Re: [DISCUSS] bprc proposal

Sent from my iPhone > On Nov 7, 2018, at 11:10 PM, Justin Mclean wrote: > > Hi, > >> brpc also includes third party code in the source tree. >> >> * https://github.com/brpc/brpc/tree/master/src/butil/third_party (BSD, MIT, >> MPL, and Public Domain) > > Being category B the MPL code may b

Re: [DISCUSS] bprc proposal

Hi, > brpc also includes third party code in the source tree. > > * https://github.com/brpc/brpc/tree/master/src/butil/third_party (BSD, MIT, > MPL, and Public Domain) Being category B the MPL code may be an issue as it probably can’t be included in a source release. [1] Thanks, Justin 1. h

Re: [DISCUSS] bprc proposal

Sure, I'm OK with that. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Thu, Nov 8, 2018 at 3:12 AM Dave Fisher wrote: > > Hi Willem, > > I’ve added the following to the proposal: > > === External Dependencies === > > brpc has the following external dependencies. > > * Google gflags (BSD)

Re: [DISCUSS] bprc proposal

Hi Willem, I’ve added the following to the proposal: === External Dependencies === brpc has the following external dependencies. * Google gflags (BSD) * Google protobuf (BSD) * Google leveldb (BSD) brpc also includes third party code in the source tree. * https://github.com/brpc/brpc/tree

Re: [DISCUSS] bprc proposal

HI, > I just have a quick look at the proposal, it looks like we need to add > more third party dependencies from the source file in the > directory[1]. You can add them but IMO not required as this will be sorted out during IP clearance and release review during graduation. Thanks, Justin

Re: [DISCUSS] bprc proposal

Hi, I just have a quick look at the proposal, it looks like we need to add more third party dependencies from the source file in the directory[1]. [1]https://github.com/brpc/brpc/tree/master/src/butil/third_party Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Sat, Nov 3, 2018 at 1:01 AM D

Re: [DISCUSS] bprc proposal

Any suggestions or comments on this proposal before I bring it to a VOTE? > On Oct 25, 2018, at 7:38 AM, Dave Fisher wrote: > > Sorry about that I missed the topic autocorrection. > > Sent from my iPhone > >> On Oct 24, 2018, at 9:15 PM, Dave Fisher > > wrote: >>

Re: [DISCUSS] bprc proposal

Sorry about that I missed the topic autocorrection. Sent from my iPhone > On Oct 24, 2018, at 9:15 PM, Dave Fisher wrote: > > Hi - > > I would like to discuss accepting bprc project into the Incubator: > Initially there were five developers from Baidu, but now these are from > several compani