Thanks everyone for suggestions and feedback, I will close this vote
thread and announce the results soon since 72 hours have passed.
Ethan Feng.
keyong zhou 于2023年3月1日周三 11:48写道：
>
> Hi Gang,
>
> Thanks for you feedback!
>
> We do keep contents of the original NOTICE file of `log4j-core-2.17.2
Hi Gang,
Thanks for you feedback!
We do keep contents of the original NOTICE file of `log4j-core-2.17.2.jar`
without [1], but separate [2] and [3] for alphabetical ordering.
We will put [2] and [3] together in future releases.
Thanks,
Keyong Zhou
[1] `This product includes software developed at
Thanks for the PR link [1].It explained the content [2] is copied from the
NOTICE of `log4j-core-2.17.2.jar`,It's right to keep it in the NOTICE file.
BTW,I suggest keep the original NOTICE file of `log4j-core-2.17.2.jar`,of
course can remove the content [3].
It might be easier to see which depen
Hi,
It looks like Spark may have incorrectly added that header. You could ask them
why it was added perhaps or just leave it as is.
Kind Regards,
Justin
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For addi
Hi Justin and Willem,
Thanks for your feedback!
The file [1] is based on Spark's file[2], we had very little modification,
and we leave the ASF header unmodified as it is[2].
We will remove the header in later releases.
Thanks,
Keyong Zhou
1.
./common/src/main/java/org/apache/celeborn/common/
@Gang
About the ResolverUtil.java Copyright occurring in the NOTICE file of the
binary release, it's a transitive dependency from log4j-core. The same
question was raised and discussed in a previous PR review [1] thus I have
the memory, JFYI.
Best Regards,
Yu
[1]
https://github.com/apache/incubat
+1 (binding)
I checked
- Files have the word incubating in their name.
- DISCLAIMER,LICENSE and NOTICE files exist.qq
- Checksums and signatures are valid.
- No unexpected binary files in the source release.
The NOTICE file under binary release contains unexpected content
`ResolverUtil.java Copyr
+1 (binding)
I checked the src kits:
- incubating in the release kit name
- The checksums and signatures are validated.
- The LICENSE and NOTICE files look good to me.
- There is a DISCLAIMER in the release kits
- No binary files in the source release kits
- I can build the source
I have the same
+1 (binding)
- Checked release file name and location: *OK*
- Checked sum and signatures: *OK*
- Checked DISCLAIMER file exists: *OK*
- Checked LICENSE and NOTICE files: *OK*
* License of 3rd-party code contained correctly mentioned in LICENSE:
*OK*
* Included dependencies are mentioned
+1 non-binding
incubating in the name
sig and checksum are valid
DISCLAIMER/LICENSE/NOTICE are fine
no unexpected binaries in the source
ASF headers on source files are fine.
Kent
On 2023/02/24 04:38:23 Justin Mclean wrote:
> Hi,
>
> +1 (binding)
>
> I checked:
> - incubating in the name
> - s
Hi,
+1 (binding)
I checked:
- incubating in the name
- signature and hashes are fine
- DISCLAIMER exists
- LICENSE and NOTICE are fine
- No unexpected binary files
- ASF headers on source files
- Can compile from source
I dislike "Copyright 2014 and onwards", but that's Spark's issue, not yours.
Hello Incubator Community,
This is a call for a vote to release Apache Celeborn(Incubating)
version 0.2.0-incubating-rc5
The Apache Celeborn community has voted on and approved a proposal to release
Apache Celeborn(Incubating) version 0.2.0-incubating-rc5
We now kindly request the Incubator PMC
12 matches
Mail list logo
