Hi Stian,
thanks for the detailed spot-on review. (comments inline).
I have created an issue to track the point you have raised (
https://github.com/apache/incubator-pulsar/issues/1337), we'll get to these
before next release.
On Fri, Mar 2, 2018 at 2:00 AM Stian Soiland-Reyes wrote:
> Oo, I'l
Hi,
The vote for releasing Apache Pulsar 1.22.0-incubating is now closed.
With a total of +5 binding votes and no -1 votes, the vote passes.
+1s (binding):
Sijie
Justin
Stian
Andrews
Jim
Thanks a lot to all the reviewers for taking the time to validate this
release!
Regards,
Jai
On Fri, Ma
+1 (binding)
> On Mar 2, 2018, at 3:17 AM, Andrews Sahaya Albert
> wrote:
>
> +1
>
> - Verified signatures
> - Ran simple producer & consumer against the binary distribution
> - Compiled the src distribution, ran unit tests and ran sample
> producer/consumer test against it
> - OS version: Mac
+1
- Verified signatures
- Ran simple producer & consumer against the binary distribution
- Compiled the src distribution, ran unit tests and ran sample
producer/consumer test against it
- OS version: MacOS 10.12.6
- I had to update "advertisedAddress=" to localhost in
conf/standalone.conf to ge
?On 25 February 2018 at 23:36, Jai Asher wrote:
> This is the fourth release candidate for Apache Pulsar, version
> 1.22.0-incubating.
>
> It fixes the following issues:
> https://github.com/apache/incubator-pulsar/milestone/11?closed=1
>
> *** Please download, test and vote by Friday, Feb 23, 201
Hi,
+1 binding
A minor issue the NOTICE year need updating.
I checked:
- incubating in name
- hashes and signatures good
- DISCLAIMER exists
- LICENSE is good
- NOTICE year is last year
- can compile from source
Thanks,
Justin
--
+1
* the distributions looks good (checked md5, sha, asc)
* test the binary distribution: standalone, run examples
* src distribution looks good: compile, unit tests, run standalone and
examples.
Verified at MacOS 10.13.1
- Sijie
On Sun, Feb 25, 2018 at 3:42 PM, Jai Asher wrote:
> Kindly ign
Kindly ignore the previous message sent on the same subject since it
contained the wrong dates.
==
This is the fourth release candidate for Apache Pulsar, version
1.22.0-incubating.
It fixes the following issues:
https://github.com/apache/incubator-pulsar/milestone/11?clos
;> -producer/consumer worked
> >>>
> >>>
> >>>
> >>>
> >>> On Fri, Feb 23, 2018 at 4:02 PM, Masahiro Sakamoto <
> >> massa...@yahoo-corp.jp
> >>> wrote:
> >>>
> >>>> +1 (binding)
> >>>>
> >>
