Agree John: we will add more explicitly the thrift binary installation
requirement in the build instructions.
Thanks !
Regards
JB
On 11/19/2016 01:55 PM, John D. Ament wrote:
JB -
I don't disagree with you. The release contents are good, but doesn't
build from source. When I asked how to b
Excellent. It’s good to know that you are striving to make things easier for
users. This will help you build the community.
In my opinion it’s OK if it’s a little harder for people verifying the release;
there are fewer people doing this.
Julian
> On Nov 19, 2016, at 1:39 PM, Liang Chen wrot
Hi Julian
Yes, based on your comment about thrift, we started one discussion about how
to facilitate Apache Thrift installation in dev mailing list:
http://apache-carbondata-mailing-list-archive.1130556.n5.nabble.com/please-vote-and-comment-remove-thrift-solution-td2253.html
Before, all users nee
Hi Jacques
Thanks for your vote.
Sure, we would improve the build instructions in the next release.
Regards
Liang
Jacques Nadeau wrote
> I didn't see the last +1 so I reviewed and also gave you a +1. Guess that
> is not needed now :P
>
> On Sat, Nov 19, 2016 at 5:33 AM, Liang Chen <
> chenlia
For what it’s worth, I ran into the same issue as John did when I validated the
0.1.1 release[1]. I put it down to my incompetence and voted +1. It would be
nice if Thrift were easier to install for idiots like me.
Julian
[1]
http://mail-archives.apache.org/mod_mbox/incubator-general/201610.mb
I didn't see the last +1 so I reviewed and also gave you a +1. Guess that
is not needed now :P
On Sat, Nov 19, 2016 at 5:33 AM, Liang Chen wrote:
> Hi
>
> Finally, this vote passed with the following result:
>
> +1 (binding) : John D. Ament,Henry Saputra,Uma Gangumalla,Jean-Baptiste
> Onofré
>
>
Built, ran tests, checked signatures.
Agree that next build shouldn't pass without clarification on build
instructions.
For this build:
+1 (binding)
On Sat, Nov 19, 2016 at 5:33 AM, Liang Chen wrote:
> Hi
>
> Thanks John.
> Definitely, we would provide the more clear build instructions.
>
>
Hi
Finally, this vote passed with the following result:
+1 (binding) : John D. Ament,Henry Saputra,Uma Gangumalla,Jean-Baptiste
Onofré
Thanks all for your vote.
Regards
Liang
Liang Chen wrote
> Hi all
>
> Finally, this vote passed with the following result:
>
> +1 (binding) : Henry Saputra
Hi
Thanks John.
Definitely, we would provide the more clear build instructions.
Regards
Liang
John D. Ament-2 wrote
> I'm changing my vote to +1 since I'm able to build from source after
> installing thrift.
>
> Going through this did point out one issue - the Thrift TLP does not
> publish val
I'm changing my vote to +1 since I'm able to build from source after
installing thrift.
Going through this did point out one issue - the Thrift TLP does not
publish valid releases. I've pinged them separately.
John
On Tue, Nov 15, 2016 at 6:50 PM John D. Ament wrote:
> Hi sorry but I'm -1 sin
JB -
I don't disagree with you. The release contents are good, but doesn't
build from source. When I asked how to build from source, I was given "mvn
clean -Pbuild-with-format install" without mention of the thrift binary
requirement. Maybe a user will already have thrift, maybe they won't. Bu
Hi John,
AFAIR, the thrift use was required for CarbonData 0.1.0-incubating
release. The 0.1.0-incubating passed with 3 +1 binding votes (Uma,
Justin, and me).
We agreed that the enforcement of the thrift dependency was not ideal,
that's why we improved the build: the "old style" build is al
I'm looking for build instructions. If the podling can provide build
instructions that can provide a binary. Right now it fails the compiles
from source requirements.
On Nov 18, 2016 21:36, "Henry Saputra" wrote:
> What is the expectation from you to satisfy your concern for the release?
>
> T
What is the expectation from you to satisfy your concern for the release?
The project needs Apache Thrift native lib to compile and you don't have
install hence compilation fail.
Could you try install ApacheThrift native lib and compile it with
appropriate flag? I believe it should work.
- Henr
Hi John
Sorry for that , thanks for your comment.
I will check it with mentors asap.
Regards
Liang
2016-11-19 9:23 GMT+08:00 John D. Ament :
> No. I voted -1. You have a +2 right now.
>
> On Nov 18, 2016 20:20, "Liang Chen" wrote:
>
> > Hi all
> >
> > Finally, this vote passed with the follo
No. I voted -1. You have a +2 right now.
On Nov 18, 2016 20:20, "Liang Chen" wrote:
> Hi all
>
> Finally, this vote passed with the following result:
>
> +1 (binding) : Henry Saputra,Uma Gangumalla,Jean-Baptiste Onofré
>
> Thanks all for your vote.
>
>
> Regards
> Liang
>
Hi all
Finally, this vote passed with the following result:
+1 (binding) : Henry Saputra,Uma Gangumalla,Jean-Baptiste Onofré
Thanks all for your vote.
Regards
Liang
+1 (binding)
As the build will be fixed after the artifacts on Central and we can still
build with thrift installed locally (as in previous releases), I don't think
it's a blocker.
Regards
JB
On Nov 14, 2016, 08:22, at 08:22, Liang Chen wrote:
>Hi Henry
>
>Yes, this problem will be solved
Hi
Thanks for your kindly clarifying, Henry.
Sure, we will add BUILD.md file in the next release under the root directory
to improve build instructions.
Regards
Liang
Henry Saputra wrote
> Thanks for the info, Liang.
>
> As John has mentioned, one way we could make it easier to build is to hav
Agree.
I think we can improve the build instructions and the build itself for the next
release, but we can move forward on this release.
Regards
JB
On Nov 17, 2016, 11:10, at 11:10, Henry Saputra wrote:
>Thanks for the info, Liang.
>
>As John has mentioned, one way we could make it easier
Thanks for the info, Liang.
As John has mentioned, one way we could make it easier to build is to have
BUILD.md file that explain how to build CarbonData properly,
Should not block this release.
- Henry
On Wed, Nov 16, 2016 at 11:58 PM, Liang Chen
wrote:
> Hi John,Henry
>
> Thanks for your co
Hi John,Henry
Thanks for your comments.
CarbonData is file format, so introduce Apache thrift for supporting
multiple languages and any language can read the file format written by
thrift.
1.For release version(like
https://dist.apache.org/repos/dist/dev/incubator/carbondata/0.2.0-incubating/),
t
I think we need to fix this properly.
I recommend to just commit the generated Java Thrift code to make sure
people could build it without waiting for Maven central push.
- Henry
On Tue, Nov 15, 2016 at 3:50 PM, John D. Ament
wrote:
> Hi sorry but I'm -1 since I cannot build it from source. W
Hi sorry but I'm -1 since I cannot build it from source. Would be ok if it
compiles and some tests fail, but this won't even compile.
Please note - -1's are not veto's if you get enough +1's to outweigh, it
will still pass. Though it would be good to if you re-roll the release to
fix this build
Disclaimer exist
LICENSE.txt exist
Signature file fine
Contains incubating
I think Readme.md file can have section about Prerequisites and point to
https://cwiki.apache.org/confluence/display/CARBONDATA/Building+CarbonData+
And+IDE+Configuration
>From Wiki
==
I
Hi Liang, Ravindran,
>From release artifacts it looks good:
Hash files look good
Signature file looks good
Disclaimer file exist
No 3rd party exes in release source artifact
+1
Should probably add in the README to install Thrift to install locally.
- Henry
On Tue, Nov 15, 2016 at 6:46 AM, Lian
Hi John D. Ament and Henry
Gentle reminder!
Could you please check again? please feel free to let me know if need to
provide more information.
BTW,building document at:
https://cwiki.apache.org/confluence/display/CARBONDATA/Building+CarbonData+And+IDE+Configuration
Regards
Liang
--
View th
Hi Henry
Yes, this problem will be solved automatically once the release is done.
After release, users can directly use the command "mvn clean install".
Only before finalizing release to repository center, need to install
thrift(0.9.3) locally for building with "mvn clean -Pbuild-with-format
insta
So, with this release, the carbondata-format module is pre-built and pushed
to maven repo so when someone run carbondata mvn install it should pull it
from central?
- Henry
On Sun, Nov 13, 2016 at 8:39 PM, ravipesala wrote:
> Hi
>
> Using the command "mvn clean install" does not build the carbo
Hi
Using the command "mvn clean install" does not build the carbondata-format
jar but it will try to get it from repository. Since release is not yet
happen it could not get dependency from repository. This problem will be
solved automatically once the release is done. There would not be any impac
Further..
[INFO] --- maven-thrift-plugin:0.1.11:compile (generate-thrift-java) @
carbondata-format ---
Downloading:
https://repo.maven.apache.org/maven2/com/google/collections/google-collections/0.8/google-collections-0.8.pom
Downloaded:
https://repo.maven.apache.org/maven2/com/google/collections/
Hi
Please use "mvn clean -Pbuild-with-format install" to run when make the 1st
compile.
Because this release remove thrift installation dependency, just add thrift
repo dependency.
dev mailinglist discussed solution:
http://apache-carbondata-mailing-list-archive.1130556.n5.nabble.com/please-vote-
Hi,
Can you please provide build instructions? It fails for me on
[ERROR] Failed to execute goal on project carbondata-core: Could not
resolve dependencies for project
org.apache.carbondata:carbondata-core:jar:0.2.0-incubating: Could not find
artifact org.apache.carbondata:carbondata-format:jar:
Hi all,
PPMC vote for the release Apache CarbonData 0.2.0-incubating has passed.
Now, we kindly submit this release to the IPMC.
Here's the PPMC vote thread for 0.2.0 release:
http://apache-carbondata-mailing-list-archive.1130556.n5.nabble.com/RESULT-VOTE-Apache-CarbonData-0-2-0-incubating-releas
34 matches
Mail list logo
