Re: [Gen-art] [Ace] Genart last call review of draft-ietf-ace-oauth-params-06

2019-12-17 Thread Ludwig Seitz
Hello Elwyn, thank you for your review. Comments inline. /Ludwig On 2019-12-14 23:46, Elwyn Davies via Datatracker wrote: Reviewer: Elwyn Davies Review result: Not Ready I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being

Re: [Gen-art] [Ace] Genart last call review of draft-ietf-ace-oauth-params-06

2019-12-21 Thread Ludwig Seitz
On 2019-12-19 21:23, elwynd wrote: Hi, Ludwig. Thanks for the prompt response. Regarding he major issue, I understand what the intention of the split was, but as far as early implementations are concerned, there is no such thing as a 'minimal breakage'; unless there is some cunning mechanism in

Re: [Gen-art] [Ace] Genart last call review of draft-ietf-ace-oauth-params-06

2019-12-22 Thread Ludwig Seitz
Hello Elwyn, I have now submitted -09 to fix the minor issues and nits, which I forgot in my -08. Comments inline. Regards, Ludwig On 2019-12-14 23:46, Elwyn Davies via Datatracker wrote: Minor issues: ss3.1, 3.2 and 4.1:  The COSE_Key type 'EC' used in several kty fields is not defined. 

Re: [Gen-art] [Ace] Genart last call review of draft-ietf-ace-oauth-params-06

2020-01-07 Thread Ludwig Seitz
On 2019-12-22 19:27, elwynd wrote: Hi, Ludwig. Having had another look at section 3.1 of draft-ietf-ace-cwt-proof-of-possession, technically the rules about which keys have to be present are not part of the syntax of the cnf claim.  The point can be covered by changing '"syntax of the 'cnf' clai