Re: [Gen-art] Genart last call review of draft-ietf-sidrops-ov-egress-01

2020-04-06 Thread Alissa Cooper
Robert, thanks for your review. All, thanks for your responses and text updates. I entered a No Objection ballot. Alissa > On Mar 13, 2020, at 11:16 AM, Robert Sparks via Datatracker > wrote: > > Reviewer: Robert Sparks > Review result: Ready > > I am the assigned Gen-ART reviewer for this

Re: [Gen-art] Genart last call review of draft-ietf-sidrops-ov-egress-01

2020-03-18 Thread Keyur Patel
On 3/18/20, 12:56 PM, "Randy Bush" wrote: ( warning: quote depth errors and top posting. keyur's mta, well let's not get into that :) > Speaking as a wg member. and one of the first ROV implementors, tyvm. > Shouldn’t you be checking the "my autonomous syste

Re: [Gen-art] Genart last call review of draft-ietf-sidrops-ov-egress-01

2020-03-18 Thread Randy Bush
( warning: quote depth errors and top posting. keyur's mta, well let's not get into that :) > Speaking as a wg member. and one of the first ROV implementors, tyvm. > Shouldn’t you be checking the "my autonomous system number" in the > update message (when sending it out to the ebgp peer) as opp

Re: [Gen-art] Genart last call review of draft-ietf-sidrops-ov-egress-01

2020-03-18 Thread Keyur Patel
Speaking as a wg member. Shouldn’t you be checking the "my autonomous system number" in the update message (when sending it out to the ebgp peer) as opposed to "my autonomous system number" in the open message. Regards, Keyur On 3/17/20, 8:27 PM, "Randy Bush" wrote: > I wanted to avoid

Re: [Gen-art] Genart last call review of draft-ietf-sidrops-ov-egress-01

2020-03-17 Thread Randy Bush
> I like that and hope it's acceptable to the community. > > But it was a very small nit - if it turns out to be problematic, I'm > ok leaving things as they were. our illustrious AD is fond of specific references to RFCs and other formal wording. :) randy _

Re: [Gen-art] Genart last call review of draft-ietf-sidrops-ov-egress-01

2020-03-17 Thread Robert Sparks
I like that and hope it's acceptable to the community. But it was a very small nit - if it turns out to be problematic, I'm ok leaving things as they were. RjS On 3/17/20 10:26 PM, Randy Bush wrote: I wanted to avoid "be able to be" and have an explicit actor. I see the difficulty you point

Re: [Gen-art] Genart last call review of draft-ietf-sidrops-ov-egress-01

2020-03-17 Thread Randy Bush
> I wanted to avoid "be able to be" and have an explicit actor. I see > the difficulty you point to below. i am happy to change to the following >> As the origin AS may be modified by outbound policy, a BGP speaker >> MUST apply ROV policy semantics using the My Autonomous System number >> in the

Re: [Gen-art] Genart last call review of draft-ietf-sidrops-ov-egress-01

2020-03-17 Thread Robert Sparks
On 3/17/20 8:34 PM, Randy Bush wrote: thanks for review robert, This sentence slowed me down when reading: As the origin AS may be modified by outbound policy, policy semantics based on RPKI Origin Validation state MUST be able to be applied separately on distribution into BGP an

Re: [Gen-art] Genart last call review of draft-ietf-sidrops-ov-egress-01

2020-03-17 Thread Randy Bush
thanks for review robert, > This sentence slowed me down when reading: > >As the origin AS may be modified by outbound policy, policy semantics >based on RPKI Origin Validation state MUST be able to be applied >separately on distribution into BGP and on egress. > > I suggest somethin