Re: [Gen-art] Review of draft-ietf-curdle-dnskey-eddsa-02 (Als was: Secdir review of draft-ietf-curdle-dnskey-eddsa-02)

2016-12-17 Thread Magnus Nyström
Same here. Thank you! /M On Fri, Dec 16, 2016 at 11:11 PM, Dan Romascanu wrote: > Thank you for addressing my comments. > > Regards, > > Dan > > > On Sat, Dec 17, 2016 at 9:01 AM, Ondřej Surý wrote: >> >> Hi all, >> >> the IETF review has ended, so I have uploaded -03 version. >> >> Magnus, Dan,

Re: [Gen-art] Review of draft-ietf-curdle-dnskey-eddsa-02 (Als was: Secdir review of draft-ietf-curdle-dnskey-eddsa-02)

2016-12-16 Thread Dan Romascanu
Thank you for addressing my comments. Regards, Dan On Sat, Dec 17, 2016 at 9:01 AM, Ondřej Surý wrote: > Hi all, > > the IETF review has ended, so I have uploaded -03 version. > > Magnus, Dan, > > the -03 version addresses all your comments. > > Tim, > > I left the irtf documents in Normative

Re: [Gen-art] Review of draft-ietf-curdle-dnskey-eddsa-02 (Als was: Secdir review of draft-ietf-curdle-dnskey-eddsa-02)

2016-12-16 Thread Ondřej Surý
Hi all, the IETF review has ended, so I have uploaded -03 version. Magnus, Dan, the -03 version addresses all your comments. Tim, I left the irtf documents in Normative as per Stephan's comments. I believe that Section 8 correctly references IANA registry: http://www.iana.org/assignments/dns-

Re: [Gen-art] Review of draft-ietf-curdle-dnskey-eddsa-02 (Als was: Secdir review of draft-ietf-curdle-dnskey-eddsa-02)

2016-12-12 Thread Dan Romascanu
Hi Ondrej, Thanks for addressing my comments. The nits can be fixed at any time you find more convenient before publication. Regards, Dan On Mon, Dec 12, 2016 at 11:38 AM, Ondřej Surý wrote: > Magnus and Dan, > > thanks for the review. > > Magnus, you are right, I have removed the first ful

Re: [Gen-art] Review of draft-ietf-curdle-dnskey-eddsa-02 (Als was: Secdir review of draft-ietf-curdle-dnskey-eddsa-02)

2016-12-12 Thread Stephen Farrell
Hi Ondřej, On 12/12/16 09:38, Ondřej Surý wrote: > I would be happy to upload next revision after Last Call > is finished or just let the RFC editors to fix it. Please do upload a new version at the end of last call with these and any other non-controversial changes. Thabks, S. smime.p7s Des

Re: [Gen-art] Review of draft-ietf-curdle-dnskey-eddsa-02 (Als was: Secdir review of draft-ietf-curdle-dnskey-eddsa-02)

2016-12-12 Thread Ondřej Surý
Magnus and Dan, thanks for the review. Magnus, you are right, I have removed the first full paragraph about "security properties" from Security Considerations from my git version as the security properties of EdDSA are better described in Normative references anyway. https://gitlab.labs.nic.cz/l

Re: [Gen-art] Review of draft-ietf-curdle-dnskey-eddsa-02

2016-12-11 Thread Daniel Migault
Thanks Dan for the review. Yours, Daniel -Original Message- From: Dan Romascanu [mailto:droma...@gmail.com] Sent: Sunday, December 11, 2016 12:21 PM To: gen-art@ietf.org Cc: draft-ietf-curdle-dnskey-eddsa@ietf.org; cur...@ietf.org; i...@ietf.org Subject: Review of draft-ietf-curdle

[Gen-art] Review of draft-ietf-curdle-dnskey-eddsa-02

2016-12-11 Thread Dan Romascanu
Reviewer: Dan Romascanu Review result: Ready with Nits Summary: Ready, with nits I am not an expert in this field, but the document seems to meet its goals, it's clear and precise Major issues: Minor issues: Nits/editorial comments: 1. Section 4: s/Section5.1.7/Sections 5.1.7/ 2. Section 8: