Re: [Gegl-developer] [PATCH 1/1] cl: Make noise-simplex kernel OpenCL 1.1 complaint

2014-06-19 Thread scl
Hi Jan, my local 'make check' tests passed and the GEGL developers had no objections, so I've committed your patch to GEGL master. Thank you for your contribution and feel free to continue your work! Greetings, Sven ___ gegl-developer-list mailing l

Re: [Gegl-developer] [PATCH 1/1] cl: Make noise-simplex kernel OpenCL 1.1 complaint

2014-06-18 Thread Daniel Sabo
This all looks "obviously correct", we've cleaned up similar things before because most OpenCL implementations will fudge around these things but some complain. I have not been involved enough with GEGL for a while to go pushing stuff; you should add massimo to your list of people to poke on IRC ab

Re: [Gegl-developer] [PATCH 1/1] cl: Make noise-simplex kernel OpenCL 1.1 complaint

2014-06-14 Thread scl
Hi, I've built it successfully on Linux Debian Testing (32 and 64 bit). For more information see also the GEGL branch wip/noise-simplex-cl-patch and https://build.gimp.org/job/gegl-noise-simplex-cl/ @Pippin, Daniel, Victor: can you please have a look on this patch? If you have no objections, the

Re: [Gegl-developer] [PATCH 1/1] cl: Make noise-simplex kernel OpenCL 1.1 complaint

2014-06-07 Thread Jan Vesely
Hi, thank you for your response. On Sat, 2014-06-07 at 22:31 +0200, scl wrote: > On 5.6.2014 at 3:09 PM Jan Vesely wrote: > > gentle ping > > > > On Sun, 2014-05-18 at 16:38 -0400, Jan Vesely wrote: > >> No static keyword, f suffix for float constants > >> Fixes one error and 7 warnings > > Hi

Re: [Gegl-developer] [PATCH 1/1] cl: Make noise-simplex kernel OpenCL 1.1 complaint

2014-06-07 Thread scl
On 5.6.2014 at 3:09 PM Jan Vesely wrote: gentle ping On Sun, 2014-05-18 at 16:38 -0400, Jan Vesely wrote: No static keyword, f suffix for float constants Fixes one error and 7 warnings Hi Jan, first of all thank you for your work! I'm more active in the GIMP project than in GEGL, but I app

Re: [Gegl-developer] [PATCH 1/1] cl: Make noise-simplex kernel OpenCL 1.1 complaint

2014-06-05 Thread Jan Vesely
gentle ping On Sun, 2014-05-18 at 16:38 -0400, Jan Vesely wrote: > No static keyword, f suffix for float constants > Fixes one error and 7 warnings > > Signed-off-by: Jan Vesely > --- > Makes the op run on mesa/clover. > > opencl/noise-simplex.cl | 14 +++--- > 1 file changed, 7 inser

[Gegl-developer] [PATCH 1/1] cl: Make noise-simplex kernel OpenCL 1.1 complaint

2014-05-18 Thread Jan Vesely
No static keyword, f suffix for float constants Fixes one error and 7 warnings Signed-off-by: Jan Vesely --- Makes the op run on mesa/clover. opencl/noise-simplex.cl | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/opencl/noise-simplex.cl b/opencl/noise-simple