DJ Delorie wrote:
> Thanks, you two, that last patch works just right!
Yes, thanks. The last thing I did before flying off to Minnesota was
whine about this bug... and while I was off enjoying Mom's cooking the
bug gets fixed. Can't beat that.
-dave
__
Thanks, you two, that last patch works just right!
Committed.
___
geda-user mailing list
geda-user@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
On 9/8/08, Robert Fitzsimons <[EMAIL PROTECTED]> wrote:
> Did you apply the patch correctly? You piece of code doesn't seem to
> show my latest changes.
No, I didn't, sorry; it does fix all.
___
geda-user mailing list
geda-user@moria.seul.org
http://
> > Here's an updated version of my patch which fixes the square pad and
> > damaged polygon issues.
>
> Actually it does not fixes "damaged polygons" very well.
Did you apply the patch correctly? You piece of code doesn't seem to
show my latest changes.
Robert
_
On 9/6/08, Robert Fitzsimons <[EMAIL PROTECTED]> wrote:
> Here's an updated version of my patch which fixes the square pad and
> damaged polygon issues.
Actually it does not fixes "damaged polygons" very well. And yes, this
issue was present before the patches. It just was not so frequent,
becaus
> Do you two want some more time to play with this, or should I commit
> now and worry later?
Here's an updated version of my patch which fixes the square pad and
damaged polygon issues.
Robert
Index: src/polygon.c
===
RCS file: /
On Fri, Sep 05, 2008 at 05:17:21PM -0400, DJ Delorie wrote:
>
> Do you two want some more time to play with this, or should I commit
> now and worry later?
Don't commit it if it breaks stuff. I'll review them this weekend. I
think I've got all the move-breaks-poly bugs fixed at the moment -- I'
I tested both patches, and Rob's has a bug - it doesn't clear square
(width == height) pads. However, both patches cause major polygon
damage (of the "have you lost your mind?" variety) if you move those
elements around; I'm not sure if this is caused by or just uncovered
by the patch (round-end
On 9/4/08, Robert Fitzsimons <[EMAIL PROTECTED]> wrote:
> Is this the same issue that I was trying to fix with this patch?
> http://archives.seul.org/geda/dev/May-2008/msg00085.html
Exactly. I think your patch just needs
- if (!(np = RectPoly (x1,x2,y1,y2)))
+ if (!(np = SquarePadPoly (pad)))
in
Is this the same issue that I was trying to fix with this patch?
http://archives.seul.org/geda/dev/May-2008/msg00085.html
Robert
On Thu, Sep 04, 2008 at 12:33:21PM +0400, Ineiev wrote:
> Hello, Dave;
> On 9/2/08, Dave N6NZ <[EMAIL PROTECTED]> wrote:
> > Clearance on rounded pads is much prettier
Hello, Dave;
On 9/2/08, Dave N6NZ <[EMAIL PROTECTED]> wrote:
> Clearance on rounded pads is much prettier, isn't it? I should probably
> switch my library over. The reason I'm using square pads is because of
> the lame path I am using to turn postscript check plots into dxf files
> for my home
DJ Delorie wrote:
> Reproduced, still broken.
OK, thanks for checking.
>
> FYI it works properly with rounded-end rotated pads, just not
> square-end rotated pads.
>
> http://www.delorie.com/pcb/rotated-clears.png
Clearance on rounded pads is much prettier, isn't it? I should probably
switch
> Probably an oversight by whoever added rotated pads. The square vs
> rounded cases are almost always different, with the same if/else
> idiom repeated in every function...
Hey, I added rotated pads! ;-)
I don't recall bumping into this then, though.
> PCB is one of the few programs I've eve
On Tue, Sep 02, 2008 at 12:51:21PM -0400, DJ Delorie wrote:
>
> Reproduced, still broken.
>
> FYI it works properly with rounded-end rotated pads, just not
> square-end rotated pads.
>
> http://www.delorie.com/pcb/rotated-clears.png
Probably an oversight by whoever added rotated pads. The squa
Reproduced, still broken.
FYI it works properly with rounded-end rotated pads, just not
square-end rotated pads.
http://www.delorie.com/pcb/rotated-clears.png
___
geda-user mailing list
geda-user@moria.seul.org
http://www.seul.org/cgi-bin/mailman/lis
15 matches
Mail list logo
