Re: [google][gcc-4_8][patch]Handle Split functions in the Function Reordering Plugin

2014-02-11 Thread Sriraman Tallam
On Tue, Feb 11, 2014 at 3:29 PM, Teresa Johnson wrote: > > On Feb 11, 2014 2:37 PM, "Sriraman Tallam" wrote: >> >> On Tue, Feb 11, 2014 at 1:32 PM, Teresa Johnson >> wrote: >> > On Mon, Feb 10, 2014 at 7:15 PM, Sriraman Tallam >> > wrote: >

Re: [google][gcc-4_8][patch]Handle Split functions in the Function Reordering Plugin

2014-02-11 Thread Sriraman Tallam
On Tue, Feb 11, 2014 at 4:39 PM, Teresa Johnson wrote: > On Tue, Feb 11, 2014 at 4:32 PM, Sriraman Tallam wrote: >> On Tue, Feb 11, 2014 at 3:29 PM, Teresa Johnson wrote: >>> >>> On Feb 11, 2014 2:37 PM, "Sriraman Tallam" wrote: >>>> >

[PATCH][target/i386] PR 61599

2014-07-07 Thread Sriraman Tallam
Hi, I have attached a patch for this bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61599. Is this alright? Thanks Sri Patch to fix PR 61599: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61599 Function int_size_in_bytes returns -1 in as the size in cases where the size of the type can var

Re: [PATCH] C++ thunk section names

2014-07-08 Thread Sriraman Tallam
names > within one comdat groups are same, perhaps it was part of the reverted patch > for AIX. I will try to get that one back in now. > > Jan >> >> Thanks, >> >> David >> >> On Thu, Jun 26, 2014 at 10:29 AM, Sriraman Tallam >> wrote: >

Re: [PATCH] C++ thunk section names

2014-07-08 Thread Sriraman Tallam
On Tue, Jul 8, 2014 at 10:38 AM, Sriraman Tallam wrote: > On Mon, Jul 7, 2014 at 11:48 AM, Jan Hubicka wrote: >> Hello, >> I apologize for taking so long to get into this patch. I ad busy time >> (wedding >> and teaching), should be back in regular schedule now.

Re: [PATCH x86_64] Optimize access to globals in "-fpie -pie" builds with copy relocations

2014-07-11 Thread Sriraman Tallam
Ping. On Thu, Jun 26, 2014 at 10:54 AM, Sriraman Tallam wrote: > Hi Uros, > >Could you please review this patch? > > Thanks > Sri > > On Fri, Jun 20, 2014 at 5:17 PM, Sriraman Tallam wrote: >> Patch Updated. >> >> Sri >> >> On Mon, Ju

Re: [PATCH] C++ thunk section names

2014-04-17 Thread Sriraman Tallam
Ping. On Wed, Feb 5, 2014 at 4:31 PM, Sriraman Tallam wrote: > Hi, > > I would like this patch reviewed and considered for commit when > Stage 1 is active again. > > Patch Description: > > A C++ thunk's section name is set to be the same as the original function&#

[google][4.7] Allow function reordering linker plugin to separate hot and cold code into different ELF segments

2012-12-14 Thread Sriraman Tallam
Hi Rong, Please review this code. This code allows the function reordering plugin to separate hot and cold code into different ELF segments. This would allow optimizations like mapping the hot code alone to huge pages. With this patch, by default, the plugin maps .text.unlikely sections i

Re: [google][4.7] Allow function reordering linker plugin to separate hot and cold code into different ELF segments

2012-12-17 Thread Sriraman Tallam
I have committed this patch. Thanks, -Sri. On Fri, Dec 14, 2012 at 4:16 PM, Rong Xu wrote: > Looks good to me for google/gcc-4_7 branch. > > Thanks, > > -Rong > > > On Fri, Dec 14, 2012 at 3:42 PM, Sriraman Tallam > wrote: >> >> Hi Rong, >> >>

Re: [PATCH] Function Multiversioning Bug, checking for function versions

2012-12-18 Thread Sriraman Tallam
Hi Diego, Thanks for the review. On Tue, Dec 18, 2012 at 8:04 AM, Diego Novillo wrote: > On 2012-11-16 14:55 , Sriraman Tallam wrote: >> >> Hi, >> >> The previous patch was incomplete because the front-end strips off >> invalid target attributes which

Re: [PATCH] Function Multiversioning Bug, checking for function versions

2012-12-26 Thread Sriraman Tallam
I committed this patch with the fix. Thanks, -Sri. On Tue, Dec 18, 2012 at 4:13 PM, Diego Novillo wrote: > On Tue, Dec 18, 2012 at 6:38 PM, Sriraman Tallam wrote: > >> The function versions are now determined purely based on the string >> value and not on DECL_FUNCTION_SPEC

Re: [PATCH] Function Multiversioning Bug, checking for function versions

2012-12-27 Thread Sriraman Tallam
+ * target.def (supports_function_versions): Fix typo. > + > 2012-12-26 Sriraman Tallam > > * doc/tm.texi.in (TARGET_OPTION_SUPPORTS_FUNCTION_VERSIONS): Document > @@ -15,12 +18,10 @@ > * (is_function_default_version): Check target strin

Re: [PATCH] Function Multiversioning Bug, checking for function versions

2013-01-02 Thread Sriraman Tallam
AM, Andreas Schwab wrote: > diff --git a/gcc/ChangeLog b/gcc/ChangeLog > index 148388d..575e03a 100644 > --- a/gcc/ChangeLog > +++ b/gcc/ChangeLog > @@ -1,4 +1,7 @@ > -<<<<<<< .mine > +2012-12-27 Andreas Schwab > + > + * target.def (suppor

Re: [PATCH] Function Multiversioning Bug, checking for function versions

2013-01-02 Thread Sriraman Tallam
On Wed, Jan 2, 2013 at 1:01 PM, Jakub Jelinek wrote: > On Wed, Jan 02, 2013 at 12:23:45PM -0800, Sriraman Tallam wrote: >> --- config/i386/i386.c (revision 194817) >> +++ config/i386/i386.c (working copy) >> @@ -29290,7 +29290,7 @@ ix86_get_function_versions_d

Re: [PATCH] Function Multiversioning Bug, checking for function versions

2013-01-02 Thread Sriraman Tallam
On Wed, Jan 2, 2013 at 1:01 PM, Jakub Jelinek wrote: > On Wed, Jan 02, 2013 at 12:23:45PM -0800, Sriraman Tallam wrote: >> --- config/i386/i386.c (revision 194817) >> +++ config/i386/i386.c (working copy) >> @@ -29290,7 +29290,7 @@ ix86_get_function_versions_d

Re: [google][4.7] Allow function reordering linker plugin to separate hot and cold code into different ELF segments

2013-01-03 Thread Sriraman Tallam
, Sriraman Tallam wrote: > I have committed this patch. > > Thanks, > -Sri. > > On Fri, Dec 14, 2012 at 4:16 PM, Rong Xu wrote: >> Looks good to me for google/gcc-4_7 branch. >> >> Thanks, >> >> -Rong >> >> >> On Fri, Dec 14, 201

Re: [google][4.7] Allow function reordering linker plugin to separate hot and cold code into different ELF segments

2013-01-04 Thread Sriraman Tallam
the option to something like: >> >> split_segment|nosplit-segment >> or split_segment=yes|no >> >> >> David >> >> On Thu, Jan 3, 2013 at 5:41 PM, Sriraman Tallam wrote: >>> Hi Rong, >>> >>> The following patch modif

Re: [google][4.7] Allow function reordering linker plugin to separate hot and cold code into different ELF segments

2013-01-04 Thread Sriraman Tallam
s invoked. The gold linker has a test case to check if the segment API actually splits segments. Thanks, -Sri. > > David > > > On Fri, Jan 4, 2013 at 2:19 PM, Sriraman Tallam wrote: >> Attached new patch. >> >> Thanks, >> -Sri. >> >> On Fri, Jan

Re: [PATCH] Multiversioning fixes (PR c++/55742, take 2)

2013-02-06 Thread Sriraman Tallam
Hi, I have attached a patch documenting Function Multiversioning and added a few more tests. I have also updated the wiki http://gcc.gnu.org/wiki/FunctionMultiVersioning. Please let me know if there are any more tests you specifically want. Please review. Thanks Sri On Wed, Jan 30, 2013 at

Re: [PATCH] Multiversioning fixes (PR c++/55742, take 2)

2013-02-07 Thread Sriraman Tallam
On Thu, Feb 7, 2013 at 6:29 AM, Jason Merrill wrote: > On 02/06/2013 08:39 PM, Sriraman Tallam wrote: >> >> +// Test to check if an error is generated when virtual functions >> +// are multiversioned. > > > This seems like a TODO, rather than something to test for.

Re: [PATCH] Multiversioning fixes (PR c++/55742, take 2)

2013-02-11 Thread Sriraman Tallam
Hi, Is this alright to commit? Thanks Sri On Thu, Feb 7, 2013 at 4:10 PM, Sriraman Tallam wrote: > On Thu, Feb 7, 2013 at 6:29 AM, Jason Merrill wrote: >> On 02/06/2013 08:39 PM, Sriraman Tallam wrote: >>> >>> +// Test to check if an error is generated when vi

Sync include/plugin-api.h with the copy in binutils

2013-02-11 Thread Sriraman Tallam
Hi, This patch was approved by Ian: http://sourceware.org/ml/binutils/2013-02/msg00136.html I have synced plugin-api.h * plugin-api.h (enum ld_plugin_level): Assign integers explicitly for all values. Index: include/plugin-api.h ==

Re: [PATCH] Multiversioning fixes (PR c++/55742, take 2)

2013-02-13 Thread Sriraman Tallam
On Wed, Feb 13, 2013 at 7:46 AM, Sriraman Tallam wrote: > > On Feb 13, 2013 1:21 AM, "Andreas Schwab" wrote: >> >> Sriraman Tallam writes: >> >> > Index: gcc/testsuite/g++.dg/ext/mv12-aux.C >> > =

Re: [PATCH] Multiversioning fixes (PR c++/55742, take 2)

2013-02-13 Thread Sriraman Tallam
On Wed, Feb 13, 2013 at 12:14 PM, Jakub Jelinek wrote: > On Wed, Feb 13, 2013 at 10:57:42AM -0800, Sriraman Tallam wrote: >> I committed a trivial patch to fix this problem. mv12-aux.C is >> auxiliary to mv12.C and should have the same test directives as >> mv12.C. >&

[google][4.7] Minor Function reordering plugin enhancements.

2013-02-13 Thread Sriraman Tallam
Hi, I have attached a patch for the reordering plugin to display appropriate error messages when incorrect options are passed or when some API is unavailable. The plugin will use the ld_plugin_message linker API to flag errors (fatal or non-fatal) when incorrect options are passed or when t

Re: [google][4.7] Minor Function reordering plugin enhancements.

2013-02-13 Thread Sriraman Tallam
stered. I will make this fatal too however. Thanks Sri > > David > > On Wed, Feb 13, 2013 at 4:19 PM, Sriraman Tallam wrote: >> Hi, >> >>I have attached a patch for the reordering plugin to display >> appropriate error messages when incorrect options

Re: [google][4.7] Minor Function reordering plugin enhancements.

2013-02-13 Thread Sriraman Tallam
Updated patch attached. Thanks Sri On Wed, Feb 13, 2013 at 4:39 PM, Sriraman Tallam wrote: > On Wed, Feb 13, 2013 at 4:32 PM, Xinliang David Li wrote: >> when split_segment is specified but the API does not exist, why not >> making it fatal ? Will it crash at some point when t

[wwwdocs] Document Runtime CPU detection builtins

2012-08-10 Thread Sriraman Tallam
Hi, I have added a release note for x86 builtins __builtin_cpu_is and __builtin_cpu_supports. They were checked in to trunk in rev. 186789. Is this ok to submit? Thanks, -Sri. Index: changes.html === RCS file: /cvs/gcc/wwwdocs/htd

Re: [wwwdocs] Document Runtime CPU detection builtins

2012-08-14 Thread Sriraman Tallam
Hi Gerald, Is this release note alright? Thanks, -Sri. On Fri, Aug 10, 2012 at 7:20 PM, Sriraman Tallam wrote: > Hi, > >I have added a release note for x86 builtins __builtin_cpu_is and > __builtin_cpu_supports. They were checked in to trunk in rev. 186789. > Is th

Re: [wwwdocs] Document Runtime CPU detection builtins

2012-08-14 Thread Sriraman Tallam
+ger...@pfiefer.com On Tue, Aug 14, 2012 at 10:51 AM, Sriraman Tallam wrote: > Hi Gerald, > >Is this release note alright? > > Thanks, > -Sri. > > On Fri, Aug 10, 2012 at 7:20 PM, Sriraman Tallam wrote: >> Hi, >> >>I have added a release

Re: [wwwdocs] Document Runtime CPU detection builtins

2012-08-20 Thread Sriraman Tallam
Ping. On Tue, Aug 14, 2012 at 11:02 AM, Sriraman Tallam wrote: > +ger...@pfiefer.com > > On Tue, Aug 14, 2012 at 10:51 AM, Sriraman Tallam wrote: >> Hi Gerald, >> >>Is this release note alright? >> >> Thanks, >> -Sri. >> >> On Fri

Re: [wwwdocs] Document Runtime CPU detection builtins

2012-08-20 Thread Sriraman Tallam
documented in extend.texi. I have attached the patch. If there are no further comments I will submit this tomorrow. Thanks, -Sri. On Mon, Aug 20, 2012 at 1:31 PM, Gerald Pfeifer wrote: > Hi Sriraman, > > On Fri, 10 Aug 2012, Sriraman Tallam wrote: >> I have added a release note f

Re: [wwwdocs] Document Runtime CPU detection builtins

2012-08-21 Thread Sriraman Tallam
/gcc/X86-Built-in-Functions.html#X86-Built-in-Functions Please note that the "_002din" is missing. This makes the link broken, did I miss anything? I verified that I submitted the right link. Thanks, -Sri. On Tue, Aug 21, 2012 at 5:41 AM, Diego Novillo wrote: > On 2012-08-20 22:41 , Sr

Sync include/plugin-api.h with src/

2012-08-24 Thread Sriraman Tallam
Hi, This patch was approved by Ian: http://sourceware.org/ml/binutils/2012-08/msg00447.html I have synced plugin-api.h with the following patch: * plugin-api.h (ld_plugin_allow_unique_segment_for_sections): New interface. (ld_plugin_unique_segment_for_sections): New in

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-09-18 Thread Sriraman Tallam
Ping. On Fri, Aug 24, 2012 at 5:34 PM, Sriraman Tallam wrote: > Hi Jason, > >I have created a new patch to use target hooks for all the > functionality and make the front-end just call the target hooks at the > appropriate places. This is more like what you suggested in a prev

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-06-14 Thread Sriraman Tallam
for function versions, along the lines of C++ thunks. Thanks, -Sri. On Mon, Jun 4, 2012 at 11:59 AM, Sriraman Tallam wrote: > Hi, > >   Attaching updated patch for function multiversioning which brings > in plenty of changes. > > * As suggested by Richard earlier, I have ma

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-06-19 Thread Sriraman Tallam
Ping. On Thu, Jun 14, 2012 at 1:13 PM, Sriraman Tallam wrote: > +cc c++ front-end maintainers > > Hi, > >   C++ Frontend maintainers, Could you please take a look at the > front-end part when you find the time? > >   Honza, your thoughts on the callgraph part? > >  

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-07-06 Thread Sriraman Tallam
On Fri, Jul 6, 2012 at 2:14 AM, Richard Guenther wrote: > > On Thu, Jun 14, 2012 at 10:13 PM, Sriraman Tallam wrote: > > +cc c++ front-end maintainers > > > > Hi, > > > >C++ Frontend maintainers, Could you please take a look at the > > front-end pa

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-07-30 Thread Sriraman Tallam
On Thu, Jul 19, 2012 at 1:39 PM, Jason Merrill wrote: > > On 07/10/2012 03:14 PM, Sriraman Tallam wrote: >> >> I am using the questions you asked previously >> to explain how I solved each of them. When working on this patch, these >> are the exact questions

[google][gcc-4.7]Revert Old CPU Runtime Detection Implementation (issue6458081)

2012-08-03 Thread Sriraman Tallam
Free Software Foundation, Inc. - Contributed by Sriraman Tallam (tmsri...@google.com) - -This file is part of GCC. - -GCC is free software; you can redistribute it and/or modify it under -the terms of the GNU General Public License as published by the Free -Software Foundation; either version 3,

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-04-27 Thread Sriraman Tallam
On Fri, Apr 27, 2012 at 6:38 AM, H.J. Lu wrote: > On Thu, Apr 26, 2012 at 10:08 PM, Sriraman Tallam wrote: >> Hi, >> >>   I have made the following changes in this new patch which is attached: >> >> * Use target attribute itself to create function versions. &g

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-04-27 Thread Sriraman Tallam
On Fri, Apr 27, 2012 at 7:38 AM, H.J. Lu wrote: > On Fri, Apr 27, 2012 at 7:35 AM, Sriraman Tallam wrote: >> On Fri, Apr 27, 2012 at 6:38 AM, H.J. Lu wrote: >>> On Thu, Apr 26, 2012 at 10:08 PM, Sriraman Tallam >>> wrote: >>>> Hi, >>>> &

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-04-27 Thread Sriraman Tallam
On Fri, Apr 27, 2012 at 8:36 AM, H.J. Lu wrote: > On Fri, Apr 27, 2012 at 7:53 AM, Sriraman Tallam wrote: >> On Fri, Apr 27, 2012 at 7:38 AM, H.J. Lu wrote: >>> On Fri, Apr 27, 2012 at 7:35 AM, Sriraman Tallam >>> wrote: >>>> On Fri, Apr 27, 2012 at 6:3

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-05-02 Thread Sriraman Tallam
On Wed, May 2, 2012 at 6:42 AM, H.J. Lu wrote: > On Tue, May 1, 2012 at 7:45 PM, Sriraman Tallam wrote: >> Hi H.J, >> >>   Done now. Patch attached. >> >> Thanks, >> -Sri. >> >> On Tue, May 1, 2012 at 5:08 PM, H.J. Lu wrote: >>> On

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-05-02 Thread Sriraman Tallam
On Wed, May 2, 2012 at 9:05 AM, H.J. Lu wrote: > On Wed, May 2, 2012 at 8:08 AM, Sriraman Tallam wrote: >> On Wed, May 2, 2012 at 6:42 AM, H.J. Lu wrote: >>> On Tue, May 1, 2012 at 7:45 PM, Sriraman Tallam wrote: >>>> Hi H.J, >>>> >>>>  

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-05-07 Thread Sriraman Tallam
On Wed, May 2, 2012 at 11:04 AM, H.J. Lu wrote: > On Wed, May 2, 2012 at 10:44 AM, Sriraman Tallam wrote: >>>>> >>>>> 1.  Since AVX > SSE4 > SSSE3 > SSE3 > SSE2 > SSE, with >>>>> foo for AVX and SSE3, on AVX processors, which fo

Re: [google][4.7]Port function reordering via linker plugin from google/gcc-4_6 branch (issue6195099)

2012-05-16 Thread Sriraman Tallam
Patch too large to be attached, rejected by gcc-patches. Please see: http://codereview.appspot.com/download/issue6195099_1.diff Thanks, -Sri. On Wed, May 16, 2012 at 6:52 PM, Sriraman Tallam wrote: > Hi, > >  This patch ports function reordering support into google/gcc-4_7 branc

Re: [google][4.7]Port function reordering via linker plugin from google/gcc-4_6 branch (issue6195099)

2012-05-17 Thread Sriraman Tallam
at 6:56 PM, Sriraman Tallam wrote: >> Patch too large to be attached, rejected by gcc-patches. Please see: >> >> http://codereview.appspot.com/download/issue6195099_1.diff >> >> Thanks, >> -Sri. >> >> On Wed, May 16, 2012 at 6:52 PM, Sriraman Tallam

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-05-25 Thread Sriraman Tallam
Hi H.J., On Fri, May 25, 2012 at 5:07 PM, H.J. Lu wrote: > On Mon, May 14, 2012 at 11:28 AM, Sriraman Tallam wrote: >> Hi H.J, >> >>   Attaching new patch with 2 test cases, mv2.C checks ISAs only and >> mv1.C checks ISAs and arches mixed. Right now, checking only

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-05-25 Thread Sriraman Tallam
On Fri, May 25, 2012 at 5:27 PM, H.J. Lu wrote: > On Fri, May 25, 2012 at 5:16 PM, Sriraman Tallam wrote: >> Hi H.J., >> >> On Fri, May 25, 2012 at 5:07 PM, H.J. Lu wrote: >>> On Mon, May 14, 2012 at 11:28 AM, Sriraman Tallam >>> wrote: >>>>

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-05-26 Thread Sriraman Tallam
On Fri, May 25, 2012 at 10:05 PM, H.J. Lu wrote: > On Fri, May 25, 2012 at 8:38 PM, Sriraman Tallam wrote: >> >> On May 25, 2012 7:15 PM, "H.J. Lu" wrote: >>> >>> >>> On May 25, 2012 6:54 PM, "Sriraman Tallam" wrote: >>> &

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-05-26 Thread Sriraman Tallam
On Sat, May 26, 2012 at 4:56 PM, H.J. Lu wrote: > On Sat, May 26, 2012 at 3:34 PM, Sriraman Tallam wrote: >> On Fri, May 25, 2012 at 10:05 PM, H.J. Lu wrote: >>> On Fri, May 25, 2012 at 8:38 PM, Sriraman Tallam >>> wrote: >>>> >>

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-05-26 Thread Sriraman Tallam
On Sat, May 26, 2012 at 7:06 PM, H.J. Lu wrote: > On Sat, May 26, 2012 at 5:23 PM, Sriraman Tallam wrote: >> On Sat, May 26, 2012 at 4:56 PM, H.J. Lu wrote: >>> On Sat, May 26, 2012 at 3:34 PM, Sriraman Tallam >>> wrote: >>>> On Fri, May 25, 2012 at 10:0

Re: Support for Runtime CPU type detection via builtins (issue5754058)

2012-06-05 Thread Sriraman Tallam
PM, Sriraman Tallam wrote: > Patch committed. > > Thanks, > -Sri. > > On Wed, Apr 25, 2012 at 4:52 PM, H.J. Lu wrote: >> On Wed, Apr 25, 2012 at 4:38 PM, Sriraman Tallam wrote: >>> Hi H.J, >>> >>>   Could you please review this patch for AVX2

Re: Support for Runtime CPU type detection via builtins (issue5754058)

2012-06-11 Thread Sriraman Tallam
On Wed, Jun 6, 2012 at 6:52 AM, H.J. Lu wrote: > On Tue, Jun 5, 2012 at 3:00 PM, Sriraman Tallam wrote: >> Hi H.J., >> >> I am attaching a patch to add __cpu_indicator_init to the list of >> symbols to be versioned and exported in libgcc_s.so. Also, updating

Re: [google] New linker plugin to do function reordering in the final binary using callgraph profiles (issue4802070)

2011-08-02 Thread Sriraman Tallam
Hi, This patch adds a new linker plugin to re-order functions. The plugin constructs an annotated callgraph with edge profile information and then repeatedly groups sections that are connected by hot edges and passes the new function layout to the linker. The grouping is done similar to the P

[4.7][google]Support for getting CPU type and feature information at run-time. (issue4893046)

2011-08-16 Thread Sriraman Tallam
--- libgcc/config/i386/i386-cpuinfo.c (revision 0) +++ libgcc/config/i386/i386-cpuinfo.c (revision 0) @@ -0,0 +1,275 @@ +/* Copyright (C) 2011 Free Software Foundation, Inc. + * Contributed by Sriraman Tallam . + * + * This file is free software; you can redistrib

Re: [4.7][google]Support for getting CPU type and feature information at run-time. (issue4893046)

2011-08-16 Thread Sriraman Tallam
On Tue, Aug 16, 2011 at 2:06 PM, H.J. Lu wrote: > On Tue, Aug 16, 2011 at 1:50 PM, Sriraman Tallam wrote: >> Support for getting CPU type and feature information at run-time. >> >> The following patch provides support for finding the platform type at >> run-time,

Re: [4.7][google]Support for getting CPU type and feature information at run-time. (issue4893046)

2011-08-16 Thread Sriraman Tallam
On Tue, Aug 16, 2011 at 3:35 PM, Joseph S. Myers wrote: > On Tue, 16 Aug 2011, Sriraman Tallam wrote: > >> Index: libgcc/config/i386/t-cpuinfo >> === >> --- libgcc/config/i386/t-cpuinfo      (revision 0) >

Re: [4.7][google]Support for getting CPU type and feature information at run-time. (issue4893046)

2011-08-17 Thread Sriraman Tallam
On Wed, Aug 17, 2011 at 12:37 AM, Richard Guenther wrote: > On Tue, Aug 16, 2011 at 10:50 PM, Sriraman Tallam wrote: >> Support for getting CPU type and feature information at run-time. >> >> The following patch provides support for finding the platform type at >>

Re: [4.7][google]Support for getting CPU type and feature information at run-time. (issue4893046)

2011-08-17 Thread Sriraman Tallam
On Wed, Aug 17, 2011 at 4:59 PM, Hans-Peter Nilsson wrote: > On Tue, 16 Aug 2011, Sriraman Tallam wrote: > > (I don't see anyone else making this comment, so maybe I missed > something obvious, but I don't think so...) > >> Support for getting CPU type and

Re: [4.7][google]Support for getting CPU type and feature information at run-time. (issue4893046)

2011-08-18 Thread Sriraman Tallam
On Thu, Aug 18, 2011 at 1:03 AM, Richard Guenther wrote: > On Wed, Aug 17, 2011 at 7:54 PM, Sriraman Tallam wrote: >> On Wed, Aug 17, 2011 at 12:37 AM, Richard Guenther >> wrote: >>> On Tue, Aug 16, 2011 at 10:50 PM, Sriraman Tallam >>> wrote: >>>

Re: [4.7][google]Support for getting CPU type and feature information at run-time. (issue4893046)

2011-08-18 Thread Sriraman Tallam
On Thu, Aug 18, 2011 at 2:15 PM, Richard Henderson wrote: > On 08/18/2011 10:25 AM, Sriraman Tallam wrote: >> Ok, so two things. I create the constructor as a comdat. So, it is >> created by gcc in every module but at link time only one copy will be >> kept. So, it is going t

Re: [4.7][google]Support for getting CPU type and feature information at run-time. (issue4893046)

2011-08-22 Thread Sriraman Tallam
On Mon, Aug 22, 2011 at 9:02 AM, H.J. Lu wrote: > On Mon, Aug 22, 2011 at 8:56 AM, Michael Matz wrote: >> Hi, >> >> On Mon, 22 Aug 2011, H.J. Lu wrote: >> >>> >> Oh, I thought it was data initialized by the constructor ... >>> > >>> > Sriramans patch right now has a function __cpu_indicator_init

Re: [4.7][google]Support for getting CPU type and feature information at run-time. (issue4893046)

2011-08-22 Thread Sriraman Tallam
On Mon, Aug 22, 2011 at 11:58 AM, H.J. Lu wrote: > On Mon, Aug 22, 2011 at 11:50 AM, Sriraman Tallam wrote: >> On Mon, Aug 22, 2011 at 9:02 AM, H.J. Lu wrote: >>> On Mon, Aug 22, 2011 at 8:56 AM, Michael Matz wrote: >>>> Hi, >>>> >>>> O

Re: [4.7][google]Support for getting CPU type and feature information at run-time. (issue4893046)

2011-08-25 Thread Sriraman Tallam
=== --- libgcc/config/i386/i386-cpuinfo.c (revision 0) +++ libgcc/config/i386/i386-cpuinfo.c (revision 0) @@ -0,0 +1,245 @@ +/* Get CPU type and Features for x86 processors. + Copyright (C) 2011 Free Software Foundation, Inc. + Contributed by Srirama

Re: [4.7][google]Support for getting CPU type and feature information at run-time. (issue4893046)

2011-08-26 Thread Sriraman Tallam
On Thu, Aug 25, 2011 at 6:02 PM, H.J. Lu wrote: > On Thu, Aug 25, 2011 at 5:37 PM, Sriraman Tallam wrote: >> Hi, >> >>  Thanks for all the comments. I am attaching a new patch >> incorporating all of the changes mentioned, mainly : >> >> 1) Make __cpu_ind

Re: [4.7][google]Support for getting CPU type and feature information at run-time. (issue4893046)

2011-08-26 Thread Sriraman Tallam
On Fri, Aug 26, 2011 at 10:10 AM, H.J. Lu wrote: > On Fri, Aug 26, 2011 at 10:06 AM, Sriraman Tallam wrote: >> On Thu, Aug 25, 2011 at 6:02 PM, H.J. Lu wrote: >>> On Thu, Aug 25, 2011 at 5:37 PM, Sriraman Tallam >>> wrote: >>>> Hi, >>>> >

Re: [4.7][google]Support for getting CPU type and feature information at run-time. (issue4893046)

2011-08-26 Thread Sriraman Tallam
On Fri, Aug 26, 2011 at 10:24 AM, H.J. Lu wrote: > On Fri, Aug 26, 2011 at 10:17 AM, Sriraman Tallam wrote: >> On Fri, Aug 26, 2011 at 10:10 AM, H.J. Lu wrote: >>> On Fri, Aug 26, 2011 at 10:06 AM, Sriraman Tallam >>> wrote: >>>> On Thu, Aug 25, 2011 a

Re: [4.7][google]Support for getting CPU type and feature information at run-time. (issue4893046)

2011-08-26 Thread Sriraman Tallam
On Fri, Aug 26, 2011 at 10:45 AM, H.J. Lu wrote: > On Fri, Aug 26, 2011 at 10:37 AM, Sriraman Tallam wrote: >> On Fri, Aug 26, 2011 at 10:24 AM, H.J. Lu wrote: >>> On Fri, Aug 26, 2011 at 10:17 AM, Sriraman Tallam >>> wrote: >>>> On Fri, Aug 26, 2011 at

Re: [4.7][google]Support for getting CPU type and feature information at run-time. (issue4893046)

2011-09-01 Thread Sriraman Tallam
Thanks, -Sri. > > thanks, > > David > > On Thu, Aug 25, 2011 at 5:37 PM, Sriraman Tallam wrote: >> Hi, >> >>  Thanks for all the comments. I am attaching a new patch >> incorporating all of the changes mentioned, mainly : >> >> 1) Make __cpu_ind

[google][main]Fix broken test cases in google/main branch (issue4961065)

2011-09-06 Thread Sriraman Tallam
This patches fixes bugs that caused the multi-version tests to fail. * mversn-dispatch.c (specialize_call): Rebuild cgraph edges after specialization. (clone_and_dispatch_function): Rebuild cgraph edges to compute inline parameters. (do_convert_builtin_dispa

Preserve callee cgraph edges when callgraph profiles sections are requested. (issue5101042)

2011-09-22 Thread Sriraman Tallam
This patch preserves cgraph callee edges till pass_final if callgraph edge profiles sections are requested. It also renames callgraph edge profile sections to be .gnu.callgraph instead of .note.callgraph Index: cgraphbuild.c === ---

Re: Preserve callee cgraph edges when callgraph profiles sections are requested. (issue5101042)

2011-09-22 Thread Sriraman Tallam
(gate_all_optimizations): Set cgraph_callee_edges_final_cleanup to true. (cgraph_callee_edges_final_cleanup): New global variable. * g++.dg/tree-prof/callgraph-profiles.C: New test. On Thu, Sep 22, 2011 at 4:01 PM, Sriraman Tallam wrote: > This patch preserves cgraph callee edges t

[google] Linker plugin to do function reordering using callgraph edge profiles (issue5124041)

2011-09-23 Thread Sriraman Tallam
ing_plugin/callgraph.h (revision 0) +++ function_reordering_plugin/callgraph.h (revision 0) @@ -0,0 +1,257 @@ +/* Callgraph implementation. + Copyright (C) 2011 Free Software Foundation, Inc. + Contributed by Sriraman Tallam (tmsri...@google.com). + +This program is free software; you can

[google] Add SECTION_EXCLUDE flag and exclude .gnu.callgraph sections (issue5126041)

2011-09-23 Thread Sriraman Tallam
This patch adds a new flag to mark sections as exclude sections. Such sections will be discarded by the linker. Also, mark .gnu.callgraph sections which store the callgraph edge profile info as exclude sections. I also want the SECTION_EXCLUDE part alone to be considered for trunk. Index: final

Re: [google] Linker plugin to do function reordering using callgraph edge profiles (issue5124041)

2011-09-26 Thread Sriraman Tallam
On Mon, Sep 26, 2011 at 9:22 AM, Nathan Froyd wrote: > On 9/23/2011 6:03 PM, Sriraman Tallam wrote: >> >> This patch adds a new linker plugin to re-order functions. > > This is great stuff.  We were experimenting with using the coverage files to > generate an ordering for

[PATCH] Add SECTION_EXCLUDE to list of section flags

2011-09-26 Thread Sriraman Tallam
Hi, Here is a simple patch to add SECTION_EXCLUDE to the list of section flag macros. Is this ok for trunk? Thanks, -Sri. * output.h (SECTION_EXCLUDE): New macro. * varasm.c (default_elf_asm_named_section): Check for SECTION_EXCLUDE. Index: gcc/varasm.c =

Re: [google] Linker plugin to do function reordering using callgraph edge profiles (issue5124041)

2011-09-26 Thread Sriraman Tallam
*Resending as plain text* I am attaching a patch of the updated files. This patch was meant for the google gcc-4_6 branch. Sorry for not mentioning this upfront in my original mail. Thanks, -Sri. > On Mon, Sep 26, 2011 at 9:53 AM, Sriraman Tallam wrote: >> >> On Mon, Sep 26,

Re: [PATCH] Add SECTION_EXCLUDE to list of section flags

2011-09-27 Thread Sriraman Tallam
Submitted to trunk after approval from Richard : http://gcc.gnu.org/ml/gcc-patches/2011-09/msg01747.html Thanks, -Sri. On Mon, Sep 26, 2011 at 2:09 PM, Sriraman Tallam wrote: > Hi, > >   Here is a simple patch to add SECTION_EXCLUDE to the list of > section flag macros. Is this

Re: [google] Add SECTION_EXCLUDE flag and exclude .gnu.callgraph sections (issue5126041)

2011-09-27 Thread Sriraman Tallam
Submitted the SECTION_EXCLUDE part to trunk. Thanks, -Sri. On Tue, Sep 27, 2011 at 10:51 AM, Kai Tietz wrote: > > 2011/9/27 Richard Henderson : > > On 09/23/2011 04:45 PM, Sriraman Tallam wrote: > >> I also want the SECTION_EXCLUDE part alone to be considered for trunk. &

Re: [google] Add SECTION_EXCLUDE flag and exclude .gnu.callgraph sections (issue5126041)

2011-09-27 Thread Sriraman Tallam
I committed the patch to google/gcc-4_6 branch. Thanks, -Sri. * output.h (SECTION_EXCLUDE): New flag for exclude sections. * varasm.c (default_elf_asm_named_section): Add "e" to section flags marked as SECTION_EXCLUDE. * final.c (rest_of_handle_final): Exclude .gn

Re: [google] Linker plugin to do function reordering using callgraph edge profiles (issue5124041)

2011-09-27 Thread Sriraman Tallam
.c     (revision 0) > +++ function_reordering_plugin/function_reordering_plugin.c     (revision 0) > > +          parse_callgraph_section_contents (section_contents, > (unsigned int)length); > +        } > +      else if (name != NULL) > +        free (name); > > name shoul

[google]Make test callgraph-profiles.C run only when section attribute e is supported (issue5167045)

2011-09-30 Thread Sriraman Tallam
Disable running of callgraph-profiles.C is section attribute "e" is not supported. Index: lib/target-supports-dg.exp === --- lib/target-supports-dg.exp (revision 179400) +++ lib/target-supports-dg.exp (working copy) @@ -100,6 +100,

Re: [google]Make test callgraph-profiles.C run only when section attribute e is supported (issue5167045)

2011-09-30 Thread Sriraman Tallam
, 2011 at 1:44 PM, Sriraman Tallam wrote: > Disable running of callgraph-profiles.C is section attribute "e" is not > supported. > > Index: lib/target-supports-dg.exp > === > --- lib/target-supports-dg.exp

Re: [google]Make test callgraph-profiles.C run only when section attribute e is supported (issue5167045)

2011-09-30 Thread Sriraman Tallam
On Fri, Sep 30, 2011 at 1:48 PM, Diego Novillo wrote: > On 11-09-30 16:44 , Sriraman Tallam wrote: >> >> Disable running of callgraph-profiles.C is section attribute "e" is not >> supported. > > OK with a ChangeLog entry. > > Was the original patch sen

Re: [google]Make test callgraph-profiles.C run only when section attribute e is supported (issue5167045)

2011-09-30 Thread Sriraman Tallam
On Fri, Sep 30, 2011 at 1:51 PM, Diego Novillo wrote: > On 11-09-30 16:50 , Sriraman Tallam wrote: >> >> ChangeLog entry: >> >> >>        * testsuite/g++.dg/tree-prof/callgraph-profiles/C:      Add >> dg-require-section-exclude.     * testsuite/lib/target

[google] Specify target as ix86 or x86_64 for test builtin_target.c (issue5174041)

2011-09-30 Thread Sriraman Tallam
* testsuite/gcc.dg/builtin_target.c: Specify target as ix86 or x86_64. Index: gcc.dg/builtin_target.c === --- gcc.dg/builtin_target.c (revision 179400) +++ gcc.dg/builtin_target.c (working copy) @@ -1,6 +1,6 @@

Re: [google] Specify target as ix86 or x86_64 for test builtin_target.c (issue5174041)

2011-09-30 Thread Sriraman Tallam
This is now submitted. Thanks, -Sri. On Fri, Sep 30, 2011 at 2:09 PM, Sriraman Tallam wrote: >        * testsuite/gcc.dg/builtin_target.c: Specify target as ix86 or >        x86_64. > > Index: gcc.dg/buil

Re: [google] Specify target as ix86 or x86_64 for test builtin_target.c (issue5174041)

2011-09-30 Thread Sriraman Tallam
Moving test gcc.target/i386 * testsuite/gcc.dg/builtin_target.c: Remove. * testsuite/gcc.target/i386/builtin_target.c: New file. On Fri, Sep 30, 2011 at 2:33 PM, Richard Henderson wrote: > On 09/30/2011 02:09 PM, Sriraman Tallam wrote: >>       * testsui

Swap SECTION_EXCLUDE and SECTION_MACH_D

2012-03-09 Thread Sriraman Tallam

Re: Swap SECTION_EXCLUDE and SECTION_MACH_DEP

2012-03-09 Thread Sriraman Tallam
0x400 /* subsequent bits reserved for target */ Ok to submit? Thanks. -Sri. On Fri, Mar 9, 2012 at 3:07 PM, Sriraman Tallam wrote: >

Re: Swap SECTION_EXCLUDE and SECTION_MACH_DEP

2012-03-12 Thread Sriraman Tallam
Hi Richard, Is this ok for trunk? Asking you because you approved the patch the first time around. Thanks, -Sri. On Fri, Mar 9, 2012 at 3:10 PM, Sriraman Tallam wrote: > Please see: > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52545 > > SECTION_EXCLUDE should not take up bits

Re: Swap SECTION_EXCLUDE and SECTION_MACH_DEP

2012-03-12 Thread Sriraman Tallam
Already submitted by gjl in rev. 185259. -Sri. On Mon, Mar 12, 2012 at 10:27 AM, Richard Henderson wrote: > On 03/12/12 10:26, Sriraman Tallam wrote: >> Hi Richard, >> >>   Is this ok for trunk? Asking you because you approved the patch the >> first time around. >

[google][4.6]Make option -freorder-functions= invoke function reordering linker plugin (issue5825054)

2012-03-14 Thread Sriraman Tallam
f (!is_api_exist) -return LDPS_OK; + /* Plugin APIs are supported if this is called. */ + assert (is_api_exist); if (is_callgraph_empty ()) return LDPS_OK; Index: function_reordering_plugin/ChangeLog.google-4_6 === --- function_reordering_plugin/ChangeLog.google-4_6 (revisi

Re: [google][4.6]Make option -freorder-functions= invoke function reordering linker plugin (issue5825054)

2012-03-14 Thread Sriraman Tallam
On Wed, Mar 14, 2012 at 1:56 PM, Sriraman Tallam wrote: > This patch overloads GCC option -freorder-functions with -freoder-functions=* > which will invoke the linker plugin libfunction_reordering_plugin.so. For > now, the only accepted option is -freoder-functions=cgedge,

[google][4.6]Make option -freorder-functions= invoke function reordering linker plugin (issue5825054)

2012-03-14 Thread Sriraman Tallam
Made the following changes: * -ffunction-sections turned on with -freorder-functions= * Change name from cgedge to callgraph. * The plugin should not dump final layout to file by default. * cgraphbuild.c (remove_cgraph_callee_edges): Replace flag_callgraph_profiles_sections with

Re: [google][4.6]Make option -freorder-functions= invoke function reordering linker plugin (issue5825054)

2012-03-14 Thread Sriraman Tallam
On Wed, Mar 14, 2012 at 6:56 PM, Sriraman Tallam wrote: > Made the following changes: > > * -ffunction-sections turned on with -freorder-functions= > * Change name from cgedge to callgraph. > * The plugin should not dump final layout to file by default. > > >

Re: [google][4.6]Make option -freorder-functions= invoke function reordering linker plugin (issue 5825054)

2012-03-18 Thread Sriraman Tallam
Updated doc/invoke.texi and submitted. Thanks, -Sri. On Sat, Mar 17, 2012 at 11:58 PM, wrote: > > Ok for google branches after updating the doc/invoke.texi file. > > David > > > http://codereview.appspot.com/5825054/

[google][4.6] Bug fixes to function reordering linker plugin to handle local and comdat functions. (issue5851044)

2012-03-20 Thread Sriraman Tallam
=== --- callgraph.h (revision 185543) +++ callgraph.h (working copy) @@ -1,6 +1,7 @@ /* Callgraph implementation. Copyright (C) 2011 Free Software Foundation, Inc. - Contributed by Sriraman Tallam (tmsri...@google.com). + Contributed by Sriraman Tallam (tmsri...@google.com) + and

<    1   2   3   4   >