[PATCH] PR69329 --with-build-config=bootstrap-asan fails because LSAN_OPTIONS is not honored

2016-01-24 Thread Mikhail Maltsev
bootstrap-asan". OK for trunk? -- Regards, Mikhail Maltsev ChangeLog: 2016-01-24 Mikhail Maltsev PR bootstrap/69329 * Makefile.in: Regenerate. * Makefile.tpl (BASE_FLAGS_TO_PASS): Add LSAN_OPTIONS. diff --git a/Makefile.in b/Makefile.in index 2733c4d..20d1c90

[PATCH, RFC]. Some initial work on coroutines

2016-03-06 Thread Mikhail Maltsev
when should we build "co_await p.yield_value(e)" from it and further expand co_await? -- Regards, Mikhail Maltsev diff --git a/.gitignore b/.gitignore index c9a6158..4595d5e 100644 --- a/.gitignore +++ b/.gitignore @@ -37,6 +37,9 @@ TAGS.sub .clang-format +.agignore +.ycm_extra_

Re: [PATCH 3/7] Fix trinary op

2015-07-09 Thread Mikhail Maltsev
NGLER macro to cp-demangle.c (it already contains a comment for other similar macros) and replaced __builtin_abort() with abort(). For some reason I thought that it might need an additional #include, but in reality libiberty (and the demangler too) already use abort(). The changelog is also atta

Re: [PATCH 3/7] Fix trinary op

2015-07-12 Thread Mikhail Maltsev
On 07/10/2015 11:44 PM, Jeff Law wrote: > > OK after regression testing. > > jeff > Bootstrapped and regtested on x86_64-unknown-linux-gnu. Applied as r225727. -- Regards, Mikhail Maltsev

Re: [C/C++ PATCH] PR c++/66572. Fix Wlogical-op false positive

2015-07-15 Thread Mikhail Maltsev
On 07/14/2015 07:38 PM, Marek Polacek wrote: > Ok, in that case I think easiest would the following (I hit the same issue > when writing the -Wtautological-compare patch): Thanks for taking care of this issue. -- Regards, Mikhail Maltsev

[PATCH] Fix partial template specialization syntax in wide-int.h

2015-07-17 Thread Mikhail Maltsev
ed on x86_64-linux. OK for trunk? -- Regards, Mikhail Maltsev diff --git a/gcc/wide-int.h b/gcc/wide-int.h index d8f7b46..6e0275f 100644 --- a/gcc/wide-int.h +++ b/gcc/wide-int.h @@ -360,21 +360,18 @@ namespace wi inputs. Note that CONST_PRECISION and VAR_PRECISION cannot be

Re: [PATCH] Fix partial template specialization syntax in wide-int.h

2015-07-20 Thread Mikhail Maltsev
On 07/17/2015 07:46 PM, Mike Stump wrote: > On Jul 17, 2015, at 2:28 AM, Mikhail Maltsev wrote: >> The following code (reduced from wide-int.h) is rejected by Intel C++ >> Compiler (EDG-based): > > So, could you test this with the top of the tree compiler and file a bug >

[PATCH] Use single shared memory block pool for all pool allocators

2015-07-26 Thread Mikhail Maltsev
pools inside gcc::context. Eventually this will be needed for multi-threaded compilation in GCCJIT (is it planned?). 6. Use ASAN poisoning in pool allocators. Add red zones between allocated objects when GCC is configured to use ASAN checks. gcc/ChangeLog: 2015-07-26 Mikhail Maltsev

Re: [PATCH] Use single shared memory block pool for all pool allocators

2015-08-03 Thread Mikhail Maltsev
; sounds like a good idea. Maybe still allow pools to use their own backing if > the object size is larger than the block size of the caching pool? Yes, I though about it, but I hesitated, whether this should be implemented in advance. I attached the updated patch. -- Regards, Mikhail M

Re: [PATCH] [ping] Use single shared memory block pool for all pool allocators

2015-09-15 Thread Mikhail Maltsev
the OS (i.e. write wrappers of mmap/VirtualAlloc) to these files. Of course right now memory-block makes much more sense. > > I think the patch is ok with the above correctness fix and whatever > choice you take > for the bikeshedding. Also fixing Richards review comments, of course.

[PATCH][PING][C++] Fix PR67333

2015-09-15 Thread Mikhail Maltsev
Ping. On 08/27/2015 09:27 PM, Mikhail Maltsev wrote: > Hi. > This patch fixes a rejects-valid bug related to volatile-qualified arguments > of > constexpr functions. This is essentially a one-line change in constexpr.c. > Bootstrapped and regtested on x86_64-pc-linux-gnu. OK for

Re: [PATCH] Update ENABLE_CHECKING to make it usable in "if" conditions

2015-09-16 Thread Mikhail Maltsev
On 09/10/2015 12:07 AM, Jeff Law wrote: >> On Mon, Aug 31, 2015 at 7:49 AM, Mikhail Maltsev >>> In lra.c we have: >>> >>> #ifdef ENABLE_CHECKING >>> >>> /* Function checks RTL for correctness. If FINAL_P is true, it is >>>

[PATCH][committed][PR middle-end/67649] Fix use of valgrind API

2015-09-22 Thread Mikhail Maltsev
disappear during RT libraries build) with valgrind checks on x86_64-linux. Markus also helped with valgrind test on ppc64le-linux. Committed as obvious, r228033. 2015-09-23 Mikhail Maltsev PR middle-end/67649 * memory-block.h (memory_block_pool::allocate): Use valgrind API to

[PATCH 1/9] ENABLE_CHECKING refactoring

2015-10-05 Thread Mikhail Maltsev
es mentioned above) on x86_64-linux. I'll also run it through config-list.mk. -- Regards, Mikhail Maltsev gcc/ChangeLog: 2015-10-05 Mikhail Maltsev * common.opt: Add flag_checking. * system.h (CHECKING_P): Define. libcpp/ChangeLog: 201

Re: [PATCH 2/9] ENABLE_CHECKING refactoring: libcpp

2015-10-05 Thread Mikhail Maltsev
libcpp/ChangeLog: 2015-10-05 Mikhail Maltsev * include/line-map.h: Fix use of ENABLE_CHECKING. * init.c: Likewise. * macro.c (struct macro_arg_token_iter, set_arg_token, macro_arg_token_iter_init, macro_arg_token_iter_forward

[PATCH 3/9] ENABLE_CHECKING refactoring: Java and Ada

2015-10-05 Thread Mikhail Maltsev
gcc/java/ChangeLog: 2015-10-05 Mikhail Maltsev * decl.c (java_mark_decl_local): Use flag_checking instead of ENABLE_CHECKING. gcc/ada/ChangeLog: 2015-10-05 Mikhail Maltsev * gcc-interface/decl.c (gnat_to_gnu_entity): Use gcc_checking_assert. * gcc

[PATCH 4/9] ENABLE_CHECKING refactoring: Fortran

2015-10-05 Thread Mikhail Maltsev
gcc/fortran/ChangeLog: 2015-10-05 Mikhail Maltsev * trans-common.c (create_common): Adjust to use flag_checking. * trans.c (gfc_add_modify_loc): Use gcc_checking_assert. >From 8113b4d5bc943772145abdd6562d4af6093d9718 Mon Sep 17 00:00:00 2001 From: Mikhail Maltsev Date:

Re: [PATCH 5/9] ENABLE_CHECKING refactoring: pool allocators

2015-10-05 Thread Mikhail Maltsev
gcc/ChangeLog: 2015-10-05 Mikhail Maltsev * alloc-pool.h (base_pool_allocator::initialize, ::allocate, ::remove): Adjust to use CHECKING_P. >From ed727b2279dd36e2fbf1ab6956270cbd487b1a01 Mon Sep 17 00:00:00 2001 From: Mikhail Maltsev Date: Sun, 4 Oct 2015 22:50:40 +0

[PATCH 6/9] ENABLE_CHECKING refactoring: generators

2015-10-05 Thread Mikhail Maltsev
gcc/ChangeLog: 2015-10-05 Mikhail Maltsev * genautomata.c: Use CHECKING_P instead of ENABLE_CHECKING. * genconditions.c: Define CHECKING_P in generated code. * genextract.c: Use CHECKING_P instead of ENABLE_CHECKING. * gengtype.c (main): Likewise

Re: [PATCH 7/9] ENABLE_CHECKING refactoring: middle-end, LTO FE

2015-10-05 Thread Mikhail Maltsev
gcc/ChangeLog: 2015-10-05 Mikhail Maltsev * attribs.c (check_attribute_tables): Define new function. (init_attributes): Use it. * cfgcleanup.c (try_optimize_cfg): Use flag_checking. * cfgexpand.c (expand_goto, expand_debug_expr): Likewise. (pass_expand

[PATCH 8/9] ENABLE_CHECKING refactoring: target-specific parts

2015-10-05 Thread Mikhail Maltsev
gcc/ChangeLog: 2015-10-05 Mikhail Maltsev * config/alpha/alpha.c (alpha_function_arg): Use gcc_checking_assert. * config/arm/arm.c (arm_unwind_emit_sequence): Adjust to use CHECKING_P. * config/bfin/bfin.c (hwloop_optimize): Likewise. * config/i386/i386.c

[PATCH][PING^2][C++] Fix PR67333

2015-10-05 Thread Mikhail Maltsev
PING. On 08/27/2015 09:27 PM, Mikhail Maltsev wrote: > Hi. > This patch fixes a rejects-valid bug related to volatile-qualified arguments > of > constexpr functions. This is essentially a one-line change in constexpr.c. > Bootstrapped and regtested on x86_64-pc-linux-gnu. OK for

Re: [PATCH][C++] Fix PR67333

2015-10-17 Thread Mikhail Maltsev
On 10/06/2015 04:46 PM, Jason Merrill wrote: > Hi, sorry for the slow response. Please feel free to ping once a week. > > On 08/27/2015 02:27 PM, Mikhail Maltsev wrote: >> + if (TREE_THIS_VOLATILE (t) && (!DECL_P (t) || want_rval)) > > Why the !DECL_P check

Re: [PATCH 1/9] ENABLE_CHECKING refactoring

2015-10-17 Thread Mikhail Maltsev
P.S. I am planning to post at least some of the other updated parts today, and I also hope to get in time with the whole series (before stage1 ends). -- Regards, Mikhail Maltsev gcc/ChangeLog: 2015-10-18 Mikhail Maltsev * config.in: Regenerate. * configure

[PATCH, committed] PR other/65800. Fix crash in gengtype's internal debug debug dump

2015-10-18 Thread Mikhail Maltsev
ects gengtype's internal debugging option (and is also rather small), I think it's OK to commit it without approve (as obvious). Bootstrapped and regtested on x86_64-pc-linux-gnu. -- Regards, Mikhail Maltsev gcc/ChangeLog: 2015-10-18 Mikhail Maltsev PR other/65800

Re: [PATCH 6/9] ENABLE_CHECKING refactoring: generators

2015-10-18 Thread Mikhail Maltsev
genextract, and always enable debugging functions in gengtype. -- Regards, Mikhail Maltsev gcc/ChangeLog: 2015-10-19 Mikhail Maltsev * genautomata.c: Use CHECKING_P instead of ENABLE_CHECKING. * genconditions.c: Define CHECKING_P in the generated code. * ge

Re: [PATCH 5/9] ENABLE_CHECKING refactoring: pool allocators

2015-10-18 Thread Mikhail Maltsev
On 10/06/2015 03:45 PM, Richard Biener wrote: > On Tue, Oct 6, 2015 at 2:41 PM, Bernd Schmidt wrote: >> On 10/06/2015 01:32 AM, Mikhail Maltsev wrote: >>> >>> gcc/ChangeLog: >>> >>> 2015-10-05 Mikhail Maltsev >>> >>>

Re: [PATCH 7/9] ENABLE_CHECKING refactoring: middle-end, LTO FE

2015-10-18 Thread Mikhail Maltsev
On 10/06/2015 03:59 PM, Richard Biener wrote: > On Tue, Oct 6, 2015 at 2:46 PM, Bernd Schmidt wrote: >> On 10/06/2015 01:39 AM, Mikhail Maltsev wrote: >>> >>> void verify_insn_chain (void); >>> +static inline void checking_verify_insn_chain (); >>>

Re: [PATCH 2/9] ENABLE_CHECKING refactoring: libcpp

2015-10-18 Thread Mikhail Maltsev
bcpp/system.h' parts into the first patch of the series. As for replacing linemap_assert, I hope it can be done separately. -- Regards, Mikhail Maltsev libcpp/ChangeLog: 2015-10-19 Mikhail Maltsev * include/line-map.h: Use CHECKING_P instead of EN

Re: [PATCH 1/9] ENABLE_CHECKING refactoring

2015-10-19 Thread Mikhail Maltsev
it (I would like to hear Jeff's and Richard's opinion). Of course it will be easy for me to adjust the patch to whatever the final decision will be. -- Regards, Mikhail Maltsev

Re: [PATCH 5/9] ENABLE_CHECKING refactoring: pool allocators

2015-10-25 Thread Mikhail Maltsev
be faster than checking > flag_checking. I fixed this and other issues, and committed the attached patch. -- Regards, Mikhail Maltsev diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 81d0e1c..d8a22c3 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2015-10-26 Mikhail

Re: [PATCH 5/9] ENABLE_CHECKING refactoring: pool allocators

2015-10-26 Thread Mikhail Maltsev
On 10/26/2015 12:47 PM, Richard Biener wrote: > I committed the attached to fix build with the valgrind annotations active. > > Richard. > Doh! Sorry for breakage. -- Regards, Mikhail Maltsev

Re: [PATCH] Add -fchecking

2015-10-27 Thread Mikhail Maltsev
al value got from command-line options). -- Regards, Mikhail Maltsev

[PATCH 9/9] ENABLE_CHECKING refactoring: C family front ends

2015-11-01 Thread Mikhail Maltsev
ning a second check after rebasing). OK for trunk? -- Regards, Mikhail Maltsev gcc/c-family/ChangeLog: 2015-10-31 Mikhail Maltsev * c-omp.c (c_omp_split_clauses): Remove conditional compilation. Use flag_checking. gcc/cp/ChangeLog: 2015-10-31 Mikhail Maltsev

[PATCH 10/9] ENABLE_CHECKING refactoring: remove remaining occurrences

2015-11-01 Thread Mikhail Maltsev
-checking=release. libcpp/ChangeLog: 2015-11-01 Mikhail Maltsev * config.in: Regenerate. * configure: Regenerate. * configure.ac: Remove ENABLE_CHECKING. gcc/ChangeLog: 2015-11-01 Mikhail Maltsev * cfganal.c (inverted_post_order_compute): Remove conditional

Re: [PATCH 9/9] ENABLE_CHECKING refactoring: C family front ends

2015-11-04 Thread Mikhail Maltsev
} >> } > I think this condition was reversed, right? > > Please fix that and install on the trunk. > > Thanks again! > > jeff Fixed and committed as r229756. -- Regards, Mikhail Maltsev

Re: [PATCH 10/9] ENABLE_CHECKING refactoring: remove remaining occurrences

2015-11-04 Thread Mikhail Maltsev
On 11/03/2015 02:35 AM, Jeff Law wrote: > This is good fore the trunk too. Please install. > > Thanks! > > jeff Committed as r229758. -- Regards, Mikhail Maltsev

Re: [PATCH 10/9] ENABLE_CHECKING refactoring: remove remaining occurrences

2015-11-08 Thread Mikhail Maltsev
On 11/01/2015 11:34 PM, Bernhard Reutner-Fischer wrote: > Mikhail, > > On November 1, 2015 9:19:19 PM GMT+01:00, Mikhail Maltsev > wrote: >> This patch cleans up remaining bits related to ENABLE_CHECKING. After >> applying >> this patch (on top of part 9) we will

Re: [PATCH 01/15] Selftest framework (unittests v4)

2015-11-19 Thread Mikhail Maltsev
the same approach: testcases are objects which store metainformation (such as name) and have methods for running tests. -- Regards, Mikhail Maltsev

[PATCH, i386] PR68497. Fix ICE with -fno-checking

2015-11-23 Thread Mikhail Maltsev
Hi! The attached patch fixes a problem introduced in r229567: the assertion gcc_assert (is_sse); is checked if flag_checking is false, and this causes an ICE when compiling with -fno-checking. Bootstrapped and regtested on x86_64-pc-linux-gnu. OK for trunk? -- Regards, Mikhail Maltsev

Re: [PATCH, i386] PR68497. Fix ICE with -fno-checking

2015-11-24 Thread Mikhail Maltsev
On 11/24/2015 02:43 AM, Bernd Schmidt wrote: > On 11/24/2015 12:09 AM, Mikhail Maltsev wrote: >> The attached patch fixes a problem introduced in r229567: the assertion >> >> gcc_assert (is_sse); >> >> is checked if flag_checking is false, and this causes an I

Re: [patch, c, ping] Fix PR c/48956: diagnostics for conversions involving complex types (reviewed)

2015-05-15 Thread Mikhail Maltsev
On 04/17/2015 05:01 AM, Mikhail Maltsev wrote: > I would like to ping the following patch: > https://gcc.gnu.org/ml/gcc-patches/2014-12/msg01925.html > Review: https://gcc.gnu.org/ml/gcc-patches/2015-01/msg02672.html > > I fixed minor issues mentioned in the review and update

[PATCH] Refactoring: use std::swap instead of manual swaps

2015-05-18 Thread Mikhail Maltsev
Mikhail Maltsev gcc/c/ChangeLog: 2015-05-18 Mikhail Maltsev * c-typeck.c (build_array_ref): Use std::swap instead of explicit swaps gcc/ChangeLog: 2015-05-18 Mikhail Maltsev * bb-reorder.c (fix_up_fall_thru_edges): Use std::swap instead of explicit swaps. * dojump.c (do_compare_rt

Re: [PATCH] Refactoring: use std::swap instead of manual swaps

2015-05-18 Thread Mikhail Maltsev
case, I re-ran tests on x86_64 linux + checked that build does not break for various targets. Simulators that I tried to use are still broken, unfortunately). -- Regards, Mikhail Maltsev diff --git a/gcc/ChangeLog b/gcc/ChangeLog index c00a878..44017c1 100644 --- a/gcc/ChangeLog +++ b/gcc/Ch

Fwd: Re: [PATCH, RFC]: Next stage1, refactoring: propagating rtx subclasses

2015-05-18 Thread Mikhail Maltsev
le and rebased) and updated changelog. Bootstrapped + regtested on x86_64-unknown-linux-gnu{,-m32} and built config-list.mk. OK for trunk? -- Regards, Mikhail Maltsev as_insn6.tar.gz Description: GNU Zip compressed data

Re: Fwd: Re: [PATCH, RFC]: Next stage1, refactoring: propagating rtx subclasses

2015-05-20 Thread Mikhail Maltsev
On 05/20/2015 12:28 AM, Jeff Law wrote: > Yes, this is OK for the trunk. Please commit. > > jeff Applied to trunk (revision 223454). -- Regards, Mikhail Maltsev

[PATCH][RFA] PR rtl-optimization/66237

2015-05-22 Thread Mikhail Maltsev
case (PR34999) on aarch64 crosscompiler using the provided profiling data. OK for trunk? -- Regards, Mikhail Maltsev gcc/ChangeLog: 2015-05-22 Mikhail Maltsev PR rtl-optimization/66237 * bb-reorder.c (fix_crossing_conditional_branches): Fix wrong location of an

Re: C/C++ PATCH to allow deprecating enum values (PR c/47043)

2015-05-22 Thread Mikhail Maltsev
for this extension (like __cpp_gnu_enum_attributes=... for C++ and __GCC_HAVE_ENUM_ATTRIBUTES for C). Thoughts? -- Regards, Mikhail Maltsev

GIMPLE syntax highlighting for vim

2015-05-24 Thread Mikhail Maltsev
Hi all! The attached vim script can be used to highlight syntax in GIMPLE dumps making them somewhat easier to read. I would like to add this script to gcc/contrib directory. Is that OK? -- Regards, Mikhail Maltsev " Syntax highlighting rules for GIMPLE dump files " " Cop

Re: GIMPLE syntax highlighting for vim

2015-05-29 Thread Mikhail Maltsev
On 27.05.2015 15:42, Jeff Law wrote: > On 05/24/2015 01:48 PM, Mikhail Maltsev wrote: >> Hi all! >> >> The attached vim script can be used to highlight syntax in GIMPLE dumps >> making them somewhat easier to read. >> >> I would like to add this script to gc

[PATCH] Fix C++11 compatibility

2015-05-31 Thread Mikhail Maltsev
gs (I tested that build now succeeds). Committed as obvious. -- Regards, Mikhail Maltsev diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 9efdb9c..5625750 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2015-05-31 Mikhail Maltsev + + * config/cris/c

Re: [wwwdocs] Move gcc/README.Portability to wwwdocs codingconventions.html

2015-06-05 Thread Mikhail Maltsev
tin_expect(!!(x), 1) #define unlikely(x) __builtin_expect((x), 0) Is it worth adding them to, say, system.h or ansidecl.h? -- Regards, Mikhail Maltsev

Re: [PATCH, RFC]: Next stage1, refactoring: propagating rtx subclasses

2015-06-05 Thread Mikhail Maltsev
09.05.2015 1:54, Jeff Law wrote: > On 05/04/2015 02:18 PM, Mikhail Maltsev wrote: [snip] >> I'm trying to continue and the next patch (peep_split.patch, >> peep_split.cl) is addressing the same task in some of the generated code >> (namely, gen_peephole2_* and gen_s

[patch, c, ping] Fix PR c/48956: diagnostics for conversions involving complex types (reviewed)

2015-04-16 Thread Mikhail Maltsev
regtested on x86_64-unknown-linux-gnu. If it is OK for trunk, please assist with applying (I don't have write access), and I will then create a new PR in bugzilla for the remaining cases mentioned in review. -- Regards, Mikhail Maltsev gcc/c-family/ChangeLog: 2015-04-17 Mikhail Ma

Re: [patch, c, ping] Fix PR c/48956: diagnostics for conversions involving complex types (reviewed)

2015-04-17 Thread Mikhail Maltsev
On 04/17/2015 08:10 PM, Jeff Law wrote: > Have you received confirmation from the FSF WRT your copyright > assignment was accepted? > > jeff > Yes, it's ID is [gnu.org #972407]. Should I forward the PDF to you? -- Regards, Mikhail Maltsev

[Patch, C++, PR65882] Check tf_warning flag in build_new_op_1

2015-04-26 Thread Mikhail Maltsev
The attached patch was bootstrapped and regtested on x86_64-unknown-linux-gnu. -- Regards, Mikhail Maltsev gcc/cp/ChangeLog: 2015-04-26 Mikhail Maltsev * call.c (build_new_op_1): Check tf_warning flag in all cases gcc/testsuite/ChangeLog: 2015-04-26 Mikhail Maltsev

Re: [PATCH, RFC]: Next stage1, refactoring: propagating rtx subclasses

2015-04-27 Thread Mikhail Maltsev
oss a GC collection, > so I don't think we need these lists to be rtxes at all. OK, reverted changes in LRA code for now. I think this should be a separate patch then. -- Regards, Mikhail Maltsev diff --git a/gcc/bb-reorder.c b/gcc/bb-reorder.c index c2a3be3..ae726e5 100644 --- a/gcc/bb

Re: [patch, c, ping] Fix PR c/48956: diagnostics for conversions involving complex types (reviewed)

2015-04-28 Thread Mikhail Maltsev
On 20.04.2015 21:35, Jeff Law wrote: > On 04/17/2015 11:37 AM, Mikhail Maltsev wrote: >> On 04/17/2015 08:10 PM, Jeff Law wrote: >>> Have you received confirmation from the FSF WRT your copyright >>> assignment was accepted? >>> >>> jeff >>>

Re: [PATCH, RFC]: Next stage1, refactoring: propagating rtx subclasses

2015-04-29 Thread Mikhail Maltsev
new {} pair and added > indention. Sorry for that. I had to introduce a couple of variables, and I decided to limit their scope in order to make their use less error-prone. -- Regards, Mikhail Maltsev gcc/ChangeLog: 2015-04-29 Mikhail Maltsev Promote types of

Re: [PATCH, RFC]: Next stage1, refactoring: propagating rtx subclasses

2015-05-04 Thread Mikhail Maltsev
bably get > write-after-approval access so that you can commit your own approved > changes. Is it OK to mention you as a maintainer who can approve my request for write access? -- Regards, Mikhail Maltsev as_insn.tar.gz Description: GNU Zip compressed data

[PATCH] Added myself to "Write After Approval" section

2015-05-10 Thread Mikhail Maltsev
Subj. -- Regards, Mikhail Maltsev diff --git a/ChangeLog b/ChangeLog index d4b60dd..b9bfc76 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2015-05-10 Mikhail Maltsev + + * MAINTAINERS (Write After Approval): Add myself. + 2015-05-03 Matthias Klose

Re: [PATCH, RFC]: Next stage1, refactoring: propagating rtx subclasses

2015-05-11 Thread Mikhail Maltsev
ed on x86_64-unknown-linux-gnu {,-m32} (C,C++,lto,objc,fortran,go), crosscompiled and regtested (C and C++ testsuites) on sh-elf, mips-elf, poweperpc-eabisim and arm-eabi simulators. -- Regards, Mikhail Maltsev diff --git a/gcc/config/bfin/bfin.c b/gcc/config/bfin/bfin.c index 2768266..37f4ded 100644 ---

[PATCH] Fix PR c++/65154 (ICE on braced initializer)

2015-03-01 Thread Mikhail Maltsev
it a, b; +}; + +int +main () +{ + C1 c1[5]{}; + C2 c2[1]{}; + + if (c2[0].a.i != 42 || c2[0].b.i != 42) +return 1; + + if (cnt1 != 5 || cnt2 != 2) +return 1; + + return 0; +} Changelog record: 2015-03-02 Mikhail Maltsev PR c++/65154 * gcc/cp/init.c (bui

Re: Strengthen ICF hash

2015-03-03 Thread Mikhail Maltsev
type), hstate); > + sem_item::add_expr (TYPE_SIZE (type), hstate); > + hstate.add_int (POINTER_TYPE_P (type)); Note that this code can also be generated automatically, based on gengtype-like annotations or, better, some separate description like match.pd. -- Regards, Mikhail Maltsev E

[PATCH] Move gen_* stubs from defaults.h to genflags

2015-06-09 Thread Mikhail Maltsev
probably some of them will be fixed in the same way, I propose a patch, which allows to generate required stubs in genflags. Bootstrapped and regtested on x86_64-unknown-linux-gnu, testing for full target list in progress. OK for trunk? -- Regards, Mikhail Maltsev gcc/ChangeLog: 2015-06-10

[PATCH] Refactoring: use std::swap instead of manual swaps (part 2)

2015-06-14 Thread Mikhail Maltsev
- Regards, Mikhail Maltsev gcc/ChangeLog: 2015-06-14 Mikhail Maltsev * auto-inc-dec.c (reverse_mem): Remove. (reverse_inc): Remove. (parse_add_or_inc): Use std::swap instead of reverse_{mem,inc}. (find_inc): Likewise. * combine.c (combine_simplify_rtx

Re: [PATCH] Move gen_* stubs from defaults.h to genflags

2015-06-14 Thread Mikhail Maltsev
/ For example, this would work if result of gen_* function is passed directly to some emit_pattern_* function (they can handle NULL pointers). >> +/* Print out a dummy for generator for instruction NAME with NUM arguments >> + which either does nothing, or aborts (depending on U

[PATCH, RFC] PR middle-end/55299, contract bitnot through ASR and rotations

2015-06-15 Thread Mikhail Maltsev
different types and tree folding fails (if I change int to long, everything is OK). Should this be addressed somehow? 3. Do the new patterns require any special handling of nop-conversions? -- Regards, Mikhail Maltsev gcc/ChangeLog: 2015-06-15 Mikhail Maltsev * match.pd: (~((~

[C/C++ PATCH] PR c++/66572. Fix Wlogical-op false positive

2015-06-19 Thread Mikhail Maltsev
ux. OK for trunk? -- Regards, Mikhail Maltsev gcc/c-family/ChangeLog: 2015-06-19 Mikhail Maltsev PR c++/66572 * c-common.c (warn_logical_operator): Treat constant-initialized VAR_DECLs like literal constants. gcc/testsuite/ChangeLog: 2015-06-19 Mikhail Maltsev

Re: [Patch, C++, PR65882] Check tf_warning flag in build_new_op_1

2015-06-19 Thread Mikhail Maltsev
nk. I see that version 5.2 is set as target milestone for this bug. Should I backport the patch? -- Regards, Mikhail Maltsev diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index eb5e4c5..6656441 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,8 @@ +2015-06-20 Mikhail Maltsev

Re: [PATCH] Refactoring: use std::swap instead of manual swaps (part 2)

2015-06-21 Thread Mikhail Maltsev
t on arm-eabi simulator today. The applied patch is identical to the one I have posted in my original message, so I'm not repeating it here. -- Regards, Mikhail Maltsev

Re: [06/12] Consolidate string hashers

2015-06-24 Thread Mikhail Maltsev
weird to me: it does not reimplement the hash function. I.e. the pointer value is used as hash. I wonder, is it intentional or not? This could actually work if strings are interned (but in that case there is no need to compare them, because comparing pointers would be enough). -- Regards, Mikhail Maltsev

Re: [C/C++ PATCH] PR c++/66572. Fix Wlogical-op false positive

2015-06-24 Thread Mikhail Maltsev
On 23.06.2015 22:49, Marek Polacek wrote: > On Sat, Jun 20, 2015 at 03:02:06AM +0300, Mikhail Maltsev wrote: >> - /* We do not warn for constants because they are typical of macro >> - expansions that test for features. */ >> - if (CONSTANT_CLASS_P (op_left) || CONST

Re: [Patch, C++, PR65882] Check tf_warning flag in build_new_op_1

2015-06-24 Thread Mikhail Maltsev
B::value>::type - operator=(Expr); // { dg-message "declared" } + operator=(Expr); // { dg-message "private" } }; void fn1() { D opt; - opt = 0; // { dg-error "private" } + opt = 0; // { dg-error "this context" } } But I am not sure, what should I do in this case. Maybe it is better to remove the failing testcase from GCC 5 branch (provided that inhibit-warn-1.C tests a fix for the same bug and does not fail)? -- Regards, Mikhail Maltsev

Re: [12/12] Simplify uses of hash_map

2015-06-26 Thread Mikhail Maltsev
AL USE ONLY $ /opt/intel/bin/icpc -c ./test2.ii ./test2.ii(11): error: declaration is incompatible with function template "void hash_table>::traverse>(Argument)" (declared at line 4) void hash_table::traverse(Argument) {} ^ compilation aborted for ./test2.ii (code 2) -- Regards, Mikhail Maltsev

[PATCH 0/7] Fix bugs found during demangler fuzz-testing

2015-07-06 Thread Mikhail Maltsev
, there are cases when conversion operator is used as a nested (qualified) name: _Z1fIN1CcvT_EEvv -> segfault Presumably this means: template void f() I wonder, if it is possible in valid C++ code? Notice that the following template instantiation is demangled correctly: void f() _Z1fIN1CcviE

[PATCH 1/7] Add CHECK_DEMANGLER

2015-07-06 Thread Mikhail Maltsev
--- libiberty/cp-demangle.h | 33 +++-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/libiberty/cp-demangle.h b/libiberty/cp-demangle.h index 6fce025..c37a91f 100644 --- a/libiberty/cp-demangle.h +++ b/libiberty/cp-demangle.h @@ -135,12 +135,41 @@ struc

[PATCH 2/7] Fix build with CP_DEMANGLE_DEBUG

2015-07-06 Thread Mikhail Maltsev
--- libiberty/cp-demangle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libiberty/cp-demangle.c b/libiberty/cp-demangle.c index 2988b6b..12093cc 100644 --- a/libiberty/cp-demangle.c +++ b/libiberty/cp-demangle.c @@ -715,7 +715,7 @@ d_dump (struct demangle_component *dc, int

[PATCH 3/7] Fix trinary op

2015-07-06 Thread Mikhail Maltsev
--- libiberty/cp-demangle.c | 4 +++- libiberty/testsuite/demangle-expected | 6 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/libiberty/cp-demangle.c b/libiberty/cp-demangle.c index 12093cc..44a0a9b 100644 --- a/libiberty/cp-demangle.c +++ b/libiberty/cp-deman

[PATCH 4/7] Fix int overflow

2015-07-06 Thread Mikhail Maltsev
--- libiberty/cp-demangle.c | 3 ++- libiberty/testsuite/demangle-expected | 4 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/libiberty/cp-demangle.c b/libiberty/cp-demangle.c index 44a0a9b..befa6b6 100644 --- a/libiberty/cp-demangle.c +++ b/libiberty/cp-demangle

[PATCH 5/7] Fix braced-init-list demangling

2015-07-06 Thread Mikhail Maltsev
--- libiberty/cp-demangle.c | 2 ++ libiberty/testsuite/demangle-expected | 4 2 files changed, 6 insertions(+) diff --git a/libiberty/cp-demangle.c b/libiberty/cp-demangle.c index befa6b6..424b1c5 100644 --- a/libiberty/cp-demangle.c +++ b/libiberty/cp-demangle.c @@ -3167,6 +3

[PATCH 6/7] Fix DEMANGLE_COMPONENT_LOCAL_NAME

2015-07-06 Thread Mikhail Maltsev
--- libiberty/cp-demangle.c | 7 +++ libiberty/testsuite/demangle-expected | 4 2 files changed, 11 insertions(+) diff --git a/libiberty/cp-demangle.c b/libiberty/cp-demangle.c index 424b1c5..289a704 100644 --- a/libiberty/cp-demangle.c +++ b/libiberty/cp-demangle.c @@ -324

[PATCH 7/7] Fix several crashes in d_find_pack

2015-07-06 Thread Mikhail Maltsev
--- libiberty/cp-demangle.c | 3 +++ libiberty/testsuite/demangle-expected | 12 2 files changed, 15 insertions(+) diff --git a/libiberty/cp-demangle.c b/libiberty/cp-demangle.c index 289a704..4ca285e 100644 --- a/libiberty/cp-demangle.c +++ b/libiberty/cp-demangle.c @

Re: [PATCH 4/7] Fix int overflow

2015-07-06 Thread Mikhail Maltsev
e about compiler warnings, but AFAIR, in multilib build libiberty is also built for 32-bit target, and I did not get any additional warnings. -- Regards, Mikhail Maltsev

Re: [PATCH 4/7] Fix int overflow

2015-07-07 Thread Mikhail Maltsev
K&R-style definitions there), and it uses (DMGL_PARAMS | DMGL_ANSI | DMGL_TYPES) by default. (snip) > FWIW, demangler.com doesn't give any results for that case. It just returns > DpDv1_c But "_Z1fDpDv1_c" makes it crash :) -- Regards, Mikhail Maltsev

Re: [PATCH, c] PR c/48956: diagnostics for conversions involving complex types

2015-01-29 Thread Mikhail Maltsev
. (Once GCC 5 has branched > and the assignment is done, please retest and send a patch with the > testcase fix to gcc-patches with a request for someone to commit it.) OK. I hope FSF will receive my copyright assignment soon (according to USPS post tracking it's already delivered). -- Regards, Mikhail Maltsev

Re: [PATCH 2/2][GCC] Add one more pattern to RTL if-conversion

2016-05-24 Thread Mikhail Maltsev
On 05/23/2016 05:15 PM, Kyrill Tkachov wrote: > > expand_simple_binop may fail. I think you should add a check that diff_rtx is > non-NULL > and bail out early if it is. > Fixed. -- Regards, Mikhail Maltsev diff --git a/gcc/ifcvt.c b/gcc/ifcvt.c index a9c146b..e1473eb 1

Re: [PATCH 1/5][GIMPLE FE] PR testsuite/80580. Handle missing labels in goto statements

2017-05-28 Thread Mikhail Maltsev
rrectly diagnoses both errors. But if I swap these two functions so that 'bar' comes before 'foo', the error in 'foo' is not diagnosed. I did not dive into details, but my speculation is that the parser enters some strange state and skips 'foo' entirely (-f

[PATCH 0/5][GIMPLE FE] PR testsuite/80580. Fix some ICEs on invalid code

2017-05-01 Thread Mikhail Maltsev
(although, I see some noise in the tree-prof tests). The patches are intended for GCC 8. -- Regards, Mikhail Maltsev

[PATCH 1/5][GIMPLE FE] PR testsuite/80580. Handle missing labels in goto statements

2017-05-01 Thread Mikhail Maltsev
nding code uses 'c_parser_error', but this function does not handle locations very well (in fact, it uses input_location). -- Regards, Mikhail Maltsev gcc/testsuite/ChangeLog: 2017-05-01 Mikhail Maltsev * gcc.dg/gimplefe-error-4.c: New test. * gcc.dg/gimplefe-err

[PATCH 2/5][GIMPLE FE] PR testsuite/80580: handle invalid types of "->" operands

2017-05-01 Thread Mikhail Maltsev
This bug happens when the LHS of operator '->' is either missing, i.e.: (->a) = 0; or it is not a pointer: int b; b_2->c = 0; LHS should be validated. -- Regards, Mikhail Maltsev gcc/testsuite/ChangeLog: 2017-05-01 Mikhail Maltsev * gcc.dg/gimplefe-

[PATCH 3/5][GIMPLE FE] PR testsuite/80580. Handle invalid unary "*" operand type

2017-05-01 Thread Mikhail Maltsev
This is essentially the same problem as in patch 2, but with unary '*'. We should verify that its argument is a pointer. -- Regards, Mikhail Maltsev gcc/c/ChangeLog: 2017-05-01 Mikhail Maltsev * gimple-parser.c (c_parser_gimple_unary_expression): Check argument

[PATCH 4/5][GIMPLE FE] PR testsuite/80580. Handle invalid __MEM

2017-05-01 Thread Mikhail Maltsev
This patch deals with invalid __MEM construct. Before we start building an expression for __MEM, we must check that parsing succeeded and that the __MEM operand is a pointer. -- Regards, Mikhail Maltsev gcc/c/ChangeLog: 2017-05-01 Mikhail Maltsev * gimple-parser.c

[PATCH 5/5][GIMPLE FE] PR testsuite/80580: Handle invalid SSA names

2017-05-01 Thread Mikhail Maltsev
When parsing SSA names, we should check that parent names are scalars. In fact, this patch just uses the condition of a 'gcc_assert' in 'make_ssa_name_fn'. -- Regards, Mikhail Maltsev gcc/testsuite/ChangeLog: 2017-05-01 Mikhail Maltsev * gcc.dg/gimplefe-

Re: [PATCH] Implement smart multiple switch expansion algorithms.

2017-10-06 Thread Mikhail Maltsev
rdcoded and quite wrong for big tables... > > Also what is the codesize difference on SPEC2006/2017? I don't see > any mention of performance impact either... > > Wilco -- Regards, Mikhail Maltsev

[C PATCH] PR43651: add warning for duplicate qualifier

2016-04-04 Thread Mikhail Maltsev
was chosen to match the same option in Clang. Bootstrapped and regtested on x86_64-linux. OK for next stage 1? -- Regards, Mikhail Maltsev gcc/c/ChangeLog: 2016-04-04 Mikhail Maltsev PR c/43651 * c-decl.c (declspecs_add_qual): Warn when -Wduplicate-decl-specifie

Re: [C PATCH] PR43651: add warning for duplicate qualifier

2016-04-08 Thread Mikhail Maltsev
On 04/08/2016 12:50 AM, Joseph Myers wrote: > New options need documenting in invoke.texi. > Done. -- Regards, Mikhail Maltsev gcc/c/ChangeLog: 2016-04-08 Mikhail Maltsev PR c/43651 * c-decl.c (declspecs_add_qual): Warn when -Wduplicate-decl-specifier

Re: [C PATCH] PR43651: add warning for duplicate qualifier

2016-04-09 Thread Mikhail Maltsev
? > > Also, in C11 mode, Clang issues the warning for duplicated > _Atomic qualifiers but it doesn't look like GCC would with > the patch. Here again, unless there's some reason not to, > I would expect GCC to issue the same warning as Clang for > the same code. > F

[PATCH] Fix missed DSE opportunity with operator delete.

2016-04-16 Thread Mikhail Maltsev
-linux-gnu. -- Regards, Mikhail Maltsev gcc/c/ChangeLog: 2016-04-16 Mikhail Maltsev * c-decl.c (merge_decls): Handle free_flag. gcc/ChangeLog: 2016-04-16 Mikhail Maltsev * builtin-attrs.def: Add attribute free. * builtins.def (free): Add attribute free

Re: [PATCH] Fix missed DSE opportunity with operator delete.

2016-04-19 Thread Mikhail Maltsev
ECF_FREE. Fixed. -- Regards, Mikhail Maltsev diff --git a/gcc/ada/gcc-interface/trans.c b/gcc/ada/gcc-interface/trans.c index 357d26f..00e4f84 100644 --- a/gcc/ada/gcc-interface/trans.c +++ b/gcc/ada/gcc-interface/trans.c @@ -400,7 +400,7 @@ gigi (Node_Id gnat_root, ftype,

  1   2   >