Re: [PATCH, Android] Runtime stack protector enabling for Android target

2012-07-24 Thread Maxim Kuvyrkov
and provides Bionic >>accessibility status > > Looks OK to me, patch needs approval from Maxim. OK. Thanks for fixing this. -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics

Re: [PATCH, PR38785] Throttle PRE at -O3

2012-04-27 Thread Maxim Kuvyrkov
On 27/04/2012, at 1:17 AM, Richard Guenther wrote: > On Wed, Apr 25, 2012 at 8:06 AM, Maxim Kuvyrkov > wrote: > ... > +ppre_n_insert_for_speed_p (pre_expr expr, basic_block block, > + unsigned int inserts_needed) > +{ > + /* The more expensive

Re: [google/gcc-4_6_2-mobile] Port of Android target support in i386 for google/gcc-4_6_2-mobile branch

2012-05-03 Thread Maxim Kuvyrkov
e build > and Android ICS build. FAOD, this is really a question for google/gcc-4_6_2-mobile owner. -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics > > Thanks, > Ilya > --- > 2012-05-03 Enkovich Ilya > > * config/linux-android.h (AND

Re: [PATCH, Android] Stack protector enabling for Android target

2012-05-07 Thread Maxim Kuvyrkov
s often synonymous with -android* target, but not always. Let's enable ssp based on whether __BIONIC__ is defined in the libc headers (i.e., add a grep test for __BIONIC__ in ) Also please add a comment along the lines of "all versions of Bionic support stack protector&qu

Re: [PATCH, Android] Stack protector enabling for Android target

2012-05-15 Thread Maxim Kuvyrkov
$target_header_dir/sys/cdefs.h > /dev/null; then + gcc_cv_libc_provides_ssp=yes fi] ;; *-*-gnu*) The patch is OK provided successful regtest and either dropping the first hunk or explaining why it is necessary. Thanks! -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics

[PATCH, MIPS] Add most common atomic patterns

2012-06-12 Thread Maxim Kuvyrkov
and [in-progress] non-XLP MIPS boards with no regressions with a corresponding patch to MIPS GLIBC port to use the new atomic builtins. -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics

[PATCH 1/3] Add atomic_compare_and_swap, atomic_exchange and atomic_fetch_add patterns.

2012-06-12 Thread Maxim Kuvyrkov
-- Maxim Kuvyrkov CodeSourcery / Mentor Graphics 0001-Add-atomic_compare_and_swap-atomic_exchange-and-atom.patch Description: Binary data

[PATCH 2/3] Add XLP-specific atomic instructions and tweaks.

2012-06-12 Thread Maxim Kuvyrkov
-- Maxim Kuvyrkov CodeSourcery / Mentor Graphics 0002-Add-XLP-specific-atomic-instructions-and-tweaks.patch Description: Binary data

[PATCH 3/3] Avoid emitting useless instructions in mips_process_sync_loop.

2012-06-12 Thread Maxim Kuvyrkov
-- Maxim Kuvyrkov CodeSourcery / Mentor Graphics 0003-Avoid-emitting-useless-instructions-in-mips_process_.patch Description: Binary data

Re: [PATCH] check_cfg assert fix

2011-09-06 Thread Maxim Kuvyrkov
the face of unconditional jump so that the barrier now follows a conditional jump. This is very odd, but, given the initial test case, is a valid case. For reference, the test case in question: /* { dg-do compile } */ void foo () { asm goto (""l1); __builtin_unreachable (); l1:; } void bar () { foo (); foo (); } -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics smime.p7s Description: S/MIME cryptographic signature

Re: [PATCH] check_cfg assert fix

2011-09-06 Thread Maxim Kuvyrkov
king_assert? I agree. I would rather remove the entirety of haifa-sched.c: check_cfg(); scheduler is not the right place for checking consistency of CFG. Check_cfg() was useful for debugging scheduler patches, but now it is more of maintainance overhead. Do I have a second vote for removal of check_cfg()? -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics

Re: [PATCH] check_cfg assert fix

2011-09-13 Thread Maxim Kuvyrkov
On 9/09/2011, at 6:54 AM, Bernd Schmidt wrote: > On 09/06/11 23:56, Maxim Kuvyrkov wrote: >> I agree. I would rather remove the entirety of haifa-sched.c: >> check_cfg(); scheduler is not the right place for checking >> consistency of CFG. Check_cfg() was useful fo

[PATCH] Distribute inliner's size_time data across entries with similar predicates

2011-09-19 Thread Maxim Kuvyrkov
l 32 entries by searching for entries with similar predicates. OK for trunk assuming testing on x86_64-linux-gnu shows no regressions? Thank you, -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics 0001-Improve-ipa-inline-analysis.c-account_size_time-to-d.patch Description: Binary data

Re: [PATCH] check_cfg assert fix

2011-09-19 Thread Maxim Kuvyrkov
On 14/09/2011, at 7:40 AM, Maxim Kuvyrkov wrote: > > OK then, attached is the trivial patch that removes > haifa-sched.c:check_cfg(). Please let me know if you have strong feelings > towards keeping check_cfg(). > > Tested on x86_64-linux-gnu. Absent any requests to th

Re: [PR 47382] We cannot simply fold OBJ_TYPE_REF at all in 4.6

2011-09-21 Thread Maxim Kuvyrkov
ake devirtualization opportunities into account and your two above patches help improve devirtualization quite a bit. Do you plan to commit them some time soon? For reference, I'm attaching the patch that adds several new devirtualization testcases. Not optimizing the very simple inlin

[PATCH, committed] Fix typos in ipa-prop.c

2011-09-22 Thread Maxim Kuvyrkov
I've committed the following trivial patch to fix typos in ipa-prop.c dump/debug print function. -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics fsf-gcc-fixes-1.patch Description: Binary data fsf-gcc-fixes-1.ChangeLog Description: Binary data

[PATCH] Account for devirtualization opportunities in inliner

2011-09-27 Thread Maxim Kuvyrkov
., if inlining A across edge E into B will allow some of the indirect edges of A to be resolved, then inlining cost of edge E is reduced. The patch was bootstrapped and regtested on x86_64-linux-gnu on both -m32 and -m64 multilibs. OK to commit? Thank you, -- Maxim Kuvyrkov CodeSourcery / Mentor

Re: [PATCH, PR43814] Assume function arguments of pointer type are aligned.

2011-09-28 Thread Maxim Kuvyrkov
nment has tremendous effect on expanding __builtin_{mem,str}* functions. Thank you, -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics fsf-glibc-locale_t-align.patch Description: Binary data

Re: [PATCH, PR43814] Assume function arguments of pointer type are aligned.

2011-09-28 Thread Maxim Kuvyrkov
On 29/09/2011, at 7:35 AM, David Miller wrote: > From: Maxim Kuvyrkov > Date: Thu, 29 Sep 2011 07:29:12 +1300 > >> GLIBC patch to fix locale_t definition is attached. > > Isn't this going to result in byte loads being used to dereference > all locale_t pointers o

Re: [PATCH, PR43814] Assume function arguments of pointer type are aligned.

2011-09-28 Thread Maxim Kuvyrkov
On 29/09/2011, at 7:41 AM, David Miller wrote: > From: Maxim Kuvyrkov > Date: Thu, 29 Sep 2011 07:40:55 +1300 > >> On 29/09/2011, at 7:35 AM, David Miller wrote: >> >>> From: Maxim Kuvyrkov >>> Date: Thu, 29 Sep 2011 07:29:12 +1300 >>> >>

Re: [PATCH, PR43814] Assume function arguments of pointer type are aligned.

2011-09-28 Thread Maxim Kuvyrkov
David, To summarize, your opinion seems to be to not enable the optimization by default, correct? Thank you, -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics On 29/09/2011, at 7:48 AM, David Miller wrote: > From: Maxim Kuvyrkov > Date: Thu, 29 Sep 2011 07:45:17 +1300 > >> O

Re: [PATCH] Distribute inliner's size_time data across entries with similar predicates

2011-09-29 Thread Maxim Kuvyrkov
why you don't need or > predicate there. Yeap, I learned this several hours after I posted the patch. > > I will take at the patch later today. Thanks, -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics

Re: [PR 47382] We cannot simply fold OBJ_TYPE_REF at all in 4.6

2011-09-29 Thread Maxim Kuvyrkov
ase was not micro-optimized, and this makes me confident that the improvements are general enough to be valuable to broad bodies of code. Regards, -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics

Re: [PR 47382] We cannot simply fold OBJ_TYPE_REF at all in 4.6

2011-09-29 Thread Maxim Kuvyrkov
On 30/09/2011, at 4:02 PM, Maxim Kuvyrkov wrote: > On 24/09/2011, at 2:19 AM, Martin Jambor wrote: > >> However, both of these are really 4.8 material and since the patches >> probably need only minor updates, it might be worthwhile to do that so >> that gcc can handle t

Re: [PR 47382] We cannot simply fold OBJ_TYPE_REF at all in 4.6

2011-09-30 Thread Maxim Kuvyrkov
On 30/09/2011, at 6:56 PM, Maxim Kuvyrkov wrote: > On 30/09/2011, at 4:02 PM, Maxim Kuvyrkov wrote: > >> On 24/09/2011, at 2:19 AM, Martin Jambor wrote: >> >>> However, both of these are really 4.8 material and since the patches >>> probably need only minor u

Re: [PR 47382] We cannot simply fold OBJ_TYPE_REF at all in 4.6

2011-09-30 Thread Maxim Kuvyrkov
On 30/09/2011, at 6:56 PM, Maxim Kuvyrkov wrote: > On 30/09/2011, at 4:02 PM, Maxim Kuvyrkov wrote: > >> On 24/09/2011, at 2:19 AM, Martin Jambor wrote: >> >>> However, both of these are really 4.8 material and since the patches >>> probably need only minor u

[PATCH] Don't assume that constants can clobber vtbl

2011-09-30 Thread Maxim Kuvyrkov
on x86_64-linux-gnu {-m64/-m32} with no regressions. OK for trunk? Thank you, -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics fsf-gcc-vtbl-assign.ChangeLog Description: Binary data fsf-gcc-vtbl-assign.patch Description: Binary data

[PATCH] Handle side-effects of EH optimizations of callees

2011-10-04 Thread Maxim Kuvyrkov
u. OK for trunk? Thank you, [*] this is done in cgraphunit.c: update_call_expr() and ipa_modify_call_arguments() via maybe_clean[_and_replace]_eh_stmt(). -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics fsf-gcc-fixup_eh.ChangeLog Description: Binary data fsf-gcc-fixup_eh.patch Description: Binary data

Re: [PATCH] Handle side-effects of EH optimizations of callees

2011-10-04 Thread Maxim Kuvyrkov
On 5/10/2011, at 1:49 AM, Richard Guenther wrote: > On Tue, Oct 4, 2011 at 9:17 AM, Maxim Kuvyrkov wrote: >> Richard, >> >> The following patch fixes a CFG consistency problem. >> >> When early IPA optimizations (e.g., early SRA) create a version of a

[PATCH] Add capability to run several iterations of early optimizations

2011-10-11 Thread Maxim Kuvyrkov
}. Effect on compilation time is fairly predictable, about 10% compile time increase with 3 iterations. OK for trunk? [*] https://docs.google.com/spreadsheet/ccc?key=0AvK0Y-Pgj7bNdFBQMEJ6d3laeFdvdk9lQ1p0LUFkVFE&hl=en_US Thank you, -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics

[PATCH, MIPS] Add -march=xlp

2012-03-22 Thread Maxim Kuvyrkov
This patch adds basic support for Broadcom XLP (formerly NetLogic XLP) to GCC. Tested by building a mips64-linux-gnu toolchain with -march=xlp. OK to check in? -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics gcc-basic-xlp.ChangeLog Description: Binary data gcc-basic-xlp.patch Description

Re: [PATCH, i386, Android] -mandroid support for i386 target

2012-03-28 Thread Maxim Kuvyrkov
LINUX_OR_ANDROID_LD (GNU_USER_TARGET_LIB_SPEC, \ > + GNU_USER_TARGET_LIB_SPEC " " ANDROID_LIB_SPEC) > + > +#undef STARTFILE_SPEC > +#define STARTFILE_SPEC \ > + LINUX_OR_ANDROID_LD (GNU_USER_TARGET_STARTFILE_SPEC, \ > +ANDROID_STARTFILE_SPEC) > + > +#undef ENDFILE_SPEC > +#define ENDFILE_SPEC \ > + LINUX_OR_ANDROID_LD (GNU_USER_TARGET_MATHFILE_SPEC " " \ > +GNU_USER_TARGET_ENDFILE_SPEC, \ > +GNU_USER_TARGET_MATHFILE_SPEC " " \ > +ANDROID_ENDFILE_SPEC) -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics

Re: [PATCH, i386, Android] Enable __ANDROID__ macro for Android i386 target

2012-03-28 Thread Maxim Kuvyrkov
_CPP_BUILTINS(); \ > +}\ > + while (0) This is OK provided (1) i386/linux.h renamed to i386/linux32.h as per review of your other patch, (2) this change is made to "new" i386/linux.h, and (3) Uros and any other i386 doesn't object. Please hold off this patch until your other Android *_SPEC changes are approved. Thank you, -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics

Re: PATCH: Use crtbegin_so%O%s/crtend_so%O%s for -mandroid -shared

2012-03-28 Thread Maxim Kuvyrkov
This is OK. I didn't encounter building shared libraries for Android when developed the original Android support. You can commit this under the "obvious patch" rule. [I've asked SC for reviewer privileges for Android support, so that I can approve more complex patches.]

Re: [PATCH, i386, Android] -mandroid support for i386 target

2012-04-01 Thread Maxim Kuvyrkov
th 32-bit and 64-bit multilibs. The 32-bit multilib will be used by default, and compilation for 64-bit user-space can be requested with -m64 option. Even though Android is not supported for -m64, such a toolchain can support Android as a additional "-m32 -mandroid" multilib. I.e., the toolchain will have three multilibs in total: "-m32" (default), "-m64" and "-m32 -mandroid". I386/linux64.h will be picked up for such a toolchain, even though by default it would compile for 32-bit target. Does this clear up things? Thank you, -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics

Re: [PATCH, i386, Android] -mandroid support for i386 target

2012-04-01 Thread Maxim Kuvyrkov
one can reasonably get. It would be possible to include linux-or-android.h at the end of linux*.h that would #undef/#define *_SPEC macros like below, but it seems clearer to give the final choice of what is going into the *_SPEC macros to individual targets. -- Maxim Kuvyrkov CodeSourcery / Men

Re: [PATCH, i386, Android] -mandroid support for i386 target

2012-04-02 Thread Maxim Kuvyrkov
ight? It's simpler that you think. The target headers ($tm_file in config.gcc -- gnu-user.h, linux*.h, etc. in this case) are all included into tm.h, which serves as proxy to all those headers. All definitions made in preceding headers are available in subsequent headers. So, given that i386

Re: [PATCH, i386, Android] -mandroid support for i386 target

2012-04-03 Thread Maxim Kuvyrkov
h >>> serves as proxy to all those headers. All definitions made in preceding >>> headers are available in subsequent headers. So, given that >>> i386/gnu-user*.h precedes i386/linux*.h in config.gcc's $tm_file, you only >>> need to touch linux*.h. >&g

[PATCH, Android] MIPS support

2012-04-04 Thread Maxim Kuvyrkov
Chao, Let's take discussion of MIPS changes to gcc-patches@. Please follow up here. -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics On 5/04/2012, at 10:10 AM, Fu, Chao-Ying wrote: > Maxim Kuvyrkov wrote: > >> I encourage you to submit the MIPS Android patches to >>

Re: [PATCH, i386, Android] Add Android support for i386 target

2012-04-17 Thread Maxim Kuvyrkov
Uros. > > Thanks, Uros! > > Maxim, could you please look at patch? The Android parts of the patch are also good. Given that Uros approved the x86 pieces, you are clear to check in. Ilya, thanks for bearing with the us and reworking your patch after the reviews. -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics

Re: [PATCH, Android] MIPS support

2012-04-17 Thread Maxim Kuvyrkov
On 5/04/2012, at 10:16 AM, Maxim Kuvyrkov wrote: > Chao, > > Let's take discussion of MIPS changes to gcc-patches@. Please follow up here. > > -- > Maxim Kuvyrkov > CodeSourcery / Mentor Graphics > > On 5/04/2012, at 10:10 AM, Fu, Chao-Ying wrote: > >>

Re: [PATCH, Android] MIPS support

2012-04-17 Thread Maxim Kuvyrkov
On 18/04/2012, at 1:10 PM, Fu, Chao-Ying wrote: > Maxim Kuvyrkov wrote: > >> Above definitions are OK. > > Thanks! For avoidance of doubt, please wait for the whole patch to be approved before committing it. >>>> Index: g

[PATCH, PR38785] Throttle PRE at -O3

2012-04-17 Thread Maxim Kuvyrkov
sted this patch on recent mainline on i686-linux-gnu with no regressions. Unless I hear from you to the contrary, I will push this patch for upstream review and, hopefully, get it checked in. Previous discussion of this patch is at http://gcc.gnu.org/ml/gcc-patches/2009-03/msg00250.html Thank

Re: MIPS Android patch

2012-04-20 Thread Maxim Kuvyrkov
after amending the patch per Richard's comments. Please check in the patch to unwind-dw2-fde-dip.c separately, as it is a change on its own. Thank you, -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics > > gcc/ChangeLog > 2012-04-19 Chao-ying Fu > > * config.g

Re: [PATCH, PR38785] Throttle PRE at -O3

2012-04-24 Thread Maxim Kuvyrkov
On 18/04/2012, at 9:17 PM, Richard Guenther wrote: > On Wed, Apr 18, 2012 at 4:15 AM, Maxim Kuvyrkov > wrote: >> Steven, >> J"orn, >> >> I am looking into fixing performance regression on EEMBC's bitmnp01, and a >> version of your combined p

Re: [PR50764, PATCH] Fix for ICE in maybe_record_trace_start with -fsched2-use-superblocks

2011-11-15 Thread Maxim Kuvyrkov
_ANTI); Please use "add_dependence_list (insn, deps->pending_jump_insns, 1, REG_DEP_ANTI);" instead. We want INSN to depend upon all of pending jumps, not just one of them. The situation where pending_jump_insns has more than a single jump does not happen in current setup of scheduling runs (as sched-rgn does not do interblock scheduling after reload), but that may change in the future. OK upon formal approval from Richard or other reviewer. Thank you, -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics

Re: [PATCH] reload: Try alternative with swapped operands before going to the next

2011-11-15 Thread Maxim Kuvyrkov
if (recog_data.dup_num[i] == commutative > ! || recog_data.dup_num[i] == commutative + 1) > ! *recog_data.dup_loc[i] > ! = recog_data.operand[(int) recog_data.dup_num[i]]; > ! ... here, ... > > ! tclass = preferred_class[commutative]; > ! preferred_class[commutative] = preferred_class[commutative + 1]; > ! preferred_class[commutative + 1] = tclass; > ! ... here, ... > > ! t = pref_or_nothing[commutative]; > ! pref_or_nothing[commutative] = pref_or_nothing[commutative + 1]; > ! pref_or_nothing[commutative + 1] = t; > ! ... and here. > > ! t = address_reloaded[commutative]; > ! address_reloaded[commutative] = address_reloaded[commutative + 1]; > ! address_reloaded[commutative + 1] = t; > ! } > ! } > } > >/* The operands don't meet the constraints. > > Thank you, -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics

Re: [PR50764, PATCH] Fix for ICE in maybe_record_trace_start with -fsched2-use-superblocks

2011-11-17 Thread Maxim Kuvyrkov
On 17/11/2011, at 9:58 PM, Tom de Vries wrote: > On 11/15/2011 10:07 PM, Maxim Kuvyrkov wrote: >> On 30/10/2011, at 8:17 AM, Tom de Vries wrote: >> >>> Richard, >>> >>> I have a tentative fix for PR50764. >> >> Richard, >> >&

Re: [PR 47382] We cannot simply fold OBJ_TYPE_REF at all in 4.6

2011-11-21 Thread Maxim Kuvyrkov
On 30/09/2011, at 6:56 PM, Maxim Kuvyrkov wrote: > On 30/09/2011, at 4:02 PM, Maxim Kuvyrkov wrote: > >> On 24/09/2011, at 2:19 AM, Martin Jambor wrote: >> >>> However, both of these are really 4.8 material and since the patches >>> probably need only minor u

Re: [PATCH] Distribute inliner's size_time data across entries with similar predicates

2011-11-21 Thread Maxim Kuvyrkov
On 28/10/2011, at 7:24 PM, Maxim Kuvyrkov wrote: > On 20/10/2011, at 10:32 PM, Jan Hubicka wrote: > >> Hi, >>> Jan, >>> >>> The following patch started as a one-liner for ipa-inline-analysis.c: >>> account_size_time() to merge predicates when

[PATCH, PR50335] Disable graphite loop flattening

2012-02-29 Thread Maxim Kuvyrkov
regressions? -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics fsf-gcc-pr50335.ChangeLog Description: Binary data fsf-gcc-pr50335.patch Description: Binary data

Re: [PATCH, PR50335] Disable graphite loop flattening

2012-03-01 Thread Maxim Kuvyrkov
On 1/03/2012, at 11:42 PM, Richard Guenther wrote: > On Thu, Mar 1, 2012 at 6:28 AM, Maxim Kuvyrkov wrote: >> This patch disables graphite loop flattening optimization due to it being >> effectively unmaintained. To avoid users trying to use unsupported >> optimizati

Re: [PATCH, 4.4, PR 52430] IPA-CP has to clone or leave alone externally_visible nodes

2012-03-01 Thread Maxim Kuvyrkov
stances of IPA_TOP -- those that can be obtained from subsequent else-if clauses. I.e., else if (!node->needed) type = !node->local.externally_visible ? IPA_TOP : IPA_BOTTOM; Thanks, -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics

Re: ifcvt cond_exec support rewrite

2012-03-02 Thread Maxim Kuvyrkov
ing > costs, > +etc. References to specific routines where we do the above core steps of algorithm (the upward walk, register assignment, etc.) would be very helpful here for someone trying to understand the implementation. Similarly, code references in other parts of this and other comment would be greatly appreciated. > Ideally we can convert the entire structure, but in complicated cases > +it's more likely that We end up with a forest of convertible sub-trees. s/We/we. Thank you, -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics

Re: ifcvt cond_exec support rewrite

2012-03-03 Thread Maxim Kuvyrkov
On 3/03/2012, at 1:55 PM, Maxim Kuvyrkov wrote: > On 30/09/2011, at 1:11 AM, Bernd Schmidt wrote: > ... >> >> The following patch rewrites essentially all the cond_exec support in >> ifcvt; reviewing is probably easier if it's thought of as new code. > >

Re: Cgraph alias reorg 8/14 (ipa-cp and ipa-prop update)

2011-07-12 Thread Maxim Kuvyrkov
'cs->callee' with 'callee' in ipcp_propagate_stage() except for in the check: if (ipa_is_called_with_var_arguments (callee_info) || !cs->callee->analyzed || ipa_is_called_with_var_arguments (callee_info)) continue; Is there a reason why you left 'cs->callee' intact in this case? Thank you, -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics

[PATCH] Improve combining of conditionals

2011-04-15 Thread Maxim Kuvyrkov
CoreMark by about 1%. OK for trunk? -- Maxim Kuvyrkov Mentor Graphics / CodeSourcery gcc-combine-if_then_else.ChangeLog Description: Binary data gcc-combine-if_then_else.patch Description: Binary data

Re: [PATCH] Improve combining of conditionals

2011-04-15 Thread Maxim Kuvyrkov
type as IN_DEST, i.e., an 'int'. I agree that 'bool' should be preferred when adding a new function or significantly rewriting an existing one. -- Maxim Kuvyrkov Mentor Graphics / CodeSourcery

Re: [PATCH] Improve combining of conditionals

2011-04-15 Thread Maxim Kuvyrkov
I have access to m68k (ColdFire, tbp) and will test this change there before committing. -- Maxim Kuvyrkov Mentor Graphics / CodeSourcery

Re: [PATCH] Improve combining of conditionals

2011-04-25 Thread Maxim Kuvyrkov
On Apr 15, 2011, at 4:38 PM, Maxim Kuvyrkov wrote: > On Apr 15, 2011, at 3:34 PM, Eric Botcazou wrote: > >>> The problem this patch fixes is that combine_simplify_rtx() prefers to >>> return an expression (say, ) even when a comparison is >>> prefered (say, ).

[PATCH][PR48170] Remove bogus asserts from gcse.c

2011-03-18 Thread Maxim Kuvyrkov
before a subsequent improvement to code hoisting was committed. The asserts were active only when a non-default value is used for the max-hoist-depth parameter, so no one noticed the outdated sanity checks before now. Thanks, -- Maxim Kuvyrkov Mentor Graphics / CodeSourcery +7-812-677-6839

[PATCH, M68K] Handle -fsched-pressure

2011-04-07 Thread Maxim Kuvyrkov
corner-case. I will commit this patch under the trivial rule in 4 days (on Monday) or sooner if I get an explicit approval. Thank you, -- Maxim Kuvyrkov Mentor Graphics / CodeSourcery +7-812-677-6839 fsf-gcc-m68k-sched_pressure.ChangeLog Description: Binary data fsf-gcc-m68k-sched_pressure.patch

[PATCH, testsuite, committed] Fix test for odd-TLS targets

2011-04-07 Thread Maxim Kuvyrkov
TLS ABI defines __m68k_read_tp() function to access thread-local storage, and to my knowledge, only GLIBC implements this, which makes the test fail on m68k-uclinux. Thanks, -- Maxim Kuvyrkov Mentor Graphics / CodeSourcery +7-812-677-6839 fsf-gcc-odd-tls-fix.ChangeLog Description: Binary data

Re: [PATCH, M68K] Handle -fsched-pressure

2011-04-07 Thread Maxim Kuvyrkov
On Apr 7, 2011, at 6:55 PM, Jeff Law wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 04/07/11 08:29, Maxim Kuvyrkov wrote: >> The following simple patch fixes a corner-case in m68k scheduling when >> -fsched-pressure is used. Currently m68k scheduli

[contrib] Extend and improve validate_failures.py

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
This patch series extends and improves validate_failures.py script to provide a powerful tool to handle DejaGnu test results in automated CI environment. Linaro TCWG uses validate_failures.py to ... - compare test results without human oversight, - detect unexpected FAILs vs baseline, - detect une

[PATCH 01/12] [contrib] validate_failures.py: Avoid testsuite aliasing

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
This patch adds tracking of current testsuite "tool" and "exp" to the processing of .sum files. This avoids aliasing between tests from different testsuites with same name+description. E.g., this is necessary for testsuite/c-c++-common, which is ran for both gcc and g++ "tools". This patch chang

[PATCH 04/12] [contrib] validate_failures.py: Simplify GetManifestPath()

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
... and don't require a valid build directory when no data from it is necessary. --- contrib/testsuite-management/validate_failures.py | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/contrib/testsuite-management/validate_failures.py b/contrib/testsuite-management

[PATCH 10/12] [contrib] validate_failures.py: Add new option --invert_match

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
This option is used to detect flaky tests that FAILed in the clean build (or manifest), but PASSed in the current build (or manifest). The option inverts output logic similar to what "-v/--invert-match" does for grep. --- .../testsuite-management/validate_failures.py | 34 +-- 1 f

[PATCH 03/12] [contrib] validate_failures.py: Read in manifest when comparing build dirs

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
This allows comparison of two build directories with a manifest listing known flaky tests on the side. --- contrib/testsuite-management/validate_failures.py | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/contrib/testsuite-management/validate_failures.py b/cont

[PATCH 02/12] [contrib] validate_failures.py: Support expiry attributes in manifests

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
--- contrib/testsuite-management/validate_failures.py | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/contrib/testsuite-management/validate_failures.py b/contrib/testsuite-management/validate_failures.py index 94ba2e58b51..7351ba120b7 100755 --- a/contrib/testsuite-m

[PATCH 06/12] [contrib] validate_failures.py: Be more stringent in parsing result lines

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
Before this patch we would identify malformed line "UNRESOLVEDTest run by tcwg-buildslave on Mon Aug 23 10:17:50 2021" as an interesting result, only to fail in TestResult:__init__ due to missing ":" after UNRESOLVED. This patch makes all places that parse result lines use a single compiled regex.

[PATCH 05/12] [contrib] validate_failures.py: Add more verbosity levels

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
... to control validate_failures.py output --- .../testsuite-management/validate_failures.py | 82 +++ 1 file changed, 46 insertions(+), 36 deletions(-) diff --git a/contrib/testsuite-management/validate_failures.py b/contrib/testsuite-management/validate_failures.py index 1bd09e

[PATCH 07/12] [contrib] validate_failures.py: Use exit code "2" to indicate regression

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
... in the results. Python exits with code "1" on exceptions and internal errors, which we use to detect failure to parse results. --- contrib/testsuite-management/validate_failures.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/testsuite-management/validate_failur

[PATCH 09/12] [contrib] validate_failures.py: Improve error output

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
From: Thiago Bauermann - Print message in case of broken sum file error. - Print error messages to stderr. The script's stdout is, usually, redirected to a file, and error messages shouldn't go there. --- contrib/testsuite-management/validate_failures.py | 5 - 1 file changed, 4 insertion

[PATCH 11/12] [contrib] validate_failures.py: Add "--expiry_date YYYYMMDD" option

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
This option sets "today" date to compare expiration entries against. Setting expiration date into the future allows re-detection of flaky tests and creating fresh entries for them before the current flaky entries expire. --- .../testsuite-management/validate_failures.py | 24 +-- 1

[PATCH 08/12] [contrib] validate_failures.py: Support "$tool:" prefix in exp names

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
From: Christophe Lyon This makes it easier to extract the $tool:$exp pair when iterating over failures/flaky tests, which, in turn, simplifies re-running testsuite parts that have unexpected failures or passes. --- contrib/testsuite-management/validate_failures.py | 8 +--- 1 file changed, 5

[PATCH 12/12] [contrib] validate_failures.py: Ignore stray filesystem paths in results

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
This patch simplifies comparison of results that have filesystem paths. E.g., (assuming different values of ): Running /home/user/gcc-N/gcc/testsuite/gcc.target/aarch64/sve/acle/aarch64-sve-acle-asm.exp ... ERROR: tcl error sourcing /home/user/gcc-N/gcc/testsuite/gcc.target/aarch64/sve/acle/aa

Re: [pushed] analyzer: implement various atomic builtins [PR109015]

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
/results.compare/*view*/ Thanks! -- Maxim Kuvyrkov https://www.linaro.org > On Jun 2, 2023, at 17:32, David Malcolm via Gcc-patches > wrote: > > This patch implements many of the __atomic_* builtins from > sync-builtins.def as known_function subclasses within the analyzer. &g

Re: [pushed] analyzer: implement various atomic builtins [PR109015]

2023-06-05 Thread Maxim Kuvyrkov via Gcc-patches
Hi David, Hm, I'm seeing this failure only in pre-commit testing, but I don't see it in our post-commit testing of gcc:master. Does this patch rely on your other patch committed just before this one? -- Maxim Kuvyrkov https://www.linaro.org > On Jun 3, 2023, at 09:23, Maxim Ku

Re: [PATCH 01/12] [contrib] validate_failures.py: Avoid testsuite aliasing

2023-06-05 Thread Maxim Kuvyrkov via Gcc-patches
> On Jun 3, 2023, at 19:17, Jeff Law wrote: > > On 6/2/23 09:20, Maxim Kuvyrkov via Gcc-patches wrote: >> This patch adds tracking of current testsuite "tool" and "exp" >> to the processing of .sum files. This avoids aliasing between >> tests from

Re: [r14-1579 Regression] FAIL: gfortran.dg/gomp/target-update-1.f90 -O scan-tree-dump gimple "#pragma omp target update to\\(c \\[len: [0-9]+\\]\\) to\\(present:a \\[len: [0-9]+\\]\\) to\\(e \\[len:

2023-06-07 Thread Maxim Kuvyrkov via Gcc-patches
(e [len: 4]) from(d [len: 4]) from(present:b [len: 4000]) Let me know if you need any help in troubleshooting this. -- Maxim Kuvyrkov https://www.linaro.org > On Jun 7, 2023, at 02:50, haochen.jiang via Gcc-patches > wrote: > > On Linux/x86_64, > > 4ede915d5dde935a16df2c

Re: [committed] libstdc++: Fix code size regressions in std::vector [PR110060]

2023-06-08 Thread Maxim Kuvyrkov via Gcc-patches
at has SPEC CPU2017 license, and I can post details to you privately. Kind regards, -- Maxim Kuvyrkov https://www.linaro.org > On Jun 1, 2023, at 19:09, Jonathan Wakely via Gcc-patches > wrote: > > Tested powerpc64le-linux. Pusshed to trunk. > > -- >8 -- > > M

Re: [PATCH] Handle FMA friendly in reassoc pass

2023-06-08 Thread Maxim Kuvyrkov via Gcc-patches
chmarks. Hi Cui, I'm seeing a 4% slowdown on 436.cactusADM from SPEC CPU2006 on aarch64-linux-gnu (Cortex-A57) when compiling with "-O2 -flto". All other benchmarks seem neutral to this patch, and I didn't observe the slow down with plain -O2 no-LTO or with -O3. I

Re: [PATCH] analyzer: Standalone OOB-warning [PR109437, PR109439]

2023-06-08 Thread Maxim Kuvyrkov via Gcc-patches
, line 17) FAIL: g++.dg/analyzer/pr100244.C -std=c++17 (test for warnings, line 17) FAIL: g++.dg/analyzer/pr100244.C -std=c++20 (test for warnings, line 17) === gcc tests === Running gcc:gcc.dg/analyzer/analyzer.exp ... FAIL: gcc.dg/analyzer/pr101962.c (test for warnings, line 19) Thanks, -

Re: [PATCH v6 0/4] P1689R5 support

2023-06-08 Thread Maxim Kuvyrkov via Gcc-patches
al compiler error: Segmentation fault) FAIL: g++.dg/modules/map-2.C -std=c++2b (test for excess errors) === Thanks, -- Maxim Kuvyrkov https://www.linaro.org > > [P1689R5]: https://isocpp.org/files/papers/P1689R5.html > > I've also added patches to include imported module

Re: [PR91598] Improve autoprefetcher heuristic in haifa-sched.c

2021-08-17 Thread Maxim Kuvyrkov via Gcc-patches
inor > codesize differences). So I think your proposed patch is OK as is. > > Cheers, > Wilco > > -- Maxim Kuvyrkov www.linaro.org 0001-Improve-autoprefetcher-heuristic-partly-fix-regressi.patch Description: Binary data

Re: [PATCH] Couple of debug dump improvements to scheduler (no code-gen changes)

2021-08-17 Thread Maxim Kuvyrkov via Gcc-patches
On Fri, 30 Aug 2019 at 01:57, Jeff Law wrote: > On 8/29/19 9:44 AM, Maxim Kuvyrkov wrote: > > Hi, > > > > The first patch adds ranking statistics for autoprefetcher heuristic. > > > > The second one makes it easier to diff scheduler debug dumps by adding &

Re: [PATCH] Add description of how testsuite parallelization works

2021-07-02 Thread Maxim Kuvyrkov via Gcc-patches
> On Jul 2, 2021, at 5:44 PM, Christophe Lyon > wrote: > > > > On Fri, Jul 2, 2021 at 4:29 PM Jakub Jelinek via Gcc-patches > wrote: > On Fri, Jul 02, 2021 at 05:20:33PM +0300, Maxim Kuvyrkov wrote: > > Hi Jakub, > > > > Thanks for helping m

[PATCH] [contrib] Remove broken compareSumTests3 script

2021-07-02 Thread Maxim Kuvyrkov via Gcc-patches
Hi Matthew, Hi Sebastian, This patch removes compareSumTests3, which appears to be broken. It tries to call compareSumFiles(), which is nowhere to be found and was never present in the GCC repo. OK to remove? Regards, -- Maxim Kuvyrkov https://www.linaro.org 0001-contrib-Remove-broken

Re: [r12-2132 Regression] FAIL: g++.dg/warn/Warray-bounds-20.C -std=gnu++98 note (test for warnings, line 55) on Linux/x86_64

2021-07-09 Thread Maxim Kuvyrkov via Gcc-patches
0.C -std=gnu++2a note (test for warnings, > line 38) > FAIL: g++.dg/warn/Warray-bounds-20.C -std=gnu++2a note (test for warnings, > line 55) > FAIL: g++.dg/warn/Warray-bounds-20.C -std=gnu++98 note (test for warnings, > line 38) > FAIL: g++.dg/warn/Warray-bounds-20.C -std=

Re: disable -Warray-bounds in libgo (PR 101374)

2021-07-09 Thread Maxim Kuvyrkov via Gcc-patches
nst U_8 * newval, U_8 *ptr); #define __kernel_cmpxchg64 (*(__kernel_cmpxchg64_t *) 0x0f60) /* Kernel helper for memory barrier. */ typedef void (__kernel_dmb_t) (void); #define __kernel_dmb (*(__kernel_dmb_t *) 0x0fa0) /* Kernel helper page version number. */ #define __kernel_helper_version (*(unsigned int *)0x0ffc) === -- Maxim Kuvyrkov https://www.linaro.org

Re: [Linaro-TCWG-CI] gcc patch #75674: FAIL: 68 regressions

2023-09-12 Thread Maxim Kuvyrkov via Gcc-patches
ist/ [2] https://sourceware.org/bugzilla/show_bug.cgi?id=29713 Thanks! -- Maxim Kuvyrkov https://www.linaro.org > On Sep 12, 2023, at 02:58, ci_not...@linaro.org wrote: > > Dear contributor, our automatic CI has detected problems related to your > patch(es). Please find some details below

Re: PATCH v6 4/4] ree: Improve ree pass for rs6000 target using defined ABI interfaces.

2023-09-18 Thread Maxim Kuvyrkov via Gcc-patches
://patchwork.sourceware.org/project/gcc/patch/5ad7cdca-63e1-73af-b38d-d58898e21...@linux.ibm.com/ [2] https://patchwork.sourceware.org/project/gcc/patch/65ed79a3-9964-dd50-39cb-98d5dbc72...@linux.ibm.com/ -- Maxim Kuvyrkov https://www.linaro.org > On Sep 18, 2023, at 09:59, Ajit Agarwal via

Re: [PATCH] middle-end/94188 fix fold of addr expression generation

2020-03-18 Thread Maxim Kuvyrkov via Gcc-patches
r: in gen_movsi, at config/arm/arm.md:6291 00:01:29 make[2]: *** [sound/drivers/serial-u16550.o] Error 1 Would you please investigate? Let me know if you need any help reproducing the problem. Kernel’s build line is (assuming cross-compilation): make CC=/path/to/arm-linux-gnueabihf-gcc

Re: [PATCH] tree-optimization PR/101014 - Limit new value calculations to first order effects.

2021-06-16 Thread Maxim Kuvyrkov via Gcc-patches
> > -void > -ranger_cache::enable_new_values () > -{ > - m_new_value_p = true; > -} > - > -// Disable new value querying. > - > -void > -ranger_cache::disable_new_values () > +bool > +ranger_cache::enable_new_values (bool state) > { > - m_new_value_p

Re: [PATCH] Avoid loading an undefined value in the ranger_cache constructor.

2021-06-17 Thread Maxim Kuvyrkov via Gcc-patches
> On 16 Jun 2021, at 20:14, Andrew MacLeod wrote: > > On 6/16/21 5:41 AM, Maxim Kuvyrkov wrote: >> >>> + m_new_value_p = state; >>> + return ret; >>> } >>>// Dump the caches for basic block BB to file F. >> Thanks, >> >

[PATCH] Add description of how testsuite parallelization works

2021-07-02 Thread Maxim Kuvyrkov via Gcc-patches
Hi Jakub, Thanks for helping me on IRC with debugging testsuite problems. Does this write up look good? Regards, -- Maxim Kuvyrkov https://www.linaro.org 0001-Add-description-of-how-testsuite-parallelization-wor.patch Description: Binary data

<    1   2   3   4