Re: [PATCH v6] RISC-V:Optimize the MASK opt generation

2023-10-01 Thread Jan-Benedict Glaw
On Mon, 2023-10-02 10:55:25 +0800, Kito Cheng wrote: > Hi Gerald: > > Thanks for reporting this issue, I just realized multidimensional > arrays are gawk extensions, could you try the attached patch to see if > it can resolve the issue? With your new patch, it works for me again using `mawk` (cf

Re: [PATCH] Remove poly_int_pod

2023-10-02 Thread Jan-Benedict Glaw
Hi Richard, On Thu, 2023-09-28 10:55:46 +0100, Richard Sandiford wrote: > poly_int was written before the switch to C++11 and so couldn't > use explicit default constructors. This led to an awkward split > between poly_int_pod and poly_int. poly_int simply inherited from > poly_int_pod and add

Re: [PATCH] LoongArch: Reimplement multilib build option handling.

2023-10-04 Thread Jan-Benedict Glaw
Hi! On Wed, 2023-09-13 17:52:14 +0800, Yang Yujie wrote: > Library build options from --with-multilib-list used to be processed with > *self_spec, which missed the driver's initial canonicalization. This > caused limitations on CFLAGS override and the use of driver-only options > like -m[no]-lsx

Re: [PATCH] LoongArch: Reimplement multilib build option handling.

2023-10-07 Thread Jan-Benedict Glaw
Hi! On Sat, 2023-10-07 15:08:34 +0800, Xi Ruoyao wrote: > On Sat, 2023-10-07 at 11:41 +0800, Yang Yujie wrote: > > Thanks for the testing! > > > > This error seems to be difficult to reproduce since it is a makefile > > dependency > > problem.  I think appending loongarch-multilib.h to $(GTM_H)

Re: [PATCH] LoongArch: Adjust makefile dependency for loongarch headers.

2023-10-08 Thread Jan-Benedict Glaw
On Sat, 2023-10-07 16:50:14 +0800, Yang Yujie wrote: > gcc/ChangeLog: > > * config.gcc: Add loongarch-driver.h to tm_files. > * config/loongarch/loongarch.h: Do not include loongarch-driver.h. > * config/loongarch/t-loongarch: Append loongarch-multilib.h to $(GTM_H) > inst

Re: [COMMITTED] ada: Remove the body of System.Storage_Elements

2023-05-29 Thread Jan-Benedict Glaw
Hi Eric! On Tue, 2023-05-23 10:08:26 +0200, Marc Poulhiès via Gcc-patches wrote: > From: Eric Botcazou > > All the subprograms declared in the unit have convention Intrinsic and > their current implementation makes some implicit assumptions that are > not valid universally, so it is replaced b

Re: [COMMITTED] ada: Remove the body of System.Storage_Elements

2023-05-29 Thread Jan-Benedict Glaw
On Mon, 2023-05-29 16:11:26 +0200, Marc Poulhiès wrote: > Jan-Benedict Glaw writes: > > (A full build log is at > > http://toolchain.lug-owl.de/laminar/jobs/gcc-aarch64-linux/74) > > > > Is this an issue with the patch? Or does it need a newer Ada compiler > > t

Re: [COMMITTED] ada: Remove the body of System.Storage_Elements

2023-05-30 Thread Jan-Benedict Glaw
On Tue, 2023-05-30 09:05:43 +0100, Maciej W. Rozycki wrote: [Ada as a cross-compiler fails to build with a slightly-older compiler.] > Alternatively you can just bootstrap GCC under test natively first and > then use the newly-built compiler for all the cross builds you want to > verify. As y

Re: [PATCH 2/3] ivopts: Call valid_mem_ref_p with code_helper [PR110248]

2023-08-14 Thread Jan-Benedict Glaw
On Fri, 2023-06-30 13:46:40 +0800, Kewen.Lin via Gcc-patches wrote: > Bootstrapped and regtested on x86_64-redhat-linux and > powerpc64{,le}-linux-gnu. > > Is it ok for trunk? [...] > diff --git a/gcc/recog.h b/gcc/recog.h > index badf8e3dc1c..c6ef619c5dd 100644 > --- a/gcc/recog.h > +++ b/gcc/

[PATCH] config-list.mk i686-solaris2.11: Use --with-gnu-as

2023-08-15 Thread Jan-Benedict Glaw
Hi! i686-solaris2.11: Use --with-gnu-as for mass-building tests As `config-list.mk` is probably mostly used on Linux system, where Solaris's `as` isn't available, let's use GNU `as` as the default. contrib/ChangeLog: * config-list.mk (i686-solaris2.11): Use --with-gnu-as. diff --git a/

[PATCH] config-list.mk Darwin: Use --with-gnu-as

2023-08-15 Thread Jan-Benedict Glaw
Hi! config-list.mk Darwin: Use --with-gnu-as for mass-building tests As `config-list.mk` is probably mostly used on Linux system, where Apple's tools aren't around. Let's use --with-gnu-as instead to have an useable assembler. contrib/ChangeLog: * config-list.mk (i686-apple-darwin): Use

Re: [PATCH] config-list.mk Darwin: Use --with-gnu-as

2023-08-16 Thread Jan-Benedict Glaw
Hi Rainer! On Tue, 2023-08-15 21:49:37 +0200, Rainer Orth wrote: > > config-list.mk Darwin: Use --with-gnu-as for mass-building tests > > > > As `config-list.mk` is probably mostly used on Linux system, where > > Apple's tools aren't around. Let's use --with-gnu-as instead to have > > an useable

[PATCH] Fix code_helper unused argument warning for fr30

2023-08-17 Thread Jan-Benedict Glaw
Hi! fr30 is the only target defining GO_IF_LEGITIMATE_ADDRESS right now, in which case the `code_helper ch` argument to memory_address_addr_space_p() is unused and emits a new warning. gcc/ChangeLog: * recog.cc (memory_address_addr_space_p): Mark possibly unused argument as unused

GCC nvptx: Silence warning?

2023-06-23 Thread Jan-Benedict Glaw
Hi Tom! Building with newer GCC versions (I'm doing CI builds with -Werror), we might see warnings like this: /usr/lib/gcc-snapshot/bin/g++ -fno-PIE -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-stri

Re: [PATCH] Move substitute_and_fold over to use simple_dce_from_worklist

2023-06-25 Thread Jan-Benedict Glaw
Hi Andrew, On Fri, 2023-05-05 08:17:19 -0700, Andrew Pinski via Gcc-patches wrote: > While looking into a different issue, I noticed that it > would take until the second forwprop pass to do some > forward proping and it was because the ssa name was > used more than once but the second statement

Re: [PATCH] Move substitute_and_fold over to use simple_dce_from_worklist

2023-06-26 Thread Jan-Benedict Glaw
Hi Andrew, On Mon, 2023-06-26 09:13:51 -0700, Andrew Pinski wrote: > On Sun, Jun 25, 2023 at 10:59 PM Jan-Benedict Glaw wrote: > > On Fri, 2023-05-05 08:17:19 -0700, Andrew Pinski via Gcc-patches > > wrote: > > > While looking into a different issue, I noticed that i

Re: [PATCH v4 4/9] MIPS: Add bitwise instructions for mips16e2

2023-07-06 Thread Jan-Benedict Glaw
Hi! On Mon, 2023-06-19 16:29:53 +0800, Jie Mei wrote: > There are shortened bitwise instructions in the mips16e2 ASE, > for instance, ANDI, ORI/XORI, EXT, INS etc. . > > This patch adds these instrutions with corresponding tests. [...] Starting with this patch, I see some new warning: [all 20

Re: [PATCH v4 4/9] MIPS: Add bitwise instructions for mips16e2

2023-07-07 Thread Jan-Benedict Glaw
On Fri, 2023-07-07 16:38:51 +0800, 梅杰 wrote: > 在 2023/7/7 07:06, Jan-Benedict Glaw 写道: > > On Mon, 2023-06-19 16:29:53 +0800, Jie Mei > > wrote: > > > There are shortened bitwise instructions in the mips16e2 ASE, > > > for instance, ANDI, ORI/XORI, EXT, INS et

[patch] bpf: Fix double whitespace warning

2023-02-15 Thread Jan-Benedict Glaw
Hi! Since a recent commit, the BPF target produces a new warning due to two consecutive non-quoted spaces in a message. This'll fix it: gcc/ * config/bpf/bpf.cc (bpf_option_override): Fix doubled space. Ok? MfG, JBG diff --git a/gcc/config/bpf/bpf.cc b/gcc/config/bpf/bpf.cc index b26

Re: Rust: In 'type_for_mode' langhook also consider all 'int_n' modes/types (was: Modula-2 / Rust: Many targets failing)

2023-02-24 Thread Jan-Benedict Glaw
Hi Thomas / Arthur! On Wed, 2023-02-22 15:30:37 +0100, Arthur Cohen wrote: [..] > > > --target=msp430-elfbare > > > ~ > > > > > > /var/lib/laminar/run/gcc-msp430-elfbare/24/toolchain-build/./gcc/xgcc > > > -B/var/lib/laminar/run/gcc-msp430-elfbare/24/toolchain-

Re: Rust: In 'type_for_mode' langhook also consider all 'int_n' modes/types (was: Modula-2 / Rust: Many targets failing)

2023-02-25 Thread Jan-Benedict Glaw
Hi Thomas, On Wed, 2023-02-22 12:25:01 +0100, Thomas Schwinge wrote: > On 2022-12-19T22:23:45+0100, Jan-Benedict Glaw wrote: > > Rust related issues > > = > > > > --target=msp430-elfbare > > ~ > > /va

Re: [PATCH] add glibc-stdint.h to vax and lm32 linux target (PR target/105525)

2023-05-22 Thread Jan-Benedict Glaw
Hi! On Mon, 2023-05-22 14:10:48 +0100, Maciej W. Rozycki wrote: > On Fri, 19 May 2023, Mikael Pettersson wrote: > > The background is that I maintain a script to build GCC-based crosses to > > as many targets as I can, currently it supports 78 distinct processors and > > 82 triplets (four process

Re: [PATCH] add glibc-stdint.h to vax and lm32 linux target (PR target/105525)

2023-05-22 Thread Jan-Benedict Glaw
Hi Mikael! On Mon, 2023-05-22 17:25:39 +0200, Mikael Pettersson wrote: > On Mon, May 22, 2023 at 3:57 PM Jan-Benedict Glaw wrote: > > On Mon, 2023-05-22 14:10:48 +0100, Maciej W. Rozycki > > wrote: > > > On Fri, 19 May 2023, Mikael Pettersson wrote: > > > &g

[patch] mcore: Fix sprintf length warning

2023-05-22 Thread Jan-Benedict Glaw
Hi! One of the supplied argument strings is unneccesarily long (c-sky, using basically the same code, fixed it to a shorter length) and this fixes overflow warnings, as GCC fails to deduce that the full 256 bytes for load_op[] are not used at all. make[1]: Entering directory '/var/lib/laminar/r

[COMMITTED] Fix unused variable warning (was: [PATCH 1/3] STABS: remove -gstabs and -gxcoff functionality)

2022-09-14 Thread Jan-Benedict Glaw
ibdecnumber/dpd -I../libdecnumber -I../../gcc/gcc/../libbacktrace -o mips.o -MT mips.o -MMD -MP -MF ./.deps/mips.TPo ../../gcc/gcc/config/mips/mips.cc ../../gcc/gcc/config/mips/mips.cc: In function 'void mips_option_override()': ../../gcc/gcc/config/mips/mips.cc:20021:10:

[ping] [PATCH] C-SKY: Fix unsigned comparison warning

2022-09-16 Thread Jan-Benedict Glaw
On Mon, 2022-09-12 14:19:23 +0200, Jan-Benedict Glaw wrote: > 2022-09-06 Jan-Benedict Glaw > > gcc/ChangeLog: > * config/csky/csky.h (FUNCTION_ARG_REGNO_P): Cast REGNO to (int) > to prevent warning. > > diff --git a/gcc/config/csky/csky.h b/gcc/confi

Re: [committed] More infrastructure to avoid bogus RTL on H8

2022-10-25 Thread Jan-Benedict Glaw
Hi Jeff! On Mon, 2022-10-17 17:47:16 -0600, Jeff Law via Gcc-patches wrote: > --- a/gcc/config/h8300/h8300.cc > +++ b/gcc/config/h8300/h8300.cc > @@ -5531,6 +5531,32 @@ h8300_ok_for_sibcall_p (tree fndecl, tree) > >return 1; > } > + > +/* Return TRUE if OP is a PRE_INC or PRE_DEC > + in

Re: [PATCH v3] xtensa: Prepare the transition from Reload to LRA

2022-10-25 Thread Jan-Benedict Glaw
Hi! On Wed, 2022-10-19 17:16:24 +0900, Takayuki 'January June' Suwa via Gcc-patches wrote: > * gcc/config/xtensa/xtensa.md: Add two new split patterns: > - splits DImode immediate load into two SImode ones > - puts out-of-constraint SImode constants into the constant pool

Re: [PATCH] cr16: remove obsoleted port

2022-08-25 Thread Jan-Benedict Glaw
On Thu, 2022-08-25 10:38:30 +0200, Martin Liška wrote: > Remove the port that has been marked obsolete in GCC 12 change notes. > contrib/ChangeLog: > > * config-list.mk: Remove cr16. Thanks for not forgetting this part! I hope the scripts will properly pick up the cr16 removal. We'll fin

Re: [PATCH] cr16: remove obsoleted port

2022-08-25 Thread Jan-Benedict Glaw
On Thu, 2022-08-25 14:50:12 +0200, Martin Liška wrote: > On 8/25/22 14:48, Jan-Benedict Glaw wrote: > > On Thu, 2022-08-25 10:38:30 +0200, Martin Liška wrote: > >> Remove the port that has been marked obsolete in GCC 12 change notes. > > > >> contrib/ChangeL

Re: [PATCH] Always default to DWARF2_DEBUG if not specified, warn about deprecated STABS

2022-08-28 Thread Jan-Benedict Glaw
On Tue, 2021-09-21 16:25:19 +0200, Richard Biener via Gcc-patches wrote: > This makes defaults.h choose DWARF2_DEBUG if PREFERRED_DEBUGGING_TYPE > is not specified by the target and errors out if DWARF DWARF is not supported. While I think the pdp11 bits arreved, the rest did not (yet). Just che

[PATCH] nvptx: Silence unused variable warning

2022-08-28 Thread Jan-Benedict Glaw
Hi! The nvptx backend defines ASM_OUTPUT_DEF along with ASM_OUTPUT_DEF_FROM_DECLS. Much like the rs6000 coff target, nvptx triggers an unused variable warning: /usr/lib/gcc-snapshot/bin/g++ -fno-PIE -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions -fno-rtti -fasynchronous

Re: [PATCH] Always default to DWARF2_DEBUG if not specified, warn about deprecated STABS

2022-08-29 Thread Jan-Benedict Glaw
Hi Jeff! On Sun, 2022-08-28 15:32:53 -0600, Jeff Law via Gcc-patches wrote: > On 8/28/2022 1:50 AM, Jan-Benedict Glaw wrote: > > On Tue, 2021-09-21 16:25:19 +0200, Richard Biener via Gcc-patches > > wrote: > > > This makes defaults.h choose DWARF2_DEBUG if PREFERRED

[PATCH] bpf: Fix unused variable warning

2022-09-05 Thread Jan-Benedict Glaw
Hi! Building for for bpf-unknown-none target, recent GCCs will issue an unused variable warning as the REGNO_REG_CLASS macro doesn't actually use its argument. Reference the argument as (void) to silence the warning. .../gcc/configure --prefix=... --enable-werror-always --enable-languages=all --

[PATCH] msp430: Mark unused attribute

2022-09-06 Thread Jan-Benedict Glaw
]: Leaving directory '/var/lib/laminar/run/gcc-msp430-elf/1/toolchain-build/gcc' make: *** [Makefile:4584: all-gcc] Error 2 2022-09-06 Jan-Benedict Glaw gcc/ChangeLog: * config/msp430/msp430.cc (msp430_single_op_cost): Mark unused argument. diff --git a/gcc/config/msp430

Re: [PATCH] Always default to DWARF2_DEBUG if not specified, warn about deprecated STABS

2022-09-07 Thread Jan-Benedict Glaw
Hi! On Mon, 2022-08-29 22:11:35 +0200, Jan-Benedict Glaw wrote: > On Sun, 2022-08-28 15:32:53 -0600, Jeff Law via Gcc-patches > wrote: > > On 8/28/2022 1:50 AM, Jan-Benedict Glaw wrote: > > > On Tue, 2021-09-21 16:25:19 +0200, Richard Biener via Gcc-patches > > &

Re: [PATCH v3] Simplify memchr with small constant strings

2022-09-07 Thread Jan-Benedict Glaw
Hi! On Wed, 2022-07-13 09:50:14 -0700, H.J. Lu via Gcc-patches wrote: > When memchr is applied on a constant string of no more than the bytes of > a word, simplify memchr by checking each byte in the constant string. > > int f (int a) > { >return __builtin_memchr ("AE", a, 2) != 0; > } >

[PATCH] mingw32: Fix warning, update documentation

2022-09-08 Thread Jan-Benedict Glaw
Leaving directory '/var/lib/laminar/run/gcc-x86_64-w64-mingw32/1/toolchain-build/gcc' make: *** [Makefile:4588: all-gcc] Error 2 Also, when TARGET_OVERRIDES_FORMAT_ATTRIBUTES is defined, TARGET_OVERRIDES_FORMAT_ATTRIBUTES_COUNT must be defined as well. Add that requirement t

Re: [PATCH v3] Simplify memchr with small constant strings

2022-09-09 Thread Jan-Benedict Glaw
Hi! On Wed, 2022-09-07 14:00:25 +0200, Richard Biener wrote: > On Wed, Sep 7, 2022 at 12:58 PM Jan-Benedict Glaw wrote: > > ../../gcc/gcc/tree-ssa-forwprop.cc:1258:42: error: array subscript 1 is > > outside array bounds of 'tree_node* [1]' [-Werror=array-bounds] >

Re: [PATCH] Implement known/maybe fpclassify like API for frange.

2022-09-12 Thread Jan-Benedict Glaw
Hi Aldy! On Thu, 2022-09-08 12:56:24 +0200, Aldy Hernandez via Gcc-patches wrote: > From 795baa0b044953e9f198f49e379374d633f43b47 Mon Sep 17 00:00:00 2001 > From: Aldy Hernandez > Date: Thu, 8 Sep 2022 08:11:43 +0200 > Subject: [PATCH] Implement known/maybe fpclassify like API for frange. > >

[PATCH] C-SKY: Fix unsigned comparison warning

2022-09-12 Thread Jan-Benedict Glaw
efile:1146: builtins.o] Error 1 The needed (int) cast is even mentioned in the comment above, so reinstate it here. 2022-09-06 Jan-Benedict Glaw gcc/ChangeLog: * config/csky/csky.h (FUNCTION_ARG_REGNO_P): Cast REGNO to (int) to prevent warning. diff --git a/gcc/config/csky/c

Re: [PATCH] Implement known/maybe fpclassify like API for frange.

2022-09-12 Thread Jan-Benedict Glaw
Hi Aldy! On Mon, 2022-09-12 15:12:46 +0200, Aldy Hernandez wrote: > On Mon, Sep 12, 2022 at 10:48 AM Jan-Benedict Glaw wrote: > > > > On Thu, 2022-09-08 12:56:24 +0200, Aldy Hernandez via Gcc-patches > > wrote: > > > > > From 795baa0b044953e9f198f49e37937

[PATCH] Fix multi-statement define for alpha-dec-vms

2021-09-12 Thread Jan-Benedict Glaw
Hi! While mass-building a cross-gcc, I noticed that for alpha-dec-vms/alpha64-dec-vms, recent GCC versions correctly throw a warning due to a multi-statement define that gets rippen in an if/else case: [all 2021-09-12 15:51:55] /usr/lib/gcc-snapshot/bin/g++ -fno-PIE -c -g -O2 -DIN_GCC -DCROS

Re: [PATCH] Remove dbx.h, do not set PREFERRED_DEBUGGING_TYPE from dbxcoff.h, lynx.h

2021-09-12 Thread Jan-Benedict Glaw
Hi Richard, On Fri, 2021-09-10 08:02:00 +0200, Richard Biener via Gcc-patches wrote: > > On 9/9/2021 7:19 AM, Richard Biener via Gcc-patches wrote: > > > The patch also removes the PREFERRED_DEBUGGING_TYPE define from > > > lynx.h which always follows elfos.h already defaulting to DWARF, > > > s

Re: [PATCH] Add cr16-*-* to the list of obsoleted targets

2021-09-13 Thread Jan-Benedict Glaw
Hi Richard, On Mon, 2021-09-13 11:24:53 +0200, Richard Biener via Gcc-patches wrote: > This adds cr16-*-* to the list of obsoleted targets in config.gcc > > Approved by Jeff in another thread, pushed. cr16 has no maintainer and > it's still cc0. > > 2021-09-13 Richard Biener > > * c

Re: [PATCH] Fix multi-statement define for alpha-dec-vms

2021-09-13 Thread Jan-Benedict Glaw
Hi! On Mon, 2021-09-13 11:11:30 +0200, Richard Biener wrote: > On Sun, Sep 12, 2021 at 8:12 PM Jan-Benedict Glaw wrote: > > gcc/ChangeLog: > > > > * config/alpha/vms.h (INIT_CUMULATIVE_ARGS): Wrap multi-statment > > define into a block. > OK.

Re: [PATCH] Add cr16-*-* to the list of obsoleted targets

2021-09-13 Thread Jan-Benedict Glaw
Hi! On Mon, 2021-09-13 11:58:59 +0200, Richard Biener wrote: > On Mon, 13 Sep 2021, Jan-Benedict Glaw wrote: > > contrib/ChangeLog: > > > > * config-list.mk (LIST): --enable-obsolete for cr16-elf. > > [...] > OK. Committed, thanks! MfG, JBG -- signature.asc Description: PGP signature

[AVR] Fix unused argument warning

2021-09-30 Thread Jan-Benedict Glaw
Hi! Configuring GCC with --target=avr-elf --enable-werror-always, I see this warning that's easy to fix. The options are parsed with a lot of #ifdefs and it may actually just be unused. Let's just mark it as such. [all 2021-09-30 00:43:46] /usr/lib/gcc-snapshot/bin/g++ -fno-PIE -c -g -O2 -DIN

[LM32] Fix '"LINK_GCC_C_SEQUENCE_SPEC" redefined' warning

2021-09-30 Thread Jan-Benedict Glaw
Hi! When configuring GCC for --target=lm32-uclinux --enable-werror-always, it breaks here: [all 2021-09-30 08:55:55] /usr/lib/gcc-snapshot/bin/g++ -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings

[PATCH, arc]: Drop "register" keyword

2021-05-26 Thread Jan-Benedict Glaw
Hi! I'd like to commit the following patch. Okay for master? Thanks, Jan-Benedict arc: Remove useless register keyword The "register" keyword was removed in C++17, remove them to get the backen to build again. gcc/ * config/arc/arc.c (arc_address_cost,

Re: [PATCH, arc]: Drop "register" keyword

2021-05-26 Thread Jan-Benedict Glaw
Hi Jukub & Richard, On Wed, 2021-05-26 14:47:20 +0200, Jakub Jelinek wrote: > On Wed, May 26, 2021 at 02:42:47PM +0200, Jan-Benedict Glaw wrote: > > The "register" keyword was removed in C++17, remove them to get the > > backen > > s/ba

PING: [AVR] Fix unused argument warning

2021-10-05 Thread Jan-Benedict Glaw
Hi, On Thu, 2021-09-30 21:27:23 +0200, Jan-Benedict Glaw wrote: > gcc/ChangeLog: > > * common/config/avr/avr-common.c (avr_handle_option): Mark > argument as ATTRIBUTE_UNUSED. > > diff --git a/gcc/common/config/avr/avr-common.c > b/gcc/common/config/avr

PING: [LM32] Fix '"LINK_GCC_C_SEQUENCE_SPEC" redefined' warning

2021-10-05 Thread Jan-Benedict Glaw
Hi, On Thu, 2021-09-30 21:34:51 +0200, Jan-Benedict Glaw wrote: > gcc/ChangeLog: > > * config/lm32/uclinux-elf.h (LINK_GCC_C_SEQUENCE_SPEC): > Undefine before redefinition. > > diff --git a/gcc/config/lm32/uclinux-elf.h b/gcc/config/lm32/uclinux-elf.h &

Re: PING: [AVR] Fix unused argument warning

2021-10-05 Thread Jan-Benedict Glaw
Hi Jeff, On Tue, 2021-10-05 08:53:00 -0600, Jeff Law wrote: > On 10/5/2021 8:46 AM, Jan-Benedict Glaw wrote: > > On Thu, 2021-09-30 21:27:23 +0200, Jan-Benedict Glaw > > wrote: > > > gcc/ChangeLog: > > > > > > * common/config/avr/avr-common.c (av

Re: [PATCH] Cleanup --params for backward threader.

2021-10-19 Thread Jan-Benedict Glaw
Hi Aldy! On Thu, 2021-10-14 16:25:48 +0200, Aldy Hernandez via Gcc-patches wrote: > The new backward threader makes some of the --param knobs used to > control it questionable at best or no longer applicable at worst. > > The fsm-maximum-phi-arguments param is unused and can be removed. > > Th

Re: [PATCH] Restore --param=max-fsm-thread-length

2021-10-20 Thread Jan-Benedict Glaw
On Wed, 2021-10-20 09:43:42 +0200, Aldy Hernandez via Gcc-patches wrote: > The removal of --param=max-fsm-thread-length is causing code > explosion. I thought that --param=max-fsm-thread-path-insns was a > better gague for path profitability than raw BB length, but it turns > out that we don't t

Re: [PATCH] Always default to DWARF2_DEBUG if not specified, warn about deprecated STABS

2021-10-23 Thread Jan-Benedict Glaw
Hi Richard, On Tue, 2021-09-21 16:25:19 +0200, Richard Biener via Gcc-patches wrote: > I have built all targets from contrib/config-list.mk to make sure we > don't run into the #error and the following makes the STABS usage > explicit for pdp11 and hppa with SOM. I'm running build tests based o

Re: [PATCH] Always default to DWARF2_DEBUG if not specified, warn about deprecated STABS

2021-10-24 Thread Jan-Benedict Glaw
Hi Richard, On Sun, 2021-10-24 08:36:36 +0200, Richard Biener wrote: > On October 23, 2021 10:00:05 PM GMT+02:00, Jan-Benedict Glaw > wrote: > >On Tue, 2021-09-21 16:25:19 +0200, Richard Biener via Gcc-patches > > wrote: > >> I have built all targets from contrib/

Re: [PATCH 0/13] v2 warning control by group and location (PR 74765)

2021-07-17 Thread Jan-Benedict Glaw
Hi Martin! On Fri, 2021-06-04 15:27:04 -0600, Martin Sebor wrote: > This is a revised patch series to add warning control by group and > location, updated based on feedback on the initial series. [...] My automated checking (in this case: Using Debian's "gcc-snapshot" package) indicates that bet

Re: [patch,avr,applied] PR target/112952 Fix attribute "io" et al. handling.

2024-01-11 Thread Jan-Benedict Glaw
On Thu, 2024-01-04 17:28:02 +0100, Georg-Johann Lay wrote: > This fixes the avr-specific attributes io, io_low and address, > that are all basically the same except that io and io_low imply > assertions on allowed addressing modes. > --- a/gcc/config/avr/avr.cc > +++ b/gcc/config/avr/avr.cc [...]

Re: [PATCH v2 1/2] Implement ASM_DECLARE_FUNCTION_NAME using ASM_OUTPUT_FUNCTION_LABEL

2024-01-12 Thread Jan-Benedict Glaw
On Tue, 2024-01-02 20:41:37 +0100, Ilya Leoshkevich wrote: > diff --git a/gcc/config/ia64/ia64.cc b/gcc/config/ia64/ia64.cc > index ac566efcf19..92d00bf922f 100644 > --- a/gcc/config/ia64/ia64.cc > +++ b/gcc/config/ia64/ia64.cc > @@ -3886,8 +3886,7 @@ ia64_expand_prologue (void) > /* Output the t

Modula-2 / Rust: Many targets failing

2022-12-19 Thread Jan-Benedict Glaw
Hi! With the recent merges for Modula-2 and Rust, I see a good number of targets failing with --enable-languages=all, mostly due to issues with the Modula-2 driver. Modula-2 related issues = --target=x86_64-apple-darwin ~~ /bin/bash

Re: [PATCH 5/8 v2] middle-end: Add cltz_complement idiom recognition

2023-01-19 Thread Jan-Benedict Glaw
On Thu, 2022-12-22 17:42:16 +, Andrew Carlotti via Gcc-patches wrote: > New patch below, bootstrapped and regression tested on > aarch64-unknown-linux-gnu and x86_64-pc-linux-gnu - ok to merge? > diff --git a/gcc/tree-ssa-loop-niter.cc b/gcc/tree-ssa-loop-niter.cc > index > fece876099c16875

Re: [PATCH 3/6] arm: [MVE intrinsics] Add support for contiguous loads and stores

2023-11-23 Thread Jan-Benedict Glaw
On Thu, 2023-11-16 15:26:14 +, Christophe Lyon wrote: > diff --git a/gcc/config/arm/arm-mve-builtins-functions.h > b/gcc/config/arm/arm-mve-builtins-functions.h > index eba1f071af0..6d234a2dd7c 100644 > --- a/gcc/config/arm/arm-mve-builtins-functions.h > +++ b/gcc/config/arm/arm-mve-builtins

Re: [PATCH 00/11] CodeView variables and type system

2024-08-12 Thread Jan-Benedict Glaw
On Tue, 2024-06-18 01:17:02 +0100, Mark Harmstone wrote: > This patch series adds support for outputting global variables when the > -gcodeview option is provided, along with the type system to go along > with this. [...] > This ought to be fairly complete as far as C is concerned. Still to come >

Re: [COMMITTED 2/5] Fix ranger when called from SCEV.

2024-05-13 Thread Jan-Benedict Glaw
On Tue, 2024-04-30 17:24:15 -0400, Andrew MacLeod wrote: > Bootstrapped on x86_64-pc-linux-gnu with no regressions.  pushed. Starting with this patch (upstream as e8ae56a7dc46e39a48017bb5159e4dc672ec7fad, can still be reproduced with 0c585c8d0dd85601a8d116ada99126a48c8ce9fd as of May 13th), my CI

Re: [COMMITTED 2/5] Fix ranger when called from SCEV.

2024-05-13 Thread Jan-Benedict Glaw
On Mon, 2024-05-13 20:19:42 +0200, Jan-Benedict Glaw wrote: > On Tue, 2024-04-30 17:24:15 -0400, Andrew MacLeod wrote: > > Bootstrapped on x86_64-pc-linux-gnu with no regressions.  pushed. > > Starting with this patch (upstream as > e8ae56a7dc46e39a48017bb5159e4dc672ec

[Ping] VAX: Fix ICE during operand output

2013-08-21 Thread Jan-Benedict Glaw
On Wed, 2013-07-31 18:34:26 +0200, Jan-Benedict Glaw wrote: > Hi! > > We've seen ICEs while outputting an operand (not even the excessive > CISC of a VAX could do that), which should be fixed by this patch: > > 2013-07-31 Jan-Benedict Glaw > > * confi

Re: [Patch] Rewrite regex matchers

2013-08-30 Thread Jan-Benedict Glaw
t gcc emit, so perhaps you > need -gdwarf-3 -gstrict-dwarf or similar. But please keep in mind that size is not everything. Cachelines count, too! If you save four or eight bytes off of a stackframe (or struct or whatever), but sacrifice a cacheline or two to access badly layouted variables i

[Ping^2 PATCH] VAX: Fix ICE during operand output

2013-09-13 Thread Jan-Benedict Glaw
On Wed, 2013-07-31 18:34:26 +0200, Jan-Benedict Glaw wrote: > We've seen ICEs while outputting an operand (not even the excessive > CISC of a VAX could do that), which should be fixed by this patch: > > 2013-07-31 Jan-Benedict Glaw > > * config/vax/constrai

[buildrobot] [PATCH] r202527: ssa / ssanames restructure broke alpha-linux

2013-09-14 Thread Jan-Benedict Glaw
from tree-flow*.h * Makefile.in (tree-ssanames.h): Add to tree-ssanames.o and GTFILES. See for example this build log: http://toolchain.lug-owl.de/buildbot/showlog.php?id=11663&mode=view I suggest this patch, which fixes an alpha-linux build for me: 2013-09-13 Jan-Benedict

Re: [buildrobot] [PATCH] r202527: ssa / ssanames restructure broke alpha-linux

2013-09-16 Thread Jan-Benedict Glaw
es in gcc/Makefile.in. > > However, we still need tree-flow.h, but instead of tree-ssa.h, we can > include tree-ssanames.h: > > I will commit attached incremental patch, once bootstrap finish. Please don't forget the dep's in gcc/Makefile.in as mentioned above. MfG, JBG --

[PATCH] target/56875: Work around buggy GAS

2013-09-20 Thread Jan-Benedict Glaw
tions, use these. +global DEFAULT_CFLAGS +if ![info exists DEFAULT_CFLAGS] then { +set DEFAULT_CFLAGS " -ansi -pedantic-errors" +} + +# Initialize `dg'. +dg-init + +# Main loop. +dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.\[cS\]]] \ + "" $DEFAULT_CFLAGS + +# All done. +dg-finish MfG, JBG -- Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7608481 Signature of:Lauf nicht vor Deinem Glück davon: the second : Es könnte hinter Dir stehen! signature.asc Description: Digital signature

Re: [PATCH] target/56875: Work around buggy GAS

2013-09-20 Thread Jan-Benedict Glaw
On Fri, 2013-09-20 18:58:23 +0200, Jan-Benedict Glaw wrote: > VAX GAS has a glitch when generating a 64bit value from a small > negative integer, which isn't properly sign-extended. (I'll see if > this can be fixed without breaking other cases.) > > However, GCC should w

[PATCH] Silence an unused variable warning

2013-09-20 Thread Jan-Benedict Glaw
don't eliminate any registers (beyond GCC's internal default). Fixed by moving this variable into the #ifdef block to which it belongs. 2013-09-20 Jan-Benedict Glaw gcc/ * lra-eliminations.c (update_reg_eliminate): Guard value_p. diff --git a/gcc/lra-eliminations.c

[ping] [PATCH] Silence an unused variable warning

2013-09-26 Thread Jan-Benedict Glaw
On Fri, 2013-09-20 20:51:37 +0200, Jan-Benedict Glaw wrote: > Hi! > > With the VAX target, I see this warning: > > g++ -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions > -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing > -Wwrite-strings

[RFC] Change dependency-generating compiler from $(CC) to $(CXX) in gcc/

2013-10-01 Thread Jan-Benedict Glaw
I cook up a patch to do the proper transition from CC to CXX for dependency generation? Or better keep it as is (which I consider broken, but probably few people will ever experience that problem)? MfG, JBG -- Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7608481 Signature o

[RFC] [PATCH] Change dependency-generating compiler from $(CC) to $(CXX) in gcc/

2013-10-01 Thread Jan-Benedict Glaw
On Tue, 2013-10-01 20:49:30 +0200, Jan-Benedict Glaw wrote: [...] > Since we're using $(CXX) instead of $(CC) these days, I suggest > using CXX instead of CC. A quick check (without regenerating all > configure and Makefile files just changing CC to CXX in gcc/configure) &g

[PATCH, COMMITTED] Fix comment in gcc/config/sh/sh.c

2012-10-18 Thread Jan-Benedict Glaw
Hi! This patch silences the following warning: ../../../../gcc/gcc/config/sh/sh.c:9455:1: warning: "/*" within comment [-Wcomment] Comitted as obvious. MfG, JBG 2012-10-18 Jan-Benedict Glaw gcc/ * config/sh/sh.c: Fix comment to silence warning. diff --git a/gcc

[buildrobot] r203314..r203320: ssa / ssanames restructure broke alpha-linux again

2013-10-10 Thread Jan-Benedict Glaw
Hi! On Mon, 2013-09-16 10:32:24 -0400, Andrew MacLeod wrote: > On 09/16/2013 05:05 AM, Richard Biener wrote: > > On Sat, Sep 14, 2013 at 12:41 PM, Jan-Benedict Glaw > > wrote: > > >My Build Robot[1] found this recent commit to break Alpha: > > > > >

[buildrobot] Minor fallout of: Fix PR 57756

2013-10-16 Thread Jan-Benedict Glaw
easy to fix. MfG, JBG [1] http://toolchain.lug-owl.de/buildbot/ http://toolchain.lug-owl.de/buildbot/timeline.php -- Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7608481 Signature of: Fortschritt bedeutet, einen Schritt so zu machen, the second :

Re: [PATCH][i386]Fix PR 57756

2013-10-17 Thread Jan-Benedict Glaw
ot[1]. All targets (except nds32, nios2 and arceb) used to build. Don't get me wrong. I don't want to overly blame Sriraman for breaking it in the first place. Shit happens. But please have an eye on fixing the fallout, timely. MfG, JBG [1] http://toolchain.lug-owl.de/buildbot/?limit=200

Re: [PATCH][i386]Fix PR 57756

2013-10-17 Thread Jan-Benedict Glaw
ttp://toolchain.lug-owl.de/buildbot/?limit=1500 http://toolchain.lug-owl.de/buildbot/timeline.php?limit=1500 Generally, if you're looking for targets that are at least somewhat supported, you find a good list to start with at contrib/config-list.mk . MfG, JBG -- Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7608481 Signature of: Wenn ich wach bin, träume ich. the second : signature.asc Description: Digital signature

Re: [PATCH][i386]Fix PR 57756

2013-10-17 Thread Jan-Benedict Glaw
o do that, or forward-port all other code. Probably a question the global reviewers should decide on. Though if you want to, I'd easily configure another instance to manually test some patches. MfG, JBG -- Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7608481 S

[PATCH][buildrobot] frv: Fix get_tree_code_name() conversion fallout

2013-10-18 Thread Jan-Benedict Glaw
type))); ^ make[1]: *** [frv.o] Error 1 Fixed like this: 2013-10-18 Jan-Benedict Glaw gcc/ * config/frv/frv.c (frv_init_cumulative_args): Fix wrong cast. diff --git a/gcc/config/frv/frv.c b/gcc/config/frv/frv.c index 41ae2bb..bcd5511 100644 --- a/gcc/config/frv/frv.c +++ b

[PATCH][buildrobot] tilepro/tilegx: fallout after tree.h refactoring (was: Re-factor inclusion of tree.h)

2013-10-22 Thread Jan-Benedict Glaw
to trunk. I get some fallout for tilepro-linux, see http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=21851 . This fixes it: 2013-10-22 Jan-Benedict Glaw * config/tilepro/tilepro.c: Include "tree.h". diff --git a/gcc/config/tilepro/tilepro.c b/gcc/config/t

Re: [PATCH][buildrobot] tilepro/tilegx: fallout after tree.h refactoring (was: Re-factor inclusion of tree.h)

2013-10-23 Thread Jan-Benedict Glaw
On Tue, 2013-10-22 08:46:13 -0400, Diego Novillo wrote: > On Tue, Oct 22, 2013 at 4:22 AM, Jan-Benedict Glaw wrote: > > This fixes it: > > > > 2013-10-22 Jan-Benedict Glaw > > > > * config/tilepro/tilepro.c: Include "tree.h". > &g

AIX: Dependency problem with xlC/g++ combination

2013-10-23 Thread Jan-Benedict Glaw
U C compiler. I'd like to get some comments on this patch, which works for me for stage-1 builds with gcc/g++ (on a amd64-linux box) as well as with xlC/g++ on gcc111 (the mentioned AIX machine): 2013-10-24 Jan-Benedict Glaw gcc/ * configure.ac (ZW_PROG_COMPILER_DEPENDENCIE

Re: AIX: Dependency problem with xlC/g++ combination

2013-10-24 Thread Jan-Benedict Glaw
On Wed, 2013-10-23 20:21:50 -0400, David Edelsohn wrote: > On Wed, Oct 23, 2013 at 6:21 PM, Jan-Benedict Glaw wrote: > > When building on gcc111, I tried to use different compilers for my > > build robot. This machine has IBM's XL C compiler installed, but not > > the

[PATCH][buildrobot] libcpp/lex.c: Use enum properly

2013-10-24 Thread Jan-Benedict Glaw
ier raw_str_phase. "/home/jbglaw/repos-IBM-XL/gcc/libcpp/lex.c", line 1500.11: 1506-045 (S) Undeclared identifier phase. make[1]: *** [lex.o] Error 1 Fixed like this: 2013-10-24 Jan-Benedict Glaw libcpp/ * lex.c (lex_raw_string): Use proper type. diff --git a/libcpp/lex.c b/l

Re: AIX: Dependency problem with xlC/g++ combination

2013-10-24 Thread Jan-Benedict Glaw
nedict> box) as well as with xlC/g++ on gcc111 (the mentioned AIX > > Jan-Benedict> machine): > > > > FWIW, I believe this patch is correct. > > However, I cannot approve it. > > The patch is okay indeed. Thanks, committed as revision r204006. MfG, JBG --

Re: [PATCH, rs6000] Fix PR63354

2016-01-23 Thread Jan-Benedict Glaw
]: *** [all-gcc] Error 2 make[1]: Leaving directory '/home/jbglaw/build-configlist_mk/powerpc-xilinx-eabi/build-gcc/mk/powerpc-xilinx-eabi' MfG, JBG -- Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7608481 Signature of: Träume nicht von Deinem

[ping] [patch] contrib/config-list.mk: Allow to build all targets individually

2013-11-26 Thread Jan-Benedict Glaw
On Sun, 2013-11-24 20:02:43 +0100, Jan-Benedict Glaw wrote: > 2013-11-24 Jan-Benedict Glaw > > * config-list.mk (host_options): Allow to override it. > (LIST): Change "=" to "EQUAL". > (list): New target listing all configurations. >

Re: wide-int, vax

2013-11-28 Thread Jan-Benedict Glaw
On Sat, 2013-11-23 11:23:08 -0800, Mike Stump wrote: > * config/vax/vax.c: Include wide-int.h. > (vax_float_literal): Use real_from_integer. Looks good to me, but Matt must tell for sure. MfG, JBG -- Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7

[ping^2] [patch] contrib/config-list.mk: Allow to build all targets individually

2013-12-02 Thread Jan-Benedict Glaw
On Wed, 2013-11-27 02:43:08 +0100, Jan-Benedict Glaw wrote: > On Sun, 2013-11-24 20:02:43 +0100, Jan-Benedict Glaw > wrote: > > 2013-11-24 Jan-Benedict Glaw > > > > * config-list.mk (host_options): Allow to override it. > > (LIST): Change "="

[buildrobot] Re: [PATCH] Split -fisolate-erroneous-paths into two options

2013-12-05 Thread Jan-Benedict Glaw
t.x_flag_isolate_erroneous_paths) ^ ../../../gcc/gcc/go/go-lang.c:277:20: error: ‘struct gcc_options’ has no member named ‘x_flag_isolate_erroneous_paths’ global_options.x_flag_isolate_erroneous_paths = 0; ^ make[2]: *** [go/go-lang.o] Error 1 MfG, JBG -- Jan-Bene

[buildrobot] Re: Make C11 _Alignof return least not greatest alignment for a type (PR c/52023)

2013-12-05 Thread Jan-Benedict Glaw
ee_node* c_sizeof_or_alignof_type(location_t, tree, bool, bool, int)’: ../../../gcc/gcc/c-family/c-common.c:5007:9: error: unused variable ‘field’ [-Werror=unused-variable] tree field = build_decl (UNKNOWN_LOCATION, FIELD_DECL, NULL_TREE, ^ cc1plus: all warnings being treated as errors mak

[buildrobot] score: Silence warnings to fix config-list.mk build

2013-12-05 Thread Jan-Benedict Glaw
Hi! This patch silences warnings (unused static functions, ambiguous `else') for the score target. 2013-12-05 Jan-Benedict Glaw * config/score/score.c (score_force_temporary): Delete function. (score_split_symbol): Ditto. * config/score/sc

Re: [buildrobot] score: Silence warnings to fix config-list.mk build

2013-12-05 Thread Jan-Benedict Glaw
On Thu, 2013-12-05 14:22:46 -0700, Jeff Law wrote: > On 12/05/13 14:17, Jan-Benedict Glaw wrote: > >diff --git a/gcc/config/score/score.h b/gcc/config/score/score.h > >index 5ab7875..e3bb7f0 100644 > >--- a/gcc/config/score/score.h > >+++ b/gcc/config/score/sc

Re: [buildrobot] score: Silence warnings to fix config-list.mk build

2013-12-05 Thread Jan-Benedict Glaw
On Thu, 2013-12-05 20:49:06 -0700, Jeff Law wrote: > On 12/05/13 14:33, Jan-Benedict Glaw wrote: > > On Thu, 2013-12-05 14:22:46 -0700, Jeff Law wrote: > > > On 12/05/13 14:17, Jan-Benedict Glaw wrote: [...] > I'd just change this one to be correct for the GNU style.

  1   2   3   >