Re: [patch] Fix PR rtl-optimization/100411

2021-05-05 Thread Eric Botcazou
> At least for NOTE_INSN_BASIC_BLOCK skipping more than one might > be problematic, because that would mean we've skipped into a different basic > block and it wouldn't surprise me if split_block in that case crashed or > did something weird (if the first argument is not BLOCK_FOR_INSN of the > sec

Fix PR target/100402

2021-05-05 Thread Eric Botcazou
this breaks for some reason; at least it appears that a .seh_setframe directive with 0 as second argument always works, so the fix aligns it this way. Tested on x86-64/Windows, applied on the affected branches as obvious. 2021-05-05 Eric Botcazou PR target/100402 * config/i386

[patch] Do not apply scalar storage order to pointer fields

2021-05-07 Thread Eric Botcazou
pulls them out. Tested on x86-64/Linux, OK for mainline? 2021-05-07 Eric Botcazou * doc/extend.texi (scalar_storage_order): Mention effect on pointer and vector fields. * tree.h (reverse_storage_order_for_component_p): Return false if the type is a point

[patch] Fix incorrect array bounds with -fgnat-encodings=minimal in DWARF

2021-05-07 Thread Eric Botcazou
Hi, this makes add_subscript_info query the get_array_descr_info hook for the actual information when it is defined. Tested on x86-64/Linux, OK for mainline? 2021-05-07 Eric Botcazou * dwarf2out.c (add_subscript_info): Retrieve the bounds and the index type by means of the

[patch] Remove call to gcc_unreachable in range-op.cc

2021-05-08 Thread Eric Botcazou
Eric Botcazou * range-op.cc (get_bool_state): Adjust head comment. (operator_not_equal::op1_range): Fix comment. (operator_bitwise_xor::op1_range): Remove call to gcc_unreachable. 2021-05-08 Eric Botcazou * gnat.dg/specs/opt5.ads: New test. * gnat.dg/

Re: [GOVERNANCE] Where to file complaints re project-maintainers?

2021-05-09 Thread Eric Botcazou
> It is a gcc issue, see the very first link you've quoted ( > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92729). IIUC you're complaining about the bounty process, not about the GCC PR, so this technical list is not the appropriate place to do it. AFAICS you have already filed a complaint wit

Re: [PATCH] Bump LTO_major_version to 11.

2021-05-10 Thread Eric Botcazou
> Ready for master? This breaks the build for me: make[3]: *** No rule to make target '/home/eric/cvs/gcc/gcc/version.c', needed by 'ada/stamp-sdefault'. Stop. make[3]: *** Waiting for unfinished jobs -- Eric Botcazou

Re: [PATCH] Bump LTO_major_version to 11.

2021-05-10 Thread Eric Botcazou
.. rm gcov.pod fsf-funding.pod lto-dump.pod gfdl.pod gpl.pod cpp.pod gcov- dump.pod gcc.pod gcov-tool.pod make[3]: Leaving directory '/home/eric/build/gcc/native/gcc' make[2]: *** [Makefile:4781: all-stage1-gcc] Error 2 ada/gnatvsn.adb imports version_string from version.c -- Eric Botcazou

Re: [PATCH] Bump LTO_major_version to 11.

2021-05-10 Thread Eric Botcazou
Provide_Shift_Operators (Slot); in atree.ads with function Shift_Left (S : Slot; V : Natural) return Slot; pragma Import (Intrinsic, Shift_Left); function Shift_Right (S : Slot; V : Natural) return Slot; pragma Import (Intrinsic, Shift_Right); -- Eric Botcazou

Re: [PATCH] Bump LTO_major_version to 11.

2021-05-10 Thread Eric Botcazou
> Do you know Eric where version.o needs to be added to be included in the > problematic command line? Presumably to the beginning of TOOLS_LIBS in ada/gcc-interface/Makefile.in: TOOLS_LIBS = ../version.o ../link.o ../targext.o ../../ggc-none.o \ -- Eric Botcazou

Re: [PATCH] Bump LTO_major_version to 11.

2021-05-10 Thread Eric Botcazou
> Do you know Eric where version.o needs to be added to be included in the > problematic command line? You can presumably remove it from GNATLINK_OBJS & GNATMAKE_OBJS. And it needs to be added to GNAT1_C_OBJS instead of GNAT_ADA_OBJS in Make-lang.in. -- Eric Botcazou

Re: [PATCH] Bump LTO_major_version to 11.

2021-05-10 Thread Eric Botcazou
> The following patch fixes that, ready for master? Sure, thanks! -- Eric Botcazou

Re: [PATCH][OBVIOUS] testsuite: prune new LTO warning

2021-05-13 Thread Eric Botcazou
> gcc/testsuite/ChangeLog: > > PR testsuite/100569 > * gcc.dg/atomic/c11-atomic-exec-2.c: Prune new LTO warning. > * gcc.dg/torture/pr94947-1.c: Likewise. Another one: PR testsuite/100569 * gnat.dg/lto21.adb: Prune new LTO warning. -- Eric Botcazoudiff --git a

[DWARF] Couple of pending patches

2021-05-14 Thread Eric Botcazou
. -- Eric Botcazou

Re: [PATCH] tree-sra: Avoid refreshing into const base decls (PR 100453)

2021-05-14 Thread Eric Botcazou
> FAIL: gnat.dg/spark1.adb (test for excess errors) > FAIL: gnat.dg/sync2.adb (test for excess errors) > FAIL: gnat.dg/synchronized1.adb (test for excess errors) Yes, it did, as well as PR boostrap/100597 probably. -- Eric Botcazou

Re: [PATCH] tree-sra: Avoid refreshing into const base decls (PR 100453)

2021-05-17 Thread Eric Botcazou
+1822,7 @@ gimplify_decl_expr (tree *stmt_p, gimple_seq *seq_p) if (!TREE_STATIC (decl)) { DECL_INITIAL (decl) = NULL_TREE; + TREE_READONLY (decl) = 0; init = build2 (INIT_EXPR, void_type_node, decl, init); gimplify_and_add (init, seq_p); ggc_free (init); -- Eric Botcazou

[Ada] Fix PR ada/113979

2024-03-07 Thread Eric Botcazou
resulting access value (after dereference) like in Expand_Allocator_Expression. Tested on x86-64/Linux, applied on all active branches. 2024-03-07 Eric Botcazou PR ada/113979 * exp_ch4.adb (Expand_N_Allocator): In the subtype indication case, call

Fix PR debug/113519 and debug/113777

2024-03-11 Thread Eric Botcazou
They both come from an oversight of mine in the placement of the DIE created for an enumeration type with reverse scalar storage order. Tested on x86-64/Linux, both GCC and GDB, applied on mainline as obvious. 2024-03-11 Eric Botcazou PR debug/113519 PR debug/113777

[PATCH] Fix PR ipa/113996

2024-03-11 Thread Eric Botcazou
hich has a static chain but the other does not. The proposed fix is just to prevent this identification from occurring. Tested on x86-64/Linux, OK for all active branches? 2024-03-11 Eric Botcazou PR ipa/113996 * ipa-icf.h (sem_function): Add static_chain_present member.

Re: [PATCH] Fix PR ipa/113996

2024-03-12 Thread Eric Botcazou
> Patch is still OK, but ipa-ICF will only identify the functions if > static chain is unused. Perhaps just picking the winning candidate to be > version without static chain and making ipa-inline to not ICE when calls > with static chain lands to function with no static chain would help us > to op

[Ada] Fix PR ada/113893

2024-02-26 Thread Eric Botcazou
references to the local finalization routine, so the finalization needs to be dropped in this case and the warning adjusted. Tested on x86-64/Linux, applied on all active branches. 2024-02-26 Eric Botcazou PR ada/113893 * exp_ch7.adb (Build_Anonymous_Master): Do not build the

[PATCH] Fix internal error in GIMPLE DSE

2024-02-27 Thread Eric Botcazou
of compute_trims assume that ref->offset is byte aligned and that the trimmed bytes are relative to ref->size, so the patch simply adds an early return if either condition is not fulfilled Tested on x86-64/Linux, OK for all the affected branches? 2024-02-27 Eric Botcazou *

Re: [PATCH] Fix debug info for enumeration types with reverse Scalar_Storage_Order

2024-01-10 Thread Eric Botcazou
No, for the reason described above, so the extra parameter is preexisting for base_type_die, modified_type_die and add_type_attribute. -- Eric Botcazou

Re: HELP: Questions on unshare_expr

2024-01-15 Thread Eric Botcazou
> Okay, so, the "unsharing everythingā€¯ is done automatically by the compiler > before gimplification? See the blurb at gimplify.cc:835 and below about this. -- Eric Botcazou

[c-family] Fix PR ada/113397

2024-01-16 Thread Eric Botcazou
It is a regression on the mainline for -fdump-ada-spec in a pathological case. Tested on x86-64/Linux, applied on the mainline. 2024-01-16 Eric Botcazou PR ada/113397 * c-ada-spec.cc (check_type_name_conflict): Add guard for the presence of DECL_NAME on a TYPE_DECL

Re: [PATCH] combine: Don't optimize paradoxical SUBREG AND CONST_INT on WORD_REGISTER_OPERATIONS targets [PR112758]

2023-12-22 Thread Eric Botcazou
for trunk? Yes, thanks for fixing this. -- Eric Botcazou

Re: [PATCH] sparc: Char arrays are 64-bit aligned on SPARC

2024-01-08 Thread Eric Botcazou
never seen it though. Is that really a warning issued by GCC? -- Eric Botcazou

Re: [PATCH 1/2] sparc: Revert membar optimization that is not suitable for LEON5

2024-01-08 Thread Eric Botcazou
sn." > > gcc/ChangeLog: > > * config/sparc/sync.md (*membar_storeload_leon3): Remove > (*membar_storeload): Enable for LEON OK. -- Eric Botcazou

Re: [PATCH] sparc: Treat instructions with length 0 as empty

2024-01-08 Thread Eric Botcazou
> This is to handle the membar_empty instruction that can be generated > when compiling for UT699. > > gcc/ChangeLog: > > * config/sparc/sparc.cc (next_active_non_empty_insn): Length 0 treated > as empty OK without the superfluous parentheses. -- Eric Botcazou

Re: [PATCH 2/2] sparc: Add errata workaround to membar patterns

2024-01-08 Thread Eric Botcazou
orkaround. OK with this change. -- Eric Botcazou

Re: [PATCH] sparc: Char arrays are 64-bit aligned on SPARC

2024-01-09 Thread Eric Botcazou
e with GCC 10. I see, thanks for the explanation, the patch is OK then. > For the OK:ed patches (with your changes), can I push them to > release/gcc-13 in addition to master? Sure. -- Eric Botcazou

Re: [PATCH] testsuite: Skip ifcvt-4.c for SPARC V8

2024-01-09 Thread Eric Botcazou
> Conditional moves are not available in SPARC V8. > > gcc/testsuite/ChangeLog: > > * gcc.dg/ifcvt-4.c: Skip for SPARC V8 OK. -- Eric Botcazou

Fix PR rtl-optimization/113140

2024-01-09 Thread Eric Botcazou
function. Tested on SPARC64/Linux, applied on the mainline and 13 branch. 2024-01-09 Eric Botcazou PR rtl-optimization/113140 * reorg.cc (fill_slots_from_thread): If we are to branch after the last instruction of the function, create an end label. 2024-01-09 Eric

Fix PR rtl-optimization/113140

2024-01-09 Thread Eric Botcazou
function. Tested on SPARC64/Linux, applied on the mainline and 13 branch. 2024-01-09 Eric Botcazou PR rtl-optimization/113140 * reorg.cc (fill_slots_from_thread): If we are to branch after the last instruction of the function, create an end label. 2024-01-09 Eric

[Ada] Fix PR ada/113195

2024-01-09 Thread Eric Botcazou
, applied on the mainline and 13 branch. 2024-01-09 Eric Botcazou PR ada/113195 * gcc-interface/utils2.cc (build_binary_op) : Relax assertion for regular pointer types. 2024-01-09 Eric Botcazou * gnat.dg/specs/anon4.ads: New test. -- Eric Botcazou-- { dg

[Ada] Fix PR ada/112781 (1/2)

2024-01-09 Thread Eric Botcazou
13 branch. 2024-01-09 Eric Botcazou PR ada/112781 * sem_ch12.adb (Instantiate_Type): Use Etype instead of Base_Type consistently to retrieve the ancestor for a derived type. * sem_ch4.adb (Analyze_Explicit_Dereference): Test Is_Access_Type

[Ada] Fix PR ada/112781 (2/2)

2024-01-09 Thread Eric Botcazou
, and moving down the assertion in Expand_Simple_Function_Return. Tested on SPARC64/Linux, applied on the mainline and 13 branch. 2024-01-09 Eric Botcazou PR ada/112781 * exp_ch6.ads (Is_Build_In_Place_Function): Adjust description. * exp_ch6.adb

[PATCH] Fix debug info for enumeration types with reverse Scalar_Storage_Order

2024-01-09 Thread Eric Botcazou
-01-09 Eric Botcazou * dwarf2out.cc (modified_type_die): Extend the support of reverse storage order to enumeration types if -gstrict-dwarf is not passed. (gen_enumeration_type_die): Add REVERSE parameter and generate the DIE immediately after the existing one if

Re: [PATCH] pro_and_epilogue: Call df_note_add_problem () if SHRINK_WRAPPING_ENABLED [PR112760]

2023-12-02 Thread Eric Botcazou
passes have to avoid false negatives, just false > positives. If a pass updates an instruction with a REG_UNUSED note, > and the pass is no longer sure whether the register is unused or not, > the pass can just delete the note.) Reintroducing the manual management of such notes would be a step backward. -- Eric Botcazou

Re: [PATCH] gcc: Disallow trampolines when -fhardened

2023-12-07 Thread Eric Botcazou
uot;A" is read but never assigned > [-gnatwv] > > so there is no warning. Look at the last line of the test (Ada has not used trampolines for ages!). -- Eric Botcazou

Re: [gcc15] nested functions in C

2023-12-07 Thread Eric Botcazou
ects > or if they do, there's explicit syntactic sugar to make it clearer. That sounds totally arbitrary though. Algol-derived languages have had nested subprograms for ages, e.g. Pascal or Ada, and they can be very useful. -- Eric Botcazou

[PATCH] Handle constant CONSTRUCTORs in operand_compare

2023-11-10 Thread Eric Botcazou
. Bootstrapped/regtested on x86-64/Linux, OK for the mainline? 2023-11-10 Eric Botcazou * fold-const.cc (operand_compare::operand_equal_p) : Deal with nonempty constant CONSTRUCTORs. (operand_compare::hash_operand) : Hash DECL_FIELD_OFFSET and DECL_FIELD_BIT_OFFSET

[PATCH] Handle addresses of more constants in IPA-CP

2023-11-11 Thread Eric Botcazou
r the mainline? 2023-11-11 Eric Botcazou * ipa-cp.cc (print_ipcp_constant_value): Move to... (values_equal_for_ipcp_p): Deal with VAR_DECLs from the constant pool. * ipa-prop.cc (ipa_print_constant_value): ...here. Lik

[Ada] Fix internal error on function returning dynamically-sized type

2023-11-16 Thread Eric Botcazou
This is PR ada/109881, a tree sharing issue for the internal return type synthesized for a function returning a dynamically-sized type and taking an Out or In/Out parameter passed by copy. Tested on x86-64/Linux, applied on mainline, 13 and 12 branches. 2023-11-16 Eric Botcazou PR

Re: PING^5: [PATCH] rtl-optimization/110939 Really fix narrow comparison of memory and constant

2023-09-25 Thread Eric Botcazou
ttern of bits so, in order to have a 1-to-1 mapping, you need to choose a canonical form. The signed form is probably more natural and, since CONST_INTs have no mode, the same objects are used for e.g. QImode and HImode, which means that you need to sign-extend the bit pattern. -- Eric Botcazou

[PATCH] Add missing return in gori_compute::logical_combine

2023-09-25 Thread Eric Botcazou
Hi, the varying case currently falls through to the 1/true case. Tested on x86_64-suse-linux, OK for mainline, 13 and 12 branches? 2023-09-25 Eric Botcazou * gimple-range-gori.cc (gori_compute::logical_combine): Add missing return statement in the varying case. 2023-09-25

Re: [PATCH] libffi: Fix 32-bit SPARC structure passing [PR115681]

2024-07-01 Thread Eric Botcazou
for trunk? Sure, thanks! -- Eric Botcazou

Re: [PATCH] sparc: define SPARC_LONG_DOUBLE_TYPE_SIZE for vxworks [PR115739]

2024-07-02 Thread Eric Botcazou
> PR target/115739 > > gcc/ChangeLog: > > * config/sparc/vxworks.h (SPARC_LONG_DOUBLE_TYPE_SIZE): New define. OK, thanks! -- Eric Botcazou

[RISC-V] Fix PR target/115591

2024-07-06 Thread Eric Botcazou
This is an ICE in the RISC-V back-end calling tree_to_uhwi on the DECL_SIZE of a global variable-length array. Fixed thusly, tested and approved by Jeff in the audit trail, and applied on the mainline. 2024-07-06 Eric Botcazou PR target/115591 * config/riscv/riscv.cc

[PATCH] Fix gimplification of ordering comparisons of arrays of bytes

2024-07-08 Thread Eric Botcazou
or aggregate types whose mode is not BLKmode and this processing deviates from the memcmp semantics when the target is little-endian. Tested on x86-64/Linux, OK for the mainline? 2024-07-08 Eric Botcazou * gimplify.cc (gimplify_scalar_mode_aggregate_compare): Add support

Re: [PATCH] Fix gimplification of ordering comparisons of arrays of bytes

2024-07-08 Thread Eric Botcazou
nch) so any additional path would be uncovered. If we have evidences that it's not sufficient, then I'm ready to amend it, but at the moment it would be a bit of a shot in the dark. -- Eric Botcazou

[wwwdocs] Document reimplementation of GNU threads library on Windows

2024-05-16 Thread Eric Botcazou
... which happened in GCC 13. Validated with W3C's Validator and applied. -- Eric Botcazoudiff --git a/htdocs/gcc-13/changes.html b/htdocs/gcc-13/changes.html index e324b782..3ab4a101 100644 --- a/htdocs/gcc-13/changes.html +++ b/htdocs/gcc-13/changes.html @@ -770,8 +770,17 @@ You may also want

[c-family] Small fix to implementation of -fdump-ada-spec

2024-05-17 Thread Eric Botcazou
This avoids declaring anonymous array types as having an aliased component when the layout is packed, as is already done for named array types. Tested on x86-64/Linux, applied on the mainline. 2024-05-17 Eric Botcazou * c-ada-spec.cc (bitfield_used): Move around

[Ada] Fix PR ada/115133

2024-05-17 Thread Eric Botcazou
The recent changes made to the runtime library broke its build on Solaris because it uses Solaris threads instead of POSIX threads on this platform. Tested by Rainer, applied on the mainline. 2024-05-17 Eric Botcazou Rainer Orth PR ada/115133 * libgnarl/s

Re: [PATCH] Add widening expansion of MULT_HIGHPART_EXPR for integral modes

2024-05-19 Thread Eric Botcazou
Hi, > Just notice that this patch may result in some ICE when build libc++ for the > riscv port, details as below. Please note not all configuration can > reproduce this issue, feel free to ping me if you cannot reproduce this > issue. CC more riscv port people for awareness. Sorry for the breaka

[PATCH] Fix PR rtl-optimization/115038

2024-05-20 Thread Eric Botcazou
Botcazou PR rtl-optimization/115038 * fold-mem-offsets.cc (fold_offsets): Return 0 if the defining instruction of the register is frame related. 2024-05-20 Eric Botcazou * g++.dg/opt/fmo1.C: New test. -- Eric Botcazoudiff --git a/gcc/fold-mem-offsets.cc b/gcc

[Ada] Fix PR ada/115168

2024-05-21 Thread Eric Botcazou
Recent changes made to the runtime library broke again its build on Solaris because it uses Solaris threads instead of POSIX threads on this platform. Tested by Rainer, applied on the mainline. 2024-05-21 Eric Botcazou PR ada/115168 * libgnarl/s-taprop__solaris.adb

[c-family] Another small fix to implementation of -fdump-ada-spec

2024-05-23 Thread Eric Botcazou
This avoids generating invalid Ada code for functions with a multidimensional array parameter and also cleans things up left and right. Tested on x86-64/Linux, applied on the mainline. 2024-05-23 Eric Botcazou * c-ada-spec.cc (check_type_name_conflict): Add guard

[c-family] Small enhancement to implementation of -fdump-ada-spec

2024-05-24 Thread Eric Botcazou
This lets it recognize more preprocessing floating constants. Tested on x86-64/Linux, applied on the mainline. 2024-05-24 Eric Botcazou * c-ada-spec.cc (is_cpp_float): New predicate. (dump_number): Deal with more preprocessing floating constants. (dump_ada_macros

[Ada] Fix PR ada/115270

2024-05-29 Thread Eric Botcazou
This fixes the link failure of the GNAT tools on 32-bit SPARC/Linux (as well as on 32-bit PowerPC/Linux probably) coming from an incorrect binding to the 64-bit compare-and-exchange builtin. Tested by Rainer on 32-bit SPARC/Linux, applied on mainline and 14 branch. 2024-05-29 Eric Botcazou

[PATCH] Fix LTO type mismatch warning on transparent union

2024-05-29 Thread Eric Botcazou
declared here /usr/include/sys/socket.h:130:12: note: code may be misoptimized unless '-fno- strict-aliasing' is used The attached patch recognizes the situation and checks the compatibility with the type of the first member of the union in this case. Tested on x86-64/Linux, OK for

Re: [PATCH] Fix LTO type mismatch warning on transparent union

2024-05-30 Thread Eric Botcazou
on pointers happen to be indirectly modified in the program... Note that there is an equivalent bypass based on common_or_extern a few lines below in the function (although I'm not sure if it's problematic TBAA-wise). -- Eric Botcazou

Re: [COMMITTED] ggc: Reduce GGC_QUIRE_SIZE on Solaris/SPARC [PR115031]

2024-05-30 Thread Eric Botcazou
ze is a host parameter rather than a target one though, so config/sparc/sol2.h is probably not the most appropriate place to override it, but I personally do not mind. -- Eric Botcazou

Re: [PATCH 01/52] ada: Replace use of LONG_DOUBLE_TYPE_SIZE

2024-06-03 Thread Eric Botcazou
cl.cc (gnat_to_gnu_entity): Use TYPE_PRECISION of > long_double_type_node to replace LONG_DOUBLE_TYPE_SIZE. OK, thanks. -- Eric Botcazou

Re: [PATCH 51/52] sparc: New hook implementation sparc_c_mode_for_floating_type

2024-06-03 Thread Eric Botcazou
is for long double type, go with the > + default one for the others. */ > + > +static machine_mode > +sparc_c_mode_for_floating_type (enum tree_index ti) > +{ > + if (ti == TI_LONG_DOUBLE_TYPE) > +return SPARC_LONG_DOUBLE_TYPE_SIZE == 128 ? TFmode : DFmode; > + return

[PATCH] Implement wrap-around arithmetics in DWARF expressions

2024-06-03 Thread Eric Botcazou
sons in DWARF for the case where the type is smaller than the "generic type", as is the case here. Tested on x86-64/Linux, OK for the mainline? 2024-06-03 Eric Botcazou * dwarf2out.cc (loc_list_from_tree_1) ; Add const. : Use a signed comparison for small unsigned t

[c-family] Add minimal support for __bf16 to -fdump-ada-spec

2024-06-17 Thread Eric Botcazou
Tested on x86-64/Linux, applied on the mainline. 2024-06-17 Eric Botcazou c-family/ * c-ada-spec.cc (is_float16): New predicate. (dump_ada_node) : Call it. -- Eric Botcazoudiff --git a/gcc/c-family/c-ada-spec.cc b/gcc/c-family/c-ada-spec.cc index a41e93aeafb..e1b1b2a4b73

[SPARC] Fix PR target/115608

2024-06-25 Thread Eric Botcazou
This passes -m32 when -mv8plus is specified on Linux (like on Solaris). Applied to mainline and 14 branch. 2024-06-25 Eric Botcazou PR target/115608 * config/sparc/linux64.h (CC1_SPEC): Pass -m32 for -mv8plus. -- Eric Botcazoudiff --git a/gcc/config/sparc/linux64.h b/gcc

[SPARC] Fix PR target/114416

2024-04-25 Thread Eric Botcazou
fix it on Solaris only at this point. Bootstrapped/regtested on SPARC/Solaris 11.4 and SPARC64/Linux by Rainer (many thanks again) and applied on the mainline. 2024-04-25 Eric Botcazou PR target/114416 * config/sparc/sparc.h (SUN_V9_ABI_COMPATIBILITY): New macro

Re: [SPARC] Fix PR target/114416

2024-04-25 Thread Eric Botcazou
> For the 20th anniversary of https://gcc.gnu.org/gcc-3.4/sparc-abi.html, a > new calling convention incompatibility with the vendor compiler (and the > ABI) has been discovered in 64-bit mode, affecting small structures > containing arrays of floating-point components. The decision has been made

[PATCH] Minor tweaks to code computing modular multiplicative inverse

2024-04-29 Thread Eric Botcazou
Hi, this removes the last parameter of choose_multiplier, which is unused, adds another assertion and more details to the description and various comments. Likewise to the closely related invert_mod2n, except for the last parameter. Tested on x86-64/Linux, OK for the mainline? 2024-04-29 Eric

Re: [PATCH] Minor tweaks to code computing modular multiplicative inverse

2024-04-29 Thread Eric Botcazou
> OK. Consider waiting to commit though as we want to make it easy to > cherry pick patches over to the release branch if needed. Sure. There are a couple more changes on top of it, but all can wait a bit. -- Eric Botcazou

[PATCH] Add widening expansion of MULT_HIGHPART_EXPR for integral modes

2024-04-29 Thread Eric Botcazou
. We'll use that in a subsequent change to the Ada front-end to generate fast modulo reduction for modular types with nonbinary modulus (a little controversial Ada 95 feature). Tested on x86-64/Linux, OK for the mainline? 2024-04-29 Eric Botcazou * exp

Re: [PATCH] ada: Fix gcc-interface/misc.cc compilation on SPARC

2024-09-06 Thread Eric Botcazou
> commit 72c6938f29cbeddb3220720e68add4cf09ffd794 > Author: Eric Botcazou > Date: Sun Aug 25 15:20:59 2024 +0200 > > ada: Streamline handling of low-level peculiarities of record field > layout > > broke the Ada build on SPARC: > > In

[PATCH] Fix wrong code out of NRV + RSO + inlining

2024-09-11 Thread Eric Botcazou
from that point on. The proposed fix is to always clear the flag during inlining in the RSO case. Tested on x86-64/Linux, OK for the mainline? 2024-09-11 Eric Botcazou * tree-inline.cc (declare_return_variable): Clear writeonly flag on a global variable used directly as the

Re: [PATCH] Fix wrong code out of NRV + RSO + inlining

2024-09-11 Thread Eric Botcazou
ed LHS? But NRV is only an example and not necessary, as you may read a RESULT_DECL in the callee. So the combination is actually just RSO + inlining if the callee happens to read RESULT_DECL. -- Eric Botcazou

Re: [patch] Adjust DECL_NAME of virtual clones

2013-08-20 Thread Eric Botcazou
> Dollar sign is not a valid character in symbols on some platforms, such as > AIX. Sure, but DECL_NAME isn't used for any symbol here, unlike DECL_ASSEMBLER_NAME. -- Eric Botcazou

Re: [patch] Adjust DECL_NAME of virtual clones

2013-08-20 Thread Eric Botcazou
> Okay, just wanted to make sure. Understood. FWIW the patchlet has been in AdaCore's tree for some months and works fine on Linux, Windows, Solaris, AIX, HP-UX, VMS, etc. -- Eric Botcazou

Re: [patch] Adjust DECL_NAME of virtual clones

2013-08-21 Thread Eric Botcazou
d so, but that's a very minor caveat. -- Eric Botcazou

Re: [PATCH] Rerun df_analyze after delete_unmarked_insns during DCE

2013-08-21 Thread Eric Botcazou
> (I can't find the original mail either in my mailbox or in the archives). It's PR rtl-optimization/57940. -- Eric Botcazou

Re: [PATCH] Rerun df_analyze after delete_unmarked_insns during DCE

2013-08-23 Thread Eric Botcazou
> It was also on the mailing list too. If I'd had the reference to 57940, > I wouldn't have approved the patch given your comment from July 20. Understood. I missed the message on the list and remembered only the PR. -- Eric Botcazou

Re: [PATCH]: Fix PR middle-end/56382 -- Only move MODE_COMPLEX_FLOAT by parts if we can create pseudos

2013-08-30 Thread Eric Botcazou
p; !(REG_P (y) && HARD_REGISTER_P (y) && hard_regno_nregs[REGNO(y)][mode] == 1)) try_int = false; -- Eric Botcazou

Re: Ada PATCH: Fix ada/58239 by linking with xg++, not xgcc

2013-08-31 Thread Eric Botcazou
R so that the Darwin folks can test it. -- Eric Botcazou

Re: [ping] Fix error recovery issue with alias

2013-09-01 Thread Eric Botcazou
,5 +5,6 @@ package Linker_Alias is > Var : Integer; -- { dg-error "aliased to undefined symbol" } > pragma Export (C, Var, "my_var"); > pragma Linker_Alias (Var, "var2"); > + pragma Weak_External (Var); > > end Linker_Alias; OK, I've instal

Re: Ada PATCH: Fix ada/58239 by linking with xg++, not xgcc

2013-09-01 Thread Eric Botcazou
> It seems the patch needs a couple of minor amendments to work with Darwin - > and I've added an updated version to the PR which passes bootstrap and make > check-ada on x86_64-darwin12. Iain Thanks, here is the final patch I just installed. 2013-09-01 Eric Botcazou

Re: [PATCH]: Fix PR middle-end/56382 -- Only move MODE_COMPLEX_FLOAT by parts if we can create pseudos

2013-09-02 Thread Eric Botcazou
> Eric, your patch works for me. Tested on hppa2.0w-hp-hpux11.11 and > hppa64-hp-hpux11.11. Thanks, also tested on x86-64/Linux and applied on the mainline. 2013-09-02 Eric Botcazou PR middle-end/56382 * expr.c (emit_move_complex): Do not move complex FP values as pa

Re: [PATCH, x86] Use vector moves in memmove expanding

2013-09-03 Thread Eric Botcazou
> Changes were checked into trunk: > http://gcc.gnu.org/ml/gcc-cvs/2013-07/msg00179.html The patch miscompiles the MPFR library on x86 Pentium Pro. Reduced testcase attached, compile for x86 with -mtune=pentiumpro. -- Eric Botcazoustatic void __attribute__((noinline, noclone)) my_memcpy (char

[VxWorks] Resurrect ARM port (again)

2013-09-05 Thread Eric Botcazou
The new extra_objs setting for the ARM was overridden for VxWorks. Applied on the mainline as obvious. 2013-09-05 Eric Botcazou * config.gcc (*-*-vxworks*): Do not override an existing extra_objs. -- Eric BotcazouIndex: config.gcc

[ARM] Fix register r3 wrongly used to save ip in nested APCS frame

2013-09-05 Thread Eric Botcazou
e stack in this latter case, using one of the slots to be used by the pushed arguments. This eliminates the last ACATS failures on ARM/VxWorks. OK for the mainline? 2013-09-05 Eric Botcazou * config/arm/arm.c (arm_expand_prologue): In a nested APCS frame with arguments to

Re: [ARM] Fix register r3 wrongly used to save ip in nested APCS frame

2013-09-05 Thread Eric Botcazou
> This is all fragile code, so a testcase would be very much appreciated. A small one is ACATS c45342a (ada/acats/tests/c4/c45342a.ada). -- Eric Botcazou

[patch] Fix another fallout of partial inlining change

2013-09-06 Thread Eric Botcazou
Hi, see http://gcc.gnu.org/ml/gcc/2013-09/msg00028.html for the context. The patch sets DECL_NO_INLINE_WARNING_P on the non-inlinable part after splitting (an alternative would be to clear DECL_DECLARED_INLINE_P). Tested on x86_64-suse-linux, OK for the mainline? 2013-09-06 Eric Botcazou

Re: [PATCH, PR 57748] Check for out of bounds access

2013-09-06 Thread Eric Botcazou
t; > OK for trunk and the 4.8 / 4.7 branch? Please avoid touching the 4.7 branch at this point, this is a sensitive area and the testcases look quite artificial to me. -- Eric Botcazou

Re: [patch] Fix another fallout of partial inlining change

2013-09-06 Thread Eric Botcazou
those may contain something that relies on inlining. Either you can > include in your change or I will fix it as a followup. I'll let you make the change. -- Eric Botcazou

Fix glitch in -fstack-usage output

2013-09-06 Thread Eric Botcazou
Tested on x86_64-suse-linux, applied on the mainline as obvious. 2013-09-06 Eric Botcazou * toplev.c (output_stack_usage): Be prepared for suffixes created by the compiler in the function names. 2013-09-06 Eric Botcazou * gnat.dg/stack_usage2.adb: New test.

Re: [1/4] Using gen_int_mode instead of GEN_INT

2013-09-11 Thread Eric Botcazou
> Now bootstrapped & regression-tested on x86_64-linux-gnu. OK to install? Sure, modulo... > Thanks, > Richard > > > gcc/ > * simplify-rtx.c (simplify_unary_operation_1): Use simplify_gen_binary > for (not (neg ...)) and (neg (not ...)) casees. 'cases' -- Eric Botcazou

Re: [PATCH, PR 57748] Check for out of bounds access

2013-09-13 Thread Eric Botcazou
is: there is no EXPAND_WRITE/EXPAND_MEMORY in 4.7... > > A possible patch for 4.7 would be like the attached (untested) patch. Let's simply declare this as WONTFIX on the 4.7 branch. -- Eric Botcazou

Re: [PATCH][ubsan] Add VLA bound instrumentation

2013-09-13 Thread Eric Botcazou
n -fstack-check is used > (even without sanitizing), so we wouldn't give proper diagnostics > for stmts following that line... In Ada we catch the sigsegv, turn it into an exception and unwind. -- Eric Botcazou

[PATCH] Fix segfault with inlining

2013-09-13 Thread Eric Botcazou
y clearing TREE_THIS_NOTRAP in the inliner. I think that this affects only the Ada compiler in practice. Tested on x86_64-suse-linux, OK for the mainline? 2013-09-13 Eric Botcazou * tree-inline.h (struct copy_body_data): Add transform_parameter. * tree-inline.c (is_paramete

[PATCH] Fix unaligned access generated by IVOPTS

2013-09-13 Thread Eric Botcazou
on SPARC/Solaris, OK for the mainline? 2013-09-13 Eric Botcazou * tree-ssa-loop-ivopts.c (may_be_unaligned_p): Deal with BLKmode as the access mode. 2013-09-13 Eric Botcazou * gnat.dg/loop_optimization17.adb: New test. * gnat.dg/loop_optimization17_pkg.ad

Re: [PATCH, committed] * pt.c (make_auto_1): Use input_location rather than BUILTINS_LOCATION.

2013-09-16 Thread Eric Botcazou
au) = build_template_parm_index That's not a valid post to gcc-patches though. You need to explain what the patch does in a few words, post a ChangeLog entry and say how you tested it. See all the other messages on the list... -- Eric Botcazou

<    1   2   3   4   5   6   7   8   9   10   >