[PATCH] get source line for diagnostic from preprocessed file / PR preprocessor/79106

Hello, within a compile cluster, only the preprocessed output of GCC is transferred to remote nodes for compilation. When GCC produces advanced diagnostics (with -fdiagnostics-show-caret), e.g. prints out the affected source line and fixit hints, it attempts to read the source file again, even

[PING] [PATCH] get source line for diagnostic from preprocessed file / PR preprocessor/79106

Happy New Year and a ping for https://gcc.gnu.org/ml/gcc-patches/2019-12/msg01113.html -Original Message- From: Bader, Lucas Sent: Montag, 16. Dezember 2019 12:19 To: gcc-patches@gcc.gnu.org Subject: [PATCH] get source line for diagnostic from preprocessed file / PR preprocessor/79106

[PING] [PATCH] get source line for diagnostic from preprocessed file / PR preprocessor/79106

. Original submission: https://gcc.gnu.org/legacy-ml/gcc-patches/2019-12/msg01113.html Please let me know if something is missing. Best Lucas -Original Message- From: Bader, Lucas Sent: Montag, 16. Dezember 2019 12:19 To: gcc-patches@gcc.gnu.org Subject: [PATCH] get source line for

Ping^3 [PATCH] get source line for diagnostic from preprocessed file / PR preprocessor/79106

. Original submission: https://gcc.gnu.org/legacy-ml/gcc-patches/2019-12/msg01113.html Please let me know if something is missing. Best Lucas -Original Message- From: Bader, Lucas Sent: Montag, 16. Dezember 2019 12:19 To: gcc-patches@gcc.gnu.org Subject: [PATCH] get source line for

[PATCH v3] get source line for diagnostic from preprocessed file [PR preprocessor/79106]

Hi, I reworked my patch based on your feedback and added data structures for caching linemarker lookups. It implements a two-stage approach consisting of plain memoization of calls to get_source_line_preprocessed and a hash table for storing linemarkers per source file. The details should hopef

[PATCH v2] get source line for diagnostic from preprocessed file [PR preprocessor/79106]

Hi, as discussed, I rebased and tested my patch against current master. Additionally, it now has the Signed-off-by tag. Looking forward to your comments. Best Lucas Within a compile cluster, only the preprocessed output of GCC is transferred to remote nodes for compilation. When GCC produ

RE: [PATCH v2] get source line for diagnostic from preprocessed file [PR preprocessor/79106]

able will have a series of line map instances representing the ranges in question. According to some comments I found, it seems that for e.g the C front-end, it can happen that we start emitting diagnostics before the line map has seen the end of the file, so it could probably only act as a hi

Re: Ping^3 [PATCH] get source line for diagnostic from preprocessed file / PR preprocessor/79106

Thanks for having a look Jeff. Would be great to hear your thoughts on this patch David. Best Lucas > On 18. Jan 2025, at 17:41, Jeff Law wrote: > >  > >> On 1/3/25 7:27 AM, Bader, Lucas wrote: >> Hello and Happy New Year, >> as https://gcc.gnu.org/bugzilla/

RE: [PATCH] get source line for diagnostic from preprocessed file / PR preprocessor/79106

Hi Dave, thanks for having a look. I'll rebase the change and resend it with the DCO sign-off. Best Lucas -Original Message- From: David Malcolm Sent: Tuesday, 28 January 2025 23:36 To: Bader, Lucas ; gcc-patches@gcc.gnu.org Subject: Re: [PATCH] get source line for diagnostic

[PING] [PATCH v3] get source line for diagnostic from preprocessed file [PR preprocessor/79106]

Gentle ping for https://gcc.gnu.org/pipermail/gcc-patches/2025-February/675450.html

[PATCH v4] get source line for diagnostic from preprocessed file [PR preprocessor/79106]

We found one more issue with the patch in our internal compile cluster. When using "-fdirectives-only", linemarkers do not always start at the beginning of a line. This version of the patch (last submission https://gcc.gnu.org/pipermail/gcc-patches/2025-February/675450.html) fixes this by skipp