Re: [PATCH] libgccjit: Fix float vector comparison

2022-12-01 Thread Antoni Boucher via Gcc-patches
On Thu, 2022-12-01 at 10:25 -0500, David Malcolm wrote: > On Thu, 2022-12-01 at 10:01 -0500, Antoni Boucher wrote: > > Thanks, David. > > Since we're not in phase 1 anymore, do we need an approval before I > > merge like last year or can I merge immediately? > > I

Re: [PATCH] libgccjit: Fix float vector comparison

2022-12-02 Thread Antoni Boucher via Gcc-patches
On Thu, 2022-12-01 at 11:57 -0500, David Malcolm wrote: > On Thu, 2022-12-01 at 10:33 -0500, Antoni Boucher wrote: > > On Thu, 2022-12-01 at 10:25 -0500, David Malcolm wrote: > > > On Thu, 2022-12-01 at 10:01 -0500, Antoni Boucher wrote: > > > > Thanks, David. >

Re: [PATCH] libgccjit: Fix float vector comparison

2022-12-02 Thread Antoni Boucher via Gcc-patches
I'm posting the patch again so that you can double-check that I wrote the DCO for the co-author correctly. Does that look good? Thanks. On Thu, 2022-12-01 at 11:57 -0500, David Malcolm wrote: > On Thu, 2022-12-01 at 10:33 -0500, Antoni Boucher wrote: > > On Thu, 2022-12-01 at 10:2

Re: [commited] jit: Support for global rvalue initialization and constructors

2021-12-15 Thread Antoni Boucher via Gcc-patches
Hi Petter. I believe you have forgotten the line `global:` in the file `gcc/jit/libgccjit.map`. I'm not sure what this line does, but it is there for all other ABI. David: What do you think? Regards. Le mardi 14 décembre 2021 à 17:22 +, Petter Tomner via Jit a écrit : > Hi! > > I have pushed

Re: [commited] jit: Support for global rvalue initialization and constructors

2021-12-29 Thread Antoni Boucher via Gcc-patches
rge thank you. > > I believe there is an implicit "global:" in the top of each version > scope, so it shouldn't > matter other than looking a bit deviant. > > Regards, > Petter > > Från: Antoni Boucher > Skickat: den 15 december 2021 15:19 > Till:

Re: SV: [commited] jit: Support for global rvalue initialization and constructors

2021-12-29 Thread Antoni Boucher via Gcc-patches
; > in test-local-init-rvalue.c with a global and local "arr" and it ran > fine. (See attachment). > > Regards, Petter > > > Från: Antoni Boucher > Skickat: den 29 december 2021 23:45 > Till: Petter Tomner; David Malcolm; j...@gcc.gnu.org; > gcc-patches@g

Re: [PATCH] libgccjit: Add support for sized integer types, including 128-bit integers [PR95325]

2022-01-03 Thread Antoni Boucher via Gcc-patches
Hi, David! One question below as I'm still not done with using this patch in rustc_codegen_gcc. Le jeudi 20 mai 2021 à 15:25 -0400, David Malcolm a écrit : > On Tue, 2021-05-18 at 14:53 +0200, Jakub Jelinek via Jit wrote: > > On Tue, May 18, 2021 at 08:23:56AM -0400, Antoni B

[PATCH] libgccjit: Add support for bitcasts [PR104071]

2022-01-17 Thread Antoni Boucher via Gcc-patches
35e113b51c416af0c13bc7eb160ff6c0cbcff813 Mon Sep 17 00:00:00 2001 From: Antoni Boucher Date: Wed, 9 Jun 2021 18:29:14 -0400 Subject: [PATCH] libgccjit: Add support for bitcasts [PR104071] 2022-01-17 Antoni Boucher gcc/jit/ PR target/104071 * docs/topics/compatibility.rst (LIBGCCJIT_ABI_20): New ABI

[PATCH] libgccjit: Add support for register variables [PR104072]

2022-01-17 Thread Antoni Boucher via Gcc-patches
Hi. This patch add supports for register variables in libgccjit. It passes the JIT tests, but since I added a function in reginfo.c, I wonder if I should run the whole testsuite. Thanks for the review. From 328eca2be438c4a05c21942b4b2c3650ff7de0eb Mon Sep 17 00:00:00 2001 From: Antoni Boucher

Re: [PATCH] libgccjit: Add support for bitcasts [PR104071]

2022-01-17 Thread Antoni Boucher via Gcc-patches
I was missing the define, so I added it. Here's the new patch with it. Le lundi 17 janvier 2022 à 17:18 -0500, Antoni Boucher via Jit a écrit : > Hi. > This patch add support for bitcasts in libgccjit. > > It passes the JIT tests, but since I added a function in tree.c, I >

Re: [PATCH] libgccjit: Add support for register variables [PR104072]

2022-01-17 Thread Antoni Boucher via Gcc-patches
I missed the comment about the new define, so here's the updated patch. Le lundi 17 janvier 2022 à 19:24 -0500, Antoni Boucher via Jit a écrit : > Hi. > This patch add supports for register variables in libgccjit. > > It passes the JIT tests, but since I added a function in regi

[PATCH] libgccjit: Add option to hide stderr logs [PR104073]

2022-01-17 Thread Antoni Boucher via Gcc-patches
reviews! From 002c6803ac7069bf18eabd6729e31de8e2be6128 Mon Sep 17 00:00:00 2001 From: Antoni Boucher Date: Sun, 9 Jan 2022 13:46:35 -0500 Subject: [PATCH] libgccjit: Add option to hide stderr logs [PR104073] 2022-01-17 Antoni Boucher get_debug_string (), - errmsg); - else -fprintf (stderr

<    1   2   3