Re: [PATCH] ipa-cp: Perform operations in the appropriate types (PR 118097)

2025-01-24 Thread Martin Jambor
Hi, the following version of the patch has one of the testcase adjusted to use long long and so pass also on 32bit i386 (and hopefully 32bit Arm too), otherwise it has not changed from what I posted on Wednesday. OK for master? Thanks, Martin -- 8< -- One of the testcases from

Re: [PATCH 1/3] c++: Fix mangling of otherwise unattached class-scope lambdas [PR118245]

2025-01-24 Thread Jason Merrill
On 1/23/25 10:13 AM, Nathaniel Shead wrote: Bootstrapped and regtested on x86_64-pc-linux-gnu, OK for trunk? OK. -- >8 -- This is a step closer to implementing the suggested changes for https://github.com/itanium-cxx-abi/cxx-abi/pull/85. Most lambdas defined within a class should have an ex

Re: [PATCH] testsuite: arm: Use -std=c17 for gcc.target/arm/thumb-bitfld1.c

2025-01-24 Thread Richard Earnshaw (lists)
On 19/01/2025 16:34, Torbjörn SVENSSON wrote: > Ok for trunk? > > -- > > Using -std=c17 avoids excess errors like: > .../thumb-bitfld1.c:15:1: warning: old-style function definition > [-Wold-style-definition] > > gcc/testsuite/ChangeLog: > > * gcc.target/arm/thumb-bitfld1.c: Use -std=c17

Re: [patch. libgfortran] PR118571 UTF-8 output and the A edit descriptor

2025-01-24 Thread Jerry D
On 1/24/25 12:25 AM, Andre Vehreschild wrote: Hi Jerry, the patch looks good to me. One small nit: in write.c after the period of the first sentence should be two space, when I am not mistaken. Thanks for the patch, Andre Thanks for review. Pushed as: commit r15-7181-g4daf088123b

Re: [GCC16 stage 1][RFC][PATCH 0/3]extend "counted_by" attribute to pointer fields of structures

2025-01-24 Thread Bill Wendling
On Tue, Jan 21, 2025 at 10:40 AM Joseph Myers wrote: > On Tue, 21 Jan 2025, Qing Zhao wrote: > > So, even after we introduce the designator syntax for counted_by attribute, > > arbitrary expressions as: > > > > counted_by (.len1 + const) > > counted_by (.len1 + .len2) > > > > Still cannot be sup

Re: [PATCH 3/3] c++/modules: Treat unattached lambdas as TU-local

2025-01-24 Thread Jason Merrill
On 1/23/25 10:16 AM, Nathaniel Shead wrote: Bootstrapped and regtested on x86_64-pc-linux-gnu, OK for trunk? OK. -- >8 -- This fixes ICEs where unattached lambdas at class scope (for instance, in member template instantiations) are streamed. This is only possible in header units, as in name

Re: [PATCH 2/3] c++/modules: Diagnose TU-local lambdas, give mangling scope to lambdas in concepts

2025-01-24 Thread Jason Merrill
On 1/23/25 10:15 AM, Nathaniel Shead wrote: Bootstrapped and regtested on x86_64-pc-linux-gnu, OK for trunk? -- >8 -- This fills in a hole left in r15-6378-g9016c5ac94c557 with regards to detection of TU-local lambdas. Now that LAMBDA_EXPR_EXTRA_SCOPE is properly set for most lambdas we can us

Re: [PATCH] c++: Only destruct elts of array for new expression if exception is thrown during the initialization [PR117827]

2025-01-24 Thread Jason Merrill
On 1/23/25 1:44 PM, Jakub Jelinek wrote: Hi! The following testcase r12-6328, because the elements of the array are destructed twice, once when the callee encounters delete[] p; and then second time when the exception is thrown. The array elts should be only destructed if exception is thrown fro

[PING] [PATCH] testsuite: arm: Update expected RTL for reg_equal_test.c test

2025-01-24 Thread Torbjorn SVENSSON
Gentle ping 🙂 Kind regards, Torbjörn On 2024-12-18 11:46, Torbjorn SVENSSON wrote: On 2024-12-12 15:50, Richard Earnshaw (lists) wrote: On 12/12/2024 13:36, Torbjorn SVENSSON wrote: On 2024-12-12 12:26, Richard Earnshaw (lists) wrote: On 10/11/2024 13:38, Torbjörn SVENSSON wrote: Hi Ric

[PING^2]: [PATCH v3] testsuite: arm: Use effective-target for attr-neon* tests

2025-01-24 Thread Torbjorn SVENSSON
Another ping... :) Kind regards, Torbjörn On 2024-12-19 20:23, Torbjorn SVENSSON wrote: Gentle ping :) Kind regards, Torbjörn On 2024-11-14 17:51, Torbjorn SVENSSON wrote: On 2024-11-14 16:16, Christophe Lyon wrote: Hi Torbjörn, On Sun, 10 Nov 2024 at 10:09, Torbjörn SVENSSON wrote: C

[PATCH] testsuite: arm: Use -Os -fno-math-errno in vfp-1.c [PR116448]

2025-01-24 Thread Torbjörn SVENSSON
Ok for trunk and releases/gcc-14? -- gcc/testsuite/ChangeLog: PR testsuite/116448 * gcc.target/arm/vfp-1.c: Use -Os -fno-math-errno. Signed-off-by: Torbjörn SVENSSON --- gcc/testsuite/gcc.target/arm/vfp-1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gc

Re: [PATCH] testsuite: arm: Use -std=c17 for gcc.target/arm/thumb-bitfld1.c

2025-01-24 Thread Torbjorn SVENSSON
On 2025-01-24 18:17, Richard Earnshaw (lists) wrote: On 19/01/2025 16:34, Torbjörn SVENSSON wrote: Ok for trunk? -- Using -std=c17 avoids excess errors like: .../thumb-bitfld1.c:15:1: warning: old-style function definition [-Wold-style-definition] gcc/testsuite/ChangeLog: * gcc.t

Re: [PATCH] testsuite: arm: Use -Os -fno-math-errno in vfp-1.c [PR116448]

2025-01-24 Thread Richard Earnshaw (lists)
On 24/01/2025 17:01, Torbjörn SVENSSON wrote: > Ok for trunk and releases/gcc-14? > > -- > > gcc/testsuite/ChangeLog: > > PR testsuite/116448 > * gcc.target/arm/vfp-1.c: Use -Os -fno-math-errno. > > Signed-off-by: Torbjörn SVENSSON > --- > gcc/testsuite/gcc.target/arm/vfp-1.c | 2

Re: [PATCH] testsuite: arm: Use -Os -fno-math-errno in vfp-1.c [PR116448]

2025-01-24 Thread Torbjorn SVENSSON
On 2025-01-24 18:07, Richard Earnshaw (lists) wrote: On 24/01/2025 17:01, Torbjörn SVENSSON wrote: Ok for trunk and releases/gcc-14? -- gcc/testsuite/ChangeLog: PR testsuite/116448 * gcc.target/arm/vfp-1.c: Use -Os -fno-math-errno. Signed-off-by: Torbjörn SVENSSON --- g

[PATCH] c++, v2: Only destruct elts of array for new expression if exception is thrown during the initialization [PR117827]

2025-01-24 Thread Jakub Jelinek
On Fri, Jan 24, 2025 at 12:45:54PM -0500, Jason Merrill wrote: > > The following testcase r12-6328, because the elements of the array > > are destructed twice, once when the callee encounters delete[] p; > > and then second time when the exception is thrown. > > The array elts should be only destru

Re: [PING^2,PATCH] Add target hook to assemble a VAR_DECL

2025-01-24 Thread Georg-Johann Lay
Am 24.01.25 um 08:18 schrieb Richard Biener: On Thu, Jan 23, 2025 at 4:53 PM Georg-Johann Lay wrote: Am 23.01.25 um 14:58 schrieb Richard Biener: On Thu, Jan 23, 2025 at 2:23 PM Georg-Johann Lay wrote: Hi, this is Ping #2 for a patch from 2024. It adds a new target hook that allows to out

Re: [PATCH 1/2] LoongArch: Fix wrong code with _alsl_reversesi_extended

2025-01-24 Thread Richard Sandiford
Lulu Cheng writes: > 在 2025/1/24 下午3:58, Richard Sandiford 写道: >> Lulu Cheng writes: >>> 在 2025/1/22 上午8:49, Xi Ruoyao 写道: The second source register of this insn cannot be the same as the destination register. gcc/ChangeLog: * config/loongarch/loongarch.md

[PATCH] tree-optimization/118634 - improve cunroll dump

2025-01-24 Thread Richard Biener
We no longer subtract the estimated eliminated number of instructions from the estimated size after unrolling we print - this is a bit confusing when comparing dumps to previous releases. The following changes the dump from Estimated size after unrolling: 42 to Estimated size after unrollin

Re: [PATCH] RISC-V: Disable two-source permutes for now [PR117173].

2025-01-24 Thread Robin Dapp
> So this isn't a regression, but I can also understand the desire to fix > this fairly significant performance issue. I'd argue it is a regression as the match.pd pattern that merges the permutes was introduces after GCC 14. After giving it a bit more thought, I'd still like to send the attache

[PATCH v2 00/11] aarch64: Refactor target parsing

2025-01-24 Thread Andrew Carlotti
This series also fixes a couple of minor bugs. I've made all the changes Richard requested against v1, and will push this if it passes testing. Each commit has again been built and tested with: RUNTESTFLAGS="aarch64.exp=feature-*\ spellcheck*\ mv*\ arch-diag*\ cpu-diag*\ target_attr_crypto_ice*

[PATCH v2 03/11] aarch64: Remove redundant generic cpu entry

2025-01-24 Thread Andrew Carlotti
The list of cores in aarch64-common.cc included an explicit "generic" entry, despite this entry also being present in aarch64-cores.def. gcc/ChangeLog: * common/config/aarch64/aarch64-common.cc (all_cores): Remove explicit generic entry. diff --git a/gcc/common/config/aarch64/aa

[PATCH v2 02/11] aarch64: Replace duplicate cpu enums

2025-01-24 Thread Andrew Carlotti
Replace `enum aarch64_processor` and `enum target_cpus` with `enum aarch64_cpu`, and prefix the entries with `AARCH64_CPU_`. Also rename aarch64_none to aarch64_no_cpu. gcc/ChangeLog: * config/aarch64/aarch64-opts.h (enum aarch64_processor): Rename to... (enum aarch64_cpu)

[PATCH v2 07/11] aarch64: Move arch/cpu parsing to aarch64-common.cc

2025-01-24 Thread Andrew Carlotti
Aside from moving the functions, the only changes are to make them non-static, and to use the existing info arrays within aarch64-common.cc instead of the info arrays remaining in aarch64.cc. gcc/ChangeLog: * common/config/aarch64/aarch64-common.cc (aarch64_get_all_extension_candi

[PATCH v2 08/11] aarch64: Inline aarch64_get_all_extension_candidates

2025-01-24 Thread Andrew Carlotti
gcc/ChangeLog: * common/config/aarch64/aarch64-common.cc (aarch64_get_all_extension_candidates): Inline into... (aarch64_print_hint_for_extensions): ...this. diff --git a/gcc/common/config/aarch64/aarch64-common.cc b/gcc/common/config/aarch64/aarch64-common.cc index c3e

[PATCH v2 05/11] aarch64: Adjust option parsing parameter types.

2025-01-24 Thread Andrew Carlotti
Replace `const struct processor *` in output parameters with `aarch64_arch` or `aarch64_cpu`. Replace `std:string` parameter in aarch64_print_hint_for_extensions with `char *`. Also name the return parameters more clearly and consistently. gcc/ChangeLog: * config/aarch64/aarch64.cc

[PATCH v2 04/11] aarch64: Rename info structs in aarch64-common.cc

2025-01-24 Thread Andrew Carlotti
Also add a (currently unused) processor field to aarch64_processor_info, and change name from "" to NULL for the terminating array entries. gcc/ChangeLog: * common/config/aarch64/aarch64-common.cc (struct aarch64_option_extension): Rename to.. (struct aarch64_extension_inf

[PING^2]: [PATCH] testsuite: arm: Use effective-target for pr68674.c test

2025-01-24 Thread Torbjorn SVENSSON
Another ping... :) Kind regards, Torbjörn On 2024-12-19 20:22, Torbjorn SVENSSON wrote: Gentle ping :) Kind regards, Torbjörn On 2024-11-14 17:32, Torbjorn SVENSSON wrote: On 2024-11-14 16:26, Christophe Lyon wrote: On Fri, 8 Nov 2024 at 18:54, Torbjörn SVENSSON wrote: Ok for trunk and

[PING^2] [PATCH] testsuite: arm: Use effective-target for unsigned-extend-1.c

2025-01-24 Thread Torbjorn SVENSSON
Another ping... :) Kind regards, Torbjörn On 2024-12-18 18:35, Torbjorn SVENSSON wrote: Gentle ping :) Kind regards, Torbjörn On 2024-11-14 17:16, Torbjorn SVENSSON wrote: On 2024-11-14 16:32, Christophe Lyon wrote: On Fri, 8 Nov 2024 at 19:49, Torbjörn SVENSSON wrote: Ok for trunk and

[pushed][PR118497][IRA]: Fix calculation of cost of assigning callee-saved hard reg

2025-01-24 Thread Vladimir Makarov
The following patch fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=118497 The patch was successfully bootstrapped and tested on x86_64, aarch64, ppc64le. The patch changes cost calculation and in many cases it results in new testsuite failures on different targets.   But I hope it will n

[PATCH v2] wwwdocs: add a Python postprocessing script

2025-01-24 Thread David Malcolm
Changed in v2: rather than replacing "mhc", this version runs the output from mhc through the Python script. I tested this via "MHC=cat", and the output appears identical to the previous build I uploaded to: https://dmalcolm.fedorapeople.org/gcc/2025-01-15/htdocs/ You can see e.g. the easily cli

Re: [GCC16 stage 1][RFC][PATCH 0/3]extend "counted_by" attribute to pointer fields of structures

2025-01-24 Thread Joseph Myers
On Fri, 24 Jan 2025, Martin Uecker wrote: > No doubt, but this is a semantic difference which does necessarily imply > that the syntax has to be different. The syntax of initialization seems > intentionally designed to look like assignment to be intuitive.  > The "=" in designators otherwise seems

Re: [GCC16 stage 1][RFC][PATCH 0/3]extend "counted_by" attribute to pointer fields of structures

2025-01-24 Thread Joseph Myers
On Fri, 24 Jan 2025, Bill Wendling wrote: > > First, I should point out that the proposed standard feature in this area > > (which received along-the-lines support at the WG14 meeting in Strasbourg > > last year, though with a very large number of issues with the proposed > > wording that would ne

[PATCH] RISC-V: ensure needed FRM restore is not eliminable [PR118646]

2025-01-24 Thread Vineet Gupta
RV-Vector FP-INT insns use the rounding mode in FRM register which if explicitly set for V insn needs, is saved/restored (although from the psABI CC Spec, it is not clear if it actually a caller-saved or callee-saved). Anyhow in the failure case the save/restore were generated by the Mode Switch p

Re: [PATCH v2 01/12] OpenMP/PolyInt: Pass poly-int structures by address to OMP libs.

2025-01-24 Thread Jakub Jelinek
On Fri, Jan 24, 2025 at 12:39:07PM +0530, Tejas Belagod wrote: > One more thing I wanted to reconfirm. As I had indicated in the v1 of the > series, these patches are based on Richard's original patch and your > subsequent review > > https://gcc.gnu.org/pipermail/gcc-patches/2023-February/611892.h

Re: [PATCH 1/2] LoongArch: Fix wrong code with _alsl_reversesi_extended

2025-01-24 Thread Lulu Cheng
在 2025/1/24 下午3:58, Richard Sandiford 写道: Lulu Cheng writes: 在 2025/1/22 上午8:49, Xi Ruoyao 写道: The second source register of this insn cannot be the same as the destination register. gcc/ChangeLog: * config/loongarch/loongarch.md (_alsl_reversesi_extended): Add '&' to the d

Re: [patch. libgfortran] PR118571 UTF-8 output and the A edit descriptor

2025-01-24 Thread Andre Vehreschild
Hi Jerry, the patch looks good to me. One small nit: in write.c after the period of the first sentence should be two space, when I am not mistaken. Thanks for the patch, Andre On Thu, 23 Jan 2025 13:18:55 -0800 Jerry D wrote: > Hello all, > > The attached patch is straight forward. I

RE: [PATCH 2/4] cfgloopmanip: Add infrastructure for scaling of multi-exit loops [PR117790]

2025-01-24 Thread Tamar Christina
ping > -Original Message- > From: Tamar Christina > Sent: Wednesday, January 15, 2025 2:08 PM > To: Alex Coplan ; gcc-patches@gcc.gnu.org > Cc: Richard Biener ; Jan Hubicka > Subject: RE: [PATCH 2/4] cfgloopmanip: Add infrastructure for scaling of > multi-exit > loops [PR117790] > > Pin

RE: [PATCH 3/4] vect: Ensure profile consistency when adding epilog guard [PR117790]

2025-01-24 Thread Tamar Christina
ping > -Original Message- > From: Tamar Christina > Sent: Wednesday, January 15, 2025 2:08 PM > To: Alex Coplan ; gcc-patches@gcc.gnu.org > Cc: Richard Biener ; Jan Hubicka > Subject: RE: [PATCH 3/4] vect: Ensure profile consistency when adding epilog > guard [PR117790] > > Ping > > > -

RE: [PATCH 1/4] vect: Set counts of early break exit blocks correctly [PR117790]

2025-01-24 Thread Tamar Christina
ping > -Original Message- > From: Tamar Christina > Sent: Wednesday, January 15, 2025 2:07 PM > To: Alex Coplan ; gcc-patches@gcc.gnu.org > Cc: Richard Biener ; Jan Hubicka > Subject: RE: [PATCH 1/4] vect: Set counts of early break exit blocks correctly > [PR117790] > > Ping > > > -

RE: [PATCH 4/4] vect: Fix scale_profile_for_vect_loop for multiple exits [PR117790]

2025-01-24 Thread Tamar Christina
ping > -Original Message- > From: Tamar Christina > Sent: Wednesday, January 15, 2025 2:08 PM > To: Alex Coplan ; gcc-patches@gcc.gnu.org > Cc: Richard Biener ; Jan Hubicka > Subject: RE: [PATCH 4/4] vect: Fix scale_profile_for_vect_loop for multiple > exits > [PR117790] > > Ping > > >

GCC JIT PR118587 - tentative patch 1

2025-01-24 Thread Basile Starynkevitch
Hello all, The following patch to GCC trunk commit 91fa9c15cc4fb9 could provide a (partial) fix to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=118587 diff --git a/gcc/jit/jit-recording.h b/gcc/jit/jit-recording.h index 0ac9245c2df..5e54f02923f 100644 --- a/gcc/jit/jit-recording.h +++ b/gcc/jit/

Re: [PATCH v3 6/6] c++/modules: Diagnose TU-local lambdas, give mangling scope to lambdas in concepts

2025-01-24 Thread Jason Merrill
On 1/23/25 5:11 PM, Nathaniel Shead wrote: On Thu, Jan 23, 2025 at 04:47:32PM -0500, Jason Merrill wrote: On 1/6/25 7:24 AM, Nathaniel Shead wrote: Happy to defer this till GCC16 if preferred. -- >8 -- This fills in a hole left in r15-6378-g9016c5ac94c557 with regards to detection of TU-local

Re: [PATCH] asan: Fix missing FakeStack flag cleanup

2025-01-24 Thread Jakub Jelinek
On Thu, Jan 09, 2025 at 01:15:30AM +0100, Ilya Leoshkevich wrote: > Bootstrapped and regtested on x86_64-redhat-linux. Ok for master? > > > > The FakeStack flag is not zeroed out when can_store_by_pieces() > returns false. Over time, this causes FakeStack::Allocate() to perform > the maximum n

Re: [PATCH/GCC16 1/1] AArch64: Define the spaceship optab [PR117013]

2025-01-24 Thread Richard Sandiford
Spencer Abson writes: > This expansion ensures that exactly one comparison is emitted for > spacesip-like sequences on floating-point operands, including when > the result of such sequences are compared against members of > std. > > For both integer and floating-point types, we optimize for th

[pushed: r15-7179] jit: fix for write_reproducer [PR117886]

2025-01-24 Thread David Malcolm
The original generated .c reproducer for PR jit/117886 did not compile, with: main.c: In function ‘create_code’: main.c:600:9: error: initialization of ‘gcc_jit_rvalue *’ from incompatible pointer type ‘gcc_jit_lvalue *’ [-Wincompatible-pointer-types] 600 | local__1, | ^~~

[PATCH v2] c++: ICE with nested anonymous union [PR117153]

2025-01-24 Thread Marek Polacek
On Wed, Jan 15, 2025 at 11:55:28AM -0500, Jason Merrill wrote: > On 1/15/25 9:43 AM, Jason Merrill wrote: > > On 11/25/24 4:46 PM, Marek Polacek wrote: > > > Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk/14? > > > > > > -- >8 -- > > > In a template, for > > > > > >    union { > > >

[pushed: r15-7178] sarif-replay: respect prefix and suffix during installation [PR117670]

2025-01-24 Thread David Malcolm
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to trunk as r15-7178-gd49667be2c2953. gcc/ChangeLog: PR sarif-replay/117670 * Makefile.in (SARIF_REPLAY_INSTALL_NAME): New. (install-libgdiagnostics): Use it,and exeext, rather than just sarif-rep

[PATCH v2 10/11] aarch64: Refactor aarch64_rewrite_mcpu

2025-01-24 Thread Andrew Carlotti
Use aarch64_validate_cpu instead of the existing duplicate (and worse) version of the -mcpu parsing code. The original code used fatal_error; I'm guessing that using error instead should be ok. gcc/ChangeLog: * common/config/aarch64/aarch64-common.cc (aarch64_rewrite_selected_cpu

[PATCH v2 1/3] aarch64: Add command line support for armv9.5-a

2025-01-24 Thread Andrew Carlotti
--- I've added a test that I accidentally omitted from the v1 patch. I've also made the changes Richard requested for the whole patch series. I'll push this once my regression test finishes if there aren't any issues raised before then. gcc/ChangeLog: * config/aarch64/aarch64-arches.d

[PATCH v2 2/3] docs: Add +wfxt and +xs to armv9.2-a

2025-01-24 Thread Andrew Carlotti
I missed that the documentation doesn't include armv8.7-a within armv9.2-a. I'll commit this as obvious. gcc/ChangeLog: * doc/invoke.texi: Add +wfxt and +xs to armv9.2-a diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index 819a684393423e53bcbb1462e5a323e3a33217b9..c8721064f91

[PATCH v2 01/11] aarch64: Improve mcpu/march conflict check

2025-01-24 Thread Andrew Carlotti
Features from a cpu or base architecture that were explicitly disabled by a +nofeat option were being incorrectly added back in before checking for conflicts between -mcpu and -march options. This patch instead compares the returned feature masks directly. gcc/ChangeLog: * config/aarch64

[PATCH v2 09/11] aarch64: Rewrite architecture strings for assembler

2025-01-24 Thread Andrew Carlotti
Add infrastructure to allow rewriting the architecture strings passed to the assembler (either as -march options or .arch directives). There was already canonicalisation everywhere except for an -march driver option passed directly to the compiler; this patch applies the same canonicalisation ther

[PATCH v2 06/11] aarch64: Inline aarch64_print_hint_for_core_or_arch

2025-01-24 Thread Andrew Carlotti
It seems odd that we add "native" to the list for -march but not for -mcpu. This is probably a bug, but for now we'll preserve the existing behaviour. gcc/ChangeLog: * config/aarch64/aarch64.cc (aarch64_print_hint_candidates): New helper function. (aarch64_print_hint_for_

[PATCH v2 11/11] aarch64: Make AARCH64_FL_CRYPTO always unset

2025-01-24 Thread Andrew Carlotti
This feature flag bit only exists to support the +crypto alias. Outside of option processing this bit needs to be set or unset consistently. This patch goes with the latter option. gcc/ChangeLog: * common/config/aarch64/aarch64-common.cc: Assert that CRYPTO bit is not set.

[PATCH v2 3/3] aarch64: Add +cpa feature flag

2025-01-24 Thread Andrew Carlotti
This doesn't enable anything within the compiler, but this allows the flag to be passed the assembler. There also doesn't appear to be a kernel cpuinfo name yet. Ok for master? gcc/ChangeLog: * config/aarch64/aarch64-arches.def (V9_5A): Add CPA. * config/aarch64/aarch64-option-

Re: [GCC16 stage 1][RFC][PATCH 0/3]extend "counted_by" attribute to pointer fields of structures

2025-01-24 Thread Joseph Myers
On Thu, 23 Jan 2025, Martin Uecker wrote: > I can see why it could be seen in this way. But the designator > syntax could also be seen (more or less) as a tiny subset of > the expression syntax allowing only assignments. It is just Initializers are not assignments. They should not be confused wi

Re: [PATCH v2 3/3] aarch64: Add +cpa feature flag

2025-01-24 Thread Richard Sandiford
Andrew Carlotti writes: > This doesn't enable anything within the compiler, but this allows the > flag to be passed the assembler. There also doesn't appear to be a > kernel cpuinfo name yet. > > > Ok for master? > > gcc/ChangeLog: > > * config/aarch64/aarch64-arches.def (V9_5A): Add CPA. >

Re: [GCC16 stage 1][RFC][PATCH 0/3]extend "counted_by" attribute to pointer fields of structures

2025-01-24 Thread Martin Uecker
Am Freitag, dem 24.01.2025 um 14:23 + schrieb Joseph Myers: > On Thu, 23 Jan 2025, Martin Uecker wrote: > > > I can see why it could be seen in this way. But the designator > > syntax could also be seen (more or less) as a tiny subset of > > the expression syntax allowing only assignments. It

Re: [PATCH v2] c++: Don't prune constant capture proxies only used in array dimensions [PR114292]

2025-01-24 Thread Simon Martin
Hi Jason, On 23 Jan 2025, at 22:56, Jason Merrill wrote: > On 1/23/25 12:06 PM, Simon Martin wrote: >> Hi Marek, >> >> On 23 Jan 2025, at 16:45, Marek Polacek wrote: >> >>> On Thu, Jan 23, 2025 at 02:40:09PM +, Simon Martin wrote: Hi Jason, On 20 Jan 2025, at 22:49, Jason Merri

Re: [PATCH] aarch64: Provide initial specifications for Apple CPU cores.

2025-01-24 Thread Andrew Carlotti
On Tue, Jan 21, 2025 at 08:21:45PM +, Iain Sandoe wrote: > > > > On 20 Jan 2025, at 18:33, Andrew Carlotti wrote: > > > > On Mon, Jan 20, 2025 at 06:29:12PM +, Tamar Christina wrote: > >>> -Original Message- > >>> From: Iain Sandoe > >>> Sent: Monday, January 20, 2025 6:15 PM >

Re: [PING^2,PATCH] Add target hook to assemble a VAR_DECL

2025-01-24 Thread Georg-Johann Lay
Am 24.01.25 um 12:59 schrieb Georg-Johann Lay: Am 24.01.25 um 08:18 schrieb Richard Biener: On Thu, Jan 23, 2025 at 4:53 PM Georg-Johann Lay wrote: Am 23.01.25 um 14:58 schrieb Richard Biener: On Thu, Jan 23, 2025 at 2:23 PM Georg-Johann Lay wrote: Hi, this is Ping #2 for a patch from 202

Re: [PATCH v2] c++: Don't prune constant capture proxies only used in array dimensions [PR114292]

2025-01-24 Thread Jason Merrill
On 1/24/25 6:19 AM, Simon Martin wrote: Hi Jason, On 23 Jan 2025, at 22:56, Jason Merrill wrote: On 1/23/25 12:06 PM, Simon Martin wrote: Hi Marek, On 23 Jan 2025, at 16:45, Marek Polacek wrote: On Thu, Jan 23, 2025 at 02:40:09PM +, Simon Martin wrote: Hi Jason, On 20 Jan 2025, at 22

Re: [PATCH v2] c++: ICE with nested anonymous union [PR117153]

2025-01-24 Thread Jason Merrill
On 1/24/25 11:08 AM, Marek Polacek wrote: On Wed, Jan 15, 2025 at 11:55:28AM -0500, Jason Merrill wrote: On 1/15/25 9:43 AM, Jason Merrill wrote: On 11/25/24 4:46 PM, Marek Polacek wrote: Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk/14? -- >8 -- In a template, for    union {

Re: [PATCH] c++: Reinstate check for uninitialized bases with c++ <= 17 [PR118239]

2025-01-24 Thread Jason Merrill
On 1/23/25 12:20 PM, Simon Martin wrote: Hi Jason, On 21 Jan 2025, at 22:51, Jason Merrill wrote: On 1/3/25 3:00 PM, Simon Martin wrote: We currently accept this code with c++ <= 17 even though it's invalid since the base is not initialized (we properly reject it with c++ >= 20) === cut here

Re: [PATCH] c++/modules: Fix linkage checks for exported using-decls

2025-01-24 Thread Jason Merrill
On 1/23/25 11:50 AM, yxj-github-437 wrote: On 1/15/25 7:36 PM, yxj-github-437 wrote: On Fri, Jan 03, 2025 at 05:18:55PM +, xxx wrote: From: yxj-github-437 <2457369...@qq.com> This patch attempts to fix an error when build module std. The reason for the error is __builrin_va_list (aka struc

Re: [PATCH] c++, v2: Only destruct elts of array for new expression if exception is thrown during the initialization [PR117827]

2025-01-24 Thread Jason Merrill
On 1/24/25 1:55 PM, Jakub Jelinek wrote: On Fri, Jan 24, 2025 at 12:45:54PM -0500, Jason Merrill wrote: The following testcase r12-6328, because the elements of the array are destructed twice, once when the callee encounters delete[] p; and then second time when the exception is thrown. The arra

[PATCH v3] [ifcombine] avoid creating out-of-bounds BIT_FIELD_REFs [PR118514]

2025-01-24 Thread Alexandre Oliva
On Jan 24, 2025, Richard Biener wrote: > Hmm. I think when an original ref could trap that should be the > insertion point (or the original ref should post-dominate the insertion > point). I suppose we could do that, but... intuitively, it doesn't feel safe to move a nontrapping load down to

Re: [PATCH 4/6] Move ferror out of hot loop of file cache

2025-01-24 Thread Richard Biener
> Am 27.12.2024 um 03:48 schrieb Andi Kleen : > > From: Andi Kleen > > glibc ferror is surprisingly expensive. Move it out of the hot loop > of finding lines by setting a flag after the actual IO operations. This 4/6 is OK. Richard > gcc/ChangeLog: > >PR preprocessor/118168 >* i

[PATCH] tree-optimization/116010 - dr_may_alias regression

2025-01-24 Thread Richard Biener
r15-491-gc290e6a0b7a9de fixed a latent issue with dr_analyze_innermost and dr_may_alias where not properly analyzed DRs would yield an invalid answer. This caused some missed optimizations in case there is not actually any evolution in the not analyzed base part. The following recovers this by on

Re: [PATCH] c++, v2: Implement for namespace statics CWG 2867 - Order of initialization for structured bindings [PR115769]

2025-01-24 Thread Jason Merrill
On 1/23/25 9:47 AM, Jakub Jelinek wrote: On Wed, Jan 22, 2025 at 04:19:38PM -0500, Jason Merrill wrote: @@ -4482,6 +4536,7 @@ emit_partial_init_fini_fn (bool initp, u /* Do one initialization or destruction. */ one_static_initialization_or_destruction (initp, decl, init);