RE: [PATCH v1] Widening-Mul: Fix one ICE for SAT_SUB matching operand promotion

2024-09-23 Thread Li, Pan2
Thanks Uros for comments. > This is not "target", but "middle-end" component. Even though the bug > is exposed on x86_64 target, the fix is in the middle-end code, not in > the target code. Sure, will rename to middle-end. > Please remove -m32 and use "{ dg-do compile { target ia32 } }" instead.

[PATCH] gfortran testsuite: Remove unit-files in files having open-statements, PR116701

2024-09-23 Thread Hans-Peter Nilsson
Here's a general approach to handle PR116701. I considered adding manual deletions as quoted below and mentioned in the PR, but seeing the handling of "integer 8" in fortran-torture-execute I decided to follow that example: better scan the source for open-statements than relying on manual annotati

RE: [PATCH]middle-end: check explicitly for external or constants when checking for loop invariant [PR116817]

2024-09-23 Thread Richard Biener
On Mon, 23 Sep 2024, Tamar Christina wrote: > I had made the condition to strict before, here's an updated patch: > > Hi All, > > The previous check if a value was external was checking > !vect_get_internal_def (vinfo, var) but this of course isn't completely right > as they could reductions etc

Re: [PATCH 01/10] libstdc++: Remove unnecessary 'static' from __is_specialization_of

2024-09-23 Thread Jonathan Wakely
On Tue, 24 Sept 2024, 00:44 Nathaniel Shead, wrote: > Bootstrapped and regtested on x86_64-pc-linux-gnu, OK for trunk? > OK, thanks > -- >8 -- > > This makes the declarations internal linkage, which is an ODR issue, and > causes a future modules patch to fail regtest as it now detects attempte

[PATCH] tree-optimization/114855 - high update_ssa time

2024-09-23 Thread Richard Biener
Part of the problem in PR114855 is high update_ssa time. When one fixes the backward jump threading issue tree SSA incremental is at 439.91s ( 26%), mostly doing bitmap element searches for blocks_with_phis_to_rewrite. The following turns that bitmap to tree view noticing the two-dimensional vect

[PATCH] aarch64: Expand CTZ to RBIT + CLZ for SVE [PR109498]

2024-09-23 Thread Soumya AR
Currently, we vectorize CTZ for SVE by using the following operation: .CTZ (X) = (PREC - 1) - .CLZ (X & -X) Instead, this patch expands CTZ to RBIT + CLZ for SVE, as suggested in PR109498. The patch was bootstrapped and regtested on aarch64-linux-gnu, no regression. OK for mainline? Signed-off-b

Re: [PATCH v1] Widening-Mul: Fix one ICE for SAT_SUB matching operand promotion

2024-09-23 Thread Uros Bizjak
On Tue, Sep 24, 2024 at 8:24 AM Li, Pan2 wrote: > > Thanks Uros for comments. > > > This is not "target", but "middle-end" component. Even though the bug > > is exposed on x86_64 target, the fix is in the middle-end code, not in > > the target code. > > Sure, will rename to middle-end. > > > Pleas

<    1   2