[PATCH v1] RISC-V: Bugfix vec_extract v mode iterator restriction mismatch

2024-06-14 Thread pan2 . li
From: Pan Li We have vec_extract pattern which takes ZVFHMIN as the mode iterator of the V mode. Aka VF_ZVFHMIN iterator. But it will expand to pred_extract_first pattern which takes the ZVFH as the mode iterator of the V mode. AKa VF. The mismatch will result in one ICE similar as below: in

[PATCH] Fix fallout of peeling for gap improvements

2024-06-14 Thread Richard Biener
The following hopefully addresses an observed bootstrap issue on aarch64 where maybe-uninit diagnostics occur. It also fixes bogus napkin math from myself when I was confusing rounded up size of a single access with rounded up size of the group accessed in a single scalar iteration. So the followi

Re: [PATCH] rs6000, altivec-2-runnable.c should be a runnable test

2024-06-14 Thread Kewen.Lin
Hi! on 2024/6/14 05:16, Carl Love wrote: > Segher: > > On 6/13/24 12:51, Segher Boessenkool wrote: > > > >> >>> --- a/gcc/testsuite/gcc.target/powerpc/altivec-2-runnable.c >>> +++ b/gcc/testsuite/gcc.target/powerpc/altivec-2-runnable.c >>> @@ -1,4 +1,4 @@ >>> -/* { dg-do compile { target power

Re: [Patch, Fortran, 96418] Fix Test coarray_alloc_comp_4.f08 ICEs

2024-06-14 Thread Andre Vehreschild
Hi all, I messed up renaming of the coarray_alloc_comp-test. This is fixed in the second version of the patch. Sorry for the inconvenience. Additionally I figured that this patch also fixed PR fortran/103112. Regtests ok on x86_64 Fedora 39. Ok for mainline? Regards, Andre On Tue, 11 J

Re: [PATCH v1] RISC-V: Bugfix vec_extract v mode iterator restriction mismatch

2024-06-14 Thread Kito Cheng
LGTM, thanks :) On Fri, Jun 14, 2024 at 3:02 PM wrote: > > From: Pan Li > > We have vec_extract pattern which takes ZVFHMIN as the mode > iterator of the V mode. Aka VF_ZVFHMIN iterator. But it will > expand to pred_extract_first pattern which takes the ZVFH as the mode > iterator of the V mod

[pushed] wwwdocs: gcc-11: Fix grammar - template alias parameters

2024-06-14 Thread Gerald Pfeifer
Elsewhere, for example in the D documentation, template is used in singular, too. Pushed. Gerald --- htdocs/gcc-11/changes.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/htdocs/gcc-11/changes.html b/htdocs/gcc-11/changes.html index b4ecf3c0..3737af5b 100644 --- a/htdoc

[COMMITTED 01/16] ada: Remove unused name of aspect from Snames

2024-06-14 Thread Marc Poulhiès
From: Eric Botcazou gcc/ada/ * snames.ads-tmpl (Name_Storage_Model): Delete. Tested on x86_64-pc-linux-gnu, committed on master. --- gcc/ada/snames.ads-tmpl | 1 - 1 file changed, 1 deletion(-) diff --git a/gcc/ada/snames.ads-tmpl b/gcc/ada/snames.ads-tmpl index 6cc66566907..699b8df5

[COMMITTED 04/16] ada: Missing initialization of multidimensional array using sliding

2024-06-14 Thread Marc Poulhiès
From: Javier Miranda When a multidimensional array is initialized with an array aggregate, and inner dimensions of the array are initialized with array subaggregates using sliding, the code generated by the compiler does not initialize the inner dimensions of the array. gcc/ada/ * exp_a

[COMMITTED 03/16] ada: Couple of small cleanups in semantic analysis of aspects

2024-06-14 Thread Marc Poulhiès
From: Eric Botcazou The first cleanup is to expose a consistent interface from Sem_Ch13 for the analysis of aspects at various points of the program. The second cleanup is to fix the awkward implementation of the analysis of the specification for the aspects Stable_Properties, Designated_Storage

[COMMITTED 02/16] ada: Allow implicit dereferenced for uses of 'Super

2024-06-14 Thread Marc Poulhiès
From: Justin Squirek This patch modifies the experimental 'Super attribute to allow an access-valued prefix to be equivalent to Prefix.all'Super. gcc/ada/ * sem_attr.adb: (Analyze_Attribute): Add check for dereference. Tested on x86_64-pc-linux-gnu, committed on master. --- g

[COMMITTED 06/16] ada: Crash checking accessibility level on private type

2024-06-14 Thread Marc Poulhiès
From: Justin Squirek This patch fixes an issue in the compiler whereby calculating a static accessibility level on a private type with an access discriminant resulted in a compile time crash when No_Dynamic_Accessibility_Checks is enabled. gcc/ada/ * accessibility.adb: (Accessib

[COMMITTED 09/16] ada: Simplify handling of VxWorks-specific error codes for ENOENT

2024-06-14 Thread Marc Poulhiès
From: Jerome Guitton These error codes were defined on older versions of VxWorks (5, 6, 7 SR0540) and now they are either not defined or they fallback to ENOENT. To handle these cases without using complex tests against vxworks versions, leverage on __has_include and provide a fallback to ENOENT

[COMMITTED 05/16] ada: Minor tweaks to processing of Aggregate aspect

2024-06-14 Thread Marc Poulhiès
From: Eric Botcazou The main one is to give the error for Aggregate applied to array types from Analyze_Aspects_At_Freeze_Point instead of Check_Aspect_At_Freeze_Point, as for the other aspects. The message is also changed to be more direct. gcc/ada/ * aspects.ads (Operational_Aspect):

[COMMITTED 08/16] ada: Minor tweak in Snames

2024-06-14 Thread Marc Poulhiès
From: Eric Botcazou gcc/ada/ * snames.ads-tmpl (Name_Present): Move to Repinfo section. Tested on x86_64-pc-linux-gnu, committed on master. --- gcc/ada/snames.ads-tmpl | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/gcc/ada/snames.ads-tmpl b/gcc/ada/snames.ads-

[COMMITTED 13/16] ada: Do not create null GCC thunks

2024-06-14 Thread Marc Poulhiès
From: Eric Botcazou This prevents Gigi from creating null GCC thunks, i.e. thunks that have all their internal parameters set to zero, replacing them with aliases. They can arise in degenerate cases and null thunks would trip on an assertion in former_thunk_p when they are later optimized. gcc/

[COMMITTED 10/16] ada: Bad tree built for Obj.Discrim_Dep_Component'Loop_Entry in assertion

2024-06-14 Thread Marc Poulhiès
From: Steve Baird The Etype for an N_Selected_Component node usually should not match the Etype of the referenced component if the component is subject to a discriminant-dependent constraint. Instead Build_Actual_Subtype_Of_Component should be called. Fix a case where this rule was not being foll

[COMMITTED 12/16] ada: Typo and indentation fix

2024-06-14 Thread Marc Poulhiès
Fixes typo in comments and 2 instances of bad indentation. gcc/ada/ * gcc-interface/decl.cc (gnat_to_gnu_entity): Typo fix. (gnat_to_gnu_component_type): Indent fix. * gcc-interface/gigi.h (build_call_alloc_dealloc): Typo fix. * gcc-interface/utils.cc (make_dummy_t

[COMMITTED 11/16] ada: Fix parts of classification of aspects

2024-06-14 Thread Marc Poulhiès
From: Eric Botcazou Many aspects are (correctly) marked as GNAT-specific but nevertheless not listed in the Implementation_Defined_Aspect array, so this aligns the two sides and also removes Default_Initial_Condition and Object_Size from the list, since they are defined in Ada 2022. This also mo

[COMMITTED 16/16] ada: Do not include target-specific makefile fragments

2024-06-14 Thread Marc Poulhiès
From: Eric Botcazou They are unused in this context. gcc/ada/ * gcc-interface/Makefile.in (tmake_file): Remove all references. Tested on x86_64-pc-linux-gnu, committed on master. --- gcc/ada/gcc-interface/Makefile.in | 6 -- 1 file changed, 6 deletions(-) diff --git a/gcc/ada/gc

[COMMITTED 07/16] ada: Add prototype for mutably tagged types

2024-06-14 Thread Marc Poulhiès
From: Justin Squirek This patch implements mutably tagged types via the new Size'Class aspect. gcc/ada/ * doc/gnat_rm/gnat_language_extensions.rst: Add documentation for mutably tagged type feature. * aspects.ads: Add registration for 'Size'Class. * einfo.ads: Ad

[COMMITTED 15/16] ada: Fix return mechanism reported by -gnatRm

2024-06-14 Thread Marc Poulhiès
From: Eric Botcazou The return mechanism of functions is reported when the -gnatRm switch is specified, but it is incorrect when the result type is not a by-reference type in the language sense but is nevertheless returned by reference. gcc/ada/ * gcc-interface/decl.cc: Include function

[COMMITTED 14/16] ada: Skip subprogram body entities inside scopes

2024-06-14 Thread Marc Poulhiès
From: Yannick Moy Entities of kind E_Subprogram_Body, used on bodies of subprograms for which there is a separate declaration, have been added in the entities linked from a scope in order to get the representation information on their enclosed object and type declarations. Skip these entities in

Re: [Patch, fortran] PR59104

2024-06-14 Thread Andre Vehreschild
Hi Paul, to me this looks fine. Thanks for the patch. Me having been away for some time from gfortran, I recommend you wait for Harald's ok, too. Regards, Andre On Thu, 13 Jun 2024 22:43:03 +0100 Paul Richard Thomas wrote: > Hi Both, > > Thanks for the highly constructive comments. I t

[pushed] doc: Remove reference to Interix

2024-06-14 Thread Gerald Pfeifer
This apparently was missed when support for Interix was removed in 2016. gcc: PR target/69374 * doc/install.texi (Specific): Remove stale reference to Interix. --- gcc/doc/install.texi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gcc/doc/install.texi b/gcc

RE: [PATCH v1] RISC-V: Bugfix vec_extract v mode iterator restriction mismatch

2024-06-14 Thread Li, Pan2
Committed, thanks Kito. Pan -Original Message- From: Kito Cheng Sent: Friday, June 14, 2024 3:33 PM To: Li, Pan2 Cc: gcc-patches@gcc.gnu.org; juzhe.zh...@rivai.ai; jeffreya...@gmail.com; rdapp@gmail.com Subject: Re: [PATCH v1] RISC-V: Bugfix vec_extract v mode iterator restriction

Re: [PATCH v1] Match: Support more forms for the scalar unsigned .SAT_SUB

2024-06-14 Thread Richard Biener
On Wed, Jun 12, 2024 at 2:38 PM wrote: > > From: Pan Li > > After we support the scalar unsigned form 1 and 2, we would like > to introduce more forms include the branch and branchless. There > are forms 3-10 list as below: > > Form 3: > #define SAT_SUB_U_3(T) \ > T sat_sub_u_3_##T (T x, T

Re: [PATCH 0/3] [APX CFCMOV] Support APX CFCMOV

2024-06-14 Thread Richard Biener
On Fri, Jun 14, 2024 at 8:58 AM Liu, Hongtao wrote: > > > > > -Original Message- > > From: Richard Biener > > Sent: Friday, June 14, 2024 2:52 PM > > To: Kong, Lingling > > Cc: gcc-patches@gcc.gnu.org; Liu, Hongtao ; Uros > > Bizjak > > Subject: Re: [PATCH 0/3] [APX CFCMOV] Support APX

RE: [PATCH v1] Match: Support more forms for the scalar unsigned .SAT_SUB

2024-06-14 Thread Li, Pan2
Thanks Richard for comments. > :c shouldn't be necessary on the plus > or on the bit_xor > OK with those changes. Will remove the :c and commit it if there is no surprise from test suites. Pan -Original Message- From: Richard Biener Sent: Friday, June 14, 2024 4:05 PM To: Li, Pan2 Cc

[pushed] doc: Consolidate duplicate MOVBE listings for Intel CPUs

2024-06-14 Thread Gerald Pfeifer
It might be a good idea to sort these lists alphabetically - easier to findi specific entries if one is looking for it, and that also avoids such cases? Pushed for now. Gerald gcc: * doc/invoke.texi (x86 Options): Consolidate duplicate MOVBE listings for haswell, broadwell, sky

Re: PING^1 [PATCH 44/52] s390: New hook implementation s390_c_mode_for_floating_type

2024-06-14 Thread Andreas Krebbel
On 6/13/24 09:43, Kewen.Lin wrote: Hi, Gentle ping: https://gcc.gnu.org/pipermail/gcc-patches/2024-June/653382.html BR, Kewen on 2024/6/3 11:01, Kewen Lin wrote: This is to remove macros {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE defines in s390 port, and add new port specific hook implementation s390

Re: [PATCH] s390: testsuite: Fix nobp-table-jump-*.c

2024-06-14 Thread Andreas Krebbel
On Mon, Jun 03, 2024 at 03:43:39PM +0200, Stefan Schulze Frielinghaus wrote: Starting with r14-5628-g53ba8d669550d3 interprocedural VRP became strong enough in order to render these tests useless. Fixed by disabling IPA. gcc/testsuite/ChangeLog: * gcc.target/s390/nobp-table-jump-inline

[PATCH] gccrs: configure.ac: Fix quoting around ldl/lpthread checks

2024-06-14 Thread Arthur Cohen
ChangeLog: * configure.ac: Add quoting around both variable checks performed, which will fix the noise reported when libc contains both ldl and lpthread. A typo around `pthread_create` being typed `pthread_crate` is also fixed. * configure: Regenerate. --- configur

Re: [PATCH-1v3] fwprop: Replace rtx_cost with insn_cost in try_fwprop_subst_pattern [PR113325]

2024-06-14 Thread Richard Sandiford
HAO CHEN GUI writes: >> The: >> >> bool ok = recog (attempt, use_change); >> >> should leave INSN_CODE set to the result of the successful recog. >> Why isn't that true in the example you hit? >> >> I wondered whether we might be trying to cost a NOOP_MOVE_INSN_CODE, >> since I couldn't see a

Re: [PATCH] build: Fix missing variable quotes

2024-06-14 Thread Arthur Cohen
Hi Collin, Sorry about the mess. As Sam pointed out, there was already a patch proposed in the bugzilla PR which I've posted on the ML as well for review. The only difference with your patch is that it also changes ac_cv_search_pthread_crate to ac_cv_search_pthread_create, as otherwise the ch

Re: [PATCH] build: Fix missing variable quotes

2024-06-14 Thread YunQiang Su
Sam James 于2024年6月14日周五 09:02写道: > > Collin Funk writes: > > > When dlopen and pthread_create are in libc the variable is > > set to "none required", therefore running configure will show > > the following errors: > > > > ./configure: line 8997: test: too many arguments > > ./configure: line 8999

[PATCH][v2] Support single def-use cycle optimization for SLP reduction vectorization

2024-06-14 Thread Richard Biener
We can at least mimic single def-use cycle optimization when doing single-lane SLP reductions and that's required to avoid regressing compared to non-SLP. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. * tree-vect-loop.cc (vectorizable_reduction): Allow single-def-us

[PATCH] Adjust gcc.target/i386/vect-strided-3.c

2024-06-14 Thread Richard Biener
The following disables SSE4 instead of just AVX to avoid pextrq being used, confusing the assembler scanning. This avoids the reported failure with -march=cascadelake but adds a FAIL for -march=cascadelake -m32 (I've opened PR115487 for that). Tested on x86_64-unknown-linux-gnu, pushed.

Re: [analyzer PATCH] Restore bootstrap with g++ 4.8.

2024-06-14 Thread Jonathan Wakely
On 07/06/24 19:40 +0100, Roger Sayle wrote: This patch restores bootstrap when using g++ 4.8 as a host compiler. Returning a std::unique_ptr requires a std::move on C++ compilers (pre-C++17) that don't guarantee copy elision/return value optimization. It doesn't though. The C++17 guaranteed c

Re: [analyzer PATCH] Restore bootstrap with g++ 4.8.

2024-06-14 Thread Jonathan Wakely
On 14/06/24 10:36 +0100, Jonathan Wakely wrote: On 07/06/24 19:40 +0100, Roger Sayle wrote: This patch restores bootstrap when using g++ 4.8 as a host compiler. Returning a std::unique_ptr requires a std::move on C++ compilers (pre-C++17) that don't guarantee copy elision/return value optimizat

[PATCH] middle-end/114189 - drop uses of vcond{,u,eq}_optab

2024-06-14 Thread Richard Biener
The following retires vcond{,u,eq} optabs by stopping to use them from the middle-end. Targets instead (should) implement vcond_mask and vec_cmp{,u,eq} optabs. The PR this change refers to lists possibly affected targets - those implementing these patterns, and in particular it lists mips, sparc

Re: [analyzer PATCH] Restore bootstrap with g++ 4.8.

2024-06-14 Thread Jonathan Wakely
On 14/06/24 11:26 +0100, Jonathan Wakely wrote: On 14/06/24 10:36 +0100, Jonathan Wakely wrote: On 07/06/24 19:40 +0100, Roger Sayle wrote: This patch restores bootstrap when using g++ 4.8 as a host compiler. Returning a std::unique_ptr requires a std::move on C++ compilers (pre-C++17) that do

Re: [analyzer PATCH] Restore bootstrap with g++ 4.8.

2024-06-14 Thread Jonathan Wakely
On 14/06/24 11:37 +0100, Jonathan Wakely wrote: On 14/06/24 11:26 +0100, Jonathan Wakely wrote: On 14/06/24 10:36 +0100, Jonathan Wakely wrote: On 07/06/24 19:40 +0100, Roger Sayle wrote: This patch restores bootstrap when using g++ 4.8 as a host compiler. Returning a std::unique_ptr requires

Re: [analyzer PATCH] Restore bootstrap with g++ 4.8.

2024-06-14 Thread Jonathan Wakely
On 14/06/24 11:42 +0100, Jonathan Wakely wrote: On 14/06/24 11:37 +0100, Jonathan Wakely wrote: On 14/06/24 11:26 +0100, Jonathan Wakely wrote: On 14/06/24 10:36 +0100, Jonathan Wakely wrote: On 07/06/24 19:40 +0100, Roger Sayle wrote: This patch restores bootstrap when using g++ 4.8 as a ho

Re: [PATCH-1v3] fwprop: Replace rtx_cost with insn_cost in try_fwprop_subst_pattern [PR113325]

2024-06-14 Thread HAO CHEN GUI
在 2024/6/14 16:36, Richard Sandiford 写道: > Ah, ok. If the problem is stale recog_data information, I think we > should instead make recog.cc:swap_change conditionally invalidate it. > I.e. change: > > if (changes[num].object && !MEM_P (changes[num].object)) > std::swap (INSN_CODE (change

Re: [PATCH-1v3] fwprop: Replace rtx_cost with insn_cost in try_fwprop_subst_pattern [PR113325]

2024-06-14 Thread HAO CHEN GUI
Hi Richard, Thanks for your comments. 在 2024/6/12 15:51, Richard Sandiford 写道: > It should only be necessary to call change_is_worthwhile once, > with strict == !prop.likely_profitable_p () > > So something like: > > bool ok = recog (attempt, use_change); > if (ok && !prop.changed_mem_p ()

Re: [Patch, rs6000, middle-end] v2: Add implementation for different targets for pair mem fusion

2024-06-14 Thread Richard Sandiford
Ajit Agarwal writes: > Hello Richard: > > All comments are addressed. I don't think this addresses the following comments from the previous reviews: (1) It is not correct to mark existing insn uses as live-out. The patch mustn't try to do this. (2) To quote a previous review: It's prob

Re: [PATCH] middle-end/114189 - drop uses of vcond{,u,eq}_optab

2024-06-14 Thread Richard Sandiford
Richard Biener writes: > The following retires vcond{,u,eq} optabs by stopping to use them > from the middle-end. Targets instead (should) implement vcond_mask > and vec_cmp{,u,eq} optabs. The PR this change refers to lists > possibly affected targets - those implementing these patterns, > and i

Re: [PATCH] middle-end/114189 - drop uses of vcond{,u,eq}_optab

2024-06-14 Thread Richard Biener
On Fri, 14 Jun 2024, Richard Sandiford wrote: > Richard Biener writes: > > The following retires vcond{,u,eq} optabs by stopping to use them > > from the middle-end. Targets instead (should) implement vcond_mask > > and vec_cmp{,u,eq} optabs. The PR this change refers to lists > > possibly affe

Re: [PATCH 2/3] Enabled LRA for ia64.

2024-06-14 Thread Frank Scheiner
Dear Jonathan, Jeff, On 13.06.24 12:33, Jonathan Wakely wrote: On Wed, 12 Jun 2024 at 22:00, Frank Scheiner wrote: Ok, I posted the results as created by contrib/test_summary now: 1. non-LRA version on [1] 2. LRA version on [2] [1]: https://gcc.gnu.org/pipermail/gcc-testresults/2024-June/81

[PATCH] Improve optimizer to avoid stack spill across pure function call

2024-06-14 Thread user202729
This patch was inspired from PR 110137. It reduces the amount of stack spilling by ensuring that more values are constant across a pure function call. It does not add any new flag; rather, it makes the optimizer generate more optimal code. For the added test file, the change is the following. A

Re: [PATCH] middle-end/114189 - drop uses of vcond{,u,eq}_optab

2024-06-14 Thread Richard Sandiford
Richard Biener writes: > On Fri, 14 Jun 2024, Richard Sandiford wrote: > >> Richard Biener writes: >> > The following retires vcond{,u,eq} optabs by stopping to use them >> > from the middle-end. Targets instead (should) implement vcond_mask >> > and vec_cmp{,u,eq} optabs. The PR this change re

[PATCH 1/2] Add function filtering to gcov

2024-06-14 Thread Jørgen Kvalsvik
Add the --include and --exclude flags to gcov to control what functions to report on. This is meant to make gcov more practical as an when writing test suites or performing other coverage experiments, which tends to focus on a few functions at the time. This really shines in combination with the -t

[PATCH 2/2] Add examples on filteirng in gcov tutorial

2024-06-14 Thread Jørgen Kvalsvik
Add a section with some examples on the --include and --exclude flags in the gcov tutorial. gcc/ChangeLog: * doc/gcov.texi: Add tutorial on function filtering. --- gcc/doc/gcov.texi | 86 +++ 1 file changed, 86 insertions(+) diff --git a/gcc/d

[PATCH][ivopts]: perform affine fold on unsigned addressing modes known not to overflow. [PR114932]

2024-06-14 Thread Tamar Christina
Hi All, When the patch for PR114074 was applied we saw a good boost in exchange2. This boost was partially caused by a simplification of the addressing modes. With the patch applied IV opts saw the following form for the base addressing; Base: (integer(kind=4) *) &block + ((sizetype) ((unsigne

[PATCH][ivopts]: use affine_tree when comparing IVs during candidate selection [PR114932]

2024-06-14 Thread Tamar Christina
Hi All, IVOPTS normally uses affine trees to perform comparisons between different IVs, but these seem to have been missing in two key spots and instead normal tree equivalencies used. In some cases where we have a structural equivalence but not a signedness equivalencies we end up generating bot

Re: [PATCH] middle-end/114189 - drop uses of vcond{,u,eq}_optab

2024-06-14 Thread Richard Biener
On Fri, 14 Jun 2024, Richard Sandiford wrote: > Richard Biener writes: > > On Fri, 14 Jun 2024, Richard Sandiford wrote: > > > >> Richard Biener writes: > >> > The following retires vcond{,u,eq} optabs by stopping to use them > >> > from the middle-end. Targets instead (should) implement vcond_

Re: [PATCH] middle-end/114189 - drop uses of vcond{,u,eq}_optab

2024-06-14 Thread Richard Biener
On Fri, 14 Jun 2024, Richard Biener wrote: > On Fri, 14 Jun 2024, Richard Sandiford wrote: > > > Richard Biener writes: > > > On Fri, 14 Jun 2024, Richard Sandiford wrote: > > > > > >> Richard Biener writes: > > >> > The following retires vcond{,u,eq} optabs by stopping to use them > > >> > fro

[PATCH] Build/Cross: Look for target headers from include if sys-include doesn't exist

2024-06-14 Thread YunQiang Su
PR 115416 When we build a cross toolchain, while without --with-sysroot, target headers are expected in ${test_exec_prefix}/${target_noncanonical}/sys-include while it is true only with --with-headers option is used. In other cases, the path should be ${test_exec_prefix}/${target_noncanonical}

[PATCHSET 14.2] Add documentation rules for Rust frontend

2024-06-14 Thread Arthur Cohen
Hi everyone, This is a quick and simple patchset to our Makefile in order to have proper documentation rules for the Rust frontend. Let me know if these changes would be accepted into 14.2, or if we should rather integrate them to trunk for 15.1 as part of our upstreaming process. If the changes

[PATCH 14.2 2/3] rust: Add rust.install-dvi and rust.install-html rules

2024-06-14 Thread Arthur Cohen
From: Christophe Lyon rust has the (empty) rust.dvi and rust.html rules, but lacks the (empty) rust.install-dvi and rust.install-html ones. 2024-04-04 Christophe Lyon gcc/rust/ * Make-lang.in (rust.install-dvi, rust.install-html): New rules. --- gcc/rust/Make-lang.in | 2 ++

[PATCH 14.2 1/3] gccrs: Add base documentation for using the Rust frontend.

2024-06-14 Thread Arthur Cohen
gcc/rust/ChangeLog: * Make-lang.in: Add documentation targets. * gccrs.texi: New file. --- gcc/rust/Make-lang.in | 25 +++-- gcc/rust/gccrs.texi | 207 ++ 2 files changed, 225 insertions(+), 7 deletions(-) create mode 100644 gcc/rust/gcc

[PATCH 14.2 3/3] rust: Copy install-html rule from Ada frontend

2024-06-14 Thread Arthur Cohen
gcc/rust/ChangeLog: * Make-lang.in: Add proper rust.install-html rule. --- gcc/rust/Make-lang.in | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/gcc/rust/Make-lang.in b/gcc/rust/Make-lang.in index 2395541425f..815a8b315c0 100644 --- a/gcc/rust/Make-

[PATCH] Enhance if-conversion for automatic arrays

2024-06-14 Thread Richard Biener
Automatic arrays that are not address-taken should not be subject to store data races. This applies to OMP SIMD in-branch lowered functions result array which for the testcase otherwise prevents vectorization with SSE and for AVX and AVX512 ends up with spurious .MASK_STORE to the stack surviving.

Re: [PATCH 2/3] Enabled LRA for ia64.

2024-06-14 Thread Jonathan Wakely
On Fri, 14 Jun 2024 at 12:07, Frank Scheiner wrote: > > Dear Jonathan, Jeff, > > On 13.06.24 12:33, Jonathan Wakely wrote: > > On Wed, 12 Jun 2024 at 22:00, Frank Scheiner wrote: > >> Ok, I posted the results as created by contrib/test_summary now: > >> > >> 1. non-LRA version on [1] > >> > >> 2.

[PATCH] analyzer: Fix g++ 4.8 bootstrap without using std::move to return std::unique_ptr

2024-06-14 Thread Jonathan Wakely
This builds successfully using both gcc-4.8.5 and gcc-13.3.1 as host compiler. OK for trunk if testing succeeds? -- >8 -- Revert the changes in r15--ge22b7f741ab54f and fix bootstrap with GCC 4.8 a different way. The original problem is not related to C++17 guaranteed copy elision, it's rela

Re: [PATCH 2/3] Enabled LRA for ia64.

2024-06-14 Thread Frank Scheiner
On 14.06.24 14:53, Jonathan Wakely wrote: On Fri, 14 Jun 2024 at 12:07, Frank Scheiner wrote: ...point to two headers which are part of glibc 2.39 (w/ia64 support re-added): * /usr/include/bits/sigcontext.h:32-38: ``` 32 struct __ia64_fpreg 33 { 34 union 35 { 36 unsigned lo

RE: [PATCH] tree-optimization/114589 - remove profile based sink heuristics

2024-06-14 Thread Li, Pan2
Hi Richard, Here is one PR related to this patch (by git bisect), details as below. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115458 I am still trying to narrow down which change caused this failure or any hints here? Pan -Original Message- From: Richard Biener Sent: Wednesday, M

RE: [PATCH] tree-optimization/114589 - remove profile based sink heuristics

2024-06-14 Thread Richard Biener
On Fri, 14 Jun 2024, Li, Pan2 wrote: > Hi Richard, > > Here is one PR related to this patch (by git bisect), details as below. > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115458 > > I am still trying to narrow down which change caused this failure or any > hints here? It definitely looks

RE: [PATCH] tree-optimization/114589 - remove profile based sink heuristics

2024-06-14 Thread Li, Pan2
> It definitely looks like a latent issue being triggered. Either in LRA > or in how the target presents itself. Thanks Richard, will have a try and keep you posted. Pan -Original Message- From: Richard Biener Sent: Friday, June 14, 2024 9:11 PM To: Li, Pan2 Cc: gcc-patches@gcc.gnu.o

Re: [PATCH 2/3] Enabled LRA for ia64.

2024-06-14 Thread Jonathan Wakely
On Fri, 14 Jun 2024 at 14:07, Frank Scheiner wrote: > > On 14.06.24 14:53, Jonathan Wakely wrote: > > On Fri, 14 Jun 2024 at 12:07, Frank Scheiner wrote: > >> ...point to two headers which are part of glibc 2.39 (w/ia64 support > >> re-added): > >> > >> * /usr/include/bits/sigcontext.h:32-38: > >

Re: [PING^2] Re: [PATCH v7 1/9] Improve must tail in RTL backend

2024-06-14 Thread Andi Kleen
Andi Kleen writes: PING^2 > Need reviewers for the tree and middle-end parts, as well as the C frontend. > > Thanks! > > -Andi

Re: [PATCH v4] c++: fix constained auto deduction in templ spec scopes [PR114915]

2024-06-14 Thread sska1377
On Wed, 2024-05-22 at 16:30 -0400, Jason Merrill wrote: > OK, on the right patch this time I hope. > > Looks like you still need either FSF copyright assignment or DCO > certification per https://gcc.gnu.org/contribute.html#legal > Hi. Thanks for your patience. I now have the FSF copyright assi

[PATCH v5] c++: fix constained auto deduction in templ spec scopes [PR114915]

2024-06-14 Thread Seyed Sajad Kahani
When deducing auto for `adc_return_type`, `adc_variable_type`, and `adc_decomp_type` contexts (at the usage time), we try to resolve the outermost template arguments to be used for satisfaction. This is done by one of the following, depending on the scope: 1. Checking the `DECL_TEMPLATE_INFO` of t

RE: [PATCH v1] Match: Support more forms for the scalar unsigned .SAT_SUB

2024-06-14 Thread Li, Pan2
Committed with those changes and test suites passed. Pan -Original Message- From: Li, Pan2 Sent: Friday, June 14, 2024 4:15 PM To: Richard Biener Cc: gcc-patches@gcc.gnu.org; juzhe.zh...@rivai.ai; kito.ch...@gmail.com; jeffreya...@gmail.com; rdapp@gmail.com Subject: RE: [PATCH v1]

Re: [PATCH] analyzer: Fix g++ 4.8 bootstrap without using std::move to return std::unique_ptr

2024-06-14 Thread David Malcolm
On Fri, 2024-06-14 at 13:57 +0100, Jonathan Wakely wrote: > This builds successfully using both gcc-4.8.5 and gcc-13.3.1 as host > compiler. > > OK for trunk if testing succeeds? Yes, thanks! Dave

[committed] libstdc++: Fix declaration of posix_memalign for freestanding

2024-06-14 Thread Jonathan Wakely
Tested x86_64-linux with --disable-hosted-libstdcxx where it is needed to fix the build. Pushed to trunk, backports needed too. -- >8 -- Thanks to Jérôme Duval for noticing this. libstdc++-v3/ChangeLog: * libsupc++/new_opa.cc [!_GLIBCXX_HOSTED]: Fix declaration of posix_memalig

[Fortran, Patch, PR 96992] Fix Class arrays of different ranks are rejected as storage association argument

2024-06-14 Thread Andre Vehreschild
Hi all, I somehow got assigned to this PR so I fixed it. GFortran was ICEing because of the ASSUME_RANK in a derived to class conversion. After fixing this, storage association was producing segfaults. The "shape conversion" of the class array as dummy argument was not initializing the dim 0 strid

Re: [PATCH] middle-end/114189 - drop uses of vcond{,u,eq}_optab

2024-06-14 Thread Hongtao Liu
On Fri, Jun 14, 2024 at 6:31 PM Richard Biener wrote: > > The following retires vcond{,u,eq} optabs by stopping to use them > from the middle-end. Targets instead (should) implement vcond_mask > and vec_cmp{,u,eq} optabs. The PR this change refers to lists > possibly affected targets - those imp

[committed] libstdc++: Make std::type_info::operator== always_inline for C++23 [PR110572]

2024-06-14 Thread Jonathan Wakely
Tested x86_64-linux, and lightly tested on x86_64-w64-mingw32 too, where it fixes the linker error. Pushed to trunk. Backports needed for 12, 13 and 14. -- >8 -- Commit r12-6266-g3633cc54284450 implemented P1328 for C++23, making std::type_info::operator== usable in constant expressions. For tar

Re: [PATCH] Enhance if-conversion for automatic arrays

2024-06-14 Thread Andrew Pinski
On Fri, Jun 14, 2024 at 5:54 AM Richard Biener wrote: > > Automatic arrays that are not address-taken should not be subject to > store data races. That seems conservative enough. Though I would think if the array never escaped the function would be still correct and allow for more arrays (but may

Re: [PATCH 30/52 v2] pdp11: Remove macro {FLOAT,DOUBLE,LONG_DOUBLE}_TYPE_SIZE

2024-06-14 Thread Paul Koning
Ok, I understand better now. But if those macros are supposed to be replaced by hook functions, could you make that replacement part of the proposed patch? paul > On Jun 13, 2024, at 11:22 PM, Kewen.Lin wrote: > > Hi Paul, > > on 2024/6/14 04:07, Paul Koning wrote: >> What is the eff

[r15-1330 Regression] FAIL: gcc.target/i386/vect-strided-3.c scan-assembler-times movq 4 on Linux/x86_64

2024-06-14 Thread haochen.jiang
On Linux/x86_64, 1438b15e5430f7fab3832c35d262d6b58caba469 is the first bad commit commit 1438b15e5430f7fab3832c35d262d6b58caba469 Author: Richard Biener Date: Fri Jun 14 11:31:53 2024 +0200 Adjust gcc.target/i386/vect-strided-3.c caused FAIL: gcc.target/i386/vect-strided-3.c scan-assembl

Re: [PATCH V2 1/2] RISC-V: Fix vwsll combine on rv32 targets

2024-06-14 Thread Robin Dapp
> diff --git a/gcc/config/riscv/autovec-opt.md b/gcc/config/riscv/autovec-opt.md > index 6a2eabbd854..29916adb62b 100644 > --- a/gcc/config/riscv/autovec-opt.md > +++ b/gcc/config/riscv/autovec-opt.md > @@ -1517,8 +1517,7 @@ (define_insn_and_split "*vwsll_zext1_scalar_" >"&& 1" >[(const_int

Re: [PATCH V2 2/2] RISC-V: Move mode assertion out of conditional branch in emit_insn

2024-06-14 Thread Robin Dapp
OK. Regards Robin

[patch,avr,applied] PR115419: round double to even LSB on tie breaks

2024-06-14 Thread Georg-Johann Lay
The convention in round-to-nearest floating-point rounding is to round to even ("Banker's rounding"). Johann AVR: target/115419 - Tie breaks are rounded-to-even. libgcc/config/avr/libf7/ PR target/115419 * libf7.c (f7_get_double): Round tie breaks to even LSB. diff --git a/lib

Re: [PATCH] c++: remove Concepts TS code

2024-06-14 Thread Marek Polacek
On Wed, Jun 12, 2024 at 03:08:27PM -0400, Patrick Palka wrote: > FWIW I think we can also remove DECL_DECLARED_CONCEPT_P, > function_concept_p and variable_concept_p (and related code in > grokfndecl and grokvardecl probably). And e.g. code in constraint.cc > that checks for FUNCTION_DECL, VAR_*,

Re: [PATCH 0/3] [APX CFCMOV] Support APX CFCMOV

2024-06-14 Thread Alexander Monakov
On Fri, 14 Jun 2024, Kong, Lingling wrote: > APX CFCMOV[1] feature implements conditionally faulting which means that all > memory faults are suppressed > when the condition code evaluates to false and load or store a memory > operand. Now we could load or store a > memory operand may trap or

Re: [PATCH 0/3] [APX CFCMOV] Support APX CFCMOV

2024-06-14 Thread Jeff Law
On 6/14/24 11:10 AM, Alexander Monakov wrote: On Fri, 14 Jun 2024, Kong, Lingling wrote: APX CFCMOV[1] feature implements conditionally faulting which means that all memory faults are suppressed when the condition code evaluates to false and load or store a memory operand. Now we could lo

[PATCH] libcpp, c-family: Add (dumb) C23 N3017 #embed support [PR105863]

2024-06-14 Thread Jakub Jelinek
Hi! The following patch implements the C23 N3017 "#embed - a scannable, tooling-friendly binary resource inclusion mechanism" paper. The implementation is intentionally dumb, in that it doesn't significantly speed up compilation of larger initializers and doesn't make it possible to use huge #emb

[PATCH] libstdc++: Fix build for AVR [PR115481, PR111639]

2024-06-14 Thread Detlef Vollmann
The attached patch fixes 115481 and 111639. It was tested against avr-libc 2.0.0 (which has *f as macros), 2.1.0 (which has *f as functions, but no long double), and 2.2.0 (which has long double functions). Only the libstdc++ build was tested, not the resulting library. Detlef commit 9112ae579

Re: [PATCH] libstdc++: Fix build for AVR [PR115481, PR111639]

2024-06-14 Thread Xi Ruoyao
On Fri, 2024-06-14 at 19:37 +0200, Detlef Vollmann wrote: > diff --git a/libstdc++-v3/configure b/libstdc++-v3/configure > index 5645e991af7..17dbae7bd87 100755 > --- a/libstdc++-v3/configure > +++ b/libstdc++-v3/configure > @@ -5080,7 +5080,7 @@ else >  We can't simply define LARGE_OFF_T to be

Re: [PATCH] libstdc++: Fix build for AVR [PR115481, PR111639]

2024-06-14 Thread Jonathan Wakely
On Fri, 14 Jun 2024 at 18:45, Xi Ruoyao wrote: > > On Fri, 2024-06-14 at 19:37 +0200, Detlef Vollmann wrote: > > diff --git a/libstdc++-v3/configure b/libstdc++-v3/configure > > index 5645e991af7..17dbae7bd87 100755 > > --- a/libstdc++-v3/configure > > +++ b/libstdc++-v3/configure > > @@ -5080,7 +5

[committed] testsuite: Add -Wno-psabi to vshuf-mem.C test

2024-06-14 Thread Jakub Jelinek
On Mon, Jun 10, 2024 at 10:06:31AM +0200, Andreas Krebbel wrote: > The current implementation assumes to always be invoked with register > operands. For memory operands we even have an instruction > though (vlrep). With the patch we try this first and only if it fails > force the input into a regis

Re: [PATCH v3] Target-independent store forwarding avoidance.

2024-06-14 Thread Jeff Law
On 6/13/24 5:32 AM, Manolis Tsamis wrote: This pass detects cases of expensive store forwarding and tries to avoid them by reordering the stores and using suitable bit insertion sequences. For example it can transform this: strbw2, [x1, 1] ldr x0, [x1] # Expensive sto

Re: [PATCH] middle-end/114189 - drop uses of vcond{,u,eq}_optab

2024-06-14 Thread Xi Ruoyao
On Fri, 2024-06-14 at 12:31 +0200, Richard Biener wrote: > The following retires vcond{,u,eq} optabs by stopping to use them > from the middle-end.  Targets instead (should) implement vcond_mask > and vec_cmp{,u,eq} optabs.  The PR this change refers to lists > possibly affected targets - those imp

Re: [PATCH] libstdc++: Fix build for AVR [PR115481, PR111639]

2024-06-14 Thread Detlef Vollmann
On 6/14/24 19:45, Xi Ruoyao wrote: On Fri, 2024-06-14 at 19:37 +0200, Detlef Vollmann wrote: diff --git a/libstdc++-v3/configure b/libstdc++-v3/configure index 5645e991af7..17dbae7bd87 100755 --- a/libstdc++-v3/configure +++ b/libstdc++-v3/configure @@ -5080,7 +5080,7 @@ else  We can't simp

[COMMITTED] Do not assume LHS of call is an ssa-name.

2024-06-14 Thread Andrew MacLeod
gimple_range_fold makes an assumption that if there is a LHS on a call that it is an ssa_name.  Especially later in compilation that may not be true. This patch merely avoids calling routines that assume an ssa-name is being passed in. Bootstraps on  x86_64-pc-linux-gnu with no regressions. 

[COMMITTED] Add merge facility to ssa_lazy_cache.

2024-06-14 Thread Andrew MacLeod
The ssa_lazy_cache object has a routine to merge a range for an ssa-name with an existing range in the cache.  This adds a method which will merge all elements of another ssa_lazy_cache the ssa_lazy_cache is a reasonably efficient object for storing ranges associated a few ssa-names, and it is

[COMMITTED] Dont add varying values to gori_on_edge mass, calculations.

2024-06-14 Thread Andrew MacLeod
The 'gori_on_edge' routine is an API which provides all contextual names that can be calculated on an outgoing edge at once.   It provides this via the ssa_lazy_cache object. This patch recognizes that if the value produces VARYING, we should not put it in the list, nor continue processing the

Re: [Patch, Fortran, 96418] Fix Test coarray_alloc_comp_4.f08 ICEs

2024-06-14 Thread Harald Anlauf
Hi Andre, the patch looks fairly simple and obvious, so OK from my side. *** Regarding the testsuite: since you renamed one of the testcases gfortran.dg/coarray_alloc_comp_* and moved it to gfortran.dg/coarray/, I checked and noticed that there are other similar runtime tests for coarrays (whil

  1   2   >