[PATCH (pushed)] libgccjit: silent 2 Clang warnings

2022-12-21 Thread Martin Liška
The make silent the following 2 warnings: jit/jit-playback.h:785:16: warning: private field 'm_source_file' is not used [-Wunused-private-field] jit/jit-playback.h:804:16: warning: private field 'm_line' is not used [-Wunused-private-field] gcc/jit/ChangeLog: * jit-playback.h: Use unus

[PATCH] go: fix clang warnings

2022-12-21 Thread Martin Liška
The patch fixes the following Clang warnings: gcc/go/gofrontend/escape.cc:1290:17: warning: private field 'fn_' is not used [-Wunused-private-field] gcc/go/gofrontend/escape.cc:3478:19: warning: private field 'context_' is not used [-Wunused-private-field] gcc/go/gofrontend/lex.h:564:15: warning

[committed] modula2: Fix lto profiledbootstrap on powerpc64le-linux and s390x-linux [PR108153]

2022-12-21 Thread Jakub Jelinek via Gcc-patches
Hi! Lto profiledbootstrap was failing for me on {powerpc64le,s390x}-linux with modula 2 enabled, with: cc1gm2: internal compiler error: the location value is corrupt 0x11a3d2d m2assert_AssertLocation(unsigned int) ../../gcc/m2/gm2-gcc/m2assert.cc:40 0x11a3d2d m2statement_BuildAssignmentTre

[committed] openmp: Don't try to destruct DECL_OMP_PRIVATIZED_MEMBER vars [PR108180]

2022-12-21 Thread Jakub Jelinek via Gcc-patches
Hi! DECL_OMP_PRIVATIZED_MEMBER vars are artificial vars with DECL_VALUE_EXPR of this->field used just during gimplification and omp lowering/expansion to privatize individual fields in methods when needed. As the following testcase shows, when not in templates, they were handled right, but in temp

[RFC/PATCH] Remove the workaround for _Float128 precision [PR107299]

2022-12-21 Thread Kewen.Lin via Gcc-patches
Hi, This a different attempt from Mike's approach[1][2] to fix the issue in PR107299. With option -mabi=ieeelongdouble specified, type long double (and __float128) and _Float128 have the same mode TFmode, but they have different type precisions, it causes the assertion to fail in function fold_us

Re: [PATCH] aarch64: Fix plugin header install

2022-12-21 Thread Richard Sandiford via Gcc-patches
Jakub Jelinek writes: > Hi! > > The r13-2943-g11a113d501ff64 made aarch64.h include > aarch64-option-extensions.def, but that file isn't installed > for building plugins. > > The following patch should fix that, ok for trunk if it > passes bootstrap/regtest + building plugin against it? > > 2022-1

Re: [C PATCH] remove same_translation_unit_p

2022-12-21 Thread Martin Uecker via Gcc-patches
Am Dienstag, dem 20.12.2022 um 20:04 + schrieb Joseph Myers: > On Tue, 20 Dec 2022, Martin Uecker via Gcc-patches wrote: > > > Here is a patch to remove the unused function > > same_translation_unit_p and related code. The > > code to check for structural equivalency of > > structs / unions is

Re: [PATCH] aarch64: Fix plugin header install

2022-12-21 Thread Jakub Jelinek via Gcc-patches
On Wed, Dec 21, 2022 at 09:56:33AM +, Richard Sandiford wrote: > Jakub Jelinek writes: > > The r13-2943-g11a113d501ff64 made aarch64.h include > > aarch64-option-extensions.def, but that file isn't installed > > for building plugins. > > > > The following patch should fix that, ok for trunk if

Re: [PATCH]AArch64 relax constraints on FP16 insn PR108172

2022-12-21 Thread Richard Sandiford via Gcc-patches
Tamar Christina writes: > Hi All, > > The move, load, load, store, dup, basically all the non arithmetic FP16 > instructions use baseline armv8-a HF support, and so do not require the > Armv8.2-a extensions. This relaxes the instructions. > > Bootstrapped Regtested on aarch64-none-linux-gnu and n

Re: [PATCH] aarch64: Fix plugin header install

2022-12-21 Thread Richard Sandiford via Gcc-patches
Jakub Jelinek writes: > On Wed, Dec 21, 2022 at 09:56:33AM +, Richard Sandiford wrote: >> Jakub Jelinek writes: >> > The r13-2943-g11a113d501ff64 made aarch64.h include >> > aarch64-option-extensions.def, but that file isn't installed >> > for building plugins. >> > >> > The following patch s

RE: [PATCH]AArch64 relax constraints on FP16 insn PR108172

2022-12-21 Thread Tamar Christina via Gcc-patches
> -Original Message- > From: Richard Sandiford > Sent: Wednesday, December 21, 2022 10:31 AM > To: Tamar Christina > Cc: gcc-patches@gcc.gnu.org; nd ; Richard Earnshaw > ; Marcus Shawcroft > ; Kyrylo Tkachov > Subject: Re: [PATCH]AArch64 relax constraints on FP16 insn PR108172 > > Tamar

Re: [PATCH]AArch64 relax constraints on FP16 insn PR108172

2022-12-21 Thread Richard Sandiford via Gcc-patches
Tamar Christina writes: >> -Original Message- >> From: Richard Sandiford >> Sent: Wednesday, December 21, 2022 10:31 AM >> To: Tamar Christina >> Cc: gcc-patches@gcc.gnu.org; nd ; Richard Earnshaw >> ; Marcus Shawcroft >> ; Kyrylo Tkachov >> Subject: Re: [PATCH]AArch64 relax constraints

Make -fwhole-program to work with incremental LTO linking

2022-12-21 Thread Jan Hubicka via Gcc-patches
Hi, this patches updates documentation of -fwhole-program which was wrongly claiming that it is useless with LTO whole it is useful for LTO without plugin and extends -fwhole-program to also work with incremental linking when non-LTO code is produced. This is useful when building kernel where the i

[PATCH] middle-end/107994 - ICE after error with comparison gimplification

2022-12-21 Thread Richard Biener via Gcc-patches
The following avoids passing down error_mark_node to fold_convert. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR middle-end/107994 * gimplify.cc (gimplify_expr): Catch errorneous comparison operand. --- gcc/gimplify.cc | 6 -- 1 file changed, 4 inser

[PATCH] modula2: PR-108119 Disable m2 plugin m2rte

2022-12-21 Thread Gaius Mulley via Gcc-patches
Hello, PR-108119 Disable m2 plugin m2rte (provide --enable-m2plugin configure option). The m2 plugin m2rte attempts to find reachable calls to the m2 exception handler, but it identifies the m2 exception calls by procedure name. As this won't work with other languages it should be disabled by d

Re: [committed] modula2: Fix lto profiledbootstrap on powerpc64le-linux and s390x-linux [PR108153]

2022-12-21 Thread Gaius Mulley via Gcc-patches
Jakub Jelinek writes: > Hi! > > Lto profiledbootstrap was failing for me on {powerpc64le,s390x}-linux with > modula 2 enabled, with: > cc1gm2: internal compiler error: the location value is corrupt > 0x11a3d2d m2assert_AssertLocation(unsigned int) > ../../gcc/m2/gm2-gcc/m2assert.cc:40 > 0

Re: [PATCH] modula2: PR-108119 Disable m2 plugin m2rte

2022-12-21 Thread Richard Biener via Gcc-patches
On Wed, Dec 21, 2022 at 1:35 PM Gaius Mulley via Gcc-patches wrote: > > > Hello, > > PR-108119 Disable m2 plugin m2rte (provide --enable-m2plugin configure > option). > > The m2 plugin m2rte attempts to find reachable calls to the m2 exception > handler, but it identifies the m2 exception calls b

[pushed] libffi: Fix X86 32b Darwin build and EH frames.

2022-12-21 Thread Iain Sandoe via Gcc-patches
The addition of rust has pulled in libffi as a target library for Darwin. This fails to bootstrap on some versions of i686-darwin and has build-time diagnostics on all. The EH is also invalid and those tests fail. Note that X86 Darwin is not listed as supported upstream. However I have made a pul

[PATCH 0/2]: Fix address cost complexity and register pressure cost calculation.

2022-12-21 Thread Dimitrije Milošević
Architectures like Mips are very limited when it comes to addressing modes. Therefore, the expected behavior would be that, for the BASE + OFFSET addressing mode, complexity is lower, while, for more complex addressing modes (e.g. BASE + INDEX << SCALE), which are not supported, complexity is hi

[PATCH 1/2] ivopts: Compute complexity for unsupported addressing modes.

2022-12-21 Thread Dimitrije Milošević
After f9f69dd, complexity is calculated using the valid_mem_ref_p target hook. Architectures like Mips only allow BASE + OFFSET addressing modes, which in turn prevents the calculation of complexity for other addressing modes, resulting in non-optimal candidate selection. There still is code that

[PATCH 2/2] ivopts: Revert register pressure cost when there are enough registers.

2022-12-21 Thread Dimitrije Milošević
When there are enough registers, the register pressure cost is unnecessarily bumped by adding another n_cands. This behavior may result in register pressure costs for the case when there are enough registers being higher than for other cases. When there are enough registers, the register pressure

Re: gcc-13/changes.html: Mention -fstrict-flex-arrays and its impact

2022-12-21 Thread Qing Zhao via Gcc-patches
Hi, Richard, Thanks a lot for your comments. > On Dec 21, 2022, at 2:12 AM, Richard Biener wrote: > > On Tue, 20 Dec 2022, Qing Zhao wrote: > >> Hi, >> >> This is the patch for mentioning -fstrict-flex-arrays and -Warray-bounds=2 >> changes in gcc-13/changes.html. >> >> Let me know if you h

[PATCH] c++: get_nsdmi in template context [PR108116]

2022-12-21 Thread Patrick Palka via Gcc-patches
Here during ahead of time checking of C{}, we indirectly call get_nsdmi for C::m from finish_compound_literal, which in turn calls break_out_target_exprs for C::m's (non-templated) initializer, during which we end up building a call to A::~A and checking expr_noexcept_p for it (from build_vec_delet

Re: [PATCH] c++: get_nsdmi in template context [PR108116]

2022-12-21 Thread Patrick Palka via Gcc-patches
On Wed, 21 Dec 2022, Patrick Palka wrote: > Here during ahead of time checking of C{}, we indirectly call get_nsdmi > for C::m from finish_compound_literal, which in turn calls > break_out_target_exprs for C::m's (non-templated) initializer, during > which we end up building a call to A::~A and ch

Re: [PATCHv2] Use toplevel configure for GMP and MPFR for gdb

2022-12-21 Thread Jeff Law via Gcc-patches
On 12/20/22 20:45, Andrew Pinski wrote: On Tue, Dec 20, 2022 at 10:59 AM Tom Tromey wrote: "Andrew" == apinski--- via Gdb-patches writes: Andrew> From: Andrew Pinski Andrew> This patch uses the toplevel configure parts for GMP/MPFR for Andrew> gdb. The only thing is that gdb now requir

Re: [PATCHv2] Use toplevel configure for GMP and MPFR for gdb

2022-12-21 Thread Tom Tromey
>> I think it's fine to move forward with this now. >> Thank you again for doing this. Andrew> Just to double check this is an approval? Yes, sorry for being unclear. Tom

Re: [PATCH] modula2: PR-108119 Disable m2 plugin m2rte

2022-12-21 Thread Gaius Mulley via Gcc-patches
Richard Biener writes: >> >> ChangeLog: >> >> * Makefile.def (extra_configure_flags): Add @enable_m2plugin@. >> * Makefile.in : Rebuilt. >> * configure : Rebuilt. >> * configure.ac (host_tools): Remove unused gm2tools. >> (m2plugin) New AC_ARG_ENABLE. >>

Re: [PATCH] modula2: PR-108119 Disable m2 plugin m2rte

2022-12-21 Thread Rainer Orth
Hi Gaius, Btw., you've got a couple of formatting errors in your ChangeLog entires: >>> ChangeLog: >>> >>> * Makefile.def (extra_configure_flags): Add @enable_m2plugin@. >>> * Makefile.in : Rebuilt. ^ no blank here. Besides, the entires are

[Patch] Fortran/OpenMP: Add parsing support for allocators/allocate directive (was: [Patch] Fortran/OpenMP: Add parsing support for allocators directive)

2022-12-21 Thread Tobias Burnus
Related pending (simple) patches - aka *Patch Ping*: * [Patch] Fortran: Extend align-clause checks of OpenMP's allocate clause https://gcc.gnu.org/pipermail/gcc-patches/2022-December/608401.html * [Patch] OpenMP: Parse align clause in allocate directive in C/C++ https://gcc.gnu.org/pipermail

GCC Patch Tracking [https://gcc.gnu.org/pipermail/gcc-patches/2022-August/599882.html]

2022-12-21 Thread Shinde, Yash
https://gcc.gnu.org/pipermail/gcc-patches/2022-August/599882.html Submission Date- Wed, 17 Aug 2022 Upstream-Status: Submitted The given GCC patch is with it’s current status as ‘Submitted’ but still is not taken to the upstream. Please let us know about why the patch is not taken to the upstrea

[RFC PATCH] RISC-V: Add support for vector crypto extensions

2022-12-21 Thread Christoph Muellner
From: Christoph Müllner This series adds basic support for the vector crypto extensions: * Zvkb * Zvkg * Zvkh[a,b] * Zvkn * Zvksed * Zvksh The implementation follows the version 20221220 of the specification, which can be found here: https://github.com/riscv/riscv-crypto/releases/tag/v20221220

Re: [PATCH] modula2: PR-108119 Disable m2 plugin m2rte

2022-12-21 Thread Gaius Mulley via Gcc-patches
Rainer Orth writes: > Hi Gaius, > > Btw., you've got a couple of formatting errors in your ChangeLog entires: > ChangeLog: * Makefile.def (extra_configure_flags): Add @enable_m2plugin@. * Makefile.in : Rebuilt. > ^ no blank here. Besid

Re: [PATCH V2 2/2] [x86] x86: Add a new option -mdaz-ftz to enable FTZ and DAZ flags in MXCSR.

2022-12-21 Thread H.J. Lu via Gcc-patches
On Mon, Dec 19, 2022 at 8:52 PM Hongtao Liu wrote: > > On Thu, Dec 15, 2022 at 3:45 PM Hongtao Liu wrote: > > > > On Thu, Dec 15, 2022 at 3:39 PM Jakub Jelinek wrote: > > > > > > On Thu, Dec 15, 2022 at 02:21:37PM +0800, liuhongt via Gcc-patches wrote: > > > > --- a/gcc/config/i386/i386.opt > >

Re: [RFC/PATCH] Remove the workaround for _Float128 precision [PR107299]

2022-12-21 Thread Segher Boessenkool
Hi! On Wed, Dec 21, 2022 at 05:02:17PM +0800, Kewen.Lin wrote: > This a different attempt from Mike's approach[1][2] to fix the > issue in PR107299. Ke Wen, Mike: so iiuc with this patch applied all three of Mike's patches are unnecessary? > With option -mabi=ieeelongdouble specified, > type lon

Re: [RFC/PATCH] Remove the workaround for _Float128 precision [PR107299]

2022-12-21 Thread Joseph Myers
On Wed, 21 Dec 2022, Segher Boessenkool wrote: > > --- a/gcc/tree.cc > > +++ b/gcc/tree.cc > > @@ -9442,15 +9442,6 @@ build_common_tree_nodes (bool signed_char) > >if (!targetm.floatn_mode (n, extended).exists (&mode)) > > continue; > >int precision = GET_MODE_PRECISION (mode);

Re: [PATCH] c++: get_nsdmi in template context [PR108116]

2022-12-21 Thread Jason Merrill via Gcc-patches
On 12/21/22 09:52, Patrick Palka wrote: Here during ahead of time checking of C{}, we indirectly call get_nsdmi for C::m from finish_compound_literal, which in turn calls break_out_target_exprs for C::m's (non-templated) initializer, during which we end up building a call to A::~A and checking ex

[PATCH 0/2] __bos and flex arrays

2022-12-21 Thread Siddhesh Poyarekar
Hi, The first patch in the series is just a minor test cleanup that I did to make sure all tests in a test case run (instead of aborting at first failure) and print the ones that failed. The second patch is the actual fix. The patch intends to make __bos/__bdos do the right thing with structs co

[PATCH 2/2] tree-object-size: More consistent behaviour with flex arrays

2022-12-21 Thread Siddhesh Poyarekar
The tree object size pass tries to fail when it detects a flex array in the struct, but it ends up doing the right thing only when the flex array is in the outermost struct. For nested cases (such as arrays nested in a union or an inner struct), it ends up taking whatever value the flex array is d

[PATCH 1/2] testsuite: Run __bos tests to completion

2022-12-21 Thread Siddhesh Poyarekar
Instead of failing on first error, run all __builtin_object_size and __builtin_dynamic_object_size tests to completion and then provide a summary of which tests failed. gcc/testsuite/ChangeLog: * gcc.dg/builtin-dynamic-object-size-0.c: Move FAIL and nfail into... * gcc.dg/

Re: [PATCH V2 2/2] [x86] x86: Add a new option -mdaz-ftz to enable FTZ and DAZ flags in MXCSR.

2022-12-21 Thread Jakub Jelinek via Gcc-patches
On Wed, Dec 21, 2022 at 12:20:23PM -0800, H.J. Lu wrote: > On Mon, Dec 19, 2022 at 8:52 PM Hongtao Liu wrote: > > > > On Thu, Dec 15, 2022 at 3:45 PM Hongtao Liu wrote: > > > > > > On Thu, Dec 15, 2022 at 3:39 PM Jakub Jelinek wrote: > > > > > > > > On Thu, Dec 15, 2022 at 02:21:37PM +0800, liuh

Re: [PATCH V2 2/2] [x86] x86: Add a new option -mdaz-ftz to enable FTZ and DAZ flags in MXCSR.

2022-12-21 Thread H.J. Lu via Gcc-patches
On Wed, Dec 21, 2022 at 2:35 PM Jakub Jelinek wrote: > > On Wed, Dec 21, 2022 at 12:20:23PM -0800, H.J. Lu wrote: > > On Mon, Dec 19, 2022 at 8:52 PM Hongtao Liu wrote: > > > > > > On Thu, Dec 15, 2022 at 3:45 PM Hongtao Liu wrote: > > > > > > > > On Thu, Dec 15, 2022 at 3:39 PM Jakub Jelinek w

Re: [RFC/PATCH] Remove the workaround for _Float128 precision [PR107299]

2022-12-21 Thread Jakub Jelinek via Gcc-patches
On Wed, Dec 21, 2022 at 09:40:24PM +, Joseph Myers wrote: > On Wed, 21 Dec 2022, Segher Boessenkool wrote: > > > > --- a/gcc/tree.cc > > > +++ b/gcc/tree.cc > > > @@ -9442,15 +9442,6 @@ build_common_tree_nodes (bool signed_char) > > >if (!targetm.floatn_mode (n, extended).exists (&mode

Re: [PATCH V2 2/2] [x86] x86: Add a new option -mdaz-ftz to enable FTZ and DAZ flags in MXCSR.

2022-12-21 Thread Jakub Jelinek via Gcc-patches
On Wed, Dec 21, 2022 at 02:43:43PM -0800, H.J. Lu wrote: > > > > > > > Target RejectNegative > > > > > > > Set 80387 floating-point precision to 80-bit. > > > > > > > > > > > > > > +mdaz-ftz > > > > > > > +Target > > > > > > > > > > > > s/Target/Driver/ > > > > > Change to Driver and Got error li

Re: [PATCH V2 2/2] [x86] x86: Add a new option -mdaz-ftz to enable FTZ and DAZ flags in MXCSR.

2022-12-21 Thread Hongtao Liu via Gcc-patches
On Thu, Dec 22, 2022 at 6:46 AM Jakub Jelinek wrote: > > On Wed, Dec 21, 2022 at 02:43:43PM -0800, H.J. Lu wrote: > > > > > > > > Target RejectNegative > > > > > > > > Set 80387 floating-point precision to 80-bit. > > > > > > > > > > > > > > > > +mdaz-ftz > > > > > > > > +Target > > > > > > > >

Re: [RFC/PATCH] Remove the workaround for _Float128 precision [PR107299]

2022-12-21 Thread Kewen.Lin via Gcc-patches
Hi Segher, on 2022/12/22 05:24, Segher Boessenkool wrote: > Hi! > > On Wed, Dec 21, 2022 at 05:02:17PM +0800, Kewen.Lin wrote: >> This a different attempt from Mike's approach[1][2] to fix the >> issue in PR107299. > > Ke Wen, Mike: so iiuc with this patch applied all three of Mike's > patches a

Re: [RFC/PATCH] Remove the workaround for _Float128 precision [PR107299]

2022-12-21 Thread Kewen.Lin via Gcc-patches
Hi Joseph, on 2022/12/22 05:40, Joseph Myers wrote: > On Wed, 21 Dec 2022, Segher Boessenkool wrote: > >>> --- a/gcc/tree.cc >>> +++ b/gcc/tree.cc >>> @@ -9442,15 +9442,6 @@ build_common_tree_nodes (bool signed_char) >>>if (!targetm.floatn_mode (n, extended).exists (&mode)) >>> contin

Re: gcc-13/changes.html: Mention -fstrict-flex-arrays and its impact

2022-12-21 Thread Richard Biener via Gcc-patches
On Wed, 21 Dec 2022, Qing Zhao wrote: > Hi, Richard, > > Thanks a lot for your comments. > > > On Dec 21, 2022, at 2:12 AM, Richard Biener wrote: > > > > On Tue, 20 Dec 2022, Qing Zhao wrote: > > > >> Hi, > >> > >> This is the patch for mentioning -fstrict-flex-arrays and -Warray-bounds=2 >

Re: [PATCH] loading float member of parameter stored via int registers

2022-12-21 Thread guojiufu via Gcc-patches
Hi, On 2022-12-21 15:30, Richard Biener wrote: On Wed, 21 Dec 2022, Jiufu Guo wrote: Hi, This patch is fixing an issue about parameter accessing if the parameter is struct type and passed through integer registers, and there is floating member is accessed. Like below code: typedef struct DF

Re: [PATCH] loading float member of parameter stored via int registers

2022-12-21 Thread Richard Biener via Gcc-patches
On Thu, 22 Dec 2022, guojiufu wrote: > Hi, > > On 2022-12-21 15:30, Richard Biener wrote: > > On Wed, 21 Dec 2022, Jiufu Guo wrote: > > > >> Hi, > >> > >> This patch is fixing an issue about parameter accessing if the > >> parameter is struct type and passed through integer registers, and > >>