Re: [PATCH] RISC-V: Note that __builtin_riscv_pause() implies Xgnuzihintpausestate

2022-12-17 Thread Andrew Waterman
It took me a few minutes to understand the purpose of this chicanery, but there's indeed a contradiction in the ISA spec. HINT instructions _do_ affect architectural state in a limited fashion--namely, updating the PC. So, it's incorrect to say that PAUSE changes no architectural state. Because th

Re: [PATCH] RISC-V: Note that __builtin_riscv_pause() implies Xgnuzihintpausestate

2022-12-17 Thread Andreas Schwab
On Dez 17 2022, Andrew Waterman wrote: > It took me a few minutes to understand the purpose of this chicanery, but > there's indeed a contradiction in the ISA spec. HINT instructions _do_ > affect architectural state in a limited fashion--namely, updating the PC. How can an insn _not_ affect the

Re: [PATCH] RISC-V: Note that __builtin_riscv_pause() implies Xgnuzihintpausestate

2022-12-17 Thread Andrew Waterman
On Sat, Dec 17, 2022 at 2:10 AM Andreas Schwab wrote: > > On Dez 17 2022, Andrew Waterman wrote: > > > It took me a few minutes to understand the purpose of this chicanery, but > > there's indeed a contradiction in the ISA spec. HINT instructions _do_ > > affect architectural state in a limited f

Re: [PATCH] RISC-V: Note that __builtin_riscv_pause() implies Xgnuzihintpausestate

2022-12-17 Thread Andreas Schwab
On Dez 17 2022, Andrew Waterman wrote: > On Sat, Dec 17, 2022 at 2:10 AM Andreas Schwab wrote: >> >> On Dez 17 2022, Andrew Waterman wrote: >> >> > It took me a few minutes to understand the purpose of this chicanery, but >> > there's indeed a contradiction in the ISA spec. HINT instructions _do

Re: [PATCH] RISC-V: Note that __builtin_riscv_pause() implies Xgnuzihintpausestate

2022-12-17 Thread Andrew Waterman
On Sat, Dec 17, 2022 at 2:21 AM Andreas Schwab wrote: > > On Dez 17 2022, Andrew Waterman wrote: > > > On Sat, Dec 17, 2022 at 2:10 AM Andreas Schwab > > wrote: > >> > >> On Dez 17 2022, Andrew Waterman wrote: > >> > >> > It took me a few minutes to understand the purpose of this chicanery, but

Re: [PATCH] contracts: Stop relying on mangling for naming .pre/.post clones

2022-12-17 Thread Arsen Arsenović via Gcc-patches
Jason Merrill writes: > > It's best to wrap the ChangeLog entry at column 75 so that the extra > indentation added by git log doesn't push past column 80. > > Applied with that change. > > Jason Heh, I thought I fixed my fill-column. Will check. Thanks! Have a great day. -- Arsen Arsenović

Re: [PATCH] contracts: Stop relying on mangling for naming .pre/.post clones

2022-12-17 Thread Arsen Arsenović via Gcc-patches
Iain Sandoe writes: > I think you want to use 'write_string (JOIN_STR “pre”);’ etc. since that > handles targets > that cannot use a period in symbol names. Ah - I think you're right. I'll have to delay checking/fixing for now. Thanks for the note. > If this is the right place, then I can up

Re: [PATCH v2] coroutines: Accept 'extern "C"' coroutines.

2022-12-17 Thread Iain Sandoe
Hi. It seems that everyone agrees that extern C coroutines should be permitted, although I have yet to see a useful testcase. This patch has been revised to append the suffices for such functions in mangle.cc rather than as part of the outlined function decl production. tested on x86_64-darwin21

[PATCH, m2]: PR-108122 Reduce sleep times in gm2/pimcoroutines/run/pass/testtime.mod

2022-12-17 Thread Gaius Mulley via Gcc-patches
PR-108122 Reduce sleep times in gm2/pimcoroutines/run/pass/testtime.mod Change time unit to 1 jiffy (with respect to TimerHandler.def) rather than a second. gcc/testsuite/ChangeLog: * gm2/pimcoroutines/run/pass/testtime.mod: Reduce sleep times in the test by a factor of 25. Te

[patch, fortran] PR107397 ICE in gfc_arith_plus, at fortran/arith.cc:654

2022-12-17 Thread Jerry D via Gcc-patches
Hi all, The attached patch fixes a regression and is a patch from Steve. I have regression tested it and provided a test case. It is fairly simple and I will commit under the "simple" rule in a little while. Thanks Steve for Patch. Thanks Harald for helping me get back up to speed on the g

Re: [PATCH RFA] gimplify: avoid unnecessary copy of init array [PR105838]

2022-12-17 Thread Jeff Law via Gcc-patches
On 12/8/22 15:01, Jason Merrill via Gcc-patches wrote: After the previous patches, I noticed that we were putting the array of strings into .rodata, but then memcpying it into an automatic array, which is pointless; we should be able to use it directly. C++ doesn't allow us to do this for the

[PATCH] rs6000: Add Rust support to traceback table

2022-12-17 Thread Segher Boessenkool
Use 0 for the "lang" identifier for Rust, just like we do for all other source languages without assigned language code (0 means "C"). Tested on powerpc64-linux. Without this patch there are ICEs galore in the gm2 testsuite for 64-bit Linux targets, and with the ptch there are just a few FAILs.

[PATCH] Fortran: incorrect array bounds when bound intrinsic used in decl [PR108131]

2022-12-17 Thread Harald Anlauf via Gcc-patches
Dear all, the previous fix for pr103505 introduced a regression that could lead to wrong array bounds when LBOUND/UBOUND were used in the array spec of a declaration. The reason was that we tried to simplify too early the array element spec, which appears to have interfered with the subtle semant

[r13-4716 Regression] FAIL: libgomp.fortran/allocate-4.f90 -O (test for excess errors) on Linux/x86_64

2022-12-17 Thread haochen.jiang via Gcc-patches
On Linux/x86_64, e205ec03f0794aeac3e8a89e947c12624d5a274e is the first bad commit commit e205ec03f0794aeac3e8a89e947c12624d5a274e Author: Tobias Burnus Date: Thu Dec 15 12:25:07 2022 +0100 libgfortran's ISO_Fortran_binding.c: Use GCC11 version for backward-only code [PR108056] caused FA

[r13-4727 Regression] FAIL: gcc.target/i386/pr64110.c scan-assembler vmovd[\\t ] on Linux/x86_64

2022-12-17 Thread haochen.jiang via Gcc-patches
On Linux/x86_64, 12abd5a7d13209f79664ea603b3f3517f71b8c4f is the first bad commit commit 12abd5a7d13209f79664ea603b3f3517f71b8c4f Author: Vladimir N. Makarov Date: Thu Dec 15 14:11:05 2022 -0500 IRA: Check that reg classes contain a hard reg of given mode in reg move cost calculation cau

[r13-4749 Regression] FAIL: gcc.dg/ira-loop-pressure.c scan-rtl-dump loop2_invariant "Decided to move invariant" on Linux/x86_64

2022-12-17 Thread haochen.jiang via Gcc-patches
On Linux/x86_64, b50fe16a3b2214c418ecc5febc0bb21bc17912b7 is the first bad commit commit b50fe16a3b2214c418ecc5febc0bb21bc17912b7 Author: Vladimir N. Makarov Date: Fri Dec 16 13:16:31 2022 -0500 Revert "IRA: Check that reg classes contain a hard reg of given mode in reg move cost calculat