Re: [PATCH] consider parameter names in -Wvla-parameter (PR 97548)

2021-07-08 Thread Jeff Law via Gcc-patches
On 7/1/2021 7:02 PM, Martin Sebor via Gcc-patches wrote: -Wvla-parameter relies on operand_equal_p() with OEP_LEXICOGRAPHIC set to compare VLA bounds for equality.  But operand_equal_p() doesn't consider decl names, and so nontrivial expressions that refer to the same function parameter are co

Re: [PATCH] Fix PR testsuite/101269

2021-07-08 Thread Jeff Law via Gcc-patches
On 6/30/2021 2:33 PM, Indu Bhagat via Gcc-patches wrote: PR testsuite/101269 - new test case gcc.dg/debug/btf/btf-datasec-1.c fails with its introduction in r12-1852 BTF datasec records for .rodata/.data are expected for now for all targets. For powerpc based targets, use -msdata=none when il

Re: [PATCH] testsuite: mips: use noinline attribute instead of -fno-inline

2021-07-08 Thread Jeff Law via Gcc-patches
On 6/25/2021 8:40 AM, Richard Sandiford wrote: Xi Ruoyao via Gcc-patches writes: On Fri, 2021-06-25 at 01:02 +0800, Xi Ruoyao wrote: On Thu, 2021-06-24 at 10:48 -0600, Jeff Law wrote: I'd like to know a bit more here.  mips.exp shouldn't care about the options passed to the compiler and to

Re: rs6000: Generate an lxvp instead of two adjacent lxv instructions

2021-07-08 Thread Peter Bergner via Gcc-patches
On 7/8/21 6:28 PM, Segher Boessenkool wrote: > It needs testing on BE. Will do. >> +static bool consecutive_mem_locations (rtx, rtx); > > Please don't; just move functions to somewhere earlier than where they > are used. Will do. >> @@ -16841,8 +16843,35 @@ rs6000_split_multireg_move (rtx

Re: [PATCH 0/2] RISC-V: Add ldr/str instruction for T-HEAD.

2021-07-08 Thread ALO via Gcc-patches
Hi, Ping. — Jojo 在 2021年6月29日 +0800 PM4:11,Jojo R ,写道: > T-HEAD extends some customized ISAs for Cores. > The patches support ldr/str insns, it likes arm's LDR insn, the > memory model is a base register indexed by (optionally scaled) register.

[PATCH] Check type size for doloop iv on BITS_PER_WORD [PR61837]

2021-07-08 Thread Jiufu Guo via Gcc-patches
Currently, doloop.xx variable is using the type as niter which may shorter than word size. For some cases, it may be better to use word size type. For example, on some 64bit system, to access 32bit niter, subreg maybe used. Then using 64bit type would not need to use subreg if the value can be pre

Re: [RFA] Attach MEM_EXPR information when flushing BLKmode args to the stack - V2

2021-07-08 Thread Jeff Law
On 7/2/2021 10:13 AM, Jeff Law wrote: This is a minor missed optimization we found with our internal port. Given this code: typedef struct {short a; short b;} T; extern void g1(); void f(T s) {     if (s.a < 0)     g1(); } "s" is passed in a register, but it's still a BLK

[PATCH 0/2] Misc PHIOPT patches

2021-07-08 Thread apinski--- via Gcc-patches
From: Andrew Pinski Just two misc improvements to simplify and match of phiopt. I decided to submit this two before I finish up the min/max movement to match.pd as that will take some time. Both showed up while looking into the movement of min/max though. Andrew Pinski (2): Improve early simpl

[PATCH 2/2] [PHIOPT/MATCH] Remove the statement to move if not used

2021-07-08 Thread apinski--- via Gcc-patches
From: Andrew Pinski Instead of waiting for DCE to remove the unused statement, and maybe optimize another conditional, it is better if we don't move the statement and have the statement removed. gcc/ChangeLog: * tree-ssa-phiopt.c (used_in_seq): New function. (match_simplify_repl

[PATCH 1/2] Improve early simplify and match for phiopt

2021-07-08 Thread apinski--- via Gcc-patches
From: Andrew Pinski Previously the idea was gimple_simplify_phiopt would call resimplify with a NULL sequence but that sometimes fails even if there was only one statement produced. The cases where it fails is when there are two simplifications happen. In the case of the min/max production, the f

Re: PING: [PATCH] mips: check MSA support for vector modes [PR100760,PR100761,PR100762]

2021-07-08 Thread Xi Ruoyao via Gcc-patches
On Thu, 2021-07-08 at 17:20 -0600, Jeff Law wrote: > > On 7/5/2021 8:04 PM, Paul Hua wrote: > > Looks good to me,  but I have no right to approve. > But your opinions are well respected :-) > > I'll go ahead and ACK, though in general I'm stepping away from > reviewing target specific work. Tha

Re: disable -Warray-bounds in libgo (PR 101374)

2021-07-08 Thread Richard Biener via Gcc-patches
On Thu, Jul 8, 2021 at 8:02 PM Martin Sebor via Gcc-patches wrote: > > Hi Ian, > > Yesterday's enhancement to -Warray-bounds has exposed a couple of > issues in libgo where the code writes into an invalid constant > address that the warning is designed to flag. > > On the assumption that those inv

Re: [committed] move warning suppression closer to invalid access (PR101372)

2021-07-08 Thread Richard Biener via Gcc-patches
On Fri, Jul 9, 2021 at 12:57 AM Martin Sebor via Gcc-patches wrote: > > To unblock bootstrap this morning that was failing due to stricter > array bounds checking, I suppressed two -Warray-bounds instances > in cp/modules.cc without analyzing them, tracking the to-do in > pr101372. Now that I und

Re: [PATCH] testsuite: mips: use noinline attribute instead of -fno-inline

2021-07-08 Thread Xi Ruoyao via Gcc-patches
On Thu, 2021-07-08 at 17:44 -0600, Jeff Law wrote: > > > On 6/25/2021 8:40 AM, Richard Sandiford wrote: > > Xi Ruoyao via Gcc-patches writes: > > > On Fri, 2021-06-25 at 01:02 +0800, Xi Ruoyao wrote: > > > > On Thu, 2021-06-24 at 10:48 -0600, Jeff Law wrote: > > > > > I'd like to know a bit more

Re: [PATCH] Check type size for doloop iv on BITS_PER_WORD [PR61837]

2021-07-08 Thread Richard Biener
On Fri, 9 Jul 2021, Jiufu Guo wrote: > Currently, doloop.xx variable is using the type as niter which may shorter > than word size. For some cases, it may be better to use word size type. > For example, on some 64bit system, to access 32bit niter, subreg maybe used. > Then using 64bit type would

Re: [RFA] Attach MEM_EXPR information when flushing BLKmode args to the stack - V2

2021-07-08 Thread Richard Biener via Gcc-patches
On Fri, Jul 9, 2021 at 4:39 AM Jeff Law wrote: > > > > On 7/2/2021 10:13 AM, Jeff Law wrote: > > > > This is a minor missed optimization we found with our internal port. > > > > Given this code: > > > > typedef struct {short a; short b;} T; > > > > extern void g1(); > > > > void f(T s) > > { > >

Re: PING: [PATCH] mips: check MSA support for vector modes [PR100760,PR100761,PR100762]

2021-07-08 Thread Xi Ruoyao via Gcc-patches
On Fri, 2021-07-09 at 14:01 +0800, Xi Ruoyao wrote: > On Thu, 2021-07-08 at 17:20 -0600, Jeff Law wrote: > > > > On 7/5/2021 8:04 PM, Paul Hua wrote: > > > Looks good to me,  but I have no right to approve. > > But your opinions are well respected :-) > > > > I'll go ahead and ACK, though in gene

Re: [PATCH 2/2] [PHIOPT/MATCH] Remove the statement to move if not used

2021-07-08 Thread Richard Biener via Gcc-patches
On Fri, Jul 9, 2021 at 7:34 AM apinski--- via Gcc-patches wrote: > > From: Andrew Pinski > > Instead of waiting for DCE to remove the unused statement, > and maybe optimize another conditional, it is better if > we don't move the statement and have the statement > removed. > > gcc/ChangeLog: > >

PING^2: [PATCH] mips: add MSA vec_cmp and vec_cmpu expand pattern [PR101132]

2021-07-08 Thread Xi Ruoyao via Gcc-patches
PING again. On Thu, 2021-07-01 at 16:11 +0800, Xi Ruoyao wrote: > Ping. > > On Mon, 2021-06-21 at 21:42 +0800, Xi Ruoyao wrote: > > Middle-end started to emit vec_cmp and vec_cmpu since GCC 11, > > causing > > ICE on MIPS with MSA enabled.  Add the pattern to prevent it. > > > > Bootstrapped and

PING^2: [PATCH] mips: Fix up mips_atomic_assign_expand_fenv [PR94780]

2021-07-08 Thread Xi Ruoyao via Gcc-patches
Ping again. On Mon, 2021-06-28 at 21:50 +0800, Xi Ruoyao wrote: > Ping.  CC several maintainers who may help to review MIPS patches. > Sorry if it sounds buzzing. > > On Wed, 2021-06-23 at 11:11 +0800, Xi Ruoyao wrote: > > Commit message shamelessly copied from 1777beb6b129 by jakub: > > > > Th

Re: [PATCH 1/2] Improve early simplify and match for phiopt

2021-07-08 Thread Richard Biener via Gcc-patches
On Fri, Jul 9, 2021 at 7:35 AM apinski--- via Gcc-patches wrote: > > From: Andrew Pinski > > Previously the idea was gimple_simplify_phiopt would call > resimplify with a NULL sequence but that sometimes fails > even if there was only one statement produced. The cases > where it fails is when the

<    1   2