Re: [PATCH] tree-sra: Avoid refreshing into const base decls (PR 100453)

2021-05-17 Thread Martin Jambor
Hi Eric, sorry for breaking Ada over the weekend, however... On Fri, May 14 2021, Eric Botcazou wrote: >> Looks like this caused: >> >> === acats tests === >> FAIL: c41325a None of the non-ACATS tests fail for me without doing a bootstrap, but I did manage to reproduce this on

[PATCH v2] x86: Warn for excessive argument alignment in main

2021-05-17 Thread H.J. Lu via Gcc-patches
On Thu, May 13, 2021 at 9:15 AM Bernd Edlinger wrote: > > On 5/13/21 3:37 PM, H.J. Lu via Gcc-patches wrote: > > Warn for excessive argument alignment in main instead of ICE. > > > > gcc/ > > > > PR c/100575 > > * cfgexpand.c (expand_stack_alignment): Add a bool argument for > >

Re: [PATCH] gcc-changelog: Remove non-strict mode.

2021-05-17 Thread Jonathan Wakely via Gcc-patches
On 11/05/21 10:56 +0200, Martin Liška wrote: Hello. I'm going to push a commit that removes non-strict mode. It's useless right now. Martin contrib/ChangeLog: * gcc-changelog/git_check_commit.py: Remove --non-strict-mode. * gcc-changelog/git_commit.py: Remove strict mode.

Re: [PATCH RFA] tree-iterator: C++11 range-for and tree_stmt_iterator

2021-05-17 Thread Jason Merrill via Gcc-patches
On 5/17/21 3:56 AM, Richard Biener wrote: On Fri, May 14, 2021 at 2:23 AM Martin Sebor via Gcc-patches wrote: On 5/13/21 1:26 PM, Jason Merrill via Gcc-patches wrote: Ping. On 5/1/21 12:29 PM, Jason Merrill wrote: Like my recent patch to add ovl_range and lkp_range in the C++ front end, thi

Re: [PATCH] c++: Fix diagnostic for binding lvalue reference to volatile rvalue [PR 100635]

2021-05-17 Thread Jason Merrill via Gcc-patches
On 5/17/21 7:15 AM, Jonathan Wakely wrote: The current diagnostic assumes the reference binding fails because the reference is non-const, but it can also fail if the rvalue is volatile. Use the current diagnostic for non-const cases, and a modified diagnostic otherwise. gcc/cp/ChangeLog:

Re: [PATCH 1/1 v2] PR100281 C++: Fix SImode pointer handling

2021-05-17 Thread Jason Merrill via Gcc-patches
On 5/17/21 4:48 AM, Richard Biener wrote: On Thu, May 13, 2021 at 8:28 AM Andreas Krebbel via Gcc-patches wrote: v1 -> v2: build_reference_type_for_mode and build_pointer_type_for_mode now pick pointer mode if MODE argument is VOIDmode. Bootstrapped and regression tested on x86_64 and s390x.

[r12-837 Regression] FAIL: gcc.target/i386/pr100582.c scan-assembler-times pblendvb 1 on Linux/x86_64

2021-05-17 Thread sunil.k.pandey via Gcc-patches
On Linux/x86_64, e0a5daf81f2c79a0275eccd7c1a25349990a7a4d is the first bad commit commit e0a5daf81f2c79a0275eccd7c1a25349990a7a4d Author: Richard Biener Date: Mon May 17 13:56:14 2021 +0200 middle-end/100582 - fix array_at_struct_end_p for vector indexing caused FAIL: gcc.target/i386/pr1

Re: [PATCH][nvptx] Handle memmodel for atomic ops

2021-05-17 Thread Tobias Burnus
Hi Tom, short version works :-) now (and I don't know why it didn't). Long version: On 17.05.21 18:58, Tom de Vries wrote: I have: ... @ %r25 atom.global.exch.b32 %r22,[atomic_lock],1; @ %r25 membar.sys; ... I tried with the PowerPC cross build - running on PowerPC + Quadro GV100 did work for

Re: [PATCH] tree-sra: Avoid refreshing into const base decls (PR 100453)

2021-05-17 Thread Eric Botcazou
> sorry for breaking Ada over the weekend, however... No problem. > None of the non-ACATS tests fail for me without doing a bootstrap, but I > did manage to reproduce this one (by the way, there really should be a > documentation on how to run ACATS tests manually, I should not need to > spend an

Re: [PATCH][DOCS] Remove install-old.texi

2021-05-17 Thread Richard Sandiford via Gcc-patches
Martin Liška writes: > Hello. > > As mentioned at the beginning of https://gcc.gnu.org/install/old.html: > "Note most of this information is out of date and superseded by the previous > chapters of this manual." > > The installation page is deprecated for 20 years now. > > Does it make sense to r

Re: [PATCH] libstdc++: Fix iterator caching inside range adaptors [PR100479]

2021-05-17 Thread Tim Song via Gcc-patches
On Mon, May 17, 2021 at 11:46 AM Patrick Palka via Libstdc++ wrote: > constexpr void > _M_set(const _Range&, const iterator_t<_Range>& __it) > { > __glibcxx_assert(!_M_has_value()); > - _M_iter = __it; > + this->_M_payload._M_payload._M_value = __i

Re: [PATCH v3] bpf.2: Use standard types and attributes

2021-05-17 Thread Daniel Borkmann
On 5/16/21 11:16 AM, Alejandro Colomar (man-pages) wrote: On 5/15/21 9:01 PM, Alejandro Colomar wrote: Some manual pages are already using C99 syntax for integral types 'uint32_t', but some aren't.  There are some using kernel syntax '__u32'.  Fix those. Both the kernel and the standard types a

Re: [PATCH] aix: handle 64bit inodes for include directories

2021-05-17 Thread David Edelsohn via Gcc-patches
The aix.h change is okay with me, but you need to get approval for the incpath.c and cpplib.h parts of the patch from the appropriate maintainers. Thanks, David On Mon, May 17, 2021 at 7:44 AM CHIGOT, CLEMENT wrote: > > On AIX, stat will store inodes in 32bit even when using LARGE_FILES. > If th

Re: [PATCH] libstdc++: Fix wrong thread waking on notify [PR100334]

2021-05-17 Thread Thomas Rodgers
On 2021-05-17 09:43, Jonathan Wakely wrote: On 14/05/21 18:09 +0100, Jonathan Wakely wrote: On 13/05/21 18:54 -0700, Thomas Rodgers wrote: From: Thomas Rodgers Please ignore the previous patch. This one removes the need to carry any extra state in the case of a 'laundered' atomic wait. li

Re: [PATCH] Hashtable PR96088

2021-05-17 Thread François Dumont via Gcc-patches
Hi     No chance yet to review this proposal ? François On 06/05/21 10:03 pm, François Dumont wrote: Hi     Considering your feedback on backtrace in debug mode is going to take me some time so here is another one.     Compared to latest submission I've added a _Hash_arg_t partial special

Re: [PATCH] libstdc++: Fix iterator caching inside range adaptors [PR100479]

2021-05-17 Thread Patrick Palka via Gcc-patches
On Mon, 17 May 2021, Tim Song wrote: > On Mon, May 17, 2021 at 11:46 AM Patrick Palka via Libstdc++ > wrote: > > constexpr void > > _M_set(const _Range&, const iterator_t<_Range>& __it) > > { > > __glibcxx_assert(!_M_has_value()); > > - _M_iter = __it; >

Re: [committed] arm: correctly handle inequality comparisons against max constants [PR100563]

2021-05-17 Thread Hans-Peter Nilsson
On Thu, 13 May 2021, Richard Earnshaw via Gcc-patches wrote: > > Normally we expect the gimple optimizers to fold away comparisons that > are always true, but at some lower optimization levels this is not > always the case, so the back-end has to be able to generate correct > code in these cases. >

Re: [PATCH] Add a couple of A?CST1:CST2 match and simplify optimizations

2021-05-17 Thread Andrew Pinski via Gcc-patches
ev-gcc/ > -B/home/ed/gnu/install/x86_64-pc-linux-gnu/bin/ > -B/home/ed/gnu/install/x86_64-pc-linux-gnu/bin/ > -B/home/ed/gnu/install/x86_64-pc-linux-gnu/lib/ -isystem > /home/ed/gnu/install/x86_64-pc-linux-gnu/include -isystem > /home/ed/gnu/install/x86_64-pc-linu

[COMMITTED] MAINTAINERS: Add myself for write after approval

2021-05-17 Thread Serge Belyshev via Gcc-patches
2021-05-17 Serge Belyshev * MAINTAINERS (Write After Approval): Add myself. --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5b10f212ce8..fbaa183cea4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -317,6 +317,7 @@ Gergö Barany

Re: [PATCH] PING implement pre-c++20 contracts

2021-05-17 Thread Jason Merrill via Gcc-patches
On 5/14/21 4:54 PM, Jason Merrill wrote: On 4/30/21 1:44 PM, Jeff Chapman wrote: Hello! Looping back around to this. re: https://gcc.gnu.org/pipermail/gcc-patches/2021-March/567334.html On 3/25/21, Jason Merrill wrote: On 3/1/21 8:12 AM, Jeff Chapman wrote: On 1/18/21, Jason Merrill wrote:

[PATCH] PR tree-optimization/100512: Once a range becomes constant, make it invariant.

2021-05-17 Thread Andrew MacLeod via Gcc-patches
The code in PR 100512 triggers an interaction between ranger and the propagation engine related to undefined values. I put the detailed analysis in the PR, but it boils down to the early VRP pass has concluded that something is a constant and can be replaced, and removes the definition expecti

Re: [PATCH] libstdc++: Fix access issues in elements_view::_Sentinel [PR100631]

2021-05-17 Thread Tim Song via Gcc-patches
On Mon, May 17, 2021 at 12:21 PM Patrick Palka via Gcc-patches wrote: > > using _Base = elements_view::_Base<_Const>; > sentinel_t<_Base> _M_end = sentinel_t<_Base>(); > @@ -3800,7 +3807,7 @@ namespace views::__adaptor > requires sized_sentinel_for, iterator_t<_Base

Re: [PATCH] libstdc++: Fix iterator caching inside range adaptors [PR100479]

2021-05-17 Thread Tim Song via Gcc-patches
On Mon, May 17, 2021 at 2:59 PM Patrick Palka wrote: > > + constexpr _CachedPosition& > + operator=(_CachedPosition&& __other) noexcept > + { > + if (std::__addressof(__other) != this) I don't think we need this check - self-move-assigning the underlying view isn't requi

Re: [PATCH][DOCS] Remove install-old.texi

2021-05-17 Thread Joseph Myers
On Mon, 17 May 2021, Martin Liška wrote: > -@enumerate > -@item > -If you have chosen a configuration for GCC which requires other GNU > -tools (such as GAS or the GNU linker) instead of the standard system > -tools, install the required tools in the build directory under the names > -@file{as}, @

Re: [PATCH][v2] c/100547 - reject overly large vector_size attributes

2021-05-17 Thread Joseph Myers
On Mon, 17 May 2021, Richard Biener wrote: > This rejects a number of vector components that does not fit an 'int' > which is an internal limitation of RTVEC. This requires adjusting > gcc.dg/attr-vector_size.c which checks for much larger > supported vectors. Note that the RTVEC limitation is a

[PATCH] libgccjit: Add support for types used by atomic builtins [PR96066] [PR96067]

2021-05-17 Thread Antoni Boucher via Gcc-patches
Hello. This patch fixes the issue with using atomic builtins in libgccjit. Thanks to review it. From 0ce53d373ffba9f3f80a2d2b4e1a7d724ba31b7d Mon Sep 17 00:00:00 2001 From: Antoni Boucher Date: Sun, 9 May 2021 20:14:37 -0400 Subject: [PATCH] Add support for types used by atomic builtins [PR96066]

Re: [PATCH] go/100537 - Bootstrap-O3 and bootstrap-debug fail

2021-05-17 Thread guojiufu via Gcc-patches
On 2021-05-17 16:17, Richard Biener wrote: On Fri, May 14, 2021 at 11:19 AM guojiufu via Gcc-patches wrote: On 2021-05-14 15:39, guojiufu via Gcc-patches wrote: > On 2021-05-14 15:15, Richard Biener wrote: >> On May 14, 2021 4:52:56 AM GMT+02:00, Jiufu Guo >> wrote: >>> As discussed in the PR

Re: [PATCH] go/100537 - Bootstrap-O3 and bootstrap-debug fail

2021-05-17 Thread Ian Lance Taylor via Gcc-patches
On Mon, May 17, 2021 at 1:17 AM Richard Biener via Gcc-patches wrote: > > On Fri, May 14, 2021 at 11:19 AM guojiufu via Gcc-patches > wrote: > > > > On 2021-05-14 15:39, guojiufu via Gcc-patches wrote: > > > On 2021-05-14 15:15, Richard Biener wrote: > > >> On May 14, 2021 4:52:56 AM GMT+02:00, J

Re: [PATCH] Add a couple of A?CST1:CST2 match and simplify optimizations

2021-05-17 Thread Andrew Pinski via Gcc-patches
> > ../../gcc-trunk-1/gcc/ada/libgnat/a-charac.ads -o ada/libgnat/a-charac.o > > /home/ed/gnu/gcc-build-2/./prev-gcc/xgcc > > -B/home/ed/gnu/gcc-build-2/./prev-gcc/ > > -B/home/ed/gnu/install/x86_64-pc-linux-gnu/bin/ > > -B/home/ed/gnu/install/x86_64-pc-linux-gnu/bin/ &

Re: [PATCH] libstdc++: Fix access issues in elements_view::_Sentinel [PR100631]

2021-05-17 Thread Patrick Palka via Gcc-patches
On Mon, 17 May 2021, Tim Song wrote: > On Mon, May 17, 2021 at 12:21 PM Patrick Palka via Gcc-patches > wrote: > > > > using _Base = elements_view::_Base<_Const>; > > sentinel_t<_Base> _M_end = sentinel_t<_Base>(); > > @@ -3800,7 +3807,7 @@ namespace views::__adaptor > >

Re: [PATCH] libstdc++: Fix iterator caching inside range adaptors [PR100479]

2021-05-17 Thread Patrick Palka via Gcc-patches
On Mon, 17 May 2021, Tim Song wrote: > On Mon, May 17, 2021 at 2:59 PM Patrick Palka wrote: > > > > + constexpr _CachedPosition& > > + operator=(_CachedPosition&& __other) noexcept > > + { > > + if (std::__addressof(__other) != this) > > I don't think we need this check

Re: [PATCH] Run pass_sink_code once more before store_mergin

2021-05-17 Thread Xionghu Luo via Gcc-patches
Hi, On 2021/5/17 16:11, Richard Biener wrote: On Fri, 14 May 2021, Xionghu Luo wrote: Hi Richi, On 2021/4/21 19:54, Richard Biener wrote: On Tue, 20 Apr 2021, Xionghu Luo wrote: On 2021/4/15 19:34, Richard Biener wrote: On Thu, 15 Apr 2021, Xionghu Luo wrote: Thanks, On 2021/4/14 14:

[PATCH] RISC-V: Properly parse the letter 'p' in '-march'.

2021-05-17 Thread Geng Qi via Gcc-patches
gcc/ChangeLog: * common/config/riscv/riscv-common.c (riscv_subset_list::parsing_subset_version): Properly parse the letter 'p' in '-march'. (riscv_subset_list::parse_std_ext, riscv_subset_list::parse_multiletter_ext): To handle errors generated in ri

[Bootstrap] *PING* Re: [Patch] gcc/configure.ac: Fix cross build by using $(CFLAGS-$@) [PR100598]

2021-05-17 Thread Tobias Burnus
Early *PING* for this bootstrap issue; in the PR, it affected a Linux to mingw64 cross build. Here, it affects x86-64 → PowerPC Linux builds, which builds with the patch applied. On 14.05.21 16:19, Tobias Burnus wrote: Fixes the build fail: ../../gcc/genversion.c:37:20: error: ‘BASEVER’ was not

Re: [PATCH V2] Split loop for NE condition.

2021-05-17 Thread Bernd Edlinger
On 5/17/21 4:01 AM, Jiufu Guo via Gcc-patches wrote: > When there is the possibility that overflow/wrap may happen on the loop index, > a few optimizations would not happen. For example code: > > foo (int *a, int *b, unsigned k, unsigned n) > { > while (++k != n) > a[k] = b[k] + 1; > } > >

[Committed] IBM Z: Support vector _Bool language extension

2021-05-17 Thread Andreas Krebbel via Gcc-patches
_Bool needs to be defined as macro in order to trigger the context-sensitive macro expansion mechanism. Bootstrapped and regtested on s390x. Committed to mainline. gcc/ChangeLog: * config/s390/s390-c.c (s390_cpu_cpp_builtins_internal): Define _Bool as macro expanding to _Bool.

Re: [PATCH] go/100537 - Bootstrap-O3 and bootstrap-debug fail

2021-05-17 Thread Richard Biener
On Mon, 17 May 2021, Ian Lance Taylor wrote: > On Mon, May 17, 2021 at 1:17 AM Richard Biener via Gcc-patches > wrote: > > > > On Fri, May 14, 2021 at 11:19 AM guojiufu via Gcc-patches > > wrote: > > > > > > On 2021-05-14 15:39, guojiufu via Gcc-patches wrote: > > > > On 2021-05-14 15:15, Richar

<    1   2