Re: The performance data for two different implementation of new security feature -ftrivial-auto-var-init

2021-01-14 Thread Qing Zhao via Gcc-patches
Hi, More data on code size and compilation time with CPU2017: Compilation time data: the numbers are the slowdown against the default “no”: benchmarks A/no D/no 500.perlbench_r 5.19% 1.95% 502.gcc_r 0.46% -0.23% 505.mcf_r

[PATCH, rs6000] Update pr88233.c test (pr91799)

2021-01-14 Thread will schmidt via Gcc-patches
[PATCH, rs6000] Update pr88233.c test (pr91799) Hi, This is a follow-up fix to clean up pr91799. Per review of test results, it appears that the combination of target and dg-require stanzas is not sufficient to properly limit the test to 64-bit only on darwin. This adds additional clauses to li

Re: [PATCH/RFC] Add GCC_EXTRA_DIAGNOSTIC_OUTPUT environment variable for fix-it hints

2021-01-14 Thread David Malcolm via Gcc-patches
On Sat, 2020-11-14 at 14:43 -0500, David Malcolm wrote: > GCC has had the ability to emit fix-it hints in machine-readable form > since GCC 7 via -fdiagnostics-parseable-fixits and > -fdiagnostics-generate-patch. > > The former emits additional specially-formatted lines to stderr; the > option and

[PATCH 0/2] PowerPC: Add __ibm128 to PowerPC targets without float128 support

2021-01-14 Thread Michael Meissner via Gcc-patches
In the patch submitted on October 22nd, 2020: https://gcc.gnu.org/pipermail/gcc-patches/2020-October/556869.html https://gcc.gnu.org/pipermail/gcc-patches/2020-October/557529.html Segher suggested that rather than add #ifdef code in libgcc's ibm-ldouble.c to use __builtin_pack_ibm128 instead of __

[PATCH 1/2] PowerPC: Allow __ibm128 on older systems.

2021-01-14 Thread Michael Meissner via Gcc-patches
[PATCH 1/2] PowerPC: Allow __ibm128 on older systems. In the patch submitted on October 22nd, 2020: https://gcc.gnu.org/pipermail/gcc-patches/2020-October/556869.html https://gcc.gnu.org/pipermail/gcc-patches/2020-October/557529.html Segher suggested that rather than add #ifdef code in libgcc's i

[PATCH 2/2] PowerPC: Use __builtin_pack_ibm128 instead of __builtin_pack_longdouble.

2021-01-14 Thread Michael Meissner via Gcc-patches
[PATCH 2/2] PowerPC: Use __builtin_pack_ibm128 instead of __builtin_pack_longdouble. In the patch submitted on October 22nd, 2020: https://gcc.gnu.org/pipermail/gcc-patches/2020-October/556869.html https://gcc.gnu.org/pipermail/gcc-patches/2020-October/557529.html Segher suggested that rather th

Re: [PATCH/RFC] Add GCC_EXTRA_DIAGNOSTIC_OUTPUT environment variable for fix-it hints

2021-01-14 Thread Lewis Hyatt via Gcc-patches
On Thu, Jan 14, 2021 at 4:34 PM David Malcolm via Gcc-patches wrote: ... > > One remaining issue raised in that Emacs bug is the encoding of these > > lines, and, indeed, the encoding of GCC's stderr in general: > > currently we emit a mixture of bytes and UTF-8; I believe we emit > > filenames as

Re: [PATCH] Handle fancy_abort before diagnostic initialization [PR98586]

2021-01-14 Thread David Malcolm via Gcc-patches
On Tue, 2021-01-12 at 08:44 +0100, Richard Biener wrote: > On Mon, Jan 11, 2021 at 10:57 PM David Malcolm via Gcc-patches > wrote: > > If fancy_abort is called before the diagnostic subsystem is > > initialized, > > internal_error will crash internally in a way that prevents a > > useful > > messa

Re: Add dg-require-wchars to libstdc++ testsuite

2021-01-14 Thread Alexandre Oliva
On Jan 14, 2021, Jonathan Wakely wrote: > The problem is that uses wchar_t in default > template arguments: > I think we should fix the header, not disable tests that don't use > that default template argument. The attached patch should allow you to > use wstring_convert and wbuffer_convert wit

Re: [PATCH 3/3] Build x86 libatomic with -march=i486 or better

2021-01-14 Thread Jakub Jelinek via Gcc-patches
On Thu, Jan 14, 2021 at 01:04:31PM -0800, H.J. Lu via Gcc-patches wrote: > If x86 libatomic isn't compiled with -march=i486 or better, append > -march=i486 XCFLAGS for x86 libatomic build. Set try_ifunc to yes > if -mcx16 isn't used to compile x86-64 libatomic or -march=i686 or > better isn't used

[committed] jit: remove "Alpha" warning from docs

2021-01-14 Thread David Malcolm via Gcc-patches
On Thu, 2021-01-14 at 23:23 +0100, Andrea Corallo wrote: > Hi Dave and all, > > libgccjit is still advertized as alpha state in the documentation > despite having being introduced few years ago. > > I think we may want to evaluate to promote it as beta with the > following > motivations: > > - T

Re: [committed] jit: remove "Alpha" warning from docs

2021-01-14 Thread Andrea Corallo via Gcc-patches
David Malcolm writes: > On Thu, 2021-01-14 at 23:23 +0100, Andrea Corallo wrote: >> Hi Dave and all, >> >> libgccjit is still advertized as alpha state in the documentation >> despite having being introduced few years ago. >> >> I think we may want to evaluate to promote it as beta with the >>

V2 [PATCH 3/3] Build x86 libatomic with -march=i486 or better

2021-01-14 Thread H.J. Lu via Gcc-patches
On Thu, Jan 14, 2021 at 3:01 PM Jakub Jelinek wrote: > > On Thu, Jan 14, 2021 at 01:04:31PM -0800, H.J. Lu via Gcc-patches wrote: > > If x86 libatomic isn't compiled with -march=i486 or better, append > > -march=i486 XCFLAGS for x86 libatomic build. Set try_ifunc to yes > > if -mcx16 isn't used t

Re: [PATCH/RFC] combine: Tweak the condition of last_set invalidation

2021-01-14 Thread Segher Boessenkool
Hi! On Wed, Dec 16, 2020 at 04:49:49PM +0800, Kewen.Lin wrote: > When I was investigating unsigned int vec_init issue on Power, > I happened to find there seems something we can enhance in how > combine pass invalidate last_set (set last_set_invalid nonzero). > > Currently we have the check: > >

Re: [PATCH] rs6000: Use rldimi for vec init instead of shift + ior

2021-01-14 Thread Segher Boessenkool
Hi! On Tue, Dec 22, 2020 at 04:08:26PM +0800, Kewen.Lin wrote: > This patch is to make unsigned int vector init go with > rldimi to merge two integers instead of shift and ior. > > I tried to use nonzero_bits in md file to make it more > general, but the testing shows it isn't doable. The > reas

[PATCH v2] libstdc++: C++23, implement WG21 P1679R3

2021-01-14 Thread Paul Fee via Gcc-patches
Add contains member function to basic_string_view and basic_string. The new method is enabled for -std=gnu++20, gnu++2b and c++2b. This allows users to access the method as a GNU extension to C++20. The conditional test may be reduced to "__cplusplus > 202011L" once GCC has a c++2b switch. Chan

Re: [PATCH] libstdc++: c++2b, implement WG21 P1679R3

2021-01-14 Thread Paul Fee via Gcc-patches
On Thu, Jan 14, 2021 at 5:06 PM Jonathan Wakely wrote: > > On 13/01/21 01:21 +, Paul Fee via Libstdc++ wrote: > >Add contains member function to basic_string_view and basic_string. > > > >The new method is enabled for -std=gnu++20, gnu++2b and c++2b. This allows > >users to access the method

Go patch committed: Add support for reading embedcfg files

2021-01-14 Thread Ian Lance Taylor via Gcc-patches
This patch to the Go frontend adds support for reading embedcfg files. An embedcfg file is a JSON file created by the go command when it sees a go:embed directive, and passed to the Go frontend via the new -fgo-embedcfg option. This code is not yet called, and does not yet do anything. It's being

Re: Ping ^ 4: [PATCH 3/4] rs6000: Enable vec_insert for P8 with rs6000_expand_vector_set_var_p8

2021-01-14 Thread Xionghu Luo via Gcc-patches
Ping^4, thanks. On 2020/12/23 10:18, Xionghu Luo via Gcc-patches wrote: Ping^3 for stage 3. And this followed patch: [PATCH 4/4] rs6000: Update testcases' instruction count. Thanks:) On 2020/12/3 22:16, Xionghu Luo via Gcc-patches wrote: Ping. Thanks. On 2020/11/27 09:04, Xionghu Luo via

[PATCH 0/3] PowerPC: Fix up tests for IEEE 128-bit long double

2021-01-14 Thread Michael Meissner via Gcc-patches
In November, I submitted a patch to fix up some of the tests for when IEEE 128-bit is used as the long double format. Segher had some suggestions. These patches are based on those suggestions: https://gcc.gnu.org/pipermail/gcc-patches/2020-November/559836.html These patches add several more sele

[PATCH 1/3] PowerPC: Add long double target-supports.

2021-01-14 Thread Michael Meissner via Gcc-patches
[PATCH 1/3] PowerPC: Add long double target-supports. This patch add several more selections to target-supports.exp: * 3 selections for the current long double format; * 3 selections if we can change the long double format to a particular value. * 3 functions to return t

[PATCH 2/3] PowerPC: PR target/70117, Force long double to be IBM 128-bit.

2021-01-14 Thread Michael Meissner via Gcc-patches
[PATCH 2/3] PowerPC: PR target/70117, Force long double to be IBM 128-bit. This patch fixes the pr70117 test to use IBM 128-bit long double. I have run tests on a little endian power9 system with 3 compilers: * One compiler using the default IBM 128-bit format; * One compiler using th

[PATCH 3/3] PowerPC: Force IBM long double for conversion test.

2021-01-14 Thread Michael Meissner via Gcc-patches
[PATCH 3/3] PowerPC: Force IBM long double for conversion test. The test c-c++-common/dfp/convert-bfp-11.c explicit expects long double to use the IBM 128-bit extended double format. In particular, some of the tests expect an infinity to be created if decimal values that are converted that are to

[PATCH 0/2] PowerPC: Add power10 IEEE 128-bit min/max/cmove

2021-01-14 Thread Michael Meissner via Gcc-patches
These patches have been kicking around for awhile, and I really would like to get them in. They aren't as important as the other float128 patches I've submitted today, since many of those patches are designed to allow switching the long double format to IEEE 128-bit, which we need in GCC 11. I ha

[PATCH 1/2] Power10: Add IEEE 128-bit min/max support.

2021-01-14 Thread Michael Meissner via Gcc-patches
[PATCH 1/2] Power10: Add IEEE 128-bit min/max support. This patch adds the support for the IEEE 128-bit floating point C minimum and maximum instructions. The next patch will add the support for using the compare and set mask instruction to implement conditional moves. Rather than trying to over

[PATCH 2/2] Power10: Add IEEE 128-bit fp conditional move.

2021-01-14 Thread Michael Meissner via Gcc-patches
[PATCH 2/2] Power10: Add IEEE 128-bit fp conditional move. This patch adds the support for power10 IEEE 128-bit floating point conditional move and for automatically generating min/max. Unlike the previous patch, I decided to keep two separate patterns for fpmask before splitting (one pattern for

[PATCH] c++: ICE with USING_DECL redeclaration [PR98687]

2021-01-14 Thread Marek Polacek via Gcc-patches
My recent patch that introduced push_using_decl_bindings didn't handle USING_DECL redeclaration, therefore things broke. This patch amends that. Note that I don't know if the other parts of finish_nonmember_using_decl are needed (e.g. the binding->type setting) -- I couldn't trigger it by any of

Re: [PATCH] rs6000: Use rldimi for vec init instead of shift + ior

2021-01-14 Thread Kewen.Lin via Gcc-patches
Hi Segher, on 2021/1/15 上午8:50, Segher Boessenkool wrote: > Hi! > > On Tue, Dec 22, 2020 at 04:08:26PM +0800, Kewen.Lin wrote: >> This patch is to make unsigned int vector init go with >> rldimi to merge two integers instead of shift and ior. >> >> I tried to use nonzero_bits in md file to make i

Re: [PATCH] combine: zeroing cost for new copies

2021-01-14 Thread Kewen.Lin via Gcc-patches
Hi Segher, Thanks for the comments! on 2021/1/15 上午4:43, Segher Boessenkool wrote: > Hi! > > On Wed, Dec 09, 2020 at 05:49:53PM +0800, Kewen.Lin wrote: >> This patch is to treat those new pseudo-to-pseudo copies >> after hard-reg-to-pseudo-copy as zero costs. The >> justification is that these

Re: [PATCH] keep scope blocks for all inlined functions (PR 98664)

2021-01-14 Thread Richard Biener via Gcc-patches
On Thu, Jan 14, 2021 at 8:13 PM Martin Sebor via Gcc-patches wrote: > > One aspect of PR 98465 - Bogus warning stringop-overread for std::string > is the inconsistency between -g and -g0 which turns out to be due to > GCC eliminating apparently unused scope blocks from inlined functions > that are

Re: [patch] gcc.dg/analyzer tests: relax dependency on alloca.h

2021-01-14 Thread Olivier Hainque
Hi Alex, > On 14 Jan 2021, at 22:13, Alexandre Oliva wrote: > > Hello, Olivier, > > On Dec 18, 2020, Olivier Hainque wrote: > >> Ping for https://gcc.gnu.org/pipermail/gcc-patches/2020-October/557548.html >> (copied below for convenience), please ? > > I think defining alloca as a macro in a

Re: V2 [PATCH 3/3] Build x86 libatomic with -march=i486 or better

2021-01-14 Thread Jakub Jelinek via Gcc-patches
On Thu, Jan 14, 2021 at 04:08:20PM -0800, H.J. Lu wrote: I think best would be to revert the i386-options.c change until this is all fixed, keeping the trunk broken too long is undesirable. Second, I didn't mean to talk specifically about libatomic, but about all the 3 configure.tgt changes. And

<    1   2