Re: [PATCH] c++: premature analysis of requires-expression [PR96410]

2020-09-16 Thread Jason Merrill via Gcc-patches
On 9/16/20 1:34 PM, Patrick Palka wrote: On Thu, 13 Aug 2020, Jason Merrill wrote: On 8/13/20 11:21 AM, Patrick Palka wrote: On Mon, 10 Aug 2020, Jason Merrill wrote: On 8/10/20 2:18 PM, Patrick Palka wrote: On Mon, 10 Aug 2020, Patrick Palka wrote: In the below testcase, semantic analysi

Re: [patch] Fix dangling references in thunks at -O0

2020-09-16 Thread Joseph Myers
This introduces an ICE building the glibc testsuite for alpha (bisected), s390 and sparc (symptoms appear the same, not bisected to confirm the exact revision). See bug 97078. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH] c++: premature analysis of requires-expression [PR96410]

2020-09-16 Thread Patrick Palka via Gcc-patches
On Wed, 16 Sep 2020, Jason Merrill wrote: > On 9/16/20 1:34 PM, Patrick Palka wrote: > > On Thu, 13 Aug 2020, Jason Merrill wrote: > > > > > On 8/13/20 11:21 AM, Patrick Palka wrote: > > > > On Mon, 10 Aug 2020, Jason Merrill wrote: > > > > > > > > > On 8/10/20 2:18 PM, Patrick Palka wrote: > >

[committed] analyzer: getchar has no side-effects

2020-09-16 Thread David Malcolm via Gcc-patches
Seen whilst debugging another issue, where the analyzer was assuming conservatively that a call to getchar could clobber a global. This is handled for most of the other stdio functions by the list in sm-file.cc Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to master as e09

[committed] analyzer: show program point in -Wanalyzer-too-complex

2020-09-16 Thread David Malcolm via Gcc-patches
I found this useful when debugging. Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to master as 6dd96e24ea3cb9919fedd4da35fbfd36ed98b0ea. gcc/analyzer/ChangeLog: * engine.cc (exploded_graph::get_or_create_node): Show the program point when issuing -Wanalyzer

[committed] analyzer: add program_point::get_next

2020-09-16 Thread David Malcolm via Gcc-patches
Avoid some future copy-and-paste by introducing a function. Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to master as b9b5fc0c2175b34131d9fd0805b1b307f754f4f0. gcc/analyzer/ChangeLog: * engine.cc (exploded_graph::process_node) : Simplify by using p

[committed] analyzer: bulk merger/processing of runs of nodes at CFG join points

2020-09-16 Thread David Malcolm via Gcc-patches
Prior to this patch the analyzer worklist considered only one node or two nodes at a time, processing and/or merging state individually or pairwise. This could lead to explosions of merger nodes at CFG join points, especially after switch statements, which could have large numbers of in-edges, and

[committed] analyzer: show SCC ids in .dot dumps

2020-09-16 Thread David Malcolm via Gcc-patches
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to master as d2c4d5199cf277becc1f377536973815d1c9519c. gcc/analyzer/ChangeLog: * engine.cc (supernode_cluster::dump_dot): Show the SCC id in the per-supernode clusters in FILENAME.eg.dot output. (exploded

Re: [Patch] OpenMP: Handle cpp_implicit_alias in declare-target discovery (PR96390)

2020-09-16 Thread Tobias Burnus
Hi Honza – some input would be really helpful! Hi Jakub – updated version below. On 9/16/20 12:36 PM, Jakub Jelinek wrote: I think you want Honza on this primarily, I'm always lost in the cgraph alias code. (Likewise as this thread shows) + while (node->alias_target) +node = symt

[committed] analyzer: fix state explosions due to SCC bug

2020-09-16 Thread David Malcolm via Gcc-patches
Debugging the state explosion of the very large switch statement in gcc.dg/analyzer/pr96653.c showed that the worklist was failing to order the exploded nodes correctly; the in-edges at the join point after the switch were not getting processed together, but were instead being rocessed in smaller b

Re: [RS6000] rs6000_rtx_costs comment

2020-09-16 Thread Segher Boessenkool
Hi! This took a while to digest, sorry. On Tue, Sep 15, 2020 at 10:49:42AM +0930, Alan Modra wrote: > + 1) Calls from places like optabs.c:avoid_expensive_constant will > + come here with OUTER_CODE set to an operation such as AND with X > + being a CONST_INT or other CONSTANT_P type. This

Re: [RS6000] rs6000_rtx_costs multi-insn constants

2020-09-16 Thread Segher Boessenkool
On Tue, Sep 15, 2020 at 10:49:43AM +0930, Alan Modra wrote: > This small patch to rs6000_rtx_const considerably improves code (_costs) > generated for large constants in 64-bit code, teaching gcc that it is > better to load a constant from memory than to generate a sequence of > up to five depend

Re: [RS6000] rs6000_rtx_costs cost IOR

2020-09-16 Thread Segher Boessenkool
Hi! On Tue, Sep 15, 2020 at 10:49:44AM +0930, Alan Modra wrote: > * config/rs6000/rs6000.c (rs6000_rtx_costs): Cost IOR. > case IOR: > - /* FIXME */ >*total = COSTS_N_INSNS (1); > - return true; Hey this was okay for over five years :-) > + left = XEXP (x, 0);

Re: libbacktrace: Add support for MiniDebugInfo

2020-09-16 Thread Ian Lance Taylor via Gcc-patches
On Wed, Sep 16, 2020 at 8:54 AM Alex Coplan wrote: > > On 16/09/2020 07:26, Ian Lance Taylor wrote: > > On Wed, Sep 16, 2020, 4:03 AM Alex Coplan wrote: > > > > > Hi Ian, > > > > > > On 14/09/2020 14:12, Ian Lance Taylor via Gcc-patches wrote: > > > > This patch to libbacktrace adds support for M

Re: [PATCH] c++: premature analysis of requires-expression [PR96410]

2020-09-16 Thread Jason Merrill via Gcc-patches
On 9/16/20 6:11 PM, Patrick Palka wrote: On Wed, 16 Sep 2020, Jason Merrill wrote: On 9/16/20 1:34 PM, Patrick Palka wrote: On Thu, 13 Aug 2020, Jason Merrill wrote: On 8/13/20 11:21 AM, Patrick Palka wrote: On Mon, 10 Aug 2020, Jason Merrill wrote: On 8/10/20 2:18 PM, Patrick Palka wrote

Re: [PATCH] Increase rtx_cost of sse_to_integer in skylake_cost.

2020-09-16 Thread Hongtao Liu via Gcc-patches
Thanks. On Wed, Sep 16, 2020 at 8:54 PM Uros Bizjak wrote: > > > gcc/ChangeLog > > > > PR target/96861 > > * config/i386/x86-tune-costs.h (skylake_cost): increase rtx > > cost of sse_to_integer from 2 to 6. > > > > gcc/testsuite > > > > * gcc.target/i386/pr95021-3.

Re: [PATCH] -mno-xsave should imply -mno-avx since -mavx implies -mxsave

2020-09-16 Thread Hongtao Liu via Gcc-patches
Thanks! On Wed, Sep 16, 2020 at 8:57 PM Uros Bizjak wrote: > > > gcc/ChangeLog > > > > * common/config/i386/i386-common.c > > (OPTION_MASK_ISA_AVX_UNSET): Remove OPTION_MASK_ISA_XSAVE_UNSET. > > (OPTION_MASK_ISA_XSAVE_UNSET): Add OPTION_MASK_ISA_AVX_UNSET. > > > > gcc/test

Re: [PATCH] warn for integer overflow in allocation calls (PR 96838)

2020-09-16 Thread Jeff Law via Gcc-patches
On 9/15/20 1:47 PM, Martin Sebor wrote: > Overflowing the size of a dynamic allocation (e.g., malloc or VLA) > can lead to a subsequent buffer overflow corrupting the heap or > stack.  The attached patch diagnoses a subset of these cases where > the overflow/wraparound is still detectable. > > Bes

Re: [RS6000] rs6000_rtx_costs cost IOR

2020-09-16 Thread Alan Modra via Gcc-patches
On Wed, Sep 16, 2020 at 07:02:06PM -0500, Segher Boessenkool wrote: > Hi! > > On Tue, Sep 15, 2020 at 10:49:44AM +0930, Alan Modra wrote: > > * config/rs6000/rs6000.c (rs6000_rtx_costs): Cost IOR. > > > case IOR: > > - /* FIXME */ > >*total = COSTS_N_INSNS (1); > > - re

Re: [PATCH] work harder to avoid -Wuninitialized for empty structs (PR 96295)

2020-09-16 Thread Jeff Law via Gcc-patches
On 9/15/20 1:00 PM, Martin Sebor via Gcc-patches wrote: > The -Wuninitialized/-Wmaybe-uninitialized enhancement to warn when > a pointer or reference to an uninitialized object is passed to > a const-qualified function argument tries to avoid triggering for > objects of empty types.  However, the

Re: [PATCH] document -Wuninitialized for allocated objects

2020-09-16 Thread Jeff Law via Gcc-patches
On 9/15/20 11:06 AM, Martin Sebor via Gcc-patches wrote: > The attached patch updates the manual to mention that Wuninitialized > and -Wmaybe-uninitialized are issued for both auto and allocated > objects, as well as for passing pointers to uninitialized objects > to const-qualified parameters.  B

Re: [PATCH] doc: use @code{} instead of @samp{@command{}} around 'date %s'

2020-09-16 Thread Jeff Law via Gcc-patches
On 9/11/20 4:41 PM, Sergei Trofimovich via Gcc-patches wrote: > From: Sergei Trofimovich > > Before the change 'man gcc' rendered "SOURCE_DATE_EPOCH" section as: > ... the output of @command{date +%s} on GNU/Linux ... > After the change it renders as: > ... the output of "date +%s" on GNU

Re: [PATCH] gcc: Make strchr return value pointers const

2020-09-16 Thread Jeff Law via Gcc-patches
On 9/7/20 6:13 PM, JonY via Gcc-patches wrote: > On 9/4/20 12:47 PM, Martin Storsjö wrote: >> Hi, >> >> On Fri, 4 Sep 2020, Jakub Jelinek wrote: >> >>> On Tue, Sep 01, 2020 at 04:01:42PM +0300, Martin Storsjö wrote: This fixes compilation of codepaths for dos-like filesystems with Clang

Re: [PATCH] Increase rtx_cost of sse_to_integer in skylake_cost.

2020-09-16 Thread Jeff Law via Gcc-patches
On 9/15/20 9:20 PM, Hongtao Liu via Gcc-patches wrote: > Hi: > Rtx cost of sse_to_integer would be used by pass_stv as a > measurement for the scalar-to-vector transformation. As > https://gcc.gnu.org/pipermail/gcc-patches/2019-August/528839.html > indicates, movement between sse regs and gprs s

Re: [PATCH] Compile gcc.target/i386/pr78904-4a.c with -mtune=generic

2020-09-16 Thread Jeff Law via Gcc-patches
On 9/15/20 8:32 AM, H.J. Lu via Gcc-patches wrote: > commit e95395926a84a2406faefe0995295d199d595440 > Author: Uros Bizjak > Date: Thu Jun 18 20:12:48 2020 +0200 > > i386: Fix mode of ZERO_EXTRACT RTXes, remove ext_register_operand > predicate. > > caused > > FAIL: gcc.target/i386/pr78904-

Re: [PATCH] fixincludes/fixfixes.c: Fix 'set but not used' warning.

2020-09-16 Thread Jeff Law via Gcc-patches
On 9/11/20 6:21 AM, Christophe Lyon via Gcc-patches wrote: > pz_tmp_base and pz_tmp_dot are always set, but used only when > _PC_NAME_MAX is defined. > > This patch moves their declaration and definition undef #ifdef > _PC_NAME_MAX to avoid this warning. > > 2020-09-11 Torbjörn SVENSSON >

PING^2 [PATCH] x86: Inline strncmp only with -minline-all-stringops

2020-09-16 Thread H.J. Lu via Gcc-patches
On Wed, Aug 19, 2020 at 6:25 AM H.J. Lu wrote: > > On Wed, Jul 15, 2020 at 10:42:27AM -0700, H.J. Lu wrote: > > Expand strncmp to "repz cmpsb" only with -minline-all-stringops since > > "repz cmpsb" can be much slower than strncmp function implemented with > > vector instructions, see > > > > http

PING^2 [PATCH] x86: Add cmpmemsi for -minline-all-stringops

2020-09-16 Thread H.J. Lu via Gcc-patches
On Wed, Aug 19, 2020 at 6:09 AM H.J. Lu wrote: > > On Tue, May 19, 2020 at 5:14 AM H.J. Lu wrote: > > > > On Tue, May 19, 2020 at 1:48 AM Uros Bizjak wrote: > > > > > > On Sun, May 17, 2020 at 7:06 PM H.J. Lu wrote: > > > > > > > > Duplicate the cmpstrn pattern for cmpmem. The only difference

Re: PING [Patch][Middle-end]Add -fzero-call-used-regs=[skip|used-gpr|all-gpr|used|all]

2020-09-16 Thread Richard Sandiford
Qing Zhao writes: > Segher and Richard, > > Now there are two major concerns from the discussion so far: > > 1. (From Richard): Inserting zero insns should be done after > pass_thread_prologue_and_epilogue since later passes (for example, > pass_regrename) might introduce new used caller-saved

Re: [PATCH] gcc: Make strchr return value pointers const

2020-09-16 Thread JonY via Gcc-patches
On 9/17/20 3:56 AM, Jeff Law wrote: > > If it's been ack'd by a maintainer, yes.  Jakub definitely qualifies as > a maintainer, so feel free to push it on Martin's behalf. > > > jeff Sure, it has been pushed, thanks all. signature.asc Description: OpenPGP digital signature

<    1   2