Re: [PATCH] Don't make -gsplit-dwarf imply -g

On Wed, May 13, 2020 at 5:50 PM Fangrui Song wrote: > > On 2020-05-13, Eric Botcazou wrote: > >> Did I mention I dislike -fsplit-dwarf? ;) > > > >Seconded, this will be confusing for almost all users. Since the option only > >affects debug info generation, it should be prefixed with 'g' in any ca

[committed] i386: Add V2SFmode conversion functions [PR95046]

gcc/ChangeLog: 2020-05-14 Uroš Bizjak PR target/95046 * config/i386/mmx.md (mmx_fix_truncv2sfv2si2): rename from mmx_pf2id. Add SSE/AVX alternative. Change operand predicates from nonimmediate_operand to register_mmxmem_operand. Enable instruction pattern for TARGET_MMX_WI

Re: [committed] i386: Add V2SFmode conversion functions [PR95046]

Now with a patch attached. On Thu, May 14, 2020 at 9:18 AM Uros Bizjak wrote: > > gcc/ChangeLog: > > 2020-05-14 Uroš Bizjak > > PR target/95046 > * config/i386/mmx.md (mmx_fix_truncv2sfv2si2): rename from mmx_pf2id. > Add SSE/AVX alternative. Change operand predicates from > n

[committed] openmp: Also implicitly mark as declare target to functions mentioned in target regions

Hi! OpenMP 5.0 also specifies that functions referenced from target regions (except for target regions with device(ancestor:)) are also implicitly declare target to. This patch implements that. Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk. 2020-05-14 Jakub Jelinek

[committed] openmp: Fix placement of 2nd+ preparation statement for PHIs in simd clone lowering [PR95108]

Hi! For normal stmts, preparation statements are inserted before the stmt, so if we need multiple, they are in the correct order, but for PHIs we emit them after labels in the entry successor bb, and we used to emit them in the reverse order that way. Fixed thusly, bootstrapped/regtested on x86

Re: [PATCH] tree-optimization/33315 - common stores during sinking

On Wed, 13 May 2020, Martin Sebor wrote: > On 5/13/20 2:20 AM, Richard Biener wrote: > > > > This implements commoning of stores to a common successor in > > a simple ad-hoc way. I've decided to put it into the code sinking > > pass since, well, it sinks stores. It's still separate since > > it

[PATCH] testsuite/94703 - skip gcc.dg/tree-ssa/pr94703.c on strict-align targets

The specific dump scanning doesn't work on strict-align targets, the following simply skips the testcase for those. 2020-05-14 Richard Biener PR testsuite/94703 * gcc.dg/tree-ssa/pr94703.c: Skip for strict-align targets. --- gcc/testsuite/gcc.dg/tree-ssa/pr94703.c | 1 + 1 fil

Re: Should ARMv8-A generic tuning default to -moutline-atomics

The 04/30/2020 12:26, Kyrylo Tkachov wrote: > > > From: Gcc On Behalf Of Andrew Pinski via Gcc > > > On Wed, Apr 29, 2020 at 6:25 AM Florian Weimer via Gcc > > > wrote: > > > > Distributions are receiving requests to build things with > > > > -moutline-atomics: > > > > > > > >

Re: [PATCH v2] Fold (add -1; zero_ext; add +1) operations to zero_ext when not overflow (PR37451, part of PR61837)

luoxhu writes: > This "subtract/extend/add" existed for a long time and still annoying us > (PR37451, part of PR61837) when converting from 32bits to 64bits, as the ctr > register is used as 64bits on powerpc64, Andraw Pinski had a patch but > caused some issue and reverted by Joseph S. Myers(PR37

[committed] aarch64: Fix arm_sve_vector_bits on typedefs [PR95105]

Compiling this testcase with -march=armv8.2-a+sve -msve-vector-bits=512: -- typedef __SVFloat32_t foo; typedef foo bar __attribute__((arm_sve_vector_bits(512))); template struct s { T x; }; extern s a; bar &b = a.x; --

Re: [PATCH] Add tests for gcc-changelog.

On Thu, May 14, 2020 at 12:11:50PM +0200, Martin Liška wrote: > I would like to add unit-tests for gcc-changelog. > The test_patches.txt contains couple of patches extracted from gcc > via git format-patch. > > Test output: > $ pytest contrib/gcc-changelog/ > Test session starts (platform: linux,

[PATCH] ipa-devirt: Fix crash in obj_type_ref_class [PR95114]

The testcase has failed since r9-5035, because obj_type_ref_class tries to look up an ODR type when no ODR type information is available. (The information was available earlier in the compilation, but was freed during pass_ipa_free_lang_data.) We then crash dereferencing the null get_odr_type resu

[committed] i386: Add V2DFmode conversion functions [PR95046]

gcc/ChangeLog: 2020-05-14 Uroš Bizjak PR target/95046 * config/i386/sse.md (sse2_cvtpi2pd): Add memory to alternative 1. (floatv2siv2df2): New expander. (floatunsv2siv2df2): New insn pattern. (fix_truncv2dfv2si2): New expander. (fixuns_truncv2dfv2si2): New insn patter

Re: [PATCH] Add tests for gcc-changelog.

On 5/14/20 1:27 PM, Jakub Jelinek wrote: On Thu, May 14, 2020 at 12:11:50PM +0200, Martin Liška wrote: I would like to add unit-tests for gcc-changelog. The test_patches.txt contains couple of patches extracted from gcc via git format-patch. Test output: $ pytest contrib/gcc-changelog/ Test ses

Re: [PATCH] ipa-devirt: Fix crash in obj_type_ref_class [PR95114]

> The testcase has failed since r9-5035, because obj_type_ref_class > tries to look up an ODR type when no ODR type information is > available. (The information was available earlier in the > compilation, but was freed during pass_ipa_free_lang_data.) > We then crash dereferencing the null get_odr

[RFH] LTO cgraph support for late declare variant resolution

Hi! I've committed the patch, so that the rest can be handled incrementally. On Wed, May 13, 2020 at 01:16:42PM +0200, Jakub Jelinek wrote: > Honza/Martin, are the cgraph related changes acceptable to you? > > For LTO, the patch only saves/restores the two cgraph_node bits added in the > patch,

Re: ChangeLog files - server and client scripts (git cherry-pick)

Hello. I'm sending patch candidate that adds 2 new git aliases: - gcc-backport - simple alias to 'git cherry-pick -x' - gcc-revert - it similarly appends '(this reverts commit 365e3cde4978c6a7dbfa50865720226254c016be)' to a reverted commit message The script normally parses content of a git mes

Re: [PATCH] ipa-devirt: Fix crash in obj_type_ref_class [PR95114]

Jan Hubicka writes: >> The testcase has failed since r9-5035, because obj_type_ref_class >> tries to look up an ODR type when no ODR type information is >> available. (The information was available earlier in the >> compilation, but was freed during pass_ipa_free_lang_data.) >> We then crash dere

Re: ChangeLog files - server and client scripts

On 5/13/20 7:53 PM, Joseph Myers wrote: On Wed, 13 May 2020, Martin Liška wrote: I'm sending the gcc-changelog relates scripts which should be added to contrib folder. The patch contains: - git_check_commit.py - checking script that verifies git message format We need a documentation patch to

[PATCH v2] coroutines: Implicitly movable objects should use move CTORs for co_return.

Hi thanks for the review and pointers ... Nathan Sidwell wrote: > On 5/13/20 9:26 AM, Iain Sandoe wrote: >> Nathan Sidwell wrote: >>> On 5/13/20 6:59 AM, Iain Sandoe wrote: >> This is the equivalent of finish_return_stmt () in the parser, it knows >> nothing of the eventual morphing of

Re: [PATCH] ipa-devirt: Fix crash in obj_type_ref_class [PR95114]

> Jan Hubicka writes: > >> The testcase has failed since r9-5035, because obj_type_ref_class > >> tries to look up an ODR type when no ODR type information is > >> available. (The information was available earlier in the > >> compilation, but was freed during pass_ipa_free_lang_data.) > >> We the

[C++] improve build_template_decl

I discovered all the users of build_template_decl were explicitly setting the RESULT and TYPE fields of the built decl. Let's just have build_template_decl do that in the first place. pushed to master. nathan -- Nathan Sidwell 2020-05-14 Nathan Sidwell * pt.c (build_template_decl): Init

Re: Ping: [PATCH] wwwdocs: Add D front-end section for GCC 10 changes

On 07/05/2020 16:04, Iain Buclaw via Gcc-patches wrote: > Hi, > > Updated the patch to include missed changes, and slighted reworded some > entries > to make them clearer/read easier. > I've gone ahead and pushed it, after someone else did a review of the wording. Iain.

Re: [PATCH] x86: Default CET run-time support to auto

On Fri, 2020-05-08 at 06:44 -0700, H.J. Lu wrote: > CET has been added since GCC 8. This patch defaults CET run-time support > to auto. It enables CET run-time support if asssembler supports CET > instructions and multi-byte NOPs are enabled via SSE2. > > OK for master? > > Thanks. > > H.J. >

Re: Ping: [PATCH] wwwdocs: Add D front-end section for GCC 10 changes

On Wed, 2020-05-13 at 15:00 +0200, Iain Buclaw via Gcc-patches wrote: > Ping. > > On 07/05/2020 16:04, Iain Buclaw via Gcc-patches wrote: > > Hi, > > > > Updated the patch to include missed changes, and slighted reworded some > > entries > > to make them clearer/read easier. > > > > OK to commit

Re: Ping: [PATCH] libiberty: Update D symbol demangling for latest ABI spec.

On Sun, 2020-05-10 at 11:10 +0200, Iain Buclaw via Gcc-patches wrote: > Ping > > On 03/05/2020 09:37, Iain Buclaw via Gcc-patches wrote: > > Ping. > > > > There is a new mangle string "Nm" in the abi to denote the @live attribute, > > however will add support in a follow up patch. > > > > > > O

Re: [PATCH] contrib: Handle GDB specific test result types

On Mon, 2020-05-11 at 22:48 +0100, Andrew Burgess wrote: > This commit is for the benefit of GDB, but as the binutils-gdb > repository shares the contrib/ directory with gcc, this commit must > first be applied to gcc then copied back to binutils-gdb. > > This commit extends the two scripts contri

[C++] more pt.c simplifications

Pushed this bunch of simplifications to the template machinery. As ever, discovered when implementing modules and figuring out how it worked. inst-friend.diff tsubst_friend_function's control flow was a little complicated. This simplifies it, primarily by using more RAII. lkp-class.diff W

[PATCH] arm.c: Clarify error message in thumb1_expand_prologue

While running the tests with -march=armv5t -mthumb, I came across this error message which I think could be clearer. 2020-05-14 Christophe Lyon gcc/ * config/arm/arm.c (thumb1_expand_prologue): Update error message. --- gcc/config/arm/arm.c | 2 +- 1 file changed, 1 insertion(

[PATCH v2] arm: Warn if IRQ handler is not compiled with -mgeneral-regs-only [PR target/94743]

The interrupt attribute does not guarantee that the FP registers are saved, which can result in problems difficult to debug. Saving the FP registers and status registers can be a large penalty, so it's probably not desirable to do that all the time. If the handler calls other functions, we'd like

[PATCH 1/2] arm: Factorize several occurrences of the same code into reg_needs_saving_p

The same code pattern occurs in several functions, so it seems cleaner to move it into a dedicated function. 2020-05-14 Christophe Lyon gcc/ * config/arm/arm.c (reg_needs_saving_p): New function. (use_return_insn): Use reg_needs_saving_p. (arm_get_vfp_saved_size

[PATCH 2/2] arm: Add support for interrupt routines to reg_needs_saving_p

reg_needs_saving_p is only used when dealing with non-interrupt routines, but it makes sense to extend it to support that context too, and make arm_compute_save_reg0_reg12_mask use it. Save only live registers for non-leaf functions, but assume a callee could clobber any register. 2020-05-14 Chr

Re: Ping: [PATCH] wwwdocs: Add D front-end section for GCC 10 changes

On Thu, 14 May 2020, Jeff Law wrote: >> OK to commit? > OK. In fact, this seems like you shouldn't need reviews -- you're just > updating the docs for D. Agreed, though always happy to help and provide review and feedback - sometimes just a bit slow as in this case. But, indeed, you can self ap

Re: [PATCH] arm.c: Clarify error message in thumb1_expand_prologue

On Thu, May 14, 2020 at 3:57 PM Christophe Lyon via Gcc-patches wrote: > > While running the tests with -march=armv5t -mthumb, I came across this > error message which I think could be clearer. > > 2020-05-14 Christophe Lyon > > gcc/ > * config/arm/arm.c (thumb1_expand_prologue)

Re: [PATCH 1/2] arm: Factorize several occurrences of the same code into reg_needs_saving_p

On Thu, May 14, 2020 at 3:58 PM Christophe Lyon via Gcc-patches wrote: > > The same code pattern occurs in several functions, so it seems cleaner > to move it into a dedicated function. > > 2020-05-14 Christophe Lyon > > gcc/ > * config/arm/arm.c (reg_needs_saving_p): New functi

Re: arm: Fix vfp_operand_register for VFP HI regs

On Fri, 1 May 2020 at 12:57, Kyrylo Tkachov wrote: > > > > > -Original Message- > > From: Christophe Lyon > > Sent: 30 April 2020 09:51 > > To: Kyrylo Tkachov > > Cc: gcc-patches@gcc.gnu.org > > Subject: Re: arm: Fix vfp_operand_register for VFP HI regs > > > > On Wed, 29 Apr 2020 at 18:

[C++] a missed c++2a->c++20

Jason missed a c++2a mention. I couldn't resist changing the loop following to place the initializers inside the fors. pushed to master nathan -- Nathan Sidwell 2020-05-14 Nathan Sidwell * parser.c (cp_parser_diagnose_invalid_typename): Mention std=c++20 not 2a, reformat dependent binfo

Re: [PATCH v2] coroutines: Implicitly movable objects should use move CTORs for co_return.

On 5/14/20 9:04 AM, Iain Sandoe wrote: Hi thanks for the review and pointers ... Nathan Sidwell wrote: On 5/13/20 9:26 AM, Iain Sandoe wrote: Nathan Sidwell wrote: On 5/13/20 6:59 AM, Iain Sandoe wrote: This is the equivalent of finish_return_stmt () in the parser, it knows nothing

Re: [PATCH 1/2] arm: Factorize several occurrences of the same code into reg_needs_saving_p

On Thu, 14 May 2020 at 17:07, Ramana Radhakrishnan wrote: > > On Thu, May 14, 2020 at 3:58 PM Christophe Lyon via Gcc-patches > wrote: > > > > The same code pattern occurs in several functions, so it seems cleaner > > to move it into a dedicated function. > > > > 2020-05-14 Christophe Lyon > >

Re: [PATCH] c++: Missing SFINAE with lookup_fnfields [PR78446]

On 5/6/20 5:48 PM, Patrick Palka wrote: Here we're failing to do SFINAE in build_op_call when looking up the class's operator() via lookup_fnfields, which calls lookup_member always with complain=tf_warning_or_error. And from there we complain about an ambiguous lookup for operator(). This patc

Re: [PATCH 2/2] arm: Add support for interrupt routines to reg_needs_saving_p

> static bool reg_needs_saving_p (unsigned reg) > { >unsigned long func_type = arm_current_func_type (); Ah ok , you needed it here. Ramana

Re: [PATCH] Optimize store_expr from STRING_CST [PR95052]

On Tue, 2020-05-12 at 10:12 +0200, Jakub Jelinek wrote: > Hi! > > In the following testcase, store_expr of e.g. 97 bytes long string literal > into 1MB long array is implemented by copying the 97 bytes from .rodata > section, followed by clearing the remaining bytes. But, as the STRING_CST > has

[C++] simplify tsubst_template_decl

the final (for now) templatet simplification is this one. The control flow through tsubst_template_decl was also confusing. This flattens the conditionals and reorders things to make it simpler. pushed to trunk. nathan -- Nathan Sidwell 2020-05-14 Nathan Sidwell * pt.c (tsubst_template_

[patch, libfortran, committed]

Hi, I just committed as obvious a patch which fixed a hang on close with -pthread after a previous error on close with an invalid STATUS. The solution was obvious: Return early if an error occurred. I also managed to make some double ChangeLog entries (fixed with the next commit after), but hey

Re: ChangeLog files - server and client scripts

On Thu, 14 May 2020, Martin Liška wrote: > On 5/13/20 7:53 PM, Joseph Myers wrote: > > On Wed, 13 May 2020, Martin Liška wrote: > > > > > I'm sending the gcc-changelog relates scripts which should be added to > > > contrib > > > folder. The patch contains: > > > - git_check_commit.py - checking s

Re: [PATCH] Optimize store_expr from STRING_CST [PR95052]

On Thu, May 14, 2020 at 10:10:55AM -0600, Jeff Law wrote: > On Tue, 2020-05-12 at 10:12 +0200, Jakub Jelinek wrote: > > Hi! > > > > In the following testcase, store_expr of e.g. 97 bytes long string literal > > into 1MB long array is implemented by copying the 97 bytes from .rodata > > section, fo

Re: [PATCH resend] rs6000, pr 94833: fix vec_first_match_index for nulls

Hi! On Wed, May 13, 2020 at 10:14:24AM -0700, Carl Love wrote: > The following patch fixes PR94833, vec_first_match_index does not > function as described in its description. > > The builtin does not handle vector elements which are zero correctly. > The following patch fixes the issue and adds

Re: [PATCH] avoid -Warray-bounds when indexing into array members of union (PR 94940)

On Fri, 2020-05-08 at 15:46 -0600, Martin Sebor via Gcc-patches wrote: > The improved detection of accesses to interior zero-length arrays > fails to consider the case when the array is a member of a union. > Such accesses are documented as supported so warning for them is > not expected. The atta

Re: Ping: [PATCH] wwwdocs: Add D front-end section for GCC 10 changes

On 14/05/2020 17:04, Gerald Pfeifer wrote: > On Thu, 14 May 2020, Jeff Law wrote: >>> OK to commit? >> OK. In fact, this seems like you shouldn't need reviews -- you're just >> updating the docs for D. > > Agreed, though always happy to help and provide review and feedback > - sometimes just a b

[committed] i386: Add V2DFmode float trunc/extend functions [PR95046]

gcc/ChangeLog: 2020-05-14 Uroš Bizjak PR target/95046 * config/i386/sse.md (truncv2dfv2df2): New insn pattern. (extendv2sfv2df2): Ditto. testsuite/ChangeLog: 2020-05-14 Uroš Bizjak PR target/95046 * gcc.target/i386/pr95046-7.c: New test. Bootstrapped and regression t

Re: Ping: [PATCH] libiberty: Update D symbol demangling for latest ABI spec.

On 14/05/2020 16:36, Jeff Law wrote: > On Sun, 2020-05-10 at 11:10 +0200, Iain Buclaw via Gcc-patches wrote: >> Ping >> >> On 03/05/2020 09:37, Iain Buclaw via Gcc-patches wrote: >>> Ping. >>> >>> There is a new mangle string "Nm" in the abi to denote the @live attribute, >>> however will add suppo

Re: [C++] template arg comparison

Hi, > When fixing up the template specialization hasher I was confused by the > control flow through template_args_equal. This reorders the category > checking, so it is clearer as to what kind of node can reach which point. > > nathan > > 2020-05-13 Nathan Sidwell > > * pt.c (template_

Re: libgo patch committed: Build syscall test with -static

Hi Ian, > This libgo patch builds the syscall test with -static. This avoids > problems finding libgo.so when running the test as root, which invokes > the test as a child process in various limited environments. This > fixes GCC PR 95061. Bootstrapped and ran Go tests on > x86_64-pc-linux-gnu.

[committed] amdgcn: fix vcc clobber in vector load/store

This fixes a wrong-code error that could occur when a vector reload was inserted between a vector compare and conditional branch. The problem was that expanding the vector base address to the vector of addresses needed by the ISA would clobber the VCC register. This fine before LRA, but not go

[PATCH] c++: decltype of invalid non-dependent expr [PR57943]

We sometimes fail to reject a invalid non-dependent operand to decltype when inside a template, because finish_decltype_type resolves the decltype to the TREE_TYPE of the operand before we ever instantiate and fully process the operand. Fix this by adding a call to instantiate_non_dependent_expr_s

Re: libgo patch committed: Build syscall test with -static

On Thu, May 14, 2020 at 12:43 PM Rainer Orth wrote: > > > This libgo patch builds the syscall test with -static. This avoids > > problems finding libgo.so when running the test as root, which invokes > > the test as a child process in various limited environments. This > > fixes GCC PR 95061. B

[pushed] c++: Fix deferred noexcept on constructor [PR93901].

My change in r10-4394 to only update clones when we actually instantiate a deferred noexcept-spec broke this because deferred parsing updates the primary function but not the clones. For GCC 10 I just reverted that change; this patch adjusts maybe_instantiate_noexcept to update only the clone pass

[PATCH] c++: Enable coroutines with -std=c++20.

Now that GCC 10 is out it seems time. People can still choose to disable coroutines with -fno-coroutines. This also switches the coroutines testsuite to run in C++20 mode. The change to coro.h is needed for co-await-11-forwarding.C; we could alternatively #include just in that file. Iain, does

Re: [PATCH] Skip jit tests for targets that don't support -lgccjit

On Fri, 2020-05-08 at 12:12 -0700, H.J. Lu via Gcc-patches wrote: > Since libgccjit.so is linked into jit tests, skip jit tests for targets > that don't support -lgccjit. > > OK for master? > > H.J. > --- > PR jit/94778 > * jit.dg/jit.exp: Skip jit tests for targets that don't support

Re: [PATCH] c++: Enable coroutines with -std=c++20.

Jason Merrill via Gcc-patches wrote: Now that GCC 10 is out it seems time. People can still choose to disable coroutines with -fno-coroutines. There’s one pass that has to run for all functions, the remainder of the work is gated on the function being a coroutine. If there’s a hit found fro

[PATCH RFC] bootstrap: Update requirement to C++11.

There seemed to be general agreement last November that we would move to allowing C++11 features to be used in GCC 11; this patch implements that direction. Are changes needed anywhere else? ChangeLog 2020-05-14 Jason Merrill * configure.ac: Update bootstrap dialect to -std=gnu++11.

Re: [PATCH RFC] bootstrap: Update requirement to C++11.

On Thu, May 14, 2020 at 05:05:59PM -0400, Jason Merrill via Gcc-patches wrote: > +Versions of GCC prior to 11 also allow bootstrapping with an ISO C++98 > +compiler, versions of GCC prior to 4.8 also allow bootstrapping with a > +ISO C89 compiler, and versions of GCC prior to 3.4 also allow > +boot

[PATCH] x86: Add -mavoid-libcall for -mgeneral-regs-only

The -mgeneral-regs-only option generates code that uses only the general-purpose registers. It prevents the compiler from using vector registers. But GCC may still generate calls to memcpy, memmove, memset and memcmp library functions. In the GNU C library, these library functions are implementa

Re: [PATCH] Skip jit tests for targets that don't support -lgccjit

On Thu, May 14, 2020 at 1:42 PM Jeff Law wrote: > > On Fri, 2020-05-08 at 12:12 -0700, H.J. Lu via Gcc-patches wrote: > > Since libgccjit.so is linked into jit tests, skip jit tests for targets > > that don't support -lgccjit. > > > > OK for master? > > > > H.J. > > --- > > PR jit/94778 > >

Re: [PATCH] Extend std::copy/std::copy_n char* overload to deque iterator

Now fully tested, ok to commit ? On 07/05/20 9:12 am, François Dumont wrote:     This patch purpose is to make sure that existing std::copy/std::copy_n overloads for char* will also be used for std::deque iterators when dealing with istreambuf_iterator. It also make sure that it still works w

Re: [PATCH] x86: Add -mavoid-libcall for -mgeneral-regs-only

On Fri, May 15, 2020 at 1:13 AM H.J. Lu wrote: > > The -mgeneral-regs-only option generates code that uses only the > general-purpose registers. It prevents the compiler from using vector > registers. But GCC may still generate calls to memcpy, memmove, memset > and memcmp library functions. In

Re: [PATCH 2/2] arm: Add support for interrupt routines to reg_needs_saving_p

On Thu, 14 May 2020 at 17:58, Ramana Radhakrishnan wrote: > > > static bool reg_needs_saving_p (unsigned reg) > > { > >unsigned long func_type = arm_current_func_type (); > > Ah ok , you needed it here. Yes sorry. Is this patch (2/2) OK? Thanks, Christophe > > Ramana