Re: PATCH -- Fix degree trignometric functions

2020-03-28 Thread Tobias Burnus
Two remarks: * As the file trigd_lib.inc is shared between libgfortran and gcc/fortran, I wonder whether it should be placed under include/ (under the GCC toplevel directroy) * All included files need dependency; I do not quickly see whether that' the case. Cheers, Tobias On 3/28/20 12:

Re: [PATCH] reassoc: Fix -fcompare-debug bug in reassociate_bb [PR94329]

2020-03-28 Thread Richard Biener
On March 28, 2020 1:50:59 AM GMT+01:00, Jakub Jelinek wrote: >Hi! > >The following testcase FAILs with -fcompare-debug, because >reassociate_bb >mishandles the case when the last stmt in a bb has zero uses. In that >case >reassoc_remove_stmt (like gsi_remove) moves the iterator to the next >stmt,

Re: [PATCH] calls.c precompute_register_parameters for TLS

2020-03-28 Thread Eric Botcazou
> I'm forced to fall back to a targeted patch in > calls.c:precompute_register_parameters() that tests exactly for TLS > symbols on AIX instead of using the legitimate_constant_p hook to test > for TLS symbols. > > I could create a new target hook for this specific use in calls.c and > define it a

Re: [PATCH] calls.c precompute_register_parameters for TLS

2020-03-28 Thread Richard Sandiford
David Edelsohn via Gcc-patches writes: > This patch is for an AIX problem, but the only robust solution is in > common code: calls.c:precompute_register_parameters(). > > AIX, like other platforms, needs to call a function to obtain the > pointer to thread-local storage. If the thread local varia

Re: PATCH -- Fix degree trignometric functions

2020-03-28 Thread Steve Kargl via Gcc-patches
On Sat, Mar 28, 2020 at 08:10:38AM +0100, Tobias Burnus wrote: > Two remarks: > > * As the file trigd_lib.inc is shared between libgfortran > and gcc/fortran, I wonder whether it should be placed > under include/ (under the GCC toplevel directroy) The original name and location were chosen to

Re: [PATCH] lower-subreg: PR94123, SVN r273240, causes gcc.target/powerpc/pr87507.c to fail

2020-03-28 Thread Segher Boessenkool
On Fri, Mar 27, 2020 at 05:41:36PM -0500, Peter Bergner wrote: > Given we're late in stage4, the above patch (assuming it's ok) probably > shouldn't go in until stage1, since it is changing lower-subreg's behaviour > slightly. > > A different (ie, safer) approach would be to just rerun lower-subre

Re: [RS6000] Put call cookie back in AIX/ELFv2 call patterns

2020-03-28 Thread Segher Boessenkool
Hi! On Sat, Mar 28, 2020 at 09:27:09AM +1030, Alan Modra wrote: > The only difference > besides mode between call_local32 and call_local64, dating back to > 1998 commit a260abc996, is that call_local64 has TARGET_64BIT in the > predicate. That alone doesn't seem reason enough to need separate > p

Re: Fix modulo-scheduler -fcompare-debug issues

2020-03-28 Thread Roman Zhuykov via Gcc-patches
Hi, Christophe Lyon wrote 2020-03-27 19:53: Hi, On Fri, 20 Mar 2020 at 11:56, Roman Zhuykov via Gcc-patches wrote: Hi all! 12.03.2020 6:17, Jeff Law wrote: >> Current modulo-sched implementation is a bit faulty from -fcompile-debug >> perspective. >> >> But right now I see that when I enab

[PATCH] doc: Update -falign-functions/-falign-loops/-falign-jumps

2020-03-28 Thread H.J. Lu via Gcc-patches
Change -falign-functions=N to Align the start of functions to the next power-of-two greater than or equal to N. Add If '-falign-labels' is greater than this value, then its value is used instead. to -falign-loops=N and -falign-jumps=N. OK for master? H.J. -- PR driver/

[committed] libstdc++: Fix two tests that fail in C++20 mode

2020-03-28 Thread Jonathan Wakely via Gcc-patches
* testsuite/20_util/is_constructible/value-2.cc: Fix test to account for changes due to parenthesized aggregate-initialization in C++20. * testsuite/20_util/time_point/cons/81468.cc: Fix test to not clash with std::chrono::sys_time in C++20. Tested powerpc64le-linux

Re: [committed 2/3] libstdc++: Add remaining C++20 changes to iterator adaptors

2020-03-28 Thread Jonathan Wakely via Gcc-patches
On 28/03/20 00:16 +, Jonathan Wakely wrote: On 27/03/20 23:29 +, Jonathan Wakely wrote: @@ -403,6 +428,49 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION operator>=(const reverse_iterator<_IteratorL>& __x, const reverse_iterator<_IteratorR>& __y) { return !(__x < __y); } +#else

Re: [PATCH] lower-subreg: PR94123, SVN r273240, causes gcc.target/powerpc/pr87507.c to fail

2020-03-28 Thread Peter Bergner via Gcc-patches
On 3/28/20 2:22 PM, Segher Boessenkool wrote: > On Fri, Mar 27, 2020 at 05:41:36PM -0500, Peter Bergner wrote: >> A different (ie, safer) approach would be to just rerun lower-subreg at >> its old location, regardless of whether we used -fsplit-wide-types-early. > > That is my preference, for a si

Re: [stage1][PATCH] Provide warning for missing jobserver.

2020-03-28 Thread Martin Sebor via Gcc-patches
On 3/26/20 3:40 AM, Martin Liška wrote: Hi. I'm suggesting to provide a warning when one uses -flto=jobserver but we can't detect job server for some reason. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed in next stage1? Thanks, Martin gcc/ChangeL

[PATCH] [ARC] Allow more ABIs in GLIBC_DYNAMIC_LINKER

2020-03-28 Thread Vineet Gupta via Gcc-patches
Enable big-endian suffixed dynamic linker per glibc multi-abi support. And to avoid a future churn and version pairingi hassles, also allow arc700 although glibc for ARC currently doesn't support it. gcc/ -xx-xx Vineet Gupta + + * config/arc/linux.h: GLIBC_DYNAMIC_LINKER support BE/ar

Re: [PATCH] calls.c precompute_register_parameters for TLS

2020-03-28 Thread David Edelsohn via Gcc-patches
On Sat, Mar 28, 2020 at 6:42 AM Richard Sandiford wrote: > > David Edelsohn via Gcc-patches writes: > > This patch is for an AIX problem, but the only robust solution is in > > common code: calls.c:precompute_register_parameters(). > > > > AIX, like other platforms, needs to call a function to ob