Re: [PATCH] alias: Fix offset checks involving section anchors [PR92294]

On Wed, Feb 19, 2020 at 4:12 PM Richard Sandiford wrote: > > Richard Biener writes: > > On Wed, Feb 19, 2020 at 1:19 PM Richard Sandiford > > wrote: > >> > >> What should we do about this? The PR is a wrong-code regression from > >> GCC 9 and it doesn't look like we can remove the second offset

Re: [PATCH 1/2] libstdc++: Forward second argument of views::iota using the correct type

On 19/02/20 23:53 -0500, Patrick Palka wrote: We are forwarding the second argument of views::iota using the wrong type, causing compiling errors when calling it with a value and bound of different types, like in the test case below. Good catch, OK for master.

Re: [PATCH 2/2] libstdc++: P1739R4 Avoid template bloat for safe_ranges in combination with ...

On 19/02/20 23:53 -0500, Patrick Palka wrote: ... 'subrange-y' view adaptors This implements an interpretation of P1739R4. It's only an "interpretation" becuase AFAICT there is an issue with the paper's wording as-is. So this patch deviates from paper when it comes to the problematic wording.

[PATCH] Fix error message for Darwin.

Hi. It's one obvious documentation fix that I'm going to install. Martin gcc/ChangeLog: 2020-02-20 Martin Liska PR translation/93831 * config/darwin.c (darwin_override_options): Change 64b to 64-bit mode. --- gcc/config/darwin.c | 3 ++- 1 file changed, 2 insertions(+), 1

[PATCH] Remove trailing | in help message.

Hi. It's one obvious documentation fix that I'm going to install. Martin gcc/ChangeLog: 2020-02-20 Martin Liska PR translation/93830 * common/config/avr/avr-common.c: Remote trailing "|". --- gcc/common/config/avr/avr-common.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH] Remove triling space for a warning.

Hi. It's one obvious warning message fix that I'm going to install. Martin gcc/cp/ChangeLog: 2020-02-20 Martin Liska PR translation/93838 * parser.c (cp_parser_decl_specifier_seq): Remove trailing space. --- gcc/cp/parser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH] Remove superfluous word in documentation.

Hi. It's one obvious documentation fix that I'm going to install. Martin gcc/cp/ChangeLog: 2020-02-20 Martin Liska PR translation/93841 * config/or1k/or1k.opt: Remove superfluous word. * doc/invoke.texi: Likewise. --- gcc/config/or1k/or1k.opt | 2 +- gcc/doc/invoke

[PATCH] libstdc++: Add <=> to thread::id

* include/std/thread (thread::id::operator<=>): Define for C++20. * testsuite/30_threads/thread/id/70294.cc: Do not take addresses of functions in namespace std. * testsuite/30_threads/thread/id/operators_c++20.cc: New test. This is a small part of P1614R2. Tested p

[committed] Remove std::type_info::operator!= for C++20

This is an even smaller part of P1614R2. Tested powerpc64le-linux, committed to master. commit 20fa41e61fd2d2839ca47e0dfac6976c552ab648 Author: Jonathan Wakely Date: Fri Feb 7 20:50:00 2020 + libstdc++: Remove std::type_info::operator!= for C++20 This function can be synthe

RE: [PATCH] Fix bug in recursiveness check for function to be cloned (ipa/pr93707)

Hi Martin, > Honza, is it OK for trunk? Tamar, can you please double check it fixes > your problem with perlbench? > Thanks for working on this! Yes it does seem to fix the regression as well. Cheers, Tamar > Thanks, > > Martin > > > ipa-cp: Avoid wrongly gathering self-recursive edges (PR 93

[committed] libstdc++: Define operator<=> for types

Another piece of P1614R2 for C++20. This also adds tests for operator< in C++11, which was present but untested. * include/std/system_error (error_category::operator<=>) (operator<=>(const error_code&, const error_code&)) (operator<=>(const error_condition&, const error_c

[PATCH] Fix -save-temp leaking lto files in /tmp

Hi, this is the remaining issue that happens when -flto and -save-temps is used together, it leaks several files in /tmp. I try to give more background to how these temp files are created, and in all likelihood the leaking of these files is wanted, and certainly very helpful for debugging lto iss

Re: [PATCH] Avoid collect2 calling signal unsafe functions and/or unlink, with uninitialized memory (for gcc-8 branch)

On Wed, 19 Feb 2020, Bernd Edlinger wrote: > Hi, > > this fixes the signal handler calling signal unsafe vfprintf and/or passing > uninitialized memory to unlink in signal handler. > > This is the patch for the gcc-8 branch. > > > Bootstrapped and reg-tested with x86_64-pc-linux-gnu. > Is it O

Re: [PATCH] Fix -save-temp leaking lto files in /tmp

On Thu, 20 Feb 2020, Bernd Edlinger wrote: > Hi, > > this is the remaining issue that happens when -flto and -save-temps > is used together, it leaks several files in /tmp. > > I try to give more background to how these temp files are > created, and in all likelihood the leaking of these > files

[committed] libstdc++: Issues with range access CPOs (P2091R0)

This changes how arrays of unknown bound and/or incomplete element type are handled. * include/bits/range_access.h (ranges::begin): Reject array of incomplete type. (ranges::end, ranges::size): Require arrays to be bounded. (ranges::data): Require lvalue or borrowed

Re: [PATCH] Fix -save-temp leaking lto files in /tmp

On 2/20/20 2:34 PM, Richard Biener wrote: > On Thu, 20 Feb 2020, Bernd Edlinger wrote: > >> Hi, >> >> this is the remaining issue that happens when -flto and -save-temps >> is used together, it leaks several files in /tmp. >> >> I try to give more background to how these temp files are >> created,

Re: [PATCH] tree-optimization/93586 - bogus path-based disambiguation

> This fixes bogus path-based disambiguation of mismatched array shape > accesses. > > Bootstrap & regtest running on x86_64-unknown-linux-gnu. > > Honza, is this the correct place to detect this or were we not > supposed to arrive there? > > Thanks, > Richard. > > 2020-02-17 Richard Biener

Re: [PATCH] Fix -save-temp leaking lto files in /tmp

Hi Bernd, hi all, note that you can get even more files: If you do offloading, LTO is additionally run for each offloading target (there can be more than one), cf. https://gcc.gnu.org/wiki/Offloading Some of those files are probably also from mkoffload etc. See below. On 2/20/20 4:33 PM, Bernd

[GCC][PATCH][ARM] Add multilib mapping for Armv8.1-M+MVE with -mfloat-abi=hard

Hi, This patch adds a new multilib for armv8.1-m.main+mve with hard float abi. For armv8.1-m.main+mve soft and softfp, the v8-M multilibs will be reused. The following mappings are also updated: "-mfloat-abi=hard -march=armv8.1-m.main+mve.fp -> armv8-m.main+fp/hard" "-mfloat-abi=softfp -march=armv

Re: [PATCH v3] c++: Fix value-init crash in template [PR93676]

On Thu, Feb 20, 2020 at 12:13:07AM +, Jason Merrill wrote: > On 2/19/20 10:15 PM, Marek Polacek wrote: > > On Fri, Feb 14, 2020 at 12:24:30AM +0100, Jason Merrill wrote: > > > On 2/11/20 8:54 PM, Marek Polacek wrote: > > > > Since we >

Re: [RFC PATCH v0] PPC64: Implement POWER Architecure Vector Function ABI.

‐‐‐ Original Message ‐‐‐ On Wednesday, February 19, 2020 5:52 PM, Joseph Myers wrote: > On Wed, 19 Feb 2020, GT wrote: > > > 1. In the Vector Function ABI document, under section "Vector Function > > Name Mangling", state that all vector variants will be created by > > the co

Re: [RFC PATCH v0] PPC64: Implement POWER Architecure Vector Function ABI.

On Thu, 20 Feb 2020, GT wrote: > What more needs to be done other than documenting the GLIBC and GCC > versions for which 'b' and 'c' vector versions are available? It is how > x86_64 explained the differences between Examples 1 and 2 at > https://sourceware.org/glibc/wiki/libmvec This is abou

[PATCH] libstdc++: Fix capturing of lvalue references in_RangeAdaptor::operator()

This fixes a dangling-reference issue with views::split and other multi-argument adaptors that may take its extra arguments by reference. When creating the _RangeAdaptorClosure in _RangeAdaptor::operator(), we currently capture all provided arguments by value. When we later use the _RangeAdaptorC

[patch,committed] OpenACC's tile clause fix for implicit typing (PR93825)

I committed it as simple and obvious patch, but of course I am happy for comment :-) OpenACC loop directives can have both 'collapse' and 'tile' clauses. They are resolved as follows: * gfc_resolve_oacc_blocks is called, which in turn calls resolve_oacc_loop_blocks followed by gfc_resolve_block

Re: [PATCH] rs6000: Fix infinite loop building ghostscript and icu [PR93658]

On 2/20/20 1:47 AM, Segher Boessenkool wrote: > On Wed, Feb 19, 2020 at 09:17:26PM -0600, Peter Bergner wrote: >> This passed bootstrap and regtesting on powerpc64le-linux and powerpc64-linux >> (in both 32-bit and 64-bit modes) with no regressions. Ok for trunk? >> The same bug exists in FSF 9 an

Re: [PATCH 2/2] libstdc++: P1739R4 Avoid template bloat for safe_ranges in combination with ...

On Thu, 20 Feb 2020, Jonathan Wakely wrote: > On 19/02/20 23:53 -0500, Patrick Palka wrote: > > ... 'subrange-y' view adaptors > > > > This implements an interpretation of P1739R4. It's only an "interpretation" > > becuase AFAICT there is an issue with the paper's wording as-is. So this > > pat

Re: [PATCH 1/2] libstdc++: Forward second argument of views::iota using the correct type

On Thu, 20 Feb 2020, Jonathan Wakely wrote: > On 19/02/20 23:53 -0500, Patrick Palka wrote: > > We are forwarding the second argument of views::iota using the wrong type, > > causing compiling errors when calling it with a value and bound of different > > types, like in the test case below. > > G

Re: [PATCH] libstdc++: Fix capturing of lvalue references in_RangeAdaptor::operator()

On 20/02/20 12:19 -0500, Patrick Palka wrote: This fixes a dangling-reference issue with views::split and other multi-argument adaptors that may take its extra arguments by reference. When creating the _RangeAdaptorClosure in _RangeAdaptor::operator(), we currently capture all provided arguments

Re: [PATCH 1/2] libstdc++: Forward second argument of views::iota using the correct type

On 20/02/20 12:52 -0500, Patrick Palka wrote: On Thu, 20 Feb 2020, Jonathan Wakely wrote: On 19/02/20 23:53 -0500, Patrick Palka wrote: > We are forwarding the second argument of views::iota using the wrong type, > causing compiling errors when calling it with a value and bound of different > t

Re: [RFC PATCH v0] PPC64: Implement POWER Architecure Vector Function ABI.

‐‐‐ Original Message ‐‐‐ On Wednesday, February 19, 2020 12:33 PM, Bill Schmidt wrote: > > The reason 'c' was added to the ABI is this mailing list discussion: > > https://sourceware.org/ml/libc-alpha/2019-11/msg00765.html > > As long as 'b' specifies that the VSX functionality is that s

Re: [PATCH] Fix -save-temp leaking lto files in /tmp

Hi Tobias, On 2/20/20 5:09 PM, Tobias Burnus wrote: > Hi Bernd, hi all, > > note that you can get even more files: If you do offloading, > LTO is additionally run for each offloading target (there > can be more than one), cf. https://gcc.gnu.org/wiki/Offloading > > Some of those files are probab

[committed] i386: Fix *vec_extractv2sf_1 and *vec_extractv2sf_1 shufps alternative [PR93828]

shufps moves two of the four packed single-precision floating-point values from *destination* operand (first operand) into the low quadword of the destination operand. Match source operand to the destination. Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}. Committed to mainline.

[PING^2][PATCH] Fix documentation of -mpoke-function-name ARM option

Hello, Ping for https://gcc.gnu.org/ml/gcc-patches/2019-12/msg01081.html. Thank you, Jérémy On Sun, Dec 15, 2019 at 07:20:26PM +0100, Jérémy Lefaure wrote: > Hi! > > Since in ARM state the value of PC is the address of the current > instruction plus 8 bytes, the code inspecting the value of PC

Re: [PATCH] avoid issuing -Wredundant-tags in shared C/C++ code in headers (PR 93804)

On 2/19/20 5:09 PM, Jason Merrill wrote: On 2/19/20 1:02 AM, Martin Sebor wrote: PR 93804 points out that issuing -Wredundant-tags for declarations in C headers included in C++ isn't helpful because the tags cannot be removed without breaking C programs that depend on the headers. Attached is a

[PATCH] c++: Some improvements to concept diagnostics

This patch improves our concept diagnostics in two ways. First, it sets a more precise location for the constraint expressions built in finish_constraint_binary_op. As a result, when a disjunction is unsatisfied we now print e.g. .../include/bits/range_access.h:467:2: note: neither operand of th

[fixinc] Allow CONFIG_SHELL to override build-time shell in mkheaders

mkheaders.in uses substitutions of @SHELL@ to run fixinc.sh and mkinstalldirs. Problem is, SHELL comes from CONFIG_SHELL for the build system, and it needs not match whatever is available at an unrelated host system after installation, when mkheaders is supposed to be run. I considered ditching t

Re: [PATCH] MAINTAINERS: Change to my personal email address

On Tue, 29 Oct 2019 21:40:09 PDT (-0700), Palmer Dabbelt wrote: I'm leaving SiFive in a bit less than two weeks, which means I'll be losing my @sifive email address. I don't have my new email address yet, so I'm switching over to my personal address instead. 2019-10-29 Palmer Dabbelt

Re: [PATCH] Fix -save-temp leaking lto files in /tmp

On Thu, 20 Feb 2020, Bernd Edlinger wrote: > On 2/20/20 2:34 PM, Richard Biener wrote: > > On Thu, 20 Feb 2020, Bernd Edlinger wrote: > > > >> Hi, > >> > >> this is the remaining issue that happens when -flto and -save-temps > >> is used together, it leaks several files in /tmp. > >> > >> I try t