Re: [Patch] PR 92463 - Cleanups due to minimum MPFR version bump to 3.1.0

On Tue, Nov 26, 2019 at 11:42 PM Tobias Burnus wrote: > > Recently, Janne bumped the minimal MPFR version from 2.4 to 3.1. As a > follow-up cleanup, the mp_ data types can now be changed to mpfr_ and > GMP_RNDx rounding to MPFR_RNDx (with an additional MPFR_RNDA). > > This patch changes the types

Re: [PATCH v2] Add inline growth bias param

On Mon, Nov 25, 2019 at 1:44 PM Graham Markall wrote: > > Hi Richard, > > Many thanks for the suggestion of an alternative implementation. I tried > implementing the suggestion, and I had a couple of observations: > > 1. As well as applying the bias in compute_fn_summary, it seemed to also > be ne

Re: [PATCH v2] Add inline growth bias param

> > 2. The results that it produced were exactly the same as those using the > > param uninlined-function-insns, so it would probably be redundant to add > > the additional parameter implemented this way. > > > > The implementation I tried is at: > > https://github.com/gmarkall/gcc/commit/1d22f65b8

Re: [Patch, gcc-wwdocs] Update to Fortran changes

On 11/27/19 8:58 AM, Janne Blomqvist wrote: On Tue, Nov 26, 2019 at 1:12 PM Tobias Burnus wrote: AUTOMATIC attribute Speaking of which, to avoid confusion maybe we should rename the -f[no-]automatic option to something like -f[no-]save, since the Fortran standard description of an "automatic d

Re: Add a new combine pass

On Tue, Nov 26, 2019 at 2:42 AM Segher Boessenkool wrote: > > On Mon, Nov 25, 2019 at 11:08:47PM +, Richard Sandiford wrote: > > Segher Boessenkool writes: > > > On Mon, Nov 25, 2019 at 09:16:52PM +, Richard Sandiford wrote: > > >> Segher Boessenkool writes: > > >> > I am wondering the o

Re: [Patch, gcc-wwdocs] Update to Fortran changes

On Wed, Nov 27, 2019 at 10:29 AM Tobias Burnus wrote: > > On 11/27/19 8:58 AM, Janne Blomqvist wrote: > > On Tue, Nov 26, 2019 at 1:12 PM Tobias Burnus > > wrote: > >> AUTOMATIC attribute > > Speaking of which, to avoid confusion maybe we should rename the > > -f[no-]automatic option to somethin

Re: Ping: RFA: patch to fix PR90007

On Tue, Nov 26, 2019 at 3:57 PM Vladimir Makarov wrote: > > This is the patch removing discrepancy between recog and LRA insn > recognition: > > https://gcc.gnu.org/ml/gcc-patches/2019-11/msg01842.html OK.

Re: [PATCH 2/4] The main m68k cc0 conversion

On Wed, Nov 27, 2019 at 12:18 AM Joseph Myers wrote: > > On Tue, 26 Nov 2019, Bernd Schmidt wrote: > > > On 11/26/19 3:21 AM, Joseph Myers wrote: > > > > > > The soft-float ColdFire build (--with-arch=cf --with-cpu=54455 > > > --disable-multilib) successfully built libgcc and glibc, but ran into a

Re: [Patch] PR 92463 - Cleanups due to minimum MPFR version bump to 3.1.0

On Tue, Nov 26, 2019 at 10:43 PM Tobias Burnus wrote: > > Recently, Janne bumped the minimal MPFR version from 2.4 to 3.1. As a > follow-up cleanup, the mp_ data types can now be changed to mpfr_ and > GMP_RNDx rounding to MPFR_RNDx (with an additional MPFR_RNDA). > > This patch changes the types

Re: [Patch, gcc-wwdocs] Update to Fortran changes

On 11/26/19 7:33 PM, Mark Eggleston wrote: htdocs/gcc-10/changes.html | 41 + + +Default fields widths can be used for I, F +and G format specifiers when excplicit widths are omitted. +Use the option -fdec-format-defaults, th

Re: [PATCH] Fix gen_lowpart_for_combine (PR rtl-optimization/92510)

On Tue, Nov 26, 2019 at 07:20:43PM -0600, Segher Boessenkool wrote: > Hi! > > On Wed, Nov 27, 2019 at 12:51:35AM +0100, Jakub Jelinek wrote: > > As mentioned in the PR, on the following testcase we ICE during combine. > > We have (subreg:V1DI (ne:DI (reg:CC flags) (const_int 0)) 0) and > > A subr

[PATCH] [dlang/phobos] S/390: Fix PR91628

Hi, in order to not use a glibc-internal symbol anymore, this patch adds separate .S files for s390x and s390 that allow to obtain the tls offset. I bootstrapped on s390x -m64 and -m31 and test on s390x, s390 seeing no new regressions. Regards Robin -- libphobos/ChangeLog: 2019-11-27 Robin

Re: [PATCH] Fix spread simplification in initializers (PR fortran/91944)

On 11/27/19 12:58 AM, Jakub Jelinek wrote: The following testcase started ICEing with my r241630 PR78026 fix. Before we created a new namespace and the check gfc_simplify_spread did happened to work during that, but it doesn't anymore. I believe gfc_init_expr_flag is the right flag to use when ch

Re: Add a new combine pass

Richard Biener writes: > On Tue, Nov 26, 2019 at 2:42 AM Segher Boessenkool > wrote: >> >> On Mon, Nov 25, 2019 at 11:08:47PM +, Richard Sandiford wrote: >> > Segher Boessenkool writes: >> > > On Mon, Nov 25, 2019 at 09:16:52PM +, Richard Sandiford wrote: >> > >> Segher Boessenkool writ

Re: [PATCH] Fix TYPO of avx512f_maskcmp3.

On Wed, Nov 27, 2019 at 11:32:24AM +0800, Hongtao Liu wrote: > hi jakub: > VF is used for differentiating AVX512F/AVX/SSE, but there's > condition TARGET_AVX512F in avx512f_maskcmp3, it must be a TYPO > and should be VF_AVX512VL instead. > > Bootstrap and regression test on i386/x86_64 backend i

Re: [PATCH] [dlang/phobos] S/390: Fix PR91628

‐‐‐ Original Message ‐‐‐ On Wednesday, 27 November 2019 10:33, Robin Dapp wrote: > Hi, > > in order to not use a glibc-internal symbol anymore, this patch adds > separate .S files for s390x and s390 that allow to obtain the tls offset. > > I bootstrapped on s390x -m64 and -m31 and test on

[PATCH] Fix PR92690

The following fixes wrong-code introduced by vector CTOR with-constants optimization into a convert and shuffle. The fix is to make sure to only convert a vector containing only the final elements, not one with unrelated ones. Code generation is slightly less optimal then with _2 = BIT_FIEL

[PATCH] Remove unused TARGET_VECTORIZE_BUILTIN_CONVERSION

All conversions go via standard optabs now. Bootstrap running on x86_64-unknown-linux-gnu. Richard. 2019-11-27 Richard Biener * target.def (TARGET_VECTORIZE_BUILTIN_CONVERSION): Remove. * targhooks.c (default_builtin_vectorized_conversion): Likewise. * targhooks.h (

Re: [PATCH][_GLIBCXX_DEBUG] Improve valid_range check

On 27/11/19 06:37 +0100, François Dumont wrote: On 11/26/19 10:52 PM, Jonathan Wakely wrote: On 26/11/19 20:07 +0100, François Dumont wrote: Sure, I am about to do so. However I wasn't sure about this syntax before the commit so I had run the new 2_neg.cc with: make CXXFLAGS=-std=c++98 chec

Re: Properly handle C2x attributes on types

Hi Joseph, > On Mon, 25 Nov 2019, Rainer Orth wrote: > >> it seems you missed updating a couple of testcases that are ia32-only: > > I think it's unavoidable that such target-specific testcases need updating > by someone testing on the target in question. like so? Tested on i386-pc-solaris2.11.

Re: Prevent all uses of DFP when unsupported (PR c/91985)

Hi Jonathan, > On 26/11/19 00:57 +, Joseph Myers wrote: >>On Mon, 25 Nov 2019, Rainer Orth wrote: >> >>> and a few more, all DFP related. They used to be emitted by g++ for >>> __fundamental_type_info in libsupc++/fundamental_type_info.cc and lived >>> in the CXXABI_1.3.4 version. However, s

Re: [PATCH] Remove unused TARGET_VECTORIZE_BUILTIN_CONVERSION

On Wed, 27 Nov 2019, Richard Biener wrote: > > All conversions go via standard optabs now. > > Bootstrap running on x86_64-unknown-linux-gnu. I applied the more complete patch below. Richard. 2019-11-27 Richard Biener * target.def (TARGET_VECTORIZE_BUILTIN_CONVERSION): Remove.

Re: [PATCH] [dlang/phobos] S/390: Fix PR91628

Hi Iain, > OK from me, what about earlier comments of using __asm__ in a C > source file? I don't mind too much either way but I gathered from the discussion in the bugzilla that .S was preferred for now. Regards Robin

[PATCH] Translate header for -fdbg-cnt-list.

Hi. The patch is about translation of titles in -fdbg-cnt-list table. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: 2019-11-27 Martin Liska PR debug/46558 * dbgcnt.c (dbg_cnt_list_all_counters):

Re: [PATCH 2/4] MSP430: Disable exception handling by default for C++

On Tue, 12 Nov 2019 21:08:48 + Richard Sandiford wrote: > Jozef Lawrynowicz writes: > > diff --git a/gcc/testsuite/lib/gcc-dg.exp b/gcc/testsuite/lib/gcc-dg.exp > > index 1df645e283c..1ce449cb935 100644 > > --- a/gcc/testsuite/lib/gcc-dg.exp > > +++ b/gcc/testsuite/lib/gcc-dg.exp > > @@ -417

Re: [PATCH, GCC, AArch64] Fix PR88398 for AArch64

Hi Richard, >> Yes so it does the insane "fully unrolled trailing loop before the unrolled >> loop" thing. One always does the trailing loop last (and typically as an >> actual loop of course) and then the code ends up much faster, close to >> the ideal version shown in the PR. > > Well, you can't

Re: [Patch, gcc-wwdocs] Update to Fortran changes

Corrected and committed. On 27/11/2019 09:00, Tobias Burnus wrote: On 11/26/19 7:33 PM, Mark Eggleston wrote:   htdocs/gcc-10/changes.html | 41 + +  +    Default fields widths can be used for I, F +    and G format specifiers when excplici

[PATCH] Properly use TYPE_MAIN_VARIANT in warn_types_mismatch.

Hi. The patch is attempt to fix ICE which I see in ODR violation warning. I think the proper fix is to use TYPE_MAIN_VARIANT(t1) instead of t1 in the problematic condition. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLo

Re: Ping: RFA: patch to fix PR90007

On 2019-11-27 3:31 a.m., Richard Biener wrote: On Tue, Nov 26, 2019 at 3:57 PM Vladimir Makarov wrote: This is the patch removing discrepancy between recog and LRA insn recognition: https://gcc.gnu.org/ml/gcc-patches/2019-11/msg01842.html OK. Thank you, Richard.  Committed as r278770.

Re: [PATCH] Support multi-versioning on self-recursive function (ipa/92133)

> 2019-11-15 Feng Xue > > PR ipa/92133 > * doc/invoke.texi (ipa-cp-max-recursive-depth): Document new option. > (ipa-cp-min-recursive-probability): Likewise. > * params.opt (ipa-cp-max-recursive-depth): New. > (ipa-cp-min-recursive-probability): Likewise.

Re: [PATCH] Prevent recursive satisfaction (PR c++/88395)

> > + if (tmpl) > > + push_tinst_level (tmpl); > > Actually, why not pass 't' here? I thought it would matter if 't' was a non-template. Turns out it doesn't. Updated and committed.

[PATCH] Check for TYPE_NAME in type_with_linkage_p.

Hi. This one another IPA devirt ICE fix where we can end up with a local array that has not TYPE_NAME. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: 2019-11-27 Martin Liska PR lto/91574 * ipa-dev

Re: [PATCH] Check for TYPE_NAME in type_with_linkage_p.

> Hi. > > This one another IPA devirt ICE fix where we can end up > with a local array that has not TYPE_NAME. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > Martin > > gcc/ChangeLog: > > 2019-11-27 Martin Liska > > P

Re: [PATCH] Properly use TYPE_MAIN_VARIANT in warn_types_mismatch.

> Hi. > > The patch is attempt to fix ICE which I see in ODR violation warning. > I think the proper fix is to use TYPE_MAIN_VARIANT(t1) instead of t1 > in the problematic condition. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, >

Re: [Patch, gcc-wwdocs] Update to Fortran changes

On 27/11/2019 08:29, Tobias Burnus wrote: On 11/27/19 8:58 AM, Janne Blomqvist wrote: On Tue, Nov 26, 2019 at 1:12 PM Tobias Burnus wrote: AUTOMATIC attribute Speaking of which, to avoid confusion maybe we should rename the -f[no-]automatic option to something like -f[no-]save, since the Fo

Re: [PATCH] Reformat PowerPC movsi_internal

Hi Mike, On Tue, Nov 26, 2019 at 08:32:12PM -0500, Michael Meissner wrote: > As we discussed in the V6 patches #1 and #2, before submitting the patches > adding eI support for movdi and movsi, you prefered that I reformat the > patches > to make them easier in the future to identify the changes.

Re: Prevent all uses of DFP when unsupported (PR c/91985)

On Wed, 27 Nov 2019, Rainer Orth wrote: > Hi Jonathan, > > > On 26/11/19 00:57 +, Joseph Myers wrote: > >>On Mon, 25 Nov 2019, Rainer Orth wrote: > >> > >>> and a few more, all DFP related. They used to be emitted by g++ for > >>> __fundamental_type_info in libsupc++/fundamental_type_info.cc

Re: [PATCH] Translate header for -fdbg-cnt-list.

On Wed, 27 Nov 2019, Martin Liška wrote: > Hi. > > The patch is about translation of titles in -fdbg-cnt-list table. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? OK. -- Joseph S. Myers jos...@codesourcery.com

Re: [patch, libgomp] Add tests for print from offload target

Hi! On 2019-11-14T18:22:39+0100, Jakub Jelinek wrote: > On Thu, Nov 14, 2019 at 05:18:41PM +, Andrew Stubbs wrote: >> On 14/11/2019 17:05, Jakub Jelinek wrote: >> > On Thu, Nov 14, 2019 at 04:47:49PM +, Andrew Stubbs wrote: >> > > This patch adds new libgomp tests to ensure that C "printf

Re: Prevent all uses of DFP when unsupported (PR c/91985)

On Wed, Nov 27, 2019 at 05:48:21PM +, Joseph Myers wrote: > > > On 26/11/19 00:57 +, Joseph Myers wrote: > > >>On Mon, 25 Nov 2019, Rainer Orth wrote: > > >> > > >>> and a few more, all DFP related. They used to be emitted by g++ for > > >>> __fundamental_type_info in libsupc++/fundamental

Re: [PATCH] Reformat PowerPC movdi_internal64

Hi! On Tue, Nov 26, 2019 at 08:33:34PM -0500, Michael Meissner wrote: > This patch changes just the movdi_internal64 insn. All of the same comments as for the movsi patch. Also: > -;; GPR store GPR load GPR move GPR li GPR lis GPR # > -;; FPR store FPR lo

Re: [PATCH, rs6000] Fix PR92566 by checking VECTOR_UNIT_NONE_P

On Wed, Nov 27, 2019 at 02:01:05PM +0800, Kewen.Lin wrote: > As Segher pointed out in PR92566, we shouldn't offer some vector modes which > aren't supported under current setting. This patch is to make it check by > VECTOR_UNIT_NONE_P which is initialized as current architecture masks. > > Bootst

Re: [PATCH] [rs6000] Fix PR92098

Hi! On Wed, Nov 27, 2019 at 12:31:30AM -0600, Li Jia He wrote: > In order to fix PR92098, we need to define vec_cmp_* and vcond_mask_*. In > fact, > PR92132 already fixed the issue on the trunk. We need to backport PR92132 int > part to gcc-9-branch. (Part of that patch). > 2019-11-27 Li Jia

[analyzer] Introduce point_and_state::validate

This patch adds various validate functions to assert that the internal state of the analyzer is consistent. In particular, it asserts that the call_string in the program_point agrees with the stack_region in the region_model (in terms of the stack depth, and which function is at each depth). Doin

[PING] Re: [PATCH 2/2][MIPS][RFC] Emit .note.GNU-stack for hard-float linux targets.

On 07.11.2019. 18:05, Dragan Mladjenovic wrote: > On 01.11.2019. 11:32, Dragan Mladjenovic wrote: >> On 10.08.2019. 00:15, Joseph Myers wrote: >>> On Fri, 9 Aug 2019, Jeff Law wrote: >>> > 2019-08-05 Dragan Mladjenovic > > * config.in: Regenerated. > * config/mips/linux.h

Re: C++ PATCH for c++/91363 - P0960R3: Parenthesized initialization of aggregates

On Wed, Nov 20, 2019 at 08:11:27PM -0500, Jason Merrill wrote: > On 11/20/19 8:37 PM, Marek Polacek wrote: > > On Tue, Nov 19, 2019 at 05:33:09PM -0500, Jason Merrill wrote: > > > On 11/19/19 1:44 AM, Marek Polacek wrote: > > > > > It also looks like you're using the LOOKUP flag to mean two differe

Re: [PATCH] Fix gen_lowpart_for_combine (PR rtl-optimization/92510)

On Wed, Nov 27, 2019 at 10:03:10AM +0100, Jakub Jelinek wrote: > and it is just combine subst + simplification that turns it into > ... (subreg:DI (subreg:V1DI (ne:DI (reg:CCZ 17 flags) (const_int 0 [0])) 0) > 0) ... > The restriction that subreg must be of a reg or mem certainly isn't honored > i

Re: Add a new combine pass

On Wed, Nov 27, 2019 at 09:29:27AM +0100, Richard Biener wrote: > On Tue, Nov 26, 2019 at 2:42 AM Segher Boessenkool > wrote: > > combine actually *calculates* DU chains almost completely, it just throws > > away most of that information (it wants to have LOG_LINKS, as it did ages > > ago). The o

Re: [C++ PATCH] c++/91353 - P1331R2: Allow trivial default init in constexpr contexts.

On Sun, Nov 24, 2019 at 12:24:48PM -0500, Jason Merrill wrote: > On 11/16/19 5:23 PM, Marek Polacek wrote: > > [ Working virtually on Baker Island. ] > > > > This patch implements C++20 P1331, allowing trivial default initialization > > in > > constexpr contexts. > > > > I used Jakub's patch fro

[PATCH v2][MSP430] -Add fno-exceptions multilib

Original patch here: https://gcc.gnu.org/ml/gcc-patches/2019-11/msg00619.html Late for stage 1 I know, but it's an iteration on a patch submitted before the transition to stage 3 and the functional changes to the compiler are constrained to the msp430 target. The code size bloat added by building

[PATCH] rs6000: Fix PR92661, Do not define DFP builtin functions, if DFP has been disabled

This patch fixes the bootstrap breakage in the rs6000 port caused by the recent patch from Joseph that disables adding the _Decimal* types when DFP has been disabled. It's based on Joseph's suggestion from the bugzilla. This passed bootstrap and regtesting on powerpc64*-linux and Iain confirmed t

[C++ PATCH] More fun with typedef to dependent alias.

rsandifo's patch for 92206 demonstrated a problem with the existing checking for alias template specializations: they were returning false for a typedef to an alias template specialization. Which is sometimes what the caller wants, and sometimes not: Sometimes we're interested in whether the type

Re: [C++ PATCH] c++/91353 - P1331R2: Allow trivial default init in constexpr contexts.

On 11/27/19 2:36 PM, Marek Polacek wrote: On Sun, Nov 24, 2019 at 12:24:48PM -0500, Jason Merrill wrote: On 11/16/19 5:23 PM, Marek Polacek wrote: [ Working virtually on Baker Island. ] This patch implements C++20 P1331, allowing trivial default initialization in constexpr contexts. I used Ja

Re: Prevent all uses of DFP when unsupported (PR c/91985)

Hi! Re , which reports (and I hereby confirm) that these changes quoted below introduce "lto1: internal compiler error" for (at least) nvptx offloading, and such a backtrace seemed vaguely familiar, and I did remember having fixed a similar is

Re: C++ PATCH for c++/91363 - P0960R3: Parenthesized initialization of aggregates

On 11/27/19 1:58 PM, Marek Polacek wrote: On Wed, Nov 20, 2019 at 08:11:27PM -0500, Jason Merrill wrote: On 11/20/19 8:37 PM, Marek Polacek wrote: On Tue, Nov 19, 2019 at 05:33:09PM -0500, Jason Merrill wrote: On 11/19/19 1:44 AM, Marek Polacek wrote: It also looks like you're using the LOOKU

Re: [C++ PATCH] Implement C++20 P1814R0, CTAD for alias templates.

On 11/16/19 5:51 PM, Jason Merrill wrote: This patch implements C++20 class template argument deduction for alias templates, which works by a moderately arcane transformation of the deduction guides for the underlying class template.  When implementing it, I found that I could simplify the rule

Re: C++ PATCH for c++/91363 - P0960R3: Parenthesized initialization of aggregates

On Wed, Nov 27, 2019 at 04:54:55PM -0500, Jason Merrill wrote: > > > > @@ -921,8 +921,20 @@ perform_member_init (tree member, tree init) > > > > inform (DECL_SOURCE_LOCATION (member), > > > > "%q#D should be initialized", member ); > > > > } > > >

Re: Prevent all uses of DFP when unsupported (PR c/91985)

On Wed, 27 Nov 2019, Thomas Schwinge wrote: > If I turn that conditional cited above into 'if (1)', then nvptx > offloading testing seems to return to normality, but I have not yet > assessed whether that has any ill effects on decimal float types support, > and/or how this should be fixed properl

[wwwdocs] Make the formatting of the tag and block more uniform.

This is not a functional change at all (or at least should not be). Rather this will ease automatic processing as we include even more of what is currently coming from style.mhtml and reduce the chance of missing some files or changes over time. Committed. Gerald commit cfa6e237e33dfad556618

[analyzer] Convert from "--analyzer" to "-fanalyzer"/"-fno-analyzer"

This patch updates the command-line option used to enable the analyzer from "--analyzer" to "-fanalyzer" (--analyzer is still accepted, via the map from prefix "--" to "-f" in option_map in opts-common.c) The patch also adds support for -fno-analyzer: given uses of -fno-analyzer and -fanalyzer, th

[PATCH] Fix ICE in tree-ssa-strlen.c (PR tree-optimization/92691)

Hi! The various routines propagate to the caller whether if (check_and_optimize_stmt (&gsi, &cleanup_eh, evrp.get_vr_values ())) gsi_next (&gsi); should do gsi_next or not (return false if e.g. gsi_remove is done, thus gsi is already moved to the next stmt). handle_printf_call return

Re: [C++ PATCH] c++/91353 - P1331R2: Allow trivial default init in constexpr contexts.

On Wed, Nov 27, 2019 at 04:47:01PM -0500, Jason Merrill wrote: > On 11/27/19 2:36 PM, Marek Polacek wrote: > > On Sun, Nov 24, 2019 at 12:24:48PM -0500, Jason Merrill wrote: > > > On 11/16/19 5:23 PM, Marek Polacek wrote: > > > > [ Working virtually on Baker Island. ] > > > > > > > > This patch im

[C++ PATCH] Fix up constexpr virtual calls (PR c++/92695)

Hi! The OBJ_TYPE_REF constexpr handling looks through DECL_FIELD_IS_BASE COMPONENT_REFs to find the actual object on which the method is called, but as the following testcase shows, we need to do the similar thing also for the argument passed as this, because cxx_eval_indirect_ref otherwise fails

[C++ PATCH] Avoid weird warning about pure virtual inline being used but not defined (PR c++/92695)

Hi! While working on the PR92695 bug, I've noticed a weird warning, when the testcase contained (pointless, but not invalid) constexpr specifier on pure virtual function. constexpr implies DECL_DECLARED_INLINE_P and we would note_vague_linkage_fn and later complain that the inline function wasn't

[C++ PATCH] Fix OBJ_TYPE_REF constexpr handling (PR c++/92695)

Hi! On the following testcase the constexpr evaluation of the virtual call fails, because what cxx_eval_constant_expression returns for OBJ_TYPE_REF_OBJECT is actually not ADDR_EXPR, but ADDR_EXPR wrapped in a NOP_EXPR. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for t

Re: [C++ PATCH] Fix OBJ_TYPE_REF constexpr handling (PR c++/92695)

On Thu, Nov 28, 2019 at 12:44:43AM +0100, Jakub Jelinek wrote: > Hi! > > On the following testcase the constexpr evaluation of the virtual call > fails, because what cxx_eval_constant_expression returns for > OBJ_TYPE_REF_OBJECT is actually not ADDR_EXPR, but ADDR_EXPR wrapped in > a NOP_EXPR. >

Re: [PATCH] Reformat PowerPC movsi_internal

Here is the patch that I committed for movsi_internal: 2019-11-27 Michael Meissner * config/rs6000/rs6000.md (movsi_internal): Reformat. Index: gcc/config/rs6000/rs6000.md === --- gcc/config/rs6000/rs6000.md (revision 278

Re: [PATCH] Reformat PowerPC movdi_internal64

Here is the patch I committed for movdi_internal64: 2019-11-27 Michael Meissner * config/rs6000/rs6000.md (movdi_internal64): Reformat. Index: gcc/config/rs6000/rs6000.md === --- gcc/config/rs6000/rs6000.md (revision 2787

Re: Autoinc vs reload and LRA

On Mon, Nov 25, 2019 at 09:22:55PM +0100, Bernd Schmidt wrote: > So I was curious what would happen if I turned on LRA for m68k. It turns > out my autoinc patches from the cc0 patch set expose a bug in how LRA > handles autoincrement. While it copies the logic from reload's > inc_for_reload, it app

Ping: [PATCH] Add explicit description for -finline

On 2019/11/4 11:42, luoxhu wrote: On 2019/11/2 00:23, Joseph Myers wrote: On Thu, 31 Oct 2019, Xiong Hu Luo wrote: +@code{-finline} enables inlining of function declared \"inline\". +@code{-finline} is enabled at levels -O1, -O2, -O3 and -Os, but not -Og. Use @option{} to mark up option n

Re: [PATCH] Support multi-versioning on self-recursive function (ipa/92133)

Have no a complete idea for new cost model, but there are something we can try: o. adjust estimated profile for recursive function so that we can get a higher threshold. o. introduce a strength level for ipa-cp-clone, by default, it is same as current configuration, and with larger number, ipa-

Re: [C++ PATCH] c++/91353 - P1331R2: Allow trivial default init in constexpr contexts.

On 11/27/19 6:35 PM, Marek Polacek wrote: On Wed, Nov 27, 2019 at 04:47:01PM -0500, Jason Merrill wrote: On 11/27/19 2:36 PM, Marek Polacek wrote: On Sun, Nov 24, 2019 at 12:24:48PM -0500, Jason Merrill wrote: On 11/16/19 5:23 PM, Marek Polacek wrote: [ Working virtually on Baker Island. ] T

Re: [C++ PATCH] Avoid weird warning about pure virtual inline being used but not defined (PR c++/92695)

On 11/27/19 6:43 PM, Jakub Jelinek wrote: Hi! While working on the PR92695 bug, I've noticed a weird warning, when the testcase contained (pointless, but not invalid) constexpr specifier on pure virtual function. constexpr implies DECL_DECLARED_INLINE_P and we would note_vague_linkage_fn and la

Re: C++ PATCH for c++/91363 - P0960R3: Parenthesized initialization of aggregates

On 11/27/19 5:25 PM, Marek Polacek wrote: On Wed, Nov 27, 2019 at 04:54:55PM -0500, Jason Merrill wrote: @@ -921,8 +921,20 @@ perform_member_init (tree member, tree init) inform (DECL_SOURCE_LOCATION (member), "%q#D should be initialized", member );