[PATCH] Fix ICE with __builtin_stack_save (PR c/90898)

2019-11-19 Thread Jakub Jelinek
Hi! I agree that we shouldn't have made __builtin_stack_{save,restore} public, but I'd fear it is too late to remove it now (and replace by internal fn), I'd think some code might use it to control when e.g. alloca will be released. As the comment on insert_clobber* says, the addition of the clob

Re: [PATCH 2/3] [ARC] Add scaled load pattern

2019-11-19 Thread Jeff Law
On 11/19/19 2:02 AM, Claudiu Zissulescu wrote: > ARC processors can use scaled addresses, i.e., the offset part of the > load address can be shifted by 2 (multiplied by 4). Add this pattern > and a test for it. > > gcc/ > -xx-xx Claudiu Zissulescu > > * config/arc/arc.md (load_scaled

Re: [PATCH] PR91195: fix -Wmaybe-uninitialized warning for conditional store optimization

2019-11-19 Thread Jakub Jelinek
On Tue, Sep 03, 2019 at 02:27:29PM -0600, Jeff Law wrote: > >> + /* The transformation below will inherently introduce a memory load, > >> + for which LHS may not be initialized yet if it is not in NOTRAP, > >> + so a -Wmaybe-uninitialized warning message could be triggered. > >> + Since

Add more pedwarns for [[]] C attributes on types

2019-11-19 Thread Joseph Myers
The standard [[]] attributes currently defined in C2x are all not valid on types not being defined at the time. Use on such types results in a warning from attribs.c about attributes appertaining to types (the warning that I think is bogus in general for both C and C++, applying as it does to all

Add release notes for new C2X features in GCC 10

2019-11-19 Thread Joseph Myers
I've committed this patch to add release notes for new C2X features in GCC 10. diff --git a/htdocs/gcc-10/changes.html b/htdocs/gcc-10/changes.html index 1e9c3f8d..52eb303c 100644 --- a/htdocs/gcc-10/changes.html +++ b/htdocs/gcc-10/changes.html @@ -63,6 +63,44 @@ a work-in-progress. +C + +

[PATCH v3] libgomp/test: Add flags to find libatomic in build-tree testing

2019-11-19 Thread Maciej W. Rozycki
Add flags to find libatomic in build-tree testing, fixing a catastrophic libgomp testsuite failure with `riscv*-*-linux*' targets, which imply `-latomic' with the `-pthread' GCC option, implied in turn by the `-fopenacc' and `-fopenmp' options, removing failures like: .../bin/riscv64-linux-gnu-

Re: [PATCH] PR91195: fix -Wmaybe-uninitialized warning for conditional store optimization

2019-11-19 Thread Jeff Law
On 11/19/19 5:03 PM, Jakub Jelinek wrote: > On Tue, Sep 03, 2019 at 02:27:29PM -0600, Jeff Law wrote: + /* The transformation below will inherently introduce a memory load, + for which LHS may not be initialized yet if it is not in NOTRAP, + so a -Wmaybe-uninitialized warnin

Re: [PATCH] Fix ICE with __builtin_stack_save (PR c/90898)

2019-11-19 Thread Jeff Law
On 11/19/19 4:58 PM, Jakub Jelinek wrote: > Hi! > > I agree that we shouldn't have made __builtin_stack_{save,restore} public, > but I'd fear it is too late to remove it now (and replace by internal fn), > I'd think some code might use it to control when e.g. alloca will be > released. As the com

Re: [PATCH] Fix ICE during MEM_REF expansion (PR middle-end/90840)

2019-11-19 Thread Jeff Law
On 11/19/19 4:42 PM, Jakub Jelinek wrote: > Hi! > > On the following testcase we ICE on i686-linux (32-bit), because we store > (first 96-bit, then 72-bit) structure into the first part of a 2x 96-bit > complex long double, and for 96-bit floats there is no corresponding > integral mode that cover

Re: [PATCH v2] Add `--with-install-sysroot=' configuration option

2019-11-19 Thread Maciej W. Rozycki
On Tue, 19 Nov 2019, Joseph Myers wrote: > > > 4. How does this interact with sysroot suffixes (again, this should be > > > made clear in the documentation)? > > > > There is no interaction, the patch merely changes where the libraries are > > installed. If the installation sysroot directory

Re: introduce -fcallgraph-info option

2019-11-19 Thread Alexandre Oliva
On Nov 6, 2019, Alexandre Oliva wrote: > (CALLEE_FROM_CGRAPH_P): New. > (dump_final_callee_vcg, dump_final_node_vcg): New. I goofed in the testing of this last-minute change. It only works with optimization disabled. With any optimization enabled, pass_remove_cgraph_callee_edges r

Re: [C++ PATCH] Fix up lambda decl specifier parsing ICE (PR c++/90842)

2019-11-19 Thread Jason Merrill
On 11/19/19 11:46 PM, Jakub Jelinek wrote: Hi! In lambdas, the only valid decl specifiers are mutable, constexpr or consteval. For various other simple specifiers it is fine to parse them and reject afterwards if the parsing is simple consuming of a single token and setting some flags, but as t

Re: [C++ PATCH] Fix weird addr_expr not supported by dump_expr messages (PR c++/90767)

2019-11-19 Thread Jason Merrill
On 11/19/19 11:38 PM, Jakub Jelinek wrote: Hi! The following patch is a minimal fix to avoid cannot convert ‘‘addr_expr’ not supported by dump_type’ to ‘X*’ and similar messages. The recently added complain_about_bad_argument function expects a from_type argument, but conv->from isn't necessari

Re: [PATCH] [MIPS] Prevent MSA branches from being put into delay slots

2019-11-19 Thread Dragan Mladjenovic
On 16.11.2019. 00:33, Jeff Law wrote: > On 11/15/19 10:27 AM, Dragan Mladjenovic wrote: >> From: "Dragan Mladjenovic" >> >> This patch tightens the instruction definitions to make sure >> that MSA branch instructions cannot be put into delay slots and have their >> delay slots eligible for

Re: [PATCH] Fix up arch= handling in x86 target attribute (PR target/90867)

2019-11-19 Thread Uros Bizjak
On Wed, Nov 20, 2019 at 12:53 AM Jakub Jelinek wrote: > > Hi! > > The arch= handling in target attribute right now clears almost all isa_flags > and all isa_flags2, so that later call to ix86_option_override_internal > can set just the isa options for the specific arch and nothing else. > Unfortun

Re: [PATCH v3] PR92398: Fix testcase failure of pr72804.c

2019-11-19 Thread luoxhu
P9LE generated instruction is not worse than P8LE. mtvsrdd;xxlnot;stxv vs. not;not;std;std. Update the test case to fix failures. v3: Define and use check_effective_target_xxx etc. pre_power8: ... power6, power7. power8: power8 only. post_power8: power8, power9 ... post_power9: power9, power10 ...

Re: [PATCH] Fix ICE during MEM_REF expansion (PR middle-end/90840)

2019-11-19 Thread Richard Biener
On Wed, 20 Nov 2019, Jakub Jelinek wrote: > Hi! > > On the following testcase we ICE on i686-linux (32-bit), because we store > (first 96-bit, then 72-bit) structure into the first part of a 2x 96-bit > complex long double, and for 96-bit floats there is no corresponding > integral mode that cove

Re: [PATCH] Fix ICE with __builtin_stack_save (PR c/90898)

2019-11-19 Thread Richard Biener
On Wed, 20 Nov 2019, Jakub Jelinek wrote: > Hi! > > I agree that we shouldn't have made __builtin_stack_{save,restore} public, > but I'd fear it is too late to remove it now (and replace by internal fn), > I'd think some code might use it to control when e.g. alloca will be > released. As the co

Re: [PATCH, rs6000] Refactor FP vector comparison operators

2019-11-19 Thread Kewen.Lin
Hi Segher, on 2019/11/20 上午1:29, Segher Boessenkool wrote: > Hi! > > On Tue, Nov 12, 2019 at 06:41:07PM +0800, Kewen.Lin wrote: >> +;; code iterators and attributes for vector FP comparison operators: >> +(define_code_iterator vector_fp_comparison_operator [lt le ne >> +

<    1   2