[PATCH][gimplefe] BIT_INSERT_EXPR support

2019-05-16 Thread Richard Biener
Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2019-05-16 Richard Biener c/ * gimple-parser.c (c_parser_gimple_statement): Handle __BIT_INSERT. (c_parser_gimple_unary_expression): Likewise. * gimple-pretty-print.c (dump_ternary_rhs):

Re: [PATCH v2 3/3] Consider doloop cmp use in ivopts

2019-05-16 Thread Richard Biener
On Wed, 15 May 2019, Segher Boessenkool wrote: > On Wed, May 15, 2019 at 10:47:31AM +0200, Richard Biener wrote: > > Ah, so the key issue is that the doloop IV is "free"? That > > is, it doesn't consume a general register and whatnot? That > > is allocating this IV doesn't really interfere with

Re: [PATCH 1/2] Add support for IVOPT

2019-05-16 Thread Richard Sandiford
Richard Sandiford writes: > kugan.vivekanandara...@linaro.org writes: >> + parts.step = wide_int_to_tree (sizetype, fact); >> + /* Addressing mode "base + index << scale". */ >> + addr = addr_for_mem_ref (&parts, as, false); >> + unsigned new_cost = address_cost (addr, mem_mod

Re: [committed] Fix up pr90478.c testcase (was Re: [PATCH] Check for overflow in tree-switch-conversion (PR middle-end/90478).)

2019-05-16 Thread Martin Liška
On 5/16/19 12:45 AM, Jakub Jelinek wrote: > Fixed thusly, tested on x86_64-linux with -m32/-m64, committed to trunk as > obvious: Thank you Jakub.

Re: [PATCH] OpenMP simd if clause support with runtime determined argument

2019-05-16 Thread Richard Biener
On Wed, 15 May 2019, Jakub Jelinek wrote: > Hi! > > The following patch implements what I've failed to do in time for 9.x, > in particular, if #pragma omp simd has if clause and the argument is > not constant zero (handled by the previous patch), or constant non-zero > (ignored, we want normal ve

[PATCH] Add myself to MAINTAINERS

2019-05-16 Thread JunMa
Already committed, as per https://www.gnu.org/software/gcc/svnwrite.html. Regards Jun 2019-05-16 Jun Ma * MAINTAINERS (Write After Approval): Add myself. diff --git a/MAINTAINERS b/MAINTAINERS index fb7fd34..7c5942a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -514,6 +514,7 @

Re: [PATCH 1/12] implement -Wformat-diag to detect quoting and spelling issues in GCC diagnostics

2019-05-16 Thread Martin Liška
On 5/16/19 12:36 AM, Martin Sebor wrote: > On 5/15/19 8:50 AM, Martin Sebor wrote: >> On 5/15/19 5:40 AM, Martin Liška wrote: >>> On 5/14/19 11:31 PM, Martin Sebor wrote: The attached patch implements the -Wformat-diag warning to help find quoting, spelling, and other formatting issues in

[PATCH] Add workaround for broken C/C++ wrappers to LAPACK (PR fortran/90329)

2019-05-16 Thread Jakub Jelinek
Hi! Fortran subroutines/functions that have CHARACTER arguments have also hidden arguments at the end of the argument list which hold the string length. This is something all Fortran compilers I've tried do and is done in order to support calling unprototyped subroutines/functions where one can't

Re: [PATCH 0/2][RFC][PR88836][AARCH64] Fix redundant ptest instruction

2019-05-16 Thread Richard Sandiford
kugan.vivekanandara...@linaro.org writes: > From: Kugan Vivekanandarajah > > Inorder to fix this PR. > * We need to change the whilelo pattern in backend > * Change RTL CSE such that: >- Add support for VEC_DUPLICATE >- When handling PARALLEL rtx in cse_insn, we kill CSE defined by all t

Re: [PATCH] OpenMP simd if clause support with runtime determined argument

2019-05-16 Thread Jakub Jelinek
On Thu, May 16, 2019 at 09:53:06AM +0200, Richard Biener wrote: > > + if (nonconst_simd_if) > > +{ > > + if (sctx.lane == NULL_TREE) > > + { > > + sctx.idx = create_tmp_var (unsigned_type_node); > > + sctx.lane = create_tmp_var (unsigned_type_node); > > + } > > Does forcing a

Re: [PATCH] S/390: Add -march to test case

2019-05-16 Thread Ilya Leoshkevich
> 2019-05-15 Robin Dapp > > * gcc.target/s390/global-array-element-pic.c: Add -march=z900. > * gcc.target/s390/global-array-element-pic2.c: New test for z10+. LGTM

Re: [PATCH] S/390: Add -march to test case

2019-05-16 Thread Andreas Krebbel
On 15.05.19 17:45, Robin Dapp wrote: > Hi, > > this patch adds -march=z900 to a test case that expects larl for loading > a value via the GOT. On z10 and later, lgrl is used which is tested in > a new test case. > > Regards > Robin > > -- > > gcc/testsuite/ChangeLog: > > 2019-05-15 Robin Da

Re: LWG2593 Move from allocator state is preserved

2019-05-16 Thread Jonathan Wakely
On 16/05/19 07:48 +0200, François Dumont wrote: Hi     Let's apply this resolution first before moving forward with the std::deque implementation.     Move from state of allocators (LWG2593)     * include/bits/stl_deque.h     (_Deque_base(_Deque_base&&, false_type)): Remove.     (_Deque_base(

[PATCH] Fix PR90502

2019-05-16 Thread Richard Biener
I forgot to update a testcase. Committed. Richard. 2019-05-16 Richard Biener PR testsuite/90502 * gcc.dg/tree-ssa/vector-6.c: Adjust for half of the transforms happening earlier now. Index: gcc/testsuite/gcc.dg/tree-ssa/vector-6.c ==

[PATCH] debug: make -feliminate-unused-debug-symbols the default [PR debug/86964]

2019-05-16 Thread Thomas De Schampheleire
From: Thomas De Schampheleire In addition to making -feliminate-unused-debug-symbols work for the DWARF format (see [1]), make this option the default. This behavior was the case before, e.g. under gcc 4.9.x. [1] https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=269925 gcc/ChangeLog: 2019-

Re: [PATCH] Add workaround for broken C/C++ wrappers to LAPACK (PR fortran/90329)

2019-05-16 Thread Richard Biener
On Thu, 16 May 2019, Jakub Jelinek wrote: > Hi! > > Fortran subroutines/functions that have CHARACTER arguments have also > hidden arguments at the end of the argument list which hold the string > length. This is something all Fortran compilers I've tried do and is > done in order to support cal

Re: [PATCH] OpenMP simd if clause support with runtime determined argument

2019-05-16 Thread Richard Biener
On Thu, 16 May 2019, Jakub Jelinek wrote: > On Thu, May 16, 2019 at 09:53:06AM +0200, Richard Biener wrote: > > > + if (nonconst_simd_if) > > > +{ > > > + if (sctx.lane == NULL_TREE) > > > + { > > > + sctx.idx = create_tmp_var (unsigned_type_node); > > > + sctx.lane = create_tmp_var

Re: [PATCH] Add workaround for broken C/C++ wrappers to LAPACK (PR fortran/90329)

2019-05-16 Thread Jakub Jelinek
On Thu, May 16, 2019 at 11:22:08AM +0200, Richard Biener wrote: > Which reminds me I forgot to update LTO_major_version on trunk - can > you do that? Done with: 2019-05-16 Jakub Jelinek * lto-streamer.h (LTO_major_version): Bump to 9. --- gcc/lto-streamer.h (revision 271283) +++ gcc

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-16 Thread Maxim Kuvyrkov
> On May 15, 2019, at 9:47 PM, Segher Boessenkool > wrote: > > On Wed, May 15, 2019 at 11:34:34AM +0300, Maxim Kuvyrkov wrote: >>> On May 15, 2019, at 12:20 AM, Segher Boessenkool >>> wrote: >>> On Tue, May 14, 2019 at 07:11:18PM +0300, Maxim Kuvyrkov wrote: This patch adds scripts to con

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-16 Thread Maxim Kuvyrkov
> On May 16, 2019, at 3:33 AM, Paul Koning wrote: > > > >> On May 15, 2019, at 2:42 PM, Eric Gallager wrote: >> >>> ... >> >> Wasn't Eric S. Raymond working on his own conversion of the GCC repo >> from SVN to Git? Whatever happened to his? > > Yes, and from what I recall he found that doin

Re: [PATCH 0/12] detect quoting and punctuation problems in diagnostics

2019-05-16 Thread Martin Liška
Hi. Maybe I've install the patches wrongly, but I see following error on ppc64le during bootstrap in stage2: /home/marxin/Programming/gcc/objdir/./prev-gcc/xg++ -B/home/marxin/Programming/gcc/objdir/./prev-gcc/ -B/usr/local/powerpc64le-unknown-linux-gnu/bin/ -nostdinc++ -B/home/marxin/Programm

Re: [PATCH] Remove redundant accessors in hash tables

2019-05-16 Thread Jonathan Wakely
On 16/05/19 07:47 +0200, François Dumont wrote: On 5/15/19 5:37 PM, Jonathan Wakely wrote: François, I noticed that _Hash_code_base and _Hashtable_base have a number of member functions which are overloaded for const and non-const:    const _Equal&    _M_eq() const { return _EqualEBO::_S_cget(*

Re: [PATCH, Darwin, PowerPC, testsuite] Exclude Darwin from VSX, Power8 and Power9 tests.

2019-05-16 Thread Iain Sandoe
Hi Segher, > On 15 May 2019, at 18:35, Iain Sandoe wrote: >> On 15 May 2019, at 18:24, Segher Boessenkool >> wrote: >> > >> On Wed, May 15, 2019 at 12:54:03PM +0100, Iain Sandoe wrote: >>> The patch augments the tests for feature support for VSX, >>> power8 and power9 to exclude Darwin eve

Re: preserve more debug stmts in gimple jump threading

2019-05-16 Thread Richard Biener
On Wed, May 15, 2019 at 11:03 PM Alexandre Oliva wrote: > > On May 15, 2019, Richard Biener wrote: > > > On Wed, May 15, 2019 at 10:20 AM Alexandre Oliva wrote: > >> > >> Gimple jump threading does not duplicate forwarder blocks that might > >> be present before or after the copied block. > > >

Re: [PATCH] Fix PR90394, [10 Regression] ICE in is_value_included_in, at tree-ssa-uninit.c:1055

2019-05-16 Thread Richard Biener
On Thu, May 16, 2019 at 1:09 AM Vladislav Ivanishin wrote: > > Hi! > > Here is a simple patch fixing the regression introduced in r270660. > > > Regtested and bootstrapped with `BOOT_CFLAGS="-O > -Wno-error=maybe-uninitialized -Wuninitialized"` on x86_64-pc-linux-gnu. > OK for trunk? OK. > It is

Re: [PATCH 1/2] Add support for IVOPT

2019-05-16 Thread Richard Biener
On Wed, May 15, 2019 at 4:40 AM wrote: > > From: Kugan Vivekanandarajah > > gcc/ChangeLog: > > 2019-05-15 Kugan Vivekanandarajah > > PR target/88834 > * tree-ssa-loop-ivopts.c (get_mem_type_for_internal_fn): Handle > IFN_MASK_LOAD_LANES and IFN_MASK_STORE_LANES. >

[PATCH] Do not allow target_clones with alias attr (PR lto/90500).

2019-05-16 Thread Martin Liška
Hi. We should not allow target_clones being combined with alias attribute. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: 2019-05-16 Martin Liska PR lto/90500 * multiple_target.c (expand_target_clo

[PATCH] Handle a location with NULL as a file (PR driver/90495)

2019-05-16 Thread Martin Liška
Hi. With LTO and -fsanitize we end up with a static ctor (_GLOBAL__sub_I_00099_0_main) that has no source location. With that stack usage will print '(artificial)' as a location of the function. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks,

Re: [PATCH] Do not allow target_clones with alias attr (PR lto/90500).

2019-05-16 Thread Richard Biener
On Thu, May 16, 2019 at 1:18 PM Martin Liška wrote: > > Hi. > > We should not allow target_clones being combined with alias attribute. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? So that's because an alias cannot be turned into a dispatche

[PATCH] Changes to std::variant to reduce code size

2019-05-16 Thread Jonathan Wakely
These two changes both result in smaller code for std::variant. The first one means smaller tables of function pointers, because we don't generate an instantiation for the valueless state. Instead we do a runtime branch, marked [[unlikely]] to make _M_reset() a no-op if it's already valueless. In

Re: [PATCH PR57534]Support strength reduction for MEM_REF in slur

2019-05-16 Thread Richard Biener
On Wed, May 15, 2019 at 6:30 AM bin.cheng wrote: > > Hi, > As noted in PR57534 comment #33, SLSR currently doesn't strength reduce memory > references in reported cases, which conflicts with its comment at the > beginning of file. > The main reason is in functions slsr_process_ref and restructure

Re: [PATCH] Do not allow target_clones with alias attr (PR lto/90500).

2019-05-16 Thread Martin Liška
On 5/16/19 1:24 PM, Richard Biener wrote: > On Thu, May 16, 2019 at 1:18 PM Martin Liška wrote: >> >> Hi. >> >> We should not allow target_clones being combined with alias attribute. >> >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. >> >> Ready to be installed? > > So t

[PATCH] Remove a test-case that leads to a huge stack (and file) allocation (PR middle-end/90478).

2019-05-16 Thread Martin Liška
Hi. I'm going to remove the test as it leads to a huge .s files and stack allocation at gcc/stmt.c:777 Ready for trunk? Martin gcc/testsuite/ChangeLog: 2019-05-16 Martin Liska PR middle-end/90478 * gcc.dg/tree-ssa/pr90478-2.c: Remove. --- gcc/testsuite/gcc.dg/tree-ssa/pr904

Re: [PATCH] Do not allow target_clones with alias attr (PR lto/90500).

2019-05-16 Thread Richard Biener
On Thu, May 16, 2019 at 1:38 PM Martin Liška wrote: > > On 5/16/19 1:24 PM, Richard Biener wrote: > > On Thu, May 16, 2019 at 1:18 PM Martin Liška wrote: > >> > >> Hi. > >> > >> We should not allow target_clones being combined with alias attribute. > >> > >> Patch can bootstrap on x86_64-linux-gn

Re: [PATCH] Changes to std::variant to reduce code size

2019-05-16 Thread Jonathan Wakely
On 16/05/19 12:29 +0100, Jonathan Wakely wrote: These two changes both result in smaller code for std::variant. The first one means smaller tables of function pointers, because we don't generate an instantiation for the valueless state. Instead we do a runtime branch, marked [[unlikely]] to make

Re: [PATCH] Do not allow target_clones with alias attr (PR lto/90500).

2019-05-16 Thread Martin Liška
On 5/16/19 1:42 PM, Richard Biener wrote: > On Thu, May 16, 2019 at 1:38 PM Martin Liška wrote: >> >> On 5/16/19 1:24 PM, Richard Biener wrote: >>> On Thu, May 16, 2019 at 1:18 PM Martin Liška wrote: Hi. We should not allow target_clones being combined with alias attribute. >>

Re: [PATCH] True IPA reimplementation of IPA-SRA

2019-05-16 Thread Richard Biener
On Fri, May 10, 2019 at 10:31 AM Martin Jambor wrote: > > Hello, > > this is a follow-up from a WIP patch I sent here in late December: > https://gcc.gnu.org/ml/gcc-patches/2018-12/msg01765.html > > Just like the last time, the patch below is is a reimplementation of > IPA-SRA to make it a full IP

Re: [PATCH] Remove redundant accessors in hash tables

2019-05-16 Thread Jonathan Wakely
On 16/05/19 11:05 +0100, Jonathan Wakely wrote: On 16/05/19 07:47 +0200, François Dumont wrote: On 5/15/19 5:37 PM, Jonathan Wakely wrote: François, I noticed that _Hash_code_base and _Hashtable_base have a number of member functions which are overloaded for const and non-const:    const _Equa

Re: [PATCH 2/3][GCC] GNAT/testsuite: Pass the `ada' option to target compilation

2019-05-16 Thread Maciej W. Rozycki
On Wed, 15 May 2019, Jacob Bachmeyer wrote: > > Index: gcc/gcc/testsuite/lib/gnat.exp > > === > > --- gcc.orig/gcc/testsuite/lib/gnat.exp > > +++ gcc/gcc/testsuite/lib/gnat.exp > > @@ -167,6 +167,8 @@ proc gnat_target_compile { source

Re: [PATCH] debug: make -feliminate-unused-debug-symbols the default [PR debug/86964]

2019-05-16 Thread Richard Biener
On Thu, May 16, 2019 at 11:20 AM Thomas De Schampheleire wrote: > > From: Thomas De Schampheleire > > In addition to making -feliminate-unused-debug-symbols work for the DWARF > format (see [1]), make this option the default. This behavior was the case > before, e.g. under gcc 4.9.x. > [1] https:

Re: [PATCH] Do not allow target_clones with alias attr (PR lto/90500).

2019-05-16 Thread Richard Biener
On Thu, May 16, 2019 at 1:53 PM Martin Liška wrote: > > On 5/16/19 1:42 PM, Richard Biener wrote: > > On Thu, May 16, 2019 at 1:38 PM Martin Liška wrote: > >> > >> On 5/16/19 1:24 PM, Richard Biener wrote: > >>> On Thu, May 16, 2019 at 1:18 PM Martin Liška wrote: > > Hi. > >

Re: [PATCH 3/3][DejaGNU] target: Wrap linker flags into `-largs'/`-margs' for Ada

2019-05-16 Thread Maciej W. Rozycki
On Wed, 15 May 2019, Jacob Bachmeyer wrote: > This patch really exposes a significant deficiency in our current > implementation of default_target_compile: the order of various flags > can be significant, but we only have that order implicitly expressed in > the code, which goes all the way ba

Re: [PATCH] Do not allow target_clones with alias attr (PR lto/90500).

2019-05-16 Thread Martin Liška
On 5/16/19 2:52 PM, Richard Biener wrote: > On Thu, May 16, 2019 at 1:53 PM Martin Liška wrote: >> >> On 5/16/19 1:42 PM, Richard Biener wrote: >>> On Thu, May 16, 2019 at 1:38 PM Martin Liška wrote: On 5/16/19 1:24 PM, Richard Biener wrote: > On Thu, May 16, 2019 at 1:18 PM Martin

Re: [PATCH] Fix __builtin_init_dwarf_reg_size_table when built with -mfpxx

2019-05-16 Thread Dragan Mladjenovic
Ping. From: Dragan Mladjenovic Sent: Thursday, May 9, 2019 12:29 PM To: gcc-patches@gcc.gnu.org Cc: Dragan Mladjenovic; Jakub Jelinek; Matthew Fortune Subject: [PATCH] Fix __builtin_init_dwarf_reg_size_table when built with -mfpxx From: "Dragan Mladjenovic" Hi

Re: [PATCH] Remove redundant accessors in hash tables

2019-05-16 Thread Jonathan Wakely
On 16/05/19 13:30 +0100, Jonathan Wakely wrote: On 16/05/19 11:05 +0100, Jonathan Wakely wrote: On 16/05/19 07:47 +0200, François Dumont wrote: On 5/15/19 5:37 PM, Jonathan Wakely wrote: François, I noticed that _Hash_code_base and _Hashtable_base have a number of member functions which are ov

[PATCH] OpenMP simd if clause support with runtime determined argument (take 2)

2019-05-16 Thread Jakub Jelinek
On Thu, May 16, 2019 at 11:30:38AM +0200, Richard Biener wrote: > > note_simd_array_uses indeed does walk the IL and does look at the calls, > > but I'd need some data structure where to store the argument; we don't have > > loop_vinfo yet (we don't have it even before the loop over vector sizes),

Re: [PATCH] OpenMP simd if clause support with runtime determined argument (take 2)

2019-05-16 Thread Richard Biener
On Thu, 16 May 2019, Jakub Jelinek wrote: > On Thu, May 16, 2019 at 11:30:38AM +0200, Richard Biener wrote: > > > note_simd_array_uses indeed does walk the IL and does look at the calls, > > > but I'd need some data structure where to store the argument; we don't > > > have > > > loop_vinfo yet (

Re: [PATCH] True IPA reimplementation of IPA-SRA

2019-05-16 Thread Martin Jambor
Hi Richi, On Thu, May 16 2019, Richard Biener wrote: > On Fri, May 10, 2019 at 10:31 AM Martin Jambor wrote: >> >> Hello, >> >> this is a follow-up from a WIP patch I sent here in late December: >> https://gcc.gnu.org/ml/gcc-patches/2018-12/msg01765.html >> >> Just like the last time, the patch b

patches to detect GCC diagnostics

2019-05-16 Thread Roland Illig
Hi Martin, I'm impressed how much work you have put into the patches for detecting nonoptimal diagnostics. It takes a long time to read through the patches, but it's worth it, knowing that it took much longer for you to prepare the patch, and that I won't have to submit i18n bug reports in the for

Re: [PATCH 0/12] detect quoting and punctuation problems in diagnostics

2019-05-16 Thread Martin Sebor
On 5/16/19 4:02 AM, Martin Liška wrote: Hi. Maybe I've install the patches wrongly, but I see following error on ppc64le during bootstrap in stage2: I also noticed it yesterday on x86_64. The %qk was vestige of an earlier attempt to use the pretty-printer to format TREE_CODEs. I have this in

Re: [PATCH] fortran: C++ support for generating C prototypes

2019-05-16 Thread Jakub Jelinek
On Wed, May 15, 2019 at 10:41:06PM +0300, Janne Blomqvist wrote: > > 2) I don't think float _Complex is > >passed the same as std::complex and similar for others; > >std::complex is in libstdc++ a C++ class with with > >__complex__ float as its sole non-static data member and with non-t

OpenACC Profiling Interface: 'acc_register_library' (was: OpenACC 2.5 Profiling Interface)

2019-05-16 Thread Thomas Schwinge
Hi Jakub! On Sun, 11 Nov 2018 22:31:42 -0600, I wrote: > On Tue, 28 Feb 2017 18:43:36 +0100, I wrote: > > The 2.5 versions of the OpenACC standard added a new chapter "Profiling > > Interface". > > I'd like to get that into trunk. It's not yet complete (that is, doesn't > provide all the informa

Add stats for aliasing_component_refs_p

2019-05-16 Thread Jan Hubicka
Hi, tis patch adds stats for aliasing_component_refs_p oracle into the alias oracle report. Bootstrapped/regtested x86_64-linux, comitted as obvious. This is dump for LTO optimizing tramp3d. Compile time: refs_may_alias_p: 0 disambiguations, 0 queries ref_maybe_used_by_call_p: 248 disambigua

Re: [PATCH PR57534]Support strength reduction for MEM_REF in slur

2019-05-16 Thread Bill Schmidt
Thanks, Bin and Richard -- I am out of the office until Tuesday, so will review when I get back. Bin, please CC me on SLSR patches as otherwise I might miss them. Thanks! Bill On 5/16/19 6:37 AM, Richard Biener wrote: > On Wed, May 15, 2019 at 6:30 AM bin.cheng wrote: >> Hi, >> As noted in PR

Re: OpenACC Profiling Interface: 'acc_register_library' (was: OpenACC 2.5 Profiling Interface)

2019-05-16 Thread Jakub Jelinek
On Thu, May 16, 2019 at 05:21:56PM +0200, Thomas Schwinge wrote: > > Jakub, would you please especially review the non-OpenACC-specific > > changes here, including the libgomp ABI changes? > > Given a baseline that I've not yet posted ;-) would you please anyway > have a look at the following chan

Re: [PATCH PR57534]Support strength reduction for MEM_REF in slur

2019-05-16 Thread Bin.Cheng
On Thu, May 16, 2019 at 11:50 PM Bill Schmidt wrote: > > Thanks, Bin and Richard -- I am out of the office until Tuesday, so will > review > when I get back. Bin, please CC me on SLSR patches as otherwise I might miss > them. Thanks! Thanks for helping. Will do it next time. Thanks, bin > > B

Re: preserve more debug stmts in gimple jump threading

2019-05-16 Thread Jeff Law
On 5/15/19 3:03 PM, Alexandre Oliva wrote: > On May 15, 2019, Richard Biener wrote: > >> On Wed, May 15, 2019 at 10:20 AM Alexandre Oliva wrote: >>> >>> Gimple jump threading does not duplicate forwarder blocks that might >>> be present before or after the copied block. > >> Empty forwarder blo

Re: [PATCH] Remove a test-case that leads to a huge stack (and file) allocation (PR middle-end/90478).

2019-05-16 Thread Jeff Law
On 5/16/19 5:42 AM, Martin Liška wrote: > Hi. > > I'm going to remove the test as it leads to a huge .s files and stack > allocation at gcc/stmt.c:777 > > Ready for trunk? > Martin > > gcc/testsuite/ChangeLog: > > 2019-05-16 Martin Liska > > PR middle-end/90478 > * gcc.dg/tree-s

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-16 Thread Jeff Law
On 5/15/19 5:19 AM, Richard Biener wrote: > > For the official converted repo do we really want all (old) > development branches to be in the > main git repo? I suppose we could create a readonly git from the > state of the whole repository > at the point of conversion (and also keep the SVN in r

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-16 Thread Maxim Kuvyrkov
> On May 16, 2019, at 7:22 PM, Jeff Law wrote: > > On 5/15/19 5:19 AM, Richard Biener wrote: >> >> For the official converted repo do we really want all (old) >> development branches to be in the >> main git repo? I suppose we could create a readonly git from the >> state of the whole repositor

Re: [PATCH v2 3/3] Consider doloop cmp use in ivopts

2019-05-16 Thread Segher Boessenkool
On Thu, May 16, 2019 at 09:25:49AM +0200, Richard Biener wrote: > On Wed, 15 May 2019, Segher Boessenkool wrote: > > > Otherwise I understand that IVOPTs doesn't properly cost > > > the doloop IV update and conditional branch. > > > > Currently it doesn't even *know* something is or isn't a doloop

Re: [PATCH] gcc: move assemble_start_function / assemble_end_function to output_mi_thunk

2019-05-16 Thread Max Filippov
On Wed, May 15, 2019 at 2:46 PM Richard Sandiford wrote: > > Max Filippov writes: > > Let backends call assemble_start_function after they have generated > > thunk function body so that a constant pool could be output if it is > > required. This may help backends to avoid implementing custom cons

Re: [PATCH PR57534]Support strength reduction for MEM_REF in slur

2019-05-16 Thread Jeff Law
On 5/14/19 10:29 PM, bin.cheng wrote: > Hi, > As noted in PR57534 comment #33, SLSR currently doesn't strength reduce memory > references in reported cases, which conflicts with its comment at the > beginning of file. > The main reason is in functions slsr_process_ref and restructure_reference >

Re: [PATCH] Handle a location with NULL as a file (PR driver/90495)

2019-05-16 Thread Jeff Law
On 5/16/19 5:19 AM, Martin Liška wrote: > Hi. > > With LTO and -fsanitize we end up with a static ctor > (_GLOBAL__sub_I_00099_0_main) that has no source location. > With that stack usage will print '(artificial)' as a location > of the function. > > Patch can bootstrap on x86_64-linux-gnu and su

Re: [PATCH 2/2] [PR88836][aarch64] Fix CSE to process parallel rtx dest one by one

2019-05-16 Thread Jeff Law
On 5/15/19 8:08 PM, kugan.vivekanandara...@linaro.org wrote: > From: Kugan Vivekanandarajah > > This patch changes cse_insn to process parallel rtx one by one such that > any destination rtx in cse list is invalidated before processing the > next. > > gcc/ChangeLog: > > 2019-05-16 Kugan Viveka

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-16 Thread Ramana Radhakrishnan
On Thu, May 16, 2019 at 5:41 PM Maxim Kuvyrkov wrote: > > > On May 16, 2019, at 7:22 PM, Jeff Law wrote: > > > > On 5/15/19 5:19 AM, Richard Biener wrote: > >> > >> For the official converted repo do we really want all (old) > >> development branches to be in the > >> main git repo? I suppose we

Re: [PATCH] True IPA reimplementation of IPA-SRA

2019-05-16 Thread Richard Biener
On Thu, May 16, 2019 at 4:04 PM Martin Jambor wrote: > > Hi Richi, > > On Thu, May 16 2019, Richard Biener wrote: > > On Fri, May 10, 2019 at 10:31 AM Martin Jambor wrote: > >> > >> Hello, > >> > >> this is a follow-up from a WIP patch I sent here in late December: > >> https://gcc.gnu.org/ml/gcc

Re: [PATCH v2 3/3] Consider doloop cmp use in ivopts

2019-05-16 Thread Jeff Law
On 5/15/19 2:47 AM, Richard Biener wrote: > On Wed, 15 May 2019, Kewen.Lin wrote: > >> on 2019/5/14 下午3:26, Richard Biener wrote: >>> On Tue, May 14, 2019 at 5:10 AM wrote: From: Kewen Lin Previous version link for background: https://gcc.gnu.org/ml/gcc-patches/2019-04/m

Re: preserve more debug stmts in gimple jump threading

2019-05-16 Thread Richard Biener
On Thu, May 16, 2019 at 6:14 PM Jeff Law wrote: > > On 5/15/19 3:03 PM, Alexandre Oliva wrote: > > On May 15, 2019, Richard Biener wrote: > > > >> On Wed, May 15, 2019 at 10:20 AM Alexandre Oliva wrote: > >>> > >>> Gimple jump threading does not duplicate forwarder blocks that might > >>> be pre

Re: preserve more debug stmts in gimple jump threading

2019-05-16 Thread Jeff Law
On 5/16/19 12:46 PM, Richard Biener wrote: > On Thu, May 16, 2019 at 6:14 PM Jeff Law wrote: >> >> On 5/15/19 3:03 PM, Alexandre Oliva wrote: >>> On May 15, 2019, Richard Biener wrote: >>> On Wed, May 15, 2019 at 10:20 AM Alexandre Oliva wrote: > > Gimple jump threading does not dup

[PATCH] Refactor tree-affine.c to not build GENERIC trees

2019-05-16 Thread Richard Biener
The following picks up the patch from last December, refactoring aff_combination_expand to not use gimple_assign_rhs_to_tree but analyze GIMPLE stmts directly. Last December I was stuck at FAIL: gcc.dg/tree-ssa/ivopts-lt-2.c scan-tree-dump-times ivopts "PHI" 1 FAIL: gcc.dg/tree-ssa/ivopts-lt-2.

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-16 Thread Jeff Law
On 5/16/19 12:36 PM, Ramana Radhakrishnan wrote: > On Thu, May 16, 2019 at 5:41 PM Maxim Kuvyrkov > wrote: >> >>> On May 16, 2019, at 7:22 PM, Jeff Law wrote: >>> >>> On 5/15/19 5:19 AM, Richard Biener wrote: For the official converted repo do we really want all (old) development b

Re: [PATCH 2/12] fix diagnostic quoting/spelling in ada

2019-05-16 Thread Jeff Law
On 5/14/19 3:31 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued by the Ada front and pointed out by > the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-ada.diff > > gcc/ada/ChangeLog: > > * gcc-interface/tr

Re: [PATCH 4/12] fix diagnostic quoting/spelling in the C front-end

2019-05-16 Thread Jeff Law
On 5/14/19 3:32 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued by the C front-end and pointed out > by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-c.diff > > gcc/c/ChangeLog: > > * c-decl.c (start_de

Re: [PATCH 7/12] fix diagnostic quoting/spelling in libgcc

2019-05-16 Thread Jeff Law
On 5/14/19 3:32 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued from files in the libgcc directory > and pointed out by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-libgcc.diff > > libgcc/ChangeLog: > >

Re: [PATCH 3/12] fix diagnostic quoting/spelling in Brig

2019-05-16 Thread Jeff Law
On 5/14/19 3:32 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued by the Brig front end and pointed > out by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-brig.diff > > gcc/brig/ChangeLog: > > * brigfront

Re: [PATCH 10/12] fix diagnostic quoting/spelling in D

2019-05-16 Thread Jeff Law
On 5/14/19 3:33 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued by the D front end and pointed out > by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-d.diff > > gcc/d/ChangeLog: > > * d/d-builtins.cc (d

Re: [PATCH 11/12] fix diagnostic quoting/spelling issues in i386 back-end

2019-05-16 Thread Jeff Law
On 5/14/19 3:33 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued by the i386 back-end and pointed out > by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-i386.diff > > gcc/ChangeLog: > > * config/i386/i38

Re: [PATCH 5/12] fix diagnostic quoting/spelling in c-family

2019-05-16 Thread Jeff Law
On 5/14/19 3:32 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued from files in the c-family/ directory > and pointed out by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-c-family.diff > > gcc/c-family/ChangeLog

Re: [PATCH 6/12] fix diagnostic quoting/spelling in C++

2019-05-16 Thread Jeff Law
On 5/14/19 3:32 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued by the C++ front-end and pointed out > by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-cp.diff > > gcc/cp/ChangeLog: > > * call.c (print_

Re: [PATCH 8/12] fix diagnostic quoting/spelling in the middle-end

2019-05-16 Thread Jeff Law
On 5/14/19 3:32 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued from files in middle-end files and > pointed out by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-midend.diff > > gcc/ChangeLog: > > * bui

Re: patches to detect GCC diagnostics

2019-05-16 Thread Jakub Jelinek
On Thu, May 16, 2019 at 04:58:08PM +0200, Roland Illig wrote: > - error ("#pragma GCC target string... is badly formed"); > + error ("%<#pragma GCC target%> string is badly formed"); > - error ("#pragma GCC optimize string... is badly formed"); > + error ("%<#pragma GCC opti

Re: OpenACC Profiling Interface: 'acc_register_library'

2019-05-16 Thread Thomas Schwinge
Hi Jakub! On Thu, 16 May 2019 17:54:23 +0200, Jakub Jelinek wrote: > On Thu, May 16, 2019 at 05:21:56PM +0200, Thomas Schwinge wrote: > > > Jakub, would you please especially review the non-OpenACC-specific > > > changes here, including the libgomp ABI changes? > > > > Given a baseline that I've

Re: [PATCH 9/12] adjust tests to quoting/spelling diagnostics fixes

2019-05-16 Thread Jeff Law
On 5/14/19 3:32 PM, Martin Sebor wrote: > The attached patch adjusts the expected test output to the quoting, > spelling and other formatting changes in diagnostics to fix issues > pointed out by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-tests.diff > > gcc/testsuite/ChangeLog: >

[PATCH] libfortran/90038: Use posix_spawn instead of fork

2019-05-16 Thread Janne Blomqvist
fork() semantics can be problematic. Most unix style OS'es have posix_spawn which can be used to replace fork + exec in many cases. For more information see e.g. https://www.microsoft.com/en-us/research/uploads/prod/2019/04/fork-hotos19.pdf This replaces the one use of fork in libgfortran with p

Re: [PATCH] libfortran/90038: Use posix_spawn instead of fork

2019-05-16 Thread Thomas Koenig
Hi Janne, fork() semantics can be problematic. Most unix style OS'es have posix_spawn which can be used to replace fork + exec in many cases. For more information see e.g. https://www.microsoft.com/en-us/research/uploads/prod/2019/04/fork-hotos19.pdf This replaces the one use of fork in libgf

[PATCH] x86-64: Add vararg ABI tests

2019-05-16 Thread H.J. Lu
We can scan stack for return address to get vector arguments passed on stack. * gcc.target/x86_64/abi/test_varargs-m128.c: New file. * gcc.target/x86_64/abi/avx/test_varargs-m256.c: Likewise. * gcc.target/x86_64/abi/avx512f/test_varargs-m512.c: Likewise. --- .../x86_64/abi

Re: [PATCH] libfortran/90038: Use posix_spawn instead of fork

2019-05-16 Thread Janne Blomqvist
On Thu, May 16, 2019 at 10:59 PM Thomas Koenig wrote: > > Hi Janne, > > > fork() semantics can be problematic. Most unix style OS'es have > > posix_spawn which can be used to replace fork + exec in many cases. > > For more information see > > e.g. > > https://www.microsoft.com/en-us/research/upl

Re: patches to detect GCC diagnostics

2019-05-16 Thread Martin Sebor
On 5/16/19 8:58 AM, Roland Illig wrote: Hi Martin, I'm impressed how much work you have put into the patches for detecting nonoptimal diagnostics. It takes a long time to read through the patches, but it's worth it, knowing that it took much longer for you to prepare the patch, and that I won't

Re: [PATCH] Changes to std::variant to reduce code size

2019-05-16 Thread Jonathan Wakely
On 16/05/19 12:43 +0100, Jonathan Wakely wrote: On 16/05/19 12:29 +0100, Jonathan Wakely wrote: These two changes both result in smaller code for std::variant. The first one means smaller tables of function pointers, because we don't generate an instantiation for the valueless state. Instead we

[PATCH] Implement sane variant converting constructor (P0608R3)

2019-05-16 Thread Jonathan Wakely
* include/std/variant (__overload_set): Remove. (_Arr): New helper. (_Build_FUN): New class template to define a single FUN overload, with specializations to prevent unwanted conversions, as per P0608R3. (_Build_FUNs): New class template to build an overload

Re: [PATCH] Changes to std::variant to reduce code size

2019-05-16 Thread Ville Voutilainen
On Thu, 16 May 2019 at 23:28, Jonathan Wakely wrote: > Here's what I've tested and am about to commit. Looks good to me.

Re: [PATCH] libfortran/90038: Use posix_spawn instead of fork

2019-05-16 Thread Thomas Koenig
Am 16.05.19 um 22:10 schrieb Janne Blomqvist: On Thu, May 16, 2019 at 10:59 PM Thomas Koenig wrote: Hi Janne, fork() semantics can be problematic. Most unix style OS'es have posix_spawn which can be used to replace fork + exec in many cases. For more information see e.g. https://www.micros

Re: [PATCH] libfortran/90038: Use posix_spawn instead of fork

2019-05-16 Thread Thomas Koenig
Hi Janne, I differ there. A longer explanation: fork() is standard POSIX. Not all systems have posix_spawn. For those systems which do not have it, we would cause a regression by simply removing that functionality for this. The patch is OK from my side if you add fork() as a fallback option

[RFC PATCH] Enhancements to profiledbootstrap

2019-05-16 Thread Arvind Sankar
Hi, I've been playing some with the PGO build infrastructure and have a few changes I thought I'd share and get feedback on whether they're completely crazy or not. I'm not terribly familiar with the innards of the build infra, so would appreciate any comments and suggestions. First, a recap of th

Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-16 Thread Jakub Jelinek
On Wed, May 08, 2019 at 06:09:06PM +0800, JunMa wrote: > 2019-05-07  Jun Ma > >     PR tree-optimization/90106 >     * gcc.dg/cdce1.c: Check tailcall code generation after cdce pass. >     * gcc.dg/cdce2.c: Likewise. This is wrong and results in UNSUPPORTED failures. Both tests are dg-do run, so

Re: [PATCH v2 3/3] Consider doloop cmp use in ivopts

2019-05-16 Thread Segher Boessenkool
Hi Jeff, On Thu, May 16, 2019 at 12:41:16PM -0600, Jeff Law wrote: > For architectures like PPC, we probably don't want to use the loop count > for anything else as it's likely expensive to get data in/out of the the > loop count register. That is part of it. Another part is that it costs extra

[committed] Fix ICE in equal_mem_array_ref_p (PR c++/90484)

2019-05-16 Thread Jakub Jelinek
Hi! As mentioned in the PR, if we are very unlucky and have a hash collision not just when hash % hash table size is equal, but when the whole 32-bit hash is equal, we can actually end up with compatible types (bool vs. unsigned : 1 on the testcase), but sz0 != sz1 (one is 1-bit, the other 8-bit),

[PATCH] i386: Enable MMX intrinsics without SSE/SSE2/SSSE3

2019-05-16 Thread H.J. Lu
Since MMX intrinsics are marked with SSE/SSE2/SSSE3 for SSE emulation, enable them without SSE/SSE2/SSSE3 if MMX is enabled. Restore TARGET_3DNOW check, which was changed to TARGET_3DNOW_A by revision 271235. gcc/ PR target/90497 * config/i386/i386-expand.c (ix86_expand_builtin):

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-16 Thread Jonathan Wakely
On 16/05/19 13:07 -0600, Jeff Law wrote: On 5/16/19 12:36 PM, Ramana Radhakrishnan wrote: On Thu, May 16, 2019 at 5:41 PM Maxim Kuvyrkov wrote: On May 16, 2019, at 7:22 PM, Jeff Law wrote: On 5/15/19 5:19 AM, Richard Biener wrote: For the official converted repo do we really want all (ol

  1   2   >