[PATCH] Fix PR88089

Another oversight. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2018-11-20 Richard Biener PR middle-end/88089 * tree-data-ref.c (lambda_matrix_right_hermite): Use abs_hwi. >From d374f5497b4bb33a5ebf2535035d6183a6a68021 Mon Sep 17 00:00:00 2001 Fro

[PATCH] Fix PR88087

The following fixes PR88087 - a failure for PRE to re-materialize call fntypes. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2018-11-20 Richard Biener PR tree-optimization/88087 * tree-ssa-pre.c (create_expression_by_pieces): Re-materialize

Re: Fix ICE in cp_var_mod_type_p

On Mon, 19 Nov 2018, Jan Hubicka wrote: > Hi, > enable-checking compiler crashes in free_lang_data because verify_type > is called too early (after we free data in types but before we clear the > langhooks) and it ends up calling cp_var_mod_type_p which ICEs. > > This is fixed by moving type chec

Re: [PATCH] Fix PR83215, remove alias-set zero case from component_uses_parent_alias_set_from

On Mon, 19 Nov 2018, Eric Botcazou wrote: > > Eric, do you know of any cases in Ada where a alias-set zero base > > has non-alias-set zero children? The testsuite seems to be clean > > but you never know... > > No, at least not off the top of my head; that would be weird in any case. OK, I'll b

Fix PR rtl-optimization/85925

Adjust couple of comments. (num_sign_bit_copies1): Likewise. 2018-11-20 Eric Botcazou * gcc.c-torture/execute/20181120-1.c: New test. -- Eric BotcazouIndex: rtl.h === --- rtl.h (revision 266178) +++ rtl.h (workin

Re: [PATCH] make function_args_iterator a proper iterator

On Mon, Nov 19, 2018 at 4:36 PM Martin Sebor wrote: > > On 11/19/2018 03:32 AM, Richard Biener wrote: > > On Sat, Nov 17, 2018 at 12:05 AM Martin Sebor wrote: > >> > >> To encourage and simplify the adoption of iterator classes in > >> GCC the attached patch turns the function_args_iterator struc

Re: C++ PATCH to implement P1094R2, Nested inline namespaces

On Mon, Nov 19, 2018 at 11:12 PM Marek Polacek wrote: > > On Mon, Nov 19, 2018 at 10:33:17PM +0100, Jakub Jelinek wrote: > > On Mon, Nov 19, 2018 at 04:21:19PM -0500, Marek Polacek wrote: > > > 2018-11-19 Marek Polacek > > > > > > Implement P1094R2, Nested inline namespaces. > > > * g++

Re: [C++ Patch] PR 84636 ("internal compiler error: Segmentation fault (identifier_p()/grokdeclarator())")

Hi, On 19/11/18 23:24, Marek Polacek wrote: On Mon, Nov 19, 2018 at 08:03:24PM +0100, Paolo Carlini wrote: @@ -12245,8 +12246,9 @@ grokdeclarator (const cp_declarator *declarator, error ("invalid use of %<::%>"); return error_mark_node; } - else if (TREE_

Re: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87626

On Mon, Nov 19, 2018 at 04:08:29PM +0530, Lokesh Janghel wrote: diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 8ca2e73..b55dfa9 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2018-11-19 Lokesh Janghel Two spaces between date and name and name and <, i.e. 2018-11-20 Lokesh Jang

Re: C++ PATCH to implement P1094R2, Nested inline namespaces

On Tue, Nov 20, 2018 at 10:25:01AM +0100, Richard Biener wrote: > > Bootstrapped/regtested on x86_64-linux, ok for trunk? > > Just another small comment - given the usual high number of > C++ regressions delaying the release is Stage3 the right time > to add new language features? I'd say this is

Re: [PATCH] S/390: Skip LT(G) peephole when literal pool is involved

On 19.11.18 17:08, Ilya Leoshkevich wrote: > Bootstrapped and regtested on s390x-redhat-linux. > > By the time peephole optimizations run, we've already made up our mind > whether to use base-register or relative addressing for literal pool > entries. LT(G) supports only base-register addressing,

Re: [PATCH] Fix PR88031

On Mon, 19 Nov 2018, Christophe Lyon wrote: > On Thu, 15 Nov 2018 at 14:41, Richard Biener wrote: > > > > > > With one of my last changes we regressed here so this goes all the > > way cleaning up things so we only have a single flag to > > vectorizable_condition whetehr we are called from reduct

[maintainer-scipts] Add a bugzilla script

Hi. It's the script that I used to identify potentially resolvable bugs. That's done by parsing of comments and seeking for trunk/branch commits. Sample output looks as follows: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88084 branches: trunk fail:

Re: [PATCH] [aarch64] Add CPU support for Ampere Computing's eMAG.

Hi Christoph, Thank you for the patch. Can you please confirm how this has been tested? On 19/11/18 17:11, Christoph Muellner wrote: *** gcc/ChangeLog *** 2018-xx-xx Christoph Muellner * config/aarch64/aarch64-cores.def: Define emag * config/aarch64/aarch64-tune.md: Regenera

[PATCH][OBVIOUS] Add -fomit-frame-pointer to a test-case (PR ipa/88093).

Hi. One obvious fix of a test-case which I'm going to install. Martin gcc/testsuite/ChangeLog: 2018-11-20 Martin Liska PR ipa/88093 * gcc.target/i386/ipa-stack-alignment.c: Add -fomit-frame-pointer. --- gcc/testsuite/gcc.target/i386/ipa-stack-alignment.c | 2 +- 1 f

Re: [PATCH, ARM] Improve robustness of -mslow-flash-data

On Mon, 19 Nov 2018 at 18:56, Thomas Preudhomme wrote: > > Hi, > > Current code to handle -mslow-flash-data in machine description files > suffers from a number of issues which this patch fixes: > > 1) The insn_and_split in vfp.md to load a generic floating-point > constant via GPR first and move

Re: [PATCH, middle-end]: Fix PR 88070, ICE in create_pre_exit, at mode-switching.c:438

On Tue, Nov 20, 2018 at 8:59 AM Eric Botcazou wrote: > > > The blockage was introduced as a fix for PR14381 [1] in r79265 [2]. > > Later, the blockage was moved after return label as a fix for PR25176 > > [3] in r107871 [4]. > > > > After that, r122626 [5] moves the blockage after the label for th

[PATCH] Fix PR88069

The following fixes another case of region VN escaping the region. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2018-11-20 Richard Biener PR tree-optimization/88069 * tree-ssa-sccvn.c (visit_phi): Do not value-number to unvisited virtual PH

Re: [v3 PATCH] Housekeeping for the effective targets of optional's tests.

On 20/11/18 07:11 +0200, Ville Voutilainen wrote: Tested on Linux-x64 for optional's tests only. Ok for trunk? OK, thanks.

[PATCH] Fix libgomp bootstrap on mingw (PR bootstrap/88106)

Hi! Jonathan reported that gcc fails to build on mingw32, apparently it has some gethostname implementation, but in winsock library or where, and it isn't prototyped. libgfortran instead uses GetComputerName API, so this patch does that for libgomp too. Kindly tested by Jonathan, committed to tr

Re: [PATCH PR84648]Adjust loop exit conditions for loop-until-wrap cases.

On Mon, Nov 19, 2018 at 9:17 PM Christophe Lyon wrote: > > On Wed, 14 Nov 2018 at 11:10, bin.cheng wrote: > > > > -- > > Sender:Richard Biener > > Sent at:2018 Nov 13 (Tue) 23:03 > > To:bin.cheng > > Cc:GCC Patches > > Subject:Re:

Re: [PATCH v2 1/3] Allow memory operands for PTWRITE

On Fri, Nov 16, 2018 at 8:07 AM Uros Bizjak wrote: > > On Fri, Nov 16, 2018 at 4:57 AM Andi Kleen wrote: > > > > From: Andi Kleen > > > > The earlier PTWRITE builtin definition was unnecessarily restrictive, > > only allowing register input to PTWRITE. The instruction actually > > supports memor

Re: [PATCH, middle-end]: Fix PR 88070, ICE in create_pre_exit, at mode-switching.c:438

On Tue, Nov 20, 2018 at 8:59 AM Eric Botcazou wrote: > > > The blockage was introduced as a fix for PR14381 [1] in r79265 [2]. > > Later, the blockage was moved after return label as a fix for PR25176 > > [3] in r107871 [4]. > > > > After that, r122626 [5] moves the blockage after the label for th

Re: [PATCH AutoFDO/2]Treat ZERO as common profile probability/count

Sender:Jan Hubicka Sent at:2018 Nov 5 (Mon) 22:21 To:Richard Biener Cc:bin.cheng ; GCC Patches Subject:Re: [PATCH AutoFDO/2]Treat ZERO as common profile probability/count > > > On Wed, Oct 31, 2018 at 7:30 AM bin.cheng > > wrote: > > > > > > Hi, > > > In new profile probability/count infra

Re: GCC 8 backports

On 10/3/18 11:23 AM, Martin Liška wrote: > On 9/25/18 8:48 AM, Martin Liška wrote: >> Hi. >> >> One more tested patch. >> >> Martin >> > > One more tested patch. > > Martin > Hi. One another tested patch that I'm going to install. Martin >From 94cd1e55e5baec63b7a80c59fdd8b5c52595c9e9 Mon Sep

Re: [PATCH 06/10] GCN back-end config

On 16/11/2018 17:44, Joseph Myers wrote: On Fri, 16 Nov 2018, Andrew Stubbs wrote: * config.sub: Recognize amdgcn*-*-amdhsa. config.sub should be copied from upstream config.git (along with config.guess at the same time), once the support has been added there; it shouldn't be patched

[PATCH][driver] Ensure --help=params lines end with period

Hi, this patch ensures that gcc --help=params lines end with a period by: - fixing the help message of param HOT_BB_COUNT_FRACTION, and - adding a test-case. Build and tested on x86_64. OK for trunk? Thanks, - Tom [driver] Ensure --help=params lines end with period 2018-11-20 Tom de Vries

Re: [PATCH v2 2/3] Add a pass to automatically add ptwrite instrumentation

On Fri, Nov 16, 2018 at 4:57 AM Andi Kleen wrote: > > From: Andi Kleen > > Add a new pass to automatically instrument changes to variables > with the new PTWRITE instruction on x86. PTWRITE writes a 4 or 8 byte > field into an Processor Trace log, which allows low over head > logging of informati

Re: [PATCH] Come up with gcc/testsuite/g++.target/i386/i386.dg and move there some tests.

On 11/16/18 6:01 PM, Renlin Li wrote: > Hi Martin, > > Seems the change is not checked in yet? Sorry, I've just installed the patch. Martin > > Thanks, > Renlin > > On 10/22/2018 01:22 PM, Martin Liška wrote: >> On 10/22/18 12:09 PM, Jakub Jelinek wrote: >>> On Mon, Oct 22, 2018 at 12:04:23PM

Re: [PATCH]Come up with -flive-patching master option.

On 11/19/18 4:52 PM, Qing Zhao wrote: > >> On Nov 19, 2018, at 2:11 AM, Martin Liška > > wrote: >> >> On 11/16/18 5:04 PM, Qing Zhao wrote: >>> On Nov 16, 2018, at 9:26 AM, Martin Liška >>> > wrote: On 11/16/18 2:

[PATCH] Fix PR88105

Boostrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. >From 27b32c8684c9703b92f5c035ebb6f06b9e2a20af Mon Sep 17 00:00:00 2001 From: Richard Guenther Date: Tue, 20 Nov 2018 10:33:16 +0100 Subject: [PATCH] fix-pr88105 2018-11-20 Richard Biener PR tree-optimization/88

[PATCH] Do not mix -fsanitize=thread and -mabi=ms (PR sanitizer/88017).

Hi. It's very similar to what I did few days ago for -fsanitize=address and -mabi=ms. Patch survives tests on x86_64-linux-gnu and bootstraps. Ready for trunk? Thanks, Martin gcc/ChangeLog: 2018-11-20 Martin Liska PR sanitizer/88017 * config/i386/i386.c (ix86_option_overri

Re: [PATCH] Remove unreachable nodes before IPA profile pass (PR ipa/87706).

> Hi. > > In order to fix the warnings mentioned in the PR, we need > to run remove_unreachable_nodes after early tree passes. That's > however possible only within a IPA pass. Thus I'm calling that > before the profile PASS. > > Patch survives regression tests on ppc64le-linux-gnu and majority >

Fix PR37916 (compile time regression)

Hi, the testcase gcc.dg/20020425-1.c was once a compile time hog. With current trunk it only needs 7 seconds (on my machine, with -O0 cc1) but there's still something to improve as virtually all of that time is wasted in repeatedly scanning the same (long) sequence of gimple statements to pos

Fix PR37916 (unnecessary spilling)

Hi, this bug report is about cris generating worse code since tree-ssa. The effect is also visible on x86-64. The symptom is that the work horse of adler32.c (from zlib) needs spills in the inner loop, while gcc 3 did not, and those spills go away with -fno-tree-reassoc. The underlying reaso

Re: Fix PR37916 (compile time regression)

On Tue, Nov 20, 2018 at 2:23 PM Michael Matz wrote: > > Hi, > > the testcase gcc.dg/20020425-1.c was once a compile time hog. With > current trunk it only needs 7 seconds (on my machine, with -O0 cc1) but > there's still something to improve as virtually all of that time is > wasted in repeatedly

Re: Fix PR37916 (unnecessary spilling)

On Tue, 20 Nov 2018, Michael Matz wrote: > > I'm wondering about testcase: should I add an x86-64 specific that tests > for no stack accesses, or would that be too constraining in the future? > > Regstrapped on x86-64-linux, no regressions. Okay for trunk? By the way, this patch helps x86-64 o

[PATCH][RFC] Extend locations where to seach for Fortran pre-include.

Hi. Following patch is a follow up of the discussion we had on IRC about locations where a Fortran pre-include should be searched. With the patch applied I see now: $ strace -f -s512 ./xgcc -B. ~/Programming/testcases/usage.F90 -c 2>&1 | grep math-vector access("./x86_64-pc-linux-gnu/9.0.0/math

Re: Fix PR37916 (compile time regression)

Hi, On Tue, 20 Nov 2018, Richard Biener wrote: > > Anyway, regstrapped on x86-64-linux, no regressions. Okay for trunk? > > Ick. Given you do that only for one stmt kind and it looks kind of ugly > wouldn't it be better to splat out gimple_set_location (g, > input_location) to all 108 places

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On Tue, Nov 20, 2018 at 03:14:02PM +0100, Martin Liška wrote: > Following patch is a follow up of the discussion we had on IRC about > locations where a Fortran pre-include should be searched. > > With the patch applied I see now: > $ strace -f -s512 ./xgcc -B. ~/Programming/testcases/usage.F90 -

Re: C++ PATCH to implement P1094R2, Nested inline namespaces

On Tue, Nov 20, 2018 at 10:36:32AM +0100, Jakub Jelinek wrote: > On Tue, Nov 20, 2018 at 10:25:01AM +0100, Richard Biener wrote: > > > Bootstrapped/regtested on x86_64-linux, ok for trunk? > > > > Just another small comment - given the usual high number of > > C++ regressions delaying the release

Re: [RFC][PATCH]Merge VEC_COND_EXPR into MASK_STORE after loop vectorization

Hi Richard, On 11/14/2018 02:59 PM, Richard Biener wrote: On Fri, Nov 9, 2018 at 4:49 PM Renlin Li wrote: Hi Richard, On 11/09/2018 11:48 AM, Richard Biener wrote: On Thu, Nov 8, 2018 at 5:55 PM Renlin Li wrote: Hi Richard, I don't see the masked load here on x86_64 btw. (I don't see

Re: Fix PR37916 (compile time regression)

On Tue, Nov 20, 2018 at 3:19 PM Michael Matz wrote: > > Hi, > > On Tue, 20 Nov 2018, Richard Biener wrote: > > > > Anyway, regstrapped on x86-64-linux, no regressions. Okay for trunk? > > > > Ick. Given you do that only for one stmt kind and it looks kind of ugly > > wouldn't it be better to spl

Re: [PATCH] [aarch64] Add CPU support for Ampere Computing's eMAG.

Hi Kyrill, thank's for your comments. > On 20.11.2018, at 11:08, Kyrill Tkachov wrote: > > Hi Christoph, > > Thank you for the patch. > Can you please confirm how this has been tested? Tested with "make check" and no regressions found. Will put that info into the mail next time. > > On 19/1

[PATCH v2] [aarch64] Add CPU support for Ampere Computing's eMAG.

Tested with "make check" and no regressions found. *** gcc/ChangeLog *** 2018-xx-xx Christoph Muellner * config/aarch64/aarch64-cores.def: Define emag. * config/aarch64/aarch64-tune.md: Regenerated with emag. * config/aarch64/aarch64.c (emag_tunings): New struct.

Re: [PATCH] make function_args_iterator a proper iterator

On 11/20/2018 02:21 AM, Richard Biener wrote: On Mon, Nov 19, 2018 at 4:36 PM Martin Sebor wrote: On 11/19/2018 03:32 AM, Richard Biener wrote: On Sat, Nov 17, 2018 at 12:05 AM Martin Sebor wrote: To encourage and simplify the adoption of iterator classes in GCC the attached patch turns th

[PR 87926] bitmap -Wno-error=array-bounds

Applying a more focussed fix, as suggested by Richard. nathan -- Nathan Sidwell 2018-11-20 Nathan Sidwell PR 87926 * Makefile.in (bitmap.o-warn): Use -Wno-error=array-bounds. Index: Makefile.in === --- Makefile.in (revision 26

Re: [PATCH] handle unusual targets in -Wbuiltin-declaration-mismatch (PR 88098)

On Mon, 19 Nov 2018 at 22:38, Martin Sebor wrote: > > The gcc.dg/Wbuiltin-declaration-mismatch-4.c test added with > the recent -Wbuiltin-declaration-mismatch enhancement to detect > calls with incompatible arguments to built-ins declared without > a prototype fails on a few targets due to incorre

Improve ODR warnings

Hi, this patch fixes another problem with ODR warnings (and I hope I am one patch away from closing that PR). As shown in the first testcase Martin attached, we output very confusing warning about wrong alignment of subtype instead of noticing that type contains field of type that already violates

Re: [PATCH 1/6] [RS6000] rs6000_call_template for external call insn assembly output

On Tue, Nov 13, 2018 at 11:17:55PM +1030, Alan Modra wrote: > Version 2. > > This is a first step in tidying rs6000 call patterns, in preparation > to support inline plt calls. Okay for trunk. Thanks for the patch, and for the rework! Segher > * config/rs6000/rs6000-protos.h (rs6000_ca

Re: [PATCH v2] [aarch64] Add CPU support for Ampere Computing's eMAG.

Hi Christoph, On 20/11/18 15:22, Christoph Muellner wrote: Tested with "make check" and no regressions found. *** gcc/ChangeLog *** 2018-xx-xx Christoph Muellner * config/aarch64/aarch64-cores.def: Define emag. * config/aarch64/aarch64-tune.md: Regenerated with emag.

Re: [PATCH v2] [aarch64] Add CPU support for Ampere Computing's eMAG.

> On 20.11.2018, at 17:14, Kyrill Tkachov wrote: > > Hi Christoph, > > On 20/11/18 15:22, Christoph Muellner wrote: >> Tested with "make check" and no regressions found. >> >> *** gcc/ChangeLog *** >> >> 2018-xx-xx Christoph Muellner >> >> * config/aarch64/aarch64-cores.def: Define e

[Committed] S/390: Fix flogr RTX.

The flogr instruction uses a 64 bit register pair target operand. In the RTX we model this as a write to a TImode register. Unfortunately the RTX's being assigned to the two parts of the target operand were swapped. This is no problem if in the end the flogr instruction will be emitted since the

Re: [PATCH 2/6] [RS6000] rs6000_indirect_call_template

Hi Alan, On Tue, Nov 13, 2018 at 11:19:03PM +1030, Alan Modra wrote: > Like the last patch for external calls, now handle most assembly code > for indirect calls in one place. The patch also merges some insns, > correcting some !rs6000_speculate_indirect_jumps cases branching to > LR, which don't

Re: [PATCH v2] [aarch64] Add CPU support for Ampere Computing's eMAG.

On 20/11/18 16:20, Christoph Müllner wrote: On 20.11.2018, at 17:14, Kyrill Tkachov wrote: Hi Christoph, On 20/11/18 15:22, Christoph Muellner wrote: Tested with "make check" and no regressions found. *** gcc/ChangeLog *** 2018-xx-xx Christoph Muellner * config/aarch64/aarch64-

Re: Tweak ALAP calculation in SCHED_PRESSURE_MODEL

On 11/19/18 2:30 PM, Pat Haugen wrote: >> This is a follow-up from >> https://gcc.gnu.org/ml/gcc-patches/2018-11/msg01525.html >> This version introduces an "artificial" property of the dependencies >> produced in >> sched-deps.c that is recorded when they are created due to >> MAX_PENDING_LIST_

Re: Tweak ALAP calculation in SCHED_PRESSURE_MODEL

On 20/11/18 16:48, Pat Haugen wrote: On 11/19/18 2:30 PM, Pat Haugen wrote: This is a follow-up from https://gcc.gnu.org/ml/gcc-patches/2018-11/msg01525.html This version introduces an "artificial" property of the dependencies produced in sched-deps.c that is recorded when they are created du

Re: [PATCH v2] [aarch64] Add CPU support for Ampere Computing's eMAG.

> On 20.11.2018, at 17:43, Kyrill Tkachov wrote: > > On 20/11/18 16:20, Christoph Müllner wrote: >>> On 20.11.2018, at 17:14, Kyrill Tkachov wrote: >>> >>> Hi Christoph, >>> >>> On 20/11/18 15:22, Christoph Muellner wrote: Tested with "make check" and no regressions found. **

Patch ping (Re: [PATCH] Fortran include line fixes and -fdec-include support)

Hi! I'd like to ping this patch, ok for trunk? > 2018-11-12 Jakub Jelinek > Mark Eggleston > > * lang.opt (fdec-include): New option. > * options.c (set_dec_flags): Set also flag_dec_include. > * scanner.c (include_line): Change return type from bool to int. >

Patch ping (was Re: [PATCH] Fix aarch64_compare_and_swap* constraints (PR target/87839))

Hi! On Tue, Nov 13, 2018 at 10:28:16AM +0100, Jakub Jelinek wrote: > 2018-11-13 Jakub Jelinek > > PR target/87839 > * config/aarch64/atomics.md (@aarch64_compare_and_swap): Use > rIJ constraint for aarch64_plus_operand rather than rn. > > * gcc.target/aarch64/pr87839.c

Re: Simplify enumerate and array types

> > Somehow do this first, otherwise 'incomplete' above is useless > work? Well, there are two types but one is main variant of the other. I have restructured the code and avoided the duplicate lookup & code duplication. The attached patch boostraps®tests and I plan to commit it after bit of furt

PING^3: [PATCH] apply_subst_iterator: Handle define_split/define_insn_and_split

On Tue, Nov 13, 2018 at 6:08 AM H.J. Lu wrote: > > On Sun, Nov 4, 2018 at 7:24 AM H.J. Lu wrote: > > > > On Fri, Oct 26, 2018 at 12:44 AM H.J. Lu wrote: > > > > > > On 10/25/18, Uros Bizjak wrote: > > > > On Fri, Oct 26, 2018 at 8:48 AM H.J. Lu wrote: > > > >> > > > >> On 10/25/18, Uros Bizjak

Re: [PATCH 3/6] [RS6000] Replace TLSmode with P, and correct tls call mems

On Tue, Nov 13, 2018 at 11:20:08PM +1030, Alan Modra wrote: > There is really no need to define a TLSmode mode iterator that is > identical (since !TARGET_64BIT == TARGET_32BIT) to the much used P > mode iterator. It's nonsense to think we might ever want to support > 32-bit TLS on 64-bit or vice

PING: V2 [PATCH] i386: Remove duplicated AVX2/AVX512 vec_dup patterns

On Mon, Nov 5, 2018 at 2:02 PM H.J. Lu wrote: > > Hi Richard, Jakub, > > Can you take a look at this patch? The last review from Kirill was in > June. > > Thanks. > > > H.J. > -- > There are many duplicated AVX2/AVX512 vec_dup patterns like: > > (define_insn "avx2_vec_dup" > [(set (match_operan

Re: Tweak ALAP calculation in SCHED_PRESSURE_MODEL

On 11/20/18 10:53 AM, Kyrill Tkachov wrote: > On 20/11/18 16:48, Pat Haugen wrote: >> On 11/19/18 2:30 PM, Pat Haugen wrote: This is a follow-up from https://gcc.gnu.org/ml/gcc-patches/2018-11/msg01525.html This version introduces an "artificial" property of the dependencies p

[PATCH v3] [aarch64] Add CPU support for Ampere Computing's eMAG.

Tested with "make check" and no regressions found. This patch depends on the struct xgene1_prefetch_tune, which has been acknowledged already: https://gcc.gnu.org/ml/gcc-patches/2018-11/msg00985.html *** gcc/ChangeLog *** 2018-xx-xx Christoph Muellner * config/aarch64/aarch64-cores.de

[PATCH] clarify comments for implicit_p flag for built-ins

Would the updated comments in the attached patch more accurately describe the purpose of the IMPLICIT_P flag and the builtin_decl_explicit() and builtin_decl_implicit() functions? I ended up here while trying to understand the differences between the functions on different targets and decide whic

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On Tue, 20 Nov 2018, Jakub Jelinek wrote: > hardcoding /usr/include looks just very wrong here. That should always be > dependent on the configured prefix or better be relative from the driver, > gcc should be relocatable. Or at least come from configure. It should e.g. > honor the sysroot stuf

Re: [PATCH v2 2/3] Add a pass to automatically add ptwrite instrumentation

On Tue, Nov 20, 2018 at 01:04:19PM +0100, Richard Biener wrote: > Since your builtin clobbers memory Hmm, maybe we could get rid of that, but then how to avoid the optimizer moving it around over function calls etc.? The instrumentation should still be useful when the program crashes, so we don't

Re: [PATCH v2 1/3] Allow memory operands for PTWRITE

On Tue, Nov 20, 2018 at 11:53:15AM +0100, Richard Biener wrote: > On Fri, Nov 16, 2018 at 8:07 AM Uros Bizjak wrote: > > > > On Fri, Nov 16, 2018 at 4:57 AM Andi Kleen wrote: > > > > > > From: Andi Kleen > > > > > > The earlier PTWRITE builtin definition was unnecessarily restrictive, > > > only

Re: [PATCH] RISC-V: Pass -mno-relax through to assembler if supported

On 11/18/18 7:28 AM, James Clarke wrote: GCC will emit ".option (no)relax" in its outputted assembly, but when using it as an assembler driver, such as for preprocessed assembly, it's merely preprocessing and therefore will not generate this directive. Therefore we should pass -mno-relax on to th

[PATCH] Fix missing dump_impl_location_t values, using a new dump_metadata_t

The dump_* API attempts to capture emission location metadata for the various dump messages, but looking in -fsave-optimization-record shows that many dump messages are lacking useful impl_location values, instead having this location within dumpfile.c: "impl_location": {

[PATCH v2, target]: Fix PR 88070, ICE in create_pre_exit, at mode-switching.c:438

Hello! Attached patch is a different approach to the problem of split return copies in create_pre_exit. It turns out that for vzeroupper insertion pass, we actually don't need to insert a mode switch before the return copy, it is enough to split edge to exit block - so we can emit vzeroupper at th

Re: Fix PR rtl-optimization/85925

Hi Eric, On Tue, Nov 20, 2018 at 10:05:21AM +0100, Eric Botcazou wrote: > +/* Return true if X is an operation that always operates on the full > + registers for WORD_REGISTER_OPERATIONS architectures. */ > + > +inline bool > +word_register_operation_p (const_rtx x) > +{ > + switch (GET_CODE (

Re: [C++ PATCH] Fix ICE in adjust_temp_type (PR c++/87506)

On Sun, Nov 18, 2018 at 08:33:39PM -0500, Jason Merrill wrote: > On Fri, Nov 16, 2018 at 4:26 PM Jakub Jelinek wrote: > > I admit this is just a shot in the dark, but I don't see why > > one couldn't adjust a type of EMPTY_CLASS_EXPR to EMPTY_CLASS_EXPR > > with a different variant of the same typ

Re: [PATCH] clarify comments for implicit_p flag for built-ins

On 11/20/2018 11:02 AM, Martin Sebor wrote: Would the updated comments in the attached patch more accurately describe the purpose of the IMPLICIT_P flag and the builtin_decl_explicit() and builtin_decl_implicit() functions? I ended up here while trying to understand the differences between the f

[PATCH] Fix up method-nonnull-1.mm testcase on Solaris (PR testsuite/88090)

Hi! The following testcase fails on Solaris, because it doesn't print there 'size_t', but 'std::size_t', as the type is defined by system headers and it is not under gcc control how exactly is size_t defined. The following patch fixes that by using a different typedef which we have total control

[committed] Fix omp simd clone creation for multiple return stmts (PR tree-optimization/87895)

Hi! In certain cases like the testcases below there are multiple return stmts in the function for which we create simd clones and the simd clone adjusting code wasn't handling that case properly, some bbs could end up with non-fallthru edges to the increment bb even without a gimple_goto at the en

[C++ PATCH] Fix ICE in constexpr OBJ_TYPE_REF handling (PR c++/88110)

Hi! The comment in OBJ_TYPE_REF handling code correctly says that we are looking for x.D.2103.D.2094, but it is important that x is not an INDIRECT_REF or something similar as in the following testcase - we can't really devirtualize in that case because we really don't know what it points to. The

[RFC C++ PATCH] Improve locations of id-expressions and operator "" (PR c++/87386)

Hi! This PR is complaining about range covering the first token from an id-expression: pr87386.C:4:15: error: static assertion failed: foo 4 | static_assert(foo::test::value, "foo"); | ^~~ The following patch adjust that to: pr87386.C:4:31: error: static assertion failed: foo 4

Re: [PATCH] handle unusual targets in -Wbuiltin-declaration-mismatch (PR 88098)

On 11/20/2018 08:56 AM, Christophe Lyon wrote: On Mon, 19 Nov 2018 at 22:38, Martin Sebor wrote: The gcc.dg/Wbuiltin-declaration-mismatch-4.c test added with the recent -Wbuiltin-declaration-mismatch enhancement to detect calls with incompatible arguments to built-ins declared without a protot

Re: [RFC C++ PATCH] Improve locations of id-expressions and operator "" (PR c++/87386)

On Tue, 2018-11-20 at 21:57 +0100, Jakub Jelinek wrote: > Hi! > > This PR is complaining about range covering the first token from > an id-expression: > pr87386.C:4:15: error: static assertion failed: foo > 4 | static_assert(foo::test::value, "foo"); > | ^~~ > The following patch a

Re: [PATCH] handle unusual targets in -Wbuiltin-declaration-mismatch (PR 88098)

By calling builtin_decl_explicit rather than builtin_decl_implicit the updated patch in the attachment avoids test failures due to missing warnings on targets with support for long double but whose libc doesn't support C99 functions like fabsl (such as apparently aarch64-linux). Martin On 11/19/

[PATCH 1/6] [og8] Host-to-device transfer coalescing & magic offset value self-documentation

Previously posted upstream: https://gcc.gnu.org/ml/gcc-patches/2018-11/msg00825.html libgomp/ * libgomp.h (OFFSET_INLINED, OFFSET_POINTER, OFFSET_STRUCT): Define. * target.c (FIELD_TGT_EMPTY): Define. (gomp_coalesce_chunk): New. (gomp_coalesce_buf): Use abo

[PATCH 2/6] [og8] Factor out duplicate code in gimplify_scan_omp_clauses

Previously posted upstream: https://gcc.gnu.org/ml/gcc-patches/2018-11/msg00824.html gcc/ * gimplify.c (insert_struct_component_mapping) (check_base_and_compare_lt): New. (gimplify_scan_omp_clauses): Outline duplicated code into calls to above two functions

[PATCH 4/6] [og8] Interaction of dynamic/multidimensional arrays with attach/detach.

OpenACC multidimensional (or "dynamic") arrays do not seem to fit very neatly into the attach/detach mechanism described for OpenACC 2.6, that is if the user tries to use a multidimensional array as a field in a struct. This patch disallows that combination, for now at least. Multidimensional arr

[PATCH 0/6] [og8] OpenACC attach/detach

This patch series is a backport of the OpenACC attach/detach support to the openacc-gcc-8-branch branch. It was previously posted upstream here: https://gcc.gnu.org/ml/gcc-patches/2018-11/msg00823.html This version of the series has been adjusted to account for features on the branch that are no

[PATCH 3/6] [og8] OpenACC 2.6 manual deep copy support (attach/detach)

Previously posted upstream: https://gcc.gnu.org/ml/gcc-patches/2018-11/msg00826.html gcc/c/ * c-parser.c (c_parser_omp_variable_list): Allow deref (->) in variable lists. (c_parser_oacc_all_clauses): Re-alphabetize cases. * c-typeck.c (handle_omp_array_sect

[PATCH 6/6] [og8] OpenACC refcounting refresh

This patch represents a mild overhaul of reference counting for OpenACC in libgomp. It's been partly automatically checked (using code not yet quite finished nor submitted upstream), but it's already more precise than the pre-patch implementation (as demonstrated by adjustments to previously-erro

[PATCH 5/6] [og8] Backport parts of upstream declare-allocate patch

This patch adjusts mappings used for some special cases in Fortran (e.g. allocatable scalars) on og8 to match code that is already upstream, or that has been submitted but not yet reviewed. Parts taken from https://gcc.gnu.org/ml/gcc-patches/2018-09/msg01205.html and parts reverted from https://gc

Re: C++ PATCH to implement P1094R2, Nested inline namespaces

On 11/19/18 5:12 PM, Marek Polacek wrote: On Mon, Nov 19, 2018 at 10:33:17PM +0100, Jakub Jelinek wrote: On Mon, Nov 19, 2018 at 04:21:19PM -0500, Marek Polacek wrote: 2018-11-19 Marek Polacek Implement P1094R2, Nested inline namespaces. * g++.dg/cpp2a/nested-inline-ns1.C: N

Re: [PATCH] v3: C/C++: add fix-it hints for missing '&' and '*' (PR c++/87850)

On Tue, 2018-11-20 at 02:46 +, Joseph Myers wrote: > On Mon, 19 Nov 2018, David Malcolm wrote: > > > +/* C implementation of same_type_p. > > + Returns true iff TYPE1 and TYPE2 are the same type, in the > > usual > > + sense of `same'. */ > > + > > +bool > > +same_type_p (tree type1, tree

Re: [C++ PATCH] Fix ICE in constexpr OBJ_TYPE_REF handling (PR c++/88110)

OK. On Tue, Nov 20, 2018 at 3:51 PM Jakub Jelinek wrote: > > Hi! > > The comment in OBJ_TYPE_REF handling code correctly says that we are > looking for x.D.2103.D.2094, but it is important that x is not an > INDIRECT_REF or something similar as in the following testcase - we can't > really devirtu

Re: [PATCH] v3: C/C++: add fix-it hints for missing '&' and '*' (PR c++/87850)

On Tue, 20 Nov 2018, David Malcolm wrote: > Should I do: You should do whatever is appropriate for the warning in question. But if what's appropriate for the warning in question includes types that are compatible but not the same, the comments need to avoid saying it's about the types being t

Re: [PATCH, libstdc++] Implement P0415 More constexpr for std::complex.

On 11/19/18 6:13 AM, Jonathan Wakely wrote: On 16/11/18 19:39 -0500, Ed Smith-Rowland wrote: @@ -322,67 +323,43 @@   //@{   ///  Return new complex value @a x plus @a y.   template -    inline complex<_Tp> +    inline _GLIBCXX20_CONSTEXPR complex<_Tp>     operator+(const complex<_Tp>& __x, const

Re: [PATCH] Do not mix -fsanitize=thread and -mabi=ms (PR sanitizer/88017).

On 11/20/18 5:22 AM, Martin Liška wrote: > Hi. > > It's very similar to what I did few days ago for -fsanitize=address and > -mabi=ms. > > Patch survives tests on x86_64-linux-gnu and bootstraps. > > Ready for trunk? > Thanks, > Martin > > gcc/ChangeLog: > > 2018-11-20 Martin Liska > >

Re: [PATCH][driver] Ensure --help=params lines end with period

On 11/20/18 4:51 AM, Tom de Vries wrote: > Hi, > > this patch ensures that gcc --help=params lines end with a period by: > - fixing the help message of param HOT_BB_COUNT_FRACTION, and > - adding a test-case. > > Build and tested on x86_64. > > OK for trunk? > > Thanks, > - Tom > > [driver] En

Re: [PATCH, middle-end]: Fix PR 88070, ICE in create_pre_exit, at mode-switching.c:438

On 11/19/18 12:58 PM, Uros Bizjak wrote: > Hello! > > The assert in create_pre_exit at mode-switching.c expects return copy > pair with nothing in between. However, the compiler starts mode > switching pass with the following sequence: > > (insn 19 18 16 2 (set (reg:V2SF 21 xmm0) > (mem/c

Re: [PATCH, middle-end]: Fix PR 88070, ICE in create_pre_exit, at mode-switching.c:438

On 11/20/18 3:24 AM, Uros Bizjak wrote: > On Tue, Nov 20, 2018 at 8:59 AM Eric Botcazou wrote: >> >>> The blockage was introduced as a fix for PR14381 [1] in r79265 [2]. >>> Later, the blockage was moved after return label as a fix for PR25176 >>> [3] in r107871 [4]. >>> >>> After that, r122626 [5

Re: [PATCH][libbacktrace] Factor out read_string

On 11/15/18 9:02 AM, Tom de Vries wrote: > Hi, > > This patch factors out new function read_string in dwarf.c. > > Bootstrapped and reg-tested on x86_64. > > OK for trunk (or, for stage1)? > > Thanks, > - Tom > > [libbacktrace] Factor out read_string > > 2018-11-15 Tom de Vries > >

  1   2   >