Re: [doc PATCH] using multiple format-arg attributes on a single function (PR 87593)

2018-10-11 Thread Martin Sebor
On 10/11/2018 04:38 PM, Joseph Myers wrote: On Thu, 11 Oct 2018, Martin Sebor wrote: Attached is a documentation-only patch to clarify the use case of multiple distinct format_arg attributes on a single function. It's far from obvious that the use case makes sense so explicitly mentioning it sh

Re: [PATCH] Fix pr87156 ICE building libstdc++ for mips64

2018-10-11 Thread Jeff Law
On 10/11/18 4:12 AM, Paul Hua wrote: > Hi: > > The bug pr87156 make MIPS target bootstrap fail a month ago. The > attached patch that posted under bugzilla by Jan Hubicka fixed the > bug. > Bootstrapped and reg-tested on mips64el-linux-gnu and x86_64-pc-linux-gnu. > Considering that Jan not very a

Re: [PATCH] Simplify comparison of attrs in IPA ICF.

2018-10-11 Thread Jeff Law
On 10/11/18 5:48 AM, Martin Liška wrote: > Hi. > > This is simplification in ICF where we can use attribute comparison > function from attrs.c instead of implementing our own. > > Patch survives tests on x86_64-linux-gnu. > Ready for trunk? > Thanks, > Martin > > gcc/ChangeLog: > > 2018-10-10

Re: [doc PATCH] mention interaction with noinline in flatten

2018-10-11 Thread Jeff Law
On 10/11/18 2:58 PM, Martin Sebor wrote: > While writing tests for attribute flatten I wasn't 100% sure > from reading the manual if it would respect attribute noinline > or if it would override it.  Turns out it's the former so > the attached patch mentions it in the manual.  Unless there > are ob

Re: [PATCH, doc] describe mode checking for doloop_end pattern

2018-10-11 Thread Jeff Law
On 10/11/18 3:09 PM, Paul Koning wrote: > Updated with an additional item I just debugged. > > Since the code that uses the doloop_end pattern does not check the operand > mode as given in the pattern, the pattern itself may need to do this, and > that was not documented. In addition, if the do

[doc PATCH] attribute packed does not apply to variables

2018-10-11 Thread Martin Sebor
The manual says that: The packed attribute specifies that a variable or structure field should have the smallest possible alignment--one byte for a variable, and one bit for a field... The variable part doesn't actually reflect reality: GCC and all other compilers I tested ignore the attri

Re: [doc PATCH] attribute packed does not apply to variables

2018-10-11 Thread Jeff Law
On 10/11/18 9:03 PM, Martin Sebor wrote: > The manual says that: > >   The packed attribute specifies that a variable or structure >   field should have the smallest possible alignment--one byte >   for a variable, and one bit for a field... > > The variable part doesn't actually reflect reality:

Re: [PATCH][GCC][testsuite] Fix caching of tests for multiple variant runs and update existing target-supports tests.

2018-10-11 Thread Jeff Law
On 9/27/18 8:13 AM, Tamar Christina wrote: >>> The error you would get if you do this is very confusing so I thought >>> since it didn't matter much for the regexp only target triple tests >>> that just accepting this would be fine. >> Seems a good thing that that's a noisy failure; the function sh

Re: [C++ PATCH] Fix pretty-print of enumerator ids (PR c++/87364)

2018-10-11 Thread Jeff Law
On 10/8/18 11:12 AM, will wray wrote: > Hi, > > A PR to fix Bug 87364 - Pretty print of enumerator never prints the id, > always falls back to C-style cast output > > The fix is tested with the code attached to the bug report and additional > usage over the past few weeks. > > Bootstrap and regt

Re: [PATCH 2/2 v3][IRA,LRA] Fix PR86939, IRA incorrectly creates an interference between a pseudo register and a hard register

2018-10-11 Thread Jeff Law
On 10/11/18 1:23 PM, Peter Bergner wrote: > On 10/11/18 1:18 PM, Peter Bergner wrote: >> Ok, after working in gdb, I see that the PA-RISC port still uses reload >> and not LRA, but it too seems to have the same issue of reusing input >> regs that have REG_DEAD notes, so the question still stands.

Re: [PATCH] Add sinh(tanh(x)) and cosh(tanh(x)) rules

2018-10-11 Thread Jeff Law
On 8/7/18 2:00 PM, Giuliano Augusto Faulin Belinassi wrote: > Related with bug 86829, but for hyperbolic trigonometric functions. > This patch adds substitution rules to both sinh(tanh(x)) -> x / sqrt(1 > - x*x) and cosh(tanh(x)) -> 1 / sqrt(1 - x*x). Notice that the both > formulas has division by

Re: [doc PATCH] attribute packed does not apply to variables

2018-10-11 Thread Eric Gallager
On 10/11/18, Martin Sebor wrote: > The manual says that: > >The packed attribute specifies that a variable or structure >field should have the smallest possible alignment--one byte >for a variable, and one bit for a field... > > The variable part doesn't actually reflect reality: GCC a

Re: [PATCH] add simple attribute introspection

2018-10-11 Thread Eric Gallager
On 10/10/18, Martin Sebor wrote: > While writing tests for fixes and enhancements for attribute > handling I keep finding myself coming up with the same boiler- > plate code to verify whether an attribute has or has not been > successfully applied. It's often error-prone because it > depends on t

Re: [C++ PATCH] Fix pretty-print of enumerator ids (PR c++/87364)

2018-10-11 Thread Christophe Lyon
On Fri, 12 Oct 2018 at 05:37, Jeff Law wrote: > > On 10/8/18 11:12 AM, will wray wrote: > > Hi, > > > > A PR to fix Bug 87364 - Pretty print of enumerator never prints the id, > > always falls back to C-style cast output > > > > The fix is tested with the code attached to the bug report and additi

Re: introduce --enable-mingw-full32 to default to --large-address-aware

2018-10-11 Thread Alexandre Oliva
On Oct 11, 2018, JonY <10wa...@gmail.com> wrote: > On 10/11/2018 02:57 AM, NightStrike wrote: >> >> Except that options typically don't get removed, just deprecated. It >> seems cleaner to me to drop mingw from the name and make it default to >> enabled for cygwin. > It is already enabled for C

Re: C++ PATCH to implement C++20 P0892R2 - explicit(bool) [v2]

2018-10-11 Thread Jason Merrill
On Thu, Oct 11, 2018 at 8:25 PM Marek Polacek wrote: > > On Thu, Oct 11, 2018 at 11:35:23AM -0400, Jason Merrill wrote: > > > + /* [dcl.fct.spec] > > > + "the constant-expression, if supplied, shall be a contextually > > > + converted constant expression of type bool." */

Re: [Patch, Fortran] PR58787 ICE (error recovery) in check_proc_interface

2018-10-11 Thread Paul Richard Thomas
Hi Tobias, This is OK. Thanks for the patch and the extra careful regtesting :-) Paul On Fri, 12 Oct 2018 at 00:17, Tobias Burnus wrote: > > Next patch, next try … > > The problem is the following: We have a use-associated symbol (a > function) – which is once referenced (by use association).

<    1   2