RE: [PATCH][GCC][ARM][AArch64] Testsuite framework changes and execution tests [Patch (8/8)]

2017-10-26 Thread Tamar Christina
Hi James, > > b3e4a2d7f5b0 100644 > > --- a/gcc/doc/sourcebuild.texi > > +++ b/gcc/doc/sourcebuild.texi > > @@ -1684,6 +1684,17 @@ ARM target supports executing instructions from > > ARMv8.2 with the FP16 extension. Some multilibs may be incompatible > with these options. > > Implies arm_v8_2a_

Re: [PATCH] Document --coverage and fork-like functions (PR gcov-profile/82457).

2017-10-26 Thread Martin Liška
On 10/20/2017 06:03 AM, Sandra Loosemore wrote: > On 10/19/2017 12:26 PM, Eric Gallager wrote: >> On 10/19/17, Martin Liška wrote: >>> Hi. >>> >>> As discussed in the PR, we should be more precise in our documentation. >>> The patch does that. >>> >>> Ready for trunk? >>> Martin >>> >>> gcc/Change

Re: Add scatter/gather costs

2017-10-26 Thread Jan Hubicka
> Hi Honza, > > > + /* VGATHERDPD is 23 uops and throughput is 9, VGATHERDPD is 35 uops, > > + throughput 12. Approx 9 uops do not depend on vector size and every > > load > > + is 7 uops. */ > > + 18, 8, /* Gather load static, per_elt. */ > > + 18, 10,

Re: [PATCH][GCC][ARM][AArch64] Testsuite framework changes and execution tests [Patch (8/8)]

2017-10-26 Thread James Greenhalgh
On Thu, Oct 26, 2017 at 08:10:28AM +0100, Tamar Christina wrote: > Hi James, > > > > b3e4a2d7f5b0 100644 > > > --- a/gcc/doc/sourcebuild.texi > > > +++ b/gcc/doc/sourcebuild.texi > > > @@ -1684,6 +1684,17 @@ ARM target supports executing instructions from > > > ARMv8.2 with the FP16 extension. S

[PATCH 2/7] GCOV: introduce usage of terminal colors.

2017-10-26 Thread marxin
I consider using colors in context of gcov as very useful. There's example for tramp3d: https://pste.eu/p/Tl2D.html gcc/ChangeLog: 2017-10-23 Martin Liska * color-macros.h: New file. * diagnostic-color.c: Factor out color related to macros to color-macros.h. *

[PATCH 7/7] GCOV: std::vector refactoring III

2017-10-26 Thread marxin
gcc/ChangeLog: 2017-10-26 Martin Liska * gcov.c (struct name_map): do not use typedef. Define operator== and operator<. (name_search): Remove. (name_sort): Remove. (main): Do not allocate names. (process_file): Add vertical space. (genera

[PATCH 4/7] GCOV: add -j argument (human readable format).

2017-10-26 Thread marxin
Human readable format is quite useful in my opinion. There's example: -:1:unsigned 14.00K:2:loop (unsigned n, int value) -:3:{ 21.00M:4: for (unsigned i = 0; i < n - 1; i++) -:5: { 20.99M:6:value += i; -:7: } -:

[PATCH 3/7] GCOV: add support for lines with an unexecuted lines.

2017-10-26 Thread marxin
It's possible to have a line of code that has a non-zero coverage. However, it can contain unexecuted blocks and I hope adding a notification can be usefull. LLVM also does that: -:0:Source:ternary.c -:0:Graph:ternary.gcno -:0:Data:ternary.gcda -:0:R

[PATCH 1/7] GCOV: document behavior of -fkeep-{static,inline}-functions (PR gcov-profile/82633).

2017-10-26 Thread marxin
gcc/ChangeLog: 2017-10-23 Martin Liska PR gcov-profile/82633 * doc/gcov.texi: Document -fkeep-{static,inline}-functions and their interaction with GCOV infrastructure. * configure.ac: Add -fkeep-{inline,static}-functions to coverage_flags. * conf

[PATCH 5/7] GCOV: std::vector refactoring.

2017-10-26 Thread marxin
gcc/ChangeLog: 2017-10-26 Martin Liska * gcov.c (struct source_info): Remove typedef. (source_info::source_info): Add proper ctor. (accumulate_line_counts): Use struct, not it's typedef. (output_gcov_file): Likewise. (output_lines): Likewise. (ma

[PATCH 0/7] GCOV: another set of improvements

2017-10-26 Thread marxin
Hi. As I've spent recently some time in gcov, I decided to enhance the tool a bit. My main target is PR48463 which will remove assumption that multiple functions can't start on a same line. I've got pending patch that will be send soon. Thanks for review, Martin marxin (7): GCOV: document beha

[PATCH 6/7] GCOV: Vector refactoring II

2017-10-26 Thread marxin
gcc/ChangeLog: 2017-10-26 Martin Liska * gcov.c (struct line_info): Remove it's typedef. (line_info::line_info): Add proper ctor. (line_info::has_block): Do not use a typedef. (struct source_info): Do not use typedef. (circuit): Likewise. (get_cy

[PATCH] Fix DWARF5 .debug_loclist handling with hot/cold partitioning (PR debug/82718)

2017-10-26 Thread Jakub Jelinek
Hi! The code in output_loc_list for DWARF5 relies on dw_loc_list_node's section field accuracy, in particular that nodes with labels in the hot subsection have one section (label) and nodes with labels in the cold subsection have another one. But that is actually not the case, so we end up with c

Re: [006/nnn] poly_int: tree constants

2017-10-26 Thread Richard Sandiford
Martin Sebor writes: > On 10/25/2017 03:31 PM, Richard Sandiford wrote: >> Martin Sebor writes: >>> On 10/23/2017 11:00 AM, Richard Sandiford wrote: +#if NUM_POLY_INT_COEFFS == 1 +extern inline __attribute__ ((__gnu_inline__)) poly_int64 +tree_to_poly_int64 (const_tree t) >>> >>> I

[PING#4, Makefile] improve libsubdir variable transmission to sub-makes

2017-10-26 Thread Olivier Hainque
Hello, ping #4, please. https://gcc.gnu.org/ml/gcc-patches/2017-09/msg00017.html Thanks much in advance, Olivier > On 04 Oct 2017, at 09:16, Olivier Hainque wrote: > > Hello, > > Ping #3 for https://gcc.gnu.org/ml/gcc-patches/2017-09/msg00017.html > > please. > > Took the liberty to cc a

[PATCH 8/N][RFC] GCOV: support multiple functions per a line

2017-10-26 Thread Martin Liška
Hi. As mentioned in cover letter this patch was main motivation for the whole series. Currently we have a list of lines (source_info::lines) per a source file. That's changed in the patch, now each functions has: map> source_lines; Thus separate lines for function for each source file the functio

Re: a new libgcov interface: __gcov_dump_all

2017-10-26 Thread Martin Liška
On 07/22/2014 06:04 PM, Xinliang David Li wrote: > Please take a look the updated patch. It addresses the issue of using > dlclose before dump, and potential races (between a thread closing a > library and the dumper call). > > David > > On Sun, Jul 20, 2014 at 11:12 PM, Nathan Sidwell wrote: >>

Re: [PATCH][GCC][ARM][AArch64] Testsuite framework changes and execution tests [Patch (8/8)]

2017-10-26 Thread Kyrill Tkachov
Hi Tamar, On 06/10/17 13:45, Tamar Christina wrote: Hi All, this is a minor respin of the patch with the comments addressed. Note this patch is now 7/8 in the series. Regtested on arm-none-eabi, armeb-none-eabi, aarch64-none-elf and aarch64_be-none-elf with no issues found. Ok for trunk?

Re: [PATCH, rs6000] Gimple folding for vec_madd()

2017-10-26 Thread Richard Biener
On Wed, Oct 25, 2017 at 4:38 PM, Will Schmidt wrote: > Hi, > > Add support for gimple folding of the vec_madd() (vector multiply-add) > intrinsics. > Testcase coverage is provided by the existing tests > gcc.target/powerpc/fold-vec-madd-*.c > > Sniff-tests appear clean. A full regtest is current

Re: [RFA][PATCH] Convert sprintf warning code to use a dominator walk

2017-10-26 Thread Richard Biener
On Wed, Oct 25, 2017 at 5:44 PM, Jeff Law wrote: > On 10/24/2017 11:35 AM, Martin Sebor wrote: >> On 10/23/2017 05:14 PM, Jeff Law wrote: >>> >>> Martin, >>> >>> I'd like your thoughts on this patch. >>> >>> One of the things I'm working on is changes that would allow passes that >>> use dominator

Re: [RFA][PATCH] Provide a class interface into substitute_and_fold.

2017-10-26 Thread Richard Biener
On Tue, Oct 24, 2017 at 8:44 PM, Jeff Law wrote: > This is similar to the introduction of the ssa_propagate_engine, but for > the substitution/replacements bits. > > In a couple places the pass specific virtual functions are just wrappers > around existing functions. A good example of this is > c

Re: [RFA][PATCH] Don't use wi->info to pass gimple location to array warning callbacks in tree-vrp.c

2017-10-26 Thread Richard Biener
On Wed, Oct 25, 2017 at 7:30 PM, Jeff Law wrote: > > The array dereference warnings in tree-vrp.c use the gimple walkers to > dig down into gimple statements looking for array accesses. I wasn't > keen to convert all the clients of the gimple walkers to C++ classes at > this time. > > And the gim

Re: [PATCH 00/13] Removal of SDB debug info support

2017-10-26 Thread Richard Biener
On Wed, Oct 25, 2017 at 11:24 PM, Jim Wilson wrote: > We have no targets that emit SDB debug info by default. We dropped all > of the SVR3 Unix and embedded COFF targets a while ago. The only > targets that are still able to emit SDB debug info are cygwin, mingw, > and msdosdjgpp. > > I tried a

Re: [PATCH 06/13] remove sdb and -gcoff from non-target files

2017-10-26 Thread Richard Biener
On Wed, Oct 25, 2017 at 11:45 PM, Jim Wilson wrote: > This removes the -gcoff option, and various sdb related references in > non-target files. I also poison SDB_DEBUGGING_INFO and SDB_DEBUG. I > didn't see any point in poisoning the other SDB_* macros, as no one has > used any of them in a very

Re: [PATCH GCC][3/3]Refine CFG and bound information for split loops

2017-10-26 Thread Richard Biener
On Fri, Oct 20, 2017 at 3:08 PM, Bin Cheng wrote: > > > > > > > > From: Richard Biener > Sent: 20 October 2017 12:24 > To: Bin Cheng > Cc: gcc-patches@gcc.gnu.org; nd > Subject: Re: [PATCH GCC][3/3]Refine CFG and bound information for split loops > > On Thu, Oct 19, 2017 at 3:26 PM, Bin Cheng wr

[build, libgcc, libgo] Adapt Solaris 12 references

2017-10-26 Thread Rainer Orth
With the change in the Solaris release model (no more major releases like Solaris 12 but only minor ones like 11.4), the Solaris 12 references in GCC need to be adapted. The following patch does this, consisting mostly of comment changes. Only a few changes bear comment: * Solaris 11.4 introduce

Re: [C++ Patch] PR 65579 ("gcc requires definition of a static constexpr member...")

2017-10-26 Thread Paolo Carlini
Hi again, On 24/10/2017 20:58, Jason Merrill wrote: This seems like an odd place to add the complete_type call. What happens if we change the COMPLETE_TYPE_P (type) in cp_apply_type_quals_to_decl to COMPLETE_TYPE_P (complete_type (type))? Finally I'm back with some information. Simply doing t

[build] Use -xbrace_comment=no with recent Solaris/x86 as

2017-10-26 Thread Rainer Orth
Recent versions of Solaris/x86 as (based on Studio 12.6 fbe) support AVX512 insns, but with a caveat as explained in as(1): -xbrace_comment=yes The assembler treats the text within the braces {} as comments. If you want the text within braces to be treated as regu

[Diagnostic Patch] don't print column zero

2017-10-26 Thread Nathan Sidwell
On the modules branch, I'm starting to add location information. Line numbers don't really make sense when reporting errors reading a binary file, so I wanted to change the diagnostics such that line number zero (which is not a line) is not printed -- one just gets the file name. I then notic

Re: [04/nn] Add a VEC_SERIES rtl code

2017-10-26 Thread Richard Biener
On Mon, Oct 23, 2017 at 1:19 PM, Richard Sandiford wrote: > This patch adds an rtl representation of a vector linear series > of the form: > > a[I] = BASE + I * STEP > > Like vec_duplicate; > > - the new rtx can be used for both constant and non-constant vectors > - when used for constant vector

Re: [05/nn] Add VEC_DUPLICATE_{CST,EXPR} and associated optab

2017-10-26 Thread Richard Biener
On Mon, Oct 23, 2017 at 1:20 PM, Richard Sandiford wrote: > SVE needs a way of broadcasting a scalar to a variable-length vector. > This patch adds VEC_DUPLICATE_CST for when VECTOR_CST would be used for > fixed-length vectors and VEC_DUPLICATE_EXPR for when CONSTRUCTOR would > be used for fixed-l

Re: [08/nn] Add a fixed_size_mode class

2017-10-26 Thread Richard Biener
On Mon, Oct 23, 2017 at 1:22 PM, Richard Sandiford wrote: > This patch adds a fixed_size_mode machine_mode wrapper > for modes that are known to have a fixed size. That applies > to all current modes, but future patches will add support for > variable-sized modes. > > The use of this class should

Re: [09/nn] Add a fixed_size_mode_pod class

2017-10-26 Thread Richard Biener
On Mon, Oct 23, 2017 at 1:22 PM, Richard Sandiford wrote: > This patch adds a POD version of fixed_size_mode. The only current use > is for storing the __builtin_apply and __builtin_result register modes, > which were made fixed_size_modes by the previous patch. Bah - can we update our host comp

Re: [12/nn] Add an is_narrower_int_mode helper function

2017-10-26 Thread Richard Biener
On Mon, Oct 23, 2017 at 1:24 PM, Richard Sandiford wrote: > This patch adds a function for testing whether an arbitrary mode X > is an integer mode that is narrower than integer mode Y. This is > useful for code like expand_float and expand_fix that could in > principle handle vectors as well as

Re: [13/nn] More is_a

2017-10-26 Thread Richard Biener
On Mon, Oct 23, 2017 at 1:25 PM, Richard Sandiford wrote: > alias.c:find_base_term and find_base_value checked: > > if (GET_MODE_SIZE (GET_MODE (src)) < GET_MODE_SIZE (Pmode)) > > but (a) comparing the precision seems more correct, since it's possible > for modes to have the same memory size

Re: [PATCH 8/N][RFC] GCOV: support multiple functions per a line

2017-10-26 Thread Nathan Sidwell
On 10/26/2017 04:44 AM, Martin Liška wrote: Hi. As mentioned in cover letter this patch was main motivation for the whole series. Currently we have a list of lines (source_info::lines) per a source file. That's changed in the patch, now each functions has: map> source_lines; Thus separate lines

Re: [14/nn] Add helpers for shift count modes

2017-10-26 Thread Richard Biener
On Mon, Oct 23, 2017 at 1:25 PM, Richard Sandiford wrote: > This patch adds a stub helper routine to provide the mode > of a scalar shift amount, given the mode of the values > being shifted. > > One long-standing problem has been to decide what this mode > should be for arbitrary rtxes (as oppose

Re: [17/nn] Turn var-tracking.c:INT_MEM_OFFSET into a function

2017-10-26 Thread Richard Biener
On Mon, Oct 23, 2017 at 1:27 PM, Richard Sandiford wrote: > This avoids the double evaluation mentioned in the comments and > simplifies the change to make MEM_OFFSET variable. Ok. Richard. > > 2017-10-23 Richard Sandiford > Alan Hayward > David Sherwood > > gcc/

Re: [16/nn] Factor out the mode handling in lower-subreg.c

2017-10-26 Thread Richard Biener
On Mon, Oct 23, 2017 at 1:27 PM, Richard Sandiford wrote: > This patch adds a helper routine (interesting_mode_p) to lower-subreg.c, > to make the decision about whether a mode can be split and, if so, > calculate the number of bytes and words in the mode. At present this > function always return

Re: [15/nn] Use more specific hash functions in rtlhash.c

2017-10-26 Thread Richard Biener
On Mon, Oct 23, 2017 at 1:26 PM, Richard Sandiford wrote: > Avoid using add_object when we have more specific routines available. Ok. > > 2017-10-23 Richard Sandiford > Alan Hayward > David Sherwood > > gcc/ > * rtlhash.c (add_rtx): Use add_hwi for 'w' and

Re: [19/nn] Don't treat zero-sized ranges as overlapping

2017-10-26 Thread Richard Biener
On Mon, Oct 23, 2017 at 1:29 PM, Richard Sandiford wrote: > Most GCC ranges seem to be represented as an offset and a size (rather > than a start and inclusive end or start and exclusive end). The usual > test for whether X is in a range is of course: > > x >= start && x < start + size > or: >

Re: [21/nn] Minor vn_reference_lookup_3 tweak

2017-10-26 Thread Richard Biener
On Mon, Oct 23, 2017 at 1:30 PM, Richard Sandiford wrote: > The repeated checks for MEM_REF made this code hard to convert to > poly_ints as-is. Hopefully the new structure also makes it clearer > at a glance what the two cases are. > > > 2017-10-23 Richard Sandiford > Alan Hayward

Re: [22/nn] Make dse.c use offset/width instead of start/end

2017-10-26 Thread Richard Biener
On Mon, Oct 23, 2017 at 1:30 PM, Richard Sandiford wrote: > store_info and read_info_type in dse.c represented the ranges as > start/end, but a lot of the internal code used offset/width instead. > Using offset/width throughout fits better with the poly_int.h > range-checking functions. Ok. Rich

Re: [RFC, PR 80689] Copy small aggregates element-wise

2017-10-26 Thread Martin Jambor
Hi, On Tue, Oct 17, 2017 at 01:34:54PM +0200, Richard Biener wrote: > On Fri, Oct 13, 2017 at 6:13 PM, Martin Jambor wrote: > > Hi, > > > > I'd like to request comments to the patch below which aims to fix PR > > 80689, which is an instance of a store-to-load forwarding stall on > > x86_64 CPUs i

Re: [09/nn] Add a fixed_size_mode_pod class

2017-10-26 Thread Richard Sandiford
Richard Biener writes: > On Mon, Oct 23, 2017 at 1:22 PM, Richard Sandiford > wrote: >> This patch adds a POD version of fixed_size_mode. The only current use >> is for storing the __builtin_apply and __builtin_result register modes, >> which were made fixed_size_modes by the previous patch. > >

Re: [PATCH] Fix test-suite fallout of default -Wreturn-type.

2017-10-26 Thread Martin Liška
On 10/24/2017 04:39 PM, Jason Merrill wrote: > On 10/18/2017 08:48 AM, Martin Liška wrote: >> This is second patch that addresses test-suite fallout. All these tests fail >> because -Wreturn-type is >> now on by default. > >> +++ b/gcc/testsuite/g++.dg/cpp0x/constexpr-diag3.C >> -constexpr T g(T

Re: [06/nn] Add VEC_SERIES_{CST,EXPR} and associated optab

2017-10-26 Thread Richard Biener
On Mon, Oct 23, 2017 at 1:20 PM, Richard Sandiford wrote: > Similarly to the VEC_DUPLICATE_{CST,EXPR}, this patch adds two > tree code equivalents of the VEC_SERIES rtx code. VEC_SERIES_EXPR > is for non-constant inputs and is a normal tcc_binary. VEC_SERIES_CST > is a tcc_constant. > > Like VEC

Re: [06/nn] Add VEC_SERIES_{CST,EXPR} and associated optab

2017-10-26 Thread Richard Biener
On Thu, Oct 26, 2017 at 2:23 PM, Richard Biener wrote: > On Mon, Oct 23, 2017 at 1:20 PM, Richard Sandiford > wrote: >> Similarly to the VEC_DUPLICATE_{CST,EXPR}, this patch adds two >> tree code equivalents of the VEC_SERIES rtx code. VEC_SERIES_EXPR >> is for non-constant inputs and is a norma

Re: [14/nn] Add helpers for shift count modes

2017-10-26 Thread Richard Biener
On Thu, Oct 26, 2017 at 2:06 PM, Richard Biener wrote: > On Mon, Oct 23, 2017 at 1:25 PM, Richard Sandiford > wrote: >> This patch adds a stub helper routine to provide the mode >> of a scalar shift amount, given the mode of the values >> being shifted. >> >> One long-standing problem has been to

Re: [18/nn] Use (CONST_VECTOR|GET_MODE)_NUNITS in simplify-rtx.c

2017-10-26 Thread Richard Biener
On Mon, Oct 23, 2017 at 1:28 PM, Richard Sandiford wrote: > This patch avoids some calculations of the form: > > GET_MODE_SIZE (vector_mode) / GET_MODE_SIZE (element_mode) > > in simplify-rtx.c. If we're dealing with CONST_VECTORs, it's better > to use CONST_VECTOR_NUNITS, since that remains co

Re: [RFC, PR 80689] Copy small aggregates element-wise

2017-10-26 Thread Richard Biener
On Thu, Oct 26, 2017 at 2:18 PM, Martin Jambor wrote: > Hi, > > On Tue, Oct 17, 2017 at 01:34:54PM +0200, Richard Biener wrote: >> On Fri, Oct 13, 2017 at 6:13 PM, Martin Jambor wrote: >> > Hi, >> > >> > I'd like to request comments to the patch below which aims to fix PR >> > 80689, which is an

Re: [09/nn] Add a fixed_size_mode_pod class

2017-10-26 Thread Richard Biener
On Thu, Oct 26, 2017 at 2:18 PM, Richard Sandiford wrote: > Richard Biener writes: >> On Mon, Oct 23, 2017 at 1:22 PM, Richard Sandiford >> wrote: >>> This patch adds a POD version of fixed_size_mode. The only current use >>> is for storing the __builtin_apply and __builtin_result register mode

Re: [C++ PATCH] Kill IDENTIFIER_LABEL_VALUE

2017-10-26 Thread Nathan Sidwell
On 10/25/2017 05:36 PM, Nathan Sidwell wrote: This patch removes 'label_value' from lang_identifier, shrinking it from 72 to 64 bytes (on 64-bit machine).   We replace this by augmenting the already used per-function named_labels hash table.  This is a major win, because labels are extremely ra

Re: [RFC, PR 80689] Copy small aggregates element-wise

2017-10-26 Thread Jan Hubicka
> I think the limit should be on the number of generated copies and not > the overall size of the structure... If the struct were composed of > 32 individual chars we wouldn't want to emit 32 loads and 32 stores... > > I wonder how rep; movb; interacts with store to load forwarding? Is > that ma

Re: [PATCH PR79868 ][aarch64] Fix error calls in aarch64 code so they can be translated (version 2)

2017-10-26 Thread Richard Earnshaw (lists)
On 26/09/17 00:25, Steve Ellcey wrote: > This is a new version of my patch to fix PR target/79868, where some > error messages are impossible to translate correctly due to how the > strings are dynamically constructed.  It also includes some format > changes in the error messags to make the message

Re: [PING][PATCH][Aarch64] Improve int<->FP conversions

2017-10-26 Thread James Greenhalgh
On Tue, Oct 24, 2017 at 10:47:32PM +0100, Michael Collison wrote: > James, > > The patch was test as required. However when I tested with the latest trunk > there were two test failures that need to be updated because of my patch. > > The files gcc.target/aarch64/vect-vcvt.c was failing because

Re: [PATCH 00/13] Removal of SDB debug info support

2017-10-26 Thread Jeff Law
On 10/26/2017 03:33 AM, Richard Biener wrote: > On Wed, Oct 25, 2017 at 11:24 PM, Jim Wilson wrote: >> We have no targets that emit SDB debug info by default. We dropped all >> of the SVR3 Unix and embedded COFF targets a while ago. The only >> targets that are still able to emit SDB debug info

Re: [RFC, PR 80689] Copy small aggregates element-wise

2017-10-26 Thread Michael Matz
Hi, On Thu, 26 Oct 2017, Martin Jambor wrote: > > 35 bytes seems to be much - what is the code-size impact? > > I will find out and report on that. I need at least 32 bytes (four > long ints) to fix imagemagick, where the problematic structure is: Surely the final heuristic should look at the

[Patch obvious][arm testsuite] Fixup expected location in require-pic-register-loc.c

2017-10-26 Thread James Greenhalgh
Hi, After r254010 we now add -gcolumn-info by default, that means the tests in gcc.target/arm/require-pic-register-loc.c need adjusting to not expect to see column zero. That's the obvious fix, and just extends what Jakub did in r254010 so I've applied it as r254106. Thanks, James --- 2017-10-

Re: [PATCH, rs6000] Gimple folding for vec_madd()

2017-10-26 Thread Will Schmidt
On Thu, 2017-10-26 at 11:05 +0200, Richard Biener wrote: > On Wed, Oct 25, 2017 at 4:38 PM, Will Schmidt > wrote: > > Hi, > > > > Add support for gimple folding of the vec_madd() (vector multiply-add) > > intrinsics. > > Testcase coverage is provided by the existing tests > > gcc.target/powerpc/

Re: [Diagnostic Patch] don't print column zero

2017-10-26 Thread David Malcolm
[CCing Rainer and Mike for the gcc-dg.exp part] On Thu, 2017-10-26 at 07:33 -0400, Nathan Sidwell wrote: > On the modules branch, I'm starting to add location > information. Line > numbers don't really make sense when reporting errors reading a > binary > file, so I wanted to change the diagnos

Re: [v3 PATCH] Deduction guides for associative containers, debug mode deduction guide fixes.

2017-10-26 Thread Jonathan Wakely
On 17/10/17 22:48 +0300, Ville Voutilainen wrote: Tested on Linux-PPC64. The debug mode fixes have been tested manually and individually on Linux-x64. 2017-10-17 Ville Voutilainen Deduction guides for associative containers, debug mode deduction guide fixes. * include/bits/stl_algobase

Re: [RFC, PR 80689] Copy small aggregates element-wise

2017-10-26 Thread Richard Biener
On Thu, Oct 26, 2017 at 2:55 PM, Jan Hubicka wrote: >> I think the limit should be on the number of generated copies and not >> the overall size of the structure... If the struct were composed of >> 32 individual chars we wouldn't want to emit 32 loads and 32 stores... >> >> I wonder how rep; mov

Re: [Diagnostic Patch] don't print column zero

2017-10-26 Thread Nathan Sidwell
On 10/26/2017 10:34 AM, David Malcolm wrote: [CCing Rainer and Mike for the gcc-dg.exp part] Alternate idea: could show_column become a tri-state: * default: show non-zero columns * never: never show columns * always: always show a column, printing 0 for the no-column case and then us

Re: [PATCH] Improve alloca alignment

2017-10-26 Thread Jeff Law
On 10/05/2017 03:16 AM, Richard Biener wrote: > On Thu, Oct 5, 2017 at 1:07 AM, Jeff Law wrote: >> On 10/04/2017 08:53 AM, Eric Botcazou wrote: This seems like a SPARC target problem to me -- essentially it's claiming a higher STACK_BOUNDARY than it really has. >>> >>> No, it is not, I

Re: [PATCH] Improve alloca alignment

2017-10-26 Thread Jeff Law
On 10/17/2017 06:04 AM, Wilco Dijkstra wrote: > Wilco Dijkstra wrote: >> >> Yes STACK_BOUNDARY applies to virtual_stack_dynamic_rtx and all other >> virtual frame registers. It appears it's main purpose is to enable alignment >> optimizations since PREFERRED_STACK_BOUNDARY is used to align >> local

Re: [PATCH] Fix nrv-1.c false failure on aarch64.

2017-10-26 Thread Jeff Law
On 10/18/2017 10:59 AM, Egeyar Bagcioglu wrote: > Hello, > > Test case "guality.exp=nrv-1.c" fails on aarch64. Optimizations reorder > the instructions and cause the value of a variable to be checked before > its first assignment. The following patch is moving the > break point to the end of the f

Re: [v3 PATCH] Deduction guides for associative containers, debug mode deduction guide fixes.

2017-10-26 Thread Jonathan Wakely
On 26/10/17 15:36 +0100, Jonathan Wakely wrote: On 17/10/17 22:48 +0300, Ville Voutilainen wrote: Tested on Linux-PPC64. The debug mode fixes have been tested manually and individually on Linux-x64. 2017-10-17 Ville Voutilainen Deduction guides for associative containers, debug mode deduc

Re: [RFC, PR 80689] Copy small aggregates element-wise

2017-10-26 Thread Richard Biener
On Thu, Oct 26, 2017 at 4:38 PM, Richard Biener wrote: > On Thu, Oct 26, 2017 at 2:55 PM, Jan Hubicka wrote: >>> I think the limit should be on the number of generated copies and not >>> the overall size of the structure... If the struct were composed of >>> 32 individual chars we wouldn't want

Re: [PATCH][AArch64] Improve addressing of TI/TFmode

2017-10-26 Thread James Greenhalgh
On Thu, Jul 20, 2017 at 01:49:03PM +0100, Wilco Dijkstra wrote: > In https://gcc.gnu.org/ml/gcc-patches/2017-06/msg01125.html Jiong > pointed out some addressing inefficiencies due to a recent change in > regcprop (https://gcc.gnu.org/ml/gcc-patches/2017-04/msg00775.html). > > This patch improves

Re: [PATCH, rs6000] Gimple folding for vec_madd()

2017-10-26 Thread Richard Biener
On Thu, Oct 26, 2017 at 4:30 PM, Will Schmidt wrote: > On Thu, 2017-10-26 at 11:05 +0200, Richard Biener wrote: >> On Wed, Oct 25, 2017 at 4:38 PM, Will Schmidt >> wrote: >> > Hi, >> > >> > Add support for gimple folding of the vec_madd() (vector multiply-add) >> > intrinsics. >> > Testcase cove

Re: [PATCH, rs6000] Gimple folding for vec_madd()

2017-10-26 Thread Richard Biener
On Thu, Oct 26, 2017 at 5:13 PM, Richard Biener wrote: > On Thu, Oct 26, 2017 at 4:30 PM, Will Schmidt > wrote: >> On Thu, 2017-10-26 at 11:05 +0200, Richard Biener wrote: >>> On Wed, Oct 25, 2017 at 4:38 PM, Will Schmidt >>> wrote: >>> > Hi, >>> > >>> > Add support for gimple folding of the v

Re: [PATCH][AArch64] Simplify frame layout for stack probing

2017-10-26 Thread James Greenhalgh
On Tue, Jul 25, 2017 at 02:58:04PM +0100, Wilco Dijkstra wrote: > This patch makes some changes to the frame layout in order to simplify > stack probing. We want to use the save of LR as a probe in any non-leaf > function. With shrinkwrapping we may only save LR before a call, so it > is useful t

Re: [PATCH] Improve alloca alignment

2017-10-26 Thread Richard Biener
On Thu, Oct 26, 2017 at 4:55 PM, Jeff Law wrote: > On 10/17/2017 06:04 AM, Wilco Dijkstra wrote: >> Wilco Dijkstra wrote: >>> >>> Yes STACK_BOUNDARY applies to virtual_stack_dynamic_rtx and all other >>> virtual frame registers. It appears it's main purpose is to enable alignment >>> optimizations

Re: [PATCH, rs6000] Gimple folding for vec_madd()

2017-10-26 Thread Will Schmidt
On Thu, 2017-10-26 at 17:18 +0200, Richard Biener wrote: > On Thu, Oct 26, 2017 at 5:13 PM, Richard Biener > wrote: > > On Thu, Oct 26, 2017 at 4:30 PM, Will Schmidt > > wrote: > >> On Thu, 2017-10-26 at 11:05 +0200, Richard Biener wrote: > >>> On Wed, Oct 25, 2017 at 4:38 PM, Will Schmidt > >

[PATCH] Fix PR81659

2017-10-26 Thread Richard Biener
The following fixes lower_eh_dispatch destroying dominator info that was still live from previous passes. This clears it from the obvious place (when we think we might have created unreachable blocks). Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2017-10-26 Richard

Re: [PATCH][AArch64] Improve aarch64_legitimate_constant_p

2017-10-26 Thread James Greenhalgh
On Fri, Jul 07, 2017 at 12:28:11PM +0100, Wilco Dijkstra wrote: > This patch further improves aarch64_legitimate_constant_p. Allow all > integer, floating point and vector constants. Allow label references > and non-anchor symbols with an immediate offset. This allows such > constants to be rema

Re: [PATCH, rs6000] 2/2 Add x86 SSE2 intrinsics to GCC PPC64LE target

2017-10-26 Thread Steven Munroe
On Wed, 2017-10-25 at 18:37 -0500, Segher Boessenkool wrote: > Hi! > > On Tue, Oct 17, 2017 at 01:27:16PM -0500, Steven Munroe wrote: > > This it part 2/2 for contributing PPC64LE support for X86 SSE2 > > instrisics. This patch includes testsuite/gcc.target tests for the > > intrinsics included by

Re: [RFA][PATCH] Convert sprintf warning code to use a dominator walk

2017-10-26 Thread Jeff Law
On 10/26/2017 03:09 AM, Richard Biener wrote: > On Wed, Oct 25, 2017 at 5:44 PM, Jeff Law wrote: >> On 10/24/2017 11:35 AM, Martin Sebor wrote: >>> On 10/23/2017 05:14 PM, Jeff Law wrote: Martin, I'd like your thoughts on this patch. One of the things I'm working on i

Re: [PATCH][AArch64] Introduce emit_frame_chain

2017-10-26 Thread James Greenhalgh
On Fri, Aug 04, 2017 at 01:26:15PM +0100, Wilco Dijkstra wrote: > The current frame code combines the separate concepts of a frame chain > (saving old FP,LR in a record and pointing new FP to it) and a frame > pointer used to access locals. Add emit_frame_chain to the aarch64_frame > descriptor an

Re: [v3 PATCH] Deduction guides for associative containers, debug mode deduction guide fixes.

2017-10-26 Thread Ville Voutilainen
On 26 October 2017 at 18:04, Jonathan Wakely wrote: > Also, please put the deduction guides for a class immediately after > the definition of that class, rather than grouping all the guides for > unordered_map and unordered_multimap together. Alright. 2017-10-26 Ville Voutilainen Deduct

Re: [v3 PATCH] Deduction guides for associative containers, debug mode deduction guide fixes.

2017-10-26 Thread Jonathan Wakely
On 26/10/17 19:23 +0300, Ville Voutilainen wrote: On 26 October 2017 at 18:04, Jonathan Wakely wrote: Also, please put the deduction guides for a class immediately after the definition of that class, rather than grouping all the guides for unordered_map and unordered_multimap together. Alrig

Re: [PATCH] Document --coverage and fork-like functions (PR gcov-profile/82457).

2017-10-26 Thread Sandra Loosemore
On 10/26/2017 01:21 AM, Martin Liška wrote: On 10/20/2017 06:03 AM, Sandra Loosemore wrote: On 10/19/2017 12:26 PM, Eric Gallager wrote: On 10/19/17, Martin Liška wrote: Hi. As discussed in the PR, we should be more precise in our documentation. The patch does that. Ready for trunk? Martin

Re: [006/nnn] poly_int: tree constants

2017-10-26 Thread Martin Sebor
/* The tree and const_tree overload templates. */ namespace wi { + class unextended_tree + { + private: +const_tree m_t; + + public: +unextended_tree () {} Defining no-op ctors is quite dangerous and error-prone. I suggest to instead default initialize the member(s): unexte

[PATCH] RISC-V: Correct and improve the "-mabi" documentation

2017-10-26 Thread Palmer Dabbelt
The documentation for the "-mabi" argument on RISC-V was incorrect. We chose to treat this as a documentation bug rather than a code bug, and to make the documentation match what GCC currently does. In the process, I also improved the documentation a bit. Thanks to Alex Bradbury for finding the

Re: [RFA][PATCH] Provide a class interface into substitute_and_fold.

2017-10-26 Thread Jeff Law
On 10/26/2017 03:24 AM, Richard Biener wrote: > On Tue, Oct 24, 2017 at 8:44 PM, Jeff Law wrote: >> This is similar to the introduction of the ssa_propagate_engine, but for >> the substitution/replacements bits. >> >> In a couple places the pass specific virtual functions are just wrappers >> arou

Re: Rename cxx1998 into normal

2017-10-26 Thread Daniel Krügler
2017-10-26 7:51 GMT+02:00 François Dumont : > Hi > > We once talk about rename the __cxx1998 namespace into something less > C++98 biased. Here is the patch to do so. > > Ok with the new name ? IMO the name should somehow still contain "cxx" somewhere, otherwise this could easily cause a s

Re: [PATCH] expand -fdebug-prefix-map documentation

2017-10-26 Thread Sandra Loosemore
On 10/25/2017 06:26 PM, Jim Wilson wrote: Index: gcc/doc/invoke.texi === --- gcc/doc/invoke.texi (revision 254023) +++ gcc/doc/invoke.texi (working copy) @@ -6981,7 +6981,12 @@ link processing time. Merging is enabled by defau @it

Re: Rename cxx1998 into normal

2017-10-26 Thread Jonathan Wakely
On 26/10/17 18:55 +0200, Daniel Krügler wrote: 2017-10-26 7:51 GMT+02:00 François Dumont : Hi We once talk about rename the __cxx1998 namespace into something less C++98 biased. Here is the patch to do so. Ok with the new name ? IMO the name should somehow still contain "cxx" somewhe

[PATCH] Change default optimization level to -Og

2017-10-26 Thread Wilco Dijkstra
GCC's default optimization level is -O0. Unfortunately unlike other compilers, GCC generates extremely inefficient code with -O0. It is almost unusable for low-level debugging or manual inspection of generated code. So a -O option is always required for compilation. -Og not only allows for fast

PING Re: [patch] configure option to override TARGET_LIBC_PROVIDES_SSP

2017-10-26 Thread Sandra Loosemore
This one. https://gcc.gnu.org/ml/gcc-patches/2017-10/msg00537.html There was discussion about documenting this, but the actual configure change hasn't been reviewed yet. -Sandra

Re: [PATCH], Enable IBM/IEEE long double format to overriden more easily

2017-10-26 Thread Michael Meissner
On Wed, Oct 25, 2017 at 07:11:07PM -0500, Segher Boessenkool wrote: > Hi Mike, > > On Sat, Oct 21, 2017 at 09:09:58AM -0400, Michael Meissner wrote: > > As Segher and I were discussing off-line, I have some problems with the > > current > > -mabi={ieee,ibm}longdouble switches as we start to plann

Re: [PATCH] expand -fdebug-prefix-map documentation

2017-10-26 Thread Gerald Pfeifer
On Wed, 25 Oct 2017, Jim Wilson wrote: > The current documentation doesn't explain what the option is for, or > how one might use it.  The attached patch expands the documentation a > bit to try to explain this. > OK? Thanks you for fleshing this out, Jim! This looks fine to me (modula Sandra's

Re: [006/nnn] poly_int: tree constants

2017-10-26 Thread Richard Sandiford
Martin Sebor writes: >> /* The tree and const_tree overload templates. */ >> namespace wi >> { >> + class unextended_tree >> + { >> + private: >> +const_tree m_t; >> + >> + public: >> +unextended_tree () {} > > Defining no-op ctors i

Re: [006/nnn] poly_int: tree constants

2017-10-26 Thread Pedro Alves
On 10/26/2017 05:37 PM, Martin Sebor wrote: > I agree that the latter use case is more common in GCC, but I don't > see it as a good thing. GCC was written in C and most code still > uses now outdated C practices such as declaring variables at the top > of a (often long) function, and usually wit

Re: [RFA][PATCH] Provide a class interface into substitute_and_fold.

2017-10-26 Thread Richard Biener
On October 26, 2017 6:50:15 PM GMT+02:00, Jeff Law wrote: >On 10/26/2017 03:24 AM, Richard Biener wrote: >> On Tue, Oct 24, 2017 at 8:44 PM, Jeff Law wrote: >>> This is similar to the introduction of the ssa_propagate_engine, but >for >>> the substitution/replacements bits. >>> >>> In a couple pl

Re: [Diagnostic Patch] don't print column zero

2017-10-26 Thread Eric Gallager
On 10/26/17, Nathan Sidwell wrote: > On 10/26/2017 10:34 AM, David Malcolm wrote: >> [CCing Rainer and Mike for the gcc-dg.exp part] > >> Alternate idea: could show_column become a tri-state: >>* default: show non-zero columns >>* never: never show columns >>* always: always show a col

Re: [PATCH] Change default optimization level to -Og

2017-10-26 Thread Eric Gallager
On 10/26/17, Wilco Dijkstra wrote: > GCC's default optimization level is -O0. Unfortunately unlike other > compilers, > GCC generates extremely inefficient code with -O0. It is almost unusable > for > low-level debugging or manual inspection of generated code. So a -O option > is > always requi

Re: [patch][i386, AVX] Adding missing CMP* intrinsics

2017-10-26 Thread Kirill Yukhin
Hello Olga, Sebastian, On 20 Oct 08:36, Peryt, Sebastian wrote: > Hi, > > This patch written by Olga Makhotina adds listed below missing intrinsics: > _mm512_[mask_]cmpeq_[pd|ps]_mask > _mm512_[mask_]cmple_[pd|ps]_mask > _mm512_[mask_]cmplt_[pd|ps]_mask > _mm512_[mask_]cmpneq_[pd|ps]_mask > _mm512

Re: [Diagnostic Patch] don't print column zero

2017-10-26 Thread Nathan Sidwell
On 10/26/2017 02:12 PM, Eric Gallager wrote: On 10/26/17, Nathan Sidwell wrote: On 10/26/2017 10:34 AM, David Malcolm wrote: Possibly a silly question, but is it OK to have a formatted string call in which some of the arguments aren't consumed? (here "col" is only consumed for the true case,

  1   2   >