Re: [PATCH 5/9] regrename: Don't run if function was separately shrink-wrapped

2016-09-14 Thread Jeff Law
On 09/14/2016 01:10 PM, Segher Boessenkool wrote: On Wed, Sep 14, 2016 at 11:52:02AM -0600, Jeff Law wrote: Yea, it'll certainly do that and I can imagine a design which would have that property. And there's other designs which benefit from spreading across the register file as much as possible

Re: [PATCH 5/9] regrename: Don't run if function was separately shrink-wrapped

2016-09-14 Thread Jeff Law
On 09/14/2016 01:03 PM, Segher Boessenkool wrote: If you think about it, conceptually we want the return insn to make the callee saved registers "used" so that DCE, regrename and friends don't muck with them. The fact that we don't is as much never having to care all that much until recently.

Re: [PATCH 5/9] regrename: Don't run if function was separately shrink-wrapped

2016-09-14 Thread Jeff Law
On 09/14/2016 01:03 PM, Segher Boessenkool wrote: (There is no return insn at those exits; these are exits *without* successor block, not the exit block). Hmm, I thought these were return blocks, but you're saying they're no-return blocks? I missed that. In that case, aren't the restores dea

Re: [PATCHv3] Add a warning for suspicious use of conditional expressions in boolean context

2016-09-14 Thread Bernd Edlinger
... resent, because message apparently bounced. On 09/14/16 21:22, Bernd Edlinger wrote: > On 09/14/16 20:11, Jason Merrill wrote: >>> >>> Yes. The reasoning I initially had was that it is completely >>> pointless to have something of the form "if (x ? 1 : 2)" or >>> "if (x ? 0 : 0)" because the

[PATCH,committed] Infer architecture from ABI for mips-img* and mips-mti*

2016-09-14 Thread Matthew Fortune
This patch allows the -mabi=n32 and -mabi=64 options to automatically infer the of a 64-bit architecture in the mips-mti-* and mips-img-* triplets. The default 64-bit architecture is mips64r2 for MTI and mips64r6 for IMG. Thanks, Matthew gcc/ * config.gcc (mips*-mti-elf*, mips*-mti-linux*

Re: debug container mutex association

2016-09-14 Thread François Dumont
On 14/09/2016 11:00, Jonathan Wakely wrote: On 13/09/16 22:37 +0200, François Dumont wrote: Hi When I proposed to change std::hash for pointers my plan was to use this approach for the debug containers. So here is the patch leveraging on this technique to avoid going through _Hash_impl to

Re: Verify package integrity of downloaded prerequisites (partially fixes 61439)

2016-09-14 Thread Moritz Klammler
Joseph Myers writes: > On Wed, 14 Sep 2016, Moritz Klammler wrote: > >> Ok, I didn't know about the workflow. Do you think I should dike the >> `--strip-sums` option out again then? > > I don't see any use for such an option. Anyone changing the versions > should always have a copy of the new

libgo patch committed: Fix typo in libgo/configure.ac

2016-09-14 Thread Ian Lance Taylor
This patch fixes a typo in libgo/configure.ac (PCQUANTUm -> PCQUANTUM). Bootstrapped on x86_64-pc-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE === --- gcc/go/gofrontend/MERGE (revision 240083) +++ gcc/go/

Re: [RFC][IPA-VRP] Early VRP Implementation

2016-09-14 Thread Jan Hubicka
> + /* Visit PHI stmts and discover any new VRs possible. */ > + gimple_stmt_iterator gsi; > + for (gphi_iterator gpi = gsi_start_phis (bb); > + !gsi_end_p (gpi); gsi_next (&gpi)) > +{ > + gphi *phi = gpi.phi (); > + tree lhs = PHI_RESULT (phi); > + value_range vr_resul

Re: Verify package integrity of downloaded prerequisites (partially fixes 61439)

2016-09-14 Thread Mike Stump
On Sep 14, 2016, at 1:19 PM, Moritz Klammler wrote: > > Joseph Myers writes: > >> On Wed, 14 Sep 2016, Moritz Klammler wrote: >> >>> Ok, I didn't know about the workflow. Do you think I should dike the >>> `--strip-sums` option out again then? >> >> I don't see any use for such an option. A

Patch ping

2016-09-14 Thread Jakub Jelinek
Hi! I'd like to ping a couple of patches: C++ === http://gcc.gnu.org/ml/gcc-patches/2016-08/msg01995.html - PR77375 - wrong-code with mutable members in base classes http://gcc.gnu.org/ml/gcc-patches/2016-08/msg01998.html - PR77338 - fix constexpr ICE on PARM_DECL with incomplete type http

[PATCH] PR fortran/77420 -- take two

2016-09-14 Thread Steve Kargl
The attached patch appears to fix PR fortran/77420 without causing regressions. The problem raised by Andrew Benson at https://gcc.gnu.org/ml/fortran/2016-09/msg00039.html contained in pr77420_3.f90 and pr77420_4.f90. The original testcase from the PR is in pr77420_1.f90 and a variation on that t

Re: [PATCH 3/9] selftest.h: add temp_override fixture

2016-09-14 Thread Trevor Saunders
On Thu, Sep 08, 2016 at 08:30:47PM -0400, David Malcolm wrote: > We have a lot of global state in our code. Ideally we'd reduce the > amount of such global state, but a prerequisite for sane refactoring > is having automated testing in place to ensure that the refactoring > doesn't break anything.

Re: [PATCH 5/9] regrename: Don't run if function was separately shrink-wrapped

2016-09-14 Thread Segher Boessenkool
On Wed, Sep 14, 2016 at 01:33:04PM -0600, Jeff Law wrote: > On 09/14/2016 01:03 PM, Segher Boessenkool wrote: > >>If you think about it, conceptually we want the return insn to make the > >>callee saved registers "used" so that DCE, regrename and friends don't > >>muck with them. The fact that we

Re: [PATCH 5/9] regrename: Don't run if function was separately shrink-wrapped

2016-09-14 Thread Segher Boessenkool
On Wed, Sep 14, 2016 at 01:35:57PM -0600, Jeff Law wrote: > On 09/14/2016 01:03 PM, Segher Boessenkool wrote: > > > >(There is no return insn at those exits; these are exits *without* > >successor block, not the exit block). > Hmm, I thought these were return blocks, but you're saying they're > no

Re: [PING] set libfunc entry for sdivmod_optab to NULL in optabs.def

2016-09-14 Thread Richard Sandiford
Prathamesh Kulkarni writes: > Hi, > I would like to ping the following patch: > https://gcc.gnu.org/ml/gcc-patches/2016-08/msg01015.html > > While implementing divmod transform: > https://gcc.gnu.org/ml/gcc-patches/2016-05/msg01757.html > > I ran into an issue with optab_libfunc(). > It appears o

Re: [PING] set libfunc entry for sdivmod_optab to NULL in optabs.def

2016-09-14 Thread Richard Sandiford
Richard Sandiford writes: > Prathamesh Kulkarni writes: >> Hi, >> I would like to ping the following patch: >> https://gcc.gnu.org/ml/gcc-patches/2016-08/msg01015.html >> >> While implementing divmod transform: >> https://gcc.gnu.org/ml/gcc-patches/2016-05/msg01757.html >> >> I ran into an issue

Re: [PATCH, 5.x/6.x/7.x] Be more conservative in early inliner if FDO is enabled

2016-09-14 Thread Yuan, Pengfei
> I think the approach is reasonable though it might still have > interesting effects on > optimization for very small growth. So for further experimenting it > would be nice Test it on SPEC CPU with FDO enabled? > to have a separate PARAM_EARLY_FDO_INLINING_INSNS or maybe simply > adjust the PA

Re: [PATCH] PR fortran/77420 -- take two

2016-09-14 Thread Jerry DeLisle
On 09/14/2016 02:49 PM, Steve Kargl wrote: The attached patch appears to fix PR fortran/77420 without causing regressions. The problem raised by Andrew Benson at https://gcc.gnu.org/ml/fortran/2016-09/msg00039.html contained in pr77420_3.f90 and pr77420_4.f90. The original testcase from the PR

Re: [patch] [gsoc] [gimplefe] GIMPLE FE Project

2016-09-14 Thread Prasad Ghangal
On 14 September 2016 at 18:54, Richard Biener wrote: > On Fri, Sep 9, 2016 at 12:38 PM, Prasad Ghangal > wrote: >> On 26 August 2016 at 14:28, Richard Biener >> wrote: >>> On Fri, Aug 26, 2016 at 5:08 AM, Prasad Ghangal >>> wrote: On 24 August 2016 at 15:32, Richard Biener wrote: >

Re: [PATCH 1/8] change a few rtx_insn * to rtx_jump_insn *

2016-09-14 Thread Kaz Kojima
tbsaunde+...@tbsaunde.org wrote: > @@ -2201,8 +2201,7 @@ fix_crossing_unconditional_branches (void) > { > if (!BARRIER_P (cur_insn)) > BLOCK_FOR_INSN (cur_insn) = cur_bb; > - if (JUMP_P (cur_insn)) > - jump_insn = cur_ins

Re: [PATCH 1/8] change a few rtx_insn * to rtx_jump_insn *

2016-09-14 Thread Trevor Saunders
On Thu, Sep 15, 2016 at 01:04:04PM +0900, Kaz Kojima wrote: > tbsaunde+...@tbsaunde.org wrote: > > @@ -2201,8 +2201,7 @@ fix_crossing_unconditional_branches (void) > > { > > if (!BARRIER_P (cur_insn)) > > BLOCK_FOR_INSN (cur_insn) = cur_bb; > > -

Re: [PATCH 1/8] change a few rtx_insn * to rtx_jump_insn *

2016-09-14 Thread Kaz Kojima
Trevor Saunders wrote: >> This hunk results several new failures for tree-profile tests on SH. >> If the line "if (JUMP_P (cur_insn))" is restored, those failures >> go away. > > That's interesting because dyn_cast should include that check. What is > the error? Here is a typical log: spawn -i

Re: [RFC][IPA-VRP] Early VRP Implementation

2016-09-14 Thread Richard Biener
On September 14, 2016 11:36:16 PM GMT+02:00, Jan Hubicka wrote: >> + /* Visit PHI stmts and discover any new VRs possible. */ >> + gimple_stmt_iterator gsi; >> + for (gphi_iterator gpi = gsi_start_phis (bb); >> + !gsi_end_p (gpi); gsi_next (&gpi)) >> +{ >> + gphi *phi = gpi.phi

<    1   2