Re: [gomp4, committed] Add goacc/kernels-acc-on-device.c

2015-10-30 Thread Thomas Schwinge
Hi Tom! On Tue, 13 Oct 2015 17:49:21 +0200, Tom de Vries wrote: > On 12/10/15 14:52, Tom de Vries wrote: > > On 12/10/15 12:49, Thomas Schwinge wrote: > >> On Sat, 10 Oct 2015 12:49:01 +0200, Tom de > >> Vries wrote: > >>> >--- /dev/null > >>> >+++ b/gcc/testsuite/c-c++-common/goacc/kernels-acc-

Re: [gomp4] acc_on_device

2015-10-30 Thread Thomas Schwinge
Hi! On Thu, 29 Oct 2015 13:15:13 -0700, Nathan Sidwell wrote: > I've committed this to gomp4 branch. It resolves a problem with > builtin_acc_on_device and C++. > The test cases in the gcc testsuite were hiding the problem by providing part > of > openacc.h in the test directory, and this

Re: [gomp4] acc_on_device

2015-10-30 Thread Thomas Schwinge
Hi! On Fri, 30 Oct 2015 09:31:52 +0100, I wrote: > > --- libgomp/testsuite/libgomp.oacc-c-c++-common/acc-on-device.c > > (revision 0) > > +++ libgomp/testsuite/libgomp.oacc-c-c++-common/acc-on-device.c > > (working copy) > > In r229568 committed to gomp-4_0-branch as obvious: > > commi

Re: [PATCH] Pass manager: add support for termination of pass list

2015-10-30 Thread Richard Biener
On Thu, Oct 29, 2015 at 3:50 PM, Martin Liška wrote: > On 10/29/2015 02:15 PM, Richard Biener wrote: >> On Thu, Oct 29, 2015 at 10:49 AM, Martin Liška wrote: >>> On 10/28/2015 04:23 PM, Richard Biener wrote: On Tue, Oct 27, 2015 at 4:30 PM, Martin Liška wrote: > On 10/27/2015 03:49 PM,

Re: Add VIEW_CONVERT_EXPR to operand_equal_p

2015-10-30 Thread Richard Biener
On Thu, Oct 29, 2015 at 4:52 PM, Jan Hubicka wrote: >> On Thu, Oct 29, 2015 at 4:02 PM, Jan Hubicka wrote: >> >> >> >> IMHO it was always wrong/fragile for backends to look at the actual >> >> arguments to >> >> decide on the calling convention. The backends should _solely_ rely on >> >> gimple

Re: [patch 2/6] scalar-storage-order merge: C front-end

2015-10-30 Thread Eric Botcazou
> It won’t. Fixing the language line for the options and a make to ensure it > still builds for you is enough testing. I was talking about the feature itself though, not about the option per se. The feature is tested for C & C++ but not for ObjC & ObjC++ so there might be surprises. > None is

[PATCH] Allow more pointer-plus folding

2015-10-30 Thread Tom de Vries
[ was: Re: [PATCH] Don't handle CAST_RESTRICT (PR tree-optimization/49279) ] On 29/10/15 12:38, Richard Biener wrote: On Thu, Oct 29, 2015 at 11:38 AM, Tom de Vries wrote: [ quote-pasted from https://gcc.gnu.org/ml/gcc-patches/2011-10/msg00464.html ] CAST_RESTRICT based disambiguation unfo

Re: Robustify REAL_MODE_FORMAT

2015-10-30 Thread Richard Biener
On Thu, Oct 29, 2015 at 5:32 PM, Richard Sandiford wrote: > Richard Biener writes: >> On October 29, 2015 4:33:17 PM GMT+01:00, Bernd Schmidt >> wrote: >>>On 10/29/2015 04:30 PM, Richard Sandiford wrote: Make sure that REAL_MODE_FORMAT aborts if it is passed an invalid >>>mode, rather

Re: [Patch] [x86_64] libgcc changes to add znver1

2015-10-30 Thread Uros Bizjak
On Thu, Oct 29, 2015 at 2:16 PM, Kumar, Venkataramanan wrote: > Hi Uros, > > As per your comments in > https://gcc.gnu.org/ml/gcc-patches/2015-09/msg02326.html please find the > patch that also adds changes to libgcc. > > It was bootstrapped and regressed tested on x86_64. > > Ok for trunk? > >

Re: [PATCH 4/4] Add -Wmisleading-indentation to -Wall

2015-10-30 Thread Richard Biener
On Thu, Oct 29, 2015 at 6:38 PM, Jeff Law wrote: > On 10/29/2015 10:49 AM, David Malcolm wrote: >> >> Our documentation describes -Wall as enabling "all the warnings about >> constructions that some users consider questionable, and that are easy to >> avoid >> (or modify to prevent the warning), e

Re: [PATCH 1/6]tree-ssa-dom.c: Normalize exprs, starting with ARRAY_REF to MEM_REF

2015-10-30 Thread Richard Biener
On Fri, Oct 30, 2015 at 6:35 AM, Jeff Law wrote: > On 10/29/2015 01:18 PM, Alan Lawrence wrote: >> >> This patch just teaches DOM that ARRAY_REFs can be equivalent to MEM_REFs >> (with >> pointer type to the array element type). >> >> gcc/ChangeLog: >> >> * tree-ssa-dom.c (dom_normalize_si

Re: [PATCH 3/6] Share code from fold_array_ctor_reference with fold.

2015-10-30 Thread Richard Biener
On Thu, Oct 29, 2015 at 8:18 PM, Alan Lawrence wrote: > This is in response to https://gcc.gnu.org/ml/gcc/2015-10/msg00097.html, where > Richi points out that CONSTRUCTOR elements are not necessarily ordered. > > I wasn't sure of a good naming convention for the new > get_ctor_element_at_index, >

Re: [PATCH] Allow more pointer-plus folding

2015-10-30 Thread Richard Biener
On Fri, Oct 30, 2015 at 9:58 AM, Tom de Vries wrote: > [ was: Re: [PATCH] Don't handle CAST_RESTRICT (PR tree-optimization/49279) > ] > > On 29/10/15 12:38, Richard Biener wrote: >> >> On Thu, Oct 29, 2015 at 11:38 AM, Tom de Vries >> wrote: >>> >>> [ quote-pasted from >>> https://gcc.gnu.org/ml/

[AARCH64][PATCH 1/3] Implementing the variants of the vmulx_ NEON intrinsic

2015-10-30 Thread Bilyan Borisov
Implementing vmulx_* and vmulx_lane* NEON intrinsics Hi all, This series of patches focuses on the different vmulx_ and vmulx_lane NEON intrinsics variants. All of the existing inlined assembly block implementations are replaced with newly defined __builtin functions, and the missing intrinsics

Re: [PATCH] PR fortran/68154 -- repair damage done byfix for PR fortran/65429

2015-10-30 Thread Paul Richard Thomas
Dear Steve, OK to commit. Thanks for the fix. Paul On 30 October 2015 at 01:03, Steve Kargl wrote: > The attached patch restores 3 lines of code removed in my > fix for PR fortran/65429. The code now checks for a NULL > character length in the typespec. If it is indeed NULL, > gfortran will

[AARCH64][PATCH 2/3] Implementing vmulx_lane NEON intrinsic variants

2015-10-30 Thread Bilyan Borisov
Implementing vmulx_* and vmulx_lane* NEON intrinsics Hi all, This series of patches focuses on the different vmulx_ and vmulx_lane NEON intrinsics variants. All of the existing inlined assembly block implementations are replaced with newly defined __builtin functions, and the missing intrinsics

[AARCH64][PATCH 3/3] Adding tests to check proper error reporting of out of bounds accesses to vmulx_lane* NEON intrinsics

2015-10-30 Thread Bilyan Borisov
Implementing vmulx_* and vmulx_lane* NEON intrinsics Hi all, This series of patches focuses on the different vmulx_ and vmulx_lane NEON intrinsics variants. All of the existing inlined assembly block implementations are replaced with newly defined __builtin functions, and the missing intrinsics

Re: [PATCH, 1/6] Simplify constraint handling

2015-10-30 Thread Richard Biener
On Thu, 29 Oct 2015, Tom de Vries wrote: > On 29/10/15 14:12, Richard Biener wrote: > > On Thu, 29 Oct 2015, Tom de Vries wrote: > > > > > >On 29/10/15 12:13, Richard Biener wrote: > > > > > >On Wed, 28 Oct 2015, Tom de Vries wrote: > > > > > > > > > > > > > > > >On 28/10/15 16:35, Richard Biener

Re: Add VIEW_CONVERT_EXPR to operand_equal_p

2015-10-30 Thread Eric Botcazou
> > But yes, the VIEW_CONVERT "stripping" is a bit fragile and I don't > > remember what exactly we gain from it (when not done on registers). > > I guess gain is really limited to Ada - there are very few cases we do VCE > otherwise. (I think we could do more of them). We can make > useless_type

Re: [PATCH][AArch64] Fix insn types

2015-10-30 Thread Marcus Shawcroft
On 20 October 2015 at 17:14, Evandro Menezes wrote: > Kyrill, > > Indeed, the correct log would be: > > The type assigned to some insn definitions was not correct. > > gcc/ > * config/aarch64/aarch64.md > (*movhf_aarch64): Change the type of "mov %0.h[0], %1.h[0] to > "neon

Re: [PATCH] libitm: Support sized delete.

2015-10-30 Thread Torvald Riegel
On Thu, 2015-10-29 at 12:38 -0700, Richard Henderson wrote: > On 10/29/2015 11:19 AM, Torvald Riegel wrote: > > diff --git a/libitm/libitm.map b/libitm/libitm.map > > index 21bcfdf..7fc9a41 100644 > > --- a/libitm/libitm.map > > +++ b/libitm/libitm.map > > @@ -168,10 +168,12 @@ LIBITM_1.0 { > >

[RFC] [Patch] Relax tree-if-conv.c trap assumptions.

2015-10-30 Thread Kumar, Venkataramanan
Hi Richard, I am trying to "if covert the store" in the below test case and later help it to get vectorized under -Ofast -ftree-loop-if-convert-stores -fno-common #define LEN 4096  __attribute__((aligned(32))) float array[LEN]; void test() { for (int i = 0; i < LEN; i++) {    if (array[i] > (f

Re: Multiply Optimization in match and Simplify

2015-10-30 Thread Richard Biener
On Thu, Oct 29, 2015 at 5:34 AM, Hurugalawadi, Naveen wrote: > Hi, > > Please find attached the patch that moves some multiply optimizations > from fold-const using simplify and match. > > Please review the patch and let me know if any modifications are required. > > Tested the patch on X86. > > O

Re: [RFC] [Patch] Relax tree-if-conv.c trap assumptions.

2015-10-30 Thread Andrew Pinski
On Fri, Oct 30, 2015 at 6:06 PM, Kumar, Venkataramanan wrote: > Hi Richard, > > I am trying to "if covert the store" in the below test case and later help it > to get vectorized under -Ofast -ftree-loop-if-convert-stores -fno-common > > #define LEN 4096 > __attribute__((aligned(32))) float array

RE: [RFC] [Patch] Relax tree-if-conv.c trap assumptions.

2015-10-30 Thread Kumar, Venkataramanan
Hi Andrew, > -Original Message- > From: Andrew Pinski [mailto:pins...@gmail.com] > Sent: Friday, October 30, 2015 3:38 PM > To: Kumar, Venkataramanan > Cc: Richard Beiner (richard.guent...@gmail.com); gcc-patches@gcc.gnu.org > Subject: Re: [RFC] [Patch] Relax tree-if-conv.c trap assumptio

Re: [PATCH][AArch64] Replace insn to zero up DF register

2015-10-30 Thread Marcus Shawcroft
On 20 October 2015 at 00:40, Evandro Menezes wrote: > In the existing targets, it seems that it's always faster to zero up a DF > register with "movi %d0, #0" instead of "fmov %d0, xzr". > > This patch modifies the respective pattern. Hi Evandro, This patch changes the generic, u architecture i

Re: Multiply Optimization in match and Simplify

2015-10-30 Thread Marc Glisse
On Fri, 30 Oct 2015, Richard Biener wrote: +/* Convert (A + A) * C -> A * 2 * C. */ +(simplify + (mult:c (convert? (plus @0 @0)) (convert? @1)) + (if (tree_nop_conversion_p (TREE_TYPE (@0), type)) + (convert (mult @0 (mult { build_int_cst (TREE_TYPE (@1), 2); } @1) +(simplify + (mult:c (

Re: [PATCH 5/6]tree-sra.c: Fix completely_scalarize for negative array indices

2015-10-30 Thread Richard Biener
On Thu, Oct 29, 2015 at 8:18 PM, Alan Lawrence wrote: > The code I added to completely_scalarize for arrays isn't right in some cases > of negative array indices (e.g. arrays with indices from -1 to 1 in the Ada > testsuite). On ARM, this prevents a failure bootstrapping Ada with the next > patch,

Re: [PATCH 00/16] Unit tests framework (v3)

2015-10-30 Thread Bernd Schmidt
On 10/29/2015 08:21 PM, Jeff Law wrote: Excellent point. I think this is worth some serious thought. Given the state of GCC's sources, tests of this nature are going to be inherently tied to implementation details/sources rather than interfaces. That's obviously not ideal, but it is where we a

Re: Multiply Optimization in match and Simplify

2015-10-30 Thread Richard Biener
On Fri, Oct 30, 2015 at 11:26 AM, Marc Glisse wrote: > On Fri, 30 Oct 2015, Richard Biener wrote: > >> +/* Convert (A + A) * C -> A * 2 * C. */ >> +(simplify >> + (mult:c (convert? (plus @0 @0)) (convert? @1)) >> + (if (tree_nop_conversion_p (TREE_TYPE (@0), type)) >> + (convert (mult @0 (mult

Re: [PATCH 5/6]tree-sra.c: Fix completely_scalarize for negative array indices

2015-10-30 Thread Eric Botcazou
> I think you want to use wide-ints here and > >wide_int idx = wi::from (minidx, TYPE_PRECISION (TYPE_DOMAIN > (...)), TYPE_SIGN (TYPE_DOMAIN (..))); >wide_int maxidx = ... > > you can then simply iterate minidx with ++ and do the final compare > against maxidx > with while (++idx <= maxi

[PATCH] replace BITS_PER_UNIT with __CHAR_BIT__ in target libs

2015-10-30 Thread tbsaunde+gcc
From: Trevor Saunders Hi, $subject as far as I am aware these are the same on all supported targets. Trev libgcc/ChangeLog: 2015-10-30 Trevor Saunders * config/visium/lib2funcs.c (__set_trampoline_parity): Use __CHAR_BIT__ instead of BITS_PER_UNIT. * fixed-bit.h: L

Don't free dominators after sincos

2015-10-30 Thread Richard Sandiford
sincos has always freed dominators at the end, but AFAICT they should still be up-to-date. (In particular, gimple_purge_dead_eh_edges updates the information.) Tested on x86_64-linux-gnu, arm-linux-gnueabi and aarch64-linux-gnu. OK to install? Thanks, Richard gcc/ * tree-ssa-math-opts.

Try to update dominance info in tree-call-cdce.c

2015-10-30 Thread Richard Sandiford
The pass would free the dominance info after making a change, but it should be pretty easy to keep the information up-to-date when the call has no EH edges. In a way the main hurdle was split_block, which seemed to assume that the new block would postdominate the old one, and that all blocks immed

Try to avoid mark_virtual_operands_for_renmaing in call-cdce

2015-10-30 Thread Richard Sandiford
It's fairly easy to update the virtual ops when the call has no EH edges, which should be cheaper than mark_virtual_operands_for_renaming. Tested on x86_64-linux-gnu, arm-linux-gnueabi and aarch64-linux-gnu. OK to install? Thanks, Richard gcc/ * tree-call-cdce.c (join_vdefs): New functi

RE: [PATCH 1/2][ARC] Add support for ARCv2 CPUs

2015-10-30 Thread Claudiu Zissulescu
Hi, Please find the updated patch. I will defer the secondary reload optimization which will use the ld instructions with LIMM, for the time being. Thank you, Claudiu gcc/ChangeLog: 2015-08-27 Claudiu Zissulescu

RE: [PATCH 2/2][ARC] Add support for ARCv2 CPUs

2015-10-30 Thread Claudiu Zissulescu
Hi, Please find the updated patch. Both ARC patches were tested using dg.exp. The ChangeLog entry is unchanged. Thank you, Claudiu 02-arcv2Updated.patch Description: 02-arcv2Updated.patch

Re: [RFC] [Patch] Relax tree-if-conv.c trap assumptions.

2015-10-30 Thread Richard Biener
On Fri, Oct 30, 2015 at 11:21 AM, Kumar, Venkataramanan wrote: > Hi Andrew, > >> -Original Message- >> From: Andrew Pinski [mailto:pins...@gmail.com] >> Sent: Friday, October 30, 2015 3:38 PM >> To: Kumar, Venkataramanan >> Cc: Richard Beiner (richard.guent...@gmail.com); gcc-patches@gcc.g

Re: Don't free dominators after sincos

2015-10-30 Thread Richard Biener
On Fri, Oct 30, 2015 at 12:16 PM, Richard Sandiford wrote: > sincos has always freed dominators at the end, but AFAICT they should > still be up-to-date. (In particular, gimple_purge_dead_eh_edges > updates the information.) > > Tested on x86_64-linux-gnu, arm-linux-gnueabi and aarch64-linux-gnu.

Re: Try to update dominance info in tree-call-cdce.c

2015-10-30 Thread Richard Biener
On Fri, Oct 30, 2015 at 12:18 PM, Richard Sandiford wrote: > The pass would free the dominance info after making a change, but it > should be pretty easy to keep the information up-to-date when the call > has no EH edges. In a way the main hurdle was split_block, which seemed > to assume that the

Re: Try to avoid mark_virtual_operands_for_renmaing in call-cdce

2015-10-30 Thread Richard Biener
On Fri, Oct 30, 2015 at 12:18 PM, Richard Sandiford wrote: > It's fairly easy to update the virtual ops when the call has no EH edges, > which should be cheaper than mark_virtual_operands_for_renaming. > > Tested on x86_64-linux-gnu, arm-linux-gnueabi and aarch64-linux-gnu. > OK to install? Well.

[PATCH 0/5] remove tm.h from encoding.c

2015-10-30 Thread tbsaunde+gcc
From: Trevor Saunders Hi, Its not the nicest code in the world, and there's definitely room for cleanups, however it seems like an improvement. After this series the only usage of tm.h in libobjc is thr.c which only uses tm.h so it can include gthr.h which uses SUPPORTS_WEAK and possibly other

[PATCH 2/5] remove usage of ROUND_TYPE_SIZE from encoding.c

2015-10-30 Thread tbsaunde+gcc
From: Trevor Saunders gcc got rid of this target macro in 2003, so it seems safe to assume the alternate path works fine on all targets. libobjc/ChangeLog: 2015-10-30 Trevor Saunders PR libobjc/24775 * encoding.c (objc_layout_finish_structure): Remove usage of ROUND_

[PATCH 1/5] 2015-01-25 Paul Thomas

2015-10-30 Thread tbsaunde+gcc
From: pault PR fortran/67171 * trans-array.c (structure_alloc_comps): On deallocation of class components, reset the vptr to the declared type vtable and reset the _len field of unlimited polymorphic components. *trans-expr.c (gfc_find_and_cut_at_last_class

[PATCH 3/5] stop using ROUND_TYPE_ALIGN in libobjc/

2015-10-30 Thread tbsaunde+gcc
From: Trevor Saunders Given the layering violation that using ROUND_TYPE_ALIGN in target libs is, and the hacks needed to make it work just coppying the relevant code into encoding.c seems to make sense as an incremental improvement. The epiphany version of this macro called a function that does

[PATCH 4/5] remove usage of BIGGEST_FIELD_ALIGNMENT in encoding.c

2015-10-30 Thread tbsaunde+gcc
From: Trevor Saunders Similar to ROUND_TYPE_ALIGN it seems to make sense to copy the information in the target macros to libobjc as an incremental step. Its worth noting a large portion of the definitions of this macro only exist to work around ADJUST_FIELD_ALIGN being used in target libs, so on

[PATCH 5/5] remove usage of ADJUST_FIELD_ALIGN in encoding.c

2015-10-30 Thread tbsaunde+gcc
From: Trevor Saunders Not many targets define this macro in ways that do something in libojc, so it seems to make sense to just inline the few definitions that do do something. libobjc/ChangeLog: 2015-10-30 Trevor Saunders PR libobjc/24775 * encoding.c (objc_layout_structure

Re: [PATCH] Pass manager: add support for termination of pass list

2015-10-30 Thread Martin Liška
On 10/30/2015 09:54 AM, Richard Biener wrote: > On Thu, Oct 29, 2015 at 3:50 PM, Martin Liška wrote: >> On 10/29/2015 02:15 PM, Richard Biener wrote: >>> On Thu, Oct 29, 2015 at 10:49 AM, Martin Liška wrote: On 10/28/2015 04:23 PM, Richard Biener wrote: > On Tue, Oct 27, 2015 at 4:30 PM,

Re: [PATCH 5/5] remove usage of ADJUST_FIELD_ALIGN in encoding.c

2015-10-30 Thread Bernd Schmidt
On 10/30/2015 12:48 PM, tbsaunde+...@tbsaunde.org wrote: -#ifdef ADJUST_FIELD_ALIGN - desired_align = ADJUST_FIELD_ALIGN (type, desired_align); +#if defined __arc__ || defined _AIX + if (TYPE_MODE (strip_array_types (TREE_TYPE (type))) == DFmode) +desired_align = MIN (desired_align, 32); +#

Re: [PATCH 1/5] 2015-01-25 Paul Thomas

2015-10-30 Thread Bernd Schmidt
On 10/30/2015 12:48 PM, tbsaunde+...@tbsaunde.org wrote: From: pault PR fortran/67171 * trans-array.c (structure_alloc_comps): On deallocation of class components, reset the vptr to the declared type vtable and reset the _len field of unlimited polymorphic compon

Re: [PATCH] Pass manager: add support for termination of pass list

2015-10-30 Thread Richard Biener
On Fri, Oct 30, 2015 at 12:59 PM, Martin Liška wrote: > On 10/30/2015 09:54 AM, Richard Biener wrote: >> On Thu, Oct 29, 2015 at 3:50 PM, Martin Liška wrote: >>> On 10/29/2015 02:15 PM, Richard Biener wrote: On Thu, Oct 29, 2015 at 10:49 AM, Martin Liška wrote: > On 10/28/2015 04:23 PM,

Re: Try to update dominance info in tree-call-cdce.c

2015-10-30 Thread Richard Sandiford
Richard Biener writes: > On Fri, Oct 30, 2015 at 12:18 PM, Richard Sandiford > wrote: >> The pass would free the dominance info after making a change, but it >> should be pretty easy to keep the information up-to-date when the call >> has no EH edges. In a way the main hurdle was split_block, wh

Re: [PATCH 5/5] remove usage of ADJUST_FIELD_ALIGN in encoding.c

2015-10-30 Thread Richard Biener
On Fri, Oct 30, 2015 at 1:06 PM, Bernd Schmidt wrote: > On 10/30/2015 12:48 PM, tbsaunde+...@tbsaunde.org wrote: >> >> -#ifdef ADJUST_FIELD_ALIGN >> - desired_align = ADJUST_FIELD_ALIGN (type, desired_align); >> +#if defined __arc__ || defined _AIX >> + if (TYPE_MODE (strip_array_types (TREE_TYP

Re: [PATCH] Remove fold () dispatch from fold_gimple_assign

2015-10-30 Thread Richard Biener
On Thu, 29 Oct 2015, Richard Biener wrote: > > After > > Index: gcc/gimple-fold.c > === > --- gcc/gimple-fold.c (revision 229518) > +++ gcc/gimple-fold.c (working copy) > @@ -398,7 +398,10 @@ fold_gimple_assign (gimple_stmt_iter

Re: Try to avoid mark_virtual_operands_for_renmaing in call-cdce

2015-10-30 Thread Richard Sandiford
Richard Biener writes: > On Fri, Oct 30, 2015 at 12:18 PM, Richard Sandiford > wrote: >> It's fairly easy to update the virtual ops when the call has no EH edges, >> which should be cheaper than mark_virtual_operands_for_renaming. >> >> Tested on x86_64-linux-gnu, arm-linux-gnueabi and aarch64-li

Re: [PATCH 1/5] 2015-01-25 Paul Thomas

2015-10-30 Thread Trevor Saunders
On Fri, Oct 30, 2015 at 01:10:32PM +0100, Bernd Schmidt wrote: > On 10/30/2015 12:48 PM, tbsaunde+...@tbsaunde.org wrote: > >From: pault > > > > PR fortran/67171 > > * trans-array.c (structure_alloc_comps): On deallocation of > > class components, reset the vptr to the declared type vt

Re: [PATCH 5/5] remove usage of ADJUST_FIELD_ALIGN in encoding.c

2015-10-30 Thread Bernd Schmidt
it's not target independent code. Are you suggesting to add a config/ to libobjc? IMHO for a not really mantained frontend / target lib that's an excessive requirement. If necessary, then yes that would be a better solution. Even just keeping the abstraction of the macro and putting definiti

Re: [PATCH] New attribute to create target clones

2015-10-30 Thread Evgeny Stupachenko
I've fixed the misprint and vertical spaces. I'll ask to commit the patch when x86 bootstrap and make check finished. Thanks, Evgeny Updated ChangeLog: 2015-10-30 Evgeny Stupachenko gcc/ * Makefile.in (OBJS): Add multiple_target.o. * attrib.c (make_attribute): Moved from conf

[PATCH 0/2] Levenshtein-based suggestions (v3)

2015-10-30 Thread David Malcolm
On Thu, 2015-09-17 at 13:31 -0600, Jeff Law wrote: > On 09/16/2015 02:34 AM, Richard Biener wrote: > > > > Btw, this looks quite expensive - I'm sure we want to limit the effort > > here a bit. > A limiter is reasonable, though as it's been pointed out this only fires > during error processing, so

[PATCH 1/2] Implement Levenshtein distance

2015-10-30 Thread David Malcolm
This patch adds an implementation of Levenshtein distance to gcc, along with unit testing of the algorithm. The unit testing is implemented via a plugin within gcc.dg/plugin. (I'd prefer to do this via the unit testing patches I've been proposing in a separate patch kit, but to avoid depending on

[PATCH 2/2] C FE: suggest corrections for misspelled field names

2015-10-30 Thread David Malcolm
This is similar to the field-name part of the v2 patch: https://gcc.gnu.org/ml/gcc-patches/2015-09/msg01090.html with the following changes: - don't call unit tests from lookup_field_fuzzy (instead, see patch 1 in the kit) - use a cutoff: if more than half of the letters were misspelle

Re: Try to update dominance info in tree-call-cdce.c

2015-10-30 Thread Richard Biener
On Fri, Oct 30, 2015 at 1:14 PM, Richard Sandiford wrote: > Richard Biener writes: >> On Fri, Oct 30, 2015 at 12:18 PM, Richard Sandiford >> wrote: >>> The pass would free the dominance info after making a change, but it >>> should be pretty easy to keep the information up-to-date when the call

[PR 68064] Do not create jump functions with zero alignment

2015-10-30 Thread Martin Jambor
Hi, in PR 68064, IPA-CP hits an assert upon encountering a jump function claiming that a pointer has known alignment of zero. That is actually what get_pointer_alignment_1 returns when asked what is the alignment of iftmp.0_1 in: : # iftmp.0_1 = PHI <0B(2), 2147483648B(3)> {anonymous}::fn1

Re: Try to avoid mark_virtual_operands_for_renmaing in call-cdce

2015-10-30 Thread Richard Biener
On Fri, Oct 30, 2015 at 1:21 PM, Richard Sandiford wrote: > Richard Biener writes: >> On Fri, Oct 30, 2015 at 12:18 PM, Richard Sandiford >> wrote: >>> It's fairly easy to update the virtual ops when the call has no EH edges, >>> which should be cheaper than mark_virtual_operands_for_renaming. >

Re: [PATCH 5/5] remove usage of ADJUST_FIELD_ALIGN in encoding.c

2015-10-30 Thread Richard Biener
On Fri, Oct 30, 2015 at 1:28 PM, Bernd Schmidt wrote: >> >> it's not target independent code. Are you suggesting to add a config/ >> to libobjc? IMHO for a not really mantained frontend / target lib that's >> an excessive requirement. > > > If necessary, then yes that would be a better solution.

Re: [AArch64][PATCH 6/7] Add NEON intrinsics vqrdmlah and vqrdmlsh.

2015-10-30 Thread Christophe Lyon
On 23 October 2015 at 14:26, Matthew Wahab wrote: > The ARMv8.1 architecture extension adds two Adv.SIMD instructions, > sqrdmlah and sqrdmlsh. This patch adds the NEON intrinsics vqrdmlah and > vqrdmlsh for these instructions. The new intrinsics are of the form > vqrdml{as}h[q]_. > > Tested the s

Re: [PATCH] Pass manager: add support for termination of pass list

2015-10-30 Thread Martin Liška
On 10/30/2015 01:13 PM, Richard Biener wrote: > So I suggest to do the push/pop of cfun there. > do_per_function_toporder can be made static btw. > > Richard. Right, I've done that and it works (bootstrap has been currently running), feasible for HSA branch too. tree-pass.h: /* Declare for plug

Re: [PR 68064] Do not create jump functions with zero alignment

2015-10-30 Thread Richard Biener
On Fri, Oct 30, 2015 at 1:44 PM, Martin Jambor wrote: > Hi, > > in PR 68064, IPA-CP hits an assert upon encountering a jump function > claiming that a pointer has known alignment of zero. That is actually > what get_pointer_alignment_1 returns when asked what is the alignment > of iftmp.0_1 in: >

Re: [PATCH 5/5] remove usage of ADJUST_FIELD_ALIGN in encoding.c

2015-10-30 Thread Trevor Saunders
On Fri, Oct 30, 2015 at 01:16:16PM +0100, Richard Biener wrote: > On Fri, Oct 30, 2015 at 1:06 PM, Bernd Schmidt wrote: > > On 10/30/2015 12:48 PM, tbsaunde+...@tbsaunde.org wrote: > >> > >> -#ifdef ADJUST_FIELD_ALIGN > >> - desired_align = ADJUST_FIELD_ALIGN (type, desired_align); > >> +#if defi

Re: Try to update dominance info in tree-call-cdce.c

2015-10-30 Thread Richard Sandiford
Richard Biener writes: > On Fri, Oct 30, 2015 at 1:14 PM, Richard Sandiford > wrote: >> Richard Biener writes: >>> On Fri, Oct 30, 2015 at 12:18 PM, Richard Sandiford >>> wrote: The pass would free the dominance info after making a change, but it should be pretty easy to keep the info

Re: [PATCH 5/5] remove usage of ADJUST_FIELD_ALIGN in encoding.c

2015-10-30 Thread Bernd Schmidt
On 10/30/2015 01:47 PM, Richard Biener wrote: On Fri, Oct 30, 2015 at 1:28 PM, Bernd Schmidt wrote: it's not target independent code. Are you suggesting to add a config/ to libobjc? IMHO for a not really mantained frontend / target lib that's an excessive requirement. If necessary, then y

Re: [gomp4] openacc reduction simplification

2015-10-30 Thread Thomas Schwinge
Hi Nathan! On Thu, 29 Oct 2015 13:28:02 -0700, Nathan Sidwell wrote: > I've committed this to gomp4. It removes a no-longer needed field from > omp_context & simplifies the dummy head/tail generation needed for > reductions > at the outermost level. Also incorporates the simplification I c

Re: [gomp4 04/14] nvptx: fix output of _Bool global variables

2015-10-30 Thread Alexander Monakov
On Thu, 29 Oct 2015, Bernd Schmidt wrote: > On 10/28/2015 08:29 PM, Alexander Monakov wrote: > > > Anything wrong with the simple fix: pick an integer type with the largest > > size > > dividing the original struct type size? > > Try it and run it through the testsuite. The following patch pa

Re: [gomp4] declare directive [3/5]

2015-10-30 Thread Thomas Schwinge
Hi! On Mon, 8 Jun 2015 10:04:11 -0500, James Norris wrote: > --- a/gcc/fortran/gfortran.h > +++ b/gcc/fortran/gfortran.h > @@ -1174,6 +1183,7 @@ enum >OMP_LIST_FROM, >OMP_LIST_REDUCTION, >OMP_LIST_DEVICE_RESIDENT, > + OMP_LIST_LINK, >OMP_LIST_USE_DEVICE, >OMP_LIST_CACHE, >

RE: [Patch] [x86_64] libgcc changes to add znver1

2015-10-30 Thread Kumar, Venkataramanan
Hi Uros, > -Original Message- > From: Uros Bizjak [mailto:ubiz...@gmail.com] > Sent: Friday, October 30, 2015 2:33 PM > To: Kumar, Venkataramanan > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [Patch] [x86_64] libgcc changes to add znver1 > > On Thu, Oct 29, 2015 at 2:16 PM, Kumar, Venkatar

Re: [gomp4 04/14] nvptx: fix output of _Bool global variables

2015-10-30 Thread Bernd Schmidt
The following patch passes testing with make -k check-c DEJAGNU=.../dejagnu.exp RUNTESTFLAGS=--target_board=nvptx-none-run with no new regressions, and fixes 1 test: -FAIL: gcc.dg/compat/struct-align-1 c_compat_x_tst.o-c_compat_y_tst.o execute Ok. Thanks! Bernd

[patch] New 'all' front end header reduction

2015-10-30 Thread Andrew MacLeod
OK, here's the much delayed front end reduction patch based on the reordering already being checked in. I discovered that my targets builds were only building c/c++, so the other languages were being reduced based only on the host x86_64-pc-linux-gnu build. Thats *probably* ok, but I wanted

Re: [OpenACC] num_gangs, num_workers and vector_length in c++

2015-10-30 Thread Jakub Jelinek
On Thu, Oct 29, 2015 at 04:02:11PM -0700, Cesar Philippidis wrote: > I noticed that num_gangs, num_workers and vector_length are parsed in > somewhat insistent ways in the c++ FE. Both vector_length and num_gangs > bail out whenever as soon as they detect errors, whereas num_workers > does not. Bes

[gomp4, committed] Backport tree-ssa-structalias.c fixes from trunk

2015-10-30 Thread Tom de Vries
Hi, this patch backports my commits to trunk of this week in tree-ssa-structalias.c. Committed to gomp-4_0-branch. Thanks, - Tom Backport tree-ssa-structalias.c fixes from trunk 2015-10-30 Tom de Vries backport from trunk: 2015-10-30 Tom de Vries * tree-ssa-structalias.c (ipa_pta_

[PR68083] stop ifcombine from moving uninitialized uses before their guards

2015-10-30 Thread Alexandre Oliva
The ifcombine pass may move a conditional access to an uninitialized value before the condition that ensures it is always well-defined, thus introducing undefined behavior. Stop it from doing so. Regstrapped on x86_64-linux-gnu and i686-linux-gnu. Ok to install? Incidentally, bb_no_side_effect

Re: [PATCH][PR tree-optimization/67892] Use FSM threader to handle backedges

2015-10-30 Thread Andreas Schwab
I'm getting this regression on m68k: FAIL: gcc.dg/tree-ssa/ssa-thread-11.c scan-tree-dump vrp2 "FSM" The generated code looks equivalent, though. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something co

Re: using scratchpads to enhance RTL-level if-conversion: revised patch

2015-10-30 Thread Bernd Schmidt
(Jakub Cc'd because of code he added for PR23567). On 10/27/2015 11:35 PM, Abe wrote: Thanks for all your feedback. I have integrated as much of it as I could in the available time. Unfortunately not all of it - I still think we need to have a better strategy of selecting a scratchpad than a

Re: [PATCH 1/2] s/390: Implement "target" attribute.

2015-10-30 Thread Andreas Krebbel
Hi Dominik, on-top of the discussions we had off-list I only have a few additional comments/questions. Apart from that the patch looks good to me. Thanks! Bye, -Andreas- > diff --git a/gcc/common/config/s390/s390-common.c > b/gcc/common/config/s390/s390-common.c > index 43459c8..4cf0df7 10064

Re: [PATCH][PR tree-optimization/67892] Use FSM threader to handle backedges

2015-10-30 Thread Jeff Law
On 10/30/2015 07:57 AM, Andreas Schwab wrote: I'm getting this regression on m68k: FAIL: gcc.dg/tree-ssa/ssa-thread-11.c scan-tree-dump vrp2 "FSM" The generated code looks equivalent, though. I'll take a look. THanks, jeff

Re: [PATCH] [ARM] neon-testgen.ml typo

2015-10-30 Thread Ramana Radhakrishnan
On 29/10/15 17:23, Jim Wilson wrote: > I noticed a comment typo in this file while using grep to look for > other stuff. The typo is easy to fix. > > I tried running neon-testgen.ml to verify, but it is apparently no > longer valid ocaml, as it doesn't work with the ocamlc 4.01.0 I have > on Ub

Re: [PATCH][ARM] Fix checking RTL error in cortex_a9_sched_adjust_cost

2015-10-30 Thread Ramana Radhakrishnan
On 29/10/15 16:02, Kyrill Tkachov wrote: > Hi all, > > An arm-none-eabi build with RTL checking and --with-cpu=cortex-a9 fails > because > cortex_a9_sched_adjust_cost tries to access the SET_DEST of a PARALLEL. > The correct thing to do is to call single_set on dep, which will return a > simpl

Re: [OpenACC] num_gangs, num_workers and vector_length in c++

2015-10-30 Thread Cesar Philippidis
On 10/30/2015 06:37 AM, Jakub Jelinek wrote: > On Thu, Oct 29, 2015 at 04:02:11PM -0700, Cesar Philippidis wrote: >> I noticed that num_gangs, num_workers and vector_length are parsed in >> somewhat insistent ways in the c++ FE. Both vector_length and num_gangs >> bail out whenever as soon as they

Re: [PATCH] [ARM] neon-testgen.ml typo

2015-10-30 Thread Christophe Lyon
On 30 October 2015 at 15:33, Ramana Radhakrishnan wrote: > > > On 29/10/15 17:23, Jim Wilson wrote: >> I noticed a comment typo in this file while using grep to look for >> other stuff. The typo is easy to fix. >> >> I tried running neon-testgen.ml to verify, but it is apparently no >> longer val

Re: [patch 2/6] scalar-storage-order merge: C front-end

2015-10-30 Thread Mike Stump
On Oct 30, 2015, at 1:56 AM, Eric Botcazou wrote: >> It won’t. Fixing the language line for the options and a make to ensure it >> still builds for you is enough testing. > > I was talking about the feature itself though, not about the option per se. > The feature is tested for C & C++ but not

Re: more accurate omp in fortran

2015-10-30 Thread Jakub Jelinek
On Thu, Oct 22, 2015 at 08:21:35AM -0700, Cesar Philippidis wrote: > diff --git a/gcc/fortran/gfortran.h b/gcc/fortran/gfortran.h > index b2894cc..93adb7b 100644 > --- a/gcc/fortran/gfortran.h > +++ b/gcc/fortran/gfortran.h > @@ -1123,6 +1123,7 @@ typedef struct gfc_omp_namelist > } u; >st

Re: [AArch64] Update comments on the usage of X30 in FIXED_REGISTERS and CALL_USED_REGISTERS

2015-10-30 Thread Jiong Wang
On 16/10/15 15:36, Jiong Wang wrote: The patch https://gcc.gnu.org/ml/gcc-patches/2014-09/msg02654.html from last year changed the definition of LR in CALL_USED_REGISTERS, but didn't update the comment above the #define to reflect the new usage. This patch bring the comment inline with the imple

[PATCH] Better error messages for merge-conflict markers (v3)

2015-10-30 Thread David Malcolm
This is a rebased version of this patch from back in April: v2: https://gcc.gnu.org/ml/gcc-patches/2015-04/msg00944.html which in turn is a rewrite of this one: v1: https://gcc.gnu.org/ml/gcc-patches/2015-03/msg01087.html The idea is to more gracefully handle merger conflict markers in the sou

Re: more accurate omp in fortran

2015-10-30 Thread Cesar Philippidis
On 10/30/2015 07:47 AM, Jakub Jelinek wrote: > On Thu, Oct 22, 2015 at 08:21:35AM -0700, Cesar Philippidis wrote: >> diff --git a/gcc/fortran/gfortran.h b/gcc/fortran/gfortran.h >> index b2894cc..93adb7b 100644 >> --- a/gcc/fortran/gfortran.h >> +++ b/gcc/fortran/gfortran.h >> @@ -1123,6 +1123,7 @@

Move constant folds for maths functions to new file

2015-10-30 Thread Richard Sandiford
The new routines operate on the built-in enum rather than on tree decls. The idea is to extend this to handle internal functions too, with a combined enum for both. The patch also moves fold_fma too, with the same prototype. The long-term plan is to replace FMA_EXPR with an internal function, for

Re: Add VIEW_CONVERT_EXPR to operand_equal_p

2015-10-30 Thread Jan Hubicka
> > > But yes, the VIEW_CONVERT "stripping" is a bit fragile and I don't > > > remember what exactly we gain from it (when not done on registers). > > > > I guess gain is really limited to Ada - there are very few cases we do VCE > > otherwise. (I think we could do more of them). We can make > >

Re: Add VIEW_CONVERT_EXPR to operand_equal_p

2015-10-30 Thread Jan Hubicka
> > Yeah, I suppose we'd need to either build a new function type for each > variadic call > then or somehow represent 'fntype' differently (note that function > attributes also > need to be preserved). Why we can't keep fntype as it is, but simply add a new set of parameters to call stmt that l

Re: [PATCH 0/4] -Wmisleading-indentation

2015-10-30 Thread Mike Stump
On Oct 29, 2015, at 10:39 PM, Andi Kleen wrote: > David Malcolm writes: >> >> * adds -Wmisleading-indentation to -Wall > > I have doubts this is a good idea. I'm sure this will break > a bazillion packages which (misguidedly) ship with -Wall -Werror. > > Would be better to leave the user the

Re: [PATCH 0/5] remove tm.h from encoding.c

2015-10-30 Thread Mike Stump
On Oct 30, 2015, at 4:48 AM, tbsaunde+...@tbsaunde.org wrote: > Its not the nicest code in the world, and there's definitely room for > cleanups, > however it seems like an improvement. After this series the only usage of > tm.h > in libobjc is thr.c which only uses tm.h so it can include gthr.h

Re: [PATCH][ARM] Fix checking RTL error in cortex_a9_sched_adjust_cost

2015-10-30 Thread Kyrill Tkachov
On 30/10/15 14:37, Ramana Radhakrishnan wrote: On 29/10/15 16:02, Kyrill Tkachov wrote: Hi all, An arm-none-eabi build with RTL checking and --with-cpu=cortex-a9 fails because cortex_a9_sched_adjust_cost tries to access the SET_DEST of a PARALLEL. The correct thing to do is to call single_set

Re: [Docs] Reword the documentation for -fdump-rtl-

2015-10-30 Thread James Greenhalgh
On Thu, Oct 29, 2015 at 11:09:32AM -0600, Sandra Loosemore wrote: > On 10/29/2015 10:55 AM, James Greenhalgh wrote: > > >diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi > >index 76fdc31..5549f17 100644 > >--- a/gcc/doc/invoke.texi > >+++ b/gcc/doc/invoke.texi > >@@ -6665,17 +6665,19 @@ Says

  1   2   >