[PATCH] Fix PR66916

2015-07-23 Thread Richard Biener
The following adds a single-use restriction to the widening/sing-change comparison pattern which fixes PR66916. Bootstrapped and tested on x86_64-unknown-linux-gnu. Verified the arm testcase produces expected assembly with a cc1 cross. Richard. 2015-07-22 Richard Biener PR middle-e

[Bug fortran/52846] [F2008] Support submodules - part 3/3

2015-07-23 Thread Paul Richard Thomas
Dear All, This is the third and final patch to implement submodules in gfortran. It is the part that deals with private module entities. Unfortunately, it is the most invasive and I would either like to have strong support for it to be committed or a bright idea as to how to do it otherwise. Sinc

Re: [Bug fortran/52846] [F2008] Support submodules - part 3/3

2015-07-23 Thread Damian Rouson
> On Jul 23, 2015, at 12:46 AM, Paul Richard Thomas > wrote: > > Since all the private entities in a module have to be transmitted to > their descendant submodules, whilst keeping them hidden from normal > use statements, I have chosen to write the module file as usual and > add a second part

Re: [Bug fortran/52846] [F2008] Support submodules - part 3/3

2015-07-23 Thread Paul Richard Thomas
Dear Damian, I do not think that there is any effect on compilation cascades. As long as the private part of the module file remains unchanged, it will not be recompiled if a descendant submodule is modified. Naturally, the size of the module file is increased but, if one is careful, this is not a

Re: libstdc++: more __intN tweaks

2015-07-23 Thread Jonathan Wakely
On 22/07/15 22:26 -0400, DJ Delorie wrote: Another place where a list of "all" types are explicitly listed, and the __intN types need to be included, and elsewhere protection against errors [-Wnarrowing] on targets that have small size_t. Ok? * include/bits/functional_hash.h: Add speci

Re: [AArch64/wwwdoc] Document -fpic support for small memory model

2015-07-23 Thread Jiong Wang
James Greenhalgh writes: > On Fri, Jun 26, 2015 at 02:45:39PM +0100, Jiong Wang wrote: >> >> Marcus Shawcroft writes: >> >> 2015-06-26 Jiong Wang >> >> wwwdocs/ >> * htdocs/gcc-6/changes.html (AArch64): Document -fpic for small model. >> > >> Index: gcc-6/changes.html >>

[gomp4] libgomp: Some torture testing for C and C++ OpenACC test cases (was: [gomp] Move openacc vector& worker single handling to RTL)

2015-07-23 Thread Thomas Schwinge
Hi! On Wed, 22 Jul 2015 12:47:32 -0400, Nathan Sidwell wrote: > On 07/20/15 11:08, Nathan Sidwell wrote: > > On 07/20/15 09:01, Nathan Sidwell wrote: > >> On 07/18/15 11:37, Thomas Schwinge wrote: > >>> For OpenACC nvptx offloading, there must still be something wrong; here's > >>> a count of the

Re: [AArch64/wwwdoc] Document -fpic support for small memory model

2015-07-23 Thread James Greenhalgh
On Thu, Jul 23, 2015 at 09:38:26AM +0100, Jiong Wang wrote: > > James Greenhalgh writes: > > > On Fri, Jun 26, 2015 at 02:45:39PM +0100, Jiong Wang wrote: > >> > >> Marcus Shawcroft writes: > >> > >> 2015-06-26 Jiong Wang > >> > >> wwwdocs/ > >> * htdocs/gcc-6/changes.html (AArch64): Docu

RE: [PATCH, MIPS] I6400 scheduling

2015-07-23 Thread Robert Suchanek
Hi, > PTF_AVOID_BRANCHLIKELY replaced with 0 in all 3 cases. > AFAICS, there is no need to update the option handling code. The branch > likely will not be enabled as it is additionally guarded by > ISA_HAS_BRANCHLIKELY. > > > > > OK with those changes. > > I'll commit the updated patch once the

Re: [PATCH][match.pd] PR middle-end/66915 Restrict A - B -> A + (-B) to non-fixed-point types

2015-07-23 Thread Kyrill Tkachov
On 21/07/15 11:11, Richard Biener wrote: On Tue, 21 Jul 2015, Kyrill Tkachov wrote: On 21/07/15 08:24, Richard Biener wrote: On Mon, 20 Jul 2015, Kyrill Tkachov wrote: Hi all, This patch fixes the PR in question which is a miscompilation of gcc.dg/fixed-point/unary.c on arm. It just restri

Re: [PATCH] Fix PR66952

2015-07-23 Thread Andreas Schwab
Richard Biener writes: > Index: gcc/testsuite/gcc.dg/torture/pr66952.c > === > --- gcc/testsuite/gcc.dg/torture/pr66952.c(revision 0) > +++ gcc/testsuite/gcc.dg/torture/pr66952.c(working copy) > @@ -0,0 +1,28 @@ > +/* { dg-do

[PATCH][combine][committed] Use std::swap in try_combine

2015-07-23 Thread Kyrill Tkachov
Hi all, This obvious patch replaces yet another instance of manual swapping by std::swap. Bootstrapped and tested on aarch64 and x86_64. Applied to trunk with r226094. Thanks, Kyrill 2015-07-23 Kyrylo Tkachov * combine.c (try_combine): Use std::swap instead of manually swapping.

Re: [PATCH][AArch64][9/14] Implement TARGET_CAN_INLINE_P

2015-07-23 Thread Kyrill Tkachov
On 21/07/15 17:07, James Greenhalgh wrote: On Thu, Jul 16, 2015 at 04:21:02PM +0100, Kyrill Tkachov wrote: Hi all, This patch implements the target-specific inlining rules. The basic philosophy is that we want to definitely reject inlining if the callee's architecture is not a subset, feature

Re: [PATCH] Document ftrapv/fwrapv interaction

2015-07-23 Thread Richard Biener
On Wed, Jul 22, 2015 at 5:11 PM, Tom de Vries wrote: > [ Re: [RFC, PR66873] Use graphite for parloops ] > On 22/07/15 13:01, Richard Biener wrote: >> >> why only scalar floats? Please use FLOAT_TYPE_P. >> >> + if (INTEGRAL_TYPE_P (type)) >> +return (!TYPE_OVERFLOW_TRAPS (type) >> +

Re: [PATCH] Document ftrapv/fwrapv interaction

2015-07-23 Thread Richard Biener
On Thu, Jul 23, 2015 at 12:19 PM, Richard Biener wrote: > On Wed, Jul 22, 2015 at 5:11 PM, Tom de Vries wrote: >> [ Re: [RFC, PR66873] Use graphite for parloops ] >> On 22/07/15 13:01, Richard Biener wrote: >>> >>> why only scalar floats? Please use FLOAT_TYPE_P. >>> >>> + if (INTEGRAL_TYPE_P (

Re: [PATCH] Fix PR66952

2015-07-23 Thread Kyrill Tkachov
On 23/07/15 10:02, Andreas Schwab wrote: Richard Biener writes: Index: gcc/testsuite/gcc.dg/torture/pr66952.c === --- gcc/testsuite/gcc.dg/torture/pr66952.c (revision 0) +++ gcc/testsuite/gcc.dg/torture/pr66952.c (worki

Re: [PATCH] Don't allow unsafe reductions in graphite

2015-07-23 Thread Richard Biener
On Wed, Jul 22, 2015 at 6:00 PM, Tom de Vries wrote: > [ was: Re: [RFC, PR66873] Use graphite for parloops ] > > On 22/07/15 13:02, Richard Biener wrote: >> >> On Wed, Jul 22, 2015 at 1:01 PM, Richard Biener >> wrote: >>> >>> >On Tue, Jul 21, 2015 at 8:42 PM, Sebastian Pop wrote: >>To

Re: [PATH PR66926,PR66951} simple fix for ICE.

2015-07-23 Thread Richard Biener
On Wed, Jul 22, 2015 at 6:09 PM, Yuri Rumyantsev wrote: > Hi All, > > Here is simple fix which fixes PR66926 and PR66951 - fix condition for > renaming virtual operands to determine that statement is outside of > loop. > > Bootstrap and regression testing did not show any new failures. > > Is it O

Re: [PATCH] Check TYPE_OVERFLOW_WRAPS for parloops reductions

2015-07-23 Thread Richard Biener
On Wed, Jul 22, 2015 at 6:13 PM, Tom de Vries wrote: > [ was: Re: [RFC, PR66873] Use graphite for parloops ] > > On 22/07/15 13:02, Richard Biener wrote: >> >> On Wed, Jul 22, 2015 at 1:01 PM, Richard Biener >> wrote: >>> >>> On Tue, Jul 21, 2015 at 8:42 PM, Sebastian Pop wrote: Tom de

[PATCHES, PING] Enhance standard DWARF for Ada

2015-07-23 Thread Pierre-Marie de Rodat
On 07/16/2015 10:34 AM, Pierre-Marie de Rodat wrote: This patch series aims at enhancing GCC to emit standard DWARF in place of the current GNAT encodings (non-standard DWARF) for a set of "basic" types: dynamic arrays, variable-length records, variant parts, etc. Ping for the patch series:

Re: [ARM] Correct spelling of references to ARMv6KZ

2015-07-23 Thread Matthew Wahab
On 24/06/15 10:25, Matthew Wahab wrote: Ping. Attached updated patch which also actually removes "armv6zk" from doc/invoke.texi. Also, retested: - arm-none-linux-gnueabihf native bootstrap and cross-compiled make checck. - arm-none-eabi: cross-compiled make check. gcc/ 2015-07-23 Matthew Waha

Re: [PR64164] drop copyrename, integrate into expand

2015-07-23 Thread Richard Biener
On Wed, Jul 22, 2015 at 7:33 PM, Alexandre Oliva wrote: > On Jul 21, 2015, Richard Biener wrote: > >> On Sat, Jul 18, 2015 at 9:37 AM, Alexandre Oliva wrote: >>> + if (cfun->gimple_df) > >> If the cfun->gimple_df check is to decide whether this is a call or a >> function >> then no, thi

Re: [PATCH] Remove unused get_current_pass_name

2015-07-23 Thread Richard Biener
On Wed, Jul 22, 2015 at 8:37 PM, Bernd Edlinger wrote: > Hi, > > > I noticed recently that tree-pass.h contains a declaration of > get_current_pass_name, > but this function is not defined, and where ever we need the current pass > name, > we simply use current_pass->name. So I would like to re

Re: [ARM] Correct spelling of references to ARMv6KZ

2015-07-23 Thread Kyrill Tkachov
Hi Matthew, On 23/07/15 11:54, Matthew Wahab wrote: On 24/06/15 10:25, Matthew Wahab wrote: Ping. Attached updated patch which also actually removes "armv6zk" from doc/invoke.texi. Also, retested: - arm-none-linux-gnueabihf native bootstrap and cross-compiled make checck. - arm-none-eabi: cros

[PATCH] [PATCH][ARM] Fix pr63210.c testcase.

2015-07-23 Thread Alex Velenko
Hi, This patch prevents testcase pr63210.c from running with -march=armv4t. Object size check should be skipped with explicit -march=armv4t, because expected size is only correct using pop pc instruction which is unsafe for armv4t. For arm_arch_v5t_ok cases, an explicit -march=armv5t flag is set.

Re: [PATCH][match.pd] PR middle-end/66915 Restrict A - B -> A + (-B) to non-fixed-point types

2015-07-23 Thread Richard Biener
On Thu, 23 Jul 2015, Kyrill Tkachov wrote: > > On 21/07/15 11:11, Richard Biener wrote: > > On Tue, 21 Jul 2015, Kyrill Tkachov wrote: > > > > > On 21/07/15 08:24, Richard Biener wrote: > > > > On Mon, 20 Jul 2015, Kyrill Tkachov wrote: > > > > > > > > > Hi all, > > > > > > > > > > This patch

Re: [PATCH] Fix PR66952

2015-07-23 Thread Richard Biener
On Thu, 23 Jul 2015, Kyrill Tkachov wrote: > > On 23/07/15 10:02, Andreas Schwab wrote: > > Richard Biener writes: > > > > > Index: gcc/testsuite/gcc.dg/torture/pr66952.c > > > === > > > --- gcc/testsuite/gcc.dg/torture/pr66952.c

Re: [PATCH][match.pd] PR middle-end/66915 Restrict A - B -> A + (-B) to non-fixed-point types

2015-07-23 Thread Kyrill Tkachov
On 23/07/15 12:16, Richard Biener wrote: On Thu, 23 Jul 2015, Kyrill Tkachov wrote: On 21/07/15 11:11, Richard Biener wrote: On Tue, 21 Jul 2015, Kyrill Tkachov wrote: On 21/07/15 08:24, Richard Biener wrote: On Mon, 20 Jul 2015, Kyrill Tkachov wrote: Hi all, This patch fixes the PR in

s390-linux fails to build

2015-07-23 Thread Nick Clifton
Hi Helmut, Hi Ulrich, Hi Andreas, A toolchain configured as --target=s390-linux currently fails to build gcc because of an undefined function: undefined reference to `s390_host_detect_local_cpu(int, char const**)' Makefile:1858: recipe for target 'xgcc' failed The patch below fix

Re: [Bug fortran/52846] [F2008] Support submodules - part 3/3

2015-07-23 Thread Salvatore Filippone
I agree with Paul that this is orthogonal to the compilation cascade phenomenon. In my opinion, putting PRIVATE entities in a module does not make much sense (yes, I know my example does it, but it is a quick adaptation of an existing code, not a clean design). If the main MODULE only contains the

Re: s390-linux fails to build

2015-07-23 Thread Jakub Jelinek
On Thu, Jul 23, 2015 at 01:03:19PM +0100, Nick Clifton wrote: > Hi Helmut, Hi Ulrich, Hi Andreas, > > A toolchain configured as --target=s390-linux currently fails to build > gcc because of an undefined function: > > undefined reference to `s390_host_detect_local_cpu(int, char const**)' >

Re: [PATCH] Fix ubsan tree sharing (PR sanitizer/66908)

2015-07-23 Thread Marek Polacek
On Wed, Jul 22, 2015 at 07:43:23PM +0200, Jakub Jelinek wrote: > On Wed, Jul 22, 2015 at 07:26:22PM +0200, Marek Polacek wrote: > > In this testcase we were generating an uninitialized variable when doing > > -fsanitize=shift,bounds sanitization. The shift instrumentation is done > > first; after

[PATCH] Remove fold_cond_expr_cond

2015-07-23 Thread Richard Biener
So I stumbled across fold_cond_expr_cond and traced it back to pre-GIMPLE and pre-fold_XXX times. It "folds" all conditions in a function (but only if they fold to always true/false). It does this after CFG construction but before cfg-cleanup. It does that to allow cfg-cleanup to be less expens

Re: s390-linux fails to build

2015-07-23 Thread Ulrich Weigand
Jakub Jelinek wrote: > On Thu, Jul 23, 2015 at 01:03:19PM +0100, Nick Clifton wrote: > > Hi Helmut, Hi Ulrich, Hi Andreas, > > > > A toolchain configured as --target=s390-linux currently fails to build > > gcc because of an undefined function: > > > > undefined reference to `s390_host_det

Re: [PATCH 3/4] S390 -march=native related fixes

2015-07-23 Thread Ulrich Weigand
Dominik Vogt wrote: > > gcc/ChangeLog > > * config/s390/driver-native.c (s390_host_detect_local_cpu): Handle > processor capabilities with -march=native. > * config/s390/s390.h (MARCH_MTUNE_NATIVE_SPECS): Likewise. > (DRIVER_SELF_SPECS): Likewise. Join specs for 31 and 6

Re: s390-linux fails to build

2015-07-23 Thread Jakub Jelinek
On Thu, Jul 23, 2015 at 02:46:43PM +0200, Ulrich Weigand wrote: > This is supposed to be fixed by this pending patch: > https://gcc.gnu.org/ml/gcc-patches/2015-07/msg01546.html LGTM. > > The config.host change also looks wrong, e.g. i?86 or mips have: > > i[34567]86-*-* \ > > | x86_64-*-* ) >

Re: s390-linux fails to build

2015-07-23 Thread Ulrich Weigand
Jakub Jelinek wrote: > On Thu, Jul 23, 2015 at 02:46:43PM +0200, Ulrich Weigand wrote: > > > I bet that is gone break also cross-compilers from s390* to other targets. > > > > I think this should be fine on s390. The problem with i386 is that > > the driver-native.c file uses data types only defi

Re: s390-linux fails to build

2015-07-23 Thread Jakub Jelinek
On Thu, Jul 23, 2015 at 03:03:29PM +0200, Ulrich Weigand wrote: > Jakub Jelinek wrote: > > On Thu, Jul 23, 2015 at 02:46:43PM +0200, Ulrich Weigand wrote: > > > > I bet that is gone break also cross-compilers from s390* to other > > > > targets. > > > > > > I think this should be fine on s390. T

Re: [PR25529] Convert (unsigned t * 2)/2 into unsigned (t & 0x7FFFFFFF)

2015-07-23 Thread Richard Biener
On Thu, Jul 23, 2015 at 5:47 AM, Hurugalawadi, Naveen wrote: >>> so using wi::mask is prefered here. > > Thanks for your review and comments. > > Please find attached the modified patch as per your comments. > > Please let me know if this version is okay? Ok with adding /* { dg-require-effective

Re: [PR25530] Convert (unsigned t / 2) * 2 into (unsigned t & ~1)

2015-07-23 Thread Richard Biener
On Thu, Jul 23, 2015 at 5:49 AM, Hurugalawadi, Naveen wrote: >>> Your previous patch correctly restricted this to unsigned types. > > Thanks for your review and comments. > > Please find attached the modified patch as per your comments. > > Please let me know if this version is okay? Ok. Thanks,

Re: s390-linux fails to build

2015-07-23 Thread Dominik Vogt
On Thu, Jul 23, 2015 at 03:09:46PM +0200, Jakub Jelinek wrote: > On Thu, Jul 23, 2015 at 03:03:29PM +0200, Ulrich Weigand wrote: > > Oh, I agree this will not be *used*. I just wanted to point out that it > > will not *break* cross-compilers as is. > > I think it would be better for consistency a

Re: [PATCH] Fix ubsan tree sharing (PR sanitizer/66908)

2015-07-23 Thread Jakub Jelinek
On Thu, Jul 23, 2015 at 02:20:51PM +0200, Marek Polacek wrote: > > So isn't the bug instead that the UBSAN_BOUNDS generating code doesn't > > unshare? Of course, these two functions use op0 and/or op1 sometimes > > multiple times too and thus they might want to unshare too, but I'd have > > expect

Re: [PING][PATCH, 1/2] Merge rewrite_virtuals_into_loop_closed_ssa from gomp4 branch

2015-07-23 Thread Richard Biener
On Mon, 20 Jul 2015, Tom de Vries wrote: > On 09/07/15 13:04, Richard Biener wrote: > > On Thu, 9 Jul 2015, Tom de Vries wrote: > > > > > On 07/07/15 17:58, Tom de Vries wrote: > > > > > If you can > > > > > handle one exit edge I also can't see the difficulty in handling > > > > > all exit edges

Re: [PATCH] Enable reductions without fassociative-math in graphite

2015-07-23 Thread Richard Biener
On Wed, 22 Jul 2015, Tom de Vries wrote: > Hi, > > this patch allows non-float reductions to be detected by graphite, independent > of whether fassociative-math (which only has effect for float operations) is > set. > > Currently bootstrapping and reg-testing on x86_64. > > OK for trunk? Ok >

Re: [PATCH] Fix ubsan tree sharing (PR sanitizer/66908)

2015-07-23 Thread Marek Polacek
On Thu, Jul 23, 2015 at 02:39:05PM +0200, Jakub Jelinek wrote: > On Thu, Jul 23, 2015 at 02:20:51PM +0200, Marek Polacek wrote: > > > So isn't the bug instead that the UBSAN_BOUNDS generating code doesn't > > > unshare? Of course, these two functions use op0 and/or op1 sometimes > > > multiple tim

Re: [PATCH PR66388]Compute use with cand of smaller precision by further exercising scev overflow info.

2015-07-23 Thread Richard Biener
On Fri, Jul 17, 2015 at 8:27 AM, Bin Cheng wrote: > Hi, > This patch is to fix PR66388. It's an old issue but recently became worse > after my scev overflow change. IVOPT now can only compute iv use with > candidate which has at least same type precision. See below code: > > if (TYPE_PRECISIO

[PATCH] rs6000: Add dot forms of and3_2insn

2015-07-23 Thread Segher Boessenkool
This does one of the TODOs I added: it adds dot forms of the ANDs done with two machine insns. It uses a new helper function (rs6000_emit_dot_insn) that probably can be used more often; it is quite general in any case. Bootstrapped and tested on powerpc64-linux, using {-m32,-m32/-mpowerpc64, -m64

Re: [PATCH] rs6000: Add dot forms of and3_2insn

2015-07-23 Thread David Edelsohn
On Thu, Jul 23, 2015 at 10:21 AM, Segher Boessenkool wrote: > This does one of the TODOs I added: it adds dot forms of the ANDs done > with two machine insns. It uses a new helper function (rs6000_emit_dot_insn) > that probably can be used more often; it is quite general in any case. > > Bootstra

[PATCH][17/n] Remove GENERIC stmt combining from SCCVN

2015-07-23 Thread Richard Biener
This moves address-of-decl simplifications. The second pattern is from if (integer_zerop (arg1) && tree_expr_nonzero_p (arg0)) { tree res = constant_boolean_node (code==NE_EXPR, type); return omit_one_operand_loc (loc, type, res, arg0); } whic

Re: [PATCH] fix in-tree-binutils builds

2015-07-23 Thread H.J. Lu
On Fri, Jul 17, 2015 at 7:43 AM, H.J. Lu wrote: > On Wed, Jul 15, 2015 at 9:47 AM, Mike Stump wrote: >> On Jul 15, 2015, at 9:07 AM, H.J. Lu wrote: >>> On Wed, Jul 15, 2015 at 1:03 AM, Jan Beulich wrote: - $gcc_cv_as_gas_srcdir/configure.in \ + $gcc_cv_as_gas_srcd

Re: [PATCH] Unswitching outer loops.

2015-07-23 Thread Yuri Rumyantsev
Hi Richard, I checked that both test-cases from 23855 are sucessfully unswitched by proposed patch. I understand that it does not catch deeper loop nest as for (i=0; i<10; i++) for (j=0;j: > On Fri, Jul 10, 2015 at 12:02 PM, Yuri Rumyantsev wrote: >> Hi All, >> >> Here is presented simple

[patch] PR66714 -- Re: Re: [RFC] two-phase marking in gt_cleare_cache

2015-07-23 Thread Cesar Philippidis
On 07/13/2015 06:43 AM, Michael Matz wrote: > This also hints at other problems (which might not actually occur in the > case at hand, but still): the contents of DECL_VALUE_EXPR is the "real" > thing containing the value of a decl (i.e. a decl having a value-expr > doesn't itself occur in the

Re: [PR64164] drop copyrename, integrate into expand

2015-07-23 Thread Alexandre Oliva
On Jul 23, 2015, Richard Biener wrote: > Hmm, ok. Does using >if (currently_expanding_to_rtl) > work? I think it's slightly more descriptive. Yeah. Thanks, I've tested it with this change, and I'm now checking this in (full patch first; adjusted incremental patch at the end): [PR64164]

Re: [CHKP, GCC 5] Port a set of stability chkp patches to gcc-5-branch

2015-07-23 Thread H.J. Lu
On Tue, Jul 21, 2015 at 12:04 PM, Jeff Law wrote: > On 07/20/2015 04:59 AM, Ilya Enkovich wrote: >> >> Ping >> >> 2015-06-19 17:10 GMT+03:00 Ilya Enkovich : >>> >>> Hi, >>> >>> There was a set of stability fixes (mostly different ICEs) for Pointer >>> Bounds Checker done in GCC 6. But only few of

Re: [Bug fortran/52846] [F2008] Support submodules - part 3/3

2015-07-23 Thread Mikael Morin
Hello Paul, Le 23/07/2015 09:46, Paul Richard Thomas a écrit : Since all the private entities in a module have to be transmitted to their descendant submodules, whilst keeping them hidden from normal use statements, I have chosen to write the module file as usual and add a second part that conta

Re: Fold some equal to and not equal to patterns in match.pd

2015-07-23 Thread Jeff Law
On 07/21/2015 06:40 PM, Andrew Pinski wrote: On Tue, Jul 21, 2015 at 12:16 PM, Richard Biener wrote: On July 21, 2015 11:38:31 AM GMT+02:00, Jakub Jelinek wrote: On Tue, Jul 21, 2015 at 09:15:31AM +, Hurugalawadi, Naveen wrote: Please find attached the patch which performs following patt

Re: Fold some equal to and not equal to patterns in match.pd

2015-07-23 Thread Segher Boessenkool
On Thu, Jul 23, 2015 at 10:09:49AM -0600, Jeff Law wrote: > It seems to me in these kind of cases that selection of the canonical > form should be driven by factors outside of which is better for a > particular target. ie, which is simpler I agree. But neither form is simpler here, and we need

[PATCH] Use unshare_expr more in c-ubsan.c

2015-07-23 Thread Marek Polacek
This sprinkles some more unshare_exprs here and there in the ubsan code. Maybe we'll have to add some more of them elsewhere, too. Unfortunately this doesn't fix the ARM -Wmaybe-uninitialized issue yet :(. Bootstrapped/regtested on x86_64-linux, ok for trunk? 2015-07-23 Marek Polacek

Re: [PATCH] Use unshare_expr more in c-ubsan.c

2015-07-23 Thread Jakub Jelinek
On Thu, Jul 23, 2015 at 07:06:40PM +0200, Marek Polacek wrote: > This sprinkles some more unshare_exprs here and there in the ubsan code. > Maybe we'll have to add some more of them elsewhere, too. > > Unfortunately this doesn't fix the ARM -Wmaybe-uninitialized issue yet :(. > > Bootstrapped/reg

Re: [patch] PR66714 -- Re: Re: [RFC] two-phase marking in gt_cleare_cache

2015-07-23 Thread Jakub Jelinek
On Thu, Jul 23, 2015 at 08:20:50AM -0700, Cesar Philippidis wrote: > The attached patch does just that; it teaches > replace_block_vars_by_duplicates to replace the decls inside the > value-exprs with a duplicate too. It's kind of messy though. At the > moment I'm only considering VAR_DECL, PARM_DE

Re: PR c/16351 Extend Wnonnull for returns_nonnull

2015-07-23 Thread Jeff Law
On 07/22/2015 09:29 AM, Manuel López-Ibáñez wrote: While looking at PR c/16351, I noticed that all tests proposed for -Wnull-attribute (https://gcc.gnu.org/ml/gcc-patches/2014-01/msg01715.html) could be warned from the FEs by simply extending the existing Wnonnull. Bootstrapped and regression te

Re: [patch] Include reduction on libackend.a and language source files

2015-07-23 Thread David Malcolm
On Wed, 2015-07-22 at 20:50 -0400, Andrew MacLeod wrote: (snip) > I then ran it through an ordering tool, (which I will eventually put in > contrib). This tool looks at include files, and puts them in a > "standard" order, and removes duplicates that have already been > included.. even if it

New Dutch PO file for 'cpplib' (version 5.2.0)

2015-07-23 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'cpplib' has been submitted by the Dutch team of translators. The file is available at: http://translationproject.org/latest/cpplib/nl.po (This file, 'cpplib-5.2.0.nl.po', h

Contents of PO file 'cpplib-5.2.0.nl.po'

2015-07-23 Thread Translation Project Robot
cpplib-5.2.0.nl.po.gz Description: Binary data The Translation Project robot, in the name of your translation coordinator.

Re: libstdc++: more __intN tweaks

2015-07-23 Thread DJ Delorie
> > * include/bits/functional_hash.h: Add specializations for __intN > > types. > > > > * include/ext/pb_ds/detail/thin_heap_/thin_heap_.hpp (__gnu_pbds): > > Guard against values that might exceed size_t's precision. > > Yes, OK - thanks. Committed. Thanks!

Re: [PATCH] gcc: fix building w/isl-0.15

2015-07-23 Thread Jeff Law
On 07/21/2015 02:32 PM, Sebastian Pop wrote: Could somebody with access to sourceware.org upload a tar.bz2 of the required version of isl from http://isl.gforge.inria.fr/isl-0.15.tar.bz2? Also, once that is done, I will commit the following patch updating the documentation. I've put isl-0.15.t

Re: [C/C++ PATCH] PR c++/66572. Fix Wlogical-op false positive

2015-07-23 Thread Jeff Law
On 07/21/2015 04:56 AM, Marek Polacek wrote: Ping. On Tue, Jul 14, 2015 at 06:38:12PM +0200, Marek Polacek wrote: Ok, in that case I think easiest would the following (I hit the same issue when writing the -Wtautological-compare patch): Bootstrapped/regtested on x86_64-linux, ok for trunk? 20

MAINTAINERS: Update my email address

2015-07-23 Thread Bernd Schmidt
I no longer work at Mentor/CodeSourcery. Until I start my new job in September I'll be using my personal email address. At this time I would like to propose to the SC (two members Cc'ed) that Nathan Sidwell be appointed nvptx maintainer instead of me, as he is the one who will continue to work

Re: [patch] Include reduction on libackend.a and language source files

2015-07-23 Thread Andrew MacLeod
On 07/23/2015 01:44 PM, David Malcolm wrote: On Wed, 2015-07-22 at 20:50 -0400, Andrew MacLeod wrote: (snip) I will eventually put all these tools into a directory in contrib. It simple enough to run it this ordering on any source file. (snip) If I'm understanding things right, we will have a

Re: [PATCH] fix in-tree-binutils builds

2015-07-23 Thread Mike Stump
On Jul 23, 2015, at 7:47 AM, H.J. Lu wrote: > On Fri, Jul 17, 2015 at 7:43 AM, H.J. Lu wrote: >> On Wed, Jul 15, 2015 at 9:47 AM, Mike Stump wrote: >>> On Jul 15, 2015, at 9:07 AM, H.J. Lu wrote: On Wed, Jul 15, 2015 at 1:03 AM, Jan Beulich wrote: > > - $gcc_cv_as_gas_src

Re: [PATCH 3/4] Add libgomp plugin for Intel MIC

2015-07-23 Thread Ilya Verbin
On Wed, Jul 08, 2015 at 16:16:44 +0200, Thomas Schwinge wrote: > > --- /dev/null > > +++ b/liboffloadmic/plugin/Makefile.am > > @@ -0,0 +1,123 @@ > > +# Plugin for offload execution on Intel MIC devices. > > > +main_target_image.h: offload_target_main > > + @echo -n "const int image_size = " > $

Re: [PATCH, rtl-opt, i386]: Backport fix for PR 58066, __tls_get_addr is called with misaligned stack on x86-64

2015-07-23 Thread Uros Bizjak
On Mon, Jul 20, 2015 at 5:00 PM, Uros Bizjak wrote: > Attached patch backports fixes for PR 58066 to release branches. > > 2015-07-XX Uros Bizjak > > Backport from mainline: > 2015-07-17 Uros Bizjak > > PR rtl-optimization/66891 > * calls.c (expand_call): Wrap precompute_regi

Re: [PR66726] Factor conversion out of COND_EXPR

2015-07-23 Thread Jeff Law
On 07/15/2015 11:52 PM, Kugan wrote: diff --git a/gcc/tree-ssa-reassoc.c b/gcc/tree-ssa-reassoc.c index 932c83a..3058eb5 100644 --- a/gcc/tree-ssa-reassoc.c +++ b/gcc/tree-ssa-reassoc.c return false; bb = gimple_bb (stmt); if (!single_succ_p (bb)) @@ -2729,9 +2743,8 @@ fina

Go patch committed

2015-07-23 Thread Ian Lance Taylor
This patch from Chris Manghane avoids a compiler crash for some kinds of invalid code. This is http://golang.org/issue/11592 . Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE =

Re: [PATCH 1/2] Allow REG_EQUAL for ZERO_EXTRACT

2015-07-23 Thread Jeff Law
On 07/19/2015 09:17 PM, Kugan wrote: I have made a mistake while addressing the review comments for this patch. Unfortunately, It was not detected in my earlier testing. My sincere graphology for the mistake. I have basically missed the STRICT_LOW_PART check for the first if-check thus the secon

Re: [patch] Include reduction on libackend.a and language source files

2015-07-23 Thread Jeff Law
On 07/22/2015 06:50 PM, Andrew MacLeod wrote: This is the result of running include reduction on all the files which make up libbackend.a, as well as most of the language files found in subdirectories lto, c ,cp, java, go, fortran, jit, ada. well, some of ada. :-) I looked at the output and han

Go patch committed

2015-07-23 Thread Ian Lance Taylor
This patch from Chris Manghane makes empty interface types for variables at parse time when there are no methods. This is normally cleaned up later, but for sink variables that clean up never happens and we get an internal compiler error. This fixes https://golang.org/issue/11579. Bootstrapped a

Re: [PATCH] Simple optimization for MASK_STORE.

2015-07-23 Thread Jeff Law
On 07/20/2015 09:05 AM, Yuri Rumyantsev wrote: Hi Jeff! Thanks for your details comments. You asked: How are conditionals on vectors usually handled? You should try to mimick that and report, with detail, why that's not working. In current implementation of vectorization pass all comparisons

Re: [PR64164] drop copyrename, integrate into expand

2015-07-23 Thread Segher Boessenkool
On Thu, Jul 23, 2015 at 12:29:14PM -0300, Alexandre Oliva wrote: > Yeah. Thanks, I've tested it with this change, and I'm now checking > this in (full patch first; adjusted incremental patch at the end): Unfortunately it causes about a thousand test fails on powerpc64-linux (at least, it seems to

Re: [patch] Include reduction on libackend.a and language source files

2015-07-23 Thread Andrew MacLeod
On 07/23/2015 03:55 PM, Jeff Law wrote: On 07/22/2015 06:50 PM, Andrew MacLeod wrote: Given the mechanical nature and size, I just did spot checks which looked fine. OK for the trunk. jeff I'll wait until early next week.. shortly I'll y be off-line until then so couldnt address any fall

Re: [PATCH, PR ipa/66566] Fix ICE in early_inliner: internal compiler error: in operator[]

2015-07-23 Thread Jeff Law
On 07/20/2015 06:08 AM, Ilya Enkovich wrote: Ping 2015-07-13 11:47 GMT+03:00 Ilya Enkovich : Ping 2015-06-18 12:54 GMT+03:00 Ilya Enkovich : Hi, In early_inliner we do recompute inline summaries for edges after optimize_inline_calls, but check this summary exists in case new edges appear.

Re: [PATCH][RTL-ifcvt] Make non-conditional execution if-conversion more aggressive

2015-07-23 Thread Jeff Law
On 07/13/2015 08:03 AM, Kyrill Tkachov wrote: 2015-07-13 Kyrylo Tkachov * ifcvt.c (struct noce_if_info): Add then_simple, else_simple, then_cost, else_cost fields. Change branch_cost field to unsigned int. (end_ifcvt_sequence): Call set_used_flags on each insn in the sequ

[PR lto/66752] Fix missed FSM jump thread

2015-07-23 Thread Jeff Law
This patch gives the FSM jump threading code the opportunity to find known values when we have a condition like (x != 0). Previously it just allowed naked SSA_NAMES (which is what appears in a SWITCH_EXPR). This patch allows us to thread a COND_EXPR. Basically given (x != 0), we just ask t

Re: [PR64164] drop copyrename, integrate into expand

2015-07-23 Thread H.J. Lu
On Thu, Jul 23, 2015 at 1:31 PM, Segher Boessenkool wrote: > On Thu, Jul 23, 2015 at 12:29:14PM -0300, Alexandre Oliva wrote: >> Yeah. Thanks, I've tested it with this change, and I'm now checking >> this in (full patch first; adjusted incremental patch at the end): > > Unfortunately it causes ab

Re: [PATCH, MIPS] Scheduling for M51xx core family

2015-07-23 Thread Richard Sandiford
Sorry for the slow reply, been away. Matthew Fortune writes: > Richard Sandiford writes: >> Robert Suchanek writes: >> > @@ -771,7 +771,8 @@ struct mips_cpu_info { >> > >> > /* Infer a -mnan=2008 setting from a -mips argument. */ >> > #define MIPS_ISA_NAN2008_SPEC \ >> > - "%{mnan*:;mips32r

[PATCH, committed] jit: supply MULTILIB_DEFAULTS as arguments when invoking driver

2015-07-23 Thread David Malcolm
x86_64-unknown-linux-gnu) +JIT: libgccjit (GCC) version 6.0.0 20150723 (experimental) (x86_64-unknown-linux-gnu) JIT: compiled by GNU C version 4.8.3 20140911 (Red Hat 4.8.3-7), GMP version 5.1.2, MPFR version 3.1.2, MPC version 1.0.1 JIT: entering: gcc_jit_context_set_str_option JIT: GCC_JI

Ping: [fr30] Fix indirect_jump pattern

2015-07-23 Thread Richard Sandiford
Ping Richard Sandiford writes: > The pattern was accepting a nonimediate_operand, using the C condition > to weed out certain types of memory, but was then using an "r" constraint > to force a register. This patch makes the predicate match the constraint > and removes the C condition. > > Tested

[PATCH, i386]: Rewrite sysv_va_list_type_node and ms_va_list_type_node initialization.

2015-07-23 Thread Uros Bizjak
Hello! This patch rewrites convoluted initialization of sysv_va_list_type_node and ms_va_list_type_node globals. 2015-07-23 Uros Bizjak * config/i386/i386.c (ix86_build_builtin_va_list_64): Rename from ix86_build_builtin_va_list_abi. Handle only 64bit non-MS_ABI targets here.

Re: [PR64164] drop copyrename, integrate into expand

2015-07-23 Thread H.J. Lu
On Thu, Jul 23, 2015 at 1:57 PM, H.J. Lu wrote: > On Thu, Jul 23, 2015 at 1:31 PM, Segher Boessenkool > wrote: >> On Thu, Jul 23, 2015 at 12:29:14PM -0300, Alexandre Oliva wrote: >>> Yeah. Thanks, I've tested it with this change, and I'm now checking >>> this in (full patch first; adjusted incre

Re: [patch] PR66714 -- Re: Re: [RFC] two-phase marking in gt_cleare_cache

2015-07-23 Thread Cesar Philippidis
On 07/23/2015 08:32 AM, Jakub Jelinek wrote: > On Thu, Jul 23, 2015 at 08:20:50AM -0700, Cesar Philippidis wrote: >> The attached patch does just that; it teaches >> replace_block_vars_by_duplicates to replace the decls inside the >> value-exprs with a duplicate too. It's kind of messy though. At t

Re: [patch] PR66714 -- Re: Re: [RFC] two-phase marking in gt_cleare_cache

2015-07-23 Thread Jakub Jelinek
On Thu, Jul 23, 2015 at 03:01:25PM -0700, Cesar Philippidis wrote: > On 07/23/2015 08:32 AM, Jakub Jelinek wrote: > > On Thu, Jul 23, 2015 at 08:20:50AM -0700, Cesar Philippidis wrote: > >> The attached patch does just that; it teaches > >> replace_block_vars_by_duplicates to replace the decls insi

Re: PR c/16351 Extend Wnonnull for returns_nonnull

2015-07-23 Thread Bernhard Reutner-Fischer
On July 23, 2015 7:43:51 PM GMT+02:00, Jeff Law wrote: >On 07/22/2015 09:29 AM, Manuel López-Ibáñez wrote: >> While looking at PR c/16351, I noticed that all tests proposed for >> -Wnull-attribute >> (https://gcc.gnu.org/ml/gcc-patches/2014-01/msg01715.html) could be >> warned from the FEs by simp

Re: [PR64164] drop copyrename, integrate into expand

2015-07-23 Thread David Edelsohn
On Thu, Jul 23, 2015 at 5:59 PM, H.J. Lu wrote: > On Thu, Jul 23, 2015 at 1:57 PM, H.J. Lu wrote: >> On Thu, Jul 23, 2015 at 1:31 PM, Segher Boessenkool >> wrote: >>> On Thu, Jul 23, 2015 at 12:29:14PM -0300, Alexandre Oliva wrote: Yeah. Thanks, I've tested it with this change, and I'm now

Re: [PR64164] drop copyrename, integrate into expand

2015-07-23 Thread H.J. Lu
On Thu, Jul 23, 2015 at 4:14 PM, David Edelsohn wrote: > On Thu, Jul 23, 2015 at 5:59 PM, H.J. Lu wrote: >> On Thu, Jul 23, 2015 at 1:57 PM, H.J. Lu wrote: >>> On Thu, Jul 23, 2015 at 1:31 PM, Segher Boessenkool >>> wrote: On Thu, Jul 23, 2015 at 12:29:14PM -0300, Alexandre Oliva wrote: >>

Re: [RFC, PATCH] nonzero attribute, static array parameter

2015-07-23 Thread Martin Uecker
Hi Marek, sorry for taking so long to respond. Fri, 15 May 2015 15:38:43 +0200 Marek Polacek : > On Sat, May 09, 2015 at 09:42:23AM -0700, Martin Uecker wrote: > > here is a tentative patch to implement a new attribute nonzero, > > which is similar to nonnull, but is not a function attribute >

Re: [PATCH] warn for unsafe calls to __builtin_return_address

2015-07-23 Thread Jeff Law
On 06/11/2015 04:05 PM, Martin Sebor wrote: Attached is an updated patch for both GCC and the manual. The patch implements the suggested warning, -Wbuiltin-address, that issues diagnostics for unsafe calls of the builtin address functions. Safe calls are those with arguments 0 or 1 anywhere in

Re: Ping: [fr30] Fix indirect_jump pattern

2015-07-23 Thread Jeff Law
On 07/23/2015 03:28 PM, Richard Sandiford wrote: Ping Richard Sandiford writes: The pattern was accepting a nonimediate_operand, using the C condition to weed out certain types of memory, but was then using an "r" constraint to force a register. This patch makes the predicate match the constr

Re: PR c/16351 Extend Wnonnull for returns_nonnull

2015-07-23 Thread Jeff Law
On 07/23/2015 04:44 PM, Bernhard Reutner-Fischer wrote: On July 23, 2015 7:43:51 PM GMT+02:00, Jeff Law wrote: On 07/22/2015 09:29 AM, Manuel López-Ibáñez wrote: While looking at PR c/16351, I noticed that all tests proposed for -Wnull-attribute (https://gcc.gnu.org/ml/gcc-patches/2014-01/msg0

Re: Fold some equal to and not equal to patterns in match.pd

2015-07-23 Thread Jeff Law
On 07/23/2015 10:33 AM, Segher Boessenkool wrote: On Thu, Jul 23, 2015 at 10:09:49AM -0600, Jeff Law wrote: It seems to me in these kind of cases that selection of the canonical form should be driven by factors outside of which is better for a particular target. ie, which is simpler I agree.