[PATCH] gcc/genrecog.c: Check matching constraint in MATCH_OPERAND.

2015-02-26 Thread Chen Gang S
If check fails, genrecog needs to stop and report error, so can let the issue be found in time. The implementation is referenced from "gcc/doc/ md.log": [...] whitespace Whitespace characters are ignored and can be inserted at any position except the first. This enables each al

Re: [PATCH] ubsan: remove bogus check for flexible array members

2015-02-26 Thread Martin Uecker
Thu, 26 Feb 2015 07:36:54 +0100 Jakub Jelinek : > On Wed, Feb 25, 2015 at 10:01:07PM -0800, Martin Uecker wrote: > > this patch removes a bogus check for flexible array members > > which prevents array references to be instrumented in some > > interesting cases. Arrays accessed through pointers ar

Re: [PATCH] ubsan: remove bogus check for flexible array members

2015-02-26 Thread Jakub Jelinek
On Thu, Feb 26, 2015 at 12:59:08AM -0800, Martin Uecker wrote: > > No, it is not bogus nor unnecessary. > > This isn't about just real flexible arrays, but similar constructs, > > C++ doesn't have flexible array members, nor C89, so people use the > > GNU extension of struct S { ... ; char a[0]; }

Re: [PATCH, 2/2][ARM]: New CPU support for Marvell Whitney

2015-02-26 Thread Maxim Kuvyrkov
> On Feb 26, 2015, at 10:42 AM, Xingxing Pan wrote: ... > Expand several arm types. > > 2015-02-26 Xingxing Pan > > * config/arm/types.md: > (neon_logic): Expand to neon_logic_reg and neon_logic_imm. > (neon_logic_q): Expand to neon_logic_reg_q and neon_logic_imm_q. > (neon_fr

Re: [PATCH] ubsan: remove bogus check for flexible array members

2015-02-26 Thread Marek Polacek
On Thu, Feb 26, 2015 at 12:59:08AM -0800, Martin Uecker wrote: > > Thu, 26 Feb 2015 07:36:54 +0100 > Jakub Jelinek : > > On Wed, Feb 25, 2015 at 10:01:07PM -0800, Martin Uecker wrote: > > > this patch removes a bogus check for flexible array members > > > which prevents array references to be inst

Re: [patch 1/2][ARM]: New CPU support for Marvell Whitney

2015-02-26 Thread Maxim Kuvyrkov
> On Feb 26, 2015, at 10:36 AM, Xingxing Pan wrote: > > On 02/25/2015 09:32 PM, Xingxing Pan wrote: >> Hi, >> >> This patch merges pipeline description for marvell-whitney to latest >> code base. >> Is it OK for trunk? >> > Refactor the commit message. > ... > Add pipeline description for ma

[PATCH] Fix PR63175

2015-02-26 Thread Richard Biener
I am currently testing the following patch to fix PR63175 - a regression in expanding realign-load expressions the vectorizer generates. get_object_alignment_2 gets MEM[&MEM[ptr + 4] & -16] here and while it extracts an alignment of 128 from the & -16 recursing on the address &MEM[ptr + 4] gets it

Re: [patch 1/2][ARM]: New CPU support for Marvell Whitney

2015-02-26 Thread Ramana Radhakrishnan
On Thu, Dec 18, 2014 at 10:13 AM, Xingxing Pan wrote: > Hi, > > This patch contains Marvell Whitney core's pipeline description. > Test on arm-linux-gnueabi and no new regression are found. > > Is it OK for trunk? I haven't had a chance to review this in detail but I think it's too late to add su

Re: [PATCH] ubsan: remove bogus check for flexible array members

2015-02-26 Thread Richard Biener
On Thu, Feb 26, 2015 at 8:32 AM, Marek Polacek wrote: > On Thu, Feb 26, 2015 at 07:36:54AM +0100, Jakub Jelinek wrote: >> On Wed, Feb 25, 2015 at 10:01:07PM -0800, Martin Uecker wrote: >> > this patch removes a bogus check for flexible array members >> > which prevents array references to be instr

Re: [patch 1/2][ARM]: New CPU support for Marvell Whitney

2015-02-26 Thread Kyrill Tkachov
Hi Xingxing, Some comments inline on the tuning struct and pipeline description. On 25/02/15 13:32, Xingxing Pan wrote: > Hi, > > This patch merges pipeline description for marvell-whitney to latest code base. > Is it OK for trunk? > > -- Regards, Xingxing > whitney_p1_20150225.patch A couple o

Re: [SH] Adding some peepholes (PR 61142)

2015-02-26 Thread Kaz Kojima
Oleg Endo wrote: > These are the peepholes as mentioned in PR 65153 and in PR 61142. They > try to wallpaper some bad RA choices and reduce the CSiBE code size by > approx. 3.9K bytes. > > A problem I ran into with this one is that the peephole2 pass drops > REG_INC notes, which makes the follow

var-tracking vs. pseudo registers (was: Option overriding in the offloading code path)

2015-02-26 Thread Thomas Schwinge
Hi! On Wed, 25 Feb 2015 18:00:54 +0100, Jakub Jelinek wrote: > On Wed, Feb 25, 2015 at 11:28:12AM +0100, Thomas Schwinge wrote: > > Am I on the right track with my assumption that it is correct that > > nvptx.c:nvptx_option_override is not invoked in the offloading code path, > > so we'd need a n

Re: [PR58315] reset inlined debug vars at return-to point

2015-02-26 Thread Richard Biener
On Thu, Feb 26, 2015 at 1:01 AM, Alexandre Oliva wrote: > On Feb 25, 2015, Jakub Jelinek wrote: > >> On Wed, Feb 25, 2015 at 06:17:33PM -0300, Alexandre Oliva wrote: >>> My measurements, for a not particularly unusual testcase, showed an >>> overall reduction of 63% in compile time, as indicated

Re: [PR58315] reset inlined debug vars at return-to point

2015-02-26 Thread Jakub Jelinek
On Thu, Feb 26, 2015 at 11:29:35AM +0100, Richard Biener wrote: > I claim you can achieve the same result by effectively inserting > those reset debug insns right before var-tracking itself and by > re-computing BLOCK "liveness". That will automatically deal > with code motion that extends the lif

Re: var-tracking vs. pseudo registers (was: Option overriding in the offloading code path)

2015-02-26 Thread Jakub Jelinek
On Thu, Feb 26, 2015 at 11:27:06AM +0100, Thomas Schwinge wrote: > Is this not the right way to skip it, or, Bernd, is this because we're > not yet handling some debug stuff in nvptx? (I tested that > > does

Re: [patch 1/2][ARM]: New CPU support for Marvell Whitney

2015-02-26 Thread Maxim Kuvyrkov
> On Feb 26, 2015, at 1:12 PM, Kyrill Tkachov wrote: > > ... > I've tried this patch out and added: > (automata_option "v") > (automata_option "time") > (automata_option "stats") > (automata_option "progress") > > to the .md file to get some compiler build-time stats on the automata. > I see t

Re: [patch, avr-tiny]: Fix handling of constant addresses.

2015-02-26 Thread Denis Chertykov
2015-02-25 18:56 GMT+03:00 Georg-Johann Lay : > The current avr-gcc ICEs in avr.c::tiny_valid_direct_memory_access_range > because XEXP (op, 0) is used on op which are not MEM_P (e.g. REG or SUBREG). > > If op is MEM_P then INTVAL might be used for on RTXes which are not > CONST_INT, e.g. CONST. >

Re: [PR58315] reset inlined debug vars at return-to point

2015-02-26 Thread Richard Biener
On Thu, Feb 26, 2015 at 11:42 AM, Jakub Jelinek wrote: > On Thu, Feb 26, 2015 at 11:29:35AM +0100, Richard Biener wrote: >> I claim you can achieve the same result by effectively inserting >> those reset debug insns right before var-tracking itself and by >> re-computing BLOCK "liveness". That wi

[PATCH, testsuite]: Cleanup final insns dump

2015-02-26 Thread Uros Bizjak
Hello! Attached patch introduces a new cleanup procedure to remove -fdump-final-insns dumps. 2015-02-26 Uros Bizjak * lib/gcc-dg.exp (cleanup-final-insns-dump): New procedure. * g++.dg/opt/dump1.C (dg-final): Call cleanup-final-insns-dump. Tested on x86_64-linux-gnu. OK for mainline

RE: [PATCH][4.9] PR 64569 - Backport support for MIPS binutils 2.25

2015-02-26 Thread Matthew Fortune
Jakub Jelinek writes: > On Tue, Feb 17, 2015 at 08:10:37PM +, Matthew Fortune wrote: > > Ping. Please could you advise if I can approve MIPS changes to release > > branches of if I need you/someone else to do so? > > Any maintainer or reviewer can approve changes to the release branches. > Of

Re: [PATCH, testsuite]: Cleanup final insns dump

2015-02-26 Thread Mike Stump
On Feb 26, 2015, at 3:01 AM, Uros Bizjak wrote: > Attached patch introduces a new cleanup procedure to remove > -fdump-final-insns dumps. > > 2015-02-26 Uros Bizjak > >* lib/gcc-dg.exp (cleanup-final-insns-dump): New procedure. >* g++.dg/opt/dump1.C (dg-final): Call cleanup-final-insn

Re: Ping : [PATCH] [gcc, combine] PR46164: Don't combine the insns if a volatile register is contained.

2015-02-26 Thread Terry Guo
On Thu, Feb 26, 2015 at 1:55 PM, Segher Boessenkool wrote: > On Tue, Feb 17, 2015 at 11:39:34AM +0800, Terry Guo wrote: >> On Sun, Feb 15, 2015 at 7:35 PM, Segher Boessenkool >> wrote: >> > Hi Terry, >> > >> > I still think this is stage1 material. >> > >> >> + /* Don't combine if dest contains

Re: [patch]: [Bug tree-optimization/61917] [4.9/5 Regression] ICE on valid code at -O3 on x86_64-linux-gnu in vectorizable_reduction, at tree-vect-loop.c:4913

2015-02-26 Thread Alex Velenko
On 25/02/15 16:51, H.J. Lu wrote: On Wed, Feb 25, 2015 at 5:10 AM, Kai Tietz wrote: Hello, So, I did full regression-test for following patch: ChangeLog 2015-02-25 Richard Biener Kai Tietz PR tree-optimization/61917 * tree-vect-loop.c (vectorizable_reduction): Allow

Re: [patch]: [Bug tree-optimization/61917] [4.9/5 Regression] ICE on valid code at -O3 on x86_64-linux-gnu in vectorizable_reduction, at tree-vect-loop.c:4913

2015-02-26 Thread Jakub Jelinek
On Thu, Feb 26, 2015 at 12:03:46PM +, Alex Velenko wrote: > This patch also breaks gcc.dg/pr56350.c for aarch64-none-elf, arm-none-eabi > and other arm targets. Failure looks very similar: Just svn update? r220987 should fix this. Jakub

Re: [PATCH] gcc/genrecog.c: Check matching constraint in MATCH_OPERAND.

2015-02-26 Thread Chen Gang S
On 02/26/2015 04:04 PM, Chen Gang S wrote: > If check fails, genrecog needs to stop and report error, so can let the > issue be found in time. The implementation is referenced from "gcc/doc/ > md.log": > > [...] > > whitespace >Whitespace characters are ignored and can be inserted at

[C++ PATCH] Fix ICE in C++14 with null RETURN_EXPR (PR c++/65202)

2015-02-26 Thread Marek Polacek
We ICE on this invalid testcase in C++14 because in C++14 a function returning void is a valid constexpr function, so adl_swap is registered as one, while in C++11 it is not registered. Then later on, we weren't able to properly handle a RETURN_EXPR with null operand when trying to evaluate the ex

Re: [C++ PATCH] Fix ICE in C++14 with null RETURN_EXPR (PR c++/65202)

2015-02-26 Thread Kai Tietz
Hi Marek, I have similiar change on the c++-delayed-fold branch. 2015-02-26 13:22 GMT+01:00 Marek Polacek : > We ICE on this invalid testcase in C++14 because in C++14 a function returning > void is a valid constexpr function, so adl_swap is registered as one, while in > C++11 it is not registere

Re: [C++ PATCH] Fix ICE in C++14 with null RETURN_EXPR (PR c++/65202)

2015-02-26 Thread Marek Polacek
On Thu, Feb 26, 2015 at 01:26:01PM +0100, Kai Tietz wrote: > > @@ -2935,7 +2935,7 @@ cxx_eval_constant_expression (const constexpr_ctx > > *ctx, tree t, > >constexpr_ctx new_ctx; > >tree r = t; > > > > - if (t == error_mark_node) > > + if (t == NULL_TREE || t == error_mark_node) > >

Re: [C++ PATCH] Fix ICE in C++14 with null RETURN_EXPR (PR c++/65202)

2015-02-26 Thread Jason Merrill
On 02/26/2015 07:22 AM, Marek Polacek wrote: - if (t == error_mark_node) + if (t == NULL_TREE || t == error_mark_node) { *non_constant_p = true; No, we don't want an empty return to make the call non-constant, it's perfectly valid. Let's handle this specifically in the RETURN_

Re: [patch] PR debug/46102 Disable -feliminate-dwarf2-dups when reading a PCH

2015-02-26 Thread Jason Merrill
On 02/25/2015 09:53 PM, Aldy Hernandez wrote: On 02/25/2015 06:47 PM, Jason Merrill wrote: On 02/25/2015 09:16 PM, Aldy Hernandez wrote: + warning (0, "ignoring unimplemented option -feliminate-dwarf2-dups"); Similarly, I'd rather say it's broken for C++. OK with that change. Interest

Re: [patch]: [Bug tree-optimization/61917] [4.9/5 Regression] ICE on valid code at -O3 on x86_64-linux-gnu in vectorizable_reduction, at tree-vect-loop.c:4913

2015-02-26 Thread Alex Velenko
Hi Jakub, Just tested with latest svn update. The issue is indeed gone. Kind regards, Alex On 26/02/15 12:12, Jakub Jelinek wrote: On Thu, Feb 26, 2015 at 12:03:46PM +, Alex Velenko wrote: This patch also breaks gcc.dg/pr56350.c for aarch64-none-elf, arm-none-eabi and other arm targets. Fai

Re: [patch] fix PR65048: check that jump-thread paths are still valid

2015-02-26 Thread Jeff Law
On 02/13/15 16:50, Sebastian Pop wrote: Hi, the attached patch fixes PR65048 by checking before jump-threading that a path to be threaded is still valid: as the testcase shows, there may be paths that are not connected anymore because the cfg has changed in a previous jump-thread. PR t

[committed] Add missing cleanup in gcc.misc-tests/godump-1.c

2015-02-26 Thread Tom de Vries
Hi, Committed as obvious. Thanks, - Tom 2015-02-26 Tom de Vries * gcc.misc-tests/godump-1.c: Add missing cleanup of godump-1.out. --- gcc/testsuite/ChangeLog | 4 gcc/testsuite/gcc.misc-tests/godump-1.c | 2 ++ 2 files changed, 6 insertions(+) diff --git a/gcc/tests

Re: [C++ PATCH] Fix ICE in C++14 with null RETURN_EXPR (PR c++/65202)

2015-02-26 Thread Marek Polacek
On Thu, Feb 26, 2015 at 08:35:00AM -0500, Jason Merrill wrote: > On 02/26/2015 07:22 AM, Marek Polacek wrote: > >- if (t == error_mark_node) > >+ if (t == NULL_TREE || t == error_mark_node) > > { > >*non_constant_p = true; > > No, we don't want an empty return to make the call non-c

Re: [PATCH] Fix for PR ipa/64693

2015-02-26 Thread Martin Liška
On 02/25/2015 07:46 PM, Jan Hubicka wrote: >From dd240028726cb7fdc777acd0b6d14c4f89aed714 Mon Sep 17 00:00:00 2001 From: mliska Date: Thu, 19 Feb 2015 16:08:09 +0100 Subject: [PATCH 1/3] Fix PR ipa/64693 2015-02-25 Martin Liska Jan Hubicka * gcc.dg/ipa/ipa-icf-26.c

[committed] Add missing cleanup in pch-init

2015-02-26 Thread Tom de Vries
Hi, committed as obvious. Thanks, - Tom 2015-02-26 Tom de Vries * lib/dg-pch.exp (pch-init): Add missing cleanup of pchtest.o. diff --git a/gcc/testsuite/lib/dg-pch.exp b/gcc/testsuite/lib/dg-pch.exp index e250301..9b4f40b 100644 --- a/gcc/testsuite/lib/dg-pch.exp +++ b/gcc/testsuite/lib/d

[committed, PATCH] Add a testcase for PR target/65217

2015-02-26 Thread H.J. Lu
I checked in this to add a testcase for PR target/65217. H.J. Index: ChangeLog === --- ChangeLog (revision 221008) +++ ChangeLog (working copy) @@ -1,3 +1,8 @@ +2015-02-26 H.J. Lu + + PR target/65217 + * gcc.target/

Re: [PATCH] Fix ICE in early inliner (PR ipa/65008)

2015-02-26 Thread Marek Polacek
Ping. On Thu, Feb 19, 2015 at 09:03:51PM +0100, Marek Polacek wrote: > On Thu, Feb 19, 2015 at 12:06:40PM +0100, Richard Biener wrote: > > On Thu, 19 Feb 2015, Marek Polacek wrote: > > > > > The problem exposed by this PR is (IIUC) that we hadn't gotten around to > > > recomputing the inline para

[committed] Add missing cleanup in gcc.dg/aru-2.c

2015-02-26 Thread Tom de Vries
Hi, committed as obvious. Thanks, - Tom 2015-02-26 Tom de Vries * gcc.dg/aru-2.c: Add missing cleanup-profile-file. diff --git a/gcc/testsuite/gcc.dg/aru-2.c b/gcc/testsuite/gcc.dg/aru-2.c index d36adc1..054223c 100644 --- a/gcc/testsuite/gcc.dg/aru-2.c +++ b/gcc/testsuite/gcc.dg/aru-2.c @

[PATCH] GCC LTO-bootstrap -Wodr fix

2015-02-26 Thread Martin Liška
Hello. Following error message can be seen for LTO boostrap: ../../gcc/fortran/resolve.c:3812:1: error: type ‘comparison’ violates one definition rule [-Werror=odr] comparison; ^ ../../gcc/compare-elim.c:95:0: note: a different type is defined in another translation unit rtx_insn *insn;

Re: [patch] fix PR65048: check that jump-thread paths are still valid

2015-02-26 Thread Sebastian Pop
On Thu, Feb 26, 2015 at 7:56 AM, Jeff Law wrote: > On 02/13/15 16:50, Sebastian Pop wrote: >> >> Hi, >> >> the attached patch fixes PR65048 by checking before jump-threading that a >> path >> to be threaded is still valid: as the testcase shows, there may be paths >> that >> are not connected anym

[committed] Add missing cleanup in gcc.target/i386/mcount_pic.c

2015-02-26 Thread Tom de Vries
Hi, committed as obvious. Thanks, - Tom 2015-02-26 Tom de Vries * gcc.target/i386/mcount_pic.c: Add missing cleanup-profile-file. diff --git a/gcc/testsuite/gcc.target/i386/mcount_pic.c b/gcc/testsuite/gcc.target/i386/mcount_pic.c index 806b7d5..1e59995 100644 --- a/gcc/testsuite/gcc.targe

[committed] Add missing cleanup in g++.dg/gcov/gcov-14.C

2015-02-26 Thread Tom de Vries
Hi, committed as obvious. Thanks, - Tom 2015-02-26 Tom de Vries * g++.dg/gcov/gcov-14.C: Add cleanup of iostream.gcov, ostream.gcov and locale_facets.h.gcov. diff --git a/gcc/testsuite/g++.dg/gcov/gcov-14.C b/gcc/testsuite/g++.dg/gcov/gcov-14.C index 8f8e388..b069d0e 100644 --- a/gcc/test

[patch]: Fix Bug 65038 - [regression 5] Unable to find ftw.h for libgcov-util.c

2015-02-26 Thread Kai Tietz
Hi, This is the remaining fix for re-enabling native boostrap for Windows-variant of gcc without disabling -Werror for libgcc. ChangeLog 2015-02-26 Kai Tietz PR target/65038 * config.in: Regenerated. * configure: Likewise. * configure.ac (AC_HEADER_STDC): Add explicit. (A

Re: [C++ PATCH] Fix ICE in C++14 with null RETURN_EXPR (PR c++/65202)

2015-02-26 Thread Jason Merrill
OK, thanks. Jason

Re: [PATCH] ubsan: remove bogus check for flexible array members

2015-02-26 Thread Marek Polacek
On Thu, Feb 26, 2015 at 11:08:04AM +0100, Richard Biener wrote: > > --- gcc/c-family/c-ubsan.c > > +++ gcc/c-family/c-ubsan.c > > @@ -303,8 +303,9 @@ ubsan_instrument_bounds (location_t loc, tree array, > > tree *index, > > > >/* Detect flexible array members and suchlike. */ > >tree base

[patch, testsuite] Add profopt-target-cleanup

2015-02-26 Thread Tom de Vries
Hi, this patch adds proc profopt-target-cleanup, which cleans up profile files, while also taking dg-additional-sources into account. Using profopt-target-cleanup in profopt-execute, we cleanup f.i. ic-misattribution-1a.gcda after running the tree-prof/ic-misattribution-1.c testcase. OK fo

Re: [PATCH] GCC LTO-bootstrap -Wodr fix

2015-02-26 Thread Tobias Burnus
Martin Liska wrote: > Following error message can be seen for LTO boostrap: > ../../gcc/fortran/resolve.c:3812:1: error: type âcomparisonâ violates one > definition rule [-Werror=odr] > comparison; > ^ >../../gcc/compare-elim.c:95:0: note: a different type is defined in another >translation unit

[PATCH, testsuite] Add missing cleanup in run-gcov

2015-02-26 Thread Tom de Vries
Hi, This patch adds cleaning up of uninteresting leftover coverage files in case of xfail, f.i. for gcc.misc-tests/gcov-13.c. OK for stage4 trunk? Thanks, - Tom 2015-02-26 Tom de Vries * lib/gcov.exp: Cleanup in case of xfail. --- gcc/testsuite/lib/gcov.exp | 3 +++ 1 file changed, 3 in

Re: [PATCH] gcc/genrecog.c: Check matching constraint in MATCH_OPERAND.

2015-02-26 Thread Chen Gang S
On 02/26/2015 08:13 PM, Chen Gang S wrote: > On 02/26/2015 04:04 PM, Chen Gang S wrote: >> If check fails, genrecog needs to stop and report error, so can let the >> issue be found in time. The implementation is referenced from "gcc/doc/ >> md.log": >> >> [...] >> >> whitespace >>Whites

Re: [PATCH] ubsan: remove bogus check for flexible array members

2015-02-26 Thread Martin Uecker
Marek Polacek : (Hi Marek and Jakub, I really appreciate your work on GCC and ubsan. I just want to add the minor enhancements necessary to make it really useful for me). > > And this is broken code. I would argue that a user who uses the > > ubsan *expects* this to be diagnosed. Atleast I was

Re: [PATCH, rs6000, testsuite] Changes for unaligned vector load/store support on POWER8

2015-02-26 Thread David Edelsohn
On Tue, Feb 10, 2015 at 8:18 PM, Bill Schmidt wrote: > Hi David, > > Sorry I haven't gotten back to this sooner. I've tried to address your > comments about the previous patch. Please let me know if I'm off base. > Test results are the same as previously. > > Thanks, > Bill > > > [gcc] > > 2015-

Re: [PATCH] rs6000: Fix HTM tcheck assembly encoding

2015-02-26 Thread Peter Bergner
On Wed, 2015-02-25 at 16:22 -0600, Peter Bergner wrote: > On Mon, 2015-02-23 at 13:42 -0500, David Edelsohn wrote: > > On Mon, Feb 23, 2015 at 1:26 PM, Peter Bergner wrote: > > > This is broken on 4.9 and 4.8, so can we get those fixed as well? > > > > Yes, please backport. > > I committed this

Re: [PR58315] reset inlined debug vars at return-to point

2015-02-26 Thread Petr Machata
Jakub Jelinek writes: > it counts on what percentage of bytes in those ranges (or instructions?) > the variable has defined location. Yes, it counts bytes. It doesn't know anything about instruction lengths etc. Thanks, Petr

Re: ipa-icf::merge TLC

2015-02-26 Thread Jack Howarth
On Wed, Feb 25, 2015 at 3:38 AM, Jan Hubicka wrote: > > I plan to commit after some further testing tomorrow and having chance > Martin to look across the changes and discuss 5). > > Honza > Is this still going in today or is there a newer patch to test? Jack

Re: [PR58315] reset inlined debug vars at return-to point

2015-02-26 Thread Alexandre Oliva
On Feb 26, 2015, Richard Biener wrote: > After all if the inliner inserts resets just for vars that already > have debug stmts then I cook up a testcase where those debug stmts > only appear after inlining. Please try that. Hint: the actual requirement is that the VTA-trackable var has been rem

Re: [PR58315] reset inlined debug vars at return-to point

2015-02-26 Thread Alexandre Oliva
On Feb 25, 2015, Alexandre Oliva wrote: > if a function is called within a loop and we inline it, bindings from > the call in one iteration of the loop will carry over onto the > subsequent iteration until a new binding occurs. Wait, I have to take that back and revisit the code I looked at. var

Re: [PATCH] ubsan: remove bogus check for flexible array members

2015-02-26 Thread Martin Uecker
Am Thu, 26 Feb 2015 10:05:14 +0100 Jakub Jelinek : > On Thu, Feb 26, 2015 at 12:59:08AM -0800, Martin Uecker wrote: > > > No, it is not bogus nor unnecessary. > > > This isn't about just real flexible arrays, but similar constructs, > > > C++ doesn't have flexible array members, nor C89, so people

[Patch 1/2, Fortran, pr60322] [OOP] Incorrect bounds on polymorphic dummy array

2015-02-26 Thread Andre Vehreschild
Hi all, please find attached the first part of a two parts patch fixing pr/60322. This first patch is only preparatory and does not change any of the semantics of gfortran at all. It only modifies the compiler code to have the symbol_attribute and the gfc_array_spec in a separate variable in the s

[Patch 2/2, Fortran, pr60322 a.o.] [OOP] Incorrect bounds on polymorphic dummy array

2015-02-26 Thread Andre Vehreschild
Hi all, here is the second part of the patch for pr60322. This patch also addresses the issue reported in pr64692, ... (more to come). The patch fixes the incorrect bounds of polymorphic arrays used to call functions and subroutines by using the same mechanism as regular arrays. In fact most of t

Re: [Ada] convert GNAT doc to sphinx

2015-02-26 Thread Arnaud Charlet
Thanks for your feedback, very useful! > How are you testing this? When getting the jit docs to work I had to > hack up the script somewhat to be able to test it on a development box > (e.g. to cut back "MANUALS" to just libcpp to speed up testing). That's a good question. Truth is that so far I

Re: libgomp nvptx plugin: rework initialisation and support the proposed load/unload hooks (was: Merge current set of OpenACC changes from gomp-4_0-branch)

2015-02-26 Thread Ilya Verbin
Hi, On Wed, Feb 25, 2015 at 10:36:08 +0100, Thomas Schwinge wrote: > > Julian Brown wrote: > > This is a version of the previously-posted patch to rework > > initialisation and support the proposed load/unload hooks, merged to > > gomp4 branch and tested alongside the two patches (from Currently

Re: [patch] fix PR65048: check that jump-thread paths are still valid

2015-02-26 Thread Sebastian Pop
Jeff Law wrote: > On 02/25/15 12:18, Sebastian Pop wrote: > >Jeff Law wrote: > >>On 02/18/15 15:27, Sebastian Pop wrote: > The dumps for the FSM threads are a bit sparse -- they don't show > the entire path. That makes it much harder to see what's going on. > >>> > >>>Would a patch improvi

[PATCH] Remove inefficient branchless conditional negate optimization

2015-02-26 Thread Wilco Dijkstra
Several GCC versions ago a conditional negate optimization was introduced as a workaround for PR45685. However the branchless expansion for conditional negate is extremely inefficient on most targets (5 sequentially dependent instructions rather than 2 on AArch64). Since the underlying issue has

Re: [PR58315] reset inlined debug vars at return-to point

2015-02-26 Thread Alexandre Oliva
On Feb 26, 2015, Richard Biener wrote: > and more concentrating on the effect of your patch as opposed to > debug stmt philosophy. > (which looks reasonable minus code-motion issues). > (but we might still want to compute it during var-tracking > if at a later PC range the scope will be active

Re: [Ada] convert GNAT doc to sphinx

2015-02-26 Thread David Malcolm
On Wed, 2015-02-25 at 16:47 +0100, Arnaud Charlet wrote: > > > I've added a -I gcc/gcc/ada/doc/gnat_ugn there, that's as far as my > > > knowledge goes for this script so I hope this is enough. > > > > Well, since by default the find command deletes all files except those > > known to be documenta

RE: [PATCH][ARM] PR target/64600 Fix another ICE with -mtune=xscale: properly sign-extend mask during constant splitting

2015-02-26 Thread Kyrill Tkachov
Ping. Thanks, Kyrill > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Kyrill Tkachov > Sent: 18 February 2015 16:07 > To: GCC Patches > Cc: Ramana Radhakrishnan; Richard Earnshaw > Subject: Re: [PATCH][ARM] PR target/64600 F

Re: [patch, testsuite] Add profopt-target-cleanup

2015-02-26 Thread Mike Stump
On Feb 26, 2015, at 7:04 AM, Tom de Vries wrote: > this patch adds proc profopt-target-cleanup, which cleans up profile files, > while also taking dg-additional-sources into account. > > Using profopt-target-cleanup in profopt-execute, we cleanup f.i. > ic-misattribution-1a.gcda after running t

Re: [PATCH, testsuite] Add missing cleanup in run-gcov

2015-02-26 Thread Mike Stump
On Feb 26, 2015, at 7:09 AM, Tom de Vries wrote: > This patch adds cleaning up of uninteresting leftover coverage files in case > of xfail, f.i. for gcc.misc-tests/gcov-13.c. > > OK for stage4 trunk? Ok.

Re: [PATCH] Fix ICE in early inliner (PR ipa/65008)

2015-02-26 Thread Jan Hubicka
> > > > 2015-02-19 Marek Polacek > > > > > > > > PR ipa/65008 > > > > * ipa-inline.c (early_inliner): Recompute inline parameters. > > > > > > > > * g++.dg/ipa/pr65008.C: New test. > > > > > > > > diff --git gcc/ipa-inline.c gcc/ipa-inline.c > > > > index 025f7fc..c445

Re: [PATCH] Fix ICE in early inliner (PR ipa/65008)

2015-02-26 Thread Jan Hubicka
> > > Are cgraph edges up-to-date here? I'd doubt that... if so, why not > > > do this update in the inliner itself where it updates the cgraph edges? And for Richard's comment - edges are kept up-to-date by the inliner - that is also necessary for clonning and other stuff. Parameters are not ke

Re: [PATCH] Fix for PR ipa/64693

2015-02-26 Thread Jan Hubicka
2015-02-25 Martin Liska Jan Hubicka PR ipa/64693 * ipa-icf.c (symbol_compare_collection::symbol_compare_collection): New. (sem_item_optimizer::subdivide_classes_by_sensitive_refs): New function. (sem_item_optimizer::process_cong_reduction): Include

Re: [Ada] convert GNAT doc to sphinx

2015-02-26 Thread Mike Stump
On Feb 26, 2015, at 9:07 AM, David Malcolm wrote: >> We'll need a more recent version of sphinx than >> 1.0 though (at least 1.2.2, or even better, 1.3b2 which is the version we use >> at AdaCore). > > The specific version of sphinx in use for gcc.gnu.org is 1.0.8 So, if people check in the gene

[patch c-family]: Fix Bug 35330 - [4.8/4.9/5 regression] ICE with invalid pragma weak

2015-02-26 Thread Kai Tietz
Hi, This patch addresses the reported ICE about #pragma weak used on declarations not var or function. ChangeLog 2015-02-26 Kai Tietz * c-pragma.c (handle_pragma_weak): Do not try to creat weak/alias of declarations not being function, or variable declarations. Bootstrapped

[PING] [wwwdocs, patch] Add libgccjit to gcc-5/changes.html

2015-02-26 Thread David Malcolm
On Thu, 2015-02-05 at 21:47 -0500, David Malcolm wrote: > This patch adds an -level section about libgccjit between the > sections on languages and targets. > > It has various links to the documentation (now that that's on the > website), and to a couple of 3rd party repos (the Python and D > bind

Re: [patch c-family]: Fix Bug 35330 - [4.8/4.9/5 regression] ICE with invalid pragma weak

2015-02-26 Thread H.J. Lu
On Thu, Feb 26, 2015 at 10:28 AM, Kai Tietz wrote: > Hi, > > This patch addresses the reported ICE about #pragma weak used on > declarations not var or function. > > ChangeLog > > 2015-02-26 Kai Tietz > > * c-pragma.c (handle_pragma_weak): Do not try to creat > weak/alias of declaration

Re: [patch c-family]: Fix Bug 35330 - [4.8/4.9/5 regression] ICE with invalid pragma weak

2015-02-26 Thread Marek Polacek
On Thu, Feb 26, 2015 at 07:28:02PM +0100, Kai Tietz wrote: > Hi, > > This patch addresses the reported ICE about #pragma weak used on > declarations not var or function. > > ChangeLog > > 2015-02-26 Kai Tietz > > * c-pragma.c (handle_pragma_weak): Do not try to creat "create" > wea

[PATCH] Fix bswap load optimization on big-endian (PR tree-optimization/65215)

2015-02-26 Thread Jakub Jelinek
Hi! If we cast a wider memory load on big endian to a narrower type and then byteswap that, we can't load the the narrower object from the address of the larger original load, because it contains the MS bytes, rather than LS bytes. Fixed thusly, bootstrapped/regtested on x86_64-linux, i686-linux,

[PATCH] Fix reassociation (PR tree-optimization/65216)

2015-02-26 Thread Jakub Jelinek
Hi! On the following testcase, there is a redundant & 1 and when reassociating, we remove the redundant & 1. The outer 2 ops are the same, so changed is still false when we reach rewrite_expr_tree with the last 2 ops (i.e. last statement). But, as we don't keep that statement as is nor just swap

Re: [SH] Adding some peepholes (PR 61142)

2015-02-26 Thread Oleg Endo
On Thu, 2015-02-26 at 19:21 +0900, Kaz Kojima wrote: > Oleg Endo wrote: > > These are the peepholes as mentioned in PR 65153 and in PR 61142. They > > try to wallpaper some bad RA choices and reduce the CSiBE code size by > > approx. 3.9K bytes. > > > > A problem I ran into with this one is that

Re: Offloading compilers' support libraries

2015-02-26 Thread Ilya Verbin
On Fri, Feb 20, 2015 at 22:48:52 +0300, Ilya Verbin wrote: > On Fri, Feb 20, 2015 at 18:05:01 +0300, Ilya Verbin wrote: > > On Thu, Feb 19, 2015 at 13:17:37 +0100, Thomas Schwinge wrote: > > > My asumption is that it is always safe to install non-native (that is > > > cross) GCC installations into

[PATCH, testsuite]: Fix gcc.dg/vect/vect-pr61917.c testcase

2015-02-26 Thread Uros Bizjak
Hello! The testcases in gcc.dg/vect have special way to pass their compile flags to testsuite framework. 2015-02-26 Uros Bizjak * gcc.dg/vect/vect-pr61917.c: Rename to ... * gcc.dg/vect/O3-vect-pr61917.c: ... this. (dg-additional-options): Remove dg directive. (dg-final): Add

Re: [patch, avr] Take 2: Fix PR64331: insn output and insn length computation rely on REG_DEAD notes.

2015-02-26 Thread Georg-Johann Lay
Am 02/23/2015 um 11:53 AM schrieb Georg-Johann Lay: This patch fixes PR64331 which produced wrong code because of outdated (too many) REG_DEAD notes. These notes are not (re)computed per default, hence do the computation by hand each time avr.c:reg_unused_after is called in a different pass. L

Re: Ping : [PATCH] [gcc, combine] PR46164: Don't combine the insns if a volatile register is contained.

2015-02-26 Thread Richard Sandiford
Terry Guo writes: > On Thu, Feb 26, 2015 at 1:55 PM, Segher Boessenkool > wrote: >> On Tue, Feb 17, 2015 at 11:39:34AM +0800, Terry Guo wrote: >>> On Sun, Feb 15, 2015 at 7:35 PM, Segher Boessenkool >>> wrote: >>> > Hi Terry, >>> > >>> > I still think this is stage1 material. >>> > >>> >> + /* D

Re: [committed] Add missing cleanup in pch-init

2015-02-26 Thread Bernhard Reutner-Fischer
On February 26, 2015 3:15:52 PM GMT+01:00, Tom de Vries wrote: >Hi, > >committed as obvious. Seems like i never pushed http://marc.info/?l=gcc-patches&m=138400411017920&w=1 Thanks!

Re: [PATCH] Fix reassociation (PR tree-optimization/65216)

2015-02-26 Thread Richard Biener
On February 26, 2015 8:13:46 PM CET, Jakub Jelinek wrote: >Hi! > >On the following testcase, there is a redundant & 1 and when >reassociating, >we remove the redundant & 1. The outer 2 ops are the same, so changed >is still false when we reach rewrite_expr_tree with the last 2 ops >(i.e. >last st

Re: [patch c-family]: Fix Bug 35330 - [4.8/4.9/5 regression] ICE with invalid pragma weak

2015-02-26 Thread Kai Tietz
2015-02-26 19:53 GMT+01:00 Marek Polacek : > On Thu, Feb 26, 2015 at 07:28:02PM +0100, Kai Tietz wrote: >> Hi, >> >> This patch addresses the reported ICE about #pragma weak used on >> declarations not var or function. >> >> ChangeLog >> >> 2015-02-26 Kai Tietz >> >> * c-pragma.c (handle

Re: [PATCH] Fix bswap load optimization on big-endian (PR tree-optimization/65215)

2015-02-26 Thread Richard Biener
On February 26, 2015 8:07:48 PM CET, Jakub Jelinek wrote: >Hi! > >If we cast a wider memory load on big endian to a narrower type and >then >byteswap that, we can't load the the narrower object from the >address of the larger original load, because it contains the MS bytes, >rather than LS bytes.

Re: [PATCH, testsuite]: Fix gcc.dg/vect/vect-pr61917.c testcase

2015-02-26 Thread Richard Biener
On February 26, 2015 8:26:45 PM CET, Uros Bizjak wrote: >Hello! > >The testcases in gcc.dg/vect have special way to pass their compile >flags to testsuite framework. But it's especially ugly and we should transition away from it. Richard. >2015-02-26 Uros Bizjak > >* gcc.dg/vect/vect-pr6

Re: [PATCH, rs6000, testsuite] Changes for unaligned vector load/store support on POWER8

2015-02-26 Thread Bill Schmidt
On Thu, 2015-02-26 at 10:36 -0500, David Edelsohn wrote: > My one concern is the interaction between TARGET_ALLOW_MOVMISALIGN and > TARGET_EFFICIENT_UNALIGNED_VSX in the movmisalign pattern in > vector.md. Your patch changes > rs6000_builtin_support_vector_misalignment to return TRUE if > TARGET_

[committed] Add missing cleanup in go-gc-tests for cmpout

2015-02-26 Thread Tom de Vries
Hi, This patch gets rid of these non-interesting .exe files: ... gcc/testsuite/go: bug206.exe bug409.exe deferprint.exe go.log.sep go.sum helloworld.exe printbig.exe site.exp bug328.exe cplx0.exe go.log goprint.exe go.sum.sep issue6899.exe sigchld.exe string.exe g

[PATCH, libsanitizer] Enable for PowerPC little endian

2015-02-26 Thread Peter Bergner
The upstream libsanitizer code has been modified to support powerpc64le-linux, but we seemed to have forgot to enable it being built by default on LE. I applied the patch below and ran the testsuite and the test results look similar to the BE results, maybe even a little better. I believe they sho

Re: [PATCH, libsanitizer] Enable for PowerPC little endian

2015-02-26 Thread Jakub Jelinek
On Thu, Feb 26, 2015 at 03:52:24PM -0600, Peter Bergner wrote: > The upstream libsanitizer code has been modified to support powerpc64le-linux, > but we seemed to have forgot to enable it being built by default on LE. > I applied the patch below and ran the testsuite and the test results look > sim

[doc,committed] spelling/typo fixes

2015-02-26 Thread Sandra Loosemore
I spotted some typos and inconsistent spelling in extend.texi. I've checked in the attached patch as an obvious fix. -Sandra 2015-02-26 Sandra Loosemore gcc/ * doc/extend.texi (Function Attributes): Fix spelling and typos. (Label Attributes): Likewise. (Cilk Plus Builtins): Likewise.

Re: [PATCH] Remove inefficient branchless conditional negate optimization

2015-02-26 Thread Jeff Law
On 02/26/15 10:30, Wilco Dijkstra wrote: Several GCC versions ago a conditional negate optimization was introduced as a workaround for PR45685. However the branchless expansion for conditional negate is extremely inefficient on most targets (5 sequentially dependent instructions rather than 2 o

Re: [patch, avr] Take 2: Fix PR64331: insn output and insn length computation rely on REG_DEAD notes.

2015-02-26 Thread Steven Bosscher
On Thu, Feb 26, 2015 at 8:35 PM, Georg-Johann Lay wrote: > Take #2 introduces a new, avr-specific rtl pass whose sole purpose is to > rectify notes. The pass is scheduled right before cfg does down (right > before .*free_cfg) so that cfg and hence df machinery is available. > > Regression tests lo

Re: [PATCH, rs6000, testsuite] Changes for unaligned vector load/store support on POWER8

2015-02-26 Thread Bill Schmidt
On Thu, 2015-02-26 at 14:40 -0600, Bill Schmidt wrote: > On Thu, 2015-02-26 at 10:36 -0500, David Edelsohn wrote: > > > My one concern is the interaction between TARGET_ALLOW_MOVMISALIGN and > > TARGET_EFFICIENT_UNALIGNED_VSX in the movmisalign pattern in > > vector.md. Your patch changes > > rs6

Re: [PATCH, libsanitizer] Enable for PowerPC little endian

2015-02-26 Thread David Edelsohn
On Thu, Feb 26, 2015 at 4:56 PM, Jakub Jelinek wrote: > On Thu, Feb 26, 2015 at 03:52:24PM -0600, Peter Bergner wrote: >> The upstream libsanitizer code has been modified to support >> powerpc64le-linux, >> but we seemed to have forgot to enable it being built by default on LE. >> I applied the p

[PATCH, testsuite] Fix gcc.dg/vect/pr59354.c

2015-02-26 Thread Pat Haugen
The subject testcase is failing on older powerpc64 hardware that doesn't support vector instructions because the prolog code is saving callee save vector registers used in the loop before the check_vect() call has even been performed. Following was tested on powerpc64-linux. Ok for trunk/4.9 br

Re: [doc, rfa] (v2) improve x86 transactional memory intrinsics section

2015-02-26 Thread Gerald Pfeifer
On Tue, 24 Feb 2015, Sandra Loosemore wrote: > Thanks for the review; I think we've got the technical corrections > nailed down now. Doc maintainers, is this OK? You can approve yourself now. Watch out for my next mail. ;-) Gerald

  1   2   >