[PATCH] Fix sporadic failure in g++.dg/tsan/aligned_vs_unaligned_race.C

2015-01-03 Thread Bernd Edlinger
Hi, the test case g++.dg/tsan/aligned_vs_unaligned_race.C still fails sporadically (around 1 out of 100 times). That is apparently a race condition in the tsan runtime itself. To make the test reproducible pass, I need to add a sleep(1) in one of the two threads. Tested really often with: make

Re: [PATCH] Fix sporadic failure in g++.dg/tsan/aligned_vs_unaligned_race.C

2015-01-03 Thread Mike Stump
On Jan 3, 2015, at 1:01 AM, Bernd Edlinger wrote: > the test case g++.dg/tsan/aligned_vs_unaligned_race.C > still fails sporadically (around 1 out of 100 times). > That is apparently a race condition in the tsan runtime itself. > To make the test reproducible pass, I need to add a sleep(1) > in on

Re: [PATCH] microblaze: microblaze.md: Use 'SI' instead of 'VOID' for operand 1 of 'call_value_intern'

2015-01-03 Thread Chen Gang S
Hello Maintainers: It is finished with qemu today, it spends 13 days, the result is below, please help check. With qemu: === gcc Summary === # of expected passes83439 # of unexpected failures175 # of unexpected successes 1 # of

Re: [Patch, Fortran + Testsuite] Fix coarray handling in modules

2015-01-03 Thread Dominique Dhumieres
Happy New Year to all. The test gfortran.dg/coarray/codimension_2.f90 fails on x86_64-apple-darwin14 with -m32 (see https://gcc.gnu.org/ml/gcc-testresults/2015-01/msg00185.html). The error is gfc /opt/gcc/work/gcc/testsuite/gfortran.dg/coarray/codimension_2.f90 /opt/gcc/work/gcc/testsuite/gfort

RE: [PATCH] Fix sporadic failure in g++.dg/tsan/aligned_vs_unaligned_race.C

2015-01-03 Thread Bernd Edlinger
On Sat, 3 Jan 2015 01:51:34, Mike Strump wrote: > > On Jan 3, 2015, at 1:01 AM, Bernd Edlinger wrote: >> the test case g++.dg/tsan/aligned_vs_unaligned_race.C >> still fails sporadically (around 1 out of 100 times). >> That is apparently a race condition in the tsan runtime itself. >> To make th

[Patch, Fortran, OOP] PR 63552: Type-bound procedures rejected as actual argument to dummy procedure

2015-01-03 Thread Janus Weil
Hi all, the attached patch allows type-bound procedures to be passed actual arguments to dummy procedures. When doing this, on has to transform the expression such that the corresponding procedure pointer from the vtab is used. The patch is regtested on x86_64-unknown-linux-gnu. Ok for trunk? Ch

Re: [PATCH, fortran, final] PR fortran/60255 Deferred character length

2015-01-03 Thread Janus Weil
Hi Andre, >> 1) There are still two TODO markers in the patch. It might be a good >> idea to take care of them before committing the patch. In particular >> for the first one (adding the initializer in gfc_build_class_symbol) >> it would be good to understand where those problems come from. > > I

[PING] Add refers_to_regno_p overload to simplify callers

2015-01-03 Thread Oleg Endo
https://gcc.gnu.org/ml/gcc-patches/2014-12/msg01730.html On Sun, 2014-12-21 at 23:02 +0100, Oleg Endo wrote: > Hi, > > It seems that quite some callers of refers_to_regno_p are interested in > testing a single register number only. The caller code can be > simplified by adding an overload for re

[PATCH] Enable experimental TSAN support for Ada

2015-01-03 Thread Bernd Edlinger
Hi, I was experimenting with enabling TSAN for Ada recently. I think this gives rather interesting results. The Instrumentation worked almost out of the box, we just have the problem that it is not gimple-OK to fold something like "& VIEW_CONVERT_EXPR(x)", and this happens in Ada all the time. B

Re: [PATCH, fortran, final] PR fortran/60255 Deferred character length

2015-01-03 Thread Andre Vehreschild
Hi Janus, thanks for the quick response. Please see my answers inline. On Sat, 3 Jan 2015 13:12:28 +0100 Janus Weil wrote: > > I started with the initializer for the _len component and ran into "Pointer > > assignment target is neither TARGET nor POINTER at %L" errors > > (expr.c:3714). I trac

Re: [PATCH 3/4] Add Visium support to gcc

2015-01-03 Thread Eric Botcazou
> I don't see anything particularly offensive. Actually it looks like a > reasonably clean RISC port. Thanks for the review. > I'm a little concerned about the MODES_TIEABLE_P definition, but if it's > working, I wouldn't mess with it. Could you elaborate? Do you find it too restrictive? > An

Re: [PATCH, fortran, final] PR fortran/60255 Deferred character length

2015-01-03 Thread Janus Weil
Hi Andre, >> >> For the >> >> second one (in gfc_conv_expr), I don't directly see how it's related >> >> to deferred char-len. Why is this change needed? >> > >> > That change is needed, because in some rare case where an associated >> > variable in a "select type ()" is used, then the type and f9

Re: PATCH: [5 Regression] r219037 caused FAIL: gcc.dg/pr44194-1.c

2015-01-03 Thread John David Anglin
On Wed, 31 Dec 2014, H.J. Lu wrote: > - /* Arguments for a sibling call that are pushed to memory are passed > - using the incoming argument pointer of the current function. These > - may or may not be frame related depending on the target. Since > - argument pointer related

[committed] gcc.dg/pr57233.c: Add -fno-common option on hppa*-*-hpux*

2015-01-03 Thread John David Anglin
The attached change fixes failure of gcc.dg/pr57233.c: on hppa-hpux due to limited common alignment. Dave -- John David Anglin dave.ang...@bell.net 2015-01-03 John David Anglin * gcc.dg/pr63914.c: Add -fno-common option on hppa*-*-hpux*. Index: gcc.dg/pr63914.c ==

Re: [Ada] implement C99 fmax semantics for floating-point 'Min/Max

2015-01-03 Thread Eric Botcazou
> NaNs are invalid values in Ada so the language doesn't specify how they > should be handled but GNAT nevertheless attempts to implement sensible > semantics for them. This patch extends this to the Min and Max attributes. > > Tested on x86_64-suse-linux, applied on the mainline. > > > 2014-12

[committed] Fix memory constraint issue on PA

2015-01-03 Thread John David Anglin
The attached change fixes a memory constraint issue found building the asterisk package on hppa-linux: http://buildd.debian-ports.org/status/fetch.php?pkg=asterisk&arch=hppa&ver=1%3A13.1.0%7Edfsg-1&stamp=1420088700 The problem was the `m' constraint allowed reload to substitute a register index

Re: PATCH: [5 Regression] r219037 caused FAIL: gcc.dg/pr44194-1.c

2015-01-03 Thread H.J. Lu
On Sat, Jan 3, 2015 at 9:35 AM, John David Anglin wrote: > On Wed, 31 Dec 2014, H.J. Lu wrote: > >> - /* Arguments for a sibling call that are pushed to memory are passed >> - using the incoming argument pointer of the current function. These >> - may or may not be frame related de

Re: PATCH: [5 Regression] r219037 caused FAIL: gcc.dg/pr44194-1.c

2015-01-03 Thread John David Anglin
On 2015-01-03, at 2:48 PM, H.J. Lu wrote: > On Sat, Jan 3, 2015 at 9:35 AM, John David Anglin > wrote: >> On Wed, 31 Dec 2014, H.J. Lu wrote: >> >>> - /* Arguments for a sibling call that are pushed to memory are passed >>> - using the incoming argument pointer of the current function.

Re: PATCH: [5 Regression] r219037 caused FAIL: gcc.dg/pr44194-1.c

2015-01-03 Thread H.J. Lu
On Sat, Jan 3, 2015 at 12:10 PM, John David Anglin wrote: > On 2015-01-03, at 2:48 PM, H.J. Lu wrote: > >> On Sat, Jan 3, 2015 at 9:35 AM, John David Anglin >> wrote: >>> On Wed, 31 Dec 2014, H.J. Lu wrote: >>> - /* Arguments for a sibling call that are pushed to memory are passed

Re: [Patch, Fortran + Testsuite] Fix coarray handling in modules

2015-01-03 Thread Tobias Burnus
Dominique Dhumieres wrote: The test gfortran.dg/coarray/codimension_2.f90 fails on x86_64-apple-darwin14 with -m32 (see https://gcc.gnu.org/ml/gcc-testresults/2015-01/msg00185.html). The error is [...] Yes, there seems to be something wrong. The module has: U _F.caf_token__gl

Re: PATCH: [5 Regression] r219037 caused FAIL: gcc.dg/pr44194-1.c

2015-01-03 Thread John David Anglin
On 2015-01-03, at 3:18 PM, H.J. Lu wrote: > On Sat, Jan 3, 2015 at 12:10 PM, John David Anglin > wrote: >> On 2015-01-03, at 2:48 PM, H.J. Lu wrote: >> >>> On Sat, Jan 3, 2015 at 9:35 AM, John David Anglin >>> wrote: On Wed, 31 Dec 2014, H.J. Lu wrote: > - /* Arguments for

[doc, committed] add/fix @opindex entries

2015-01-03 Thread Sandra Loosemore
This is another in my series of cleanups to the GCC user documentation. I noticed that some recently-added options documented in invoke.texi were missing @opindex entries, or had incorrect ones. I made a pass through the whole file to try to fix all the mistakes of this sort that I spotted --

Re: [PATCH, ada]: Use xasprintf instead of unchecked asprintf

2015-01-03 Thread Eric Botcazou
> 2014-12-31 Uros Bizjak > > * gcc-interface/misc.c (internal_error_function): Use xasprintf instead > of unchecked asprintf. > > Although almost trivial, this patch is *not* tested, so I'd kindly ask > someone to bootstrap and regresion test this patch. Sanity checked only, but that'

Re: [Patch, Fortran + Testsuite] Fix coarray handling in modules

2015-01-03 Thread Dominique d'Humières
From a quick test, with the patch I still see the error with -m32 /var/folders/8q/sh_swgz96r7f5vnn08f7fxr0gn/T//cc8Yz3Jr.s:18:non-relocatable subtraction expression, "__F.caf_token__global_coarrays_MOD_b" minus "L1$pb" /var/folders/8q/sh_swgz96r7f5vnn08f7fxr0gn/T//cc8Yz3Jr.s:18:symbol: "

Re: PATCH: [5 Regression] r219037 caused FAIL: gcc.dg/pr44194-1.c

2015-01-03 Thread H.J. Lu
On Sat, Jan 3, 2015 at 12:58 PM, John David Anglin wrote: > On 2015-01-03, at 3:18 PM, H.J. Lu wrote: > >> On Sat, Jan 3, 2015 at 12:10 PM, John David Anglin >> wrote: >>> On 2015-01-03, at 2:48 PM, H.J. Lu wrote: >>> On Sat, Jan 3, 2015 at 9:35 AM, John David Anglin wrote: > On W

Re: [Patch, Fortran, OOP] PR 63552: Type-bound procedures rejected as actual argument to dummy procedure

2015-01-03 Thread Tobias Burnus
Hi Janus, Janus Weil wrote: the attached patch allows type-bound procedures to be passed actual arguments to dummy procedures. When doing this, on has to transform the expression such that the corresponding procedure pointer from the vtab is used. ... + else if (sym->ts.type == BT_CLASS)

Re: [Patch, Fortran + Testsuite] Fix coarray handling in modules

2015-01-03 Thread Tobias Burnus
Dominique d'Humières wrote: From a quick test, with the patch I still see the error with -m32 It helps if one actually adds the decl. The following (still untested) should help. I also marked the token as nonaliasing (it really should!) and added for proc pointers the tree-public optimizatio

Re: [PATCH/TopLevel] Fix compiling libgo with a combined sources

2015-01-03 Thread Andrew Pinski
On Mon, Nov 24, 2014 at 1:32 PM, Jeff Law wrote: > On 11/22/14 21:20, Andrew Pinski wrote: >> >> Hi, >>The problem here is here is that OBJCOPY is not being set to the >> newly built objcopy when compiling libgo. This patch adds >> OBJCOPY_FOR_TARGET to the toplevel configure/Makefile so that

Re: [Patch, Fortran + Testsuite] Fix coarray handling in modules

2015-01-03 Thread Dominique d'Humières
Compilation with the new patch fails with ../../work/gcc/fortran/trans-decl.c: In function 'void gfc_build_qualified_array(tree, gfc_symbol*)': ../../work/gcc/fortran/trans-decl.c:855:25: error: 'cur_module' was not declared in this scope gfc_module_add_decl (cur_module, token); Dominique

[doc, committed] copy-edit -fsemantic-interposition documentation

2015-01-03 Thread Sandra Loosemore
I spotted some typos in the description of -fsemantic-interposition. This patch fixes them and also cleans up some awkward grammar. Committed under the obvious fix rule. -Sandra 2015-01-03 Sandra Loosemore gcc/ * doc/invoke.texi ([-fsemantic-interposition]): Fix typos and

[doc, committed] copy-edit documentation for -fisolate-erroneous-paths-*

2015-01-03 Thread Sandra Loosemore
This patch fixes a bunch of small problems in the descriptions of -fisolate-erroneous-paths-dereference and -fisolate-erroneous-paths-attribute: * "which"/"that" confusion * use American spelling of "behavior" vs British "behaviour" * most places in the manual use "null" or more rarely "@code{N

[doc, committed] clean up -fauto-profile documentation

2015-01-03 Thread Sandra Loosemore
I saw that the documentation for the new -fauto-profile option needed a lot of work -- it had formatting and markup problems, terminology problems (e.g., "linux" is not a proper name by GNU documentation standards), and content problems like failure to document the filename default. I removed