[DOC Patch] Attribute 'naked'

2014-06-17 Thread David Wohlferd
I don't have permissions to commit this patch, but I do have a release on file with the FSF. Problem description: The docs for the function attribute 'naked' are confusing and self-contradictory. Also, discussion on this thread https://gcc.gnu.org/ml/gcc/2014-05/msg00100.html has lead to chan

Re: [PATCH] Fix PR61335

2014-06-17 Thread Uros Bizjak
On Fri, Jun 6, 2014 at 10:07 AM, Uros Bizjak wrote: > On Fri, Jun 6, 2014 at 9:47 AM, Uros Bizjak wrote: > >>> 2014-05-28 Richard Biener >>> >>> PR tree-optimization/61335 >>> * tree-vrp.c (vrp_visit_phi_node): If the compare of old and >>> new range fails, drop to varying. >>> >>> * gfortran.

[PATCH] PR54555: Use strict_low_part for loading a constant only if it is cheaper

2014-06-17 Thread Andreas Schwab
Postreload may transform (set (REGX) (CONST_INT A)) ... (set (REGX) (CONST_INT B)) to (set (REGX) (CONST_INT A)) ... (set (STRICT_LOW_PART (REGX)) (CONST_INT B)), but it should do that only if the latter is cheaper. On m68k, a full word load of a small constant with moveq is cheaper than doing a b

Re: Regimplification enhancements 1/3

2014-06-17 Thread Richard Biener
On Mon, Jun 16, 2014 at 11:52 PM, Mike Stump wrote: > On Jun 16, 2014, at 10:49 AM, Bernd Schmidt wrote: >> >> There are two reasons why I can't do this in the frontends - one, Joseph has >> already rejected a C frontend patch, > > I’d like to think there is an acceptable way to get the right me

Re: fix math wrt volatile-bitfields vs C++ model

2014-06-17 Thread Richard Biener
On Tue, Jun 17, 2014 at 4:08 AM, DJ Delorie wrote: > >> Looks ok to me, but can you add a testcase please? > > I have a testcase, but if -flto the testcase doesn't include *any* > definition of the test function, just all the LTO data. Is this > normal? Without -ffat-lto-objects yes, this is nor

Re: [PATCH][genattrtab] Fix memory corruption, allocate enough memory for all bypassed reservations

2014-06-17 Thread Kyrill Tkachov
On 16/06/14 17:39, Jeff Law wrote: On 06/16/14 04:12, Kyrill Tkachov wrote: Doh, you're right. I did consider it but for some reason thought we might want to iterate over all of the bypasses anyway. Breaking out seems good. How about this? Tested on arm and aarch64 and confirmed with valgrind

Re: [PATCH, cprop] Check rtx_cost when propagating constant

2014-06-17 Thread Richard Biener
On Tue, Jun 17, 2014 at 4:11 AM, Zhenqiang Chen wrote: > Hi, > > For some large constant, ports like ARM, need one more instructions to > operate it. e.g > > #define MASK 0xfe00ff > void maskdata (int * data, int len) > { >int i = len; >for (; i > 0; i -= 2) > { > data[i] &= MASK

Re: Turn DECL_SECTION_NAME into string

2014-06-17 Thread Richard Biener
On Tue, Jun 17, 2014 at 8:40 AM, Thomas Schwinge wrote: > Hi! > > On Thu, 12 Jun 2014 06:33:25 +0200, Jan Hubicka wrote: >> this lenghtly patch makes the legwork to put section names out of tree >> representation. >> Originally they were STRING_CST. I ended up implementing on-side reference >>

[gomp4] Merge trunk r211693 (2014-06-16) into gomp-4_0-branch

2014-06-17 Thread Thomas Schwinge
Hi! In r211726, I have committed a merge from trunk r211693 (2014-06-16) into gomp-4_0-branch. The LTO regression that appeared with an earlier merge, , remains to be resolved: PASS: gcc.dg/lto/save-temps

[c++-concepts] Fix assertion failure with cp_maybe_constrained_type_specifier

2014-06-17 Thread Braden Obrzut
cp_maybe_constrained_type_specifier asserted that the decl passed in would be of type OVERLOAD, however a clean build of the compiler was broken since it could also be a BASELINK. I'm not entirely sure when this is the case, except that it seems to happen with class member templates as it also

[PATCH] Testcase for PR61012

2014-06-17 Thread Richard Biener
>From the new dup. Committed to trunk and branch. Richard. 2014-06-17 Richard Biener PR lto/61012 * gcc.dg/lto/pr61526_0.c: New testcase. * gcc.dg/lto/pr61526_1.c: Likewise. Index: gcc/testsuite/gcc.dg/lto/pr61526_0.c

[c++-concepts] Allow function parameters to be referenced in trailing requires clauses

2014-06-17 Thread Braden Obrzut
This patch allows function parameters to be referenced by trailing requires clauses. Typically this is used to refer to the type of an implicitly generated template. For example, the following should now be valid (where C is some previously defined concept): auto f1 (auto x) requires C ();

Commit: MSP430: Add NOP after DINT in hardware multiply patterns

2014-06-17 Thread Nick Clifton
Hi Guys, I am checking in the patch below to update the hardware multiply patterns for the MSP430 so that there is a NOP instruction after disabling interrupts with the DINT instruction. Timing issues mean that it is possible for the instruction following the DINT to be interrupted, so

[PATCH][match-and-simplify] Make gimple_fold_stmt_to_constant_1 dumping more useful

2014-06-17 Thread Richard Biener
Committed. Richard. 2014-06-17 Richard Biener * gimple-fold.c (gimple_fold_stmt_to_constant_1): Dump simplified expression. Index: gcc/gimple-fold.c === --- gcc/gimple-fold.c (revision 211452) +++ gcc/gimple-f

Re: [PATCH, cprop] Check rtx_cost when propagating constant

2014-06-17 Thread Zhenqiang Chen
On 17 June 2014 16:15, Richard Biener wrote: > On Tue, Jun 17, 2014 at 4:11 AM, Zhenqiang Chen > wrote: >> Hi, >> >> For some large constant, ports like ARM, need one more instructions to >> operate it. e.g >> >> #define MASK 0xfe00ff >> void maskdata (int * data, int len) >> { >>int i = len;

Re: [PATCH] Fix PR61335

2014-06-17 Thread Tobias Burnus
Uros Bizjak wrote: > Attached patch initializes problematic array to zero instead of > uninitialized value. > > 2014-06-17 Uros Bizjak > > * gfortran.dg/pr61335.f90 (cp_unit_create): Initialize > unit_id and kind_id to zero. > > Tested on alphaev68-linux-gnu and x86_64-linux-gnu. > OK fo

RE: [PATCH,MIPS] Remove unused code relating to reloading fcc

2014-06-17 Thread Matthew Fortune
Richard Sandiford writes: > Matthew Fortune writes: > > This is a small clean-up patch to remove code relating to reloading or > moving > > mips fcc registers. At some point in the past these registers were > allocated > > as part of register allocation but they are now statically allocated in >

Bug 61407 - Build errors on latest OS X 10.10 Yosemite with Xcode 6 on GCC 4.8.3

2014-06-17 Thread Илья Михальцов
Hello. This patch fixes gcc build problems on the latest OS X 10.10 SDK beta (see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61407) fixincludes/ChangeLog * inclhack.def (darwin14_has_feature): New fix * fixincl.x: Regenerate * tests/base/Availability.h: Added gcc/Chang

Re: [PATCH,MIPS] Remove unused code relating to reloading fcc

2014-06-17 Thread Richard Sandiford
Matthew Fortune writes: > Richard Sandiford writes: >> Matthew Fortune writes: >> > This is a small clean-up patch to remove code relating to reloading or >> moving >> > mips fcc registers. At some point in the past these registers were >> allocated >> > as part of register allocation but they a

Re: fix math wrt volatile-bitfields vs C++ model

2014-06-17 Thread Bernd Edlinger
Hi, On Tue, 17 Jun 2014 10:08:33, Richard Biener wrote: > On Tue, Jun 17, 2014 at 4:08 AM, DJ Delorie wrote: >> >>> Looks ok to me, but can you add a testcase please? >> >> I have a testcase, but if -flto the testcase doesn't include *any* >> definition of the test function, just all the LTO dat

[PATCH] Simplify collect_switch_conv_info

2014-06-17 Thread Richard Biener
This simplifies (and for me robustifies) finding of the final_bb. The current code is somewhat odd in that it requires at least one non-forwarder successor of a switch to transform. The following patch makes us simply pick the candidate from a random edge (I chose the default edge) using either t

[PATCH] Use vec<>::qsort where possible

2014-06-17 Thread Richard Biener
Just spotted these. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2014-06-17 Richard Biener * genopinit.c (main): Use vec<>::qsort method. * tree-ssa-loop-niter.c (discover_iteration_bound_by_body_walk): Likewise. * tree-vect-data-re

Re: Make ipa-ref somewhat less stupid

2014-06-17 Thread Martin Liška
On 06/16/2014 10:01 AM, Jan Hubicka wrote: On 06/10/2014 08:34 AM, Jan Hubicka wrote: Hi, ipa-reference is somewhat stupid and builds its data sets for all variables including addressable and public one just to prune them out after all bitmaps are constructed. This used to make sense when the

Re: [PATCH, PR52252] Alternative way of vectorization for load groups of size 2 and 3.

2014-06-17 Thread Evgeny Stupachenko
Are i386 changes ok? Patches with corresponding changes and new tests are attached. Thanks, Evgeny On Thu, Jun 12, 2014 at 12:14 PM, Richard Biener wrote: > On Thu, Jun 12, 2014 at 6:04 AM, Evgeny Stupachenko > wrote: >> Testing finished. No new regressions. >> Is the following patch ok? > > +

Re: [PATCH, PR52252] Alternative way of vectorization for load groups of size 2 and 3.

2014-06-17 Thread Uros Bizjak
On Tue, Jun 17, 2014 at 2:33 PM, Evgeny Stupachenko wrote: > Are i386 changes ok? > Patches with corresponding changes and new tests are attached. Please remove all target selectors from dg-options and dg-final testcase directives, they are not needed inside gcc.dg/i386 directory. The patch is

[PATCH][RFC] Add phiopt in early opts (and add -fssa-phiopt option)

2014-06-17 Thread Richard Biener
First this adds a controlling option to the phiopt pass (-fssa-phiopt). Second, this moves the first phiopt pass from the main optimization pipeline into early opts (before merge-phi which confuses phiopt but after dce which will help it). ISTR that adding an early phiopt pass was wanted to perfo

Re: [PATCH][RFC] Add phiopt in early opts (and add -fssa-phiopt option)

2014-06-17 Thread pinskia
> On Jun 17, 2014, at 6:07 AM, Richard Biener wrote: > > > First this adds a controlling option to the phiopt pass (-fssa-phiopt). > Second, this moves the first phiopt pass from the main optimization > pipeline into early opts (before merge-phi which confuses phiopt > but after dce which will

Re: [PATCH][RFC] Add phiopt in early opts (and add -fssa-phiopt option)

2014-06-17 Thread Richard Biener
On Tue, 17 Jun 2014, pins...@gmail.com wrote: > > > > On Jun 17, 2014, at 6:07 AM, Richard Biener wrote: > > > > > > First this adds a controlling option to the phiopt pass (-fssa-phiopt). > > Second, this moves the first phiopt pass from the main optimization > > pipeline into early opts (be

Re: [PATCH, Pointer Bounds Checker 28/x] IPA CP

2014-06-17 Thread Martin Jambor
Hi, On Wed, Jun 11, 2014 at 05:47:36PM +0400, Ilya Enkovich wrote: > > Here is fixed verison. I'm fine with the ipa-cp hunks but I cannot approve them, Honza is the right person to ask. Thanks, Martin > > Thanks, > Ilya > -- > gcc/ > > 2014-06-11 Ilya Enkovich > > * cgraph.h (cgra

Compile gcc.target/i386/fuse-caller-save.c with -fomit-frame-pointer (PR target/61533)

2014-06-17 Thread Rainer Orth
gcc.target/i386/fuse-caller-save.c currently FAILs on Solaris/x86 with gas and -m64: FAIL: gcc.target/i386/fuse-caller-save.c scan-assembler-not .cfi_def_cfa_offset FAIL: gcc.target/i386/fuse-caller-save.c scan-assembler-not .cfi_offset Fixed as follows as suggested and pre-approved by Uros in th

Re: Bug 61407 - Build errors on latest OS X 10.10 Yosemite with Xcode 6 on GCC 4.8.3

2014-06-17 Thread Bernhard Reutner-Fischer
On 17 June 2014 13:10:07 Илья Михальцов wrote: index 892ba35..39f795f 100644 --- a/gcc/config/darwin-c.c +++ b/gcc/config/darwin-c.c @@ -572,20 +572,31 @@ find_subframework_header (cpp_reader *pfile, const char *header, cpp_dir **dirp) /* Return the value of darwin_macosx_version_min suitab

Re: Another AIX Bootstrap failure

2014-06-17 Thread David Edelsohn
On Mon, Jun 16, 2014 at 11:44 PM, Jan Hubicka wrote: >> The linker is not seeing the local definition of >> ._ZN14__gnu_parallel9_SettingsC1Ev. libstdc++ is built with >> Linux-like semantics, so it allows symbols to be overridden. AIX calls >> everything through the PLT. But the real definition

Re: Regimplification enhancements 3/3

2014-06-17 Thread Martin Jambor
On Mon, Jun 16, 2014 at 01:38:49PM +0200, Richard Biener wrote: > On Mon, Jun 16, 2014 at 12:57 PM, Bernd Schmidt > wrote: > > There's code in regimplification that makes us use an extra temporary > > when we encounter a call returning a non-BLKmode structure. This seems > > somewhat inefficient

Re: [PATCH] [ARM] Post-indexed addressing for NEON memory access

2014-06-17 Thread Charles Baylis
On 5 June 2014 07:27, Ramana Radhakrishnan wrote: > On Mon, Jun 2, 2014 at 5:47 PM, Charles Baylis > wrote: >> This patch adds support for post-indexed addressing for NEON structure >> memory accesses. >> >> For example VLD1.8 {d0}, [r0], r1 >> >> >> Bootstrapped and checked on arm-unknown-gnueab

Re: [PATCH, PR52252] Alternative way of vectorization for load groups of size 2 and 3.

2014-06-17 Thread Richard Henderson
On 06/17/2014 05:33 AM, Evgeny Stupachenko wrote: > + 1st vec: 0 1 2 3 4 5 6 7 > + 2nd vec: 8 9 10 11 12 13 14 15 > + 3rd vec: 16 17 18 19 20 21 22 23 > + > + The output sequence should be: > + > + 1st vec: 0 3 6 9 12 15 18 21 > + 2nd vec: 1 4 7 10 13 16 19 22 > + 3rd

[PATCH GCC 2/2]Add 'force-dwarf-lexical-blocks' command line option - extend to C++

2014-06-17 Thread Herman, Andrei
Hi, This is the third (and final) patch which extends the original change proposal, submitted on June 1, and titled "Add 'force-dwarf-lexical-blocks' command line option". This patch extends the proposed functionality to C++. Attached are the proposed ChangeLog additions (for this patch only

Re: Another AIX Bootstrap failure

2014-06-17 Thread Jan Hubicka
> > To avoid using PLT and GOT when the unit refers to the symbol and we know > > that interposition does not matter. > > I am not certain if the linker is creating the PLT stub code because > it wants to allow interpolation or because it cannot see a definition > of the function and wants to allo

Re: [Patch] PR55189 enable -Wreturn-type by default

2014-06-17 Thread Sylvestre Ledru
On 05/06/2014 20:01, Joseph S. Myers wrote: > >> Initially, I implemented -Wmissing-return to manage this case ( >> https://gcc.gnu.org/ml/gcc-patches/2014-01/msg00820.html ) but Jason >> suggested to remove that: >> https://gcc.gnu.org/ml/gcc-patches/2014-01/msg01033.html >> (I don't have a strong

Re: Another AIX Bootstrap failure

2014-06-17 Thread David Edelsohn
On Tue, Jun 17, 2014 at 12:50 PM, Jan Hubicka wrote: >> > To avoid using PLT and GOT when the unit refers to the symbol and we know >> > that interposition does not matter. >> >> I am not certain if the linker is creating the PLT stub code because >> it wants to allow interpolation or because it c

Re: [Patch] PR55189 enable -Wreturn-type by default

2014-06-17 Thread Joseph S. Myers
On Tue, 17 Jun 2014, Sylvestre Ledru wrote: > On 05/06/2014 20:01, Joseph S. Myers wrote: > > > >> Initially, I implemented -Wmissing-return to manage this case ( > >> https://gcc.gnu.org/ml/gcc-patches/2014-01/msg00820.html ) but Jason > >> suggested to remove that: > >> https://gcc.gnu.org/ml/gc

Re: [PATCH, PR52252] Alternative way of vectorization for load groups of size 2 and 3.

2014-06-17 Thread Evgeny Stupachenko
While developing I've tried the following scheme: First step is 3 shuffles (as initially): A1 = (0 3 6) (1 4 7) (2 5) A2 = (8 11 14) (9 12 15) (10 13) A3 = (16 19 22) (17 20 23) (18 21) R1 = blend [ blend [A1 A2], A3] = (0 3 6) (9 12 15) (18 21) B2 = blend [A1, A2] = (0 3 6) (1 4 7) (10 13) R

Re: [Patch] PR55189 enable -Wreturn-type by default

2014-06-17 Thread Sylvestre Ledru
On 17/06/2014 19:15, Joseph S. Myers wrote: > On Tue, 17 Jun 2014, Sylvestre Ledru wrote: > >> On 05/06/2014 20:01, Joseph S. Myers wrote: Initially, I implemented -Wmissing-return to manage this case ( https://gcc.gnu.org/ml/gcc-patches/2014-01/msg00820.html ) but Jason suggested to

Re: [Patch] PR55189 enable -Wreturn-type by default

2014-06-17 Thread Joseph S. Myers
On Tue, 17 Jun 2014, Sylvestre Ledru wrote: > OK. I will do that. > We should test the following: > * default => run just -Wreturn-type > * -Wreturn-type => Run both > * -Wreturn-type + -Wmissing-return => Run both > * -Wno-return-type + -Wmissing-return => Run just the second one > * -Wno-return-

Re: [PATCH] C++ thunk section names

2014-06-17 Thread Sriraman Tallam
Ping. On Mon, Jun 9, 2014 at 3:54 PM, Sriraman Tallam wrote: > Ping. > > On Mon, May 19, 2014 at 11:25 AM, Sriraman Tallam wrote: >> Ping. >> >> On Thu, Apr 17, 2014 at 10:41 AM, Sriraman Tallam >> wrote: >>> Ping. >>> >>> On Wed, Feb 5, 2014 at 4:31 PM, Sriraman Tallam wrote: Hi, >

Re: [PATCH][RFC] Add phiopt in early opts (and add -fssa-phiopt option)

2014-06-17 Thread Jeff Law
On 06/17/14 07:07, Richard Biener wrote: I felt that -ftree-XXX is bad naming so I went for -fssa-XXX even if that is now inconsistent. Any optinion here? For RTL we simply have unsuffixed names so shall we instead go for -fphiopt? PHI implies SSA anyway and 'SSA' or 'RTL' is an implementatio

Re: Fwd: [RFC][gomp4] Offloading patches (2/3): Add tables generation

2014-06-17 Thread Ilya Verbin
Hello Bernd, On 28 Feb 17:21, Bernd Schmidt wrote: > For your use case, I'd imagine the offload compiler would be built > relatively normally as a full build with > "--enable-as-accelerator-for=x86_64-linux", which would install it > into locations where the host will eventually be able to find it

Re: [PATCH] PR54555: Use strict_low_part for loading a constant only if it is cheaper

2014-06-17 Thread Jeff Law
On 06/17/14 01:47, Andreas Schwab wrote: Postreload may transform (set (REGX) (CONST_INT A)) ... (set (REGX) (CONST_INT B)) to (set (REGX) (CONST_INT A)) ... (set (STRICT_LOW_PART (REGX)) (CONST_INT B)), but it should do that only if the latter is cheaper. On m68k, a full word load of a small co

Re: [PATCH, Cilk+, PR57541] Additional fix for issues witn array notations

2014-06-17 Thread Jeff Law
On 06/16/14 14:13, Zamyatin, Igor wrote: Hi All! The patch fixes ICE in array notation for the cases of incorrect arguments of Cilk+ builtins and undeclared initial index. Is it ok for trunk and 4.9? Thanks, Igor diff --git a/gcc/c/ChangeLog b/gcc/c/ChangeLog index 54d0de7..56e1b0b 100644 --

Re: [PATCH, PR 61211] Fix a bug in clone_of_p verification

2014-06-17 Thread Martin Jambor
Ping. Thanks, Martin On Sat, May 31, 2014 at 12:46:03AM +0200, Martin Jambor wrote: > Hi, > > after a clone is materialized, its clone_of field is cleared which in > PR 61211 leads to a failure in the skipped_thunk path in clone_of_p in > cgraph.c, which then leads to a false positive verifica

Re: [patch libatomic]: Add basic support for mingw targets

2014-06-17 Thread Jeff Law
On 06/16/14 07:20, Kai Tietz wrote: Hello, this patch adds basic support for libatomic for mingw targets using win32 and for mingw targets using posix threading model. The win32 implemenation might need for initialization of mutexes a critical section. If issue occures we can still add that.

Re: Fwd: [RFC][gomp4] Offloading patches (2/3): Add tables generation

2014-06-17 Thread Bernd Schmidt
On 06/17/2014 08:20 PM, Ilya Verbin wrote: Hello Bernd, On 28 Feb 17:21, Bernd Schmidt wrote: For your use case, I'd imagine the offload compiler would be built relatively normally as a full build with "--enable-as-accelerator-for=x86_64-linux", which would install it into locations where the h

Re: [patch i386]: Combine memory and indirect jump

2014-06-17 Thread Jeff Law
On 06/13/14 10:59, Kai Tietz wrote: 2014-06-13 17:58 GMT+02:00 Jeff Law : On 06/13/14 09:56, Richard Henderson wrote: On 06/13/2014 08:36 AM, Jeff Law wrote: So you may have answered this already, but why can't this be a combiner pattern? Until pass_duplicate_computed_gotos, we (intention

Re: [Patch, Fortran] Add coarray communication support to the trunk (coindex variables)

2014-06-17 Thread Paul Richard Thomas
Dear Tobias and Alessandro, Well what can I say? The patch is something of a tour de force! Sandro, questo è assolutamente meraviglioso. Molte grazie da tutti noi. I have done nothing to check the functionality of the patch. However, I have checked the conformance with coding standards and that

Re: [patch libatomic]: Add basic support for mingw targets

2014-06-17 Thread Kai Tietz
2014-06-17 21:16 GMT+02:00 Jeff Law : > On 06/16/14 07:20, Kai Tietz wrote: >> >> Hello, >> >> this patch adds basic support for libatomic for mingw targets using >> win32 and for mingw targets using posix threading model. >> >> The win32 implemenation might need for initialization of mutexes a >>

[PATCH, rs6000] Remove XFAIL from default_format_denormal_2.f90 for PowerPC on Linux

2014-06-17 Thread William J. Schmidt
Hi, The testcase gfortran.dg/default_format_denormal_2.f90 has been reporting XPASS since 4.8 on the powerpc*-unknown-linux-gnu platforms. This patch removes the XFAIL for powerpc*-*-linux-* from the test. I believe this pattern doesn't match any other platforms, but please let me know if I shoul

[Fortran-dev] Merge from the trunk

2014-06-17 Thread Tobias Burnus
Dear all, I have now updated the "fortran-dev" branch to trunk version Rev. 211744. Committed as Rev. 211745. Tobias

Re: [PATCH, PR 61160] Artificial thunks need combined_args_to_skip

2014-06-17 Thread Martin Jambor
Hi, Ping. Thanks, Martin On Sat, May 31, 2014 at 01:08:31AM +0200, Martin Jambor wrote: > Hi, > > the second issue in PR 61160 is that because artificial thunks > (produced by duplicate_thunk_for_node) do not have > combined_args_to_skip, calls to them do not get actual arguments > removed, w

Re: [PATCH 1/5] New Identical Code Folding IPA pass

2014-06-17 Thread Jeff Law
On 06/13/14 04:24, mliska wrote: You may ask, why the GNU GCC does need such a new optimization. The compiler, having simply better knowledge of a compiled source file, is capable of reaching better results, especially if Link-Time optimization is enabled. Apart from that, GCC implementation add

Re: [PATCH 4/5] Existing tests fix

2014-06-17 Thread Jeff Law
On 06/13/14 04:48, mliska wrote: Hi, many tests rely on a precise number of scanned functions in a dump file. If IPA ICF decides to merge some function and(or) read-only variables, counts do not match. Martin Changelog: 2014-06-13 Martin Liska Honza Hubicka * c-c

Re: [PATCH 5/5] New tests introduction

2014-06-17 Thread Jeff Law
On 06/13/14 05:16, mliska wrote: Hi, this is a new collection of tests for IPA ICF pass. Martin Changelog: 2014-06-13 Martin Liska Honza Hubicka * gcc/testsuite/g++.dg/ipa/ipa-se-1.C: New test. * gcc/testsuite/g++.dg/ipa/ipa-se-2.C: Likewise. * gcc

Re: [PATCH 2/5] Existing call graph infrastructure enhancement

2014-06-17 Thread Jeff Law
On 06/13/14 04:26, mliska wrote: Hi, this small patch prepares remaining needed infrastructure for the new pass. Changelog: 2014-06-13 Martin Liska Honza Hubicka * ipa-utils.h (polymorphic_type_binfo_p): Function marked external instead of static.

Re: [PATCH 1/5] New Identical Code Folding IPA pass

2014-06-17 Thread Paolo Carlini
Hi, On 13/06/14 12:24, mliska wrote: The optimization is inspired by Microsoft /OPT:ICF optimization (http://msdn.microsoft.com/en-us/library/bxwfs976.aspx) that merges COMDAT sections with each function reside in a separate section. In terms of C++ testcases, I'm wondering if you already d

Re: [patch libatomic]: Add basic support for mingw targets

2014-06-17 Thread Jeff Law
On 06/17/14 13:31, Kai Tietz wrote: 2014-06-17 21:16 GMT+02:00 Jeff Law : On 06/16/14 07:20, Kai Tietz wrote: Hello, this patch adds basic support for libatomic for mingw targets using win32 and for mingw targets using posix threading model. The win32 implemenation might need for initializat

Re: [PATCH 1/5] New Identical Code Folding IPA pass

2014-06-17 Thread David Malcolm
On Fri, 2014-06-13 at 12:24 +0200, mliska wrote: [...snip...] > Statistics about the pass: > Inkscape: 11.95 MB -> 11.44 MB (-4.27%) > Firefox: 70.12 MB -> 70.12 MB (-3.07%) FWIW, you wrote 70.12 MB here for both before and after for Firefox, but give a -3.07% change, which seems like a typo

Re: [PATCH, Pointer Bounds Checker 28/x] IPA CP

2014-06-17 Thread Jeff Law
On 06/17/14 07:41, Martin Jambor wrote: Hi, On Wed, Jun 11, 2014 at 05:47:36PM +0400, Ilya Enkovich wrote: Here is fixed verison. I'm fine with the ipa-cp hunks but I cannot approve them, Honza is the right person to ask. I'll step in and say these bits are fine :-) Thanks for the reviews

Re: [PATCH][genattrtab] Fix memory corruption, allocate enough memory for all bypassed reservations

2014-06-17 Thread Jeff Law
On 06/17/14 02:12, Kyrill Tkachov wrote: On 16/06/14 17:39, Jeff Law wrote: On 06/16/14 04:12, Kyrill Tkachov wrote: Doh, you're right. I did consider it but for some reason thought we might want to iterate over all of the bypasses anyway. Breaking out seems good. How about this? Tested on a

Re: [PING][PATCH, trunk, 4.9, 4.8] Fix PR57653, filename information discarded when using -imacros

2014-06-17 Thread Jeff Law
On 06/11/14 15:15, Peter Bergner wrote: I'd like to ping the following patch that fixes PR57653. This did bootstrap and regtest with no regressions on powerpc64-linux. https://gcc.gnu.org/ml/gcc-patches/2014-04/msg01571.html Is this ok for trunk, 4.9 and 4.8? Whee, fun. So this led me t

Re: [patch i386]: Combine memory and indirect jump

2014-06-17 Thread Kai Tietz
2014-06-17 21:26 GMT+02:00 Jeff Law : > On 06/13/14 10:59, Kai Tietz wrote: >> >> 2014-06-13 17:58 GMT+02:00 Jeff Law : >>> >>> On 06/13/14 09:56, Richard Henderson wrote: On 06/13/2014 08:36 AM, Jeff Law wrote: > > > So you may have answered this already, but why can't t

Re: [patch] improve sloc assignment on bind_expr entry/exit code

2014-06-17 Thread Jeff Law
On 06/11/14 09:02, Olivier Hainque wrote: Hello, For blocks requiring it, the gimplifier generates stack pointer save/restore operations on entry/exit, per: gimplify_bind_expr (...) if (gimplify_ctxp->save_stack) { gimple stack_restore; /* Save stack on entry and resto

Re: [PATCH, rs6000] Remove XFAIL from default_format_denormal_2.f90 for PowerPC on Linux

2014-06-17 Thread Rainer Orth
"William J. Schmidt" writes: > Index: gcc/testsuite/gfortran.dg/default_format_denormal_2.f90 > === > --- gcc/testsuite/gfortran.dg/default_format_denormal_2.f90 (revision > 211741) > +++ gcc/testsuite/gfortran.dg/default_format_d

Re: [PATCH 4/5] Existing tests fix

2014-06-17 Thread Rainer Orth
Jeff Law writes: > On 06/13/14 04:48, mliska wrote: >> Hi, >>many tests rely on a precise number of scanned functions in a dump file. >> If IPA ICF decides to merge some function and(or) read-only variables, >> counts do not match. >> >> Martin >> >> Changelog: >> >> 2014-06-13 Martin Lisk

Re: [PATCH, Pointer Bounds Checker 29/x] Debug info

2014-06-17 Thread Jeff Law
On 06/11/14 02:50, Ilya Enkovich wrote: Hi, This patch skips all bounds during debug info generation. Bootstrapped and tested on linux-x86_64. Thanks, Ilya -- gcc/ 2014-06-11 Ilya Enkovich * dbxout.c (dbxout_type): Ignore POINTER_BOUNDS_TYPE. * dwarf2out.c (gen_subprogram_

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-06-17 Thread Jeff Law
On 06/12/14 08:34, Christian Bruel wrote: On 06/11/2014 02:00 PM, Christian Bruel wrote: >On 06/11/2014 06:17 AM, Joern Rennecke wrote: Joern, is this new target macro interface OK with you ? >>Yes, this interface should allow me to do switches between rounding >>and truncating >>floating-

Re: Bug 61407 - Build errors on latest OS X 10.10 Yosemite with Xcode 6 on GCC 4.8.3

2014-06-17 Thread Mike Stump
On Jun 17, 2014, at 4:09 AM, Илья Михальцов wrote: > This patch fixes gcc build problems on the latest OS X 10.10 SDK beta (see > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61407) fix include hack to add: > +#ifndef __has_feature > +#define __has_feature(x) 0 > +#endif So, I’d like to bring

Re: [PATCH, loop2_invariant] Pre-check invariants

2014-06-17 Thread Jeff Law
On 06/11/14 03:35, Zhenqiang Chen wrote: Thanks for the comments. df_live seams redundant. With flag_ira_loop_pressure, the pass will call df_analyze () at the beginning, which can make sure all the DF info are correct. Can we guarantee all DF_... correct without df_analyze ()? They should be

Re: [PATCH, i386, Pointer Bounds Checker 17/x] Pointer bounds constants support

2014-06-17 Thread Jeff Law
On 06/06/14 03:11, Ilya Enkovich wrote: 2014-06-04 10:58 GMT+04:00 Jeff Law : On 06/02/14 04:25, Ilya Enkovich wrote: Hi, This patch adds support for pointer bounds constants to be used as DECL_INITIAL for constant bounds (like zero bounds). Bootstrapped and tested on linux-x86_64. Thanks,

Re: [PATCH, loop2_invariant, 1/2] Check only one register class

2014-06-17 Thread Jeff Law
On 06/11/14 04:05, Zhenqiang Chen wrote: On 10 June 2014 19:06, Steven Bosscher wrote: On Tue, Jun 10, 2014 at 11:22 AM, Zhenqiang Chen wrote: Hi, For loop2-invariant pass, when flag_ira_loop_pressure is enabled, function gain_for_invariant checks the pressures of all register classes. This d

Re: [PATCH] Fortran OpenMP 4.0 target support

2014-06-17 Thread Tobias Burnus
Jakub Jelinek wrote: This patch adds the target directives. Tested both normally plus with target.c/splay-tree.c from gomp-4_0-branch@203409 plus the attached patch against target.c to implement the new to_pset map kind (5) and allow handling of NULL. That patch will need to be forward ported to

Re: [PATCH] Fortran OpenMP 4.0 target support

2014-06-17 Thread Jakub Jelinek
On Tue, Jun 17, 2014 at 11:59:22PM +0200, Tobias Burnus wrote: > >This patch adds the target directives. > >Tested both normally plus with target.c/splay-tree.c from > >gomp-4_0-branch@203409 plus the attached patch against > >target.c to implement the new to_pset map kind (5) and > >allow handling

Re: [Patch, microblaze]: Added load and store reverse patterns

2014-06-17 Thread Michael Eager
On 02/10/14 17:55, Michael Eager wrote: On 11/25/13 23:54, David Holsgrove wrote: Added the lwr/swr instructions pattern. lwr and swr instructions will load/store the data with opposite endianness. Changelog 2013-11-26 Nagaraju Mekala * gcc/config/microblaze/microblaze.md: Add movsi4_rev

Re: [PATCH, ARM] MI-thunk fix for TARGET_THUMB1_ONLY

2014-06-17 Thread Ramana Radhakrishnan
On Sun, Jun 8, 2014 at 12:27 PM, Chung-Lin Tang wrote: > Hi Richard, Ramana, > > Attached is a small fix for resolving a g++.old-deja/g++.jason/thunk2.C > regression we found under a TARGET_THUMB1_ONLY multilib (-mthumb > -march=armv6-m to be exact). Basically under those conditions, the thunk > i

Re: [PATCH, PR61219]: Fix sNaN handling in ARM float to double conversion

2014-06-17 Thread Ramana Radhakrishnan
On Sun, May 18, 2014 at 10:23 PM, Aurelien Jarno wrote: > On ARM soft-float, the float to double conversion doesn't convert a sNaN > to qNaN as the IEEE Std 754 standard mandates: > > "Under default exception handling, any operation signaling an invalid > operation exception and for which a floati

Re: [RFC ARM] Error if overriding --with-tune by --with-cpu

2014-06-17 Thread Ramana Radhakrishnan
On Fri, May 30, 2014 at 5:34 PM, James Greenhalgh wrote: > > Hi, > > We error in the case where both --with-tune and --with-cpu are specified at > configure time. In this case, we cannot distinguish this situation from the > situation where --with-tune was specified at configure time and -mcpu was

[PATCH, rs6000] Fix PR61542 - V4SF vector extract for little endian

2014-06-17 Thread BIll Schmidt
Hi, As described in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61542, a new test case (gcc.dg/vect/vect-nop-move.c) was added in 4.9. This exposes a bug on PowerPC little endian for extracting an element from a V4SF value that goes back to 4.8. The following patch fixes the problem. Tested on

Re: [PATCH][ARM] FAIL: gcc.target/arm/pr58041.c scan-assembler ldrb

2014-06-17 Thread Ramana Radhakrishnan
On Fri, May 30, 2014 at 12:19 AM, Maciej W. Rozycki wrote: > On Wed, 28 May 2014, Richard Earnshaw wrote: > >> Ah, light dawns (maybe). >> >> I guess the problems stem from the attempts to combine Neon with ARMv5. >> Neon shouldn't be used with anything prior to ARMv7, since that's the >> earlies

Re: [PATCH] [ARM] [RFC] Fix longstanding push_minipool_fix ICE (PR49423, lp1296601)

2014-06-17 Thread Ramana Radhakrishnan
On Wed, Apr 2, 2014 at 2:29 PM, Charles Baylis wrote: > Hi > > This patch fixes the push_minipool_fix ICE, which occurs when the ARM > backend encounters a zero/sign extending load from a constant pool. > > I don't have a current test case for trunk, lp1296601 has a test case > which affects the l

C++ PATCH for c++/60605 (local function and default template arg)

2014-06-17 Thread Jason Merrill
The exception for local declarations in check_default_tmpl_args needs to handle DECL_LOCAL_FUNCTION_P, too. Tested x86_64-pc-linux-gnu, applying to 4.8, 4.9, trunk. commit 424c657e1213126dc5d2a7231abac05e16713286 Author: Jason Merrill Date: Tue Jun 17 18:43:57 2014 +0200 PR c++/60605

[PATCH] PR61517: fix stmt replacement in bswap pass

2014-06-17 Thread Thomas Preud'homme
Hi everybody, Thanks to a comment from Richard Biener, the bswap pass take care to not perform its optimization is memory is modified between the load of the original expression. However, when it replaces these statements by a single load, it does so in the gimple statement that computes the fi

Re: [PATCH, loop2_invariant, 1/2] Check only one register class

2014-06-17 Thread Zhenqiang Chen
On 18 June 2014 05:49, Jeff Law wrote: > On 06/11/14 04:05, Zhenqiang Chen wrote: >> >> On 10 June 2014 19:06, Steven Bosscher wrote: >>> >>> On Tue, Jun 10, 2014 at 11:22 AM, Zhenqiang Chen wrote: Hi, For loop2-invariant pass, when flag_ira_loop_pressure is enabled, func

RE: [PATCH] Fix PR61306: improve handling of sign and cast in bswap

2014-06-17 Thread Thomas Preud'homme
> From: Richard Biener [mailto:richard.guent...@gmail.com] > Sent: Wednesday, June 11, 2014 4:32 PM > > > > > > Is this OK for trunk? Does this bug qualify for a backport patch to > > 4.8 and 4.9 branches? > > This is ok for trunk and also for backporting (after a short while to > see if there is

[PATCH, aarch64] Fix 61545

2014-06-17 Thread Richard Henderson
Trivial fix for missing clobber of the flags over the tlsdesc call. Ok for all branches? r~ * config/aarch64/aarch64.md (tlsdesc_small_): Clobber CC_REGNUM. diff --git a/gcc/config/aarch64/aarch64.md b/gcc/config/aarch64/aarch64.md index a4d8887..1ee2cae 100644 --- a/gcc/config/aarch64

Re: [PATCH][PING] Fix for PR 61422

2014-06-17 Thread Yury Gribov
Have already been done in r211699. Does it work for you? Adding a test would still be useful. -Y

[Patch, Fortran, committed] PR61126 – fix wextra_1.f regression

2014-06-17 Thread Tobias Burnus
Committed as Rev. 211766. See PR comments 10, 23 and 24 for the patch and the background. Thanks to Manuel and Dominque for the patch! Tobias 2014-06-18 Manuel López-Ibáñez PR fortran/61126 * options.c (gfc_handle_option): Remove call to handle_generated_option. 2014-06-18 Dominique

Re: [Patch, Fortran, committed] PR61126 – fix wextra_1.f regression

2014-06-17 Thread Tobias Burnus
Tobias Burnus wrote: Committed as Rev. 211766. See PR comments 10, 23 and 24 for the patch and the background. Thanks to Manuel and Dominque for the patch! And as follow up, I have committed the attached documentation patch. I think it is sufficient, even though it does not explicitly state th

Re: [PATCH, loop2_invariant, 2/2] Change heuristics for identical invariants

2014-06-17 Thread Zhenqiang Chen
On 10 June 2014 19:16, Steven Bosscher wrote: > On Tue, Jun 10, 2014 at 11:23 AM, Zhenqiang Chen wrote: >> * loop-invariant.c (struct invariant): Add a new member: eqno; >> (find_identical_invariants): Update eqno; >> (create_new_invariant): Init eqno; >> (get_inv_c