Re: [PATCH 8/8] Add a common .md file and define standard constraints there

2014-06-14 Thread Richard Sandiford
Steve Ellcey writes: > Richard, > > Something in these constraint patches broke my mips16 build (I cannot > build glibc in mips16 mode). I have cut down a test case and verified > that the problem started with this checkin: > > 2014-06-11 Richard Sandiford > > * common.md: New file. >

Re: RFA: speeding up dg-extract-results.sh

2014-06-14 Thread Richard Sandiford
Bernd Schmidt writes: > On 05/25/2014 11:35 AM, Richard Sandiford wrote: >> Bernd Schmidt writes: >>> On 02/13/2014 10:18 AM, Richard Sandiford wrote: contrib/ * dg-extract-results.py: New file. * dg-extract-results.sh: Use it if the environment seems suitable. >>> >>> I'm no

Re: [PATCH 8/8] Add a common .md file and define standard constraints there

2014-06-14 Thread Richard Sandiford
Segher Boessenkool writes: >> > * cris, m68k, pdp11, and vax actually use "g". >> > >> > So it won't be all that much work to completely get rid of "g". >> > Do we want that? >> >> Is it simply a matter of replacing “g” by “mri”? That’s what the doc >> suggests. Or is there more to the story t

[Ada] PR ada/61505

2014-06-14 Thread Bernd Edlinger
Hi, this should fix the current makeinfo build-problems with gnat_rm.texi. The main problem seems to be, that @item is not working inside @cartouche so I moved all @items up by 3 lines. Then the System.Task_Info (s-tasinf.ads) needs to be in the menu. While editing, I saw the following: Initia

Re: [PATCH,MIPS] MIPS64r6 support

2014-06-14 Thread Richard Sandiford
Sorry for the slow review. Matthew Fortune writes: > The initial support for MIP64r6 is intentionally minimal to make review > easier. Performance enhancements and use of new MIPS64r6 features will > be introduced separately. The current patch makes no attempt to > get the testsuite appropriately

Re: [Ada] PR ada/61505

2014-06-14 Thread Arnaud Charlet
> 2014-06-14 Bernd Edlinger > > PR ada/61505 > * gnat_rm.texi: Fix errors with makeinfo 5.1. This looks good, except that there's a last change needed (at least according to older versions of makeinfo), now detected: --- gnat_rm.texi(revision 211665) +++ gnat_rm.texi

Re: [PATCH][RFC] Make FRE/PRE apply copy/constant propagation

2014-06-14 Thread Eric Botcazou
p.adb -I ~/svn/gcc/gcc/ada - I gcc/ada -O2 -gnatn +===GNAT BUG DETECTED==+ | 4.10.0 20140614 (experimental) [trunk revision 211664] (x86_64-suse-linux) GCC error:| | in forward_edge_to_pdom, at tree-ssa-dce.c:1042 | | Error

Re: [patch] implement std::experimental::any

2014-06-14 Thread Jonathan Wakely
On 10/06/14 14:44 +0100, Jonathan Wakely wrote: This patch implements std::experimental::any from the Fundamentals TS, including small-object optimisation, uses-allocator construction and partial support for -fno-rtti (I should probably disable the allocator-extended constructors when RTTI is dis

[patch] Fix doxygen warnings

2014-06-14 Thread Jonathan Wakely
Ensure parameter names and doxygen comments match, document missing parameters, fix markup etc. Tested x86_64-linux, committed to trunk. The C++14 headers added to the .cfg file won't produce any output until we bump the value of __cplusplus Doxygen uses. I suppose we should really document clas

Re: [libgfortran, patch] Fix compilation on HP/UX 10

2014-06-14 Thread FX
ping > Attached patch should fix compilation of libgfortran on hppa1.1-hp-hpux10.20 > (see PR60468: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60468), by adding > a missing header to the configure checks. > > I’ve tested that it doesn’t break bootstrap on x86_64-apple-darwin, but not > on h

[PATCH 0/6] Make df_ref representation more efficient

2014-06-14 Thread Richard Sandiford
Walks of things like DF_REF_INSN_USES were showing up high in the profile of a fold-const.ii compilation. These reference lists are represented as pointers to null-terminated lists of pointers, and since there's little locality when walking all insns, each loop over the uses or defs generally has

[PATCH 2/6] FOR_EACH_ARTIFICIAL_{DEF,USE}

2014-06-14 Thread Richard Sandiford
Similar to patch 1, but for artificial uses and defs. Richard gcc/ * df.h (FOR_EACH_ARTIFICIAL_USE, FOR_EACH_ARTIFICIAL_DEF): New macros. * cse.c (cse_extended_basic_block): Use them. * dce.c (mark_artificial_use): Likewise. * df-problems.c (df_rd_simulate_artific

[PATCH 3/6] Add FOR_EACH_INSN_INFO_MW

2014-06-14 Thread Richard Sandiford
Similar to patch 1, but for df_mw_hardregs. I think the "S" in "MWS" is a plural, so I went for "mw" in the variable names for single entries. Richard gcc/ * df.h (FOR_EACH_INSN_INFO_MW): New macro. * df-problems.c (df_note_bb_compute): Use it. * regstat.c (regstat_bb_co

[PATCH 4/6] Add df_single_{def,use} helper functions

2014-06-14 Thread Richard Sandiford
IRA wants to know whether a particular insn has a single def or use. That seems worth putting in a utility function, again to hide the underlying representation a bit. Richard gcc/ * df.h (df_single_def, df_single_use): New functions. * ira.c (find_moveable_pseudos): Use them. I

[PATCH 5/6] Remove dead code

2014-06-14 Thread Richard Sandiford
This patch removes some dead code that would otherwise need to be changed in the final patch. Richard gcc/ * df.h (df_ref_create, df_ref_remove): Delete. * df-scan.c (df_ref_create, df_ref_compress_rec): Likewise. (df_ref_remove): Likewise. Index: gcc/df.h ==

[PATCH 6/6] Use a linked list for insn defs and uses

2014-06-14 Thread Richard Sandiford
This is the main change, which is hard to break down much further. Most of this is pretty mechanical. Some of it is reindentation, since it's no longer meaningful (if it was before) to test the defs or artificial_defs against null to see whether a structure had been initialised. Also, df_ref_cha

Remove some unnecessary null checks in df.h

2014-06-14 Thread Richard Sandiford
DF_REF_REG_USE_P and DF_MWS_REG_USE_P checked for null arguments but the def equivalents didn't. There doesn't seem to be any need for this difference. Tested on x86_64-linux-gnu. OK to install? Thanks, Richard gcc/ * df.h (DF_REF_REG_USE_P, DF_MWS_REG_USE_P): Remove null checks. Ind

Re: [PATCH 1/6] Add FOR_EACH_INSN{_INFO}_{DEFS,USES,EQ_USES}

2014-06-14 Thread Steven Bosscher
On Sat, Jun 14, 2014 at 9:43 PM, Richard Sandiford wrote: > gcc/ > * df.h (DF_INSN_INFO_MWS, FOR_EACH_INSN_INFO_DEF): New macros. > (FOR_EACH_INSN_INFO_USE, FOR_EACH_INSN_INFO_EQ_USE): Likewise. > (FOR_EACH_INSN_DEF, FOR_EACH_INSN_USE, FOR_EACH_INSN_EQ_USE): > Likewise. >

Re: [PATCH 2/6] FOR_EACH_ARTIFICIAL_{DEF,USE}

2014-06-14 Thread Steven Bosscher
On Sat, Jun 14, 2014 at 9:44 PM, Richard Sandiford wrote: > gcc/ > * df.h (FOR_EACH_ARTIFICIAL_USE, FOR_EACH_ARTIFICIAL_DEF): New macros. > * cse.c (cse_extended_basic_block): Use them. > * dce.c (mark_artificial_use): Likewise. > * df-problems.c (df_rd_simulate_arti

Re: [PATCH 3/6] Add FOR_EACH_INSN_INFO_MW

2014-06-14 Thread Steven Bosscher
On Sat, Jun 14, 2014 at 9:45 PM, Richard Sandiford wrote: > gcc/ > * df.h (FOR_EACH_INSN_INFO_MW): New macro. > * df-problems.c (df_note_bb_compute): Use it. > * regstat.c (regstat_bb_compute_ri): Likewise. OK. Ciao! Steven

Re: [PATCH 4/6] Add df_single_{def,use} helper functions

2014-06-14 Thread Steven Bosscher
On Sat, Jun 14, 2014 at 9:47 PM, Richard Sandiford wrote: > IRA wants to know whether a particular insn has a single def or use. > That seems worth putting in a utility function, again to hide the > underlying representation a bit. I would have sworn we already had functions for this, but apparent

Re: [PATCH 5/6] Remove dead code

2014-06-14 Thread Steven Bosscher
On Sat, Jun 14, 2014 at 9:48 PM, Richard Sandiford wrote: > This patch removes some dead code that would otherwise need to be > changed in the final patch. These functions were intended to allow passes to update DF info manually. That never was a very practical idea, apparently. > gcc/ >

[patch] Fix links in libstdc++ doxygen comments

2014-06-14 Thread Jonathan Wakely
Fix old, broken links from Doxygen comments to pages in the manual that have a different URL now. Unfortunately the URLs make some lines too long to fit in 80 chars, but I'm not sure what we can do about that. Any suggestions? Tested x86_64-linux, committed to trunk. commit 2a0f6d650951c63f1b56a6

Re: [PATCH 6/6] Use a linked list for insn defs and uses

2014-06-14 Thread Steven Bosscher
On Sat, Jun 14, 2014 at 9:53 PM, Richard Sandiford wrote: > gcc/ > * df.h (df_mw_hardreg, df_base_ref): Add a link pointer. > (df_insn_info): Turn defs, uses, eq_uses and mw_hardregs into linked > lists. > (df_scan_bb_info): Likewise artificial_defs and artificial_us

Re: Remove some unnecessary null checks in df.h

2014-06-14 Thread Steven Bosscher
On Sat, Jun 14, 2014 at 10:02 PM, Richard Sandiford wrote: > DF_REF_REG_USE_P and DF_MWS_REG_USE_P checked for null arguments > but the def equivalents didn't. There doesn't seem to be any > need for this difference. Right, looking at the users (one user for each) of these macros, I don't think R

Re: [PATCH 0/6] Make df_ref representation more efficient

2014-06-14 Thread Steven Bosscher
On Sat, Jun 14, 2014 at 9:36 PM, Richard Sandiford wrote: > Using a linked list gives a consistent 2% compile-time improvement for > fold-const.ii -O0 and ~1% for various -O2 compiles I tried. The df > routines do still show up high on the profile though. Can you explain a bit more about what sho

[patch] Improve some doxygen comments

2014-06-14 Thread Jonathan Wakely
One last set of Doxygen-related updates for today. This removes some redundancy, moves std::bitset to the "Utilities" group in the docs (which is where it lives in the C++11 standard) and gets rid of the "Global I/O operators for bitsets" group, which only contained two operators for the dytnamic

Re: [PATCH] proposed fix for bug # 61144

2014-06-14 Thread Rich Felker
Ping. Do you have any feedback on my tests? What is the next step? Rich On Mon, Jun 09, 2014 at 03:40:44PM +0400, Alexander Monakov wrote: > > > On Fri, 6 Jun 2014, Rich Felker wrote: > > > On Fri, May 23, 2014 at 12:26:18PM -0600, Jeff Law wrote: > > > On 05/21/14 21:59, Rich Felker wrote: >

Re: [C++ Patch] PR 33101

2014-06-14 Thread Jason Merrill
OK, thanks. :) Jason

Re: [C++ Patch] PR 33101

2014-06-14 Thread Paolo Carlini
Hi, On 06/15/2014 12:17 AM, Jason Merrill wrote: OK, thanks. :) Committed... but, I don't think we are done yet, because it seems to me that DR577 means that in C++11 mode we have to accept the typedef?!? That's what current icc does... (I thought the issue was only about clearer diagnostic

libstdc++ regressions with "Move DECL_SECTION_NAME into symtab"

2014-06-14 Thread Hans-Peter Nilsson
On Wed, 11 Jun 2014, Jan Hubicka wrote: > * varasm.c (set_implicit_section): New function. > (resolve_unique_section): Use it to set implicit section > for aliases, too. > (get_named_text_section): Use symtab_get_node (decl)->implicit_section > (default_function_secti

Re: [PATCH 1/n] Add conditional compare framework in middle-end

2014-06-14 Thread Andrew Pinski
On Mon, Feb 24, 2014 at 1:18 AM, Zhenqiang Chen wrote: > Hi, > > The patch (http://gcc.gnu.org/ml/gcc-patches/2014-11/msg03622.html) is > re-based (the arm port change is stripped as a separate patch), which > includes only the middle-end changes. The basic logic for the patch > is: > > 1) Ident

Re: [PATCH, libgfortran] Add overflow check to xmalloc

2014-06-14 Thread Janne Blomqvist
PING #3 On Sat, Jun 7, 2014 at 5:46 AM, Janne Blomqvist wrote: > PING #2 > > On Fri, May 30, 2014 at 5:53 PM, Janne Blomqvist > wrote: >> PING >> >> On Tue, May 20, 2014 at 12:42 AM, Janne Blomqvist >> wrote: >>> On Thu, May 15, 2014 at 1:00 AM, Janne Blomqvist >>> wrote: Hi, a

Re: [libgfortran, patch] Fix compilation on HP/UX 10

2014-06-14 Thread Janne Blomqvist
Ok. (as an aside, has anyone ever heard of anyone actually using gfortran on hp-ux?) On Sat, Jun 14, 2014 at 10:07 PM, FX wrote: > ping > >> Attached patch should fix compilation of libgfortran on hppa1.1-hp-hpux10.20 >> (see PR60468: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60468), by addi

Re: [PATCH, libgfortran] Add overflow check to xmalloc

2014-06-14 Thread Bernhard Reutner-Fischer
>> On Tue, May 20, 2014 at 12:42 AM, Janne Blomqvist >> wrote: >>> On Thu, May 15, 2014 at 1:00 AM, Janne Blomqvist >>> wrote: Hi, a common malloc() pattern is "malloc(num_foo * sizeof(foo_t)", that is, create space for an array of type foo_t with num_foo elements. The