Re: fixincludes patch RFA: Fix fenv.h on Ubuntu Precise

2013-11-07 Thread Ian Lance Taylor
On Thu, Nov 7, 2013 at 8:48 AM, Bruce Korb wrote: > > This time, I'm on my dev box and looked at the code. > You remembered correctly that the first file name in the list > of file names needs to not have wild card characters so that > the testing scheme can create a file by that name. A director

Re: Implement C11 _Atomic

2013-11-07 Thread Joseph S. Myers
On Thu, 7 Nov 2013, Uros Bizjak wrote: > Please note that following code form fenv.c won't generate overflow > exception on x87: > > if (excepts & FP_EX_OVERFLOW) > { > volatile float max = __FLT_MAX__; > r = max * max; > } r being volatile is intended to ensure that the re

Re: Implement C11 _Atomic

2013-11-07 Thread Uros Bizjak
On Thu, Nov 7, 2013 at 7:26 PM, Joseph S. Myers wrote: > On Thu, 7 Nov 2013, Uros Bizjak wrote: > >> Please note that following code form fenv.c won't generate overflow >> exception on x87: >> >> if (excepts & FP_EX_OVERFLOW) >> { >> volatile float max = __FLT_MAX__; >> r = max *

Re: [PATCH, MPX, 2/X] Pointers Checker [5/25] Tree and gimple ifaces

2013-11-07 Thread Jeff Law
On 11/04/13 05:40, Richard Biener wrote: Effectively the bounds are passed "on the side". Well, not exactly. I can see __bound_tmp.0_4 passed to access_and_store. I'm referring to how they're dealt with in FUNCTION_ARG and friends, ie, the low level aspects. Maybe that's why we're crossing

Re: Implement C11 _Atomic

2013-11-07 Thread Joseph S. Myers
On Thu, 7 Nov 2013, Uros Bizjak wrote: > [uros@localhost test]$ gcc -lm -g fpex.c > [uros@localhost test]$ ./a.out > Floating point exception (core dumped) > [uros@localhost test]$ gcc -lm -g -m32 fpex.c > [uros@localhost test]$ ./a.out > [uros@localhost test]$ I see code of the form (testing com

Re: [gomp4 9/9] OpenACC: Basic support for #pragma acc parallel.

2013-11-07 Thread Thomas Schwinge
Hi! Thanks for the quick review of the patch series! Committed earlier today, with the revisions as discussed. On Wed, 6 Nov 2013 20:55:01 +0100, Jakub Jelinek wrote: > On Wed, Nov 06, 2013 at 08:42:23PM +0100, tho...@codesourcery.com wrote: > > +#define OACC_PARALLEL_CLAUSE_MASK

Re: [PATCH, MPX, 2/X] Pointers Checker [9/25] Bound constants

2013-11-07 Thread Jeff Law
On 10/31/13 03:15, Ilya Enkovich wrote: Hi, Here is a patch which adds support for bound constant to be used as DECL_INITIAL for constant static bounds generated by compiler. Thanks, Ilya -- gcc/ 2013-10-23 Ilya Enkovich * emit-rtl.c (immed_double_const): Support MODE_POINTER_BOU

Re: [PATCH, MPX, 2/X] Pointers Checker [10/25] Calls copy and verification

2013-11-07 Thread Jeff Law
On 11/07/13 04:50, Ilya Enkovich wrote: Hi, Here is an updated patch version. I think this needs to hold until we have a consensus on what the parameter passing looks like for bounded pointers. Jeff

[C++ Patch / RFC] Fixing a diagnostic regression caused by the fix for c++/56930

2013-11-07 Thread Paolo Carlini
Hi all, Jason, in mainline, this commit: http://gcc.gnu.org/viewcvs/gcc?view=revision&revision=199232 appear to have caused a diagnostic regression for the following (from c++/43906): extern void z(); void f() { if ( z ) z(); } that is, with -Waddress we warn twice, because in cp_conver

Fix for PR c++/59031

2013-11-07 Thread Easwaran Raman
Before r193504, if a method can not be overridden, LOOKUP_NONVIRTUAL is set and the call is direct. The changes at r193504 (to fix PR c++/11750) caused a regression to this behavior. This patch attempts to fix that. Bootstraps and no test regressions on x86_64/linux. Is this a correct fix and is t

[PATCH] Fix obvious comment typo

2013-11-07 Thread Jeff Law
Just something I noticed while reviewing patches. Installed onto the trunk as obvious. Jeff * varpool.c (ctor_for_folding): Fix typo in comment. diff --git a/gcc/varpool.c b/gcc/varpool.c index 4f1658e..1e4c823 100644 --- a/gcc/varpool.c +++ b/gcc/varpool.c @@ -304,7 +304,7 @@ ctor_for

Re: wide-int testing results

2013-11-07 Thread Mike Stump
On Nov 7, 2013, at 9:51 AM, Richard Sandiford wrote: > pdp11 and picochip-elf don't build on mainline due to: > > gcc/target-def.h:69:34: error: ‘default_stabs_asm_out_destructor’ was not > declared in this scope > # define TARGET_ASM_DESTRUCTOR default_stabs_asm_out_destructor Fixed: 2

[PATCH i386]: Handle FP_EX_DENORM and improve __sfp_handle_exceptions

2013-11-07 Thread Uros Bizjak
Hello! Attached patch adds missing FP_EX_DENORM handling to x86 soft-fp exception generator and improves support code a bit. The FP_EX_DENORM handling will be needed by gfortran IEEE support. 2013-11-07 Uros Bizjak * config/i386/sfp-exceptions.c (__sfp_handle_exceptions): Handle FP_EX

Re: [C++ Patch / RFC] Fixing a diagnostic regression caused by the fix for c++/56930

2013-11-07 Thread Paolo Carlini
... well, something like this seems better to me. Only lightly tested so far, sorry. Paolo. /// Index: cvt.c === --- cvt.c (revision 204536) +++ cvt.c (working copy) @@ -621,24 +621,25 @@ cp_convert_

Re: [PATCH, MPX, 2/X] Pointers Checker [9/25] Bound constants

2013-11-07 Thread Ilya Enkovich
2013/11/7 Jeff Law : > On 10/31/13 03:15, Ilya Enkovich wrote: >> >> Hi, >> >> Here is a patch which adds support for bound constant to be used as >> DECL_INITIAL for constant static bounds generated by compiler. >> >> Thanks, >> Ilya >> -- >> >> gcc/ >> >> 2013-10-23 Ilya Enkovich >> >>

Re: [C++ Patch / RFC] Fixing a diagnostic regression caused by the fix for c++/56930

2013-11-07 Thread Paolo Carlini
.. nope, p2 isn't Ok, because we would return a different tree depending on complain and . c_inhibit_evaluation_warnings. Thus either something closer to p or something else. Paolo.

[patch] remove superfluous sets to SSA_NAME_DEF_STMT

2013-11-07 Thread Aldy Hernandez
SSA_NAME_DEF_STMT is set by default in gimple_build_assign(), by virtue of gimple_assign_set_lhs: static inline void gimple_assign_set_lhs (gimple gs, tree lhs) { GIMPLE_CHECK (gs, GIMPLE_ASSIGN); gimple_set_op (gs, 0, lhs); if (lhs && TREE_CODE (lhs) == SSA_NAME) SSA_NAME_DEF_STMT (

Re: [patch] remove superfluous sets to SSA_NAME_DEF_STMT

2013-11-07 Thread Diego Novillo
On Thu, Nov 7, 2013 at 3:14 PM, Aldy Hernandez wrote: > SSA_NAME_DEF_STMT is set by default in gimple_build_assign(), by virtue of > gimple_assign_set_lhs: > >> static inline void >> gimple_assign_set_lhs (gimple gs, tree lhs) >> { >> GIMPLE_CHECK (gs, GIMPLE_ASSIGN); >> gimple_set_op (gs, 0,

Re: Implement C11 _Atomic

2013-11-07 Thread Joseph S. Myers
On Thu, 7 Nov 2013, Uros Bizjak wrote: > > I see code of the form (testing compilation rather than execution): > > > > flds4(%esp) > > flds8(%esp) > > fmulp %st, %st(1) > > fstps 12(%esp) > > > > where the fstps should result in the exception, and glibc

[WIP] Vectorization using elemental functions

2013-11-07 Thread Jakub Jelinek
Hi! Here is a WIP. As the cloning doesn't yet produce multiple arguments for one arg (say for SSE2 variant and simdlen(8) int should be passed in two V4SImode arguments, while currently it is passed in one vector(8) int BLKmode one) nor returned in multiple vectors (any thoughts how to represent

Re: Implement C11 _Atomic

2013-11-07 Thread Uros Bizjak
On Thu, Nov 7, 2013 at 9:33 PM, Joseph S. Myers wrote: >> > I see code of the form (testing compilation rather than execution): >> > >> > flds4(%esp) >> > flds8(%esp) >> > fmulp %st, %st(1) >> > fstps 12(%esp) >> > >> > where the fstps should result in

Re: fixincludes patch RFA: Fix fenv.h on Ubuntu Precise

2013-11-07 Thread Ian Lance Taylor
In the meantime I've committed my version of the patch to the gccgo branch. It will be updated to whatever the final mainline version is the next time I merge from mainline to the gccgo branch. Ian On Thu, Nov 7, 2013 at 10:16 AM, Ian Lance Taylor wrote: > On Thu, Nov 7, 2013 at 8:48 AM, Bruce

[patch] safe iterator simplification

2013-11-07 Thread François Dumont
Hi Here is a patch to simplify a little safe iterator implementation. Returning a sequence pointer from a safe iterator and a const sequence pointer from a const safe iterator allows to avoid inconsistent usages of iterator like comparing iterator with a const_iterator. This way __get_dis

Re: [PATCH, MPX, 2/X] Pointers Checker [5/25] Tree and gimple ifaces

2013-11-07 Thread Ilya Enkovich
2013/11/7 Jeff Law : > On 11/04/13 05:40, Richard Biener wrote: >>> >>> >>> Effectively the bounds are passed "on the side". >> >> >> Well, not exactly. I can see __bound_tmp.0_4 passed to access_and_store. > > I'm referring to how they're dealt with in FUNCTION_ARG and friends, ie, the > low leve

Re: fixincludes patch RFA: Fix fenv.h on Ubuntu Precise

2013-11-07 Thread Bruce Korb
OK. It will be a couple of days. On Thu, Nov 7, 2013 at 1:01 PM, Ian Lance Taylor wrote: > In the meantime I've committed my version of the patch to the gccgo > branch. It will be updated to whatever the final mainline version is > the next time I merge from mainline to the gccgo branch. > > Ia

Re: Implement C11 _Atomic

2013-11-07 Thread Uros Bizjak
On Thu, Nov 7, 2013 at 9:55 PM, Uros Bizjak wrote: >>> > I see code of the form (testing compilation rather than execution): >>> > >>> > flds4(%esp) >>> > flds8(%esp) >>> > fmulp %st, %st(1) >>> > fstps 12(%esp) >>> > >>> > where the fstps should result

Re: Implement C11 _Atomic

2013-11-07 Thread Joseph S. Myers
On Thu, 7 Nov 2013, Uros Bizjak wrote: > However, this insn also raised FE_INEXACT flag (also on x86_64), > probably not what you wanted. Your code that generates FE_UNDERFLOW > will also raise FE_INEXACT. (and FE_DENORMAL). If the compound assignment raised overflow or underflow, it will also ha

Recent Go patch broke Alpha bootstrap

2013-11-07 Thread Uros Bizjak
Hello! Recent Go mega-patch broke Alpha bootstrap. Following fixlet is needed: --cut here-- Index: runtime/proc.c === --- runtime/proc.c (revision 204522) +++ runtime/proc.c (working copy) @@ -2098,7 +2098,7 @@

Re: [PATCH] Add gimple subclasses for every gimple code (was Re: [PATCH 0/6] Conversion of gimple types to C++ inheritance (v3))

2013-11-07 Thread Alec Teal
Hello On 06/11/13 15:32, Michael Matz wrote: Hi, On Tue, 5 Nov 2013, David Malcolm wrote: Here's a followup patch which ensures that every gimple code has its own subclass, by adding empty subclasses derived from the GSS_-based subclasses as appropriate (I don't bother for gimple codes that a

Re: Recent Go patch broke Alpha bootstrap

2013-11-07 Thread Ian Lance Taylor
On Thu, Nov 7, 2013 at 2:25 PM, Uros Bizjak wrote: > > Recent Go mega-patch broke Alpha bootstrap. Following fixlet is needed: > > --cut here-- > Index: runtime/proc.c > === > --- runtime/proc.c (revision 204522) > +++ runtime/pr

Re: [PATCH, i386]: Fix PR 59021, new vzeroupper instructions generated with -mavx

2013-11-07 Thread Joern Rennecke
On 7 November 2013 20:01, Uros Bizjak wrote: > OTOH, looking a bit deeper, it looks that there is a problem in > mode-switching infrastructure. If we have a BB without any mode > requirements, but an insn that switched the mode via MODE_AFTER, we > should not mark the block as transparent. Indeed

Re: [C] Fix PR57258: unused variable warning is emitted for volatile variables

2013-11-07 Thread Mingjie Xing
2013/11/7 Joseph S. Myers : > On Thu, 7 Nov 2013, Mingjie Xing wrote: > >> 2013/11/6 Richard Biener : >> > You miss a testcase. >> > >> > Also why should the warning be omitted for unused automatic >> > volatile variables? They cannot be used in any way. >> > >> > Richard. >> >> Thanks. I've upda

RE: [patch] [arm] ARM Cortex-M3/M4 tuning

2013-11-07 Thread Joey Ye
Ping > -Original Message- > From: Joey Ye [mailto:joey...@arm.com] > Sent: Friday, November 01, 2013 1:00 > To: gcc-patches@gcc.gnu.org > Subject: [patch] [arm] ARM Cortex-M3/M4 tuning > > Based on Julian's http://gcc.gnu.org/ml/gcc-patches/2012-07/msg01006.html > and > > * Merged with l

Re: [PATCH] Small fix: add { dg-require-effective-target vect_int } to testsuite/gcc.dg/vect/pr58508.c

2013-11-07 Thread Cong Hou
Ping. OK for the trunk? thanks, Cong On Fri, Nov 1, 2013 at 10:47 AM, Cong Hou wrote: > It seems that on some platforms the loops in > testsuite/gcc.dg/vect/pr58508.c may be unable to be vectorized. This > small patch added { dg-require-effective-target vect_int } to make > sure all loops ca

Re: [PATCH] Introducing SAD (Sum of Absolute Differences) operation to GCC vectorizer.

2013-11-07 Thread Cong Hou
Now is this patch OK for the trunk? Thank you! thanks, Cong On Tue, Nov 5, 2013 at 9:58 AM, Cong Hou wrote: > Thank you for your detailed explanation. > > Once GCC detects a reduction operation, it will automatically > accumulate all elements in the vector after the loop. In the loop the > re

[PATCH, ARM, testcase] Skip target arm-neon for lp1243022.c

2013-11-07 Thread Zhenqiang Chen
Hi, lp1243022.c will fail with options: -mfpu=neon -mfloat-abi=hard. Logs show it does not generate auto-incremental instruction in pass auto_inc_dec. In this case, the check of REG_INC note at subreg2 will be invalid. So skip the check for target arm-neon. All PASS with the following options:

Go patch committed: Correct types in type conversion

2013-11-07 Thread Ian Lance Taylor
This patch to the Go frontend fixes the type returned when a type conversion has to make a function call. I have a test case that I will commit to the master testsuite after the Go 1.2 release (the test case is simply "return []byte(s)[0]"). Bootstrapped and ran Go testsuite on x86_64-unknown-lin

Merge from mainline to gccgo branch

2013-11-07 Thread Ian Lance Taylor
I've merged GCC mainline revision 204559 to the gccgo branch. Ian

<    1   2