Re: [PATCH, MPX, 2/X] Pointers Checker [5/25] Tree and gimple ifaces

2013-10-29 Thread Jeff Law
On 10/24/13 08:43, Ilya Enkovich wrote: +/* Return the number of arguments used by call statement GS. */ + +static inline unsigned +gimple_call_num_nobnd_args (const_gimple gs) +{ + unsigned num_args = gimple_call_num_args (gs); + unsigned res = num_args; + for (unsigned n = 0; n < num_args;

Re: [PATCH, MPX, 2/X] Pointers Checker [2/25] Builtins

2013-10-29 Thread Ilya Enkovich
2013/10/29 Jeff Law : > On 10/29/13 07:52, Ilya Enkovich wrote: >> >> >> Yeah. I'm working on it right now. I've fixed known issues and now >> I'm looking for others. Meanwhile here is a new patch version with >> required renames and without LTO restriction. > > I can't help but but curious, wha

Re: [Patch, Fortran] PR44350 - add constraint check for BLOCK DATA

2013-10-29 Thread Paul Richard Thomas
Dear Tobias, Your patch is OK for trunk. Thanks for the patch Are you sure that PR58857 is valid? If so, I stick my legs up in the air and give up :-) Cheers Paul On 24 October 2013 00:09, Tobias Burnus wrote: > A rather simple patch, which tries to implement Fortran 2008's C1116 (see > als

Re: Fix scheduler ix86_issue_rate and ix86_adjust_cost for modern x86 chips

2013-10-29 Thread Jan Hubicka
> On Fri, 25 Oct 2013, Jan Hubicka wrote: > > > > > OK, so it is about 2%. Did you try if you need lookahead even in the > > > > early pass (before reload)? My guess would be so, but if not, it could > > > > cut the cost to half. For -Ofast/-O3 it looks resonable to me, but we > > > > will

Re: [PATCH] Fix PR ipa/58862 (profiled bootstrap failure)

2013-10-29 Thread Jan Hubicka
> This patch fixes a profiledbootstrap failure that occurred after I > added some profile fixup. The initial profile insanity occurred > upstream of my change, but my change caused the insanity to spread to > the edge probability, resulting in a verify failure. The patch below > ensures this doesn'

Re: [Patch, fortran] PRs 57893 and 58858

2013-10-29 Thread Paul Richard Thomas
Dear Tobias, The .diff does not seem to reflect what is in the file - I am at a loss to explain why. Committed as revision 204177. Thanks for the review. Paul On 29 October 2013 07:32, Tobias Burnus wrote: > Am 28.10.2013 23:26, schrieb Paul Richard Thomas: > >> This patch addresses issues ar

Re: [SH] PR 54236 - add some more addc patterns

2013-10-29 Thread Oleg Endo
On Tue, 2013-10-29 at 11:43 +0900, Kaz Kojima wrote: > Oleg Endo wrote: > > This adds some more patterns to utilize the SH addc instruction. > > Tested on rev 204111 with > > make -k check RUNTESTFLAGS="--target_board=sh-sim > > \{-m2a/-mb,-m2a-single/-mb,-m4/-ml,-m4-single/-ml,-m4/-mb,-m4-single/

[wide-int] Various minor tweaks

2013-10-29 Thread Richard Sandiford
I looked through the diff of wide-int with mainline and noticed a few minor things to tweak. This patch: - Fixes comment typos that I'd introducted. - Fixes spurious whitespace differences. - Uses const X & instead of X for *wide_int parameters. - Fuses declarations and initialisers. - Avoids unn

[patch] fix libstdc++/58839

2013-10-29 Thread Jonathan Wakely
This change fixes the unique_ptr testcase in the PR while preserving the extension that we allow initializing a shared_ptr from a unique_ptr that uses a custom pointer. I've added a test for that extension, and for assignment of enable_shared_from this. 2013-10-29 Jonathan Wakely PR l

[RFA][PATCH] Minor fix to aliasing machinery

2013-10-29 Thread Jeff Law
Marc pointed out that the handling of various BUILT_IN_MEM* and BUILT_IN_STR* functions in tree-ssa-alias.c probably wasn't working as intended because the code wasn't prepared for a common return value from ao_ref_base, particularly returns of MEM_REFs. This patch fixes the code to handle t

Re: patch to fix a LRA crash on ppc

2013-10-29 Thread Mike Stump
On Oct 28, 2013, at 4:20 PM, Vladimir Makarov wrote: >* lra-spills.c (lra_final_code_change): Remove useless move insns >originated from moves of pseudos. So I was facing a problem of extraneous moves of multiple registers: (set (reg:TI 1) (mem …)) === (set (reg:DI 2) (subreg:D

Re: [PATCH, MPX, 2/X] Pointers Checker [5/25] Tree and gimple ifaces

2013-10-29 Thread Ilya Enkovich
On 29 Oct 13:39, Jeff Law wrote: > On 10/24/13 08:43, Ilya Enkovich wrote: > > > >+/* Return the number of arguments used by call statement GS. */ > >+ > >+static inline unsigned > >+gimple_call_num_nobnd_args (const_gimple gs) > >+{ > >+ unsigned num_args = gimple_call_num_args (gs); > >+ unsig

Re: [patch] fix libstdc++/58839

2013-10-29 Thread Jonathan Wakely
On 29 October 2013 21:33, Jonathan Wakely wrote: > This change fixes the unique_ptr testcase in the PR while > preserving the extension that we allow initializing a shared_ptr from > a unique_ptr that uses a custom pointer. > > I've added a test for that extension, and for assignment of > enable_sh

Re: [RFA][PATCH] Minor fix to aliasing machinery

2013-10-29 Thread Marc Glisse
On Tue, 29 Oct 2013, Jeff Law wrote: Marc pointed out that the handling of various BUILT_IN_MEM* and BUILT_IN_STR* functions in tree-ssa-alias.c probably wasn't working as intended because the code wasn't prepared for a common return value from ao_ref_base, particularly returns of MEM_REFs.

[PATCH] Introducing SAD (Sum of Absolute Differences) operation to GCC vectorizer.

2013-10-29 Thread Cong Hou
Hi SAD (Sum of Absolute Differences) is a common and important algorithm in image processing and other areas. SSE2 even introduced a new instruction PSADBW for it. A SAD loop can be greatly accelerated by this instruction after being vectorized. This patch introduced a new operation SAD_EXPR and a

[wide-int] Update main comment

2013-10-29 Thread Richard Sandiford
This patch tries to update the main wide_int comment to reflect the current implementation. - bitsizetype is TImode on x86_64 and others, so I don't think it's necessarily true that all offset_ints are signed. (widest_int are though.) - As discussed in the early threads, I think the first re

Re: [wide-int] Update main comment

2013-10-29 Thread Kenneth Zadeck
On 10/29/2013 06:37 PM, Richard Sandiford wrote: This patch tries to update the main wide_int comment to reflect the current implementation. - bitsizetype is TImode on x86_64 and others, so I don't think it's necessarily true that all offset_ints are signed. (widest_int are though.) i am

Ping^2 Re: Add predefined macros for library use in defining __STDC_IEC_559*

2013-10-29 Thread Joseph S. Myers
Ping^2. This patch is still pending review (hook addition, rs6000/powerpc changes). -- Joseph S. Myers jos...@codesourcery.com

[Patch, libgfortran] Set close-on-exec flag when opening files

2013-10-29 Thread Janne Blomqvist
Hello, the attached patch sets the close-on-exec flag when opening files, as is usually considered good practice these days. See e.g. http://www.python.org/dev/peps/pep-0446/ and links therein for more information. The preconnected units INPUT_UNIT, OUTPUT_UNIT, ERROR_UNIT are not affected, only

Re: [PATCH] Introducing SAD (Sum of Absolute Differences) operation to GCC vectorizer.

2013-10-29 Thread Ramana Radhakrishnan
Cong, Please don't do the following. >+++ b/gcc/testsuite/gcc.dg/vect/ vect-reduc-sad.c @@ -0,0 +1,54 @@ +/* { dg-require-effective-target sse2 { target { i?86-*-* x86_64-*-* } } } */ you are adding a test to gcc.dg/vect - It's a common directory containing tests that need to run on multiple arc

Re: libsanitizer merge from upstream r191666

2013-10-29 Thread Konstantin Serebryany
Jakub, Your patch seems to do what it should: % ../gcc-inst/bin/g++ -gdwarf-2 -fsanitize=address -static-libasan ../gcc/gcc/testsuite/c-c++-common/asan/stack-overflow-1.c && ./a.out ... Address 0x7fffb8ec95ca is located in stack of thread T0 at offset 42 in frame #0 0x44bd73 in main ../gcc/gc

Re: Aliasing: look through pointer's def stmt

2013-10-29 Thread Marc Glisse
On Tue, 29 Oct 2013, Richard Biener wrote: For the POINTER_PLUS_EXPR offset argument you should use int_cst_value () to access it (it will unconditionally sign-extend) and use host_integerp (..., 0). That leaves the overflow possibility in place (and you should multiply by BITS_PER_UNIT) which

[Patch, committed] libcilkrts - add AM_MAINTAINER_MODE; update "gcc_update" for libcilkrts

2013-10-29 Thread Tobias Burnus
I have committed the following as obvious: * Added AM_MAINTAINER_MODE to libcilkrtl's configure.ac (and reconfigured) Before, building failed on a system which had the wrong version of autoconf. * As suggested by Joseph, I added the relevant files for libcilkrtl to contrib/gcc_update Committe

Re: [Patch, committed] libcilkrts - add AM_MAINTAINER_MODE; update "gcc_update" for libcilkrts

2013-10-29 Thread Tobias Burnus
I missed to attach the patch. I now did. Tobias Tobias Burnus: I have committed the following as obvious: * Added AM_MAINTAINER_MODE to libcilkrtl's configure.ac (and reconfigured) Before, building failed on a system which had the wrong version of autoconf. * As suggested by Joseph, I adde

Re: libsanitizer merge from upstream r191666

2013-10-29 Thread Konstantin Serebryany
Actually, I guessed the flags: % ../gcc-inst/bin/g++ -g -fsanitize=address -static-libasan -O2 -flto -fno-use-linker-plugin -flto-partition=none ../gcc/gcc/testsuite/c-c++-common/asan/stack-overflow-1.c; ./a.out 2>&1 /tmp/ccgSw6NI.lto.o: In function `main': ../gcc/gcc/testsuite/c-c++-common/asan

Re: [wide-int] More optimisations

2013-10-29 Thread Kenneth Zadeck
On 10/29/2013 08:43 AM, Richard Sandiford wrote: Richard Biener writes: On Sun, 27 Oct 2013, Richard Sandiford wrote: This patch adds some more optimisations to the wi:: comparison functions. It uses the: #define CONSTANT(X) (__builtin_constant_p (X) && (X)) idiom that was mentioned befor

[PATCH] Fix PR middle-end/58134

2013-10-29 Thread Sharad Singhai
This patch removes a deprecated option -ftree-vectorizer-verbose. It was already implemented in terms of -fopt-info and makes little sense to keep it around longer. It causes needless confusion as reported in PR middle-end/58134. I noticed that several gettext related gcc/po files contain help tra

Re: [wide-int] More optimisations

2013-10-29 Thread Mike Stump
On Oct 29, 2013, at 5:43 AM, Richard Sandiford wrote: > Richard Biener writes: >> >> I think the cases Mike added should only be enabled when we can figure >> them out at compile-time, too. > > Well, the idea with most of these functions was to handle the simple > "everything is one HWI" cases

Re: Add predefined macros for library use in defining __STDC_IEC_559*

2013-10-29 Thread David Edelsohn
On Tue, Oct 15, 2013 at 5:22 PM, Joseph S. Myers wrote: > Bootstrapped with no regressions on x86_64-unknown-linux-gnu, and > tested with no regressions with cross to powerpc-linux-gnu > (soft-float). OK to commit (hook addition, rs6000/powerpc changes)? > > 2013-10-15 Joseph Myers > >

Re: [wide-int] Various minor tweaks

2013-10-29 Thread Mike Stump
On Oct 29, 2013, at 2:21 PM, Richard Sandiford wrote: > I looked through the diff of wide-int with mainline and noticed a few > minor things to tweak. > It all seemed pretty obvious, and the patch is long and mechanical, > so I went ahead and installed it. I reviewed it, looks good.

Re: Using gen_int_mode instead of GEN_INT minor testsuite fallout on MIPS

2013-10-29 Thread Mike Stump
On Oct 29, 2013, at 3:20 AM, Richard Biener wrote: > Can you please get rid of PARTIAL_INT_MODE_NAME by > making the name a required argument to PARTIAL_INT_MODE? Sure, easy to do. * machmode.def (PARTIAL_INT_MODE): Add precision and name. * genmodes.c (PARTIAL_INT_MODE): Add pre

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

2013-10-29 Thread Andrew Pinski
On Tue, Oct 29, 2013 at 3:28 AM, Richard Biener wrote: > On Sun, Oct 27, 2013 at 7:55 PM, Andrew Pinski wrote: >> On Sat, Oct 26, 2013 at 4:49 PM, Andrew Pinski wrote: >>> On Sat, Oct 26, 2013 at 2:30 PM, Andrew Pinski wrote: On Fri, Oct 18, 2013 at 2:21 AM, Zhenqiang Chen wrote: >>>

Re: [PATCH] Keep REG_INC note in subreg2 pass

2013-10-29 Thread Zhenqiang Chen
On 30 October 2013 02:47, Jeff Law wrote: > On 10/24/13 02:20, Zhenqiang Chen wrote: >> >> Hi, >> >> REG_INC note is lost in subreg2 pass when resolve_simple_move, which >> might lead to wrong dependence for ira. e.g. In function >> validate_equiv_mem of ira.c, it checks REG_INC note: >> >>

<    1   2