Re: [PATCH] Basic support for MIPS r5900

2013-06-24 Thread Jürgen Urban
Hello Richard, Am 23.06.2013 um 22:21 schrieb Richard Sandiford : > "Jürgen Urban" writes: >> >> In the native PS2SDK (i.e. no Linux) I detected that there are undefined >> references to `__fixtfsi', `__floatsitf', `__subtf3', `__multf3', >> __extenddftf2', `__lttf2' and `__gttf2'. These are th

Re: [PATCH, libjava] Use accessor functions to manipulate xmlOutputBuffer

2013-06-24 Thread Dodji Seketeli
Hello Andrew, Andrew Haley writes: > On 08/08/2012 11:08 PM, Dodji Seketeli wrote: >> OK to commit? > > Looks good, Thanks. Just for the record, you acked this patch a year or so ago, but now I realize it was by private email. I am attaching the email I received (as I see there is nothing rea

Re: [PATCH, libjava] Use accessor functions to manipulate xmlOutputBuffer

2013-06-24 Thread Andrew Haley
On 06/24/2013 09:13 AM, Dodji Seketeli wrote: > Just to make sure I understand what you are saying; do you mean that the > accessor macro GET_XML_OUTPUT_BUFFER_SIZE (that depends on > LIBXML2_NEW_BUFFER) shouldn't be defined in > libjava/classpath/native/jni/xmlj/xmlj_io.c but somewhere else by an

Re: [Patch, Fortran] Print floating-point exception status after STOP/ERROR STOP

2013-06-24 Thread Tobias Burnus
Eric, Gerald, all, I have now committed (Rev. 200360) the attached patch. (Compared to the draft patch, with a missing "," added in AC_CHECK_TYPES). Eric, Gerald: Can you confirm that it now works on both FreeBSD and Solaris? Eric: Should one (conditionally) include on Solaris? I am asking

Re: [Patch, Fortran] PR52413 - Incorrect behavior of FRACTION when applied to a constant

2013-06-24 Thread Tobias Burnus
Dominique Dhumieres wrote: This patch packages the Steven G. Kargl's patch when MPFR 3.1.0 or newer is available and fixes the original code for older versions using the FX Coudert's machinery (see PR for details). Tested on powerpc-apple-darwin9 and x86_64-apple-darwin10 without regression. OK

Re: [PATCH, i386, PR57623] Introduce _bextr (single underscore) intrinsucs

2013-06-24 Thread Kirill Yukhin
Hello! >> I actually don't understand how this can work, bmi_bextr_{si,di} expanders >> have just 3 operands (one target, 2 arguments), so just by giving it >> 4 operands instead just means the last one is dropped on the floor. >> Why do you need a builtin for this at all? >> I was expecting that _

Re: [PATCH, i386, PR57623] Introduce _bextr (single underscore) intrinsucs

2013-06-24 Thread Jakub Jelinek
On Mon, Jun 24, 2013 at 12:55:11PM +0400, Kirill Yukhin wrote: > Here is snippet from i386.c: > case > 3: > > > pat = GEN_FCN (icode) (real_target, args

RE: [PATCH,ARM] Define MAX_CONDITIONAL_EXECUTE

2013-06-24 Thread Greta Yorsh
PING... http://gcc.gnu.org/ml/gcc-patches/2013-06/msg00948.html Thanks, Greta > -Original Message- > From: Greta Yorsh [mailto:greta.yo...@arm.com] > Sent: 17 June 2013 12:19 > To: GCC Patches > Cc: Richard Earnshaw; Ramana Radhakrishnan; p...@codesourcery.com; > ni...@redhat.com > Subjec

[PATCH] Fix PR57488

2013-06-24 Thread Richard Biener
This fixes PR57488 - clearing NEW sets before each insert iteration ensures we don't propagate memory accesses across back-edges into regions where that would not be valid. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2013-06-24 Richard Biener PR t

Re: [Patch, Fortran] PR52413 - Incorrect behavior of FRACTION when applied to a constant

2013-06-24 Thread Dominique Dhumieres
Tobias, > I have committed it as Rev. 200361. Thanks for the quick commit. No backport? Dominique

[PATCH] Fix PR57584

2013-06-24 Thread Richard Biener
Removed the target specific bits and verified the testcase reproduces the original bug and works after the fix for x86_64 and i686. Committed. Richard. 2013-06-24 Richard Biener PR testsuite/57686 * gcc.dg/torture/pr57584.c: Remove target specific bits. Index: gcc/testsuite

Re: [PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2013-06-24 Thread Dimitris Papavasiliou
Ping! Would anybody care to comment on this? On 06/10/2013 12:44 AM, Dimitris Papavasiliou wrote: Hello, First, let me say that I have consciously broken most of the rules mentioned about patch submission at gcc.gnu.org but I have done so in order to spare myself from wasting time to provide a

Re: [PATCH] Provide a pointer_map template

2013-06-24 Thread Richard Biener
On Wed, 19 Jun 2013, Richard Biener wrote: > On Wed, 19 Jun 2013, Richard Biener wrote: > > > > > This templates the pointer-map implementation (actually it copies > > the implementation, leaving the old interface unchanged) providing > > a templated value type. That's suitable to replace the v

Re: [PATCH] if-to-switch pass

2013-06-24 Thread Richard Biener
On Fri, Jun 21, 2013 at 10:37 PM, Cesar Philippidis wrote: > Here is an updated version of Tom's if-to-switch conversion pass that > was originally posted here: > > . > > I corrected a build problem with ARM by including "tm_p.h" and an ICE

Re: [ping] [patch 4/5] fix bugs with -fstrict-volatile-bitfields and packed structures

2013-06-24 Thread Richard Biener
On Sun, Jun 23, 2013 at 6:17 PM, Sandra Loosemore wrote: > On 06/16/2013 01:08 PM, Sandra Loosemore wrote: >> >> This part of the patch series fixes problems with bad code being emitted >> for unaligned bitfield accesses, as reported in PRs 48784, 56341, and >> 56997. A secondary goal of this pat

Re: [PATCH] Change the badness computation to ensure no integer-underflow

2013-06-24 Thread Richard Biener
On Sat, Jun 22, 2013 at 2:59 AM, Dehao Chen wrote: > This patch prevents integer-underflow of badness computation in ipa-inline. > > Bootstrapped and passed regression tests. > > OK for trunk? > > Thanks, > Dehao > > gcc/ChangeLog: > 2013-06-21 Dehao Chen > > * ipa-inline.c (edge_badnes

[v3] libstdc++/57691

2013-06-24 Thread Paolo Carlini
Hi, see audit trail for details. Committed to mainline. Thanks, Paolo. // 2013-06-24 Bernd Edlinger PR libstdc++/57691 * include/c_global/cstdlib (atexit, at_quick_exit): If !_GLIBCC_HOSTED, declare per the letter of the C++ standard in terms of v

[PATCH] Fix PR56977

2013-06-24 Thread Richard Biener
With -Og we do no constant propagation after folding all remaining builtins which is a problem when RTL expansion issues errors such as those for function calls to functions with the error attribute. Fixed as follows, bootstrap and regtest pending on x86_64-unknown-linux-gnu. Richard. 2013-06-

[PATCH][RFC] Fix PR57656

2013-06-24 Thread Richard Biener
This fixes the miscompile in PR57656 - folding of int t = 1 - (a - b) / c; to int t = (b - a) / c + 1; which introduces intermediate undefined overflow for a == -1 and b == INT_MAX. There seems to be a mix of assumptions of the context negate_expr_p is called in - for example the comments

Re: [ping] [patch 4/5] fix bugs with -fstrict-volatile-bitfields and packed structures

2013-06-24 Thread Sandra Loosemore
On 06/24/2013 06:31 AM, Richard Biener wrote: On Sun, Jun 23, 2013 at 6:17 PM, Sandra Loosemore wrote: On 06/16/2013 01:08 PM, Sandra Loosemore wrote: This part of the patch series fixes problems with bad code being emitted for unaligned bitfield accesses, as reported in PRs 48784, 56341, and

[PATCH] Fix PR57521

2013-06-24 Thread Richard Biener
The following fixes a long-standing bug in tree if-conversion. The transform phase relies on being able to extract edge predicates by simply using the predicate under which its source block is executed. That obviously isn't the correct one if the source block ends in a condition itself. Thus the

Re: [PATCH, libcpp] Do not decrease highest_location if the included file has be included twice.

2013-06-24 Thread Tom Tromey
> "Dehao" == Dehao Chen writes: Dehao> Thanks for helping update the patch. The new patch passed all Dehao> regression test and can fix the problem in my huge source file. I Dehao> added ChangeLog entry to the patch. Could any libcpp maintainers help Dehao> check if it is ok for trunk? I'm s

Re: [RS6000] libffi little-endian

2013-06-24 Thread Anthony Green
It's fine with me. Please commit it directly to GCC and I'll put it in the upstream. Thanks! AG - Original Message - From: "David Edelsohn" To: "GCC Patches" , libffi-disc...@sourceware.org, "Alan Modra" Sent: Sunday, June 23, 2013 10:32:44 PM Subject: Re: [RS6000] libffi little-en

Re: [PATCH] Cilk Plus Array Notation for C++

2013-06-24 Thread Jason Merrill
A few more comments: + if (processing_template_decl || !TREE_TYPE (t)) + new_var = build_min_nt_loc (EXPR_LOCATION (t), VAR_DECL, NULL_TREE, + NULL_TREE); Again, we shouldn't be trying to expand array notation during template parsing.

Re: C++ PATCH: Change reference to cxx0x to cxx11

2013-06-24 Thread Jason Merrill
OK, but please also remove the cxx0x enumerator so that uses don't creep in again. Jason

Re: [c++-concepts] code review

2013-06-24 Thread Jason Merrill
On 06/21/2013 08:46 AM, Andrew Sutton wrote: I can move those patches over to git and push the changes in separate branches in addition to the usual submission mechanism. Would that be appropriate? Can I create a bunch of different git branches for small feature sets? Sure, that sounds fine. J

Re: [patch 4/5] fix bugs with -fstrict-volatile-bitfields and packed structures

2013-06-24 Thread Eric Botcazou
> This part of the patch series fixes problems with bad code being emitted > for unaligned bitfield accesses, as reported in PRs 48784, 56341, and > 56997. A secondary goal of this patch was making the bitfield store and > extract code follow similar logic, at least for the parts relating to > -fs

[PATCH, AArch64] Update insv_1.c test for Big Endian

2013-06-24 Thread Ian Bolton
Hi, The insv_1.c test case I added recently was not compatible with big endian. I attempted to fix with #ifdefs but dejagnu thinks all dg directives in a file, regardless of #ifdefs, are applicable, so I had to instead make a new test and add a new effective target to show when each test is suppor

Re: [c++-concepts]: constraint association

2013-06-24 Thread Andrew Sutton
Revisions from previous patch. I've taken constraint_info out of lang_decl_min and made it specific to TEMPLATE_DECLs by saving it as DECL_SIZE_UNIT. It seems to be unused for templates. When I start working on the shorthand notation, I'll do something similar for template parameters and auto decl

Re: C++ PATCH: Change reference to cxx0x to cxx11

2013-06-24 Thread Gabriel Dos Reis
Jason Merrill writes: | OK, but please also remove the cxx0x enumerator so that uses don't | creep in again. Indeed, that was the follow up patch that I'm preparing separately along with another fixlet. -- Gaby

Re: [PATCH, rs6000] power8 patches, patch #8, power8 load fusion + misc.

2013-06-24 Thread Michael Meissner
On Tue, Jun 18, 2013 at 02:30:49PM -0400, David Edelsohn wrote: > On Wed, May 22, 2013 at 4:52 PM, Michael Meissner > wrote: > > > 2013-05-22 Michael Meissner > > > > * config/rs6000/predicates.md (fusion_gpr_addis): New predicates > > to support power8 load fusion. > >

Re: [PATCH] Change the badness computation to ensure no integer-underflow

2013-06-24 Thread Dehao Chen
Hi, Richard, I've updated the patch (as attached) to use sreal to compute badness. Thanks, Dehao On Mon, Jun 24, 2013 at 5:41 AM, Richard Biener wrote: > On Sat, Jun 22, 2013 at 2:59 AM, Dehao Chen wrote: >> This patch prevents integer-underflow of badness computation in ipa-inline. >> >> Boot

Re: [c++-concepts]: constraint association

2013-06-24 Thread Gabriel Dos Reis
Andrew Sutton writes: | Revisions from previous patch. | | I've taken constraint_info out of lang_decl_min and made it specific | to TEMPLATE_DECLs by saving it as DECL_SIZE_UNIT. It seems to be | unused for templates. When I start working on the shorthand notation, | I'll do something similar f

Re: [Patch, Fortran] Print floating-point exception status after STOP/ERROR STOP

2013-06-24 Thread Eric Botcazou
> Eric, Gerald: Can you confirm that it now works on both FreeBSD and Solaris? It works fine on Solaris, thanks! > Eric: Should one (conditionally) include on Solaris? I > am asking because LIBGFOR_CHECK_FPSETMASK in acinclude.m4 uses that > include file during configure - but libgfortran.h (or

Re: [gomp4] Some progress on #pragma omp simd

2013-06-24 Thread Jakub Jelinek
On Tue, Jun 18, 2013 at 02:15:55PM -0500, Aldy Hernandez wrote: > >Please move simduid after force_vect, so that it is better packed. > > Fixed. > > I also rewrote the builtins to use the internal function doo-dah as > previously suggested. > > Let me know if this is fine with y'all and you (Jak

Re: [PATCH, rs6000] power8 patches, patch #8, power8 load fusion + misc.

2013-06-24 Thread David Edelsohn
On Mon, Jun 24, 2013 at 12:31 PM, Michael Meissner wrote: >> This really should have been a separate patch. > > Yes, you are right. I can separate it to be a separate patch if desired. The > last I checked, there were still problems in moving to use LRA. It would be > nice if we could get the

Re: [Patch, Fortran] Print floating-point exception status after STOP/ERROR STOP

2013-06-24 Thread Gerald Pfeifer
On Mon, 24 Jun 2013, Tobias Burnus wrote: I have now committed (Rev. 200360) the attached patch. (Compared to the draft patch, with a missing "," added in AC_CHECK_TYPES). Eric, Gerald: Can you confirm that it now works on both FreeBSD and Solaris? I can confirm FreeBSD 8.x and 10.x. Thanks,

[wwwdocs] Release note for x86 intrinsics usability

2013-06-24 Thread Sriraman Tallam
Hi, I recently committed a patch: http://gcc.gnu.org/ml/gcc-patches/2013-06/msg01349.html to allow x86 intrinsics to be called from functions with appropriate target attributes without having to compile the entire file with -mxxx. I have added a release note for this. Please see if this is ok

Re: [wwwdocs] Release note for x86 intrinsics usability

2013-06-24 Thread Gerald Pfeifer
On Mon, 24 Jun 2013, Sriraman Tallam wrote: > IA-32/x86-64 ^ Ahem, no. :-) Please use id="x86" instead. > > It is now possible to call x86 intrinsics from select functions in > a file that are marked with the appropriate target attribute without > having to compile

Re: [wwwdocs] Release note for x86 intrinsics usability

2013-06-24 Thread Sriraman Tallam
On Mon, Jun 24, 2013 at 2:55 PM, Gerald Pfeifer wrote: > On Mon, 24 Jun 2013, Sriraman Tallam wrote: >> IA-32/x86-64 > ^ > Ahem, no. :-) Please use id="x86" instead. > >> >> It is now possible to call x86 intrinsics from select functions in >> a file that are marked with

[PATCH, PR 57670] Do not turn member pointers to builtin_unreachable

2013-06-24 Thread Martin Jambor
Hi, I have made a mistake when I decided to redirect member-pointer calls to builtin_unreachable because I wrongly thought there are two calls, one for the VMT lookup and other for non-virtual members and thought only the second got redirected. However, even though there are two different lookups

Re: [PATCH] Redirect calls to non-functions to builtin_unreachable

2013-06-24 Thread Martin Jambor
Hi, On Thu, Jun 20, 2013 at 05:46:28PM +0200, Martin Jambor wrote: > On Thu, Jun 20, 2013 at 03:47:11PM +0100, Marcus Shawcroft wrote: > > Hi, I've been looking at an issue in mysql compilation which appears > > to be due to this patch. > > > > On 10 May 2013 18:27, Martin Jambor wrote: > > > H

Go patch committed: Implement method values

2013-06-24 Thread Ian Lance Taylor
Go 1.1 introduced a new language concept: method values. If a value v is of some type that implements method M, you can now write v.M and get a function f. Calling f with some arguments is exactly like calling v.M with those same arguments. In other words, v.M keeps a copy of v and uses in later

Re: [PATCH] Change the badness computation to ensure no integer-underflow

2013-06-24 Thread Dehao Chen
The original patch has some flaw. The new patch is attached. Bootstrapped and passed regression tests. Thanks, Dehao On Mon, Jun 24, 2013 at 9:44 AM, Dehao Chen wrote: > Hi, Richard, > > I've updated the patch (as attached) to use sreal to compute badness. > > Thanks, > Dehao > > On Mon, Jun 24,

Go patch committed: Check _ constant declarations

2013-06-24 Thread Ian Lance Taylor
This patch to the Go frontend, from Rémy Oudompheng, checks the constants named _ are valid. Such constants are discarded but the values should still be checked. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline and 4.8 branch. Ian diff -r 49a130a849da go/gog

[v3] libstdc++/57704

2013-06-24 Thread Paolo Carlini
Hi, this is the LWG 467 bit about char_traits::lt: since the member is not used elsewhere in the library as an implementation detail and the symbol is not exported, I think we can just unconditionally apply the tweak and be done. Tested x86_64-linux. Thanks, Paolo.

Re: [RS6000] libffi little-endian

2013-06-24 Thread Alan Modra
On Mon, Jun 24, 2013 at 11:12:03AM -0400, Anthony Green wrote: > It's fine with me. Please commit it directly to GCC and I'll put it in the > upstream. Thanks! Committed revision 200383. (and 200384 to 4.8 branch.) -- Alan Modra Australia Development Lab, IBM

[google/gcc-4_8] Port -Wreal-conversion warning

2013-06-24 Thread Sharad Singhai
Hi, This patch forward ports the -Wreal-conversion warning to google/gcc-4_8 branch (google ref 39133-p2). I tweaked the patch a little bit to avoid printing duplicate warnings when both -Wconversion and -Wreal-conversion are specified. Also, I trimmed the test case to avoid testing for integer-to

Re: [PATCH, PR 57670] Do not turn member pointers to builtin_unreachable

2013-06-24 Thread Jan Hubicka
> Hi, > > I have made a mistake when I decided to redirect member-pointer calls > to builtin_unreachable because I wrongly thought there are two calls, > one for the VMT lookup and other for non-virtual members and thought > only the second got redirected. However, even though there are two > dif

Re: [google/gcc-4_8] Port -Wreal-conversion warning

2013-06-24 Thread Xinliang David Li
To avoid printing twice, can you just do opt_type = (warn_conversion ? OPT_Wconversion : OPT_Wreal_conversion); warning_at (loc, opt_type, ...); David On Mon, Jun 24, 2013 at 6:08 PM, Sharad Singhai wrote: > Hi, > > This patch forward ports the -Wreal-conversion warning to > google/gcc-4_8 bran

Re: [google/gcc-4_8] Port -Wreal-conversion warning

2013-06-24 Thread Sharad Singhai
On Mon, Jun 24, 2013 at 9:14 PM, Xinliang David Li wrote: > To avoid printing twice, can you just do > > opt_type = (warn_conversion ? OPT_Wconversion : OPT_Wreal_conversion); > warning_at (loc, opt_type, ...); Thanks for the suggestion. I have updated the enclosed patch and retested. Okay for go

Re: [wwwdocs] Release note for x86 intrinsics usability

2013-06-24 Thread Xinliang David Li
Perhaps provide a tiny example showing the change (user level) before and after? David On Mon, Jun 24, 2013 at 2:55 PM, Gerald Pfeifer wrote: > On Mon, 24 Jun 2013, Sriraman Tallam wrote: >> IA-32/x86-64 > ^ > Ahem, no. :-) Please use id="x86" instead. > >> >> It is now poss

Re: [google/gcc-4_8] Port -Wreal-conversion warning

2013-06-24 Thread Xinliang David Li
ok. David On Mon, Jun 24, 2013 at 10:03 PM, Sharad Singhai wrote: > On Mon, Jun 24, 2013 at 9:14 PM, Xinliang David Li wrote: >> To avoid printing twice, can you just do >> >> opt_type = (warn_conversion ? OPT_Wconversion : OPT_Wreal_conversion); >> warning_at (loc, opt_type, ...); > > Thanks f

[PING^3] Nios II port

2013-06-24 Thread Chung-Lin Tang
Ping x 3. On 13/6/18 下午4:38, Chung-Lin Tang wrote: > On 13/6/18 上午3:05, Sandra Loosemore wrote: >> > Ping? I think these are the most recent versions of the unreviewed >> > patches in the series: >> > >> > http://gcc.gnu.org/ml/gcc-patches/2013-06/msg00287.html >> > http://gcc.gnu.org/ml/gcc-pat