Re: [tsan] Instrument atomics

2012-11-26 Thread Dmitry Vyukov
On Sat, Nov 24, 2012 at 12:58 PM, Dmitry Vyukov wrote: >>> Ok. A slight problem then is that where the tsan pass sits right now, there >>> is no easy way to find out if the builtin call will be expanded inline or >>> not, so (similar for asan), if we instrument them in the pass, it might be >>> i

Re: [PATCH] Section anchors and thread-local storage

2012-11-26 Thread Richard Sandiford
David Edelsohn writes: > I have been working to enable native thread-local storage on AIX. One > problem I encountered is the AIX assembler has difficulty with the > anchor symbol for TLS CSECTs. While the section anchors machinery > uses a separate pool for TLS entries, should section anchor blo

Re: [tsan] Instrument atomics

2012-11-26 Thread Jakub Jelinek
On Mon, Nov 26, 2012 at 12:17:44PM +0400, Dmitry Vyukov wrote: > On Sat, Nov 24, 2012 at 12:58 PM, Dmitry Vyukov wrote: > >>> Ok. A slight problem then is that where the tsan pass sits right now, > >>> there > >>> is no easy way to find out if the builtin call will be expanded inline or > >>> no

[patch] Re: MULTIARCH_DIRNAME in gcc/config/rs6000/t-linux doesn't work

2012-11-26 Thread Matthias Klose
Am 26.11.2012 09:50, schrieb Jan-Benedict Glaw: > The ifeq in this new makefile fragment doesn't work due to unbalanced > brackets. Fixed, and committing as obvious. Sorry, apparently I missed testing the non-multilib'd configuration. Matthias 2012-11-26 Matthias Klose * config/rs6000/t-l

Re: [Patch,testsuite] ad PR52641: More fixes for not-so-common targets

2012-11-26 Thread Georg-Johann Lay
Hans-Peter Nilsson wrote: > On Fri, 23 Nov 2012, Georg-Johann Lay wrote: >> Here are some more fixes for 16-bit int and similar. > >> * gcc.c-torture/execute/20120919-1.x: New file (int32plus). > > No, you should be able to use dg-directives in the main file these days. > (The .x files are o

Re: Minor fixes to ipa-inline-analysis.c

2012-11-26 Thread Jan Hubicka
> > @@ -692,12 +692,14 @@ account_size_time (struct inline_summary > > found = true; > > break; > >} > > - if (i == 32) > > + if (i == 256) > > Shouldn't this be a --param? You are probably right. ipa-inline-analysis has few hard wired constants in it but mostly to al

Re: [PATCH][AARCH64] Fix the name mangling of va_list

2012-11-26 Thread Marcus Shawcroft
On 21/11/12 14:31, Yufeng Zhang wrote: Hi, This patch updates the AArch64 port to mangle __va_list as it is in namespace std in C++. This is specified in the AArch64 AAPCS64 ABI doc. OK for the trunk? Thanks, Yufeng gcc/ChangeLog 2012-11-21 Yufeng Zhang * config/aarch64/aarch6

Re: [tsan] Instrument atomics

2012-11-26 Thread Dmitry Vyukov
On Sat, Nov 24, 2012 at 3:06 PM, Dmitry Vyukov wrote: > > On Fri, Nov 23, 2012 at 8:39 PM, Jakub Jelinek wrote: > > On Fri, Nov 23, 2012 at 08:10:39PM +0400, Dmitry Vyukov wrote: > >> > This patch attempts to instrument __atomic_* and __sync_* builtins. > >> > Unfortunately for none of the builti

Re: [Patch, Fortran, OOP] PR 54881: [4.8 Regression] [OOP] ICE in fold_convert_loc, at fold-const.c:2016

2012-11-26 Thread Janus Weil
2012/11/25 Mikael Morin : > Le 11/10/2012 23:49, Janus Weil a écrit : > >> Hi all, >> >> here is an OOP patch for the above PR, which has two disconnected parts: >> >> 1) It fixes a problem with ASSOCIATED, when it is fed a CLASS-valued >> function as argument (i.e. the ICE in the bug title). This

Re: [Patch, Fortran] PR 54997: -Wunused-function gives false warnings for procedures passed as actual argument

2012-11-26 Thread Janus Weil
2012/11/25 Mikael Morin : > Le 22/10/2012 16:49, Janus Weil a écrit : > >> Minor update to the patch: It now also sets TREE_USED for entry >> masters in order to avoid bogus warnings for procedures with ENTRY >> (cf. comment 6 in the PR, which like comment 0 is a 4.8 regression). >> >> Still regtes

Re: [Patch,testsuite] ad PR52641: More fixes for not-so-common targets

2012-11-26 Thread Hans-Peter Nilsson
On Mon, 26 Nov 2012, Georg-Johann Lay wrote: > Hans-Peter Nilsson wrote: > > On Fri, 23 Nov 2012, Georg-Johann Lay wrote: > >> Here are some more fixes for 16-bit int and similar. > > > >>* gcc.c-torture/execute/20120919-1.x: New file (int32plus). > > > > No, you should be able to use dg-direct

Re: [Patch, Fortran] PR 54997: -Wunused-function gives false warnings for procedures passed as actual argument

2012-11-26 Thread Mikael Morin
Le 26/11/2012 12:21, Janus Weil a écrit : 2012/11/25 Mikael Morin: Le 22/10/2012 16:49, Janus Weil a écrit : Minor update to the patch: It now also sets TREE_USED for entry masters in order to avoid bogus warnings for procedures with ENTRY (cf. comment 6 in the PR, which like comment 0 is a 4.

Tidy up comments about sizetypes

2012-11-26 Thread Eric Botcazou
It's a couple of obsolete comments about the sign-extendness of sizetypes plus some "size type" -> "sizetype" adjustments. No functional changes. Tested on x86-64/Linux, applied on the mainline as obvious. 2012-11-26 Eric Botcazou * fold-const.c (const_binop): Adjust comment.

[PATCH] Remove redundant variable in hash_set

2012-11-26 Thread Marek Polacek
I don't see why we need the `hash' variable, when we can use the `regno' variable directly. Regtested/bootstrapped on x86_64-linux. Ok for trunk? 2012-11-26 Marek Polacek * cprop.c (hash_set): Remove hash variable. Use regno variable directly. --- gcc/cprop.c.mp 2012-11

Re: [RFA/4.7/ARM] Backport arm-*-linux-gnueabihf triplet support to 4.7

2012-11-26 Thread Richard Biener
On Tue, 20 Nov 2012, Matthew Gretton-Dann wrote: > All, > > This patch backports Matthais Klose's arm*-*-linux-gnueabihf triplet > support patch of 2012-10-15 to 4.7. > > The backport was not clean as 4.8 has obsoleted various arm*-*-* > triplets which are valid in 4.7. > > I have tested this c

Patch ping

2012-11-26 Thread Jakub Jelinek
- PR55137 fold reassociation fix http://gcc.gnu.org/ml/gcc-patches/2012-11/msg00636.html (al

Re: [Patch AArch64] Add support for TARGET_BUILTIN_DECL

2012-11-26 Thread Marcus Shawcroft
On 21/11/12 15:05, James Greenhalgh wrote: Hi, This patch wires up support for TARGET_BUILTIN_DECL in the AArch64 backend. Is this OK to commit? Thanks, James Greenhalgh --- gcc/ 2012-11-21 James Greenhalgh * config/aarch64/aarch64-builtins.c (aarch64_builtin_decls): New.

Re: [PATCH, generic] Fix for define_subst

2012-11-26 Thread Kirill Yukhin
Guys, this is a ping. Thanks, K On Thu, Nov 22, 2012 at 9:36 PM, Kirill Yukhin wrote: > Hello, > Here is copy-and-paste from issue raised by Ian (in the bottom). > > Fix is attached. > ChangeLog entry: > 2012-11-22 Michael Zolotukhin > > * gensupport.c (add_c_test): Check if expr isn'

Re: [patch] reorg.c janitor patch 3: remove rare_destination()

2012-11-26 Thread Jeff Law
On 11/25/2012 11:30 AM, Richard Sandiford wrote: FWIW, the vast majority of condjumps have a REG_BR_PROB note so the part of mostly_true_jump that handles the jumps without a REG_BR_PROB note is itself a rare_destination :-) GCC is very careful about preserving the notes. Perhaps all that code sh

Re: [PATCH] Remove unused DELAY_SLOTS_FOR_EPILOGUE target macro

2012-11-26 Thread Jeff Law
On 11/24/2012 03:08 PM, Steven Bosscher wrote: Hello, The DELAY_SLOTS_FOR_EPILOGUE target macro, and the related ELIGIBLE_FOR_EPILOGUE_DELAY macro, are unused. The attached patch removes them. OK for trunk? OK, though this arguably shouldn't be going in during stage3. But given those are total

Typo fix in loop-invariant.c

2012-11-26 Thread Steven Bosscher
Will commit as obvious somewhen... * loop-invariant.c (heck_invariant_table_size): Take sizeof of the right type. Index: loop-invariant.c === --- loop-invariant.c(revision 193814) +++ loop-invariant.c(working copy) @@

Re: [PATCH] Remove redundant variable in hash_set

2012-11-26 Thread Richard Biener
On Mon, Nov 26, 2012 at 1:09 PM, Marek Polacek wrote: > I don't see why we need the `hash' variable, when we can use the > `regno' variable directly. Regtested/bootstrapped on x86_64-linux. > Ok for trunk? Ok. Thanks, Richard. > 2012-11-26 Marek Polacek > > * cprop.c (hash_set): Rem

[PATCH] Don't bypass blocks with multiple latch edges (PR middle-end/54838)

2012-11-26 Thread Marek Polacek
In this PR, for the C testcase, in .cse1 we have: ENTRY | | 2 | | + 4 --+ |/ \ | | / \ | | 6 5| | /\ |\

Re: Fix twolf -funroll-loops -O3 miscompilation (a semi-latent web.c bug)

2012-11-26 Thread Dominique Dhumieres
> Or rather this one. Same hammer, different color. It turns out that > the rtlanal.c change caused problems, so I've got to use a home-brewn > equivalent of remove_reg_equal_equiv_notes_for_regno... This does not fix pr55006 on x86_64-apple-darwin10;-(while the patch in http://gcc.gnu.org/ml/gcc-

[PATCH][ARM] AArch32 vmaxnm, vminnm support

2012-11-26 Thread Kyrylo Tkachov
Hi all, This patch adds support for the AArch32 vmaxnm and vminnm VFP instructions in that can be used to implement the smax[sf,df]3 and smin[sf,df]3 RTL patterns. The patterns are only used by gcc when unsafe math optimisations are turned on. Two new values for the type attribute are introduced: f

Re: [RFA 6/8] validate_failures.py: remove pass/fail from GetBuildData

2012-11-26 Thread Diego Novillo
On Sat, Nov 24, 2012 at 5:54 PM, Doug Evans wrote: > 2012-11-24 Doug Evans > > * testsuite-management/validate_failures.py: Remove pass/fail > indicator from > result of GetBuildData. OK. Diego.

Re: [PATCH] Use working set profile info to determine hotness (issue6852069)

2012-11-26 Thread Teresa Johnson
Thanks for the fixes and commit! Teresa On Fri, Nov 23, 2012 at 6:13 AM, Jan Hubicka wrote: >> Sounds good. I am travelling the rest of the week so I'll get the revised >> patch ready by Mon. Thanks, Teresa > Hi, > I updated the patch, so we make progress on the heuristic retunning. There > was

Re: [PATCH] Fix make_range_step with -fwrapv (PR tree-optimization/55236)

2012-11-26 Thread Richard Biener
On Thu, Nov 8, 2012 at 9:04 PM, Jakub Jelinek wrote: > Hi! > > With -fwrapv the range test optimization miscompiles the following testcase > (both inter-bb version in 4.8+ in first function and the pure fold-const.c > one since 3.4). The problem is that with -fwrapv and signed type > -x in [-,b]

Re: [PATCH] Reset source location for instructions moved out of its original residing basic block

2012-11-26 Thread Richard Biener
On Sun, Nov 4, 2012 at 11:26 PM, Alexandre Oliva wrote: > On Nov 1, 2012, Dehao Chen wrote: > >> I see your point. How about we guard these changes with a flag, say >> -gless-jumpy > > The right (DWARF-expected) approach to avoid this sortof jumpiness is to > teach GCC to emit .locs with is_stmt

Re: [PATCH] Allocate extra 16 bytes for -fsanitize=address

2012-11-26 Thread H.J. Lu
On Fri, Nov 23, 2012 at 11:50 AM, Jakub Jelinek wrote: > On Fri, Nov 23, 2012 at 11:33:37AM -0800, H.J. Lu wrote: >> 2012-11-21 H.J. Lu >> >> PR bootstrap/55380 >> * charset.c (_cpp_convert_input): Clear CPP_PAD_BUFFER_SIZE >> bytes if CLEAR_CPP_PAD_BUFFER isn't 0. Allocate e

Re: GCC 4.8.0 Status Report (2012-10-29), Stage 1 to end soon

2012-11-26 Thread Richard Biener
On Mon, Nov 5, 2012 at 2:59 PM, Kenneth Zadeck wrote: > > On 11/04/2012 11:54 AM, Richard Biener wrote: >> >> On Thu, Nov 1, 2012 at 2:10 PM, Richard Sandiford >> wrote: >>> >>> Kenneth Zadeck writes: I would like you to respond to at least point 1 of this email. In it there is

Re: [PATCH] gcc-{ar,nm,ranlib}: Find binutils binaries relative to self

2012-11-26 Thread Richard Biener
On Wed, Nov 7, 2012 at 10:51 PM, Meador Inge wrote: > Ping ^ 4. Ok. Thanks, Richard. > On 10/29/2012 10:46 AM, Meador Inge wrote: >> Ping ^ 3. >> >> On 10/18/2012 10:30 AM, Meador Inge wrote: >>> Ping ^ 2. >>> >>> On 10/09/2012 09:44 PM, Meador Inge wrote: Ping. On 10/04/2012 03:

Re: [PATCH] Fix substitute_and_fold ICE (PR tree-optimization/55331)

2012-11-26 Thread Richard Biener
On Thu, Nov 15, 2012 at 9:09 PM, Jakub Jelinek wrote: > Hi! > > On the following testcase substitute_and_fold ICEs because memmove > of length 1 on an empty class is optimized away, and this function wasn't > prepared to handle that. > > Fixed thusly, bootstrapped/regtested on x86_64-linux and i68

Re: [PATCH] Fix substitute_and_fold ICE (PR tree-optimization/55331)

2012-11-26 Thread Jakub Jelinek
On Mon, Nov 26, 2012 at 04:24:41PM +0100, Richard Biener wrote: > On Thu, Nov 15, 2012 at 9:09 PM, Jakub Jelinek wrote: > > On the following testcase substitute_and_fold ICEs because memmove > > of length 1 on an empty class is optimized away, and this function wasn't > > prepared to handle that.

Re: [PATCH] Cleanup last_location and update input_location in ipa_prop

2012-11-26 Thread Richard Biener
On Thu, Nov 8, 2012 at 6:39 PM, Dehao Chen wrote: > ping... The emit-rtl.c hunk is ok. I'm questioning the ipa-prop.c hunk though - what looks at input_location (nothing outside of the frontend should, really). Thanks, Richard. > > On Mon, Nov 5, 2012 at 5:20 PM, Dehao Chen wrote: >> >> Hi, >

Re: [PATCH] Do not dump location for compare_debug

2012-11-26 Thread Richard Biener
On Thu, Nov 1, 2012 at 1:26 AM, Dehao Chen wrote: > Hi, > > When -fcompare_debug is used, what we really want to do is to compare > instructions between the -g version and -gtoggle version. However, > current dump file still contains the source line in its rtl dump. This > patch changes to only du

Re: patch to fix constant math - second small patch

2012-11-26 Thread Richard Biener
On Thu, Nov 8, 2012 at 7:13 PM, Kenneth Zadeck wrote: > I have added the proper doc. OK to commit? Ok. Thanks, Richard. > Kenny > > > > On 10/08/2012 05:06 AM, Richard Guenther wrote: >> >> On Sat, Oct 6, 2012 at 12:48 AM, Kenneth Zadeck >> wrote: >>> >>> This patch adds machinery to genmodes

Re: Tighten checking of vector comparisons

2012-11-26 Thread Richard Biener
On Thu, Nov 22, 2012 at 11:59 AM, Marc Glisse wrote: > (I forgot to send this at the time) > > > On Sun, 4 Nov 2012, Richard Biener wrote: > >>> - else if (!INTEGRAL_TYPE_P (type) && TREE_CODE (type) != >>> VECTOR_TYPE) >>> + else if (!INTEGRAL_TYPE_P (type) && !VOID_TYPE_P (type)

Re: [PATCH] Update source location for PRE inserted stmt

2012-11-26 Thread Dehao Chen
On Sun, Nov 25, 2012 at 11:37 AM, Xinliang David Li wrote: > On Sun, Nov 25, 2012 at 4:40 AM, Richard Biener > wrote: >> On Thu, Nov 15, 2012 at 5:46 PM, Eric Botcazou wrote: But UNKNOWN_LOCATION is effectively wrong as well. If other optimizations move the statements above the insert

[C++ Patch / RFC] PR 51242

2012-11-26 Thread Paolo Carlini
Hi, this PR is about the rejection (in C++11 mode of course) of: enum class MyEnum { A = 1 }; struct MyClass { MyEnum Field1 : 3; }; whereas the corresponding unscoped enum case already works. As noticed by Jon, it seems that the below straightforward patchlet is enough to solve the probl

Re: Fix twolf -funroll-loops -O3 miscompilation (a semi-latent web.c bug)

2012-11-26 Thread Steven Bosscher
On Mon, Nov 26, 2012 at 3:38 PM, Dominique Dhumieres wrote: >> Or rather this one. Same hammer, different color. It turns out that >> the rtlanal.c change caused problems, so I've got to use a home-brewn >> equivalent of remove_reg_equal_equiv_notes_for_regno... > > This does not fix pr55006 on x8

Re: [patch] Rework RTL CFG graph dumping to dump DOT format

2012-11-26 Thread Richard Biener
On Fri, Nov 23, 2012 at 10:46 AM, Steven Bosscher wrote: > Hello, > > The graph.[ch] code to dump the CFG for viewing with VCG is quite > broken and hasn't been updated to follow the advances in the CFG > infrastructure. > > The attached patch is the first in a series of patches I have planned > t

Re: [PATCH] Cleanup last_location and update input_location in ipa_prop

2012-11-26 Thread Dehao Chen
On Mon, Nov 26, 2012 at 7:28 AM, Richard Biener wrote: > On Thu, Nov 8, 2012 at 6:39 PM, Dehao Chen wrote: >> ping... > > The emit-rtl.c hunk is ok. I'm questioning the ipa-prop.c hunk though - what > looks at input_location (nothing outside of the frontend should, really). ipa_modify_call_argu

Re: [patch] Rework RTL CFG graph dumping to dump DOT format

2012-11-26 Thread Steven Bosscher
On Mon, Nov 26, 2012 at 4:46 PM, Richard Biener wrote: > On Fri, Nov 23, 2012 at 10:46 AM, Steven Bosscher wrote: >> Hello, >> >> The graph.[ch] code to dump the CFG for viewing with VCG is quite >> broken and hasn't been updated to follow the advances in the CFG >> infrastructure. >> >> The attach

Re: Fix PR 53743 and other -freorder-blocks-and-partition failures (issue6823047)

2012-11-26 Thread Teresa Johnson
Ping. Teresa On Thu, Nov 15, 2012 at 12:10 PM, Teresa Johnson wrote: > Revised patch that fixes failures encountered when enabling > -freorder-blocks-and-partition, including the failure reported in PR 53743. > > This includes new verification code to ensure no cold blocks dominate hot > blocks c

Re: GCC 4.8.0 Status Report (2012-10-29), Stage 1 to end soon

2012-11-26 Thread Kenneth Zadeck
On 11/26/2012 10:03 AM, Richard Biener wrote: On Mon, Nov 5, 2012 at 2:59 PM, Kenneth Zadeck wrote: On 11/04/2012 11:54 AM, Richard Biener wrote: On Thu, Nov 1, 2012 at 2:10 PM, Richard Sandiford wrote: Kenneth Zadeck writes: I would like you to respond to at least point 1 of this email.

Re: [PATCH] Cleanup last_location and update input_location in ipa_prop

2012-11-26 Thread Richard Biener
On Mon, Nov 26, 2012 at 4:54 PM, Dehao Chen wrote: > On Mon, Nov 26, 2012 at 7:28 AM, Richard Biener > wrote: >> On Thu, Nov 8, 2012 at 6:39 PM, Dehao Chen wrote: >>> ping... >> >> The emit-rtl.c hunk is ok. I'm questioning the ipa-prop.c hunk though - what >> looks at input_location (nothing o

Re: [patch] Rework RTL CFG graph dumping to dump DOT format

2012-11-26 Thread Richard Biener
On Mon, Nov 26, 2012 at 4:53 PM, Steven Bosscher wrote: > On Mon, Nov 26, 2012 at 4:46 PM, Richard Biener wrote: >> On Fri, Nov 23, 2012 at 10:46 AM, Steven Bosscher wrote: >>> Hello, >>> >>> The graph.[ch] code to dump the CFG for viewing with VCG is quite >>> broken and hasn't been updated to fo

Re: Fix PR 53743 and other -freorder-blocks-and-partition failures (issue6823047)

2012-11-26 Thread Christophe Lyon
Hi, I have tested your patch on Spec2000 on ARM, and I can still see several failures caused by: "error: fallthru edge crosses section boundary", including the case described in PR55121. On 26 November 2012 16:55, Teresa Johnson wrote: > Ping. > Teresa > > On Thu, Nov 15, 2012 at 12:10 PM, Teres

Re: GCC 4.8.0 Status Report (2012-10-29), Stage 1 to end soon

2012-11-26 Thread Richard Biener
On Mon, Nov 26, 2012 at 5:03 PM, Kenneth Zadeck wrote: > On 11/26/2012 10:03 AM, Richard Biener wrote: >> >> On Mon, Nov 5, 2012 at 2:59 PM, Kenneth Zadeck >> wrote: >>> >>> On 11/04/2012 11:54 AM, Richard Biener wrote: On Thu, Nov 1, 2012 at 2:10 PM, Richard Sandiford wrote:

[Patch, Fortran] PR5469

2012-11-26 Thread Tobias Burnus
l_push_char allocates memory which is freed with free_line. However, currently, the memory is not always freed when calling generate_error. If one aborts, that's fine. However, generate_error can also set the iostat variable. Thus, one should ensure that the memory is always freed. I wouldn't

[PATCH][AARCH64] Refactor constant generation

2012-11-26 Thread Sofiane Naci
Hi, Constant building in the AArch64 backend spits out assembly code, which affects scheduling of the generated code. This patch rewrites the code to use RTL patterns. A full aarch64-none-elf regression run shows no issues. Thanks Sofiane - ChangeLog: 2012-11-26 Sofiane Naci

RFA: Enable both ld and gold in GCC 4.8

2012-11-26 Thread H.J. Lu
Hi, There is a patch to enable both ld and gold in GCC: http://gcc.gnu.org/ml/gcc-patches/2011-06/msg02076.html and Diego asked if there is "anything in particular blocking this patch in trunk": http://gcc.gnu.org/ml/gcc-patches/2011-06/msg02121.html I'd like to see it in GCC 4.8. Thanks. -

Re: [PATCH] Section anchors and thread-local storage

2012-11-26 Thread David Edelsohn
On Mon, Nov 26, 2012 at 3:26 AM, Richard Sandiford wrote: > David Edelsohn writes: >> I have been working to enable native thread-local storage on AIX. One >> problem I encountered is the AIX assembler has difficulty with the >> anchor symbol for TLS CSECTs. While the section anchors machinery >

Re: [tsan] Instrument atomics

2012-11-26 Thread Xinliang David Li
On Mon, Nov 26, 2012 at 12:35 AM, Jakub Jelinek wrote: > On Mon, Nov 26, 2012 at 12:17:44PM +0400, Dmitry Vyukov wrote: >> On Sat, Nov 24, 2012 at 12:58 PM, Dmitry Vyukov wrote: >> >>> Ok. A slight problem then is that where the tsan pass sits right now, >> >>> there >> >>> is no easy way to fi

Re: [PATCH] Cleanup last_location and update input_location in ipa_prop

2012-11-26 Thread Dehao Chen
On Mon, Nov 26, 2012 at 8:10 AM, Richard Biener wrote: > On Mon, Nov 26, 2012 at 4:54 PM, Dehao Chen wrote: >> On Mon, Nov 26, 2012 at 7:28 AM, Richard Biener >> wrote: >>> On Thu, Nov 8, 2012 at 6:39 PM, Dehao Chen wrote: ping... >>> >>> The emit-rtl.c hunk is ok. I'm questioning the ipa

Re: PR 55438: Incorrect use of BIGGEST_ALIGNMENT

2012-11-26 Thread Eric Botcazou
> In http://gcc.gnu.org/ml/gcc-patches/2012-11/msg00257.html I said: > > get_best_mode has various checks to decide what counts as an acceptable > bitfield mode. It actually has two copies of them, with slightly > different alignment checks: > > MIN (unit, BIGGEST_ALIGNMENT) > align > >

Re: [patch] reorg.c janitor patch 2: handle DEBUG_INSN

2012-11-26 Thread Eric Botcazou
> If that is true, then why are there so many post var-tracking passes > using NONDEBUG_INSN_P and/or looking for the DEBUG_INSN code? See e.g. > shorten_branches, reorg.c, various machine reorgs, etc. They are very likely overzealous. > For example from reorg.c:redundant_insn() in the loop "/* S

Re: [tsan] Instrument atomics

2012-11-26 Thread Dmitry Vyukov
On Mon, Nov 26, 2012 at 9:07 PM, Xinliang David Li wrote: >>> >>> Ok. A slight problem then is that where the tsan pass sits right now, >>> >>> there >>> >>> is no easy way to find out if the builtin call will be expanded inline >>> >>> or >>> >>> not, so (similar for asan), if we instrument th

patch to fix a test in PR55277

2012-11-26 Thread Vladimir Makarov
The following patch fixes the second test case in http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55277 As for the first case, I don' think it will be fixed soon as I have more urgent PRs. The patch was successfully tested and bootstrapped on x86/x86-64. Committed as rev. 193824. 2012-

[PING^2] PR 54805: __gthread_tsd* in vxlib-tls.c

2012-11-26 Thread rbmj
On 11/13/2012 10:22 PM, rbmj wrote: On 11/5/2012 12:57 PM, rbmj wrote: This removes warnings about implicit declarations and fixes one of the function calls in vxlib-tls.c for vxworks targets. I got the old prototypes from http://gcc.gnu.org/ml/gcc-patches/2005-08/msg01314.html See bug for fur

Re: PR 55438: Incorrect use of BIGGEST_ALIGNMENT

2012-11-26 Thread Richard Sandiford
Eric Botcazou writes: >> In http://gcc.gnu.org/ml/gcc-patches/2012-11/msg00257.html I said: >> >> get_best_mode has various checks to decide what counts as an acceptable >> bitfield mode. It actually has two copies of them, with slightly >> different alignment checks: >> >> MIN (unit, B

Re: [patch] reorg.c janitor patch 2: handle DEBUG_INSN

2012-11-26 Thread Richard Sandiford
Eric Botcazou writes: >> If that is true, then why are there so many post var-tracking passes >> using NONDEBUG_INSN_P and/or looking for the DEBUG_INSN code? See e.g. >> shorten_branches, reorg.c, various machine reorgs, etc. > > They are very likely overzealous. > >> For example from reorg.c:red

[RFC] Wrong register numbers in .dwarf_frame on Linux/PowerPC

2012-11-26 Thread Ulrich Weigand
Hello, I noticed what appears to be a long-standing bug in generating .dwarf_frame sections with GCC on Linux on PowerPC. It had been my understanding that .dwarf_frame is supposed to differ from .eh_frame on PowerPC w.r.t. register numbers: .eh_frame should use GCC internal numbers, while .dwarf

Re: [patch] reorg.c janitor patch 2: handle DEBUG_INSN

2012-11-26 Thread Jakub Jelinek
On Mon, Nov 26, 2012 at 07:08:41PM +, Richard Sandiford wrote: > In the long term it would be good to replace dbr_schedule altogether, > but in the medium term I thought we might want to update it so that > it can run before vartracking. var-tracking definitely isn't prepared to handle dbr_sch

Re: [RFC] Wrong register numbers in .dwarf_frame on Linux/PowerPC

2012-11-26 Thread David Edelsohn
On Mon, Nov 26, 2012 at 2:10 PM, Ulrich Weigand wrote: > So I'm wondering where to go from here. I guess we could: > > 1. Bring GCC (and gas) behaviour in compliance with the documented ABI >by removing the #undef DBX_REGISTER_NUMBER and changing gas's >md_reg_eh_frame_to_debug_frame to

Re: [RFC] Wrong register numbers in .dwarf_frame on Linux/PowerPC

2012-11-26 Thread Mark Kettenis
> Date: Mon, 26 Nov 2012 20:10:06 +0100 (CET) > From: "Ulrich Weigand" > > Hello, > > I noticed what appears to be a long-standing bug in generating .dwarf_frame > sections with GCC on Linux on PowerPC. > > ... > > So I'm wondering where to go from here. I guess we could: > > 1. Bring GCC (a

Re: Fix PR 53743 and other -freorder-blocks-and-partition failures (issue6823047)

2012-11-26 Thread Teresa Johnson
) version 4.8.0 20121126 (experimental) (arm-none-linux-gnueabi) compiled by GNU C version 4.4.3, GMP version 4.3.2, MPFR version 2.4.2-p1, MPC version 0.8.1 GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096 GNU C (GCC) version 4.8.0 20121126 (experimental) (arm-none-linux

Re: Fix PR 53743 and other -freorder-blocks-and-partition failures (issue6823047)

2012-11-26 Thread Jack Howarth
er-blocks-and-partition > GNU C (GCC) version 4.8.0 20121126 (experimental) (arm-none-linux-gnueabi) > compiled by GNU C version 4.4.3, GMP version 4.3.2, MPFR version > 2.4.2-p1, MPC version 0.8.1 > GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096 > GNU C (

Re: PR 55438: Incorrect use of BIGGEST_ALIGNMENT

2012-11-26 Thread Eric Botcazou
> OK, how about: > >/* ??? For historical reasons, reject modes that would normally > receive greater alignment, even if unaligned accesses are > acceptable. This has both advantages and disadvantages. Fine with me. > I think here we really do want unit (i.e. the GET

PATCH: lto/55474: global-buffer-overflow in lto-wrapper.c

2012-11-26 Thread H.J. Lu
Hi, OPT_SPECIAL_unknown, OPT_SPECIAL_ignore, OPT_SPECIAL_program_name and OPT_SPECIAL_input_file are special options, which aren't in cl_options. This patch avoids if (!(cl_options[foption->opt_index].flags & CL_TARGET)) on them. This patch skips them. OK to install? Thanks. H.J. --- 2012-1

[Patch, Fortran] PR55475 - fix invalid reads with show_locus

2012-11-26 Thread Tobias Burnus
As found with -fsanitize=address by HJ, but it also shows up with valgrind. The fix for the PR is the change in scanner.c; I think the patch is rather obvious. The change in error.c is due to: if (c1 == c2) c2 += 1; which could lead to an out-of-bounds condition is "c1" is already at th

Re: r193821 - in /trunk/gcc: ChangeLog common.opt d...

2012-11-26 Thread Hans-Peter Nilsson
I don't see this posted on gcc-patches@, but... On Mon, 26 Nov 2012, ste...@gcc.gnu.org wrote: > testsuite/ > * testsuite/gcc.dg/20050811-1.c: Change -dv option to -graph option > to -fdump-rtl-all. > * testsuite/gcc.dg/pr37858.c: Remove -dv option. ...looks like you missed: Ex

[PATCH] Fix the bug of comparing goto_locus to UNKNOWN_LOCATION

2012-11-26 Thread Dehao Chen
Hi, This patch fixes a bug of comparing goto_locus to UNKNOWN_LOCATION when combining basic blocks. Bootstrapped and and passed gcc regression tests. Is it okay for trunk? Thanks, Dehao gcc/ChangeLog: 2012-11-26 Dehao Chen * cfgrtl.c (rtl_merge_blocks): Check with UNKNOWN_LOCATION

Re: [PATCH] Cleanup last_location and update input_location in ipa_prop

2012-11-26 Thread Dehao Chen
The new patch is attached. Bootstrapped and passed gcc regression test. Ok for trunk? Thanks, Dehao gcc/ChangeLog: 2010-11-05 Dehao Chen * ipa-prop.c (ipa_modify_call_arguments): Set loc correctly. * emit-rtl.c (last_location): Remove unused variable. Index: gcc/emit-rtl.c =

Re: r193821 - in /trunk/gcc: ChangeLog common.opt d...

2012-11-26 Thread Steven Bosscher
On Mon, Nov 26, 2012 at 11:38 PM, Hans-Peter Nilsson wrote: > I don't see this posted on gcc-patches@, but... > > On Mon, 26 Nov 2012, wrote: >> testsuite/ >> * testsuite/gcc.dg/20050811-1.c: Change -dv option to -graph option >> to -fdump-rtl-all. >> * testsuite/gcc.dg/pr37858.c

[patch] RFA: slim RTL printing cleanups

2012-11-26 Thread Steven Bosscher
Hello, This patch performs some necessary TLC on slim RTL printing in sched-vis.c: * Make it independent of the scheduler. Actually it already was, mostly. This patch completes the job. * Harmonize dumping templates for INSN_UID. * Always print the pattern of a CALL_INSN. * Don't print "jump"

Re: PR 55438: Incorrect use of BIGGEST_ALIGNMENT

2012-11-26 Thread Andreas Schwab
Eric Botcazou writes: > We could conceivably have an aligned mode with bitsize 32 and alignment 16 > (i.e. STRICT_ALIGNMENT 1 and BIGGEST_ALIGNMENT 16), meaning that we can use > 16-bit aligned 32-bit chunks in this mode. That's actually what m68k traditionally had. Andreas. -- Andreas Schw

[patch] fix libstdc++/55463 calling mem_fn with rvalues

2012-11-26 Thread Jonathan Wakely
PR libstdc++/55463 * include/std/functional (_Mem_fn): Handle rvalue objects. Add noexcept-specifications. * testsuite/20_util/function_objects/mem_fn/55463.cc: New. * testsuite/20_util/bind/ref_neg.cc: Adjust dg-error line numbers. Tested x86_64-linux, comm

[patch] tweak std::bind constraint

2012-11-26 Thread Jonathan Wakely
* include/std/functional (__is_socketlike): Change from class template to alias template. Tested x86_64-linux, committed to trunk. commit 634c004b52c86148e1719e20744504816374dfdb Author: Jonathan Wakely Date: Sun Nov 25 22:01:28 2012 + * include/std/functional (__is

Re: GCC 4.8.0 Status Report (2012-10-29), Stage 1 to end soon

2012-11-26 Thread Kenneth Zadeck
Richard, I spent a good part of the afternoon talking to Mike about this. He is on the c++ standards committee and is a much more seasoned c++ programmer than I am. He convinced me that with a large amount of engineering and c++ "foolishness" that it was indeed possible to get your proposal

[PATCH, libgcc, ARM] __gnu_f2h_internal inaccuracy

2012-11-26 Thread John Tytgat
__gnu_f2h_internal in libgcc converts single-precision floating-point value to half-precision value for ARM. I noticed there is a slight inaccuracy for floating-point values 2^-25 + epsilon (with epsilon > 0 and < 2^-26). Those should all be converted to 2^-24 in half-precision. And this because

Re: [PATCH, libgcc, ARM] __gnu_f2h_internal inaccuracy

2012-11-26 Thread John Tytgat
In message John Tytgat wrote: > [...] Attached patch solves this problem. [...] This time for real. John Tytgat. -- John Tytgat, in his comfy chair at home john.tyt...@aaug.net Index: libgcc/config/arm/fp16.c === --- li

RE: [PATCH, libgcc] Make possible to disable JCR in crtstuff.c

2012-11-26 Thread Joey Ye
Ping^2 > -Original Message- > From: Joey Ye > Sent: Tuesday, November 20, 2012 10:09 > To: gcc-patches@gcc.gnu.org > Cc: Joey Ye > Subject: RE: [PATCH, libgcc] Make possible to disable JCR in crtstuff.c > > Ping, as Joseph Prostko is saying that this patch shall solve the same > problem h

Re: [PATCH, libgcc] Make possible to disable JCR in crtstuff.c

2012-11-26 Thread H.J. Lu
On Mon, Nov 26, 2012 at 7:19 PM, Joey Ye wrote: > Ping^2 > >> -Original Message- >> From: Joey Ye >> Sent: Tuesday, November 20, 2012 10:09 >> To: gcc-patches@gcc.gnu.org >> Cc: Joey Ye >> Subject: RE: [PATCH, libgcc] Make possible to disable JCR in crtstuff.c >> >> Ping, as Joseph Prostko

Re: [PATCH, libgcc] Make possible to disable JCR in crtstuff.c

2012-11-26 Thread Joseph Prostko
On Mon, Nov 26, 2012 at 10:19 PM, Joey Ye wrote: > Ping^2 > >> -Original Message- >> From: Joey Ye >> Sent: Tuesday, November 20, 2012 10:09 >> To: gcc-patches@gcc.gnu.org >> Cc: Joey Ye >> Subject: RE: [PATCH, libgcc] Make possible to disable JCR in crtstuff.c >> >> Ping, as Joseph Prostk

Re: [PATCH, libgcc] Make possible to disable JCR in crtstuff.c

2012-11-26 Thread Joseph Prostko
On Mon, Nov 26, 2012 at 11:55 PM, H.J. Lu wrote: > On Mon, Nov 26, 2012 at 7:19 PM, Joey Ye wrote: >> Ping^2 >> >>> -Original Message- >>> From: Joey Ye >>> Sent: Tuesday, November 20, 2012 10:09 >>> To: gcc-patches@gcc.gnu.org >>> Cc: Joey Ye >>> Subject: RE: [PATCH, libgcc] Make possibl