Re: [patch][lra] Improve initial program point density in lra-lives.c (was: Re: RFC: LRA for x86/x86-64 [7/9])

2012-10-04 Thread Steven Bosscher
On Thu, Oct 4, 2012 at 8:57 AM, Steven Bosscher wrote: > On Thu, Oct 4, 2012 at 5:30 AM, Vladimir Makarov wrote: >> I was going to look at this code too but I was interesting in generation of >> less points and live ranges. It is strange that in my profiles, >> remove_some_program_points_and_upd

Re: [PATCH] Improve debug info for partial inlining (PR debug/54519, take 2)

2012-10-04 Thread Jakub Jelinek
On Thu, Oct 04, 2012 at 01:31:08AM -0300, Alexandre Oliva wrote: > On Oct 3, 2012, Jakub Jelinek wrote: > > > basically there is a non-addressable parameter in stack slot, and > > vt_canon_true_dep -> canon_true_dependence thinks an argument push > > insn might alias with it, because it doesn't

Re: Convert more non-GTY htab_t to hash_table.

2012-10-04 Thread Richard Guenther
On Tue, 2 Oct 2012, Lawrence Crowl wrote: > On 10/2/12, Richard Guenther wrote: > > On Mon, 1 Oct 2012, Lawrence Crowl wrote: > > > Change more non-GTY hash tables to use the new type-safe > > > template hash table. Constify member function parameters that > > > can be const. Correct a couple o

Re: [PATCH] Fix up DW_TAG_formal_parameter placement

2012-10-04 Thread Richard Guenther
On Wed, 3 Oct 2012, Jakub Jelinek wrote: > Hi! > > With the PR54519 patch I've just posted, I've noticed, I've noticed on the > same testcase from yesterday's IRC: > static inline void foo (int x, int y) { asm volatile ("nop"); } > static inline void bar (int z) { foo (z, 0); foo (z, 1); } > int

Re: RFC: Using DECL_NO_LIMIT_STACK as a backend specific flag

2012-10-04 Thread Richard Guenther
On Wed, Oct 3, 2012 at 5:20 PM, nick clifton wrote: > Hi Ian, > > >> Can't you just keep a list of the decls for which you have issued the >> warning? > > > Yes - that would work too. In fact I agree that this would be cleaner > solution in my particular case. I'll create a new patch... > > > >>

Re: PATCH trunk: gengtype honoring mark_hook-s inside struct inside union-s

2012-10-04 Thread Basile Starynkevitch
On Wed, Oct 03, 2012 at 01:02:44PM +0200, Basile Starynkevitch wrote: > On Wed, Oct 03, 2012 at 12:21:02PM +0300, Laurynas Biveinis wrote: > > Hello Basile - > > > > > 2012-10-02 Basile Starynkevitch > > > > > > * gengtype.c (walk_type): Emit mark_hook when inside a > > > stru

Re: RFA: add lock_length attribute to break branch-shortening cycles

2012-10-04 Thread Richard Guenther
On Wed, Oct 3, 2012 at 8:22 PM, Joern Rennecke wrote: > The ARCompact architecture has some pipelining features that result in > the vanilla branch shortening not always converging. > > Moreover, there are some short, complex branch instructions with very short > offsets; replacing them with a mul

Re: [PATCH] Fix up DW_TAG_formal_parameter placement

2012-10-04 Thread Jakub Jelinek
On Thu, Oct 04, 2012 at 09:42:59AM +0200, Richard Guenther wrote: > This looks like the wrong place to fix things to me ... either we can > fix this at the point we create the VAR_DECLs for the optimized away > PARM_DECLs (or we should delay that until here?) No, that is not possible. There is no

Adjust gcc.dg/lower-subreg-1.c for SPARC

2012-10-04 Thread Eric Botcazou
Tested on SPARC/Solaris 10, applied on the mainline. 2012-10-04 Eric Botcazou PR rtl-optimization/54739 * gcc.dg/lower-subreg-1.c: Also skip on SPARC. -- Eric BotcazouIndex: gcc.dg/lower-subreg-1.c === --- gcc.

Re: opts.c, gcc.c: Plug some memory leaks - and an out-of-bounds memory access

2012-10-04 Thread Richard Guenther
On Wed, Oct 3, 2012 at 11:01 PM, Tobias Burnus wrote: > Found using http://scan5.coverity.com/ > > Build on x86-64-gnu-linux with C/C++/Fortran. I will now do an all-language > build/regtest. > OK when it passes? > > (Note to the save_string call: I reduced it by 2: The "+1" in the call makes > it

Fix -fdump-ada-spec

2012-10-04 Thread Arnaud Charlet
After changes by Sharad (Add option for dumping to stderr (issue6190057)), -fdump-ada-spec is broken, and is now a no-op. Admittedly, this is because -fdump-ada-spec is handled differently from other -fdump-* switches, so this patch fixes support for -fdump-ada-spec by using an approach similar to

Re: [PATCH] Fix instability of -fschedule-insn for x86

2012-10-04 Thread Kirill Yukhin
Hi, > Based on this opinion, the patch is OK for mainline, if there are no ... Checked in: http://gcc.gnu.org/ml/gcc-cvs/2012-10/msg00187.html K

Re: [Ping]FW: [PATCH] Cilk Plus merging to trunk (2 of n)

2012-10-04 Thread Richard Guenther
On Thu, Oct 4, 2012 at 2:22 AM, Iyer, Balaji V wrote: > Hi Joseph, > Did you get a chance to look at this submission? I think I have fixed > all the changes you have mentioned. Is it OK for trunk? > > Thanks, > > Balaji V. Iyer. > >>-Original Message- >>From: gcc-patches-ow...@gcc

Re: Fix -fdump-ada-spec

2012-10-04 Thread Richard Guenther
On Thu, Oct 4, 2012 at 10:26 AM, Arnaud Charlet wrote: > After changes by Sharad (Add option for dumping to stderr (issue6190057)), > -fdump-ada-spec is broken, and is now a no-op. > > Admittedly, this is because -fdump-ada-spec is handled differently from > other -fdump-* switches, so this patch

[Ada] Project_Dir should not modify the case of its path name

2012-10-04 Thread Arnaud Charlet
This patch ensures that when project'Project_Dir is used, the path will not be modified, even on platforms where the file names are case insensitive, such as Windows. Tested on x86_64-pc-linux-gnu, committed on trunk 2012-10-04 Vincent Celier * prj-proc.adb (Process_Package_Declaratio

[Ada] Visibility error in the presence of private limited with clauses

2012-10-04 Thread Arnaud Charlet
This patch fixes a visibility error when compiling a unit DDP, when an ancestor P of DDP has a private limited with clause on a descendant of P that is itself an ancestor of DDP. The following must compile quietly: gcc -c -gnat05 bg-el-lc.adb --- package body BG.El.LC is overriding p

[Ada] Remaining fixes to get MINIMIZED through test suite

2012-10-04 Thread Arnaud Charlet
This patch makes two minor corrections to fix two remaining tests in the test suite that failed if run with -gnato2 forced on. There is also a minor optimization of Compile_Time_Compare which improves the results in some cases (noticed during testing, but does not have any effect on the test suite)

[Ada] Remaining fixes for -gnato3 (eliminated mode overflow checks)

2012-10-04 Thread Arnaud Charlet
This patch corrects a couple of errors in the handling of ELIMINATED mode overflow checking. With this patch, the entire test suite passes with -gnato3 mode forced on (there are some differences in output, but all are expected). The following three tests now work correctly The following compiles

Re: [SH] PR 33135 - Remove mieee option in libgcc

2012-10-04 Thread Kaz Kojima
Oleg Endo wrote: > Since the -mieee behavior has been fixed, is enabled by default on SH > and the additional flags in libgcc can be removed. > > OK? OK. Regards, kaz

[Ada] Legality of aspects specified on a full view

2012-10-04 Thread Arnaud Charlet
In Ada 2012, certain aaspects, such as Type_Invariant, can be specified on a partial view of a type, or on the full view, but not in both This patch rejects such duplications cleanly. the command: gcc -c -gnat12 -gnata r.ads must yield: r.ads:5:32: aspect already specified in private de

[Ada]: Remove __gl_zero_cost_exceptions in the binder generated file

2012-10-04 Thread Arnaud Charlet
This variable wasn't used anymore. No functional change. Tested on x86_64-pc-linux-gnu, committed on trunk 2012-10-04 Tristan Gingold * init.c (__gl_zero_cost_exceptions): Comment it as not used anymore. * bindgen.adb (Gen_Adainit): Do not emit Zero_Cost_Exceptions

[Ada] New preprocessor switch -a

2012-10-04 Thread Arnaud Charlet
This change introduces a new switch "-a" (all source text preserved) for gnatprep and the integrated preprocessor, causing all source text to be preserved (i.e. the "if", all "elsif" and the "else" branch of a #if construct all show up in the output). This is useful to perform simple style checks o

[Ada] Warn on Ada 2012 set membership test duplicate element

2012-10-04 Thread Arnaud Charlet
This patch adds a warning if a duplicate literal entry is found in an Ada 2012 set membership, as shown by this example: 1. pragma Ada_2012; 2. package Dupset is 3.a : integer; 4.b : character; 5.c : boolean := a in 1 | 6.2 | 7

[Ada] Fix value of GNAT.Command_Line.Full_Switch on invalid switch

2012-10-04 Thread Arnaud Charlet
This patch fixes the value returned by Full_Switch when the user provided an invalid long switch (instead of return "--", Full_Switch will now return "--long"), as in this example: with GNAT.Command_Line; use GNAT.Command_Line; with Ada.Text_IO; use Ada.Text_IO; procedure Main is

Re: [patch][lra] Improve initial program point density in lra-lives.c (was: Re: RFC: LRA for x86/x86-64 [7/9])

2012-10-04 Thread Steven Bosscher
On Wed, Oct 3, 2012 at 5:35 PM, Steven Bosscher wrote: > The "worst" result is this: > Compressing live ranges: from 726174 to 64496 - 8%, pre_count 40476128, > post_count 12483414 > > But that's still a lot better than before the patch for the same function: > Compressing live ranges: from 17425

Re: [Fortran, (RFC) patch] PR49110/51055 Assignment to alloc. deferred-length character vars

2012-10-04 Thread Tobias Burnus
Thanks for the suggestions. The attached patch changes all "."-something symbol names, which I found. Build and regtested on x86-64-gnu-linux. OK for the trunk and 4.7? (".saved_dovar" also occurs in 4.6; we could also backport that part to 4.6, but I am not sure whether it is needed.) We pro

[RFA 1/5] New port: CR16: Remove "gdb" from noconfigdirs in configure.ac

2012-10-04 Thread Kaushik Phatak
Hi, This patch is one of patch set to add a new port (National Instruments CR16) in gdb. This patch will, - Remove "gdb" from noconfigdirs in top-level configure.ac. - Add target-lobgloss - Make target OS independent in config.sub OK for gcc and binutils? Regards, Kaushik 2012-10-04 Kaushik P

Re: [Fortran, (RFC) patch] PR49110/51055 Assignment to alloc. deferred-length character vars

2012-10-04 Thread Janus Weil
2012/10/4 Tobias Burnus : > Thanks for the suggestions. The attached patch changes all "."-something > symbol names, which I found. > > Build and regtested on x86-64-gnu-linux. > OK for the trunk and 4.7? (".saved_dovar" also occurs in 4.6; we could also > backport that part to 4.6, but I am not su

Re: [PATCH] Use __cxa_atexit on OpenBSD

2012-10-04 Thread Mark Kettenis
> Date: Wed, 3 Oct 2012 17:45:21 +0200 (CEST) > From: Gerald Pfeifer > > On Sat, 15 Sep 2012, Ian Lance Taylor wrote: > >> 2012-09-02 Mark Kettenis > >> > >> * config.gcc (*-*-openbsd4.[3-9]|*-*-openbsd[5-9]*): Set > >> default_use_cxa_atexit to yes. > > This is OK. > > I comm

Re: [Fortran, (RFC) patch] PR49110/51055 Assignment to alloc. deferred-length character vars

2012-10-04 Thread Janus Weil
>> Thanks for the suggestions. The attached patch changes all "."-something >> symbol names, which I found. >> >> Build and regtested on x86-64-gnu-linux. >> OK for the trunk and 4.7? (".saved_dovar" also occurs in 4.6; we could also >> backport that part to 4.6, but I am not sure whether it is nee

Re: [Fortran, (RFC) patch] PR49110/51055 Assignment to alloc. deferred-length character vars

2012-10-04 Thread Mikael Morin
Le 04/10/2012 12:17, Janus Weil a écrit : > > When backporting to 4.6 and 4.7, do you intend to also bump the module > version there? Does that make sense? > If the module version is different from that of trunk, please don't, as we would have two different module formats with the same module ver

[testsuite] Add support for -fdump-ada-spec

2012-10-04 Thread Eric Botcazou
Hi, the recent breakage of -fdump-ada-spec revealed that the switch isn't exercised in the testsuite. This patch adds the missing support. Tested on x86_64-suse-linux, OK for mainline? What of the 4.7 branch? 2012-10-04 Eric Botcazou * lib/gcc-dg.exp (cleanup-ada-spec): New proce

Re: [Patch, Fortran, OOP] PR 54784: [4.7/4.8 Regression] wrong code in polymorphic allocation with SOURCE

2012-10-04 Thread Mikael Morin
Le 03/10/2012 18:48, Janus Weil a écrit : > Hi all, > > here is a small patch for a wrong-code regression with polymorphic > allocation. The problem is that we falsely detect the allocation > variable to be a polymorphic array (although it is a scalar). For > further details see the PR, in particu

Re: [Fortran, (RFC) patch] PR49110/51055 Assignment to alloc. deferred-length character vars

2012-10-04 Thread Janne Blomqvist
On Thu, Oct 4, 2012 at 1:50 PM, Janus Weil wrote: >>> Thanks for the suggestions. The attached patch changes all "."-something >>> symbol names, which I found. >>> >>> Build and regtested on x86-64-gnu-linux. >>> OK for the trunk and 4.7? (".saved_dovar" also occurs in 4.6; we could also >>> backp

Re: [Fortran, (RFC) patch] PR49110/51055 Assignment to alloc. deferred-length character vars

2012-10-04 Thread Tobias Burnus
Hi Janus, Janus Weil wrote: When backporting to 4.6 and 4.7, do you intend to also bump the module version there? Does that make sense? Probably not. The .__result and the .saved_dovar are not ABI relevant, thus, they can be changed without problems - but also not that important. The module

Re: [patch][lra] Improve initial program point density in lra-lives.c (was: Re: RFC: LRA for x86/x86-64 [7/9])

2012-10-04 Thread Richard Guenther
On Thu, Oct 4, 2012 at 11:43 AM, Steven Bosscher wrote: > On Wed, Oct 3, 2012 at 5:35 PM, Steven Bosscher wrote: >> The "worst" result is this: >> Compressing live ranges: from 726174 to 64496 - 8%, pre_count 40476128, >> post_count 12483414 >> >> But that's still a lot better than before the pa

Re: libgo patch committed: Use libbacktrace

2012-10-04 Thread Rainer Orth
Ian Lance Taylor writes: > This patch to libgo changes it to use libbacktrace. Previously > backtraces required the Go package debug/elf to register itself with the > runtime during the package initialization, which only worked if the > program actually imported debug/elf one way or another. Bo

Re: patch to fix

2012-10-04 Thread Richard Guenther
On Wed, Oct 3, 2012 at 7:15 PM, Kenneth Zadeck wrote: > The enclosed patch is the third of at least four patches that fix the > problems associated with supporting integers on the target that are > wider than two HOST_WIDE_INTs. > > While GCC claims to support OI mode, and we have two public ports

Re: [Fortran, (RFC) patch] PR49110/51055 Assignment to alloc. deferred-length character vars

2012-10-04 Thread Janus Weil
Hi, >> One more comment: Since its appearance is a bit scattered in the code, >> how about using a small macro which prepends the "_F" prefix to a >> given variable name? >> >> Btw, note that we are using a double underscore scheme in other places >> (like __class, __vtab, __vtype, etc). I have ev

Re: [Patch] Fix PR53397

2012-10-04 Thread Richard Guenther
On Tue, Oct 2, 2012 at 6:40 PM, Kumar, Venkataramanan wrote: > Hi Richi, > > (Snip) >> + (!cst_and_fits_in_hwi (step)) >> +{ >> + if( loop->inner != NULL) >> +{ >> + if (dump_file && (dump_flags & TDF_DETAILS)) >> +{ >> + fprintf (dump_file, "Refe

Re: [patch][lra] Improve initial program point density in lra-lives.c (was: Re: RFC: LRA for x86/x86-64 [7/9])

2012-10-04 Thread Steven Bosscher
On Thu, Oct 4, 2012 at 1:30 PM, Richard Guenther wrote: > Isn't _REVERSE vs. non-_RESERVE still kind-of "random" order? Not at this stage. For cfglayout mode I would answer yes, but IRA/LRA operates in cfgrtl mode, so the sequence of insns and basic blocks must match. Therefore, if you walk the b

Re: [PATCH, gdc] - Merging gdc (GNU D Compiler) into gcc

2012-10-04 Thread Iain Buclaw
I would like to get a bump on this. It's been a while, and there have been quite a number of changes since the initial post that address many of the issues raised. Rather than reposting patches, someone mentioned attaching changelog, well, here it is. Repository is still located here: https://gi

Re: patch to fix

2012-10-04 Thread Marc Glisse
On Wed, 3 Oct 2012, Mike Stump wrote: On Oct 3, 2012, at 1:47 PM, Marc Glisse wrote: did you consider making the size of wide_int a template parameter, now that we are using C++? All with a convenient typedef or macro so it doesn't show. I am asking because in vrp I do some arithmetic that re

Re: Propagate profile counts during switch expansion

2012-10-04 Thread Jan Hubicka
> Hi, > This patch propagates the profile counts during RTL expansion. In > many cases, there is no way to determine the exact count of an edge > generated during the expansion. So this patch uses some simple > heuristics to estimate the edge counts but ensures that the counts of > the basic block

Re: [RFA 1/5] New port: CR16: Remove "gdb" from noconfigdirs in configure.ac

2012-10-04 Thread Pedro Alves
On 10/04/2012 11:17 AM, Kaushik Phatak wrote: > Hi, > This patch is one of patch set to add a new port (National Instruments CR16) > in gdb. > This patch will, > - Remove "gdb" from noconfigdirs in top-level configure.ac. > - Add target-lobgloss I can't see how adding target-libgloss is relevant

Re: RFA: darwin PATCH to fix build, internal visibility

2012-10-04 Thread Jack Howarth
On Wed, Oct 03, 2012 at 03:26:14PM -0700, Mike Stump wrote: > On Oct 3, 2012, at 12:04 PM, Jason Merrill wrote: > > This patch fixes a couple of Darwin issues I noticed with a cross-compiler: > > > > 1) Adds a couple of consts to avoid const-correctness errors. > > 2) Treats visibility "internal"

Re: patch to fix constant math

2012-10-04 Thread Kenneth Zadeck
Let me talk about the mode here first. What this interface/patch provides is a facility where the constant math that is done in optimizations is done exactly the way that it would be done on the target machine. What we have now is a compiler that only does this if it convenient to do on the

Profile housekeeping 6/n (-fprofile-consistency-report)

2012-10-04 Thread Jan Hubicka
Hi, this patch implements -fprofile-consistency-report that is useful to get an statistic about what pass are major offenders in keeping profile up-to-date. For example the following is output for combine.c Pass: fnsplit (after pass) mismatched in: +16 (freqs) +0 (counts); michma

Re: Profile housekeeping 6/n (-fprofile-consistency-report)

2012-10-04 Thread Steven Bosscher
On Thu, Oct 4, 2012 at 4:01 PM, Jan Hubicka wrote: > * doc/invoke.texi (-fprofile-consistency-report): Document. > * common.opt (fprofile-consistency-report): New. > * toplev.h (dump_profile_consistency_report): Declare. > * toplev.c (finalize): Call dump_profile_con

Re: RFA: add lock_length attribute to break branch-shortening cycles

2012-10-04 Thread Joern Rennecke
Quoting Richard Guenther : I miss a few things in this description: - what is the value of lock_length supposed to be? From the "lock" prefix it sounds like it is something unchanging, maybe even constant, thus a maximum? - the length attribute still needs to be specified when lock_length i

Re: [RFC] Make vectorizer to skip loops with small iteration estimate

2012-10-04 Thread Jan Hubicka
> > So SOC cancels out in the runtime check. > > I still think we need two formulas - one determining if vectorization is > > profitable, other specifying the threshold for scalar path at runtime (that > > will generally give lower values). > > True, we want two values. But part of the scalar pat

Re: Profile housekeeping 6/n (-fprofile-consistency-report)

2012-10-04 Thread Jan Hubicka
> On Thu, Oct 4, 2012 at 4:01 PM, Jan Hubicka wrote: > > * doc/invoke.texi (-fprofile-consistency-report): Document. > > * common.opt (fprofile-consistency-report): New. > > * toplev.h (dump_profile_consistency_report): Declare. > > * toplev.c (finalize): Call dump_p

Re: libgo patch committed: Use libbacktrace

2012-10-04 Thread Ian Lance Taylor
On Thu, Oct 4, 2012 at 5:11 AM, Rainer Orth wrote: > Ian Lance Taylor writes: > >> This patch to libgo changes it to use libbacktrace. Previously >> backtraces required the Go package debug/elf to register itself with the >> runtime during the package initialization, which only worked if the >>

Re: patch to fix

2012-10-04 Thread Kenneth Zadeck
On 10/04/2012 09:17 AM, Marc Glisse wrote: On Wed, 3 Oct 2012, Mike Stump wrote: On Oct 3, 2012, at 1:47 PM, Marc Glisse wrote: did you consider making the size of wide_int a template parameter, now that we are using C++? All with a convenient typedef or macro so it doesn't show. I am asking

[C++ testcase] PR 54323

2012-10-04 Thread Paolo Carlini
Hi, I'm adding the testcase and closing the PR. Tested x86_64-linux. Thanks, Paolo. / 2012-10-04 Paolo Carlini PR c++/54323 * g++.dg/cpp0x/pr54323.C: New. Index: g++.dg/cpp0x/pr54323.C ==

Re: [patch][lra] Improve initial program point density in lra-lives.c (was: Re: RFC: LRA for x86/x86-64 [7/9])

2012-10-04 Thread Vladimir Makarov
On 10/04/2012 03:24 AM, Steven Bosscher wrote: On Thu, Oct 4, 2012 at 8:57 AM, Steven Bosscher wrote: On Thu, Oct 4, 2012 at 5:30 AM, Vladimir Makarov wrote: I was going to look at this code too but I was interesting in generation of less points and live ranges. It is strange that in my prof

Re: RFA: darwin PATCH to fix build, internal visibility

2012-10-04 Thread Jason Merrill
On 10/04/2012 09:41 AM, Jack Howarth wrote: It appears that the patch should also special case the "scan-assembler .internal.*Foo.methodEv" tests in g++.dg/ext/visibility/pragma-override1.C and g++.dg/ext/visibility/pragma-override2.C on darwin as well... Done, thanks. Jason

Re: [patch][lra] Improve initial program point density in lra-lives.c (was: Re: RFC: LRA for x86/x86-64 [7/9])

2012-10-04 Thread Vladimir Makarov
On 10/04/2012 05:43 AM, Steven Bosscher wrote: On Wed, Oct 3, 2012 at 5:35 PM, Steven Bosscher wrote: The "worst" result is this: Compressing live ranges: from 726174 to 64496 - 8%, pre_count 40476128, post_count 12483414 But that's still a lot better than before the patch for the same functi

Re: [testsuite] Add support for -fdump-ada-spec

2012-10-04 Thread Mike Stump
On Oct 4, 2012, at 4:10 AM, Eric Botcazou wrote: > the recent breakage of -fdump-ada-spec revealed that the switch isn't > exercised in the testsuite. This patch adds the missing support. > > Tested on x86_64-suse-linux, OK for mainline? Ok. > What of the 4.7 branch? I don't see the point…

Small PATCH to rs6000.c to fix cross-compiler build without gas

2012-10-04 Thread Jason Merrill
If configure doesn't think that the assembler supports weak symbols, rs6000.c fails to compile because ASM_WEAKEN_DECL isn't defined. So let's not use it in that case. OK for trunk? commit 5f0878b79d1a42795aca2fabc8d70eefa2e29fa6 Author: Jason Merrill Date: Wed Oct 3 15:55:48 2012 -0400

Re: patch to fix

2012-10-04 Thread Kenneth Zadeck
Actually richi, this code is "correct" for some broken definition of correct. If all that is done is to convert the rtl parts of the compiler, then this code is the best you can do (of course an assertion that the length is not greater than 2 would be a useful addition). The code that is in

PATCH to acinclude.m4 to fix gas version detection

2012-10-04 Thread Jason Merrill
Recent versions of binutils seem to have started putting ' around the version number in bfd/configure.in, which was confusing gcc configure. This patch allows us to detect the version number again. OK for trunk? commit f9ce75775fe4392ee92893c46e89e17dc31bb816 Author: Jason Merrill Date: Thu

Profile housekeeping 7/n minor updating fixes

2012-10-04 Thread Jan Hubicka
Hi, here are few minor issues I run across while auditing the profile updating code. The function.c changes solve some misupdates in jump threading. tree-inline and except can be seen with -fprofile-feedback. Bootstrapped/regtested x86_64-linux, will commit it shortly. Honza * tree-inlin

[lra] patch to solve most scalability problems for LRA

2012-10-04 Thread Vladimir Makarov
The following patch solves most of LRA scalability problems. Itswitches on simpler algorithms in LRA. The first it switches off trying to reassign hard registers to spilled pseudos (they usually for such huge functions have long live ranges -- so the possibility to assign them something very

Re: RFC: LRA for x86/x86-64 [7/9] -- continuation

2012-10-04 Thread Richard Sandiford
Hi Vlad, This message is for lra-assigns.c. Sorry for the piecemeal reviews, never sure when I'll get time... > +/* This file contains a pass mostly assigning hard registers to reload > + pseudos. There is no any RTL code transformation on this pass. Maybe: /* This file's main objective is

Re: [PATCH, gdc] - Merging gdc (GNU D Compiler) into gcc

2012-10-04 Thread Mike Stump
On Oct 4, 2012, at 6:06 AM, Iain Buclaw wrote: > I would like to get a bump on this. > > It's been a while, and there have been quite a number of changes since > the initial post that address many of the issues raised. Rather than > reposting patches, someone mentioned attaching changelog, well,

Re: [patch][lra] Improve initial program point density in lra-lives.c (was: Re: RFC: LRA for x86/x86-64 [7/9])

2012-10-04 Thread Vladimir Makarov
On 10/04/2012 02:57 AM, Steven Bosscher wrote: On Thu, Oct 4, 2012 at 5:30 AM, Vladimir Makarov wrote: I was going to look at this code too but I was interesting in generation of less points and live ranges. It is strange that in my profiles, remove_some_program_points_and_update_live_ranges t

Re: PATCH trunk: gengtype honoring mark_hook-s inside struct inside union-s

2012-10-04 Thread Laurynas Biveinis
> 2012-10-03 Basile Starynkevitch > > * gengtype.c (walk_type): Emit mark_hook when inside a > struct of a union member. This is OK. Thanks, -- Laurynas

Re: Small PATCH to rs6000.c to fix cross-compiler build without gas

2012-10-04 Thread David Edelsohn
On Thu, Oct 4, 2012 at 11:38 AM, Jason Merrill wrote: > If configure doesn't think that the assembler supports weak symbols, > rs6000.c fails to compile because ASM_WEAKEN_DECL isn't defined. So let's > not use it in that case. > > OK for trunk? This patch is okay. Where are you compiling GCC f

PING^2: [patch] pr/54508: fix incomplete debug information for class

2012-10-04 Thread Paul_Koning
Ping ^ 2... -- If the only reference in a source file is to a static method of a class, then GCC would output debug information for the class name but not any of its members or base classes. The attached patch fixes this by having "prune_unused_types_mark" mark all of the parent's childre

Re: [patch][lra] Improve initial program point density in lra-lives.c

2012-10-04 Thread Vladimir Makarov
On 10/04/2012 11:45 AM, Vladimir Makarov wrote: On 10/04/2012 02:57 AM, Steven Bosscher wrote: On Thu, Oct 4, 2012 at 5:30 AM, Vladimir Makarov wrote: I was going to look at this code too but I was interesting in generation of less points and live ranges. It is strange that in my profiles, r

Re: [RFC] Make vectorizer to skip loops with small iteration estimate

2012-10-04 Thread Richard Guenther
On Thu, 4 Oct 2012, Jan Hubicka wrote: > > > So SOC cancels out in the runtime check. > > > I still think we need two formulas - one determining if vectorization is > > > profitable, other specifying the threshold for scalar path at runtime > > > (that > > > will generally give lower values). > >

Re: [PATCH, gdc] - Merging gdc (GNU D Compiler) into gcc

2012-10-04 Thread Iain Buclaw
On 4 October 2012 16:51, Mike Stump wrote: > On Oct 4, 2012, at 6:06 AM, Iain Buclaw wrote: >> I would like to get a bump on this. >> >> It's been a while, and there have been quite a number of changes since >> the initial post that address many of the issues raised. Rather than >> reposting pat

Re: [PATCH] Rs6000 infrastructure cleanup (switches), revised patch #2c

2012-10-04 Thread Gunther Nikl
Michael Meissner schrieb: > On Tue, Oct 02, 2012 at 10:13:25AM +0200, Gunther Nikl wrote: >> Michael Meissner wrote: >>> Segher Boessenkool asked me on IRC to break out the fix in the last change. >>> This patch is just the change to set the default options if the user did not >>> use -mcpu= and th

[PATCH] Improve var-tracking memory disambiguation with frame pointer (PR debug/54796)

2012-10-04 Thread Jakub Jelinek
Hi! This patch fixes a few FAILs in the ix86 guality testsuite (mainly -Os), by better disambiguating sp based VALUEs (which usually have no MEM_EXPR and thus the alias Oracle can't be used for them) from frame pointer based ones or global vars. Bootstrapped/regtested on x86_64-linux and i686-lin

[PATCH] Teach VRP to handle if ((unsigned_narrowing_cast) x != 0) similarly to if ((x & 0xffff) != 0) (PR tree-optimization/54810)

2012-10-04 Thread Jakub Jelinek
Hi! This patch handles unsigned narrowing casts the same as BIT_AND_EXPR with the unsigned narrow type's max value. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2012-10-04 Jakub Jelinek PR tree-optimization/54810 * tree-vrp.c (register_edge_assert_for_

Re: [PATCH] Improve var-tracking memory disambiguation with frame pointer (PR debug/54796)

2012-10-04 Thread Steven Bosscher
On Thu, Oct 4, 2012 at 6:33 PM, Jakub Jelinek wrote: > This patch fixes a few FAILs in the ix86 guality testsuite (mainly -Os), > by better disambiguating sp based VALUEs (which usually have no MEM_EXPR > and thus the alias Oracle can't be used for them) from frame pointer > based ones or global va

Re: [patch][lra] Improve initial program point density in lra-lives.c (was: Re: RFC: LRA for x86/x86-64 [7/9])

2012-10-04 Thread Steven Bosscher
On Thu, Oct 4, 2012 at 5:31 PM, Vladimir Makarov wrote: > > Wow. I did not have such effect. What machine do you use? I do all my testing on gcc17. Ciao! Steven

Re: patch to fix

2012-10-04 Thread Marc Glisse
On Thu, 4 Oct 2012, Kenneth Zadeck wrote: On 10/04/2012 09:17 AM, Marc Glisse wrote: On Wed, 3 Oct 2012, Mike Stump wrote: On Oct 3, 2012, at 1:47 PM, Marc Glisse wrote: did you consider making the size of wide_int a template parameter, now that we are using C++? All with a convenient typede

Re: [patch][lra] Improve initial program point density in lra-lives.c

2012-10-04 Thread Steven Bosscher
On Thu, Oct 4, 2012 at 6:12 PM, Vladimir Makarov wrote: >>> 0.6% sounds really very different from my timings. How much time does >>> create_start_finish_chains take for you? >>> >> 0.65% (2.78s). >> >> Actually, I have a profile but I am not sure now that it is for PR54146. >> It might be for PR2

Re: patch to fix constant math

2012-10-04 Thread Richard Guenther
On Thu, Oct 4, 2012 at 3:55 PM, Kenneth Zadeck wrote: > Let me talk about the mode here first. > > What this interface/patch provides is a facility where the constant math > that is done in optimizations is done exactly the way that it would be done > on the target machine. What we have now is a

Adjust gcc.dg/lto/20120723_0.c for SPARC

2012-10-04 Thread Eric Botcazou
As noted by Martin in http://gcc.gnu.org/ml/gcc-patches/2012-08/msg00116.html, the testcase is invalid C and cannot pass on SPARC 32-bit because of the ABI. Tested on SPARC/Solaris 10, applied on the mainline. 2012-10-04 Eric Botcazou * gcc.dg/lto/20120723_0.c: Skip on SPARC 32-bit.

[Patch, Fortran] Fix some memory leaks

2012-10-04 Thread Tobias Burnus
This patch fixes some memory leaks and other issues found by http://scan5.coverity.com. Build and regtested on x86-64-linux. OK for the trunk? Tobias 2012-10-04 Tobias Burnus * expr.c (scalarize_intrinsic_call): Plug memory leak. * frontend-passes.c (gcc_assert): Extend assert. * interf

Re: [lra] patch to solve most scalability problems for LRA

2012-10-04 Thread Steven Bosscher
On Thu, Oct 4, 2012 at 5:37 PM, Vladimir Makarov wrote: > The only issue now is PR54146 compilation time for IRA+LRA although it > was improved significantly. I will continue work on PR54146. But now I > am going to focus on proposals from reviews. Right, there still are opportunities to impr

Re: [PATCH] Improve var-tracking memory disambiguation with frame pointer (PR debug/54796)

2012-10-04 Thread Jakub Jelinek
On Thu, Oct 04, 2012 at 06:42:47PM +0200, Steven Bosscher wrote: > On Thu, Oct 4, 2012 at 6:33 PM, Jakub Jelinek wrote: > > This patch fixes a few FAILs in the ix86 guality testsuite (mainly -Os), > > by better disambiguating sp based VALUEs (which usually have no MEM_EXPR > > and thus the alias Or

Re: [patch][lra] Improve initial program point density in lra-lives.c

2012-10-04 Thread Steven Bosscher
On Thu, Oct 4, 2012 at 6:56 PM, Steven Bosscher wrote: > "Crude, but efficient" (tm) :-) BTW with a similar approach I also time other bits of process_bb_lives: timevar_push (TV_HOIST); /* See if we'll need an increment at the end of this basic block. An increment is needed if the PSEUDOS

Re: [Patch, Fortran] Fix some memory leaks

2012-10-04 Thread Steven Bosscher
On Thu, Oct 4, 2012 at 7:06 PM, Tobias Burnus wrote: > This patch fixes some memory leaks and other issues found by > http://scan5.coverity.com. > > Build and regtested on x86-64-linux. > OK for the trunk? Yes, thanks for plugging these! Some of them have been there since day 0 :-) Ciao! Steven

Re: PATCH trunk: gengtype honoring mark_hook-s inside struct inside union-s

2012-10-04 Thread Basile Starynkevitch
On Thu, Oct 04, 2012 at 06:51:35PM +0300, Laurynas Biveinis wrote: > > 2012-10-03 Basile Starynkevitch > > > > * gengtype.c (walk_type): Emit mark_hook when inside a > > struct of a union member. > > This is OK. thanks, Committed revision 192092 to trunk. I believe this pat

Re: [lra] patch to solve most scalability problems for LRA

2012-10-04 Thread Richard Guenther
On Thu, Oct 4, 2012 at 7:07 PM, Steven Bosscher wrote: > On Thu, Oct 4, 2012 at 5:37 PM, Vladimir Makarov wrote: >> The only issue now is PR54146 compilation time for IRA+LRA although it >> was improved significantly. I will continue work on PR54146. But now I >> am going to focus on proposal

Re: PATCH trunk: gengtype honoring mark_hook-s inside struct inside union-s

2012-10-04 Thread Richard Guenther
On Thu, Oct 4, 2012 at 7:24 PM, Basile Starynkevitch wrote: > On Thu, Oct 04, 2012 at 06:51:35PM +0300, Laurynas Biveinis wrote: >> > 2012-10-03 Basile Starynkevitch >> > >> > * gengtype.c (walk_type): Emit mark_hook when inside a >> > struct of a union member. >> >> This is O

Re: [PATCH] Teach VRP to handle if ((unsigned_narrowing_cast) x != 0) similarly to if ((x & 0xffff) != 0) (PR tree-optimization/54810)

2012-10-04 Thread Richard Guenther
On Thu, Oct 4, 2012 at 6:31 PM, Jakub Jelinek wrote: > Hi! > > This patch handles unsigned narrowing casts the same as > BIT_AND_EXPR with the unsigned narrow type's max value. > > Bootstrapped/regtested on x86_64-linux and i686-linux, > ok for trunk? Ok. Thanks, Richard. > 2012-10-04 Jakub Je

Re: PATCH trunk: gengtype honoring mark_hook-s inside struct inside union-s

2012-10-04 Thread Basile Starynkevitch
On Thu, Oct 04, 2012 at 07:26:23PM +0200, Richard Guenther wrote: > On Thu, Oct 4, 2012 at 7:24 PM, Basile Starynkevitch > wrote: > > On Thu, Oct 04, 2012 at 06:51:35PM +0300, Laurynas Biveinis wrote: > >> > 2012-10-03 Basile Starynkevitch > >> > > >> > * gengtype.c (walk_type): Emit ma

Re: PING^2: [patch] pr/54508: fix incomplete debug information for class

2012-10-04 Thread Cary Coutant
> /* We also have to mark its parents as used. > -(But we don't want to mark our parents' kids due to this.) */ > +(But we don't want to mark our parent's kids due to this, > +unless it is a class.) */ > if (die->die_parent) > - prune_unused_types_mark (d

Re: [patch][lra] Improve initial program point density in lra-lives.c

2012-10-04 Thread Vladimir Makarov
On 10/04/2012 12:56 PM, Steven Bosscher wrote: On Thu, Oct 4, 2012 at 6:12 PM, Vladimir Makarov wrote: 0.6% sounds really very different from my timings. How much time does create_start_finish_chains take for you? 0.65% (2.78s). Actually, I have a profile but I am not sure now that it is for

Re: Convert more non-GTY htab_t to hash_table.

2012-10-04 Thread Lawrence Crowl
On 10/4/12, Richard Guenther wrote: > On Tue, 2 Oct 2012, Lawrence Crowl wrote: >> On 10/2/12, Richard Guenther wrote: >> > On Mon, 1 Oct 2012, Lawrence Crowl wrote: >> > > Change more non-GTY hash tables to use the new type-safe >> > > template hash table. Constify member function parameters th

Re: patch to fix constant math

2012-10-04 Thread Kenneth Zadeck
On 10/04/2012 12:58 PM, Richard Guenther wrote: On Thu, Oct 4, 2012 at 3:55 PM, Kenneth Zadeck wrote: Let me talk about the mode here first. What this interface/patch provides is a facility where the constant math that is done in optimizations is done exactly the way that it would be done on t

Re: Use conditional casting with symtab_node

2012-10-04 Thread Diego Novillo
On Thu, Oct 4, 2012 at 2:14 PM, Lawrence Crowl wrote: > So, Jan Hubicka requested and approved the current spelling. > What now? I don't think we should hold this up. The names Jan requested seem reasonable enough. We seem to be running in circles here. Diego.

Re: PATCH trunk: gengtype honoring mark_hook-s inside struct inside union-s

2012-10-04 Thread Basile Starynkevitch
On Wed, Oct 03, 2012 at 01:02:44PM +0200, Basile Starynkevitch wrote: > So I applied and I am proposing the following patch to gcc trunk 192031 > (Laurynas, I did take your remarks into account) > # patch to trunk > Index: gcc/gengtype.c > ===

Re: PING^2: [patch] pr/54508: fix incomplete debug information for class

2012-10-04 Thread Paul_Koning
On Oct 4, 2012, at 1:38 PM, Cary Coutant wrote: >> /* We also have to mark its parents as used. >> -(But we don't want to mark our parents' kids due to this.) */ >> +(But we don't want to mark our parent's kids due to this, >> +unless it is a class.) */ >> if (

Re: RFC: LRA for x86/x86-64 [0/9]

2012-10-04 Thread Steven Bosscher
On Sat, Sep 29, 2012 at 10:26 PM, Steven Bosscher wrote: > To put it in another perspective, here are my timings of trunk vs lra > (both checkouts done today): > > trunk: > integrated RA : 181.68 (24%) usr 1.68 (11%) sys 183.43 > (24%) wall 643564 kB (20%) ggc > reload

  1   2   >