Re: [Patch libitm] [V2] config-based assessment of weakref capability

2012-01-06 Thread Iain Sandoe
On 6 Jan 2012, at 01:44, Patrick Marlier wrote: Hello Iain, On 11/21/2011 10:17 AM, Iain Sandoe wrote: This checked to DTRT on i686-darwin9 (weak ref doesn't behave like ELF's) and x86-64-darwin10/XCode 3.2.5 (weak ref behaves as per ELF). It is my understanding from some off-list discussion

Re: [ARM] Hookize REGISTER_MOVE_COST and MEMORY_MOVE_COST

2012-01-06 Thread Richard Earnshaw
On 05/01/12 18:54, Anatoly Sokolov wrote: >Hi. > >This patch removes obsolete PREFERRED_RELOAD_CLASS macro from the ARM back > end in the GCC and introduces equivalent TARGET_PREFERRED_RELOAD_CLASS target > hook. > >Bootstrapped and regression tested on arm-unknown-linux-gnueabi. >

PATCH: fix -fdump-ada-spec after PR debug/51410

2012-01-06 Thread Arnaud Charlet
The fix for PR debug/51410 (http://gcc.gnu.org/PR51410) available at: http://gcc.gnu.org/ml/gcc-patches/2011-12/msg00375.html has introduced a regression in the handling of -fdump-ada-spec which was taking the previous behavior wrt ext_block into account to avoid generating twice the same declara

Re: [PATCH][ARM] Fix headmerge testcases

2012-01-06 Thread Ramana Radhakrishnan
> > OK? OK Ramana

Re: Unreviewed libffi, libgfortran, libitm patches

2012-01-06 Thread Rainer Orth
Richard Henderson writes: > On 01/04/2012 11:27 PM, Rainer Orth wrote: >> [libgfortran, libitm] Link with -shared-libgcc >> http://gcc.gnu.org/ml/gcc-patches/2011-12/msg01382.html >> >> This will need a fortran resp. libitm maintainer. > > Does the following alleviate the need for -sha

[Add] Run ACATS cb20004 with -gnato

2012-01-06 Thread Eric Botcazou
I just discovered that the ACATS test cb20004 should be compiled with overflow checking, otherwise it can fail when you're tweaking the generated code. As a matter of fact, it fails with the unmodified compiler if you change the 51 Initial_Data_Block: begin

Re: [Patch, Fortran] Deregister allocatable COARRAYS, fixes to (de)allocate

2012-01-06 Thread Paul Richard Thomas
Dear Tobias, Please excuse the delay on coming back to you with this. Since the power cut the other evening, I have been exceptionally busy. > Build and regtested on x86-64-linux. > OK for the trunk? I have to confess that I do not like /* A better error message may be possible, but not require

Re: [PATCH][ARM] Fix headmerge testcases

2012-01-06 Thread Andrew Stubbs
On 06/01/12 10:23, Ramana Radhakrishnan wrote: OK Committed. Andrew

Re: PATCH: fix -fdump-ada-spec after PR debug/51410

2012-01-06 Thread Joseph S. Myers
On Fri, 6 Jan 2012, Arnaud Charlet wrote: > 2011-01-06 Arnaud Charlet > > * c-decl.c (ext_block): Moved up. > (collect_all_refs, for_each_global_decl): Take ext_block into account. OK. -- Joseph S. Myers jos...@codesourcery.com

[PR 51759, 4.5] Backport the fix for PR 45644 to the 4.5 branch

2012-01-06 Thread Martin Jambor
Hi, the original testcase for PR 45644 did not fail on gcc 4.5 but the bug is there as the testcase of PR 51759 shows. Therefore I've backported the patch to the 4.5 branch. The only change is the use of gcc_assert instead of gcc_checking_assert since we didn't have that in 4.5 times. Bootstrap

Re: [Patch]: split libgcc/config/ia64/t-ia64 in two

2012-01-06 Thread Tristan Gingold
On Jan 6, 2012, at 12:40 AM, Richard Henderson wrote: > On 12/21/2011 10:04 PM, Tristan Gingold wrote: >> * config/ia64/t-ia64 (LIB1ASMFUNCS): Move backward >> compatibility thunks... >> (CUSTOM_CRTSTUFF, crtbegin.o, crtend.o) >> (crtbeginS.o, crtendS.o): ... and these to ...

[PATCH] MIPS16 TLS support for GCC

2012-01-06 Thread Chung-Lin Tang
Hi Richard, here are the patches for MIPS16 TLS. Some highlights of the implementation: 1) For the common -mcode-readable=yes case, TP/DTP offset constants are loaded pc-relative (this saves insn count and size). HI16/LO16 constructing is used only as a fall-back when text is not readable. 2) To

[Ada] Ada.[Wide_]Wide_Characters.Handling should be Pure

2012-01-06 Thread Arnaud Charlet
An oversight in the preparation of the RM left out the intended pragma Pure for Ada.Wide_[Wide_]Characters.Handling (obviously intended since Ada.Characters.Handling is Pure). This is expected to be corrected in a future versiobn of AI05-0266-1, and this patch adds the required pragma Pure statemen

[Ada] Add overriding indicators

2012-01-06 Thread Arnaud Charlet
This patch adds some missing overriding indicators. No change in functionality Tested on x86_64-pc-linux-gnu, committed on trunk 2012-01-06 Bob Duff * s-rpc.ads (Read, Write): Add overriding indicators. Index: s-rpc.ads

[Ada] Visibility of selected components that are prefixed calls in instances

2012-01-06 Thread Arnaud Charlet
This patch fixes a rare visibility bug in instantiations. A selected component that resolves to a prefixed call in a generic unit may accidentally resolve to a selected component with a different selector in an instance, when both a primitive operation with a single parameter and a record component

Re: [ARM] Convert to atomic optabs

2012-01-06 Thread Richard Earnshaw
On 06/01/12 04:57, Richard Henderson wrote: > Ping. Reposting the patch as it required updates to HEAD. > > > r~ > > This is OK apart from: > + gcc_assert(!reload_completed); Missing space. > (define_special_predicate "add_operator" >(match_code "plus")) > + > +(define_predicat

Re: Ping^2: backport fix for PR 48660 (assigning to BLKmode return regs)

2012-01-06 Thread Richard Sandiford
Richard Sandiford writes: > Ping for backporting this expand patch, which fixes an ice-on-valid > regression from 4.4 while compiling certain C++ packages on ARM: > >http://gcc.gnu.org/ml/gcc-patches/2011-12/msg01550.html Approved by richi on IRC. Now applied to both 4.5 and 4.6 branches. R

Re: [Google/main Patch] Cleanup pubnames/pubtypes and test-suite (issue5514045)

2012-01-06 Thread Tom Tromey
> "Sterling" == Sterling Augustine writes: Sterling> The enclosed patch to google/main contains certain small fixes Sterling> for pubnames and pubtypes, which are now emitted completely Sterling> and canonically. I am curious to know how you ensure that they are canonical. My recollection i

Re: [PING] PR33919/preprocessor fix __BASE_FILE__ when included from the command line

2012-01-06 Thread Tom Tromey
> "Gary" == Gary Funck writes: Gary> I have a specific question re: this new code. Gary> + name = _cpp_get_file_name (pfile->main_file); Gary> + if (!name) Gary> + name = ""; Gary> I wasn't sure whether 'name' can have a NULL value, and handled Gary> that case

Re: [Patch libitm] [V2] config-based assessment of weakref capability

2012-01-06 Thread Mike Stump
On Jan 6, 2012, at 12:29 AM, Iain Sandoe wrote: >> I think something is wrong in the configure. Indeed, on apple-darwin10.8.0, >> weak ref works but it is configure as "no". >> I guess it should not try to run it but only compile it (or the symbol >> should exists). > > Which tool-chain are you

Re: [Patch libitm] [V2] config-based assessment of weakref capability

2012-01-06 Thread Patrick Marlier
On 01/06/2012 10:38 AM, Mike Stump wrote: On Jan 6, 2012, at 12:29 AM, Iain Sandoe wrote: I think something is wrong in the configure. Indeed, on apple-darwin10.8.0, weak ref works but it is configure as "no". I guess it should not try to run it but only compile it (or the symbol should exists

Re: [testsuite,trans-mem] memcpy-1.c testcase

2012-01-06 Thread Aldy Hernandez
On 01/05/12 17:44, Patrick Marlier wrote: On Darwin, the memcpy is a macro to provide secure string operations (FORTIFY_LEVEL > 0). I propose to remove the string.h include and add manually the declaration. Tested on x86_64-apple-darwin and on x86_64-unknown-linux-gnu. This solves PR51655. Patr

[PATCH] Fix miscompilation with -fprofile-use (PR gcov-profile/50127)

2012-01-06 Thread Jakub Jelinek
Hi! When tree-prof/bb-reorg.c is compiled with 32-bit host cc1 with -fprofile-use, it is miscompiled. The problem is that partition_hot_cold_basic_blocks leaves garbage (other bb pointers) in bb->aux of some basic blocks and df_analyze assumes (like other passes) that it is cleared and uses ->aux

[PATCH] Fix LTO with returns_twice TM builtins (PR lto/51774)

2012-01-06 Thread Jakub Jelinek
Hi! Now that one of the TM builtins is returns_twice, the LTO FE needs to handle it too. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2012-01-06 Jakub Jelinek PR lto/51774 * lto-lang.c (handle_returns_twice_attribute): New function.

[PATCH] Fix LTO weakref handling without .weakref assembler support (PR target/47333)

2012-01-06 Thread Jakub Jelinek
Hi! If as doesn't support .weakref, we handle weakrefs by assemble_alias setting IDENTIFIER_TRANSPARENT_ALIAS and using ultimate_transparent_alias_target from assemble_name. But for this to work, assemble_alias has to be called before asm for functions is emitted, not after it. Fixed thusly, boot

Re: [Patch libitm] [V2] config-based assessment of weakref capability

2012-01-06 Thread Jack Howarth
On Fri, Jan 06, 2012 at 10:58:51AM -0500, Patrick Marlier wrote: > On 01/06/2012 10:38 AM, Mike Stump wrote: >> On Jan 6, 2012, at 12:29 AM, Iain Sandoe wrote: I think something is wrong in the configure. Indeed, on apple-darwin10.8.0, weak ref works but it is configure as "no". I g

Re: [PATCH] Fix LTO with returns_twice TM builtins (PR lto/51774)

2012-01-06 Thread Diego Novillo
On 12-01-06 11:38 , Jakub Jelinek wrote: Hi! Now that one of the TM builtins is returns_twice, the LTO FE needs to handle it too. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2012-01-06 Jakub Jelinek PR lto/51774 * lto-lang.c (handle_retu

Re: [Google/main Patch] Cleanup pubnames/pubtypes and test-suite (issue5514045)

2012-01-06 Thread Sterling Augustine
On Fri, Jan 6, 2012 at 7:21 AM, Tom Tromey wrote: >> "Sterling" == Sterling Augustine writes: > > Sterling> The enclosed patch to google/main contains certain small fixes > Sterling> for pubnames and pubtypes, which are now emitted completely > Sterling> and canonically. > > I am curious to k

[RFC] Fixing expansion of misaligned MEM_REFs on strict-alignment targets

2012-01-06 Thread Martin Jambor
Hi, I'm trying to teach our expander how to deal with misaligned MEM_REFs on strict alignment targets. We currently generate code which leads to bus error signals due to misaligned accesses. I admit my motivation is not any target in particular but simply being able to produce misaligned MEM_REF

Re: [ARM] Implement vec_perm for NEON

2012-01-06 Thread Richard Earnshaw
On 06/01/12 04:59, Richard Henderson wrote: > Ping. Reposting the patch as it required updates to HEAD. > > OK. R.

Re: patch: remove is_gimple_non_addressable

2012-01-06 Thread Aldy Hernandez
On 01/05/12 09:36, Richard Guenther wrote: On Thu, Jan 5, 2012 at 3:48 PM, Aldy Hernandez wrote: As you suggested here: http://gcc.gnu.org/ml/gcc-patches/2012-01/msg00232.html Bootregged on x86-64 Linux. OK? No, this pessimizes things too much at gimplification time, please simply inline t

Re[2]: [BFIN] Hookize PREFERRED_RELOAD_CLASS

2012-01-06 Thread Anatoly Sokolov
Hi, Jie. On Jan 6, 2012, Jie Zhang wrote: > Hi Anatoly, > The patch looks OK. > But I cannot apply your patch by saving your email as a patch file. If > you take a look at this: I attach the patch. Anatoly. bfin_prc.diff Description: Binary data

Re: [Patch libitm] [V2] config-based assessment of weakref capability

2012-01-06 Thread Iain Sandoe
On 6 Jan 2012, at 16:42, Jack Howarth wrote: On Fri, Jan 06, 2012 at 10:58:51AM -0500, Patrick Marlier wrote: On 01/06/2012 10:38 AM, Mike Stump wrote: On Jan 6, 2012, at 12:29 AM, Iain Sandoe wrote: I think something is wrong in the configure. Indeed, on apple- darwin10.8.0, weak ref works

Re: PATCH: fix -fdump-ada-spec after PR debug/51410

2012-01-06 Thread Eric Botcazou
> Fixed by now taking into account ext_block in collect_all_refs and > for_each_global_decl (and moving the declaration of ext_block up in the > file). > > Tested on i686-pc-linux-gnu, OK for trunk? Since it only affects -fdump-ada-spec, I took the liberty to backport it to the 4.6 branch, as Jak

Re: [Patch libitm] [V2] config-based assessment of weakref capability

2012-01-06 Thread Patrick Marlier
On 01/06/2012 12:30 PM, Iain Sandoe wrote: On 6 Jan 2012, at 16:42, Jack Howarth wrote: On Fri, Jan 06, 2012 at 10:58:51AM -0500, Patrick Marlier wrote: On 01/06/2012 10:38 AM, Mike Stump wrote: On Jan 6, 2012, at 12:29 AM, Iain Sandoe wrote: I think something is wrong in the configure. Ind

Re: [Patch libitm] [V2] config-based assessment of weakref capability

2012-01-06 Thread Iain Sandoe
On 6 Jan 2012, at 18:04, Patrick Marlier wrote: On 01/06/2012 12:30 PM, Iain Sandoe wrote: On 6 Jan 2012, at 16:42, Jack Howarth wrote: On Fri, Jan 06, 2012 at 10:58:51AM -0500, Patrick Marlier wrote: On 01/06/2012 10:38 AM, Mike Stump wrote: On Jan 6, 2012, at 12:29 AM, Iain Sandoe wrote

Re: [patch] Fix PR tree-optimization/51624

2012-01-06 Thread Eric Botcazou
> > OK, I see.  Then the only way out I can think of is to stop going up the > > chain of COMPONENT_REFs as soon as the offset becomes negative. > > Yeah, that sounds like a better solution. PR ada/51775 shows that this pessimizes though because if you have an enclosing sub-component at offset 0

Re: patch ping^2: PR 51516 (TM clone aliases)

2012-01-06 Thread Aldy Hernandez
On 01/05/12 16:05, Richard Henderson wrote: On 01/06/2012 12:53 AM, Aldy Hernandez wrote: http://gcc.gnu.org/ml/gcc-patches/2011-12/msg01088.html It looks like it would be cleaner to put the .alias dereferencing directly into get_cg_data. r~ Arghh, I knew you were going to say that. That

Re: [Patch libitm] [V2] config-based assessment of weakref capability

2012-01-06 Thread Jack Howarth
On Fri, Jan 06, 2012 at 06:07:37PM +, Iain Sandoe wrote: > > On 6 Jan 2012, at 18:04, Patrick Marlier wrote: > >> On 01/06/2012 12:30 PM, Iain Sandoe wrote: >>> >>> On 6 Jan 2012, at 16:42, Jack Howarth wrote: >>> On Fri, Jan 06, 2012 at 10:58:51AM -0500, Patrick Marlier wrote: > On 01

Re: [PATCH] Fix arm var-tracking ICE (PR debug/51746)

2012-01-06 Thread Alexandre Oliva
On Jan 4, 2012, Jakub Jelinek wrote: > Before the htab expansion > cselib_lookup on r1 - 1 gave value 18:18 which contains the right value, but > doesn't have the hash value for r1 - 1 (8169), thus is found only by > accident. Unfortunately after the expansion we don't look at the 18:18 > value

Re: [PATCH] Another canonical cselib_val bootstrap fix (PR bootstrap/51725)

2012-01-06 Thread Alexandre Oliva
On Jan 3, 2012, Jakub Jelinek wrote: > My previous patch apparently wasn't enough. I think we need to propagate addr_lists to the canonical value too, and I found other spots that AFAICT require or would benefit from canonical values. Regstrapped on x86_64-linux-gnu and i686-linux-gnu, also ve

Re: Keep static VTA locs in cselib tables only

2012-01-06 Thread Alexandre Oliva
On Jan 2, 2012, Hans-Peter Nilsson wrote: >> (canonical_cselib_val): New. >> * cselib.c (new_elt_loc_list): Rework to support value >> equivalences. Adjust all callers. > This (r182760) caused regressions in the libstdc++ testsuite for > cris-elf, PR51728. On Jan 2, 2012, Andreas Krebbel wr

Re: [PATCH] Another canonical cselib_val bootstrap fix (PR bootstrap/51725)

2012-01-06 Thread Jakub Jelinek
On Fri, Jan 06, 2012 at 05:30:52PM -0200, Alexandre Oliva wrote: > Regstrapped on x86_64-linux-gnu and i686-linux-gnu, also verified with > gnu-CORBA.list with a ia64-linux-gnu cross. > > Ok to install? Ok. Jakub

Re: [PING] PR33919/preprocessor fix __BASE_FILE__ when included from the command line

2012-01-06 Thread Gary Funck
On 01/06/12 08:34:52, Tom Tromey wrote: Tom> The patch is ok with either that change or with those 2 lines removed. Tom, thanks for the review. Another question ... The test case tries to sanity check the __FILE__ value by comparing the 'basename' part. #define BASE_NAME "pr33919.c" in

Re: [patch] libitm: Optimize undo log.

2012-01-06 Thread Richard Henderson
On 01/06/2012 11:15 AM, Torvald Riegel wrote: > libitm: Optimize undo log. > > libitm/ > * local.cc (GTM_LB): Use GTM::gtm_undolog. > (GTM::gtm_thread::drop_references_undolog): Remove. > (GTM::gtm_thread::commit_undolog, > GTM::gtm_thread::rollback_undolog):

C++/libiberty PATCH for many mangling fixes (6057, 48051, 50855, 51322 and more)

2012-01-06 Thread Jason Merrill
This patch fixes several mangling issues that have been around for a while; several things didn't have a defined mangling until recently, and others have been adjusted subtly. The most notable of these is that the mangling for a C++11 template argument pack has changed, which affects any code

Re: [ARM] Convert to atomic optabs

2012-01-06 Thread Richard Henderson
On 01/07/2012 01:54 AM, Richard Earnshaw wrote: >> > + >> > +(define_predicate "mem_noofs_operand" >> > + (and (match_code "mem") >> > + (match_code "reg" "0"))) > > Hmm, I'm a bit worried about things like the frame pointer reg matching > this and then everything going screwy when eliminat

Re: [PATCH] Fix LTO weakref handling without .weakref assembler support (PR target/47333)

2012-01-06 Thread Richard Henderson
On 01/07/2012 03:41 AM, Jakub Jelinek wrote: > PR target/47333 > * cgraphunit.c (cgraph_optimize): Call output_weakrefs > before emitting functions. Ok. r~

Re: [PATCH] Fix miscompilation with -fprofile-use (PR gcov-profile/50127)

2012-01-06 Thread Richard Henderson
On 01/07/2012 03:36 AM, Jakub Jelinek wrote: > PR gcov-profile/50127 > * bb-reorder.c (partition_hot_cold_basic_blocks): Clear > bb->aux before running df_analyze. Ok except, > + /* Clear bb->aux fields that the above routines were using. */ > + FOR_EACH_BB (bb) > +bb->au

Re: [PATCH] Fix LTO weakref handling without .weakref assembler support (PR target/47333)

2012-01-06 Thread Jan Hubicka
> Hi! > > If as doesn't support .weakref, we handle weakrefs by > assemble_alias setting IDENTIFIER_TRANSPARENT_ALIAS and using > ultimate_transparent_alias_target from assemble_name. > But for this to work, assemble_alias has to be called before > asm for functions is emitted, not after it. > >

Re: C++/libiberty PATCH for many mangling fixes (6057, 48051, 50855, 51322 and more)

2012-01-06 Thread Joseph S. Myers
On Fri, 6 Jan 2012, Jason Merrill wrote: > For the moment, only the additions are enabled by default; the changes require > -fabi-version=6 or =0. Other changes since -fabi-version=2 have been fairly > limited in scope, not affecting very much code. But this is a big change, > that will require

Re: [testsuite,trans-mem] memcpy-1.c testcase

2012-01-06 Thread Richard Henderson
On 01/06/2012 10:44 AM, Patrick Marlier wrote: > 2012-01-05 Patrick Marlier > > PR testsuite/51655 > * c-c++-common/tm/memcpy-1.c: Declare memcpy instead of > including . Applied. r~

Re: Keep static VTA locs in cselib tables only

2012-01-06 Thread Hans-Peter Nilsson
> From: Alexandre Oliva > Date: Fri, 6 Jan 2012 20:35:39 +0100 > On Jan 2, 2012, Hans-Peter Nilsson wrote: > > This (r182760) caused regressions in the libstdc++ testsuite for > > cris-elf, PR51728. > On Jan 2, 2012, Andreas Krebbel wrote: > > this seem to have caused a bootstrap failure on

C++ PATCH for c++/47450 (defining class in new-expression)

2012-01-06 Thread Jason Merrill
DR 686 clarified that it is ill-formed to define a class in the (type-id) of a new-expression as well as in a new-type-id. This patch implements that, so we now reject the testcase. Tested x86_64-pc-linux-gnu, applying to trunk. commit f9a4c24ed3c76e4777414733d3c7de43c6642286 Author: Jason Me

Re: [PATCH] PR debug/45682 - wrong struct DIE nesting with -fdebug-types-section

2012-01-06 Thread Cary Coutant
> I think the real problem is that the skeleton declaration DIE for > class Executor is being inserted under the wrong DIE -- probably in > remove_child_or_replace_with_skeleton(). The problem is that we're inserting the skeleton DIE for class Executor in place of the original specification DIE at

binutils et al broken from "C++/libiberty PATCH for many mangling fixes (6057, 48051, 50855, 51322 and more)"

2012-01-06 Thread Hans-Peter Nilsson
> From: Jason Merrill > Date: Fri, 6 Jan 2012 22:38:28 +0100 > include/ > * demangle.h (enum demangle_component_type): Add > DEMANGLE_COMPONENT_INITIALIZER_LIST, DEMANGLE_COMPONENT_NULLARY. > > diff --git a/include/demangle.h b/include/demangle.h > index 98b11d7..34b3ed3 1006

Re: [BFIN] Hookize PREFERRED_RELOAD_CLASS

2012-01-06 Thread Jie Zhang
On 01/06/2012 12:07 PM, Anatoly Sokolov wrote: Hi, Jie. On Jan 6, 2012, Jie Zhang wrote: Hi Anatoly, The patch looks OK. But I cannot apply your patch by saving your email as a patch file. If you take a look at this: I attach the patch. I can apply the attached patch. OK. Thank you