Re: [fortran, patch] Document the interaction of -finit-{real,integer,…} and -Wuninitialized

2011-11-08 Thread Janne Blomqvist
On Tue, Nov 8, 2011 at 09:55, FX wrote: > The attached patch documents the fact that using the -finit-* options will > silence -Wuninitialized warnings. I don't think that's unreasonable (and > Steve classified it as a "it hurts when I do this" problem), so I intend to > close the PR after comm

Re: [PATCH] SLP vectorize calls (take 2)

2011-11-08 Thread Ira Rosen
On 8 November 2011 09:22, Jakub Jelinek wrote: > First of all, whether copysignf, sqrtf and/or lrint are vectorized is > very much target specific, should I guard the dg-final lines with > { target { i?86-*-* x86_64-*-* } } > resp. > { target { { i?86-*-* x86_64-*-* } && !lp64 } } > (the latter f

Re: [ARM] Fix PR49641

2011-11-08 Thread Sebastian Huber
On 10/31/2011 11:39 AM, Sebastian Huber wrote: On 10/25/2011 06:56 PM, Richard Earnshaw wrote: On 24/10/11 14:30, Sebastian Huber wrote: Hello, what about the attached patch based on the original patch provided by Bernd Schmidt with modifications suggested by Richard Earnshaw. pr49641.patch

Re: [PATCH, ARM] Fix stack red zone bug (PR38644)

2011-11-08 Thread Sebastian Huber
On 11/02/2011 11:05 AM, Richard Guenther wrote: On Wed, Nov 2, 2011 at 3:27 AM, Jiangning Liu wrote: > Hi, > > This patch is to fix PR38644 in ARM back-end. OK for trunk? > > For every detail, please refer to > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38644. Ok in absence of any target

[PATCH] Mixed int/float vcond{,u} for Altivec/VSX

2011-11-08 Thread Jakub Jelinek
Hi! Working virtually out of Pago Pago for now. The following patch enables mixed mode COND_EXPR vectorization, similarly how it has been enabled for i?86/x86_64 a few months ago. For Altivec/VSX the only combinations that can be supported are V4SImode comparison (unsigned or signed) with V4SFmod

Re: [PATCH][PING^2] Vectorize conversions directly

2011-11-08 Thread Dmitry Plotnikov
Ping. On 10/28/2011 12:22 PM, Dmitry Plotnikov wrote: Here is the patch updated according to recent comments. 2011-10-28 Dmitry Plotnikov gcc/ * tree-cfg.c (verify_gimple_assign_unary): Allow vector conversions. * optabs.c (supportable_convert_operation): New function. * optabs.h (supportable

Re: [fortran, patch] Document the interaction of -finit-{real,integer,…} and -Wuninitialized

2011-11-08 Thread Tobias Burnus
On 11/08/2011 08:55 AM, FX wrote: The attached patch documents the fact that using the -finit-* options will silence -Wuninitialized warnings. Good idea. (And approved by Janne.) I don't think that's unreasonable [...], so I intend to close the PR after committing. I think one could disti

[libgfortran, patch] Silence a warning in fallback round() implementation

2011-11-08 Thread FX
PR 47970 is about a warning in libgfortran/intrinsics/c99_functions.c for platforms without round() and ceill(), because round() is used in roundl() before it's prototype is given. Moving the round() prototype and implementation earlier in the file fixes it. Patch tested by manually editing my

[fortran, patch] PR 21881, issue a fatal error instead of an ICE

2011-11-08 Thread FX
PR21881 is about cases like this: > type t > integer i001(268435456) > end type t > type(t), allocatable :: x(:) where (on 32-bit systems) the array in the derived type is too large for us to handle (the array descriptor redesign might make the problem go away altogether, but that's

[PATCH] SLP vectorize calls (take 3)

2011-11-08 Thread Jakub Jelinek
On Tue, Nov 08, 2011 at 10:03:23AM +0200, Ira Rosen wrote: > The second option would be nicer. ... Thanks. Here is an updated patch, will bootstrap/regtest it now. Ok for trunk if it passes? 2011-11-08 Jakub Jelinek * tree-vect-stmts.c (vectorizable_call): Add SLP_NODE argument.

Re: [PATCH] Improve VEC_BASE

2011-11-08 Thread Richard Guenther
On Tue, Nov 8, 2011 at 1:29 AM, Jeff Law wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 11/07/11 15:53, Richard Guenther wrote: >> On Mon, Nov 7, 2011 at 10:25 PM, Jakub Jelinek >> wrote: >>> Hi! >>> >>> This patch attempts to optimize VEC_BASE if we know that offsetof >>> of bas

Re: [PATCH] SLP vectorize calls (take 3)

2011-11-08 Thread Ira Rosen
On 8 November 2011 11:32, Jakub Jelinek wrote: > On Tue, Nov 08, 2011 at 10:03:23AM +0200, Ira Rosen wrote: >> The second option would be nicer. > ... > > Thanks.  Here is an updated patch, will bootstrap/regtest it now. > Ok for trunk if it passes? Yes. Thanks, Ira > > 2011-11-08  Jakub Jeline

Re: [PATCH] Improve VEC_BASE

2011-11-08 Thread Richard Guenther
On Tue, Nov 8, 2011 at 10:45 AM, Richard Guenther wrote: > On Tue, Nov 8, 2011 at 1:29 AM, Jeff Law wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> On 11/07/11 15:53, Richard Guenther wrote: >>> On Mon, Nov 7, 2011 at 10:25 PM, Jakub Jelinek >>> wrote: Hi! This pa

Re: [libgfortran, patch] Silence a warning in fallback round() implementation

2011-11-08 Thread Tobias Burnus
On 11/08/2011 10:06 AM, FX wrote: PR 47970 is about a warning in libgfortran/intrinsics/c99_functions.c for platforms without round() and ceill(), because round() is used in roundl() before it's prototype is given. Moving the round() prototype and implementation earlier in the file fixes it.

Re: [Patch, Fortran, committed] Add libquadmath testcase gfortran.dg/quad_2.f90

2011-11-08 Thread Rainer Orth
Steve Kargl writes: > On Mon, Nov 07, 2011 at 09:55:48PM +0100, Eric Botcazou wrote: >> > The test uses the largest available floating-point number - be it 8, 10 >> > or 16 - and tests for that. The checks should be thus OK for any system. >> >> It fails with a link failure on SPARC Solaris 8 an

Re: [PATCH] Emit vperm2[if]128 $0x12/$0x20 as vinsert[if]128 $0/$1

2011-11-08 Thread Uros Bizjak
On Mon, Nov 7, 2011 at 10:20 PM, Jakub Jelinek wrote: > I think it is at least more readable and perhaps for some CPUs could > be faster (for SandyBridge it is the same speed) if we emit a more > specialized insn over a more generic one. > > Bootstrapped/regtested on x86_64-linux and i686-linux,

[libgfortran, patch] Silence a warning in libgfortran's runtime/error.c

2011-11-08 Thread FX
This patch for PR 47972 uses __builtin_choose_expr instead of the current if-else, avoiding the type warning for the branch not taken. This was suggested by Jakub in the PR itself. Bootstrapped and regtested on x86_64-linux, OK to commit to trunk? FX typewarning.ChangeLog Description: Binary

Re: [PATCH] If !-prefer-avx128, prefer using even 32-byte integer vector modes

2011-11-08 Thread Uros Bizjak
On Tue, Nov 8, 2011 at 7:44 AM, Jakub Jelinek wrote: > Working virtually out of Pago Pago. Hm...? > Is there a reason why we don't prefer 32-byte integer vector modes > even for AVX?  If a vectorized loop needs some operation that is only > supported by AVX2 we would retry whenever seeing such

[fortran, patch] Add DREAL simplification (last remaining elemental required for initialization expressions)

2011-11-08 Thread FX
Attached patch adds a (rather trivial) simplification routine for the DREAL intrinsic (a GNU extension), which is the last unimplemented simplification for elemental intrinsics (PR 38718, which tracks this issue, also lists LSHIFT and RSHIFT, but both have gained simplification routines since it

Re: [rs6000] Fix PR 50906, eh_frame and other woes

2011-11-08 Thread Olivier Hainque
On Nov 8, 2011, at 6:13 AM, Alan Modra wrote: > It's been a while since I looked at what was happening with this > testcase, but from memory what stops sheduling over the stack_tie is > alias.c:base_alias_check. Which relies on tracking registers to see > whether two memory accesses using differ

[Patch, Fortran, OOP] PR 50960: vtables not marked as constant

2011-11-08 Thread Janus Weil
Hi all, the attached patch marks the 'vtab' symbols as constant (FL_PARAMETER). They are fixed objects which are initialized once and never change. Regtested on x86_64-unknown-linux-gnu. Ok for trunk? Is it ok to commit without a test case? If not, any suggestions how a good test case could look

Re: [RFA/ARM][Patch 04/05]: STRD generation instead of PUSH in A15 ARM prologue.

2011-11-08 Thread Sameera Deshpande
On Fri, 2011-10-21 at 13:45 +0100, Ramana Radhakrishnan wrote: > >+arm_emit_strd_push (unsigned long saved_regs_mask) > > How different is this from the thumb2 version you sent out in Patch 03/05 ? > Thumb-2 STRD can handle non-consecutive registers, ARM STRD cannot. Because of which we accumula

Re: [RFA/ARM][Patch 05/05]: LDRD generation instead of POP in A15 ARM epilogue.

2011-11-08 Thread Sameera Deshpande
On Fri, 2011-10-21 at 13:45 +0100, Ramana Radhakrishnan wrote: > change that. Other than that this patch looks OK and please watch out > for stylistic issues from the previous patch. Ramana, please find attached reworked patch. The patch is tested with check-gcc, check-gdb and bootstrap with no r

Re: [PATCH] Add capability to run several iterations of early optimizations

2011-11-08 Thread Richard Guenther
On Tue, Nov 8, 2011 at 7:34 AM, Maxim Kuvyrkov wrote: > On 2/11/2011, at 10:18 AM, Richard Guenther wrote: >> >  Thus, I don't think we want to > merge this in its current form or in this stage1. What is the benefit of pushing this to a later release?  If anything, merging t

Re: [PATCH] If !-prefer-avx128, prefer using even 32-byte integer vector modes

2011-11-08 Thread Richard Guenther
On Tue, Nov 8, 2011 at 7:44 AM, Jakub Jelinek wrote: > Hi! > > Working virtually out of Pago Pago. > > Is there a reason why we don't prefer 32-byte integer vector modes > even for AVX?  If a vectorized loop needs some operation that is only > supported by AVX2 we would retry whenever seeing such

Re: [PATCH, ARM] Fix stack red zone bug (PR38644)

2011-11-08 Thread Richard Guenther
On Tue, Nov 8, 2011 at 9:06 AM, Sebastian Huber wrote: > On 11/02/2011 11:05 AM, Richard Guenther wrote: >> >> On Wed, Nov 2, 2011 at 3:27 AM, Jiangning Liu >>  wrote: >>> >>> >  Hi, >>> > >>> >  This patch is to fix PR38644 in ARM back-end. OK for trunk? >>> > >>> >  For every detail, please refe

Re: RFA: New pass to delete unexecutable paths in the CFG

2011-11-08 Thread Paolo Bonzini
On 11/07/2011 07:54 PM, Jeff Law wrote: But we're still stuck with the conditional leading to the path with the __builtin_trap. That's what we want to avoid since those conditionals are executed at runtime. Just to understand, what does this do with your optimization? void f(void *p) { if

[PATCH] Fix canonicalize_constructor_val

2011-11-08 Thread Richard Guenther
This fixes an oversight in canonicalize_constructor_val which can result in trying to add a referenced var to a function that doesn't have them computed when folding a statement before referenced_vars pass has been run. Committed. Richard. 2011-11-08 Richard Guenther * gimple-fold.c

Re: [PATCH, ARM] Fix stack red zone bug (PR38644)

2011-11-08 Thread Sebastian Huber
On 11/08/2011 12:15 PM, Richard Guenther wrote: On Tue, Nov 8, 2011 at 9:06 AM, Sebastian Huber wrote: On 11/02/2011 11:05 AM, Richard Guenther wrote: On Wed, Nov 2, 2011 at 3:27 AM, Jiangning Liu wrote: Hi, This patch is to fix PR38644 in ARM back-end. OK for trunk? For every d

Re: [wwwdocs] update gcc-4.7/changes.html

2011-11-08 Thread Jonathan Wakely
On 8 November 2011 01:27, Jonathan Wakely wrote: > The std::pointer_traits and std::allocator_traits implementations are > complete now, update the release notes. Also replace C++0x with C++11. Checked in to wwwdocs Index: changes.html =

Re: [v3] Bits of libstdc++/51018

2011-11-08 Thread Jonathan Wakely
Here's another bit, disable the failing test on netbsd PR libstdc++/51018 * testsuite/30_threads/thread/native_handle/typesizes.cc: Do not run on netbsd. committed to mainline Index: testsuite/30_threads/thread/native_handle/typesizes.cc ===

RFT: Fix PR middle/end-40154

2011-11-08 Thread Kaz Kojima
"joern.renne...@embecosm.com" wrote: > This fixes the problem on the Epiphany, but I haven't tested if it also fixes > it on > the SH - AAUI you'd have to back out a workaround first to properly test it. > > Bootstrapped powerpc64-unknown-linux-gnu. With the patch + reverting 148018 workaround,

Re: RFT: Fix PR middle/end-40154

2011-11-08 Thread Eric Botcazou
> This fixes the problem on the Epiphany, but I haven't tested if it also > fixes it on the SH - AAUI you'd have to back out a workaround first to > properly test it. The fix belongs in the caller instead - it should make sure that what it is doing makes sense at all. -- Eric Botcazou

[v3] -Wall fixes

2011-11-08 Thread Paolo Carlini
Hi, fix two minor regressions for the -Wall testsuite. Committed to mainline. Paolo. 2011-11-08 Paolo Carlini * testsuite/29_atomics/headers/atomic/macros.cc: Avoid -Wall warnings. * testsuite/29_atomics/atomic/cons/user_pod.cc: Likewise. Index: test

[PATCH][C][C++] Fix PR51010

2011-11-08 Thread Richard Guenther
This fixes PR51010 by handling SSA names in the C/C++ pretty printers. Bootstrap and regtest pending on x86_64-unknown-linux-gnu, ok if that succeeds? Thanks, Richard. 2011-11-08 Richard Guenther PR middle-end/51010 c-family/ * c-pretty-print.c (pp_c_expression): Han

Re: RFT: Fix PR middle/end-40154

2011-11-08 Thread Joern Rennecke
Quoting Eric Botcazou : This fixes the problem on the Epiphany, but I haven't tested if it also fixes it on the SH - AAUI you'd have to back out a workaround first to properly test it. The fix belongs in the caller instead - it should make sure that what it is doing makes sense at all. set_u

[PATCH] Fix PR51012

2011-11-08 Thread Richard Guenther
This fixes PR51012 - a few more places where we need to update non-inlinable state when discovering new direct edges. Bootstrap and regtest pending on x86_64-unknown-linux-gnu. Richard. 2011-11-08 Richard Guenther PR tree-optimization/51012 * ipa-prop.c (update_indirect_edge

Re: Massive breakage with your libgcc patches

2011-11-08 Thread Paolo Bonzini
On 11/07/2011 07:15 PM, Rainer Orth wrote: > Bernd Schmidt writes: > >> On 11/03/11 20:20, Rainer Orth wrote: >>> >>> * config/c6x/t-elf (LIB2ADDEH): Set. >>> * config/c6x/t-c6x-elf: Remove. >> >> It builds now, but parts of libgcc are missing. There's no sign of >> muldf3, for examples.

Re: RFT: Fix PR middle/end-40154

2011-11-08 Thread Joern Rennecke
Quoting Kaz Kojima : It seems that find_reloads calls set_unique_reg_note for a USE insn. That's true, and it is by design. This use of set_unique_reg_note is a bit debatable - add_reg_note should do just fine there. OTOH keeping this as it is, and keeping set_unique_reg_note accepting USE in

Re: RFT: Fix PR middle/end-40154

2011-11-08 Thread Eric Botcazou
> set_unique_reg note already makes a number of checks so that its > multitude of callers doesn't have to. E.g. it checks that there is > indeed only one set, not only one set of a live register. Indeed, but not on the DATUM. > As you can see in the PR, there are different pieces in the compiler

Re: RFT: Fix PR middle/end-40154

2011-11-08 Thread Joern Rennecke
Quoting Eric Botcazou : This is the bug: you shouldn't call set_unique_reg_note on a DATUM with a mode different from that of the destination. This usually means that the logic in the caller is confused. This is the same interface as emit_move_insn. No, it isn't. Expanders call other exp

Re: cxx-mem-model merge [6 of 9] - libstdc++-v3

2011-11-08 Thread Andrew MacLeod
On 11/08/2011 12:05 AM, Hans-Peter Nilsson wrote: So, what DO we do if there is no basic level of atomic support... I just realized I may be feeding you an inconsistent configuration, see the atomicity stuff in libstdc++-v3/config/cpu/cris. Is that just obsolete and unused now or what do I ne

Re: Patch ping

2011-11-08 Thread Richard Guenther
On Mon, Nov 7, 2011 at 10:45 PM, Jakub Jelinek wrote: > Hi! > > I'd like to ping the restrict_based_on_field attribute patch: > http://gcc.gnu.org/ml/gcc-patches/2011-10/msg00135.html > > We currently don't do cast restricts and even if we do them again, > as this attribute doesn't make the type _

Re: [rs6000] Fix PR 50906, eh_frame and other woes

2011-11-08 Thread Alan Modra
On Tue, Nov 08, 2011 at 11:37:57AM +0100, Olivier Hainque wrote: > Joseph resorted to mem:scratch to impose a strong barrier. That's certainly > safe and I don't think the performance impact can be significant, so this > looks like a good way out. I agree. Our fancy powerpc stack deallocation

Re: [PATCH] Fix PR50999, serialize frontend specific flags (-fexceptions)

2011-11-08 Thread Richard Guenther
On Tue, 8 Nov 2011, Joseph S. Myers wrote: > On Mon, 7 Nov 2011, Richard Guenther wrote: > > > Joseph, do you have any advise on how to address frontend specific > > options in a more general way? I'm trying to re-construct a > > command-line that when processed frontend agnostic would produce >

[PATCH] Fix PR51030, handle p ? &p->base : 0 in phiopt

2011-11-08 Thread Richard Guenther
This should optimize VEC_BASE that Jakub was patching by teaching phiopt to handle some one-statement intermediate basic-blocks. Bootstrapped and tested on x86_64-unknown-linux-gnu, any comments? Thanks, Richard. 2011-11-08 Richard Guenther PR tree-optimization/51030 * tree-

Re: RFT: Fix PR middle/end-40154

2011-11-08 Thread Joern Rennecke
Quoting Eric Botcazou : set_unique_reg note already makes a number of checks so that its multitude of callers doesn't have to. E.g. it checks that there is indeed only one set, not only one set of a live register. Indeed, but not on the DATUM. P.S.: The DATUM is in the right mode for the co

fix crashes (issue5303083)

2011-11-08 Thread Dmitriy Vyukov
Fix crashes during instrumentation. The patch is for google/main branch. 2011-11-08 Dmitriy Vyukov * gcc/doc/invoke.texi: * gcc/tree-tsan.c (enum tsan_ignore_type): (struct bb_data): (struct mop_desc): (struct tsan_ignore_desc): (build_var_decl)

remove commented out code (issue5303083)

2011-11-08 Thread Dmitriy Vyukov
Remove commented out code. The patch is for google/main branch. 2011-11-08 Dmitriy Vyukov * gcc/doc/invoke.texi: * gcc/tree-tsan.c (enum tsan_ignore_type): (struct bb_data): (struct mop_desc): (struct tsan_ignore_desc): (build_var_decl):

Re: [PATCH] Fix PR50999, serialize frontend specific flags (-fexceptions)

2011-11-08 Thread Iain Sandoe
On 8 Nov 2011, at 00:21, Joseph S. Myers wrote: On Mon, 7 Nov 2011, Iain Sandoe wrote: How is the default selected (that's not obvious to me). flag_next_runtime doesn't use options mechanisms it seems, that's bad. Both -fgnu-runtime and -fnext-runtime are frontend-only flags, they shoul

Re: [PATCH] Fix PR50999, serialize frontend specific flags (-fexceptions)

2011-11-08 Thread Richard Guenther
On Tue, 8 Nov 2011, Iain Sandoe wrote: > > On 8 Nov 2011, at 00:21, Joseph S. Myers wrote: > > > On Mon, 7 Nov 2011, Iain Sandoe wrote: > > > > > > How is the default selected (that's not obvious to me). > > > > flag_next_runtime > > > > doesn't use options mechanisms it seems, that's bad. Bot

Re: RFT: Fix PR middle/end-40154

2011-11-08 Thread Kaz Kojima
Joern Rennecke wrote: > That's true, and it is by design. > This use of set_unique_reg_note is a bit debatable - add_reg_note > should do just fine there. > > OTOH keeping this as it is, and keeping set_unique_reg_note accepting USE > in this case, seems more conservative for stage3. A tiny chan

Re: Problems with trans-mem branch on Solaris/x86 etc.

2011-11-08 Thread Rainer Orth
Richard Henderson writes: >> Solaris/SPARC is going to have a similar issue: the default configure >> triplet is sparc-sun-solaris2*, still it defaults to v8plus, so cas is >> available. I haven't tried a bootstrap yet, though. > > Of course there's a bit more porting work to do for a new

Re: Problems with trans-mem branch on Solaris/x86 etc.

2011-11-08 Thread Richard Henderson
On 11/08/2011 06:51 AM, Rainer Orth wrote: >>> >> * configure.tgt: Handle i386 like i[456]86. >>> >> * config/generic/tls.h [!HAVE_ARCH_GTM_THREAD] (gtm_thr): Don't >>> >> take address. >>> >> * config/generic/tls.cc [!HAVE_ARCH_GTM_THREAD || >>> >> !HAVE_ARCH_GTM_THREAD_DISP] (_gtm_thr_tls):

Re: [PATCH][C][C++] Fix PR51010

2011-11-08 Thread Gabriel Dos Reis
On Tue, Nov 8, 2011 at 6:38 AM, Richard Guenther wrote: > > This fixes PR51010 by handling SSA names in the C/C++ pretty printers. > > Bootstrap and regtest pending on x86_64-unknown-linux-gnu, ok if that > succeeds? yes.

Re: Scheduler fix for the new predication code

2011-11-08 Thread Bernd Schmidt
Ping. Ensure we don't predicate insns with the wrong condition in a branch delay slot: http://gcc.gnu.org/ml/gcc-patches/2011-10/msg02447.html Bernd

Re: [Patch, Fortran, committed] Add libquadmath testcase gfortran.dg/quad_2.f90

2011-11-08 Thread Steve Kargl
On Tue, Nov 08, 2011 at 11:14:52AM +0100, Rainer Orth wrote: > Steve Kargl writes: > > > On Mon, Nov 07, 2011 at 09:55:48PM +0100, Eric Botcazou wrote: > >> > The test uses the largest available floating-point number - be it 8, 10 > >> > or 16 - and tests for that. The checks should be thus OK fo

Re: PATCH: Add capability to contrib/compare_tests to handle directories

2011-11-08 Thread Quentin Neill
On Sat, Nov 5, 2011 at 4:26 PM, Mike Stump wrote: > On Nov 4, 2011, at 8:23 PM, Quentin Neill wrote: >> This patch concatenates the common .sum files before comparing. >> >> Okay to commit? > > Ok, thanks for the contribution. > FYI I see my patch was missing these two fixes: 1. fix missing sum1

Re: [patch tree-optimization 1/2]: Branch-cost optimizations

2011-11-08 Thread Kai Tietz
Hi, with not much hope that this patch gets into 4.7 version, resent revised version for the first part of patch. I updated the patch according to comments I got by matz on IRC yesterday. Patch uses now vector for collecting truth &/|'s conditional chain. Additionally it checks now consisten

Re: [Patch, Fortran, committed] Add libquadmath testcase gfortran.dg/quad_2.f90

2011-11-08 Thread Rainer Orth
Steve Kargl writes: >> Please no: sqrtl is a C99 addition, and we don't want lists of non-C99 >> targets in tests that require them. >> > > OK, so, then we simply accept that running a regression test > on these targets will always FAIL? If the answer is 'yes', > then please close this PR becau

Re: [Patch, Fortran, committed] Add libquadmath testcase gfortran.dg/quad_2.f90

2011-11-08 Thread Janne Blomqvist
On Tue, Nov 8, 2011 at 17:41, Rainer Orth wrote: > Steve Kargl writes: > >>> Please no: sqrtl is a C99 addition, and we don't want lists of non-C99 >>> targets in tests that require them. >>> >> >> OK, so, then we simply accept that running a regression test >> on these targets will always FAIL?

Re: [Patch, Fortran, committed] Add libquadmath testcase gfortran.dg/quad_2.f90

2011-11-08 Thread Steve Kargl
On Tue, Nov 08, 2011 at 04:41:32PM +0100, Rainer Orth wrote: > Steve Kargl writes: > > >> Please no: sqrtl is a C99 addition, and we don't want lists of non-C99 > >> targets in tests that require them. > >> > > > > OK, so, then we simply accept that running a regression test > > on these targets

Re: PATCH: Add capability to contrib/compare_tests to handle directories

2011-11-08 Thread Mike Stump
On Nov 8, 2011, at 7:29 AM, Quentin Neill wrote: > FYI I see my patch was missing these two fixes: > Okay to commit? Ok.

Disable libitm if unsupported

2011-11-08 Thread Richard Henderson
As suggested by Joseph, this consolidates the knowledge of libitm support in the libitm directory. And better, in a file not controlled by autoconf, so less fumbling around for the correct edition. ;-) Committed in two hunks because I faffed it the first time and managed to not notice that I'd d

Re: Massive breakage with your libgcc patches

2011-11-08 Thread Bernd Schmidt
On 11/07/11 19:15, Rainer Orth wrote: > > * config/c6x/t-elf (LIB2ADD): Add instead of assigning. It does seem happier that way, please install. Please also check the list of files Paolo generated. Bernd

Re: [Patch, Fortran, committed] Add libquadmath testcase gfortran.dg/quad_2.f90

2011-11-08 Thread Tobias Burnus
On 11/08/2011 05:10 PM, Janne Blomqvist wrote: On Tue, Nov 8, 2011 at 17:41, Rainer Orth wrote: Steve Kargl writes: Please no: sqrtl is a C99 addition, and we don't want lists of non-C99 targets in tests that require them. OK, so, then we simply accept that running a regression test on the

[v3] finish allocator support in and std::shared_ptr

2011-11-08 Thread Jonathan Wakely
This is the final version of a patch I've had hanging around for about 6 months, it makes futures and shared_ptr use allocator_traits so they work with minimal C++11 allocators, such as the testsuite's SimpleAllocator, and implement the proposed resolution of LWG 2070 (which is still in Open state,

Re: [PATCH] AIX fixincludes for pthread.h

2011-11-08 Thread Bruce Korb
On Mon, Nov 7, 2011 at 12:59 PM, David Edelsohn wrote: > Okay? Well, okay, but I'd prefer one fix something like the following (and I confess I've not had any test time...) because it looks simpler to me: /* * pthread.h on AIX defines PTHREAD_ONCE_INIT without enough braces. * Rewrite the de

Re: [PING] Pass address space to REGNO_MODE_CODE_OK_FOR_BASE_P

2011-11-08 Thread Bernd Schmidt
On 10/28/11 18:06, Ulrich Weigand wrote: > > The following patch still needs maintainer review: > http://gcc.gnu.org/ml/gcc-patches/2011-10/msg01874.html Looks straightforward to me. OK. Bernd

Re: [PATCH] AIX fixincludes for pthread.h

2011-11-08 Thread David Edelsohn
Bruce, I don't want to add a layer and PTHREAD_ONCE_INIT_INTERNAL. Thanks, David

C++ PATCH for c++/50835 (wrong lvalueness with ?: in template)

2011-11-08 Thread Jason Merrill
In C++98 we can just conservatively assume that everything is an lvalue, since the things an lvalue can do are a superset of what an rvalue can do. But that isn't the case in C++11, since an lvalue can't bind to an rvalue reference, so I changed lvalue_kind to work harder to figure out whether

Re: vector garbaged collected while still in use

2011-11-08 Thread Xinliang David Li
Here is the revised patch. Bootstrap and regression tested on linux/x86-64. Honza, can you comment on the implication of this change? thanks, David On Mon, Nov 7, 2011 at 2:09 PM, Richard Guenther wrote: > On Mon, Nov 7, 2011 at 5:41 PM, Xinliang David Li wrote: >> Here is the stack trace whe

Re: Disable libitm if unsupported

2011-11-08 Thread Pedro Alves
On Tuesday 08 November 2011 16:33:52, Richard Henderson wrote: > toplevel/ > * configure.ac: Adjust srcdir for running libitm/configure.tgt. > +# Disable libitm on unsupported hosted systems. > +if test x$enable_libitm = x; then > + AC_MSG_CHECKING([for libitm support]) > + if (srcdir=

Re: Disable libitm if unsupported

2011-11-08 Thread Richard Henderson
On 11/08/2011 09:26 AM, Pedro Alves wrote: > On Tuesday 08 November 2011 16:33:52, Richard Henderson wrote: >> toplevel/ >> * configure.ac: Adjust srcdir for running libitm/configure.tgt. > >> +# Disable libitm on unsupported hosted systems. >> +if test x$enable_libitm = x; then >> + AC_

Re: Scheduler fix for the new predication code

2011-11-08 Thread Vladimir Makarov
On 11/08/2011 10:05 AM, Bernd Schmidt wrote: Ping. Ensure we don't predicate insns with the wrong condition in a branch delay slot: http://gcc.gnu.org/ml/gcc-patches/2011-10/msg02447.html Ok. Thanks, Bernd.

Re: Massive breakage with your libgcc patches

2011-11-08 Thread Rainer Orth
Bernd Schmidt writes: > On 11/07/11 19:15, Rainer Orth wrote: >> >> * config/c6x/t-elf (LIB2ADD): Add instead of assigning. > > It does seem happier that way, please install. Please also check the > list of files Paolo generated. Done. Checking this in other cases has been the plan all al

Re: [PING] Pass address space to REGNO_MODE_CODE_OK_FOR_BASE_P

2011-11-08 Thread Ulrich Weigand
Bernd Schmidt wrote: > On 10/28/11 18:06, Ulrich Weigand wrote: > > > > The following patch still needs maintainer review: > > http://gcc.gnu.org/ml/gcc-patches/2011-10/msg01874.html > > Looks straightforward to me. OK. Thanks! I've checked the patch in now. Georg-Johann, not sure whether the

Re: Disable libitm if unsupported

2011-11-08 Thread Pedro Alves
On Tuesday 08 November 2011 17:31:45, Richard Henderson wrote: > On 11/08/2011 09:26 AM, Pedro Alves wrote: > > On Tuesday 08 November 2011 16:33:52, Richard Henderson wrote: > >> toplevel/ > >> * configure.ac: Adjust srcdir for running libitm/configure.tgt. > > > >> +# Disable libitm on u

Re: [PING] Pass address space to REGNO_MODE_CODE_OK_FOR_BASE_P

2011-11-08 Thread Georg-Johann Lay
Ulrich Weigand wrote: > Georg-Johann, not sure whether the AVR follow-on patch was > approved in the meantime, but the core support should be > there now. > > Bye, > Ulrich Great! Many thanks Johann

Re: Failure to bootstrap trunk with --enable-threads=posix on cygwin since r180767

2011-11-08 Thread Dave Korn
On 07/11/2011 18:39, Rainer Orth wrote: > Christian Joensson >> xgcc: error: unrecognized command line option ‘-pthread’ > [...] >> Note the --enable-threads=posix. >> >> Backing off to revision 180766 does not yield this problem, while >> 180767 has the problem. > > I erroneously moved the

Re: Failure to bootstrap trunk with --enable-threads=posix on cygwin since r180767

2011-11-08 Thread Rainer Orth
Dave Korn writes: > Notice how in your additions, you prepend the t-mingw-pthread file to the > list in $tmake_file rather than append it as the existing code does. Ordering > of t-* files in $tmake_file is significant as there may be overrides and files > should be listed from most generic to

Re: [4.5.1,PR42776] Backport LTO-COFF implementation.

2011-11-08 Thread Dave Korn
On 30/10/2011 21:30, Gerald Pfeifer wrote: > On Mon, 14 Jun 2010, Dave Korn wrote: >> * htdocs/gcc-4.5/changes.html: Remove explicit mentions of ELF >> format from LTO documentation. > > Ouch, I noticed this patch of yours never was applied, perhaps > some misunderstanding between Richi

[PATCH] [Annotalysis] Support trylock attributes on virtual methods.

2011-11-08 Thread Delesley Hutchins
This patch fixes a bug wherein the trylock attribute would not work if it was attached to a virtual method. Bootstrapped and passed gcc regression testsuite on x86_64-unknown-linux-gnu. Okay for google/gcc-4_6? -DeLesley Changelog.google-4_6: 2011-11-08 DeLesley Hutchins * tree-threadsaf

Re: [PATCH] AIX fixincludes for pthread.h

2011-11-08 Thread David Edelsohn
On Tue, Nov 8, 2011 at 11:56 AM, Bruce Korb wrote: > On Mon, Nov 7, 2011 at 12:59 PM, David Edelsohn wrote: >> Okay? > > Well, okay, but I'd prefer one fix something like the following (and I confess > I've not had any test time...) because it looks simpler to me: Also, there are other fixinclud

Re: Disable libitm if unsupported

2011-11-08 Thread Richard Henderson
On 11/08/2011 09:56 AM, Pedro Alves wrote: > On Tuesday 08 November 2011 17:31:45, Richard Henderson wrote: >> On 11/08/2011 09:26 AM, Pedro Alves wrote: >>> On Tuesday 08 November 2011 16:33:52, Richard Henderson wrote: toplevel/ * configure.ac: Adjust srcdir for running libitm/c

Re: Failure to bootstrap trunk with --enable-threads=posix on cygwin since r180767

2011-11-08 Thread Christian Jönsson
2011/11/7 Rainer Orth: > Christian Joensson writes: > >> xgcc: error: unrecognized command line option ‘-pthread’ > [...] >> Note the --enable-threads=posix. >> >> Backing off to revision 180766 does not yield this problem, while >> 180767 has the problem. > > I erroneously moved the use of i38

Re: Failure to bootstrap trunk with --enable-threads=posix on cygwin since r180767

2011-11-08 Thread Dave Korn
On 08/11/2011 18:12, Rainer Orth wrote: > Dave Korn writes: > >> Notice how in your additions, you prepend the t-mingw-pthread file to the >> list in $tmake_file rather than append it as the existing code does. >> Ordering >> of t-* files in $tmake_file is significant as there may be overrides

Re: [Patch, Fortran, OOP] PR 50960: vtables not marked as constant

2011-11-08 Thread Paul Richard Thomas
Hi Janus, As part of Tobias's fix for PR50640, he introduced: + if ((sym->attr.flavor == FL_PARAMETER + && (sym->attr.dimension || sym->ts.type == BT_DERIVED)) + || sym->attr.vtab) TREE_READONLY (decl) = 1; Is this not sufficient to fix this PR too? Otherwise, your patch is, of

Re: [Patch, Fortran, committed] Add libquadmath testcase gfortran.dg/quad_2.f90

2011-11-08 Thread Dominique Dhumieres
I have a few questions: (1) Is sqrtl the only missing Fortran intrinsic? (2) Is there a list of missing intrinsics and platforms? (3) Does it make any sense to support REAL(10) if sqrtl is missing? Cheers, Dominique

Re: [PATCH] AIX fixincludes for pthread.h

2011-11-08 Thread Bruce Korb
Hi David, On Tue, Nov 8, 2011 at 10:20 AM, David Edelsohn wrote: >>> Okay? >> >> Well, okay, but > > Also, there are other fixincludes fixes for missing braces that > directly add the braces, not a wrapper.  They are not multi-line > macros, but there is a precedent on the style of solution.

Re: [patch i386 mingw g++.dg gcc.dg]: Set -mms-bitfields as default for native windows targets

2011-11-08 Thread Dave Korn
On 13/04/2011 11:49, Pedro Alves wrote: > On Wednesday 13 April 2011 11:43:43, Kai Tietz wrote: >>> This is a default ABI change (IIRC, when the option was >>> introduced, it was left off as default so to not break the ABI). >>> >>> Shouldn't we advertise it somewhere? > >> Yes, I did recently a l

Re: [Patch, Fortran, committed] Add libquadmath testcase gfortran.dg/quad_2.f90

2011-11-08 Thread Steve Kargl
On Tue, Nov 08, 2011 at 07:35:40PM +0100, Dominique Dhumieres wrote: > I have a few questions: > > (1) Is sqrtl the only missing Fortran intrinsic? > (2) Is there a list of missing intrinsics and platforms? This is definitely platform dependent. For amd64-*freebsd, troutmask:sgk[210] gmake che

Re: [patch tree-optimization 1/2]: Branch-cost optimizations

2011-11-08 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/07/11 15:42, Richard Guenther wrote: > > IIRC valgrind even offers simple branch predictor simulation - well > predicted branches tend to be cheap. It does. The predictor is based on processors that are 5-7 years old. I don't generally look c

Re: expr.c: don't assume MUL for scaling pointers

2011-11-08 Thread Paul Koning
> > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches-ow...@gcc.gnu.org] On > Behalf Of DJ Delorie > Sent: Wednesday, November 02, 2011 11:24 PM > To: gcc-patches@gcc.gnu.org > Subject: expr.c: don't assume MUL for scaling pointers > > > GCC assumes the target

Re: [PATCH] Improve VEC_BASE

2011-11-08 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/08/11 02:45, Richard Guenther wrote: > On Tue, Nov 8, 2011 at 1:29 AM, Jeff Law wrote: >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 >> >> On 11/07/11 15:53, Richard Guenther wrote: >>> On Mon, Nov 7, 2011 at 10:25 PM, Jakub Jelinek >>> wro

Re: [PING2] New port for TILEPro ...

2011-11-08 Thread Richard Henderson
On 11/07/2011 03:28 PM, Walter Lee wrote: > gcc: > http://gcc.gnu.org/ml/gcc-patches/2011-10/msg02084.html Well, I must say I'm a bit disappointed that the two ports are just dis-similar enough to not be merged. And failing that, I'd prefer to review them separately. Tilepro: > (UNSPEC_INSN_

Re: RFA: New pass to delete unexecutable paths in the CFG

2011-11-08 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/08/11 04:18, Paolo Bonzini wrote: > On 11/07/2011 07:54 PM, Jeff Law wrote: >> But we're still stuck with the conditional leading to the path >> with the __builtin_trap. That's what we want to avoid since >> those conditionals are executed at ru

Re: [PATCH] Improve VEC_BASE

2011-11-08 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/07/11 15:53, Richard Guenther wrote: > On Mon, Nov 7, 2011 at 10:25 PM, Jakub Jelinek > wrote: >> Hi! >> >> This patch attempts to optimize VEC_BASE if we know that offsetof >> of base is 0 (unless the compiler is doing something strange, it >>

Re: RFA: New pass to delete unexecutable paths in the CFG

2011-11-08 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/07/11 15:25, Richard Guenther wrote: > > Indeed. We'd have to tell people that they cannot catch *(void *)0 > = 0 with a SIGSEGV signal handler unless they compile with some > magic flag. Thus, the question is whether we want to optimize > thin

Re: [C++ PATCH] PR c++/45114 - Support alias templates

2011-11-08 Thread H.J. Lu
On Mon, Nov 7, 2011 at 7:54 AM, Dodji Seketeli wrote: >> On 11/05/2011 07:36 PM, Dodji Seketeli wrote: >> > +#define TYPE_DECL_NAMES_ALIAS_TEMPLATE_P(NODE)                         \ >> >> This doesn't seem to be needed anymore. > > Removed, thanks. > >> >> > +dump_alias_template_specialization (tr

  1   2   >