Re: RFA: Fix potential NULL pointer dereference

2011-11-03 Thread Jakub Jelinek
Hi! On Wed, Nov 02, 2011 at 09:28:52PM -0600, Jeff Law wrote: > This was caught by some prototype code to warn for potential NULL > pointer dereferences. Clearly we have a set of vec.h operations that require the vector to be non-NULL. Seems it is last, index (which already have such check in the

Re: serious libgcc regression added recently

2011-11-03 Thread Paolo Bonzini
On 11/03/2011 04:41 AM, David Miller wrote: From: "Joseph S. Myers" Date: Thu, 3 Nov 2011 01:21:35 + (UTC) What is new is that you can now put tests in libgcc/configure.ac such as the "Check 32bit or 64bit for x86." one, and select t-* files based on those tests - whereas in the gcc/ direct

Re: serious libgcc regression added recently

2011-11-03 Thread Jakub Jelinek
On Wed, Nov 02, 2011 at 11:41:08PM -0400, David Miller wrote: > --- a/libgcc/configure.ac > +++ b/libgcc/configure.ac > @@ -255,11 +255,12 @@ AC_CACHE_CHECK([whether assembler supports CFI > directives], [libgcc_cv_cfi], >[libgcc_cv_cfi=yes], >[libgcc_cv_cfi=no])]) > > -# Check 32bit or

Re: Mark objects death at end of scope

2011-11-03 Thread Richard Guenther
On Thu, Nov 3, 2011 at 2:10 AM, Eric Botcazou wrote: >> And there's also one issue with Ada that I need help with: it doesn't >> build anymore. ;-)  Well, the tools don't link when C++ bootstrap is >> active.  This is because our whole libbackend is compiled with g++, and >> hence uses the gxx_per

Re: except.c: fix setjmp buffer size math

2011-11-03 Thread Eric Botcazou
> * except.c (init_eh): Fix setjmp buffer size calculations for > targets where pointers are not word-sized. This will shrink the buffer for most such targets though. > Index: gcc/except.c > === > --- gcc/except.c (r

Re: Mark objects death at end of scope

2011-11-03 Thread Richard Guenther
On Thu, Nov 3, 2011 at 12:15 AM, Michael Matz wrote: > Hi, > > [Eric, see below for an Ada issue] > > so, this is a more complete resubmission of an old patch, trying to get it > into 4.7.  In order not to have to rely on TREE_BLOCK of variables to > determine valid sharing (which never really wor

Re: Mark objects death at end of scope

2011-11-03 Thread Eric Botcazou
> There is a bug about not using -fexceptions (50857). Then let's fix it, as you said there "We fail to pass -fno-exceptions -fno-rtti to g++ for stage2 and stage3 building the host binaries. That leads to increased compile-time and possibly runtime." And now that will be worse. > If gnattool

Re: Mark objects death at end of scope

2011-11-03 Thread Jakub Jelinek
On Thu, Nov 03, 2011 at 12:15:49AM +0100, Michael Matz wrote: > And there's also one issue with Ada that I need help with: it doesn't > build anymore. ;-) Well, the tools don't link when C++ bootstrap is > active. This is because our whole libbackend is compiled with g++, and > hence uses the

Re: CFT: [build] Move crtstuff support to toplevel libgcc

2011-11-03 Thread Andreas Schwab
Rainer Orth writes: > diff --git a/libgcc/config/ia64/t-ia64 b/libgcc/config/ia64/t-ia64 > --- a/libgcc/config/ia64/t-ia64 > +++ b/libgcc/config/ia64/t-ia64 > @@ -1,17 +1,15 @@ > CUSTOM_CRTSTUFF = yes > > # Assemble startup files. > -crtbegin.o: $(gcc_srcdir)/config/ia64/crtbegin.asm > +# FIX

Re: Mark objects death at end of scope

2011-11-03 Thread Michael Matz
Hi, On Thu, 3 Nov 2011, Richard Guenther wrote: > > +  /* Add clobbers for all variables that go out of scope.  */ > > +  for (t = BIND_EXPR_VARS (bind_expr); t ; t = DECL_CHAIN (t)) > > +    { > > +      if (TREE_CODE (t) == VAR_DECL > > +         && !is_global_var (t) > > I think you want to u

Re: CFT: [build] Move crtstuff support to toplevel libgcc

2011-11-03 Thread Matthew Gretton-Dann
On 02/11/11 12:37, Rainer Orth wrote: Rainer Orth writes: The next patch in the series moves crtstuff.c, extra_parts, EXTRA_PARTS, EXTRA_MULTILIB_PARTS and referenced files to libgcc. This will avoid errors due to inconsistencies in extra_parts between gcc and libgcc in the future. Much of t

Re: Mark objects death at end of scope

2011-11-03 Thread Michael Matz
Hi, On Thu, 3 Nov 2011, Jakub Jelinek wrote: > > personality. I'm not sure what the best fix here is. The rest of the > > compiler uses COMPILER and LINKER make variables that are set > > correctly depending on bootstrap configuration. But the gnattools > > Makefile.in doesn't know about th

[Patch]: Fix PR rtl-optimization/50448

2011-11-03 Thread Georg-Johann Lay
This is a patch as proposed by paolo to fix a missing propagaton of const-int addresses. Bootstrapped and regression tested on i686-pc-linux-gnu. Ok for trunk? Johann PR rtl-optimization/50448 * cprop.c (try_replace_reg): Try to simplify SET_SRC given the substitution. I

Re: Mark objects death at end of scope

2011-11-03 Thread Jakub Jelinek
On Thu, Nov 03, 2011 at 12:01:05PM +0100, Michael Matz wrote: > > Do your artificial EH regions survive into .gcc_except_table, > > It's possible. At expansion time the clobbers expand to nothing, so those > regions theoretically are mergeable with outer regions, but we don't have > EH cleanups

[C++11 Patch] PR 50941

2011-11-03 Thread Ed Smith-Rowland
Greetings, Here is a one liner and a test case. Checked on x86_64-linux-gnu. Ed Index: gcc/testsuite/g++.dg/cpp0x/udlit-string-length.C === --- gcc/testsuite/g++.dg/cpp0x/udlit-string-length.C(revision 0) +++ gcc/testsuite/g++.

Re: Mark objects death at end of scope

2011-11-03 Thread Richard Guenther
On Thu, Nov 3, 2011 at 10:23 AM, Eric Botcazou wrote: >> There is a bug about not using -fexceptions (50857). > > Then let's fix it, as you said there "We fail to pass -fno-exceptions > -fno-rtti > to g++ for stage2 and stage3 building the host binaries.  That leads to > increased compile-time an

Re: [C++11 Patch] PR 50941

2011-11-03 Thread Paolo Carlini
On 11/03/2011 12:56 PM, Ed Smith-Rowland wrote: + len = TREE_STRING_LENGTH (value) + / TREE_INT_CST_LOW (TYPE_SIZE_UNIT ( TREE_TYPE(TREE_TYPE (value - 1; ... with open brackets in random positions ;) Paolo.

Re: CFT: [build] Move crtstuff support to toplevel libgcc

2011-11-03 Thread Rainer Orth
Jason Merrill writes: > This broke bootstrap on powerpc64-unknown-linux-gnu, due to a couple of > problems with t-ppccomm. I fixed the missing backslashes, but the startup > file recipes are clearly wrong as well: > > ecrti$(objext): $(srcdir)/config/rs6000/eabi-ci.S > $(crt_compile) -c

[Patch,AVR]: Tweak division

2011-11-03 Thread Georg-Johann Lay
This is a tweak for signed 16- and 32-bit division routines. The old code called subroutine __divmod{si|hi}4_neg1 and returned if T-flag is not set. This is costly. By shuffling the instructions the test can be moved up without increasing the code size but saving calls here and there. The speed

Re: CFT: [build] Move crtstuff support to toplevel libgcc

2011-11-03 Thread Paolo Bonzini
On 11/03/2011 01:52 PM, Rainer Orth wrote: ncrtn$(objext): $(srcdir)/config/rs6000/sol-cn.S - $(crt_compile) -c ncrtn.S + $(crt_compile) -c < Oops. Missing dollar sign. Paolo

Re: Mark objects death at end of scope

2011-11-03 Thread Michael Matz
Hi, On Thu, 3 Nov 2011, Jakub Jelinek wrote: > > It's possible. At expansion time the clobbers expand to nothing, so > > those regions theoretically are mergeable with outer regions, but we > > don't have EH cleanups on RTL anymore. > > That is unfortunate. Can't EH cleanups be taught about

Re: Massive breakage with your libgcc patches

2011-11-03 Thread Rainer Orth
Hans-Peter Nilsson writes: > For big changes such as this, please test on a cross > configuration as well. A random cross wouldn't help, and I'd claim it's impractical to set up full cross environments for all affected targets. That's why I repeatedly send calls for testers, with exactly no rea

Re: Massive breakage with your libgcc patches

2011-11-03 Thread Rainer Orth
Bernd Schmidt writes: > c6x-elf cross builds are also broken with failures in libgcc/. Rainer, > can you investigate? Can you provide details? It probably would take quite some time for me to set up a full cross environment, and perhaps I can spot what's amiss without doing so. Thanks.

Re: Mark objects death at end of scope

2011-11-03 Thread Michael Matz
Hi, On Thu, 3 Nov 2011, Richard Guenther wrote: > >> If gnattools are built with the C++ compiler they should also link > >> with the G++ driver, so that's  worth fixing anyway I think. > > > > gnattools is built with the C compiler, but it reuses a couple of > > object files of libbackend.a th

fix review comments (issue5303083)

2011-11-03 Thread Dmitriy Vyukov
Fixes after davidxl review. The patch is for google/main branch. 2011-11-03 Dmitriy Vyukov * gcc/doc/invoke.texi: * gcc/tree-tsan.c (enum tsan_ignore_type): (struct bb_data): (struct mop_desc): (struct tsan_ignore_desc): (lookup_name): (

[PATCH Atom] Fix for PR target/50962 (bad AGU stall avoidance)

2011-11-03 Thread Ilya Enkovich
Hello, Here is a fix for PR 50962. Fix improves AGU stall avoidance optimization by adding opportunity to emit lea instead of mov when it is profitable. Bootstrapped and checked on linux-x86_64. Could please someone review it? Thanks, Ilya --- gcc/ 2011-11-03 Enkovich Ilya PR targe

Re: Massive breakage with your libgcc patches

2011-11-03 Thread Bernd Schmidt
On 11/03/11 14:12, Rainer Orth wrote: > Bernd Schmidt writes: > >> c6x-elf cross builds are also broken with failures in libgcc/. Rainer, >> can you investigate? > > Can you provide details? It probably would take quite some time for me > to set up a full cross environment, and perhaps I can sp

Re: [PATCH, rs6000] Preserve link stack for 476 cpus

2011-11-03 Thread Rainer Orth
Peter Bergner writes: > Hmmm, more fallout from the libgcc move. I think I'm just going to > use an older checkout to test with until the libgcc fallout gets fixed. > > ... > xgcc: error: ecrti.S: No such file or directory > xgcc: fatal error: no input files > compilation terminated. > make[5]:

Re: [C++ Patch] PR 50956

2011-11-03 Thread Tom Tromey
> "Paolo" == Paolo Carlini writes: Paolo> By the way, I have no idea why I didn't see it, only Fortran includes Paolo> that header in the *libcpp* directory? Anyway, I'm proceeding to Paolo> bootstrap the attached. It really isn't ok to do this. That header is supposedly private to libcpp.

Re: serious libgcc regression added recently

2011-11-03 Thread Joel Sherrill
On 11/02/2011 05:30 PM, David Miller wrote: From: Joel Sherrill Date: Wed, 2 Nov 2011 16:29:16 -0500 Is this similar to what I just got for sparc-rtems when compiling libgcc2 with -mcpu=v8? /tmp/cczMc4jN.s: Assembler messages: /tmp/cczMc4jN.s:16: Error: Hardware capability "mul32" not enabled

Re: [C++11 Patch] PR 50941

2011-11-03 Thread Ed Smith-Rowland
On 11/03/2011 08:50 AM, Paolo Carlini wrote: On 11/03/2011 12:56 PM, Ed Smith-Rowland wrote: + len = TREE_STRING_LENGTH (value) +/ TREE_INT_CST_LOW (TYPE_SIZE_UNIT ( TREE_TYPE(TREE_TYPE (value - 1; ... with open brackets in random positions ;) Paolo. Arrrgh! ;-) Here's a new patch

Re: [PATCH, rs6000] Preserve link stack for 476 cpus

2011-11-03 Thread Peter Bergner
On Thu, 2011-11-03 at 14:48 +0100, Rainer Orth wrote: > I sent a patch for that one: > > http://gcc.gnu.org/ml/gcc-patches/2011-11/msg00300.html > > plus Paolo's typo fix: > > http://gcc.gnu.org/ml/gcc-patches/2011-11/msg00302.html Thanks, I kicked off a bootstrap with those changes

Build gcc/ with -fno-exceptions -fno-rtti

2011-11-03 Thread Michael Matz
Hi, On Thu, 3 Nov 2011, Eric Botcazou wrote: > > There is a bug about not using -fexceptions (50857). > > Then let's fix it, as you said there "We fail to pass -fno-exceptions > -fno-rtti to g++ for stage2 and stage3 building the host binaries. > That leads to increased compile-time and poss

Re: Build gcc/ with -fno-exceptions -fno-rtti

2011-11-03 Thread Paolo Bonzini
On 11/03/2011 03:16 PM, Michael Matz wrote: > > There is a bug about not using -fexceptions (50857). > > Then let's fix it, as you said there "We fail to pass -fno-exceptions > -fno-rtti to g++ for stage2 and stage3 building the host binaries. > That leads to increased compile-time and po

Re: Mark objects death at end of scope

2011-11-03 Thread Eric Botcazou
> libcpp and libcommon and libcommon-target, the latter are: > > diagnostic.o pretty-print.o intl.o input.o version.o > prefix.o params.o opts.o opts-common.o options.o vec.o hooks.o > common/common-targhooks.o > -common.o > > Doesn't read as if these were good candidates to compile with C only whe

Re: Mark objects death at end of scope

2011-11-03 Thread Michael Matz
Hi, On Thu, 3 Nov 2011, Eric Botcazou wrote: > > libcpp and libcommon and libcommon-target, the latter are: > > > > diagnostic.o pretty-print.o intl.o input.o version.o > > prefix.o params.o opts.o opts-common.o options.o vec.o hooks.o > > common/common-targhooks.o > > -common.o > > > > Doesn't r

Re: Build gcc/ with -fno-exceptions -fno-rtti

2011-11-03 Thread Richard Guenther
On Thu, Nov 3, 2011 at 3:19 PM, Paolo Bonzini wrote: > On 11/03/2011 03:16 PM, Michael Matz wrote: >> >  >  There is a bug about not using -fexceptions (50857). >>> >>> > >>> >  Then let's fix it, as you said there "We fail to pass -fno-exceptions >>> >  -fno-rtti to g++ for stage2 and stage3

Re: Massive breakage with your libgcc patches

2011-11-03 Thread Hans-Peter Nilsson
> From: Rainer Orth > Date: Thu, 3 Nov 2011 14:10:50 +0100 > Hans-Peter Nilsson writes: > > > For big changes such as this, please test on a cross > > configuration as well. > > A random cross wouldn't help, and I'd claim it's impractical to set up > full cross environments for all affected ta

Re: [C++ Patch] PR 50956

2011-11-03 Thread Paolo Carlini
Hi, > It really isn't ok to do this. That header is supposedly private to > libcpp. Eh, eh looks like somebody wandered around and found a few handy helper functions ;) > Paolo

Re: Mark objects death at end of scope

2011-11-03 Thread Eric Botcazou
> Note, though, that eventually you'll probably have to link with g++ for > real anyway, as soon as somebody starts using c++ features in those files. Given the current pace, probably at the end of the decade, yes. :-) > Meanwhile I've put the -fno-exceptions flag to real testing, will commit > i

gfortran using libcpp/internal.h (was Re: [C++ Patch] PR 50956)

2011-11-03 Thread Jason Merrill
On 11/03/2011 09:51 AM, Tom Tromey wrote: "Paolo" == Paolo Carlini writes: Paolo> By the way, I have no idea why I didn't see it, only Fortran includes Paolo> [internal.h] in the *libcpp* directory? Anyway, I'm proceeding to Paolo> bootstrap the attached. It really isn't ok to do this. Th

Re: Build gcc/ with -fno-exceptions -fno-rtti

2011-11-03 Thread Eric Botcazou
> Thus, ok if it passes some testing. And with PR bootstrap/50857 in the ChangeLog for extra brownie points. -- Eric Botcazou

Re: gfortran using libcpp/internal.h (was Re: [C++ Patch] PR 50956)

2011-11-03 Thread Richard Guenther
On Thu, Nov 3, 2011 at 3:46 PM, Jason Merrill wrote: > On 11/03/2011 09:51 AM, Tom Tromey wrote: >>> >>> "Paolo" == Paolo Carlini  writes: >> >> Paolo>  By the way, I have no idea why I didn't see it, only Fortran >> includes >> Paolo>  [internal.h] in the *libcpp* directory? Anyway, I'm p

[committed] Fix typo in vms.c

2011-11-03 Thread Tristan Gingold
Hi, I will commit this patch to fix an obvious typo in vms.c Tristan. 2011-11-03 Tristan Gingold * config/vms/vms.c (vms_patch_builtins): Fix typo. Index: config/vms/vms.c === --- config/vms/vms.c(revision 180827) +

Re: gfortran using libcpp/internal.h (was Re: [C++ Patch] PR 50956)

2011-11-03 Thread Richard Guenther
On Thu, Nov 3, 2011 at 4:03 PM, Daniel Franke wrote: > 2011/11/3 Richard Guenther : >> On Thu, Nov 3, 2011 at 3:46 PM, Jason Merrill wrote: >>> On 11/03/2011 09:51 AM, Tom Tromey wrote: > > "Paolo" == Paolo Carlini  writes: Paolo>  By the way, I have no idea why I didn't

Re: [PATCH, rs6000] Preserve link stack for 476 cpus

2011-11-03 Thread Rainer Orth
Peter Bergner writes: > On Thu, 2011-11-03 at 09:13 -0500, Peter Bergner wrote: >> On Thu, 2011-11-03 at 14:48 +0100, Rainer Orth wrote: >> > I sent a patch for that one: >> > >> >http://gcc.gnu.org/ml/gcc-patches/2011-11/msg00300.html >> > >> > plus Paolo's typo fix: >> > >> >http://g

Re: [PATCH] Remove "bogus" g++.dg/init/copy7.C testcase

2011-11-03 Thread Richard Guenther
On Mon, Oct 10, 2011 at 2:17 PM, Richard Guenther wrote: > On Mon, Aug 15, 2011 at 2:42 PM, Richard Guenther wrote: >> >> The g++.dg/init/copy7.C testcase checks whether the C++ frontend >> guards memcpy it emits via a conditional verifying that src != dst >> because calling memcpy with overlappi

Re: [PATCH, rs6000] Preserve link stack for 476 cpus

2011-11-03 Thread Peter Bergner
On Thu, 2011-11-03 at 09:13 -0500, Peter Bergner wrote: > On Thu, 2011-11-03 at 14:48 +0100, Rainer Orth wrote: > > I sent a patch for that one: > > > > http://gcc.gnu.org/ml/gcc-patches/2011-11/msg00300.html > > > > plus Paolo's typo fix: > > > > http://gcc.gnu.org/ml/gcc-patches/2011-1

Re: Massive breakage with your libgcc patches

2011-11-03 Thread Hans-Peter Nilsson
> From: Rainer Orth > Date: Thu, 3 Nov 2011 14:10:50 +0100 > Hans-Peter Nilsson writes: > > For cris-elf, a patch in the range 180770:180778 supposedly > > yours, cause massive testsuite failures on the form of not > > finding functions in libgcc at link-time. It seems it was just a missing t-f

Re: Massive breakage with your libgcc patches

2011-11-03 Thread Rainer Orth
Hans-Peter Nilsson writes: >> From: Rainer Orth >> Date: Thu, 3 Nov 2011 14:10:50 +0100 > >> Hans-Peter Nilsson writes: >> > For cris-elf, a patch in the range 180770:180778 supposedly >> > yours, cause massive testsuite failures on the form of not >> > finding functions in libgcc at link-time.

[alpha-vms] simplify the generation of VMS linkages

2011-11-03 Thread Tristan Gingold
Richard, I plan to commit this patch to simplify the generation of linkage entries. Instead of a splay_tree, it adds a field in machine_function. But because the new field is controlled by GGC, it is present on (and thus affect) all alpha targets (it cannot be enclosed by #if/#endif). I suppose

Re: [PATCH] [Annotalysis] Fix ICE caused by ipa-sra optimization.

2011-11-03 Thread Diego Novillo
On Wed, Nov 2, 2011 at 16:48, Delesley Hutchins wrote: > This patch fixes an ICE caused when the ipa-sra optimization deletes > function arguments that are referenced from within a thread safety > attribute.  It will attempt to detect this situation and recover > gracefully.  Since a graceful reco

Re: [alpha-vms] simplify the generation of VMS linkages

2011-11-03 Thread Richard Henderson
On 11/03/2011 08:35 AM, Tristan Gingold wrote: > Do you have any objections ? Nope. r~

Re: CFT: [build] Move crtstuff support to toplevel libgcc

2011-11-03 Thread Jason Merrill
That fixed bootstrap, so I committed it. Jason

[trans-mem] document -fgnu-tm

2011-11-03 Thread Aldy Hernandez
It seems we documented libitm, and forgot to document the main switch :). OK for branch? * doc/invoke.texi (C Dialect Options): Document -fgnu-tm. Index: doc/invoke.texi === --- doc/invoke.texi (revision 180772) +++ doc/

Re: [C++ Patch / RFC] PR 48420

2011-11-03 Thread Jason Merrill
I'd rather use maybe_constant_value here, but I think you don't need to check the actual value at all; if we have decided that there is a conversion from bool to pointer, it must be a null pointer constant, and so false. Jason

Re: [PATCH] [Annotalysis] Fix ICE caused by ipa-sra optimization.

2011-11-03 Thread Delesley Hutchins
Let's try this again; perhaps I should learn to use e-mail. :-) This patch fixes an ICE caused when the ipa-sra optimization deletes function arguments that are referenced from within a thread safety attribute.  It will attempt to detect this situation and recover gracefully.  Since a graceful re

Re: [PATCH Atom] Fix for PR target/50962 (bad AGU stall avoidance)

2011-11-03 Thread Uros Bizjak
Hello! > Here is a fix for PR 50962. Fix improves AGU stall avoidance > optimization by adding opportunity to emit lea instead of mov when it > is profitable. > > 2011-11-03 Enkovich Ilya > > PR target/50962 > * config/i386/i386-protos.h (ix86_use_lea_for_mov): New. > * config

Re: [PATCH] [Annotalysis] Fix ICE caused by ipa-sra optimization.

2011-11-03 Thread Diego Novillo
On Thu, Nov 3, 2011 at 12:09, Delesley Hutchins wrote: > Let's try this again; perhaps I should learn to use e-mail.  :-) Well, all you really need is upload-gcc-patch.py from http://gcc.gnu.org/wiki/rietveld. We have an internal copy, I'll send you the location. > This patch fixes an ICE cause

Re: except.c: fix setjmp buffer size math

2011-11-03 Thread Mike Stump
On Nov 3, 2011, at 2:14 AM, Eric Botcazou wrote: >> * except.c (init_eh): Fix setjmp buffer size calculations for >> targets where pointers are not word-sized. > > This will shrink the buffer for most such targets though. I prefer: #ifndef TARGET_BUILTIN_JMP_BUF_SIZE #define TARGET_BU

Re: except.c: fix setjmp buffer size math

2011-11-03 Thread DJ Delorie
If the comment is true, and it takes a pointer to five WORDS, why are we using POINTER_SIZE at all? Does it actually take a pointer to five POINTERS? If so, where did the '4' come from? >/* builtin_setjmp takes a pointer to 5 words. */ > - tmp = size_int (5 * BITS_PER_WORD / POINT

[SPARC] Consolidate movtf patterns

2011-11-03 Thread Eric Botcazou
Tested on SPARC/Solaris, applied on the mainline. 2011-11-03 Eric Botcazou * config/sparc/sparc.md (movtf_insn_sp32_no_fpu): Consolidate into... (movtf_insn_sp32): ...this. (movtf_insn_sp64_no_fpu): Consolidate into... (movtf_insn_sp64): ...this. (movtf

Re: increase call_saved_regs[] in caller-save.c

2011-11-03 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/03/11 10:21, DJ Delorie wrote: >> But doesn't that imply that a hard register is getting inserted >> into the array more than once. While I don't see explicit code >> to prevent this, I'm having a hard time seeing how that can >> actually happen

Re: CFT: [build] Move crtstuff support to toplevel libgcc

2011-11-03 Thread Rainer Orth
Matthew Gretton-Dann writes: > This also breaks arm-none-eabi builds (fails to find unwind-arm-common.h > from gcc/ginclude). I have raised PR50978 for this > (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50978). I had incidentally removed arm/t-bpabi, incorrectly assuming it was empty while it

Re: [top-level patch] Do proper target tool checks for readelf

2011-11-03 Thread Roland McGrath
On Wed, Nov 2, 2011 at 8:32 PM, Ian Lance Taylor wrote: > The top level is not automatically merged between gcc and src.  However, > people are expected to merge manually.  Normally gcc is considered to be > the master. Ok. src/MAINTAINERS could be clearer about that. >> Ok for src/ trunk, or s

Re: except.c: fix setjmp buffer size math

2011-11-03 Thread Eric Botcazou
> I prefer: > > #ifndef TARGET_BUILTIN_JMP_BUF_SIZE > #define TARGET_BUILTIN_JMP_BUF_SIZE 5 > #endif > /* builtin_setjmp takes a pointer to TARGET_BUILTIN_JMP_BUF_SIZE > words. */ tmp = build_int_cst (NULL_TREE, TARGET_BUILTIN_JMP_BUF_SIZE * > BITS_PER_WORD / POINTER_SIZE - 1); > > This does

Re: [PATCH] [Annotalysis] Fix ICE caused by ipa-sra optimization.

2011-11-03 Thread Delesley Hutchins
> I wonder... how about disabling IPA-SRA when annotalysis is enabled? That would certainly make my life a lot easier -- IPA-SRA is not really compatible with annotalysis. The only problem I can see is that people may be unhappy if turning on annotalysis makes their code runs slower. We need a

Re: except.c: fix setjmp buffer size math

2011-11-03 Thread Eric Botcazou
> If the comment is true, and it takes a pointer to five WORDS, why are > we using POINTER_SIZE at all? Because of the 2 lines just below: tmp = build_index_type (tmp); tmp = build_array_type (ptr_type_node, tmp); > Does it actually take a pointer to five POINTERS? No. > If so, w

[build] Restore arm-eabi bootstrap (PR target/50978)

2011-11-03 Thread Rainer Orth
This patch restores arm-none-eabi bootstrap, which had been broken by my libgcc patches. They accidentally removed arm/t-bpabi in gcc/config.gcc while the file is still needed for its addition to EXTRA_HEADERS. Matt confirmed in the PR that it restored bootstrap for him. Ok for mainline?

Re: increase call_saved_regs[] in caller-save.c

2011-11-03 Thread DJ Delorie
> But doesn't that imply that a hard register is getting inserted into > the array more than once. While I don't see explicit code to > prevent this, I'm having a hard time seeing how that can actually > happen. It made no sense to me, but the array overflowed for my RL78 port, and less than hal

Re: RFA: Fix potential NULL pointer dereference

2011-11-03 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/03/11 01:51, Jakub Jelinek wrote: > Hi! > > On Wed, Nov 02, 2011 at 09:28:52PM -0600, Jeff Law wrote: >> This was caught by some prototype code to warn for potential >> NULL pointer dereferences. > > Clearly we have a set of vec.h operations th

[PATCH, i386]: Use {} for multi-line preparation statements.

2011-11-03 Thread Uros Bizjak
Hello! No functional change. 2011-11-03 Uros Bizjak * config/i386/i386.md: Use {} for multi-line preparation statements. Bootstrapped and regression tested on x86_64-pc-linux-gnu, committed to mainline SVN. Uros. Index: i386.md ===

Re: Massive breakage with your libgcc patches

2011-11-03 Thread Rainer Orth
Bernd Schmidt writes: > On 11/03/11 14:12, Rainer Orth wrote: >> Bernd Schmidt writes: >> >>> c6x-elf cross builds are also broken with failures in libgcc/. Rainer, >>> can you investigate? >> >> Can you provide details? It probably would take quite some time for me >> to set up a full cross

Re: RFA: Fix potential NULL pointer dereference

2011-11-03 Thread Jakub Jelinek
On Thu, Nov 03, 2011 at 10:21:54AM -0600, Jeff Law wrote: > Well, if we're going to go that direction, I'd just say define > VEC_BASE to (&(P)->base) for non-checking rather than mess with the > NONNULL variant. Is there some reason why we don't do that? Because the VEC_BASE macro is also used fo

Re: [trans-mem] document -fgnu-tm

2011-11-03 Thread Richard Henderson
On 11/03/2011 08:58 AM, Aldy Hernandez wrote: > * doc/invoke.texi (C Dialect Options): Document -fgnu-tm. Ok. r~

Re: Build gcc/ with -fno-exceptions -fno-rtti

2011-11-03 Thread Michael Matz
Hi, On Thu, 3 Nov 2011, Eric Botcazou wrote: > > Thus, ok if it passes some testing. > > And with PR bootstrap/50857 in the ChangeLog for extra brownie points. r180833. Ciao, Michael.

[patch] 1/n: trans-mem: libitm runtime tests

2011-11-03 Thread Aldy Hernandez
These are all new files, thus require no ChangeLog entries (for the tests themselves anyhow). However, I will post a separate ChangeLog for the entire libitm. Index: libitm/testsuite/Makefile.am === --- libitm/testsuite/Makefile.am

[patch] 2/n: ChangeLog entries for libitm runtime

2011-11-03 Thread Aldy Hernandez
The runtime is too big to post as one patch, hence the split. Index: libitm/ChangeLog === --- libitm/ChangeLog(.../trunk) (revision 0) +++ libitm/ChangeLog(.../branches/transactional-memory) (revision 180773) @@ -0,0

Re: [top-level patch] Do proper target tool checks for readelf

2011-11-03 Thread Ian Lance Taylor
Roland McGrath writes: > On Wed, Nov 2, 2011 at 8:32 PM, Ian Lance Taylor wrote: >> The top level is not automatically merged between gcc and src.  However, >> people are expected to merge manually.  Normally gcc is considered to be >> the master. > > Ok. src/MAINTAINERS could be clearer about

Re: Massive breakage with your libgcc patches

2011-11-03 Thread Bernd Schmidt
On 11/03/11 18:01, Rainer Orth wrote: > Bernd Schmidt writes: >> A cross environment for -elf targets typicaly just requires building up >> binutils/newlib, and that should be rather quick to set up. A set of > > Maybe in theory, but for the case at hand, a c6x-elf configuration with > binutils f

Re: [top-level patch] Do proper target tool checks for readelf

2011-11-03 Thread Roland McGrath
On Thu, Nov 3, 2011 at 10:39 AM, Ian Lance Taylor wrote: > Ideally I'd like to see a build maintainer approve it.  Perhaps I missed > that. Ah. The src/MAINTAINERS file says, "Any global maintainer can approve changes to these files, ...", which in that context I think includes you. But since ".

[PATCH] Fix up floatunsv{4,8}siv{4,8}sf2

2011-11-03 Thread Jakub Jelinek
Hi! As mentioned in the last mail, the testcase in that patch shows a bug in the unsigned int -> float vectorization on i?86/x86_64. E.g. 0x808fU converted to float by scalar code is 0x1.02p+31, but by vector code is 0x1p+31, i.e. one ulp smaller. We currently generate: vxorps %

Re: [top-level patch] Do proper target tool checks for readelf

2011-11-03 Thread DJ Delorie
> Ideally I'd like to see a build maintainer approve it. Perhaps I missed > that. I've got my usual paranoia about command line lengths being stressed, but I suspect we're already way past the limits on the ones that will actually fail. The patch looks OK to me.

[patch] 7/n: trans-mem: libstdc++-v3 changes

2011-11-03 Thread Aldy Hernandez
* libstdc++-v3/testsuite/util/testsuite_abi.cc (check_version): Add CXXABI_TM_1. * libstdc++-v3/libsupc++/eh_tm.cc: New file. * libstdc++-v3/libsupc++/unwind-cxx.h (__cxa_tm_cleanup): Declare. * libstdc++-v3/config/abi/pre/gnu.ver: Export __cxa_tm_cleanup.

Re: [top-level patch] Do proper target tool checks for readelf

2011-11-03 Thread Roland McGrath
On Thu, Nov 3, 2011 at 10:55 AM, DJ Delorie wrote: > The patch looks OK to me. Thanks! As I'm still not a GCC committer, someone please check it in for me. If people would like me to handle the merge over to src/ myself, I'd be glad to do that step. Thanks, Roland

Re: [PATCH] [Annotalysis] Fix ICE caused by ipa-sra optimization.

2011-11-03 Thread Diego Novillo
On Thu, Nov 3, 2011 at 12:41, Delesley Hutchins wrote: >> I wonder... how about disabling IPA-SRA when annotalysis is enabled? > > That would certainly make my life a lot easier -- IPA-SRA is not > really compatible with annotalysis.  The only problem I can see   is > that people may be unhappy if

[patch] 8/n: trans-mem: toplevel/misc changes

2011-11-03 Thread Aldy Hernandez
These are toplevel and various misc changes (libiberty, config, contrib). The libiberty, config, and contrib ChangeLogs.tm can be merged into the respective directory ChangeLog's if necessary. Index: ChangeLog.tm === --- ChangeLog

Re: Massive breakage with your libgcc patches

2011-11-03 Thread Rainer Orth
Bernd Schmidt writes: [Trimming the Cc: list.] > On 11/03/11 18:01, Rainer Orth wrote: >> Bernd Schmidt writes: >>> A cross environment for -elf targets typicaly just requires building up >>> binutils/newlib, and that should be rather quick to set up. A set of >> >> Maybe in theory, but for th

Re: [build] Restore arm-eabi bootstrap (PR target/50978)

2011-11-03 Thread Ramana Radhakrishnan
. > > Ok for mainline? This is OK. Ramana

Re: [patch] 8/n: trans-mem: toplevel/misc changes

2011-11-03 Thread Andrew Pinski
On Thu, Nov 3, 2011 at 11:09 AM, Aldy Hernandez wrote: > These are toplevel and various misc changes (libiberty, config, contrib). This should have been seperated into the following three patches: 1) a toplevel configure/makefile changes including config 2) demangler changes (libiberty) 3) contri

Re: [build] Restore arm-eabi bootstrap (PR target/50978)

2011-11-03 Thread Paolo Bonzini
On 11/03/2011 05:50 PM, Rainer Orth wrote: This patch restores arm-none-eabi bootstrap, which had been broken by my libgcc patches. They accidentally removed arm/t-bpabi in gcc/config.gcc while the file is still needed for its addition to EXTRA_HEADERS. Matt confirmed in the PR that it restored

[patch] 8a/n: trans-mem: toplevel/misc changes (contrib/)

2011-11-03 Thread Aldy Hernandez
* contrib/gcc_update: Add libitm to touch data. Index: contrib/gcc_update === --- contrib/gcc_update (.../trunk) (revision 180744) +++ contrib/gcc_update (.../branches/transactional-memory) (revision 180773) @@ -13

[PATCH] [Annotalysis] Add support for arrays in lock expressions

2011-11-03 Thread Delesley Hutchins
This patch adds support for array indexing (i.e. operator []) in lock expressions. The current version of gcc seems to emit these as expressions involving pointer arithmetic, so we update get_canonical_lock_expr() to handle such expressions. Bootstrapped and passed gcc regression testsuite on x8

[patch] 8b/n: trans-mem: toplevel/misc changes (libiberty/)

2011-11-03 Thread Aldy Hernandez
+2011-03-10 Richard Henderson + + PR 47952 + * cp-demangle.c (cplus_demangle_fill_ctor): Accept + gnu_v3_object_ctor_group. + (cplus_demangle_fill_dtor): Accept gnu_v3_object_dtor_group. + (d_ctor_dtor_name): Recognize gnu_v3_object_ctor_group + and gnu_v3_o

Re: PR c++/30195

2011-11-03 Thread Jason Merrill
On 11/02/2011 05:04 PM, Fabien Chêne wrote: Consequently, I think the current patch is not good enough without that. Would you be OK with the changes suggested above ? Sounds good. Jason

[patch] 8c/n: trans-mem: toplevel/misc changes (include/)

2011-11-03 Thread Aldy Hernandez
2011-03-10 Richard Henderson * demangle.h (enum gnu_v3_ctor_kinds): Add gnu_v3_object_ctor_group. (enum gnu_v3_dtor_kinds): Add gnu_v3_object_dtor_group. 2008-11-05 Richard Henderson * demangle.h (DEMANGLE_COMPONENT_TRANSACTION_CLONE): New. (DEMANGLE_COMP

[patch] 8d/n: trans-mem: toplevel/misc changes (configury/makefile/config)

2011-11-03 Thread Aldy Hernandez
Index: ChangeLog.tm === --- ChangeLog.tm(.../trunk) (revision 0) +++ ChangeLog.tm(.../branches/transactional-memory) (revision 180773) @@ -0,0 +1,89 @@ +2011-11-02 Aldy Hernandez + + * Merge from main

Re: RFA: Add Epiphany port

2011-11-03 Thread Andrew Pinski
On Thu, Nov 3, 2011 at 11:08 AM, Joern Rennecke wrote: > +@smallexample > +float __builtin_epiphany_fmadd (float a, float b, float c) /* a + b * c */ > +float __builtin_epiphany_fmsub (float a, float b, float c) /* a - b * c */ > +@end smallexample I don't think you need target specific builtins

[patch] 11/n: trans-mem: compiler tests (2 of 3)

2011-11-03 Thread Aldy Hernandez
Index: gcc/testsuite/g++.dg/tm/wrap-2.C === --- gcc/testsuite/g++.dg/tm/wrap-2.C(.../trunk) (revision 0) +++ gcc/testsuite/g++.dg/tm/wrap-2.C (.../branches/transactional-memory) (revision 180773) @@ -0,0 +1,16 @@ +/* { dg-do

Re: Massive breakage with your libgcc patches

2011-11-03 Thread Bernd Schmidt
On 11/03/11 19:12, Rainer Orth wrote: > Bernd Schmidt writes: > > [Trimming the Cc: list.] > >> On 11/03/11 18:01, Rainer Orth wrote: >>> Bernd Schmidt writes: A cross environment for -elf targets typicaly just requires building up binutils/newlib, and that should be rather quick to s

  1   2   >