Re: mt-mep using EXTRA_TARGET_HOST_ALL_MODULES?

2011-03-24 Thread Joseph S. Myers
On Thu, 24 Mar 2011, Paolo Bonzini wrote: > Is this actually desired? And what's all-utils? Can we just kill mt-mep? utils at least exists in the src tree. One thing I wonder is if we can kill the toplevel support for building lots of miscellaneous tools that aren't in the gcc or src trees a

Re: [patch i386 windows]: Introduce call-abi for 32-bit mingw and make callee_pop_aggregate_return attribute by default on for 32-bit mingw target

2011-03-24 Thread Kai Tietz
2011/3/24 Kai Tietz : > Hi, > > this patch introduces for windows 32-bit target also the call-abi > specifiers (ms_abi/sys_v) and set its default for this target to > "ms_abi".  This patch set the default of the > "callee_pop_aggregate_return" attribute to true for MS_ABI call-abi on > 32-bit.  Add

[toplevel] Target fragments cleanups

2011-03-24 Thread Paolo Bonzini
EXTRA_TARGET_HOST_* has been obsolete for years, GDB_NLM_DEPS was touched exactly once in 1995, and mt-v810 has no references. Committed to gcc and src. Paolo 2011-03-24 Paolo Bonzini * configure.ac: Remove references to mt-mep, mt-netware, mt-wince. * Makefile.def:

Re: [libgo] Support Solaris 8/9

2011-03-24 Thread Ian Lance Taylor
Rainer Orth writes: > FAIL: image/png > Can't open -n > grep: can't open -n > grep: can't open -n > --- FAIL: png.TestReader (1.0 seconds) > basn0g01-30 open testdata/pngsuite/basn0g01-30.png: No such file or > directory > basn0g02-29 open testdata/pngsuite/basn0g02-29.png: No such f

Re: [libgo] Support Solaris 8/9

2011-03-24 Thread Rainer Orth
Ian Lance Taylor writes: > Just a quick note that I committed patches yesterday which should fix at > least some of those problems. I failed to commit some of the test data > the last time I updated the library. Fine, I'll give it another try tonight or over the weekend. Rainer -- --

Re: mt-mep using EXTRA_TARGET_HOST_ALL_MODULES?

2011-03-24 Thread Paolo Bonzini
On 03/24/2011 06:43 PM, Joseph S. Myers wrote: On Thu, 24 Mar 2011, Paolo Bonzini wrote: Is this actually desired? And what's all-utils? Can we just kill mt-mep? utils at least exists in the src tree. Indeed I didn't know about it. :) However it's not necessary to add it specially nowad

Re: [PATCH, 4.7] Have all inlining destinations "analyzed"

2011-03-24 Thread Martin Jambor
Ping. Thanks, Martin -- On Sat, Mar 19, 2011 at 01:48:36AM +0100, Martin Jambor wrote: Hi, On Fri, Mar 11, 2011 at 03:30:53PM +0100, Jan Hubicka wrote: > > Index: src/gcc/cgraph.c > > ==

Re: mt-mep using EXTRA_TARGET_HOST_ALL_MODULES?

2011-03-24 Thread Joseph S. Myers
On Thu, 24 Mar 2011, Paolo Bonzini wrote: > > One thing I wonder is if we can > > kill the toplevel support for building lots of miscellaneous tools that > > aren't in the gcc or src trees and that aren't libraries used by tools in > > those trees (such as the support for dropping a GMP source tre

Re: [patch middle-end c c++]: Optimize cost of comp_type_attributes

2011-03-24 Thread Kai Tietz
2011/3/24 Kai Tietz : > 2011/3/24 Jason Merrill : >> On 03/24/2011 06:06 PM, Kai Tietz wrote: >>> >>> +/* Compare two attributes for identity.  Return true if the attributes >>> +   are known to be equal; otherwise return false.  */ >>> + >>> +static bool >>> +attribute_equal (const_tree attr1, con

Re: Remove old host cases from toplevel configure

2011-03-24 Thread Joseph S. Myers
On Thu, 24 Mar 2011, Joseph S. Myers wrote: > Furthermore, the whole idea of the toplevel configure tentative_cc > setting code is dubious since this is an autoconf-generated script and > it's autoconf's job to deal with finding a working compiler, putting > it in ANSI C mode, etc. - so if someone

Re: [cxx-mem-model] disallow load data races (1 of some)

2011-03-24 Thread Richard Henderson
On 03/24/2011 10:33 AM, Aldy Hernandez wrote: > In the example below we usually hoist "global" into a register or > temporary to avoid reading from it at each step. This would cause a > race if another thread had modified "global" in between iterations. > > for (x=0; x< 5; x++) > sum[x

Re: [RFC PATCH, i386]: ICE: in final_scan_insn due to late split

2011-03-24 Thread Rainer Orth
Uros Bizjak writes: > 2011-03-23 Uros Bizjak > > PR target/48237 > * config/i386/i386.md (*movdf_internal_rex64): Do not split > alternatives that can be handled with movq or movabsq insn. > (*movdf_internal): Disable for !TARGET_64BIT. > (*movdf_internal_nointege

More toplevel configure.ac pruning

2011-03-24 Thread Joseph S. Myers
This toplevel configure patch continues pruning useless or incorrect code, generally specific to particular hosts or targets. * There are mentions of target-groff, target-librx and tix, but these are useless as they are not in Makefile.def, so they can safely be removed. * libmudflap is disab

Re: [debug] dwarf2out emits unnecessary null byte in empty .debug_abbrev section

2011-03-24 Thread Richard Henderson
On 03/24/2011 09:26 AM, Mark Wielaard wrote: >/* Terminate the table. */ > - dw2_asm_output_data (1, 0, NULL); > + if (abbrev_die_table_in_use > 1) > +dw2_asm_output_data (1, 0, NULL); I'd prefer this to be handled by if (abbrev_die_table_in_use == 0) return; at the beginning o

Re: [PATCH] Fix PR 48144

2011-03-24 Thread Vladimir Makarov
On 03/24/2011 06:50 AM, Andrey Belevantsev wrote: Hello, As noted in the PR audit trail, this is a case when we fail to find a transformed insn due to incomplete transformation history attached to it. The earlier fixes of this issue worked only for bookkeeping copies, but now we need a more g

Re: [debug] Remove deprecated DW_FORM_sig8 define

2011-03-24 Thread Richard Henderson
On 03/24/2011 08:30 AM, Mark Wielaard wrote: > 2010-03-24 Mark Wielaard > > * dwarf2.h (dwarf_form): Remove deprecated DW_FORM_sig8 define. > > 2011-03-24 Mark Wielaard > > * dwarf2out.c (size_of_die): Modify comment to say DW_FORM_ref_sig8. > (value_format): Use DW_FORM_ref_si

Re: [patch] Do not generate useless branches for multi-word comparison

2011-03-24 Thread Richard Henderson
On 03/24/2011 07:38 AM, Eric Botcazou wrote: > + /* Deal with the special case 0 > x: only one comparison is necessary and > + we reverse it to avoid jumping to the drop-through label. */ > + if (op0 == const0_rtx && drop_through_if_true && !drop_through_if_false) > +{ > + code = LE

Re: [PATCH] use cfglayout mode for instatiate_virtual_regs

2011-03-24 Thread Richard Henderson
On 03/24/2011 04:47 AM, Nathan Froyd wrote: > * function.c (instantiate_virtual_regs): Use FOR_EACH_BB and > FOR_BB_INSNS_SAFE to iterate through insns. Re-indent. > * passes.c (init_optimization_passes): Move > pass_instantiate_virtual_regs after pass_into_cfg_layout_mode.

Re: [RFC PATCH, i386]: ICE: in final_scan_insn due to late split

2011-03-24 Thread Uros Bizjak
On Thu, Mar 24, 2011 at 8:59 PM, Rainer Orth wrote: > Uros Bizjak writes: > >> 2011-03-23  Uros Bizjak   >> >>       PR target/48237 >>       * config/i386/i386.md (*movdf_internal_rex64): Do not split >>       alternatives that can be handled with movq or movabsq insn. >>       (*movdf_internal)

Re: [debug] dwarf2out emits unnecessary null byte in empty .debug_abbrev section

2011-03-24 Thread Mark Wielaard
> >/* Terminate the table. */ > > - dw2_asm_output_data (1, 0, NULL); > > + if (abbrev_die_table_in_use > 1) > > + dw2_asm_output_data (1, 0, NULL); > > I'd prefer this to be handled by > > if (abbrev_die_table_in_use == 0) > return; > > at the beginning of the function. > > Ok with that ch

Re: [cxx-mem-model] disallow load data races (1 of some)

2011-03-24 Thread Aldy Hernandez
On 03/24/11 14:58, Richard Henderson wrote: On 03/24/2011 10:33 AM, Aldy Hernandez wrote: In the example below we usually hoist "global" into a register or temporary to avoid reading from it at each step. This would cause a race if another thread had modified "global" in between iterations.

Re: [google] Port lock annotations/analysis to google/main branch (issue4275075)

2011-03-24 Thread Diego Novillo
On Thu, Mar 24, 2011 at 15:30, Le-Chun Wu wrote: > 2011-03-24  Le-Chun Wu   > >        * Makefile.in: Add new source file and headers in dependencies. >        * attribs.c (decl_attributes): Handle lock attributes. >        (is_lock_attribute_with_args): New function. >        (is_lock_attribute_

Re: [cxx-mem-model] disallow load data races (1 of some)

2011-03-24 Thread Joseph S. Myers
On Thu, 24 Mar 2011, Aldy Hernandez wrote: > This work is independent of the C++ memory model. It is just to prevent the > optimizers from introducing new data races due to code movement. This initial > pass is just to make the optimizations data race safe so that if you have a > program which is

More fixes from static analysis checkers

2011-03-24 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 We had a variety of functions which would fail to call va_end prior to returning. I'm not aware of a host were this could cause a problem, but it's easy enough to fix and keeps the checkers quiet. Bootstrapped and regression tested on x86_64-unknown

Re: More fixes from static analysis checkers

2011-03-24 Thread Diego Novillo
On Thu, Mar 24, 2011 at 17:52, Jeff Law wrote: > Bootstrapped and regression tested on x86_64-unknown-linux-gnu.  OK for > trunk? OK. Diego.

Re: [google] Port lock annotations/analysis to google/main branch (issue4275075)

2011-03-24 Thread lcwu
Could you also update http://gcc.gnu.org/wiki/ThreadSafetyAnnotation? It still points to the old branch and seems to have stale content. Will do. Any plans for mainline merge? I don't actually have a time frame for that, but that is the ultimate goal. http://codereview.appspot.com/427507

Re: [toplevel] cleanup mh-cygwin

2011-03-24 Thread Dave Korn
On 24/03/2011 17:11, Paolo Bonzini wrote: > The cygwin host fragment is using obsolete variables and constructs, > modernize it. > > Committed to gcc and (shortly) src. Thanks, top-level stuff is a bit of a mystery to me :) cheers, DaveK

Re: [debug] dwarf2out emits unnecessary null byte in empty .debug_abbrev section

2011-03-24 Thread Richard Henderson
On 03/24/2011 01:54 PM, Mark Wielaard wrote: > + if (abbrev_die_table_in_use == 1) > +return; > + >for (abbrev_id = 1; abbrev_id < abbrev_die_table_in_use; ++abbrev_id) > { >dw_die_ref abbrev = abbrev_die_table[abbrev_id]; > > Still OK? Yes. r~

libgo patch committed: Update to current version of Go library

2011-03-24 Thread Ian Lance Taylor
I've committed a patch to libgo to update to the current version of the master Go library. The patch is too large to include here, and is in any case simply a copy of changes available in the master Go library repository. See SVN or http://codereview.appspot.com/4281068/ for the changes as applie

Re: [cxx-mem-model] disallow load data races (1 of some)

2011-03-24 Thread Andrew MacLeod
On Thu, 24 Mar 2011, Aldy Hernandez wrote: This work is independent of the C++ memory model. It is just to prevent the optimizers from introducing new data races due to code movement. This initial pass is just to make the optimizations data race safe so that if you have a program which is prove

Re: [4.7] Avoid global state in sparc_handle_option

2011-03-24 Thread Joseph S. Myers
On Thu, 17 Mar 2011, Eric Botcazou wrote: > > 2011-03-13 Joseph Myers > > > > * config/sparc/sparc-opts.h: New. > > Do you really need all the dates in there? They were the dates on sparc.h from which this file was split out. This version uses only the dates of the revisions shown by "s

[alpha] Revert input_operand change for vms

2011-03-24 Thread Richard Henderson
While purging Windows code, I failed to remember that VMS has a 32-bit mode as well, and thus this line still matters. r~ diff --git a/gcc/config/alpha/alpha.md b/gcc/config/alpha/alpha.md index 38d40b5..abd96c7 100644 --- a/gcc/config/alpha/alpha.md +++ b/gcc/config/alpha/alpha.md @@ -177,6 +177

[alpha] Unify zero_extend patterns with attribute enabled

2011-03-24 Thread Richard Henderson
The attribute enabled feature can help avoid quite a lot of duplication in the alpha backend. This begins the process by tackling the easiest -- zero_extension, conditionalized on the existance of the BWX instruction set extension. Tested on alpha{,ev5,ev56,ev67}-linux. r~ + * config/alp

[alpha] cleanup sign_extension patterns

2011-03-24 Thread Richard Henderson
We don't get a chance to use attribute enabled here, but we can eliminate some unnecessary expanders. The non-BWX expansion paths wound up subregging the input to DImode to perform the operation and subregging it back. Exactly as the generic code paths would do. I didn't investigate what elimin

[alpha] Unify most move patterns with attribute enabled

2011-03-24 Thread Richard Henderson
This handles everything except movdi, which is more complex. One perhaps non-obvious thing is the use of the ABI as an "isa" entry with respect to the loading of an address constant. This appears in movsi for VMS. This turns out to be significantly easier than using two different attributes to c

[alpha] Unify movdi with attribute enabled.

2011-03-24 Thread Richard Henderson
This handles the movdi pattern, of which there were four copies... r~ + * config/alpha/alpha.md (attribute isa): Add er, ner. + (attribute enabled): Handle them. + (*movdi): Merge *movdi_{er_nofix,nofix,er_fix,fix}. diff --git a/gcc/config/alpha/alpha.md b/gcc/config/alpha/alp

[alpha] Tidy some byte manipulation users.

2011-03-24 Thread Richard Henderson
We have helper expanders -- originally for the builtins -- so that we can write mskwh instead of mskxh-plus-magic-argument. Use them more often. r~ + * config/alpha/alpha.c (alpha_expand_unaligned_load): Use extql. + (alpha_expand_unaligned_store): Use mskwl, mskll, mskql. + (a

Re: [alpha] Revert input_operand change for vms

2011-03-24 Thread Richard Henderson
On 03/24/2011 05:06 PM, Richard Henderson wrote: > While purging Windows code, I failed to remember that VMS has a 32-bit > mode as well, and thus this line still matters. Bah. This patch, not the other one. r~ commit 3351cef043c126925829c9b414a087251dc67e45 Author: rth Date: Fri Mar 25 00:0

Re: [PATCH] use cfglayout mode for instatiate_virtual_regs

2011-03-24 Thread H.J. Lu
On Thu, Mar 24, 2011 at 4:47 AM, Nathan Froyd wrote: > As $SUBJECT suggests.  The patch looks much bigger than it actually is > due to re-indentation. > > Tested on x86_64-unknown-linux-gnu.  OK to commit? > > -Nathan > >        * function.c (instantiate_virtual_regs): Use FOR_EACH_BB and >      

Go patch committed: Remove closed function

2011-03-24 Thread Ian Lance Taylor
The predeclared function "closed" has been removed from the Go language, as it is no longer necessary now that v, ok = <-c returns whether the channel is closed. This patch implements that in gccgo. This patch also fixes the handling of case v, ok := <-c in a select statement. Bootstrapped and ra

Re: [PATCH] use cfglayout mode for instatiate_virtual_regs

2011-03-24 Thread H.J. Lu
On Thu, Mar 24, 2011 at 9:11 PM, H.J. Lu wrote: > On Thu, Mar 24, 2011 at 4:47 AM, Nathan Froyd > wrote: >> As $SUBJECT suggests.  The patch looks much bigger than it actually is >> due to re-indentation. >> >> Tested on x86_64-unknown-linux-gnu.  OK to commit? Did you run -m32 tests on Linux/x

<    1   2